date:20190512

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Bruce Anderson

andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  In D20930#464412 , @jgrulich wrote:
  
  > In D20930#464403 , 
@andersonbruce wrote:
  >
  > > In D20930#464387 , @jgrulich 
wrote:
  > >
  > > > In D20930#464384 , @jgrulich 
wrote:
  > > >
  > > > > In D20930#464377 , 
@andersonbruce wrote:
  > > > >
  > > > > > Updated SecretAgent class to always try to get the secrets from 
kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses 
are 43 random characters long and we don't expect the user to enter these 
manually when trying to make a connection. If data is not available in kwallet 
then trying to make a connection will fail. Also updated the configuration 
screens to not allow a configuration with "AlwaysAsk" flags on either key.
  > > > >
  > > > >
  > > > > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  > > >
  > > >
  > > > Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).
  > >
  > >
  > > Great!  Should I make the change in this review? If so, what is the 
correct procedure (with git, arc, ...) to merge that change into this review?
  >
  >
  > Should be enough just to merge current master into your branch I guess.
  
  
  Isn't  'arc diff' going to try to include the differences between the master 
I originally checked out and the merged current master as changes in the 
WireGuard review then?  Sorry if these are stupid questions, I'm not a git 
expert and I just don't want to mess things up.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Jan Grulich

jgrulich added a comment.


  In D20930#464403 , @andersonbruce 
wrote:
  
  > In D20930#464387 , @jgrulich 
wrote:
  >
  > > In D20930#464384 , @jgrulich 
wrote:
  > >
  > > > In D20930#464377 , 
@andersonbruce wrote:
  > > >
  > > > > Updated SecretAgent class to always try to get the secrets from 
kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses 
are 43 random characters long and we don't expect the user to enter these 
manually when trying to make a connection. If data is not available in kwallet 
then trying to make a connection will fail. Also updated the configuration 
screens to not allow a configuration with "AlwaysAsk" flags on either key.
  > > >
  > > >
  > > > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  > >
  > >
  > > Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).
  >
  >
  > Great!  Should I make the change in this review? If so, what is the correct 
procedure (with git, arc, ...) to merge that change into this review?
  
  
  Should be enough just to merge current master into your branch I guess.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21167: Add Messages.sh

2019-05-12 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:71dbe70d2c15: Add Messages.sh (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21167?vs=57945&id=57977

REVISION DETAIL
  https://phabricator.kde.org/D21167

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/Messages.sh

To: broulik, #plasma, kde-i18n-doc, aacid, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21165: [Notifications] When un-dismissing job hide plasmoid popup

2019-05-12 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d0a0a007746: [Notifications] When un-dismissing job hide 
plasmoid popup (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21165?vs=57943&id=57976

REVISION DETAIL
  https://phabricator.kde.org/D21165

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21137: [Notifications] Rename device name to origin name

2019-05-12 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9d0f3b37fcb8: [Notifications] Rename device name to 
origin name (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21137?vs=57891&id=57975

REVISION DETAIL
  https://phabricator.kde.org/D21137

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/server_p.cpp

To: broulik, #plasma, nicolasfella, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Bruce Anderson

andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  
  
  In D20930#464387 , @jgrulich wrote:
  
  > In D20930#464384 , @jgrulich 
wrote:
  >
  > > In D20930#464377 , 
@andersonbruce wrote:
  > >
  > > > Updated SecretAgent class to always try to get the secrets from kwallet 
even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 
random characters long and we don't expect the user to enter these manually 
when trying to make a connection. If data is not available in kwallet then 
trying to make a connection will fail. Also updated the configuration screens 
to not allow a configuration with "AlwaysAsk" flags on either key.
  > >
  > >
  > > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  >
  >
  > Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).
  
  
  Great!  Should I make the change in this review? If so, what is the correct 
procedure (with git, arc, ...) to merge that change into this review?

INLINE COMMENTS

> jgrulich wrote in secretagent.cpp:432
> Shouldn't it be
> 
>   (isVpn && !isWireguard) && allowInteraction
> 
> You don't want to display password dialog in case it's a WG connection.
> 
> Or maybe it should stay and instead we should return true and send error 
> (like we do when a dialog has an error) if it's a WG connection, to let 
> NetworkManager know we cannot handle that.

Actually what I did is move the WireGuard handling above this 'else if' so it 
shouldn't get to this point if it is WireGuard so I simply returned the logic 
to what it was originally.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21176: PanelView: update mask on window on change of panelMask property

2019-05-12 Thread Friedrich W. H. Kossebau

kossebau updated this revision to Diff 57974.
kossebau added a comment.


  keep old code for KF 5.58 compat

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21176?vs=57965&id=57974

BRANCH
  updatepanelmaskonchange

REVISION DETAIL
  https://phabricator.kde.org/D21176

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Bruce Anderson

andersonbruce updated this revision to Diff 57972.
andersonbruce added a comment.


  - Return non-WireGuard logic to original state

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57970&id=57972

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Jan Grulich

jgrulich added a comment.


  In D20930#464384 , @jgrulich wrote:
  
  > In D20930#464377 , 
@andersonbruce wrote:
  >
  > > Updated SecretAgent class to always try to get the secrets from kwallet 
even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 
random characters long and we don't expect the user to enter these manually 
when trying to make a connection. If data is not available in kwallet then 
trying to make a connection will fail. Also updated the configuration screens 
to not allow a configuration with "AlwaysAsk" flags on either key.
  >
  >
  > You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).
  
  
  Sorry, that's not it, I added a new option to do that, you can now use 
PasswordField::setPasswordNotSavedEnabled(false).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Jan Grulich

jgrulich added inline comments.

INLINE COMMENTS

> secretagent.cpp:432
> +return true;
> +} else if (requestNew || (allowInteraction && 
> !setting->needSecrets(requestNew).isEmpty()) || (allowInteraction && 
> userRequested) || ((isVpn || isWireGuard) && allowInteraction)) {
> +

Shouldn't it be

  (isVpn && !isWireguard) && allowInteraction

You don't want to display password dialog in case it's a WG connection.

Or maybe it should stay and instead we should return true and send error (like 
we do when a dialog has an error) if it's a WG connection, to let 
NetworkManager know we cannot handle that.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21164: Replace QUrl::fromUserInput by lighter heuristic

2019-05-12 Thread Kai Uwe Broulik

broulik added a comment.


  In D21164#464287 , @apol wrote:
  
  > https://doc.qt.io/qt-5/qurl.html#UrlFormattingOption-enum
  >
  > How about using QUrl::toDisplayString(QUrl::PreferLocalFile)?
  
  
  That won't make a difference as it always creates a `QFileInfo`: 
https://code.woboq.org/qt5/qtbase/src/corelib/io/qurl.cpp.html#_ZN4QUrl13fromUserInputERK7QStringS2_6QFlagsINS_25UserInputResolutionOptionEE

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21164

To: broulik, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Jan Grulich

jgrulich added a comment.


  In D20930#464377 , @andersonbruce 
wrote:
  
  > Updated SecretAgent class to always try to get the secrets from kwallet 
even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 
random characters long and we don't expect the user to enter these manually 
when trying to make a connection. If data is not available in kwallet then 
trying to make a connection will fail. Also updated the configuration screens 
to not allow a configuration with "AlwaysAsk" flags on either key.
  
  
  You can disable "AlwaysAsk" option with 
PasswordField::setPasswordNotRequiredEnabled(false).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21111: Added new option to use GlobalProtect with openconnect

2019-05-12 Thread Jan Grulich

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:dfbcf8b18a4b: Added new option to use GlobalProtect with 
openconnect (authored by avaldes, committed by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2?vs=57861&id=57971

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectprop.ui
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop

To: avaldes, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

2019-05-12 Thread Nathaniel Graham

ngraham added a comment.


  This thing's UI really needs to be rewritten in QML. Once we do that and give 
it a proper FormLayout style, the string can be shorter, but for now, seeing it 
in context, I feel like  the string should be "Hibernate after 3 hours of 
sleep".
  
  Also I wouldn't mind making the period configurable. If you don't want to do 
that in this patch though, that's fine.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: meven, soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Bruce Anderson

andersonbruce added a comment.


  Updated SecretAgent class to always try to get the secrets from kwallet even 
if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random 
characters long and we don't expect the user to enter these manually when 
trying to make a connection. If data is not available in kwallet then trying to 
make a connection will fail. Also updated the configuration screens to not 
allow a configuration with "AlwaysAsk" flags on either key.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Bruce Anderson

andersonbruce updated this revision to Diff 57970.
andersonbruce added a comment.


  - Don't allow save of configuration with "AlwaysAsk" flag for keys

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57969&id=57970

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Bruce Anderson

andersonbruce updated this revision to Diff 57969.
andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  - Always get encrypted data from kwallet
  
  Don't ask user for key values.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57888&id=57969

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerwidget.ui
  libs/editor/settings/ui/wireguardtabwidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/settings/wireguardpeerwidget.h
  libs/editor/settings/wireguardtabwidget.cpp
  libs/editor/settings/wireguardtabwidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21176: PanelView: update mask on window on change of panelMask property

2019-05-12 Thread Friedrich W. H. Kossebau

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  updatepanelmaskonchange

REVISION DETAIL
  https://phabricator.kde.org/D21176

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21164: Replace QUrl::fromUserInput by lighter heuristic

2019-05-12 Thread Aleix Pol Gonzalez

apol added a comment.


  https://doc.qt.io/qt-5/qurl.html#UrlFormattingOption-enum
  
  How about using QUrl::toDisplayString(QUrl::PreferLocalFile)?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21164

To: broulik, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21167: Add Messages.sh

2019-05-12 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, kde-i18n-doc, aacid.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There's a few translatable strings in libnotificationmanager

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21167

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/Messages.sh

To: broulik, #plasma, kde-i18n-doc, aacid
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21131: ScrollBar: Make it work as a horizontal scroll bar as well

2019-05-12 Thread Nathaniel Graham

ngraham added a comment.


  In fact, all QML KCMs now crash. See 
https://bugs.kde.org/show_bug.cgi?id=407446.
  
  Reverting this patch fixes the issue. However I suspect that this patch isn't 
the root cause and only exposed a deeper issue. Thoughts on how to proceed? We 
need to make sure this is fixed in some way before 5.59 is tagged, obviously.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21131

To: apol, #kirigami, mart, ngraham
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21153: [Notifications KCM] Hack scroll bar not crashing

2019-05-12 Thread Nathaniel Graham

ngraham added a comment.


  Since the bug seems to cause all the QML KCMs to crash, it seems like maybe 
we should fix it at a lower level rather than putting hacks in the client code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21153

To: broulik, #plasma
Cc: ngraham, odeda, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21134: [Notifications] Tweak paddings

2019-05-12 Thread Sebastian Krzyszkowiak

dos added a comment.


  In D21134#464175 , @broulik wrote:
  
  > In D21134#464005 , @dos wrote:
  >
  > > To anyone playing with those paddings: please note, that until T8177 
 is fixed, on X11 with hidpi screens you 
need to run Plasma with `PLASMA_USE_QT_SCALING=1` env variable, as otherwise 
the font sizes are disproportionate to other UI elements.
  >
  >
  > Don't do that on X, it causes all kinds of problems.
  
  
  I think you meant "don't forget to switch it back afterwards", as it's 
literally the only way to get correct paddings on X11 with hidpi.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: cfeck, dos, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21134: [Notifications] Tweak paddings

2019-05-12 Thread Kai Uwe Broulik

broulik added a comment.


  In D21134#464005 , @dos wrote:
  
  > To anyone playing with those paddings: please note, that until T8177 
 is fixed, on X11 with hidpi screens you 
need to run Plasma with `PLASMA_USE_QT_SCALING=1` env variable, as otherwise 
the font sizes are disproportionate to other UI elements.
  
  
  Don't do that on X, it causes all kinds of problems.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: cfeck, dos, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21165: [Notifications] When un-dismissing job hide plasmoid popup

2019-05-12 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - Started a copy, clicked the triangle to hide it, opened notification 
history, clicked button to expand job. Job popup showed again and plasmoid 
closed now instead of annoyingly staying open

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21165

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21164: Replace QUrl::fromUserInput by lighter heuristic

2019-05-12 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I just found that `QUrl::fromLocalFile()` actually calls `QFileInfo::exists` 
on the URL which is not something you want to be doing constantly and 
especially not for remote locations.
  The code is really just trying to figure out a URL from the source or 
destination labels of the job which are usually either a full URL or just a 
local path. If it's not, then it's probably not very interesting to us anyway.

TEST PLAN
  - No longer have plasmashell creeping to a halt when copying stuff from my 
phone (using sshfs mounted by kdeconnect, ie a "local" path but actually 
remote) to my PC
  
  This code is really just trying to guess whether the descriptions of the job 
have any sort of path / filename in it, so replace it by a lighter guessing 
logic.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21164

AFFECTED FILES
  libnotificationmanager/job_p.cpp
  libnotificationmanager/job_p.h

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21147: Null pointer dereference at ksysguard

2019-05-12 Thread George Karagiannidis

gkaragiannidis marked an inline comment as done.
gkaragiannidis added a comment.


  Yes it would read better indeed.
  I don't know the procedure though; should I do anything?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21147

To: gkaragiannidis
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D21111: Added new option to use GlobalProtect with openconnect

2019-05-12 Thread Alejandro Valdes

avaldes added a comment.


  I can't land it, please merge @jgrulich

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  globalprotect (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2

To: avaldes, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

2019-05-12 Thread Atul Bisht

atulbi updated this revision to Diff 57933.
atulbi added a comment.


  - lmr mapping working now

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57923&id=57933

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

2019-05-12 Thread Jan Grulich

jgrulich added inline comments.

INLINE COMMENTS

> andersonbruce wrote in connectionicon.cpp:403
> There is still a discrepancy between the enum defined by NetworkManager and 
> the one defined by NMQT.  NetworkManager is returning a value of 29 but 
> NetworkManager::Device::WireGuard has a value of 30.

This is correct, we are unfortunately +1 because back then there was a device 
which we add support for and later during the NM development cycle it was 
renamed and I couldn't just simply rename or remove an enum, because it would 
break ABI. You can see in NMQT that there is code converting NM  device type to 
NMQT device type so we this coverd.

> andersonbruce wrote in wireguardpeerwidget.cpp:52
> SimpleIpV4AddressValidator and SimpleIpV6AddressValidator were intentionally 
> done this way because they were existing functions that I didn't want to 
> break when I added new (defaulted) parameters for use in with WireGuard 
> functionality.
> 
> Since changing these two will involve changes to non-WireGuard code and it 
> makes sense to do them all at the same time, can we write this up as a 
> separate Bug?

Ok, we can do that in a separate review.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21134: [Notifications] Tweak paddings

2019-05-12 Thread Christoph Feck

cfeck added inline comments.

INLINE COMMENTS

> NotificationItem.qml:74
>  
> -property int headingLeftPadding: 0
> +property int headingLeftPadding: units.smallSpacing
>  property int headingRightPadding: 0

Does this take into account layouts for RTL languages?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: cfeck, dos, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21134: [Notifications] Tweak paddings

2019-05-12 Thread Sebastian Krzyszkowiak

dos added a comment.


  To anyone playing with those paddings: please note, that until T8177 
 is fixed, on X11 with hidpi screens you 
need to run Plasma with `PLASMA_USE_QT_SCALING=1` env variable, as otherwise 
the font sizes are disproportionate to other UI elements.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: dos, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21153: [Notifications KCM] Hack scroll bar not crashing

2019-05-12 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For some reason since the `WheelHandler` rewrite the `position` of the 
horizontal scroll bar is `NaN` leading to all sorts of odd behavior and now 
even crashes.
  
  BUG: 407446

TEST PLAN
  It's been broken for weeks with nobody caring but only started crashing with 
f7f99e8b8ca42c1036db4c25ce0488df2046b6a9 
 
where an `SIGFPE` is raised in `QCommonStyle` as a result of this.
  
  - Opened KCM, opened configure page, now no longer crashes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21153

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21131: ScrollBar: Make it work as a horizontal scroll bar as well

2019-05-12 Thread Kai Uwe Broulik

broulik added a comment.


  I have a `ListView` inside a `ScrollView` [1] but for some reason 
`controlRoot.position` is `NaN` and then it ends up raising a `SIGFPE` in 
`QCommonStyle`. I don't understand why the position is bollocks, though.
  
  [1] 
https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n82

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21131

To: apol, #kirigami, mart, ngraham
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

2019-05-12 Thread Atul Bisht

atulbi updated this revision to Diff 57923.
atulbi added a comment.


  - Added Copyright notice
  - Corrected asterisk placement

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=57521&id=57923

BRANCH
  arcpatch-D20186

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/src/kcm/touchpadconfigplugin.h
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.cpp
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21131: ScrollBar: Make it work as a horizontal scroll bar as well

2019-05-12 Thread Kai Uwe Broulik

broulik added a comment.


  This patch causes the new notification KCM to crash, see Bug 407446

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21131

To: apol, #kirigami, mart, ngraham
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21152: [Notifications] Fix oversight of not taking into account screen X when placing notifications on the right side of the screen

2019-05-12 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, hein, lbeltrame.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - Fixes left panel messing with the popup position on the right, noticed by 
@hein
  - Probably also fixes multi screen placement noticed by @lbeltrame

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21152

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, hein, lbeltrame
Cc: lbeltrame, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

2019-05-12 Thread Atul Bisht

atulbi added inline comments.

INLINE COMMENTS

> romangg wrote in libinputtouchpad.h:57
> Why is there the negation? Put the Enabled-related function in the parent 
> class.

X provides property for the disabled, while Wayland provides property for 
enabled.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

38 matches

Mail list logo