D21268: Add missing includes

2019-05-17 Thread Michael Palimaka 
palimaka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
palimaka requested review of this revision.

REVISION SUMMARY
  These includes aren't always available transitively, so
  include them explicitly to avoid build failure.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21268

AFFECTED FILES
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardpeerwidget.cpp

To: palimaka, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21239: Port knsbackendtest to ecm_add_test

2019-05-17 Thread Michael Palimaka 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:03653a7d75ba: Port knsbackendtest to ecm_add_test 
(authored by palimaka).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21239?vs=58159=58233

REVISION DETAIL
  https://phabricator.kde.org/D21239

AFFECTED FILES
  libdiscover/backends/KNSBackend/tests/CMakeLists.txt

To: palimaka, #plasma, apol
Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

2019-05-17 Thread ivan tkachenko 
ratijastk added a comment.


  Bump (again)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21147: Null pointer dereference at ksysguard

2019-05-17 Thread George Karagiannidis 
gkaragiannidis updated this revision to Diff 58214.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21147?vs=57914=58214

REVISION DETAIL
  https://phabricator.kde.org/D21147

AFFECTED FILES
  ksysguardd/conf.c

To: gkaragiannidis
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21257: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:ce0dd71daa86: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21257?vs=58204=58213

REVISION DETAIL
  https://phabricator.kde.org/D21257

AFFECTED FILES
  gui/CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21259: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:d9eb33df36b0: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21259?vs=58206=58211

REVISION DETAIL
  https://phabricator.kde.org/D21259

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21256: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:268ed1db19d5: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21256?vs=58203=58210

REVISION DETAIL
  https://phabricator.kde.org/D21256

AFFECTED FILES
  applets/comic/CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21257: Move knsrc files to the new location

2019-05-17 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21257

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21259: Move knsrc files to the new location

2019-05-17 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21259

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21255: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:041a9b08d5f4: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21255?vs=58201=58208

REVISION DETAIL
  https://phabricator.kde.org/D21255

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21259: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21259

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21257: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21257

AFFECTED FILES
  gui/CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21256: Move knsrc files to the new location

2019-05-17 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21256

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21256: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21256

AFFECTED FILES
  applets/comic/CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21255: Move knsrc files to the new location

2019-05-17 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D21255

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21255: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D21255

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

2019-05-17 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  We just branched 5.16, so this will be 5.17 material. That should leave lots 
of time for testing. Would also be nice to get a review from @broulik once he 
returns from vacation or anyone else in #plasma 
.
  
  Can you land the patch yourself or do you need someone else to do it for you?

INLINE COMMENTS

> powerdevilpowermanagement.cpp:207
> +{
> +if(!d->serviceRegistered) {
> +return;

space after `if`

> powerdevilpowermanagement.cpp:210
> +}
> +if(!d->canSuspendThenHibernate) {
> +return;

space after `if`

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: reverendhomer, meven, soriano, abalaji, graesslin, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

2019-05-17 Thread Friedrich W. H. Kossebau 
kossebau abandoned this revision.
kossebau added a comment.


  There is no agreement that splitting off a separate category is the way to 
move forward, so discarding.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20898

To: kossebau, #plasma, apol, leinir, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21246: Search also legacy location for knsrc files

2019-05-17 Thread Dan Leinir Turthra Jensen 
leinir added a comment.


  In D21246#466158 , @arojas wrote:
  
  > OK I see in https://phabricator.kde.org/D19340 this is intentional
  
  
  Yes, i'm afraid it's one of those unfortunate side effects of having to fix a 
pretty hefty sort of bug which caused a fair few people a lot of anguish. Well 
spotted otherwise, and it would certainly seem to be a good time to (now 
Frameworks has had a release with the code) get this updated in the various 
applications which use KNS. We'd need to do this either by using the new 
install location from KNewStuffCore's cmake module, or by hand picking that 
install location manually (if, for some reason, there is a desire in the 
application to not depend on such a new Frameworks release, which i guess i can 
understand in some cases).

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21246

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21246: Search also legacy location for knsrc files

2019-05-17 Thread Antonio Rojas 
arojas abandoned this revision.
arojas added a comment.


  OK I see in https://phabricator.kde.org/D19340 this is intentional

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21246

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

2019-05-17 Thread Pavel Mos 
pavelmos added a comment.


  In D20222#466116 , @davidedmundson 
wrote:
  
  > Generally I don't like things being blocked for no discernable reason. It 
makes toggling between two things order dependent.
  >
  > > If the user disables the last checkbox, all other checkboxes will 
automatically get enabled in the settings.
  >
  > Yeah, that's weird behaviour.
  >
  > Lets do this.
  
  
  Thanks!
  I have no commit access.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart