D13481: Recommend window border size "None"

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  For the record. As far as I can tell, MSWindows(r) decorations do not have 
"no borders". They have a 1 pixel dark border (that blends with the shadow), on 
all sides. This essentially fixes all the regressions that this patch 
introduces, that were mentionned by several kde contributors, and essentially 
ignored. 
  I am still strongly against this change.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13481

To: romangg, #plasma, #vdg, ngraham
Cc: hpereiradacosta, pedrogomes1698, hein, januz, ngraham, davidedmundson, 
graesslin, abetts, mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol

D21610: Redesign Advanced tab

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:e020446f7019: Redesign Advanced tab (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59282&id=59305

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

[Alejandro Valdes]

avaldes marked 3 inline comments as done.
avaldes added a comment.


  In D16425#475148 , @ericadams 
wrote:
  
  > I apologize if this is the wrong place to add this comment but I have a 
laptop where this applies and would benefit me. I am happy to help test this if 
you find it helpful. Thanks.
  
  
  Feel free to download this patch (download raw diff 
) and apply it to powerdevil 
repo . You need to build the 
package and replace the one in your system.
  
  If you use arch or a derivative I can help you with that.

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: ericadams, jobauer, reverendhomer, meven, soriano, abalaji, graesslin, 
ngraham, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13278: Set default border value in all places

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:133eeece41e2: Set default border value in all places 
(authored by ngraham).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13278?vs=35379&id=59299

REVISION DETAIL
  https://phabricator.kde.org/D13278

AFFECTED FILES
  kdecoration/breezesettingsdata.kcfg

To: ngraham, #breeze, abetts
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13481: Recommend window border size "None"

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:e15989fb1f0d: Recommend window border size 
"None" (authored by romangg).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13481?vs=36009&id=59296

REVISION DETAIL
  https://phabricator.kde.org/D13481

AFFECTED FILES
  kdecoration/breeze.json

To: romangg, #plasma, #vdg, ngraham
Cc: pedrogomes1698, hein, januz, ngraham, davidedmundson, graesslin, abetts, 
mart, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Nathaniel Graham]

ngraham updated this revision to Diff 59289.
ngraham added a comment.


  Remove TODO and formalize that the buttons should all be the same size

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21629?vs=59270&id=59289

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: abetts, filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Filip Fila]

filipf marked 3 inline comments as done.
filipf added a comment.


  Should work fairly well now with the 2 dependencies.

REPOSITORY
  R114 Plasma Addons

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Filip Fila]

filipf updated this revision to Diff 59286.
filipf added a comment.


  - use readonly property instead of function
  - make icon sizes scalable

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21027?vs=57785&id=59286

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Filip Fila]

filipf added a comment.


  In D21629#475353 , @abetts wrote:
  
  > +1
  >
  > We might need to add some padding so the button frame doesn't overlay 
content on the background
  
  
  As far as I can tell the button is actually within it's own frame/rectangle, 
it's Elisa's icon that drops too low and the sits behind the frame/rectangle.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: abetts, filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D21610: Redesign Advanced tab

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit! Master only, obviously

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

[Filip Fila]

filipf updated this revision to Diff 59282.
filipf added a comment.


  improve string "Relogin after quit"

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59280&id=59282

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

[Filip Fila]

filipf added a comment.


  In D21610#475386 , @ngraham wrote:
  
  > In D21610#475385 , @filipf wrote:
  >
  > > My suggestion is to rename it to "Log in again after logging off"
  >
  >
  > Much better! How about "Log in again after immediately after logging off" 
to emphasize how instant it is? Or even "After logging off, immediately log in 
again".
  
  
  Nice, I'll do option no.1 because the HIG tells us to start off checkbox 
labels with an action verb.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

[Nathaniel Graham]

ngraham added a comment.


  In D21610#475385 , @filipf wrote:
  
  > My suggestion is to rename it to "Log in again after logging off"
  
  
  Much better! How about "Log in again after immediately after logging off" to 
emphasize how instant it is? Or even "After logging off, immediately log in 
again".

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

[Filip Fila]

filipf added a comment.


  In D21610#475382 , @ngraham wrote:
  
  > Much better, thanks! Works now.
  >
  > One final thing, maybe: can we re-word "Relogin after quit"? I admit I have 
no idea what it even does! It's also got an English error ("relogin" isn't a 
word) and it has no tooltip to explain what it does. Needs a bit of loving.
  
  
  I had no idea what it meant either lol. Then I thought about it a bit and 
assumed it means that when you have autologin on and you log off it just logs 
you back in. Which tests seem to confirm.
  
  My suggestion is to rename it to "Log in again after logging off"

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21627: [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:62c099c023de: [Task manager] Use Windows-style 
middle-click behaviors for entries and… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21627?vs=59268&id=59281

REVISION DETAIL
  https://phabricator.kde.org/D21627

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21610: Redesign Advanced tab

[Nathaniel Graham]

ngraham added a comment.


  Much better, thanks! Works now.
  
  One final thing, maybe: can we re-word "Relogin after quit"? I admit I have 
no idea what it even does! It's also got an English error ("relogin" isn't a 
word) and it has no tooltip to explain what it does. Needs a bit of loving.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21610: Redesign Advanced tab

[Filip Fila]

filipf updated this revision to Diff 59280.
filipf added a comment.


  use toggled instead of clicked

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21610?vs=59232&id=59280

BRANCH
  redesign-sddm-advanced-tab (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21610

AFFECTED FILES
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Nathaniel Graham]

ngraham added a comment.


  In D21629#475353 , @abetts wrote:
  
  > +1
  >
  > We might need to add some padding so the button frame doesn't overlay 
content on the background
  
  
  That's a pre-existing bug only visible when the pop-up isn't displaying a 
media preview. We can fix that in another revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: abetts, filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Andres Betts]

abetts added a comment.


  +1
  
  We might need to add some padding so the button frame doesn't overlay content 
on the background

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: abetts, filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in ToolTipInstance.qml:336
> Do we also have the issue here that the tool button will grow in size but not 
> the icon inside it? Seems OK when I bump up the scaling.

Nah, the out-of-the-box behavior is fine, that comment is just there to 
indicate what needs to happen before we can make the Play button bigger, as it 
is without this patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Noah Davis]

ndavis added a comment.


  In D21629#475324 , @filipf wrote:
  
  > BTW when talking about consistency, do we also apply this change to the 
media player applet?
  
  
  The media player applet already has ToolButtons.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  +1 buttons should be buttons unless there's really strong designer reasons 
such as in the login screen etc. I'm also enjoying this a lot more than than 
just having icons.
  
  BTW when talking about consistency, do we also apply this change to the media 
player applet?

INLINE COMMENTS

> ToolTipInstance.qml:336
> +PlasmaComponents.ToolButton {
> +// TODO: make PlasmaComponents ToolButtons respond 
> to size changes
> +// iconHeight: units.iconSizes.medium

Do we also have the issue here that the tool button will grow in size but not 
the icon inside it? Seems OK when I bump up the scaling.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21494: Close KSplash when the desktops are visible

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I wrote a patch to delay uiReady till the wallpaper is loaded.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21494

To: apol, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21627: [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails

[Nathaniel Graham]

ngraham added a comment.


  Thanks. I had a feeling that the default settings change would not be too 
controversial but I won't land this until I get at least one positive review 
from a #plasma  person since the new 
middle-click-to-close behavior for popup thumbnails is destructive and could be 
controversial. I didn't add an option to disable it because of the desire to 
not add new options for everything, but I'd like to see it discussed before I 
land the patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  windows-style-middle-click-behaviors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21627

To: ngraham, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Filip Fila]

filipf added a comment.


  It is also makes it consistent with the notification popup. Let me give it a 
quick spin.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis
Cc: filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Makes sense to be consistent about how we present buttons.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now, the Task Manager's popup has various buttons in it that do not 
look or
  feel like buttons because they are implemented as a MouseArea with an Icon 
inside.
  
  This patch makes them feel like standard buttons uses elsewhere by 
implementing
  them using ToolButtons instead.

TEST PLAN
  F6874640: ToolButtons for window closing controls.png 

  F6874639: ToolButtons for player controls.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21627: Use Windows-style middle-click behaviors for Task Manager entries and thumbnails

[Nathaniel Graham]

ngraham added a comment.


  The current default is None.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21627

To: ngraham, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21627: Use Windows-style middle-click behaviors for Task Manager entries and thumbnails

[Noah Davis]

ndavis added a comment.


  Is the current default group/ungroup or is the current default none? If the 
former is true, why is this better? If the latter, then +1 because it's useful.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21627

To: ngraham, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21627: Use Windows-style middle-click behaviors for Task Manager entries and thumbnails

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Windows 10 Task Manager equivalent opens a new instance when 
middle-clicking an
  open Task, and when middle-clicking on a thumbnail in the pop-up, that task 
is closed.
  
  These are some nice shortcuts. This patch implements the same behaviors for 
our Task
  Manager.

TEST PLAN
  1. Delete `~/.config/plasma-org.kde.plasma.desktop-appletsrc` and restart 
plasmashell
  2. Open an app
  3. Middle-click on the app's Task -> see that a new instance is created
  4. Keep middle-clicking on the app's Task until it becomes grouped
  5. Move the mouse over the grouped task
  6. Middle-click on a thumbnail in the pop-up -> see how that instance is 
closed

REPOSITORY
  R119 Plasma Desktop

BRANCH
  windows-style-middle-click-behaviors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21627

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21623: [ToolButton] Pass custom icon size to StyleItem

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Follow up on D20418 . Not sure what I was 
testing back then but it clearly couldn't have worked. Maybe I just forgot to 
add this part to the diff.

TEST PLAN
  `icon.width` and `icon.height` on a `ToolButton` now work
  F6874501: Screenshot_20190606_171346.png 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D21623

AFFECTED FILES
  org.kde.desktop/ToolButton.qml

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21620: Handle Esc properly when focus is in searchbox

[Jan Grulich]

jgrulich added a comment.


  In D21620#475194 , @ngraham wrote:
  
  > @jgrulich unless you object, I'll land this on the stable branch once my 
comment has been addressed.
  
  
  Feel free to land it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21620

To: kishoreg, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21620: Handle Esc properly when focus is in searchbox

[Nathaniel Graham]

ngraham added a comment.


  @jgrulich unless you object, I'll land this on the stable branch once my 
comment has been addressed.

INLINE COMMENTS

> Toolbar.qml:154
>  onVisibleChanged: if (!visible) text = ""
> -Keys.onEscapePressed: searchToggleButton.checked = false
> +Keys.onEscapePressed: {
> +if (searchToggleButton.checked) {

Could you add a comment explaining why this is necessary?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21620

To: kishoreg, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21620: Handle Esc properly when focus is in searchbox

[Kishore Gopalakrishnan]

kishoreg created this revision.
kishoreg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
kishoreg requested review of this revision.

REVISION SUMMARY
  BUG: 408290
  
  If we place the focus in the searchbar, pressing Esc once dismisses the 
searchbar. However, pressing Esc after this does not dismiss the popup unless 
one manually intereacts with some other element in the popup. This patch fixes 
the issue.

TEST PLAN
  1. Open the Networks popup in the systray.
  2. Click the search icon above the channels list.
  3. Click in the search area to place focus there.
  4. Press Esc. Searchbar disappears.
  5. Press Esc again. Check that the popup closes.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21620

AFFECTED FILES
  applet/contents/ui/Toolbar.qml

To: kishoreg, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Plasma 5.16 tars are ready

[Jonathan Riddell]

Tars are ready for packaging

Release due on Tuesday

D16425: Added new Suspend then Hibernate option

[Eric Adams]

ericadams added a comment.


  I apologize if this is the wrong place to add this comment but I have a 
laptop where this applies and would benefit me. I am happy to help test this if 
you find it helpful. Thanks.

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: ericadams, jobauer, reverendhomer, meven, soriano, abalaji, graesslin, 
ngraham, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: [orca-list] Accessibility in Plasmas new notification system

[chrys]

Howdy Joanie,

oh this is pritty awsome! thanks for this information.
I will forward it to plasma-devel and kbroulik. fore sure they will  
like your answer!


mercy,

cheers chrys
Zitat von Joanmarie Diggs :


Hey Chrys.

Regarding notifications, it should be pretty simple:

1. Give it ROLE_NOTIFICATION
2. Be sure it emits an object:state-changed:showing event
3. Be sure the displayed text is exposed via the accessible text
   interface, either on the notification itself or in the accessible
   children of the notification

In theory, that should do it. Orca's looking for notifications that
announce their appearance because, like you stated, they don't get focus.

Hope this helps. BTW, I'm not subscribed to plasma-devel, so I'm not
sure if my CCing them will be sufficient. If it's not, and if they need
what I've stated above, please forward it to them.

Thanks again for all your work on this!
--joanie

On 6/6/19 7:45 AM, ch...@linux-a11y.org wrote:


Howdy Joanie,

I just give an talk to kbroulik ( the creator of Plasmas new awsome
notification system).
see here:
https://blog.broulik.de/2019/05/next-generation-plasma-notifications/

He told me that accessibility is not yet implemented. But I see
notifications are an very importaint part of an desktop system. Problem
for make it accessible is, that it currently doesnt get the focus at any
time.
Is there a best practice to implement this?
how does gnome do this? how is orca awaiting for incomming
notifications? do you know how we can make this happen?
Sorry for bother you with so basic stuff but you are the only one person
I know what can answer those issues properly.

maybe a nice side notice for you (and others). We currently work on an
accessibility HIG for KDE.
https://hig.kde.org/accessibility/index.html
Still a WIP, but if someone wants to add some good content just contact me.
It should contain:
- Keyboard navigation
- Focus handling
- Set A11y Lables/ Descriptions/ roles
- howto test for good a11y

cheers chrys

___
orca-list mailing list
orca-l...@gnome.org
https://mail.gnome.org/mailman/listinfo/orca-list
Orca wiki: https://wiki.gnome.org/Projects/Orca
Orca documentation: https://help.gnome.org/users/orca/stable/
GNOME Universal Access guide:
https://help.gnome.org/users/gnome-help/stable/a11y.html

D21610: Redesign Advanced tab

[Nathaniel Graham]

ngraham added a comment.


  Ah you're right, that's a pre-existing issue. However it does get worse with 
this redesign since the Advanced page is now much more compact. Oh well.
  
  I've found one new issue: when auto-login is enabled and you go to the 
Advanced page, its checkbox is checked but none of the related controls are 
un-disabled: F6874337: Screenshot_20190606_071356.png 

  
  When you toggle it off and on again, they do get enabled as expected. An 
inline comment explains why:

INLINE COMMENTS

> advanceconfig.ui:247
> +   autoLogin
> +   clicked(bool)
> +   label_4

This and other subsequent connections are probably the problem. The signal is 
only getting passed along when the checkbox is actually clicked. But nothing is 
connected to its `checked()` signal, so it doesn't know to enable the controls 
when the checkbox starts out checked but is not explicitly clicked by the user.

You can probably change `clicked` to `checked`.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21619: Wallpaper: delay calling UIReady until the image is actually loaded

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The desktop image is loaded asyncronously in another thread. This is a
  good thing as it can be quite intensive.
  
  Unforunately this can lead to kslpash being removed before the wallpaper
  being loaded which undermines half the point of an insanely long
  ksplash.

TEST PLAN
  qdebug showed that we don't emit we're ready till the wallpaper is loaded
  KSplash disappearing too early was hard to reproduce reliably

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21619

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size

[Nathaniel Graham]

ngraham added a comment.


  @ndavis in the future, the best way to do this would be to land it on the 
`Plasma/5.16` branch, then merge that branch to master. This process is 
detailed at 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21593

To: ndavis, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, rikmills, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 22 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/22/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 06 Jun 2019 12:37:06 +
 Build duration:
6 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2578)14%
(212/1499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/255)0%
(0/134)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/6/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 06 Jun 2019 12:37:08 +
 Build duration:
6 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 221 lines...][2019-06-06T12:43:40.504Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-06T12:43:40.504Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-06T12:43:40.504Z] PROCESSOR_LEVEL   = '6'[2019-06-06T12:43:40.504Z] PROCESSOR_REVISION= '5e03'[2019-06-06T12:43:40.504Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-06T12:43:40.504Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-06T12:43:40.504Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-06T12:43:40.504Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-06T12:43:40.504Z] PROMPT= '$P$G'[2019-06-06T12:43:40.504Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-06T12:43:40.504Z] PUBLIC= 'C:\Users\Public'[2019-06-06T12:43:40.504Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/6/display/redirect?page=changes'[2019-06-06T12:43:40.504Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/6/display/redirect'[2019-06-06T12:43:40.504Z] STAGE_NAME= 'Configuring Build'[2019-06-06T12:43:40.504Z] SYSTEMDRIVE   = 'C:'[2019-06-06T12:43:40.504Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-06T12:43:40.504Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-06T12:43:40.504Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-06T12:43:40.504Z] UCRTVERSION   = '10.0.17763.0'[2019-06-06T12:43:40.504Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-06T12:43:40.504Z] USERDOMAIN= 'DESKTOP-66R8QOQ'[2019-06-06T12:43:40.504Z] USERNAME  = 'Jenkins'[2019-06-06T12:43:40.504Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-06T12:43:40.504Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-06T12:43:40.504Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-06T12:43:40.504Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-06T12:43:40.504Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-06T12:43:40.504Z] VCTOOLSVERSION= '14.16.27023'[2019-06-06T12:43:40.504Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-06T12:43:40.504Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-06T12:43:40.504Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-06T12:43:40.504Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-06T12:43:40.504Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-06T12:43:40.504Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-06T12:43:40.504Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-06T12:43:40.504Z] VSCMD_VER = '16.0.3'[2019-06-06T12:43:40.504Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-06T12:43:40.504Z] WINDIR= 'C:\WINDOWS'[2019-06-06T12:43:40.504Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-06T12:43:40.504Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-06T12:43:40.504Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-06T12:43:40.504Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-06T12:43:40.504Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-06T12:43:40.504Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-06T12:43:40.504Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11'[2019-06-06T12:43:40.504Z] __DOTNET_ADD_64BIT= '1'[2019-06-06T12:43:40.504Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-06T12:43:40.504Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-06

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/24/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 06 Jun 2019 12:37:07 +
 Build duration:
1 min 56 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

Accessibility in Plasmas new notification system

[chrys]

Howdy Joanie,

I just give an talk to kbroulik ( the creator of Plasmas new awsome  
notification system).

see here:
https://blog.broulik.de/2019/05/next-generation-plasma-notifications/

He told me that accessibility is not yet implemented. But I see  
notifications are an very importaint part of an desktop system.  
Problem for make it accessible is, that it currently doesnt get the  
focus at any time.

Is there a best practice to implement this?
how does gnome do this? how is orca awaiting for incomming  
notifications? do you know how we can make this happen?
Sorry for bother you with so basic stuff but you are the only one  
person I know what can answer those issues properly.


maybe a nice side notice for you (and others). We currently work on an  
accessibility HIG for KDE.

https://hig.kde.org/accessibility/index.html
Still a WIP, but if someone wants to add some good content just contact me.
It should contain:
- Keyboard navigation
- Focus handling
- Set A11y Lables/ Descriptions/ roles
- howto test for good a11y

cheers chrys

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/23/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 06 Jun 2019 11:02:01 +
 Build duration:
22 min and counting
   CONSOLE OUTPUT
  [...truncated 191 lines...][2019-06-06T11:24:21.045Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-06-06T11:24:21.045Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/display/redirect'[2019-06-06T11:24:21.045Z] MAIL  = '/var/mail/jenkins'[2019-06-06T11:24:21.045Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/23/display/redirect?page=changes'[2019-06-06T11:24:21.045Z] JENKINS_URL   = 'https://build.kde.org/'[2019-06-06T11:24:21.045Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-06-06T11:24:21.045Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.12'[2019-06-06T11:24:21.045Z] HUDSON_HOME   = '/home/production/data'[2019-06-06T11:24:21.045Z] BUILD_ID  = '23'[2019-06-06T11:24:21.045Z] OLDPWD= '/usr/home/jenkins'[2019-06-06T11:24:21.045Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12'[2019-06-06T11:24:21.045Z] _ = '/usr/local/bin/java'[2019-06-06T11:24:21.045Z] TERM  = 'su'[2019-06-06T11:24:21.045Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.12'[2019-06-06T11:24:21.045Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.12-23'[2019-06-06T11:24:21.045Z] BUILD_DISPLAY_NAME= '#23'[2019-06-06T11:24:21.046Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/23/display/redirect'[2019-06-06T11:24:21.046Z] USER  = 'jenkins'[2019-06-06T11:24:21.046Z] HOME  = '/home/jenkins'[2019-06-06T11:24:21.046Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/23/'[2019-06-06T11:24:21.046Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/'[2019-06-06T11:24:21.046Z] HUDSON_URL= 'https://build.kde.org/'[2019-06-06T11:24:21.046Z] SHELL = '/usr/local/bin/bash'[2019-06-06T11:24:21.046Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12'[2019-06-06T11:24:21.046Z] MM_CHARSET= 'UTF-8'[2019-06-06T11:24:21.046Z] STAGE_NAME= 'Configuring Build'[2019-06-06T11:24:21.046Z] NODE_NAME = 'FreeBSD Builder 2'[2019-06-06T11:24:21.046Z] BLOCKSIZE = 'K'[2019-06-06T11:24:21.046Z] EXECUTOR_NUMBER   = '0'[2019-06-06T11:24:21.046Z] SHLVL = '0'[2019-06-06T11:24:21.046Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-06-06T11:24:21.046Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-06-06T11:24:21.046Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-06-06T11:24:21.046Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-06-06T11:24:21.046Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-06-06T11:24:21.046Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-06-06T11:24:21.046Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-06-06T11:24:21.046Z] QT_SELECT = 'qt5'[2019-06-06T11:24:21.046Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-06-06T11:24:21.046Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-06-06T11:24:21.046Z] [2019-06-06T11:24:21.046Z] [2019-06-06T11:24:21.046Z] == Commencing Configuration:[2019-06-06T11:24:21.046Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12"[2019-06-06T11:24:21.320Z] -- The C compiler identification is Clang 6.0.1[2019-06-06T11:24:21.320Z] -- The CXX compiler identification is Clang 6.0.1[2019-06-06T11:24:21.320Z] -- Check for working C compiler: /usr/bin/cc[2019-06-06T11:24:21.585Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-06-06T11:24:21.585Z] -- Detecting C com

D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f4fe4a65de85: [showdesktop][minimizeall] Reduce the 
maximum panel icon size (authored by ndavis).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21593?vs=59181&id=59254

REVISION DETAIL
  https://phabricator.kde.org/D21593

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml
  applets/showdesktop/package/contents/ui/main.qml

To: ndavis, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, rikmills, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 21 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/21/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 06 Jun 2019 11:02:00 +
 Build duration:
7 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 256 lines...][2019-06-06T11:09:16.339Z] OSTYPE= 'linux'[2019-06-06T11:09:16.339Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-06-06T11:09:16.339Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-06-06T11:09:16.339Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/21/display/redirect'[2019-06-06T11:09:16.339Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-06-06T11:09:16.339Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-06-06T11:09:16.339Z] HUDSON_URL= 'https://build.kde.org/'[2019-06-06T11:09:16.339Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-06-06T11:09:16.339Z] NODE_NAME = 'Docker Swarm-bd04d230a7ef'[2019-06-06T11:09:16.339Z] HOST  = 'bd04d230a7ef'[2019-06-06T11:09:16.339Z] LESSOPEN  = 'lessopen.sh %s'[2019-06-06T11:09:16.339Z] USER  = 'jenkins'[2019-06-06T11:09:16.339Z] MORE  = '-sl'[2019-06-06T11:09:16.339Z] CSHEDIT   = 'emacs'[2019-06-06T11:09:16.339Z] SHLVL = '2'[2019-06-06T11:09:16.339Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-21'[2019-06-06T11:09:16.339Z] WINDOWMANAGER = 'xterm'[2019-06-06T11:09:16.339Z] PAGER = 'less'[2019-06-06T11:09:16.339Z] EXECUTOR_NUMBER   = '0'[2019-06-06T11:09:16.339Z] CVS_RSH   = 'ssh'[2019-06-06T11:09:16.339Z] LIBGL_DEBUG   = 'quiet'[2019-06-06T11:09:16.339Z] STAGE_NAME= 'Configuring Build'[2019-06-06T11:09:16.339Z] NODE_LABELS   = 'Docker Swarm-bd04d230a7ef SUSEQt5.12'[2019-06-06T11:09:16.339Z] XCURSOR_THEME = 'DMZ-Black'[2019-06-06T11:09:16.339Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-06-06T11:09:16.339Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-06-06T11:09:16.339Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-06-06T11:09:16.339Z] PROFILEREAD   = 'true'[2019-06-06T11:09:16.339Z] MAIL  = '/var/mail/jenkins'[2019-06-06T11:09:16.339Z] HOSTTYPE  = 'x86_64'[2019-06-06T11:09:16.339Z] BUILD_ID  = '21'[2019-06-06T11:09:16.339Z] LESSKEY   = '/etc/lesskey.bin'[2019-06-06T11:09:16.339Z] OLDPWD= '/home/jenkins'[2019-06-06T11:09:16.339Z] LC_CTYPE  = 'C.UTF-8'[2019-06-06T11:09:16.339Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-06-06T11:09:16.339Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-06-06T11:09:16.339Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-06-06T11:09:16.339Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-06-06T11:09:16.339Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-06-06T11:09:16.339Z] QT_SELECT = 'qt5'[2019-06-06T11:09:16.339Z] LANG  = 'en_US.UTF-8'[2019-06-06T11:09:16.339Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-06-06T11:09:16.339Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-06-06T11:09:16.339Z] [2019-06-06T11:09:16.339Z] [2019-06-06T11:09:16.339Z] == Commencing Configuration:[2019-06-06T11:09:16.339Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2019-06-06T11:09:18.699Z] -- The C compiler identification is GNU 8.3.1[2019-06-06T11:09:19.748Z] -- The CXX compiler identification is GNU 8.3.1[2019-06-06T11:09:20.247Z] -- Check for working C compiler: /usr/bin/cc[2019-06-06T11:09:20.247Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-06-06T11:09:20.247Z] -- Detecting C compiler ABI info[2019-06-06T11:09:20.752Z] -- Detecting C compiler ABI info - done[2019-06-06T11:09:20.752Z] -- Detecting C compile features[2019-06-06T11:09:20.752Z] -- Detecting C compile features - done[2019-06-06T11:09:20.752Z] -- Check for working CXX compiler: /usr/bin/c

D21593: [showdesktop] Reduce the maximum panel icon size

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  should be pushed to 5.16 as well

REPOSITORY
  R119 Plasma Desktop

BRANCH
  show-desktop-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21593

To: ndavis, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, rikmills, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D21593: [showdesktop] Reduce the maximum panel icon size

[Kai Uwe Broulik]

broulik added a comment.


  > I couldn't figure out how to make the widget get the icon from the desktop 
theme
  
  Plasma `IconItem` primarily uses icons from Plasma theme, if such exists, or 
told so otherwise by setting `usesPlasmaTheme` to `false`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21593

To: ndavis, #vdg, #plasma
Cc: ngraham, broulik, rikmills, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21610: Redesign Advanced tab

[Filip Fila]

filipf added a comment.


  I believe that's due to the other tab. If you try to resize the Themes tab 
height-wise, you'll notice the scrollbar appears when the bottom buttons start 
disappearing. I'll investigate some more though.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9037: use desktop file actions instead of global shortcuts

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cac7af89b7eb: use desktop file actions instead of global 
shortcuts (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9037?vs=58829&id=59246

REVISION DETAIL
  https://phabricator.kde.org/D9037

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  krunner/CMakeLists.txt
  krunner/krunner.desktop
  krunner/main.cpp
  krunner/update/CMakeLists.txt
  krunner/update/krunnerglobalshortcuts.cpp
  krunner/update/krunnerglobalshortcuts.upd
  krunner/update/krunnerplugins.cpp
  krunner/update/main.cpp
  krunner/view.cpp

To: broulik, #plasma, davidedmundson, mart
Cc: broulik, apol, davidedmundson, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart