D21639: Remove background from scrollbars when hovering on them

2019-06-08 Thread Matej Mrenica 
mthw added a comment.


  In D21639#476035 , @ngraham wrote:
  
  > In D21639#476019 , @mthw wrote:
  >
  > > I changed the color to always blue so it looked more like Dolphin. But I 
can change it back tomorrow.
  >
  >
  > The different behaviors are actually fairly subtle. This is what's typical 
for all KDE apps:
  >
  > - The handle is thin and gray when not in use
  
  
  The handle dissapears altogether when not in use and I cannot change that.
  
  > - Turn the handle turquoise when the view that contains the scrollbar 
receives focus
  
  When the handle appears it is turquoise.
  
  > - Show the track and widen the handle when the track is hovered over
  
  Done. I don't know if I got the size correct though.
  
  > - Turn the handle turquoise when it's hovered over (if it wasn't already 
turquoise)
  
  I made it different turquoise when hovered, like it is in Dolphin.
  
  > Not sure if it's possible to do all of that in the Breeze-GTK theme, but if 
it is, we should match it as closely as possible.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21639

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21639: Remove background from scrollbars when hovering on them

2019-06-08 Thread Matej Mrenica 
mthw updated this revision to Diff 59382.
mthw added a comment.


  Hopefully the final version

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21639?vs=59364&id=59382

BRANCH
  breeze-gtk-scrollbar-no-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21639

AFFECTED FILES
  src/gtk318/widgets/_scrollbar.scss
  src/gtk320/widgets/_scrollbar.scss

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21639: Remove background from scrollbars when hovering on them

2019-06-08 Thread Matej Mrenica 
mthw updated this revision to Diff 59383.
mthw added a comment.


  There are lines that 'git diff' says are different altough shows them exactly 
the same and I don't know what to do with that.

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21639?vs=59382&id=59383

BRANCH
  breeze-gtk-scrollbar-no-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21639

AFFECTED FILES
  src/gtk318/widgets/_scrollbar.scss
  src/gtk320/widgets/_scrollbar.scss

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

2019-06-08 Thread Christoph Roick 
croick updated this revision to Diff 59394.
croick added a comment.


  Rebase to current master

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11234?vs=29245&id=59394

BRANCH
  nicebutton

REVISION DETAIL
  https://phabricator.kde.org/D11234

AFFECTED FILES
  src/drkonqidialog.cpp

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18245: Create QApplication in a scope to work around possible deadlock

2019-06-08 Thread Christoph Roick 
croick updated this revision to Diff 59395.
croick added a comment.


  Rebase to current master

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18245?vs=52524&id=59395

BRANCH
  scopedqapp

REVISION DETAIL
  https://phabricator.kde.org/D18245

AFFECTED FILES
  src/main.cpp

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

2019-06-08 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Display also threads as if they were processes. This is enabled with
  menu entry in PID column header.
  
  Signed-off-by: Topi Miettinen 

TEST PLAN
  None

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

AFFECTED FILES
  processcore/processes.cpp
  processcore/processes.h
  processcore/processes_atop_p.cpp
  processcore/processes_atop_p.h
  processcore/processes_base_p.h
  processcore/processes_dragonfly_p.cpp
  processcore/processes_freebsd_p.cpp
  processcore/processes_gnu_p.cpp
  processcore/processes_linux_p.cpp
  processcore/processes_local_p.h
  processcore/processes_netbsd_p.cpp
  processcore/processes_openbsd_p.cpp
  processcore/processes_remote_p.cpp
  processcore/processes_remote_p.h
  processcore/processes_solaris_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Port to Kirigami FormLayout and QQC2.
  
  NOTE: There are some heavy binding loop errors about "implicitWidth" due to 
loading more FormLayouts into the main one. How to fix this?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Filip Fila 
filipf updated this revision to Diff 59404.
filipf added a comment.


  initial cleanup

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21668?vs=59403&id=59404

BRANCH
  modernize-redesign-nightcolor-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21668

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/NumberField.qml
  kcms/nightcolor/package/contents/ui/TimeField.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Filip Fila 
filipf added inline comments.

INLINE COMMENTS

> main.qml:23
>  import org.kde.plasma.core 2.0 as PlasmaCore
> -import org.kde.plasma.extras 2.0 as PlasmaExtras
> +import org.kde.plasma.extras 2.0 as PlasmaExtras*/
> +import org.kde.kirigami 2.5 as Kirigami

Are these 3 imports needed? I couldn't figure out what they were doing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21668: WIP: Modernize and redesign the Night Color config window

2019-06-08 Thread Nathaniel Graham 
ngraham added a comment.


  Lovely! Can you align the bottom fields with the combobox above them?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21668

To: filipf, #vdg, ngraham, romangg, mart
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21670: Enforce use of the reset timer for clearing the model

2019-06-08 Thread Fabian Vogt 
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  Currently when the query string changes, krunner sends a signal with no 
matches
  directly, which circumvents use of the reset timer.

TEST PLAN
  Enter =1+1, results are shown. Add another "1", the shown 2 switches to a 12
  instantly without hiding the previous result for a few frames.

REPOSITORY
  R112 Milou

BRANCH
  resetchange

REVISION DETAIL
  https://phabricator.kde.org/D21670

AFFECTED FILES
  lib/sourcesmodel.cpp

To: fvogt, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart