D22014: Add a copy of FindKXB from kwin

[Luca Beltrame]

lbeltrame created this revision.
lbeltrame added a reviewer: cgiboudeaux.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lbeltrame requested review of this revision.

REVISION SUMMARY
  1a54c53bca82a28d77f379a6d5cb2e1a3be46fe5 
 
added a requirement for xkbcommon
  without actually looking for it. As FindXKB is not yet in ECM, this commit
  puts a copy of it in the source, and hooks it up with CMake.

TEST PLAN
  Did not compile for me earlier, now compiles.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  xkb-compile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22014

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXKB.cmake
  src/kmodifierkeyinfoprovider/CMakeLists.txt

To: lbeltrame, cgiboudeaux
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22014: Add a copy of FindKXB from kwin

[Alexey Min]

alexeymin added a comment.


  typo in title :)

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22014

To: lbeltrame, cgiboudeaux
Cc: alexeymin, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22014: Add a copy of FindKXB from kwin

[Luca Beltrame]

lbeltrame abandoned this revision.
lbeltrame added a comment.


  Actually, those changes are not needed. The includes aren't used at all.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22014

To: lbeltrame, cgiboudeaux
Cc: alexeymin, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/14/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Jun 2019 07:34:46 +
 Build duration:
3 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 283 lines...][2019-06-23T07:37:41.443Z] LANG  = 'en_US.UTF-8'[2019-06-23T07:37:41.443Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-06-23T07:37:41.443Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-06-23T07:37:41.443Z] [2019-06-23T07:37:41.443Z] [2019-06-23T07:37:41.443Z] == Commencing Configuration:[2019-06-23T07:37:41.443Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12"[2019-06-23T07:37:47.594Z] -- The C compiler identification is GNU 8.3.1[2019-06-23T07:37:48.095Z] -- The CXX compiler identification is GNU 8.3.1[2019-06-23T07:37:48.095Z] -- Check for working C compiler: /usr/bin/cc[2019-06-23T07:37:48.596Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-06-23T07:37:48.596Z] -- Detecting C compiler ABI info[2019-06-23T07:37:48.596Z] -- Detecting C compiler ABI info - done[2019-06-23T07:37:48.596Z] -- Detecting C compile features[2019-06-23T07:37:49.096Z] -- Detecting C compile features - done[2019-06-23T07:37:49.096Z] -- Check for working CXX compiler: /usr/bin/c++[2019-06-23T07:37:49.096Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-06-23T07:37:49.096Z] -- Detecting CXX compiler ABI info[2019-06-23T07:37:49.595Z] -- Detecting CXX compiler ABI info - done[2019-06-23T07:37:49.595Z] -- Detecting CXX compile features[2019-06-23T07:37:50.095Z] -- Detecting CXX compile features - done[2019-06-23T07:37:51.151Z] -- Looking for __GLIBC__[2019-06-23T07:37:51.151Z] -- Looking for __GLIBC__ - found[2019-06-23T07:37:51.151Z] -- Performing Test _OFFT_IS_64BIT[2019-06-23T07:37:51.685Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-06-23T07:37:51.686Z] -- Performing Test HAVE_DATE_TIME[2019-06-23T07:37:51.686Z] -- Performing Test HAVE_DATE_TIME - Success[2019-06-23T07:37:51.686Z] -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.60.0") [2019-06-23T07:37:51.686Z] -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.60.0") [2019-06-23T07:37:51.686Z] -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.60.0") [2019-06-23T07:37:51.686Z] -- Found KF5: success (found suitable version "5.60.0", minimum required is "5.58.0") found components:  IdleTime WindowSystem GuiAddons [2019-06-23T07:37:51.686Z] -- The following REQUIRED packages have been found:[2019-06-23T07:37:51.686Z] [2019-06-23T07:37:51.686Z]  * ECM (required version >= 5.58.0)[2019-06-23T07:37:51.686Z]  * Qt5Gui (required version >= 5.12.3)[2019-06-23T07:37:51.686Z]  * Qt5Widgets[2019-06-23T07:37:51.686Z]  * Qt5Core[2019-06-23T07:37:51.686Z]  * KF5IdleTime (required version >= 5.58.0)[2019-06-23T07:37:51.686Z]  * KF5WindowSystem (required version >= 5.58.0)[2019-06-23T07:37:51.686Z]  * KF5GuiAddons (required version >= 5.58.0)[2019-06-23T07:37:51.686Z]  * KF5 (required version >= 5.58.0)[2019-06-23T07:37:51.686Z]  * KF5Wayland[2019-06-23T07:37:51.686Z]  * Qt5Test[2019-06-23T07:37:51.686Z]  * Qt5[2019-06-23T07:37:51.686Z] [2019-06-23T07:37:51.686Z] -- Configuring done[2019-06-23T07:37:52.188Z] -- Generating done[2019-06-23T07:37:52.188Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-06-23T07:37:53.791Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kwayland-integration --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-06-23T07:37:53.791Z] Scanning dependencies of target KF5WindowSystemKWaylandPlugin_autogen[2019-06-23T07:37:53.791Z] Scanning dependencies of target KF5IdleTimeKWaylandPlugin_autogen[2019-06-23T07:37:53.791Z] [  9%] Automatic MOC for target KF5IdleTimeKWaylandPlugin[2019-06-23T07:37:53.791Z] [  9%] Automatic MOC for target KF5WindowSystemKWaylandPlugin[2019-06-23T07:37:54.292Z] [  9%] Built target KF5IdleTimeKWaylandPlugin_autogen[2019-06-23T07:37:54.292Z] Scanning dependencies of target kmodifierkey_wayland_autogen[2019-06-23T07:37:54.292Z] [ 14%] Automatic MOC for target kmodifierkey_wayland[2019-06-23T07:37:54.292Z] [ 14%] Built target kmodifierkey_wayland_autogen[2019-06-23T07:37:54.292Z] Scanning dependencies of target idleTest_autogen[2019-06-23T07:37:54.292Z] [ 19%] Automatic MO

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 23 Jun 2019 07:34:46 +
 Build duration:
30 min and counting
   CONSOLE OUTPUT
  [...truncated 231 lines...][2019-06-23T08:04:58.161Z] -- Check for working CXX compiler: /usr/bin/c++[2019-06-23T08:04:58.417Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-06-23T08:04:58.417Z] -- Detecting CXX compiler ABI info[2019-06-23T08:04:58.417Z] -- Detecting CXX compiler ABI info - done[2019-06-23T08:04:58.417Z] -- Detecting CXX compile features[2019-06-23T08:04:58.674Z] -- Detecting CXX compile features - done[2019-06-23T08:04:58.674Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-06-23T08:04:58.674Z] -- Looking for __GLIBC__[2019-06-23T08:04:58.674Z] -- Looking for __GLIBC__ - not found[2019-06-23T08:04:58.674Z] -- Performing Test _OFFT_IS_64BIT[2019-06-23T08:04:59.005Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-06-23T08:04:59.005Z] -- Performing Test HAVE_DATE_TIME[2019-06-23T08:04:59.005Z] -- Performing Test HAVE_DATE_TIME - Success[2019-06-23T08:04:59.005Z] -- Found KF5IdleTime: /usr/home/jenkins/install-prefix/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.60.0") [2019-06-23T08:04:59.005Z] -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.60.0") [2019-06-23T08:04:59.005Z] -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.60.0") [2019-06-23T08:04:59.005Z] -- Found KF5: success (found suitable version "5.60.0", minimum required is "5.58.0") found components:  IdleTime WindowSystem GuiAddons [2019-06-23T08:04:59.005Z] -- The following REQUIRED packages have been found:[2019-06-23T08:04:59.005Z] [2019-06-23T08:04:59.005Z]  * ECM (required version >= 5.58.0)[2019-06-23T08:04:59.005Z]  * Qt5Gui (required version >= 5.12.2)[2019-06-23T08:04:59.005Z]  * Qt5Widgets[2019-06-23T08:04:59.005Z]  * Qt5Core[2019-06-23T08:04:59.005Z]  * KF5IdleTime (required version >= 5.58.0)[2019-06-23T08:04:59.005Z]  * KF5WindowSystem (required version >= 5.58.0)[2019-06-23T08:04:59.005Z]  * KF5GuiAddons (required version >= 5.58.0)[2019-06-23T08:04:59.005Z]  * KF5 (required version >= 5.58.0)[2019-06-23T08:04:59.005Z]  * KF5Wayland[2019-06-23T08:04:59.005Z]  * Qt5Test[2019-06-23T08:04:59.005Z]  * Qt5[2019-06-23T08:04:59.005Z] [2019-06-23T08:04:59.005Z] -- Configuring done[2019-06-23T08:04:59.005Z] -- Generating done[2019-06-23T08:04:59.005Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 FreeBSDQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-06-23T08:04:59.642Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kwayland-integration --branchGroup kf5-qt5 --platform FreeBSDQt5.12 --usingInstall /home/jenkins/install-prefix/[2019-06-23T08:04:59.899Z] Scanning dependencies of target KF5IdleTimeKWaylandPlugin_autogen[2019-06-23T08:04:59.899Z] Scanning dependencies of target kmodifierkey_wayland_autogen[2019-06-23T08:04:59.899Z] Scanning dependencies of target idleTest_autogen[2019-06-23T08:04:59.899Z] Scanning dependencies of target KF5WindowSystemKWaylandPlugin_autogen[2019-06-23T08:04:59.899Z] [  4%] Automatic MOC for target KF5IdleTimeKWaylandPlugin[2019-06-23T08:04:59.899Z] [  9%] Automatic MOC for target kmodifierkey_wayland[2019-06-23T08:04:59.899Z] [ 19%] Automatic MOC for target idleTest[2019-06-23T08:04:59.899Z] [ 19%] Automatic MOC for target KF5WindowSystemKWaylandPlugin[2019-06-23T08:05:00.580Z] [ 19%] Built target KF5IdleTimeKWaylandPlugin_autogen[2019-06-23T08:05:00.580Z] Scanning dependencies of target KF5IdleTimeKWaylandPlugin[2019-06-23T08:05:00.580Z] [ 23%] Building CXX object src/idletime/CMakeFiles/KF5IdleTimeKWaylandPlugin.dir/KF5IdleTimeKWaylandPlugin_autogen/mocs_compilation.cpp.o[2019-06-23T08:05:00.580Z] [ 28%] Building CXX object src/idletime/CMakeFiles/KF5IdleTimeKWaylandPlugin.dir/poller.cpp.o[2019-06-23T08:05:00.580Z] [ 28%] Built target KF5WindowSystemKWaylandPlugin_autogen[2019-06-23T08:05:00.580Z] [ 28%] Built target kmodifierkey_wayland_autogen[2019-06-23T08:05:00.580Z] Scanning dependencies of target kmodifierkey_wayland[2019-06-23T08:05:00.580Z] [ 33%] Building CXX object src/kmodifierkeyinfoprovider/CMakeFiles/kmodifierkey_wayland.dir/kmodifierkeyinfoprovider_wayland.cpp.o[2019-06-23T08:05:00.580Z] [ 38%] Building CXX object src/kmodifierkeyinfoprovider/CMakeFiles/kmodifierkey_wayland.dir/kmodifierkey_wayland_autogen/mocs_compilation.cpp.o[2019-06-23T08:05:00.580Z] In file included from /usr/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 FreeBSDQt5.12/src/kmodifierkeyinfoprovider/kmodifierkeyinfoprovider_wayland.cpp:21:[2019-06-23T08:05:00.580Z] 

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 60421.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=60345&id=60421

BRANCH
  davidedmundson/ksession

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22017: [Notifications] Let plasmashell be the only true owner of notification and job tracker services

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mvourlakos, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Register notification and job tracker services with "allow replacement" flag 
if not plasmashell, so when it eventually comes up, it can claim the service 
and then cling on to it.
  
  BUG: 408250
  FIXED-IN: 5.16.2

TEST PLAN
  Can't reproduce with latte but tried with `plasmawindowed 
org.kde.plasma.notifications` and then starting `plasmashell`
  
  Not too happy about that magic property but other than that pretty cool imho

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22017

AFFECTED FILES
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/jobsmodel.h
  libnotificationmanager/jobsmodel_p.cpp
  libnotificationmanager/jobsmodel_p.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/utils.cpp
  libnotificationmanager/utils_p.h
  shell/main.cpp

To: broulik, #plasma, mvourlakos, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> server.h:56
>  
> +
>  #define SESSION_PREVIOUS_LOGOUT "saved at previous logout"

?

> startup.cpp:417
> +connect(watcher, &QDBusServiceWatcher::serviceRegistered, this, [=]() {
> +emitResult();
> +});

watcher->deleteLater();

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21995

To: davidedmundson, #plasma
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in startup.cpp:417
> watcher->deleteLater();

It's a QDbusServiceWatcher not a QDBusPendingCallWatcher

it's parented to the job which will quit

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21995

To: davidedmundson, #plasma
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D19389: Rewrite kworkspace logout, shutdown and suspend API

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sessionmanagement.cpp:95
> I don't see where it did

KDisplayManager::isSwitchable()

checks `CanMultiSession` on the session manager.
and there's also `numReserve()` which seems to be hardcoded to `1` for more 
modern systems, so that might not be an issue.

> davidedmundson wrote in sessionmanagement.h:93
> We did, but that isn't needed now.
> 
> If you want low level, you can use the SessionManagementBackend to just 
> perform the action directly

Right

> davidedmundson wrote in sessionmanagementbackend.cpp:200
> Honestly, because it's super legacy and I don't really want to spend any time 
> on it. Especially as I need to ask others to test again.
> 
> The old code blocked, anyway

Ah, right consolekit1, fine then.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19389

To: davidedmundson, #plasma
Cc: pino, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21998: Batch MPRIS DBus property changes

[Aleix Pol Gonzalez]

apol added a comment.


  +1 LGTM

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21998

To: broulik, #plasma, fvogt
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22020: Fix wayland-dev session

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  without dbus-run-session developer can't login into this session

TEST PLAN
  now login works

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/fix-waylan-dev

REVISION DETAIL
  https://phabricator.kde.org/D22020

AFFECTED FILES
  login-sessions/plasmawayland-dev.desktop.cmake

To: bshah, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22021: Don't start ksmserver with lockscreen integration on wayland

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  Fixes regression from the startkde C++ re-write which made ksmserver
  start the kscreenlocker in wayland session, resulting in the double
  lockscreeens.

TEST PLAN
  after applying patch I only get one lockscreen

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/fix-startplasma-wayland

REVISION DETAIL
  https://phabricator.kde.org/D22021

AFFECTED FILES
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cpp
  startkde/startplasma.h

To: bshah, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22005: Accept local paths

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> actionlist.cpp:256
> +if (resource.startsWith(QLatin1Char('/'))) {
> +resource = QStringLiteral("file://") + resource;
> +}

if (QDir::isAbsolutePath(resource)) {
  resource = QUrl::fromLocalFile(resource);
  }

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22005

To: broulik, #plasma, hein
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22011: Add MenuSeparator

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ngraham wrote in MenuSeparator.qml:37
> @mart does this need to be multiplied by the device pixel ratio to account 
> for fractional scale factors? I forget.

It shouldn't need any height at all.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22011

To: astippich, mart, apol, ngraham
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22011: Add MenuSeparator

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> apol wrote in MenuSeparator.qml:37
> It shouldn't need any height at all.

Oh duh, I was thinking it was a Rectangle, but it's a Kirigami.Separator

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  menu_separator

REVISION DETAIL
  https://phabricator.kde.org/D22011

To: astippich, mart, apol, ngraham
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22021: Don't start ksmserver with lockscreen integration on wayland

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> startplasma.h:48
>  bool startKDEInit();
> -bool startKSMServer();
> +bool startKSMServer(bool wayland);
>  

Can you use some flags/enum here, `startKSMServer(false)` isn't very descript.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22021

To: bshah, apol
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22020: Fix wayland-dev session

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1cc0b27fb840: Fix wayland-dev session (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22020?vs=60424&id=60426

REVISION DETAIL
  https://phabricator.kde.org/D22020

AFFECTED FILES
  login-sessions/plasmawayland-dev.desktop.cmake

To: bshah, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22021: Don't start ksmserver with lockscreen integration on wayland

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3daa7bd2c58f: Don't start ksmserver with lockscreen 
integration on wayland (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22021?vs=60425&id=60427

REVISION DETAIL
  https://phabricator.kde.org/D22021

AFFECTED FILES
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cpp
  startkde/startplasma.h

To: bshah, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60429.
romangg added a comment.


  - Update protocol xml to wayland-protocols master

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60366&id=60429

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D21990: Don't propagate a title change if it didn't actually change

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:97cd13a388f1: Don't propagate a title change if it 
didn't actually change (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21990?vs=60320&id=60430

REVISION DETAIL
  https://phabricator.kde.org/D21990

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

[Nathaniel Graham]

ngraham added a comment.


  It never makes sense to put a tooltip on the wrong control.
  
  The fact that you need to check "CPU Monitor" first to get the "Show CPUs 
separately" option to become enables id visually communicated by the fact that 
it's indented below the other checkbox.
  
  If https://bugreports.qt.io/browse/QTBUG-30801 is the blocker here, I think 
we can safely commit this now (but for the right control) and then once that 
bug is fixed, the tooltip will just automatically work.

REVISION DETAIL
  https://phabricator.kde.org/D21979

To: nhiga, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22011: Add MenuSeparator

[Alexander Stippich]

astippich updated this revision to Diff 60433.
astippich added a comment.


  - remove unneeded height

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22011?vs=60391&id=60433

BRANCH
  menu_separator

REVISION DETAIL
  https://phabricator.kde.org/D22011

AFFECTED FILES
  org.kde.desktop/MenuSeparator.qml

To: astippich, mart, apol, ngraham
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21998: Batch MPRIS DBus property changes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:8cacb9246b0d: Batch MPRIS DBus property changes (authored 
by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21998?vs=60352&id=60437

REVISION DETAIL
  https://phabricator.kde.org/D21998

AFFECTED FILES
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22028: Improve QWidget KCM and QML KCM consistency

[Méven Car]

meven created this revision.
meven added reviewers: mart, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  - Set QWidget KCMs title font size to the same one as QML ones
  - Add content margin to QWidget KCMs to match QML ones
  - Only display own KCM title in QML case

REPOSITORY
  R102 KInfoCenter

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  Modules/fileindexermonitor/kcm.cpp
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

[Méven Car]

meven updated this revision to Diff 60446.
meven added a comment.


  Remove lines that shouldn't have been included

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60442&id=60446

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19855: Fix bugzilla login page widgets tab order

[Christoph Feck]

cfeck added a comment.


  Is this fixed by https://phabricator.kde.org/D21894 ?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

To: marcelomariano, sitter, cfeck, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

[Nathaniel Graham]

ngraham added a comment.


  Close! But the title sizes still appear to differ:
  
  F6927140: The bug-2019-06-23_13.03.08.webm 


REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22028

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix and update PCI module

[Christoph Feck]

cfeck added a comment.


  Would it be possible to commit the whitespace changes separately? They hide 
all the actual changes.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18920

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf added a comment.


  Preview of a highlight style in line with what's being discussed in T11124 
:
  
  F6927189: image.png 
  
  From a technical POV is it possible to reuse the widgets/tasks SVG here?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D22011: Add MenuSeparator

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  LGTM
  
  To be honest, I would expect this to be the actual logic and 
Kirigami.Separator just use MenuSeparator, but maybe it's something we can look 
into in the future.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  menu_separator

REVISION DETAIL
  https://phabricator.kde.org/D22011

To: astippich, mart, apol, ngraham
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22034: Introcuce ContainmentLayoutManager QML plugin

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  This QML plugin offers a reusable, C++ based framework to manage layout
  of items (mainly plasmoids but other stuff too) inside Plasma Containments
  This will replace the Javascript based plasmoid layout manager inside the
  FolderView and Desktop containments (is planned also forPlasma mobile 
homescreen)
  This makes folderview code simpler and layouting more reliable.
  Relayouting behavior after screen resolution change improved too, making 
easier to
  keep a similar looking layout

TEST PLAN
  Tested on FolderView, a minimal containment using it may be shipped on the 
store
  if we don't feel to ship the folderview port immediately

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/containmentlayoutmanager

REVISION DETAIL
  https://phabricator.kde.org/D22034

AFFECTED FILES
  components/CMakeLists.txt
  components/containmentlayoutmanager/CMakeLists.txt
  components/containmentlayoutmanager/abstractlayoutmanager.cpp
  components/containmentlayoutmanager/abstractlayoutmanager.h
  components/containmentlayoutmanager/appletcontainer.cpp
  components/containmentlayoutmanager/appletcontainer.h
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/configoverlay.cpp
  components/containmentlayoutmanager/configoverlay.h
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.cpp
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.h
  components/containmentlayoutmanager/gridlayoutmanager.cpp
  components/containmentlayoutmanager/gridlayoutmanager.h
  components/containmentlayoutmanager/itemcontainer.cpp
  components/containmentlayoutmanager/itemcontainer.h
  components/containmentlayoutmanager/qml/BasicAppletContainer.qml
  components/containmentlayoutmanager/qml/ConfigOverlayWithHandles.qml
  components/containmentlayoutmanager/qml/PlaceHolder.qml
  components/containmentlayoutmanager/qml/private/BasicResizeHandle.qml
  components/containmentlayoutmanager/qml/qmldir
  components/containmentlayoutmanager/resizehandle.cpp
  components/containmentlayoutmanager/resizehandle.h

To: mart, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22035: first prototype of port to the new C++ layout code

[Marco Martin]

mart created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  sync edit mode
  
  bigger applet handles on touch interaction
  
  remove dead code
  
  folderViewLayer child of appletsLayout
  
  appletsLayout event filters its children, so event management works nice
  
  support handle on hover again
  
  isupport drag applets between containments
  
  better support of applet draf between conts
  
  destroy container when moving applets between containments
  
  Merge branch 'master' into mart/newlayout
  
  remove dead code
  
  base config key switch on availableScreenRect geometry

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/ConfigOverlay.qml

To: mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22035: first prototype of port to the new C++ layout code

[Marco Martin]

mart updated this revision to Diff 60461.
mart added a comment.


  - no automatic edit mode for now

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=60460&id=60461

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/ConfigOverlay.qml

To: mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21991: Add X-KDE-ParentApp entries in metadata.desktop

[Kai Uwe Broulik]

broulik reopened this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> metadata.desktop:150
>  Icon=preferences-desktop-notification-bell
> -X-KDE-ParentApp=
> +X-KDE-ParentApp=org.kde.plasmashell
>  X-KDE-PluginInfo-Author=Kai Uwe Broulik

This causes the notification plasmoid to not show up in system tray anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21991

To: bshah, apol, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22037: [Notifications] Don't show remaining time when job is paused

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Downloaded something, got a "3 minutes remaining", paused it, remaining time 
disappeared.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22037

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationHeader.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart added a comment.


  Before:
  F6927347: Screenshot_20190623_140805.png 

  After:
  F6927342: Screenshot_20190623_140647.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22039: Start sending download updates again when resuming a download

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When there are no active downloads the update timer stops automatically but 
it was only restarted when a new download was created, not when one was paused 
and then unpaused.

TEST PLAN
  - Started a download, paused it through notifications, unpaused it: it now 
updated correctly again
  - Verified that the timer still stops automatically when there is no download 
running

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22039

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Nathaniel Graham]

ngraham added a comment.


  +1 visually!
  
  I wonder if it might make sense to make the icons on the handle bigger even 
in desktop mode. They're awfully small, and bigger click targets can help 
desktop users, too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22041: [Avatar Gallery] Increase minimum width

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  3 entries now fit in a row instead of 2.

REPOSITORY
  R128 User Manager

BRANCH
  wider-avatar-gallery-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22041

AFFECTED FILES
  src/avatargallery.ui

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22041: [Avatar Gallery] Increase minimum width

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit! Stable branch please.

REPOSITORY
  R128 User Manager

BRANCH
  wider-avatar-gallery-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22041

To: filipf, #vdg, ngraham, ndavis
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22041: [Avatar Gallery] Increase minimum width

[Filip Fila]

filipf added a comment.


  In D22041#485251 , @ngraham wrote:
  
  > Shipit! Stable branch please.
  
  
  I don't have an earlier copy now, but IIRC there were enough thumbnails in a 
row before, it's only when we added the new Konqi ones that the thumbnails 
increased in width.

REPOSITORY
  R128 User Manager

BRANCH
  wider-avatar-gallery-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22041

To: filipf, #vdg, ngraham, ndavis
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22041: [Avatar Gallery] Increase minimum width

[Nathaniel Graham]

ngraham added a comment.


  Oh right, because they're wider now.

REPOSITORY
  R128 User Manager

BRANCH
  wider-avatar-gallery-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22041

To: filipf, #vdg, ngraham, ndavis
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22041: [Avatar Gallery] Increase minimum width

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:82fe6ba3830b: [Avatar Gallery] Increase minimum width 
(authored by filipf).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22041?vs=60473&id=60481

REVISION DETAIL
  https://phabricator.kde.org/D22041

AFFECTED FILES
  src/avatargallery.ui

To: filipf, #vdg, ngraham, ndavis
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg updated this revision to Diff 60482.
romangg added a comment.


  Rebase Fredrik's dma-buf code on master

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10750?vs=29953&id=60482

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10750

AFFECTED FILES
  platformsupport/scenes/opengl/abstract_egl_backend.cpp
  platformsupport/scenes/opengl/abstract_egl_backend.h
  platformsupport/scenes/opengl/backend.cpp
  platformsupport/scenes/opengl/backend.h
  plugins/scenes/opengl/scene_opengl.cpp
  plugins/scenes/opengl/scene_opengl.h
  scene.cpp
  scene.h
  wayland_server.cpp
  wayland_server.h

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

[Méven Car]

meven updated this revision to Diff 60484.
meven added a comment.


  Adjust font size

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60446&id=60484

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22028: Improve QWidget KCM and QML KCM consistency

[Méven Car]

meven updated this revision to Diff 60485.
meven added a comment.


  Remove changes that will go to another review

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60484&id=60485

BRANCH
  fix-title-qml

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22044: Fix a Qml warning

[Méven Car]

meven created this revision.
meven added reviewers: mart, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Fix a bad reference

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22044

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, mart, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22044: Fix a Qml warning

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:71dbbbeb64a1: Fix a Qml warning (authored by meven).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22044?vs=60486&id=60487

REVISION DETAIL
  https://phabricator.kde.org/D22044

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: meven, mart, #plasma, filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21991: Add X-KDE-ParentApp entries in metadata.desktop

[Bhushan Shah]

bshah abandoned this revision.
bshah added a comment.


  I've reverted this change now and have come up with more nicer solution in 
kpackagetool5, will open PR for it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21991

To: bshah, apol, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Nathaniel Graham]

ngraham added a comment.


  Works perfectly with my testing on using both a pointing device and 
touchscreen. The touchscreen use case in particular is hugely improved.
  
  I'm not an expert on this code, but it looks pretty sane to me on 
read-through.

INLINE COMMENTS

> main.qml:322
> +/*
>  MouseArea { // unfocus any plasmoid when clicking empty desktop area
>  anchors.fill: parent

The feature seems to work without this commented code; can we remove it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart updated this revision to Diff 60493.
mart added a comment.


  - remove dead code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=60461&id=60493

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/ConfigOverlay.qml

To: mart
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21999: [WIP] Make highlights similar to Kickoff highlight

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:df5ab1bfa328: Make context menu highlight similar to 
Kickoff highlight (authored by ndavis).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21999?vs=60353&id=60494#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21999?vs=60353&id=60494

REVISION DETAIL
  https://phabricator.kde.org/D21999

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #breeze, #vdg, #plasma
Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22045: [Notifications] Make popup placement more resilient

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The popup width is fixed, so don't rely on the actual dialog window width 
which might be bollocks.
  More importantly, place the popups immediately and before they are shown so 
they show up correctly and don't fly all over the place.

TEST PLAN
  The first popup might still fly in from outside the screen or something but 
it's a significant improvement on wayland at least.
  
  (Don't really know which bugreport on bugzilla is that particular issue, 
there's some others with notification popups overlapping and appearing in 
random places but might be unrelated)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22045

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22046: Make feedback-related strings accurate

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, nicolasfella, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Prior strings were inaccurate (I was the one who changed it, sorry about that)
  and talked about visual feedback for something that was actually about audio
  feedback. Adjust strings to be clearer and actually accurate.

TEST PLAN
  F6927847: Screenshot_20190623_163238.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  improve-strings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22046

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, nicolasfella, drosca
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22045: [Notifications] Make popup placement more resilient

[Nathaniel Graham]

ngraham added a comment.


  Stable branch please

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22045

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22045: [Notifications] Make popup placement more resilient

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22045

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22048: [Notifications] Don't keep non-configurable notifications in history

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  If a notification isn't configurable (e.g. because the application doesn't 
set a `desktop-entry` hint), there's no way for the user to keep it out of the 
history if they so desire, causing excess history spam.

TEST PLAN
  - my vlc player and thunderbird no longer show up in the history which was 
90% of pointless notifications I had in the history

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22048

AFFECTED FILES
  libnotificationmanager/notificationfilterproxymodel.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22048: [Notifications] Don't keep non-configurable notifications in history

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, if an app can't bother to set this stuff properly for itself, then it's 
either not very important or doesn't deserve to be in the history. Works 
perfectly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22048

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> abstract_egl_backend.cpp:427
> +
> +// FIXME: Add support for multi-planar images
> +if (planes.count() != 1)

What's holding us from doing that?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D21829: Improved Touch support for Kickoff

[Marco Martin]

mart added a comment.


  not entering in the code yet, i'm ok with it as a general UX behavior

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

To: steffenh, #plasma, hein, ngraham
Cc: mart, sbergeron, davidedmundson, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10750: wayland: Add support for zwp_linux_dmabuf

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> abstract_egl_backend.cpp:438-439
> +EGL_DMA_BUF_PLANE0_PITCH_EXT,   EGLint(planes[0].stride),
> +EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT, EGLint(planes[0].modifier & 
> 0x),
> +EGL_DMA_BUF_PLANE0_MODIFIER_HI_EXT, EGLint(planes[0].modifier >> 32),
> +EGL_NONE

Perhaps we need to add modifier only if EGL_EXT_image_dma_buf_import_modifiers 
is present.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D21999: [WIP] Make highlights similar to Kickoff highlight

[Nathaniel Graham]

ngraham reopened this revision.
ngraham added a comment.


  Not actually closed; Phab just failed to notice that this went to a WIP 
branch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D21999

To: ndavis, #breeze, #vdg, #plasma
Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22045: [Notifications] Make popup placement more resilient

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Much better, but it still has one callLater which I don't like.
  
  Time for Dialog2!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22045

To: broulik, #plasma, #vdg, ngraham, nicolasfella, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22045: [Notifications] Make popup placement more resilient

[Kai Uwe Broulik]

broulik updated this revision to Diff 60510.
broulik added a comment.


  - Fix typo

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22045?vs=60509&id=60510

REVISION DETAIL
  https://phabricator.kde.org/D22045

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, ngraham, nicolasfella, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22045: [Notifications] Make popup placement more resilient

[Kai Uwe Broulik]

broulik updated this revision to Diff 60509.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - get rid of `Qt.callLater`
  - Fix (work around) issue when dialog contents arent ready yet

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22045?vs=60492&id=60509

REVISION DETAIL
  https://phabricator.kde.org/D22045

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, ngraham, nicolasfella, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22046: Make feedback-related strings accurate

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:5ff03a6be245: Make feedback-related strings accurate 
(authored by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22046?vs=60495&id=60515

REVISION DETAIL
  https://phabricator.kde.org/D22046

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, nicolasfella, drosca
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22045: [Notifications] Make popup placement more resilient

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c26fd34c7d60: [Notifications] Make popup placement more 
resilient (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22045?vs=60510&id=60519

REVISION DETAIL
  https://phabricator.kde.org/D22045

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, ngraham, nicolasfella, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22048: [Notifications] Don't keep non-configurable notifications in history

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1f6050b1740c: [Notifications] Don't keep 
non-configurable notifications in history (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22048?vs=60499&id=60520

REVISION DETAIL
  https://phabricator.kde.org/D22048

AFFECTED FILES
  libnotificationmanager/notificationfilterproxymodel.cpp

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22017: [Notifications] Let plasmashell be the only true owner of notification and job tracker services

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:52bec414aefa: [Notifications] Let plasmashell be the only 
true owner of notification and job… (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22017?vs=60420&id=60517

REVISION DETAIL
  https://phabricator.kde.org/D22017

AFFECTED FILES
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/jobsmodel.h
  libnotificationmanager/jobsmodel_p.cpp
  libnotificationmanager/jobsmodel_p.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/server.cpp
  libnotificationmanager/server.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/utils.cpp
  libnotificationmanager/utils_p.h
  shell/main.cpp

To: broulik, #plasma, mvourlakos, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22037: [Notifications] Don't show remaining time when job is paused

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:48da3382b2bf: [Notifications] Don't show remaining 
time when job is paused (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22037?vs=60466&id=60518

REVISION DETAIL
  https://phabricator.kde.org/D22037

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationHeader.qml

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22039: Start sending download updates again when resuming a download

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ae8fab32f84b: Start sending download updates again when 
resuming a download (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22039?vs=60469&id=60521

REVISION DETAIL
  https://phabricator.kde.org/D22039

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, fvogt, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21999: [WIP] Make highlights similar to Kickoff highlight

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:b61b97dc6b5b: Make context menu highlight similar to 
Kickoff highlight (authored by ndavis, committed by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21999?vs=60494&id=60523#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21999?vs=60494&id=60523

REVISION DETAIL
  https://phabricator.kde.org/D21999

AFFECTED FILES
  kstyle/breezehelper.cpp

To: ndavis, #breeze, #vdg, #plasma
Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  In D20908#485103 , @filipf wrote:
  
  > Preview of a highlight style in line with what's being discussed in T11124 
:
  >
  > F6927189: image.png 
  >
  > From a technical POV is it possible to reuse the widgets/tasks SVG here?
  
  
  just answered in real life.
  short answer is.. better not :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D21999: [WIP] Make highlights similar to Kickoff highlight

[Nathaniel Graham]

ngraham added a comment.


  I guess we should just keep this revision closed due to `arc` sadness, and 
submit the final branch once it's all done.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D21999

To: ndavis, #breeze, #vdg, #plasma
Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  `TaskGroupingProxyModel::requestToggleMaximized` now uses this to
  minimize and restore groups of windows while preserving the
  stacking order, a frequently user-requested wish.
  BUG:368867
  
  Window activation is additionally tracked to implement a new front-
  end feature to activate the most recently active window (or fall
  through to stacking order otherwise) subsequently.
  CCBUG:379259
  
  A Wayland implementation requires the addition of a
  `PlasmaWindowManagement::stackingOrder()`, which should be a QList
  of PlasmaWindow* in stacking order, along with a change signal. We
  discussed this at the Plasma+KWin sprint and I'll code up patches
  to KWin and KWayland soon and then implement the new API in here.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22053

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21954: Handle Gimp 2.10

[Diego Marino]

dmarino added a comment.


[Mapping]
Gimp-2.10=org.gimp.GIMP
  
  This is required to solve the same issue for the flatpak package. Is there a 
way to reconcile both workarounds?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21954

To: hein, ngraham
Cc: dmarino, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21935: [devicenotifier] Hide plasmoid if no device is available

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  @nicolasfella and I were discussing with someone else (@mart maybe?) redoing 
the System Tray configuration pages to collapse the General and Entries pages 
into a single list that displays Configure buttons for the configurable 
applets. That would help with the issue of configurability for 
hidden-by-default applets.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hideit

REVISION DETAIL
  https://phabricator.kde.org/D21935

To: nicolasfella, #plasma, ngraham, broulik
Cc: mart, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D22011: Add MenuSeparator

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:6eb266c3d4fc: Add MenuSeparator (authored by astippich).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22011?vs=60433&id=60528

REVISION DETAIL
  https://phabricator.kde.org/D22011

AFFECTED FILES
  org.kde.desktop/MenuSeparator.qml

To: astippich, mart, apol, ngraham
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22060: [Task Manager] Prefer PID match even when desktop entry doesn't match

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When an application got renamed by flatpak-builder without knowing it, it 
will still send its original value as desktop-entry breaking the mapping. If 
the PID of the service matches the window owner's PID imho it's fine to assume 
it's a match.

TEST PLAN
  5.16?
  
  - My spotify snap has media controls in its context menu and tooltip now
  - p-b-i (where the host binary doesn't match the browser window) still works 
for both Chrome and Firefix
  - VLC player still works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22060

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Fredrik Höglund]

fredrik added inline comments.

INLINE COMMENTS

> zzag wrote in abstract_egl_backend.cpp:427
> What's holding us from doing that?

We would need to create a separate EGL image and a separate texture for each 
plane.
The scene would need to bind each of those textures to separate texture binding 
points, and we would need to generate and use a shader that samples texels from 
each plane and performs YUV to RGB conversion.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart