KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 59 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/59/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Jun 2019 03:20:53 +
 Build duration:
8 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/14)0%
(0/59)0%
(0/59)0%
(0/3768)0%
(0/1566)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/8)0%
(0/8)0%
(0/461)0%
(0/162)Modules.about-distro.src0%
(0/2)0%
(0/2)0%
(0/150)0%
(0/52)Modules.base0%
(0/3)0%
(0/3)0%
(0/396)0%
(0/132)Modules.devinfo0%
(0/11)0%
(0/11)0%
(0/664)0%
(0/202)Modules.energy0%
(0/8)0%
(0/8)0%
(0/265)0%
(0/135)Modules.fileindexermonitor0%
(0/2)0%
(0/2)0%
(0/8)100%
(0/0)Modules.info0%
(0/2)0%
(0/2)0%
(0/53)0%
(0/6)Modules.memory0%
(0/6)0%
(0/6)0%
(0/274)0%
(0/64)Modules.nics0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/38)Modules.opengl0%
(0/1)0%
(0/1)0%
(0/409)0%
(0/223)Modules.pci0%
(0/1)0%
(0/1)0%
(0/28)100%
(0/0)Modules.samba0%
(0/9)0%
(0/9)0%
(0/546)0%
(0/348)Modules.usbview0%
(0/4)0%
(0/4)0%
(0/327)0%
(0/180)ToolTips0%
(0/1)0%
(0/1)0%
(0/86)0%
(0/24)

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 66 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.12/66/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 21:00:12 +
 Build duration:
1 hr 3 min and counting
   CONSOLE OUTPUT
  [...truncated 2064 lines...][2019-06-24T22:03:15.455Z] [ 42%] Building CXX object autotests/libinput/CMakeFiles/testLibinputDevice.dir/mock_libinput.cpp.o[2019-06-24T22:03:15.711Z] [ 42%] Built target testScreenPaintData_autogen[2019-06-24T22:03:15.711Z] Scanning dependencies of target fakeeffectplugin_autogen[2019-06-24T22:03:15.711Z] [ 42%] Building CXX object autotests/libinput/CMakeFiles/testLibinputDevice.dir/__/__/libinput/device.cpp.o[2019-06-24T22:03:15.711Z] [ 42%] Automatic MOC for target fakeeffectplugin[2019-06-24T22:03:15.711Z] [ 42%] Built target fakeeffectplugin_autogen[2019-06-24T22:03:15.711Z] [ 42%] Building CXX object autotests/libinput/CMakeFiles/testLibinputDevice.dir/testLibinputDevice_autogen/mocs_compilation.cpp.o[2019-06-24T22:03:15.711Z] Scanning dependencies of target kwin_cubeslide_config_autogen[2019-06-24T22:03:15.711Z] [ 42%] Generating cubeslide_config.json[2019-06-24T22:03:15.711Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/kcmodule.desktop"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-FactoryName" with type "QString"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-ParentComponents" with type "QStringList"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-CfgDlgHierarchy" with type "QString"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-System-Settings-Parent-Category" with type "QString"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-KInfoCenter-Category" with type "QString"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-Weight" with type "int"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-PluginKeyword" with type "QString"[2019-06-24T22:03:15.711Z] Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"[2019-06-24T22:03:15.711Z] Generated  "/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 SUSEQt5.12/build/effects/cubeslide/cubeslide_config.json" [2019-06-24T22:03:15.711Z] [2019-06-24T22:03:15.711Z] [ 42%] Automatic MOC for target kwin_cubeslide_config[2019-06-24T22:03:15.967Z] [ 42%] Built target kwin_cubeslide_config_autogen[2019-06-24T22:03:15.967Z] Scanning dependencies of target kwin_desktopgrid_config_autogen[2019-06-24T22:03:15.967Z] [ 42%] Generating desktopgrid_config.json[2019-06-24T22:03:15.967Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/kcmodule.desktop"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-FactoryName" with type "QString"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-ParentComponents" with type "QStringList"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-CfgDlgHierarchy" with type "QString"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-System-Settings-Parent-Category" with type "QString"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-KInfoCenter-Category" with type "QString"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-Weight" with type "int"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-PluginKeyword" with type "QString"[2019-06-24T22:03:15.967Z] Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"[2019-06-24T22:03:15.967Z] Generated  "/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 SUSEQt5.12/build/effects/desktopgrid/desktopgrid_config.json" [2019-06-24T22:03:15.967Z] [2019-06-24T22:03:15.968Z] [ 42%] Automatic MOC for target kwin_desktopgrid_config[2019-06-24T22:03:16.228Z] [ 42%] Built target kwin_desktopgrid_config_autogen[2019-06-24T22:03:16.228Z] Scanning dependencies of target effectversionplugin_autogen[2019-06-24T22:03:16.228Z] Scanning dependencies of target kwin4_effect_builtins_autogen[2019-06-24T22:03:16.228Z] Scanning dependencies of target timelinetest_autogen[2019-06-24T22:03:16.228Z] [ 43%] Automatic MOC for target effectversionplugin[2019-06-24T22:03:16.228Z] [ 43%] Automatic MOC for target kwin4_effect_builtins[2019-06-24T22:03:16.228Z] [ 43%] Automatic MOC for target timelinetest[2019-06-24T22:03:16.228Z] Scanning dependencies of target windowquadlisttest_autogen[2019-06-24T22:03:16.228Z] [ 43%] Automatic MOC for target windowquadlisttest[2019-06-24T22:03:16.497Z] [ 43%] Built target effectversionplugin_autogen[2019-06-24T22:03:16.497Z] Scanning dependencies of target kwin_rules_dialog[2019-06-24T22:03:16.497Z] [ 43%] Built target timelinetest_autogen[2019-06-24T22:03:16.497Z] [ 43%] Generating desktopgridconfig.h, desktopgridconfig.cpp[2019-06-24T22:03:16.497Z] [ 43%] Building CXX object kcmkwin/kwinrules/CMakeFiles/kwin_rules_dialog.dir/kwin_rules_dialog_dummy.cpp.o[2019-06-24T22:03:16.497Z] [ 43%] Generating 

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/58/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 20:41:45 +
 Build duration:
1 hr 17 min and counting
   CONSOLE OUTPUT
  [...truncated 742 lines...][2019-06-24T21:59:21.451Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/kcmcontainer.cpp: In member function ���QString KcmContainer::exportText() const���:[2019-06-24T21:59:21.451Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/kcmcontainer.cpp:140:44: warning: ���QString KCModule::exportText() const��� is deprecated [-Wdeprecated-declarations][2019-06-24T21:59:21.451Z]   140 | return m_mod->realModule()->exportText();[2019-06-24T21:59:21.451Z]   |^[2019-06-24T21:59:21.451Z] In file included from /home/jenkins/install-prefix/include/KF5/KConfigWidgets/KCModule:1,[2019-06-24T21:59:21.451Z]  from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/kcmcontainer.h:29,[2019-06-24T21:59:21.451Z]  from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/kcmcontainer.cpp:23:[2019-06-24T21:59:21.451Z] /home/jenkins/install-prefix/include/KF5/KConfigWidgets/kcmodule.h:255:39: note: declared here[2019-06-24T21:59:21.451Z]   255 | KCONFIGWIDGETS_DEPRECATED QString exportText() const;[2019-06-24T21:59:21.451Z]   |   ^~[2019-06-24T21:59:21.708Z] [ 64%] Linking CXX shared module ../../bin/kcm_usb.so[2019-06-24T21:59:21.965Z] [ 65%] Building CXX object CMakeFiles/kinfocenter.dir/kcmtreeitem.cpp.o[2019-06-24T21:59:21.965Z] [ 67%] Linking CXX shared module ../../bin/kcm_memory.so[2019-06-24T21:59:21.965Z] In file included from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/devicelisting.h:40,[2019-06-24T21:59:21.965Z]  from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/devinfo.h:36,[2019-06-24T21:59:21.965Z]  from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/infopanel.h:41,[2019-06-24T21:59:21.965Z]  from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/infopanel.cpp:22:[2019-06-24T21:59:21.965Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/soldevice.h:111:10: warning: ���virtual bool SolDevice::operator<(const QTreeWidgetItem&) const��� can be marked override [-Wsuggest-override][2019-06-24T21:59:21.965Z]   111 | bool operator< (const QTreeWidgetItem & other) const;[2019-06-24T21:59:21.965Z]   |  ^~~~[2019-06-24T21:59:22.221Z] In file included from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/soldevicetypes.h:28,[2019-06-24T21:59:22.221Z]  from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/soldevicetypes.cpp:22:[2019-06-24T21:59:22.221Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/devinfo/soldevice.h:111:10: warning: ���virtual bool SolDevice::operator<(const QTreeWidgetItem&) const��� can be marked override [-Wsuggest-override][2019-06-24T21:59:22.221Z]   111 | bool operator< (const QTreeWidgetItem & other) const;[2019-06-24T21:59:22.221Z]   |  ^~~~[2019-06-24T21:59:22.221Z] [ 67%] Built target kcm_usb[2019-06-24T21:59:22.221Z] [ 68%] Building CXX object CMakeFiles/kinfocenter.dir/kcmcategoryitem.cpp.o[2019-06-24T21:59:22.221Z] [ 69%] Linking CXX shared module ../../bin/kcm_info.so[2019-06-24T21:59:22.221Z] [ 69%] Built target kcm_memory[2019-06-24T21:59:22.221Z] [ 70%] Building CXX object Modules/opengl/CMakeFiles/kcm_opengl.dir/kcm_opengl_autogen/mocs_compilation.cpp.o[2019-06-24T21:59:22.484Z] [ 71%] Building CXX object CMakeFiles/kinfocenter.dir/infokcmmodel.cpp.o[2019-06-24T21:59:22.484Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/opengl/opengl.cpp: In function ���bool GetInfo_OpenGL(QTreeWidget*)���:[2019-06-24T21:59:22.484Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/opengl/opengl.cpp:961:13: warning: variable ���numScreens��� set but not used [-Wunused-but-set-variable][2019-06-24T21:59:22.484Z]   961 | int numScreens, scrnum;[2019-06-24T21:59:22.484Z]   | ^~[2019-06-24T21:59:22.484Z] [ 72%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcmsambastatistics.cpp.o[2019-06-24T21:59:22.740Z] [ 73%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcm_samba_autogen/mocs_compilation.cpp.o[2019-06-24T21:59:22.740Z] [ 73%] Built target kcm_info[2019-06-24T21:59:22.740Z] Scanning dependencies of target kcm_pci[2019-06-24T21:59:22.740Z] [ 75%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/kcm_pci.cpp.o[2019-06-24T21:59:22.740Z] [ 76%] Building CXX object 

D22028: Improve QWidget KCM and QML KCM consistency

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:4d5321648e9a: Improve QWidget KCM and QML KCM consistency 
(authored by meven).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22028?vs=60485=60619

REVISION DETAIL
  https://phabricator.kde.org/D22028

AFFECTED FILES
  kcmcontainer.cpp

To: meven, mart, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18860: Add comment / description to the translations kcm

[Jonah Brüchert]

jbbgameich added a comment.


  ping

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22084: Span wayland objects to lifespan of the QApplication

[Nathaniel Graham]

ngraham added a comment.


  Would this happen to fix https://bugs.kde.org/show_bug.cgi?id=372789?

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22084

To: davidedmundson, #plasma
Cc: ngraham, anthonyfieroni, zzag, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22075: [Notifications] Swap configure and clear buttons in full representation header

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:11387ca37f91: [Notifications] Swap configure and clear 
buttons in full representation header (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22075?vs=60588=60606

REVISION DETAIL
  https://phabricator.kde.org/D22075

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22084: Span wayland objects to lifespan of the QApplication

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in waylandintegration.cpp:95-99
> Since qApp is the parent are they needed? When destroyed qApp will call 
> delete on m_waylandBlurManager, no?

Or that's when removed during the normal execution?

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22084

To: davidedmundson, #plasma
Cc: anthonyfieroni, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22084: Span wayland objects to lifespan of the QApplication

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> waylandintegration.cpp:95-99
>  connect(m_waylandBlurManager, 
> ::Client::BlurManager::removed, this,
>  [this] () {
>  m_waylandBlurManager->deleteLater();
> -m_waylandBlurManager = nullptr;
>  }
>  );

Since qApp is the parent are they needed? When destroyed qApp will call delete 
on m_waylandBlurManager, no?

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22084

To: davidedmundson, #plasma
Cc: anthonyfieroni, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22084: Span wayland objects to lifespan of the QApplication

[Vlad Zagorodniy]

zzag added a comment.


  Is there any reason for not making WaylandIntegration a child of qApp? 
(disclaimer: I don't have full insight into the problem)

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22084

To: davidedmundson, #plasma
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22084: Span wayland objects to lifespan of the QApplication

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We must release all wayland objects before the QPA connection is closed.
  
  We used to do this explicitly, but this still left an awkward code path
  where we could still try to recreate a BlurManager if it's called after
  the QApplication is closed.
  
  Instead we can scope all the wayland objects to the QApplication. The
  objects themselves were not leaked as public API so this is safe. Calls
  after this will simply no-op.
  
  This fixes crashes on tear down of plasma.

TEST PLAN
  kquitapp5 plasmashell

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22084

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22078: Use the native resolution image

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:be12c1a1262b: Use the native resolution image (authored 
by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22078?vs=60594=60597

REVISION DETAIL
  https://phabricator.kde.org/D22078

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22079: Show an entry on the system tray indicator when a portal is needed

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
apol requested review of this revision.

REVISION SUMMARY
  This way it's still accessible if I lose the notification somehow.

TEST PLAN
  I don't get it when connected normally on the internet. I managed to reach 
the portal when on the plane.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22079

AFFECTED FILES
  applet/contents/ui/main.qml
  libs/declarative/connectionicon.cpp
  libs/declarative/connectionicon.h

To: apol, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22078: Use the native resolution image

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of loading the image size of the scaled window, use the actual 
resolution of the display.
  This way no scaling will be needed on high dpi displays.

TEST PLAN
  Added debug statements that load the wallpaper that matches my monitor size.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22078

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22077: [Colors KCM] Add title bar to preview delegate

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes the difference between Breeze and Breeze Light more pronounced.

TEST PLAN
  Depends on D22076 
  Also implements the subtle gradient Brezee window decoration has

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22077

AFFECTED FILES
  kcms/colors/colorsmodel.cpp
  kcms/colors/colorsmodel.h
  kcms/colors/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22075: [Notifications] Swap configure and clear buttons in full representation header

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This makes it consistent with the configure button of the items in the list 
below.
  
  BUG: 409140
  FIXED-IN: 5.16.2

TEST PLAN
  F6931175: Screenshot_20190624_173300.png 

  When the history is empty, the clear button is disabled instead of hidden to 
keep the configure button from shifting around

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22075

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60584.
filipf added a comment.


  highlight effect: remove unused ID and bettery opacity values

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60583=60584

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60583.
filipf added a comment.


  Also implement the upcoming highlight style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60115=60583

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 322 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/322/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 24 Jun 2019 14:32:44 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21702: Ship color schemes with Oxygen

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R113:70243942ef1d: Ship color schemes with Oxygen (authored by 
filipf).

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21702?vs=59464=60582

REVISION DETAIL
  https://phabricator.kde.org/D21702

AFFECTED FILES
  CMakeLists.txt
  color-schemes/CMakeLists.txt
  color-schemes/ExtraDesktop.sh
  color-schemes/Oxygen.colors
  color-schemes/OxygenCold.colors

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21701: [kcm-colors] Do not ship any additional color schemes

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b137ee56fa66: [kcm-colors] Do not ship any additional 
color schemes (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21701?vs=59463=60581

REVISION DETAIL
  https://phabricator.kde.org/D21701

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/schemes/ExtraDesktop.sh
  kcms/colors/schemes/Honeycomb.colors
  kcms/colors/schemes/Norway.colors
  kcms/colors/schemes/ObsidianCoast.colors
  kcms/colors/schemes/Oxygen.colors
  kcms/colors/schemes/OxygenCold.colors
  kcms/colors/schemes/Steel.colors
  kcms/colors/schemes/WontonSoup.colors
  kcms/colors/schemes/Zion.colors
  kcms/colors/schemes/ZionReversed.colors

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, abetts, davidedmundson, nicolasfella, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D21701: [kcm-colors] Do not ship any additional color schemes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Tested removing the color schemes on disk and re-adding them from the new 
items you created on store.kde.org and everything worked perfectly. Let's do it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-more-extra-color-schemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21701

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, abetts, davidedmundson, nicolasfella, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D21701: [kcm-colors] Do not ship any additional color schemes

[Filip Fila]

filipf added a comment.


  All of the color schemes deprecated here are now in the newly-created repo:
  
  
https://invent.kde.org/kde/kde-vdg-extras/tree/master/deprecated/plasma-desktop/kcms/colors/schemes
  
  ... and on the KDE Store:
  
  https://www.pling.com/u/kdecommunity/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21701

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, abetts, davidedmundson, nicolasfella, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D22070: make scripted sleep no-op

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b8f2dc039f64: make scripted sleep no-op (authored by 
sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22070?vs=60568=60570

REVISION DETAIL
  https://phabricator.kde.org/D22070

AFFECTED FILES
  shell/scripting/appinterface.cpp

To: sitter, davidedmundson, mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 35 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/35/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 24 Jun 2019 11:09:16 +
 Build duration:
2 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-06-24T11:12:05.645Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-06-24T11:12:05.645Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-06-24T11:12:05.645Z] PROCESSOR_LEVEL   = '6'[2019-06-24T11:12:05.645Z] PROCESSOR_REVISION= '5e03'[2019-06-24T11:12:05.645Z] PROGRAMDATA   = 'C:\ProgramData'[2019-06-24T11:12:05.645Z] PROGRAMFILES  = 'C:\Program Files'[2019-06-24T11:12:05.645Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-06-24T11:12:05.645Z] PROGRAMW6432  = 'C:\Program Files'[2019-06-24T11:12:05.645Z] PROMPT= '$P$G'[2019-06-24T11:12:05.645Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-06-24T11:12:05.645Z] PUBLIC= 'C:\Users\Public'[2019-06-24T11:12:05.645Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/35/display/redirect?page=changes'[2019-06-24T11:12:05.645Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/35/display/redirect'[2019-06-24T11:12:05.645Z] STAGE_NAME= 'Configuring Build'[2019-06-24T11:12:05.645Z] SYSTEMDRIVE   = 'C:'[2019-06-24T11:12:05.645Z] SYSTEMROOT= 'C:\WINDOWS'[2019-06-24T11:12:05.645Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-24T11:12:05.645Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-06-24T11:12:05.645Z] UCRTVERSION   = '10.0.17763.0'[2019-06-24T11:12:05.645Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-24T11:12:05.645Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-06-24T11:12:05.645Z] USERNAME  = 'Jenkins'[2019-06-24T11:12:05.645Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-06-24T11:12:05.645Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-06-24T11:12:05.645Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-06-24T11:12:05.645Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-06-24T11:12:05.645Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-06-24T11:12:05.645Z] VCTOOLSVERSION= '14.16.27023'[2019-06-24T11:12:05.645Z] VISUALSTUDIOVERSION   = '16.0'[2019-06-24T11:12:05.645Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-06-24T11:12:05.645Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-06-24T11:12:05.645Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-06-24T11:12:05.645Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-06-24T11:12:05.645Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-06-24T11:12:05.646Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-06-24T11:12:05.646Z] VSCMD_VER = '16.0.3'[2019-06-24T11:12:05.646Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-06-24T11:12:05.646Z] WINDIR= 'C:\WINDOWS'[2019-06-24T11:12:05.646Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-06-24T11:12:05.646Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-06-24T11:12:05.646Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-06-24T11:12:05.646Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-06-24T11:12:05.646Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-06-24T11:12:05.646Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-06-24T11:12:05.646Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-06-24T11:12:05.646Z] __DOTNET_ADD_64BIT= '1'[2019-06-24T11:12:05.646Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-06-24T11:12:05.646Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-06-24T11:12:05.646Z] 

D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:a00df4badcd1: show details examples in label itself 
instead of unexpected tooltip (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21745?vs=60565=60569#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21745?vs=60565=60569

REVISION DETAIL
  https://phabricator.kde.org/D21745

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_base.h
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22070: make scripted sleep no-op

[Harald Sitter]

sitter added a comment.


  follow up to D21895 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22070

To: sitter, davidedmundson, mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22070: make scripted sleep no-op

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this was implemented using a nested loop, which is simply not viable
  because nested looping may work on inconsistent object states and cause
  crashes all over the place. furthermore sleeping probably has no real use
  case as there isn't anything you could be sleeping for
  
  prevent any future problems by making the API method do nothing and instead
  print a warning about it being deprecated.
  
  should be removed when moving over to kf6

TEST PLAN
  prints warning when sleeping

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no-sleep

REVISION DETAIL
  https://phabricator.kde.org/D22070

AFFECTED FILES
  shell/scripting/appinterface.cpp

To: sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 shipit!

REPOSITORY
  R871 DrKonqi

BRANCH
  examples

REVISION DETAIL
  https://phabricator.kde.org/D21745

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22068: Send downloads when downloads plugin is loaded

[Kai Uwe Broulik]

broulik added a comment.


  Or maybe I should remove the old code since the change to "update existing 
job when being signalled a creation" was only added in May

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22068

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21762: do not use long deprecated QString::toAscii

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4cf47ad6818d: do not use long deprecated QString::toAscii 
(authored by sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21762?vs=60564=60567

REVISION DETAIL
  https://phabricator.kde.org/D21762

AFFECTED FILES
  libtaskmanager/waylandtasksmodel.cpp

To: sitter, hein, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 121 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/121/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 10:32:49 +
 Build duration:
9 min 53 sec and counting
   CONSOLE OUTPUT
  [...truncated 5 lines...]All nodes of label ‘SUSEQt5.12’ are offlineRunning on Docker Swarm-be49f61ebb9c in /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2019-06-24T10:34:09.856Z] No credentials specified[2019-06-24T10:34:09.951Z] Cloning the remote Git repository[2019-06-24T10:34:10.210Z] Cloning repository git://anongit.kde.org/plasma-workspace[2019-06-24T10:34:10.710Z]  > git init /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12 # timeout=10[2019-06-24T10:34:11.211Z] Fetching upstream changes from git://anongit.kde.org/plasma-workspace[2019-06-24T10:34:11.212Z]  > git --version # timeout=10[2019-06-24T10:34:11.220Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-06-24T10:34:18.516Z]  > git config remote.origin.url git://anongit.kde.org/plasma-workspace # timeout=10[2019-06-24T10:34:18.528Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-06-24T10:34:18.632Z]  > git config remote.origin.url git://anongit.kde.org/plasma-workspace # timeout=10[2019-06-24T10:34:18.757Z] Fetching upstream changes from git://anongit.kde.org/plasma-workspace[2019-06-24T10:34:18.757Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-workspace +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-06-24T10:34:19.507Z] Checking out Revision 3563f51309cc5d7c25983c05d5bdd54292cd962f (refs/remotes/origin/Plasma/5.16)[2019-06-24T10:34:19.343Z]  > git rev-parse Plasma/5.16^{commit} # timeout=10[2019-06-24T10:34:19.448Z]  > git rev-parse refs/remotes/origin/Plasma/5.16^{commit} # timeout=10[2019-06-24T10:34:19.653Z]  > git config core.sparsecheckout # timeout=10[2019-06-24T10:34:19.662Z]  > git checkout -f 3563f51309cc5d7c25983c05d5bdd54292cd962f # timeout=10[2019-06-24T10:34:30.880Z] Commit message: "print a warning when invoking the scripting API's sleep()"[2019-06-24T10:34:30.933Z]  > git rev-list --no-walk 92a6d3f3a3c1200346e13825c7f449e3a9e82446 # timeout=10[Pipeline] checkout[2019-06-24T10:34:32.674Z] No credentials specified[2019-06-24T10:34:32.768Z] Cloning the remote Git repository[2019-06-24T10:34:32.821Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-06-24T10:34:32.821Z]  > git init /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/ci-tooling # timeout=10[2019-06-24T10:34:32.858Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-06-24T10:34:32.859Z]  > git --version # timeout=10[2019-06-24T10:34:32.865Z]  > git fetch --tags --force --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-06-24T10:34:35.072Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-06-24T10:34:35.086Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-06-24T10:34:35.187Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-06-24T10:34:35.288Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-06-24T10:34:35.289Z]  > git fetch --tags --force --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-06-24T10:34:36.092Z] Checking out Revision b2d2001bdb2c9076f9f67513c407245441a244a8 (origin/master)[2019-06-24T10:34:36.322Z] Commit message: "Gitlab (Experimental) CI: Ensure Linux runs tests after the install stage."[Pipeline] checkout[2019-06-24T10:34:36.831Z] No credentials specified[2019-06-24T10:34:36.033Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-06-24T10:34:36.144Z]  > git config core.sparsecheckout # timeout=10[2019-06-24T10:34:36.154Z]  > git checkout -f b2d2001bdb2c9076f9f67513c407245441a244a8 # timeout=10[2019-06-24T10:34:36.925Z] Cloning the remote Git repository[2019-06-24T10:34:36.977Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-06-24T10:34:36.977Z]  > git init /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/ci-tooling/repo-metadata # timeout=10[2019-06-24T10:34:36.998Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-06-24T10:34:36.999Z]  > git --version # timeout=10[2019-06-24T10:34:37.002Z]  > git fetch --tags --force --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[Pipeline] }[Pipeline] // 

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 297 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/297/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 24 Jun 2019 10:32:49 +
 Build duration:
5 min 20 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21895: print a warning when invoking the scripting API's sleep()

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3563f51309cc: print a warning when invoking the scripting 
APIs sleep() (authored by sitter).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21895?vs=60050=60566

REVISION DETAIL
  https://phabricator.kde.org/D21895

AFFECTED FILES
  shell/scripting/appinterface.cpp

To: sitter, mart
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

sitter added a comment.


  F6930248: Screenshot_20190624_122741.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D21745

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21745: show details examples in label itself instead of unexpected tooltip

[Harald Sitter]

sitter updated this revision to Diff 60565.
sitter added a comment.


  set smallest readable font as well. as seen in gwenview

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21745?vs=59586=60565

BRANCH
  examples

REVISION DETAIL
  https://phabricator.kde.org/D21745

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_base.h
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter, ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21762: do not use long deprecated QString::toAscii

[Harald Sitter]

sitter updated this revision to Diff 60564.
sitter added a comment.


  and update again because arcanist hates me

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21762?vs=60563=60564

BRANCH
  no-toascii

REVISION DETAIL
  https://phabricator.kde.org/D21762

AFFECTED FILES
  libtaskmanager/waylandtasksmodel.cpp

To: sitter, hein
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21762: do not use long deprecated QString::toAscii

[Harald Sitter]

sitter updated this revision to Diff 60563.
sitter added a comment.


  concat qstrings as suggested by @apol

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21762?vs=59639=60563

BRANCH
  no-toascii

REVISION DETAIL
  https://phabricator.kde.org/D21762

AFFECTED FILES
  applets/activitybar/metadata.desktop
  applets/analog-clock/metadata.desktop
  applets/appmenu/package/metadata.desktop
  applets/calendar/package/metadata.desktop
  applets/clipboard/metadata.desktop
  applets/devicenotifier/package/metadata.desktop
  applets/devicenotifier/test-predicate-openinwindow.desktop
  applets/digital-clock/package/metadata.desktop
  applets/icon/package/metadata.desktop
  applets/lock_logout/metadata.desktop
  applets/notifications/package/metadata.desktop
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/metadata.desktop
  applets/systemtray/container/package/metadata.desktop
  applets/systemtray/package/metadata.desktop
  appmenu/appmenu.desktop
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc
  components/shellprivate/widgetexplorer/plasmoids.knsrc
  containmentactions/applauncher/plasma-containmentactions-applauncher.desktop
  containmentactions/contextmenu/plasma-containmentactions-contextmenu.desktop
  containmentactions/paste/plasma-containmentactions-paste.desktop
  
containmentactions/switchactivity/plasma-containmentactions-switchactivity.desktop
  
containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop
  containmentactions/switchwindow/plasma-containmentactions-switchwindow.desktop
  dataengines/activities/plasma-dataengine-activities.desktop
  dataengines/applicationjobs/plasma-dataengine-applicationjobs.desktop
  dataengines/apps/plasma-dataengine-apps.desktop
  dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop
  dataengines/dict/plasma-dataengine-dict.desktop
  dataengines/executable/plasma-dataengine-executable.desktop
  dataengines/filebrowser/plasma-dataengine-filebrowser.desktop
  dataengines/geolocation/plasma-geolocation-gps.desktop
  dataengines/geolocation/plasma-geolocation-ip.desktop
  dataengines/hotplug/plasma-dataengine-hotplug.desktop
  dataengines/keystate/plasma-dataengine-keystate.desktop
  dataengines/mouse/plasma-dataengine-mouse.desktop
  dataengines/notifications/plasma-dataengine-notifications.desktop
  dataengines/places/plasma-dataengine-places.desktop
  dataengines/share/packagestructure/plasma-packagestructure-share.desktop
  dataengines/share/plasma-dataengine-share.desktop
  dataengines/soliddevice/plasma-dataengine-soliddevice.desktop
  dataengines/statusnotifieritem/plasma-dataengine-statusnotifieritem.desktop
  dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop
  dataengines/time/plasma-dataengine-time.desktop
  dataengines/weather/ions/bbcukmet/ion-bbcukmet.desktop
  dataengines/weather/ions/noaa/ion-noaa.desktop
  dataengines/weather/plasma-dataengine-weather.desktop
  freespacenotifier/freespacenotifier.desktop
  freespacenotifier/freespacenotifier.notifyrc
  kcms/translations/kcm_translations.desktop
  kcms/translations/package/metadata.desktop
  kioslave/desktop/desktopnotifier.desktop
  klipper/klipper.desktop
  klipper/org.kde.klipper.desktop
  klipper/plasma-dataengine-clipboard.desktop
  ktimezoned/ktimezoned.desktop
  libcolorcorrect/kded/colorcorrectlocationupdater.desktop
  libtaskmanager/waylandtasksmodel.cpp
  phonon/platform_kde/phonon.notifyrc
  plasma-windowed/plasma-windowed.desktop
  runners/calculator/plasma-runner-calculator.desktop
  runners/places/plasma-runner-places.desktop
  shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop
  systemmonitor/org.kde.systemmonitor.desktop

To: sitter, hein
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D19855: Fix bugzilla login page widgets tab order

[Harald Sitter]

sitter commandeered this revision.
sitter edited reviewers, added: marcelomariano; removed: sitter.
sitter added a comment.


  Ah yes, so it is.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

To: sitter, cfeck, #plasma, marcelomariano
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21959: Fix selectedNameFilter() multiple matches

[Robert Hoffmann]

hoffmannrobert added a comment.


  Can you please push it for me, I don't have commit access. Thanks.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fix_selectedNameFilter

REVISION DETAIL
  https://phabricator.kde.org/D21959

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 296 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/296/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 24 Jun 2019 09:09:58 +
 Build duration:
22 min and counting
   CONSOLE OUTPUT
  [...truncated 174 lines...][2019-06-24T09:32:15.440Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-baloo-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-kdecoration-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-kscreenlocker-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-breeze-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-khelpcenter-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-libksysguard-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-kwin-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-milou-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-libkscreen-kf5-qt5[2019-06-24T09:32:15.440Z] Retrieving: Plasma-kactivitymanagerd-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[2019-06-24T09:32:17.232Z] + python3 -u ci-tooling/helpers/configure-build.py --product Plasma --project plasma-workspace --branchGroup kf5-qt5 --platform FreeBSDQt5.12 --installTo /home/jenkins/install-prefix/[2019-06-24T09:32:17.233Z] == Using the following environment to perform the build:[2019-06-24T09:32:17.233Z] JOB_NAME  = 'Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.12'[2019-06-24T09:32:17.233Z] BUILD_NUMBER  = '296'[2019-06-24T09:32:17.233Z] LOGNAME   = 'jenkins'[2019-06-24T09:32:17.233Z] LANG  = 'en_US.UTF-8'[2019-06-24T09:32:17.233Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-06-24T09:32:17.233Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/display/redirect'[2019-06-24T09:32:17.233Z] MAIL  = '/var/mail/jenkins'[2019-06-24T09:32:17.233Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/296/display/redirect?page=changes'[2019-06-24T09:32:17.233Z] JENKINS_URL   = 'https://build.kde.org/'[2019-06-24T09:32:17.233Z] PATH  = '/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-06-24T09:32:17.233Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.12'[2019-06-24T09:32:17.233Z] HUDSON_HOME   = '/home/production/data'[2019-06-24T09:32:17.233Z] BUILD_ID  = '296'[2019-06-24T09:32:17.233Z] OLDPWD= '/usr/home/jenkins'[2019-06-24T09:32:17.233Z] PWD   = '/usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.12'[2019-06-24T09:32:17.233Z] _ = '/usr/local/bin/java'[2019-06-24T09:32:17.233Z] TERM  = 'su'[2019-06-24T09:32:17.233Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.12'[2019-06-24T09:32:17.233Z] BUILD_TAG = 'jenkins-Plasma-plasma-workspace-kf5-qt5 FreeBSDQt5.12-296'[2019-06-24T09:32:17.233Z] BUILD_DISPLAY_NAME= '#296'[2019-06-24T09:32:17.233Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/296/display/redirect'[2019-06-24T09:32:17.233Z] USER  = 'jenkins'[2019-06-24T09:32:17.233Z] HOME  = '/home/jenkins'[2019-06-24T09:32:17.233Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/296/'[2019-06-24T09:32:17.233Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/'[2019-06-24T09:32:17.233Z] HUDSON_URL= 'https://build.kde.org/'[2019-06-24T09:32:17.233Z] SHELL = '/usr/local/bin/bash'[2019-06-24T09:32:17.233Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 FreeBSDQt5.12'[2019-06-24T09:32:17.233Z] MM_CHARSET= 'UTF-8'[2019-06-24T09:32:17.233Z] STAGE_NAME= 'Configuring Build'[2019-06-24T09:32:17.233Z] NODE_NAME = 'FreeBSD Builder 2'[2019-06-24T09:32:17.233Z] BLOCKSIZE = 'K'[2019-06-24T09:32:17.233Z] EXECUTOR_NUMBER   = '0'[2019-06-24T09:32:17.233Z] SHLVL = '0'[2019-06-24T09:32:17.233Z] CMAKE_PREFIX_PATH = '/usr/:/usr/local/'[2019-06-24T09:32:17.233Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-06-24T09:32:17.233Z] XDG_DATA_DIRS = '/usr/share:/usr/local/share'[2019-06-24T09:32:17.233Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2019-06-24T09:32:17.233Z] XDG_CONFIG_DIRS   = 

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 321 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/321/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 24 Jun 2019 09:16:04 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.12’Ready to run at Mon Jun 24 09:31:28 UTC 2019Resuming build at Mon Jun 24 09:31:28 UTC 2019 after Jenkins restartRunning on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2019-06-24T09:31:35.706Z] No credentials specified[2019-06-24T09:31:35.716Z] Cloning the remote Git repository[2019-06-24T00:47:54.635Z] Cloning repository git://anongit.kde.org/plasma-desktop[2019-06-24T00:47:54.656Z]  > git init /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.12 # timeout=10[2019-06-24T00:47:54.685Z] Fetching upstream changes from git://anongit.kde.org/plasma-desktop[2019-06-24T00:47:54.686Z]  > git --version # timeout=10[2019-06-24T00:47:54.696Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-desktop +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-06-24T09:31:42.454Z] Checking out Revision 7a0b158c7a9b193b1cf2ad78781cdb9701d45b10 (origin/master)[2019-06-24T00:48:00.961Z]  > git config remote.origin.url git://anongit.kde.org/plasma-desktop # timeout=10[2019-06-24T00:48:00.993Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-06-24T00:48:01.049Z]  > git config remote.origin.url git://anongit.kde.org/plasma-desktop # timeout=10[2019-06-24T00:48:01.062Z] Fetching upstream changes from git://anongit.kde.org/plasma-desktop[2019-06-24T00:48:01.062Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-desktop +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-06-24T00:48:01.225Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-06-24T00:48:01.349Z]  > git config core.sparsecheckout # timeout=10[2019-06-24T00:48:01.357Z]  > git checkout -f 7a0b158c7a9b193b1cf2ad78781cdb9701d45b10 # timeout=10[2019-06-24T09:31:44.400Z] Commit message: "Merge branch 'Plasma/5.16'"[2019-06-24T00:48:03.283Z]  > git rev-list --no-walk c123bb09de4569fea65c3dacb614261533db5e1a # timeout=10[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-06-24T09:31:59.804Z] java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps[2019-06-24T09:31:59.805Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.onResume(SynchronousNonBlockingStepExecution.java:75)[2019-06-24T09:31:59.805Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)[2019-06-24T09:31:59.805Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)[2019-06-24T09:31:59.805Z] 	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)[2019-06-24T09:31:59.805Z] 	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)[2019-06-24T09:31:59.805Z] 	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)[2019-06-24T09:31:59.805Z] 	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)[2019-06-24T09:31:59.805Z] 	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)[2019-06-24T09:31:59.805Z] 	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[2019-06-24T09:31:59.805Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:1011)[2019-06-24T09:31:59.805Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:989)[2019-06-24T09:31:59.805Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:907)[2019-06-24T09:31:59.805Z] 	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)[2019-06-24T09:31:59.805Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-06-24T09:31:59.805Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-06-24T09:31:59.805Z] 	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)[2019-06-24T09:31:59.805Z] 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)[2019-06-24T09:31:59.805Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)[2019-06-24T09:31:59.805Z] 	at 

D22060: [Task Manager] Prefer PID match even when desktop entry doesn't match

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4a6a518a8b4c: [Task Manager] Prefer PID match even when 
desktop entry doesnt match (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22060?vs=60541=60560

REVISION DETAIL
  https://phabricator.kde.org/D22060

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22068: Send downloads when downloads plugin is loaded

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We call `sendDownloads()` immediately when connecting to the port which looks 
racy.
  Instead, have the plugin tell the extension to send all downloads once it is 
loaded and ready to accept input.
  Kept the old call for compat which shouldn't hurt...

TEST PLAN
  Started a download, reloaded the extension, reliably got a download created 
again

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22068

AFFECTED FILES
  extension/extension.js
  host/downloadplugin.cpp
  host/downloadplugin.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22066: [sysemtray] Port away from foreach

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c3e61edd9ce1: [sysemtray] Port away from foreach 
(authored by nicolasfella).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22066?vs=60555=60559

REVISION DETAIL
  https://phabricator.kde.org/D22066

AFFECTED FILES
  applets/systemtray/systemtray.cpp

To: nicolasfella, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22066: [sysemtray] Port away from foreach

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

TEST PLAN
  system tray build with -DQT_NO_FOREACH, still does system tray things

REPOSITORY
  R120 Plasma Workspace

BRANCH
  foreach

REVISION DETAIL
  https://phabricator.kde.org/D22066

AFFECTED FILES
  applets/systemtray/systemtray.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22065: Introduce PluginManager

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This adds a dedicated class for loading/unloading and sending data to a 
plugin rather than doing it all in `main()`
  It could in the future then handle things like sending a reply to an incoming 
dataset by storing a reference/identifier to the request etc.

TEST PLAN
  - Loading and unloading plugins still works
  - Plugins still work
  
  Behavior on browser side is unchanged and/or protocol structure

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22065

AFFECTED FILES
  host/CMakeLists.txt
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/main.cpp
  host/pluginmanager.cpp
  host/pluginmanager.h
  host/settings.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> fredrik wrote in abstract_egl_backend.cpp:427
> We would need to create a separate EGL image and a separate texture for each 
> plane.
> The scene would need to bind each of those textures to separate texture 
> binding points, and we would need to generate and use a shader that samples 
> texels from each plane and performs YUV to RGB conversion.

Thanks for the explanation @fredrik. It wasn't clear to me how multi-planes 
buffers are handled (also that it's the same notion as for hw-planes is 
annoying!).

Until we support multi-plane buffers shouldn't we then filter out all 
multi-plane formats in the supportedFormats call such that the client does not 
even try to use these instead of just failing with null here?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart