D21944: Show shortcut in menu item when specified
This revision was automatically updated to reflect the committed changes. Closed by commit R858:721c348d1a1e: Show shortcut in menu item when specified (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=60332&id=60824 REVISION DETAIL https://phabricator.kde.org/D21944 AFFECTED FILES org.kde.desktop/MenuItem.qml To: astippich, mart, ngraham, apol Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders
davidre updated this revision to Diff 60823. davidre added a comment. Sort only if a sortmode has been specified Otherwise it could have been initialized to an invalid value which caused us to reach Q_UNREACHABLE and crash. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60725&id=60823 BRANCH slideshow (branched from master) REVISION DETAIL https://phabricator.kde.org/D22121 AFFECTED FILES wallpapers/image/CMakeLists.txt wallpapers/image/backgroundlistmodel.h wallpapers/image/image.cpp wallpapers/image/image.h wallpapers/image/imagepackage/contents/ui/config.qml wallpapers/image/imagepackage/contents/ui/main.qml wallpapers/image/slidefiltermodel.cpp wallpapers/image/slidefiltermodel.h wallpapers/image/slidemodel.cpp wallpapers/image/slidemodel.h wallpapers/image/slideshowpackage/contents/config/main.xml To: davidre, #plasma Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders
davidre updated this revision to Diff 60825. davidre marked 4 inline comments as done. davidre added a comment. - String changes and remove debug statement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60823&id=60825 BRANCH slideshow (branched from master) REVISION DETAIL https://phabricator.kde.org/D22121 AFFECTED FILES wallpapers/image/CMakeLists.txt wallpapers/image/backgroundlistmodel.h wallpapers/image/image.cpp wallpapers/image/image.h wallpapers/image/imagepackage/contents/ui/config.qml wallpapers/image/imagepackage/contents/ui/main.qml wallpapers/image/slidefiltermodel.cpp wallpapers/image/slidefiltermodel.h wallpapers/image/slidemodel.cpp wallpapers/image/slidemodel.h wallpapers/image/slideshowpackage/contents/config/main.xml To: davidre, #plasma Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders
davidre updated this revision to Diff 60826. davidre added a comment. - add my copyright REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60825&id=60826 BRANCH slideshow (branched from master) REVISION DETAIL https://phabricator.kde.org/D22121 AFFECTED FILES wallpapers/image/CMakeLists.txt wallpapers/image/backgroundlistmodel.h wallpapers/image/image.cpp wallpapers/image/image.h wallpapers/image/imagepackage/contents/ui/config.qml wallpapers/image/imagepackage/contents/ui/main.qml wallpapers/image/slidefiltermodel.cpp wallpapers/image/slidefiltermodel.h wallpapers/image/slidemodel.cpp wallpapers/image/slidemodel.h wallpapers/image/slideshowpackage/contents/config/main.xml To: davidre, #plasma Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16425: Added new Suspend then Hibernate option
meven accepted this revision. meven added a comment. Except that I couldn't test it, the code looks in great shape to me. REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham, meven Cc: ericadams, jobauer, reverendhomer, meven, soriano, abalaji, graesslin, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10747: Implement zwp_linux_dmabuf_v1
zzag added a comment.
> Update protocol xml to wayland-protocols master
OT: there's a package called wayland-protocols. We could use it in order to
avoid copying protocol specs.
name=FindWaylandProtocols.cmake
#.rst:
# FindWaylandProtocols
# ---
#
# Try to find wayland-protocols on a Unix system.
#
# This will define the following variables:
#
# ``WaylandProtocols_FOUND``
# True if (the requested version of) wayland-protocols is available
# ``WaylandProtocols_VERSION``
# The version of wayland-protocols
# ``WaylandProtocols_DATADIR``
# The wayland protocols data directory
find_package(PkgConfig)
pkg_check_modules(PKG_wayland_protocols QUIET wayland-protocols)
set(WaylandProtocols_VERSION ${PKG_wayland_protocols_VERSION})
pkg_get_variable(WaylandProtocols_DATADIR wayland-protocols pkgdatadir)
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(WaylandProtocols
FOUND_VAR WaylandProtocols_FOUND
REQUIRED_VARS WaylandProtocols_DATADIR
VERSION_VAR WaylandProtocols_VERSION
)
include(FeatureSummary)
set_package_properties(WaylandProtocols PROPERTIES
URL "https://wayland.freedesktop.org/";
DESCRIPTION "Specifications of extended Wayland protocols"
)
and then use it as follows
find_package(WaylandProtocols 1.8 REQUIRED)
${WaylandProtocols_DATADIR}/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D10747
To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: zzag, kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk,
jraleigh, sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh,
ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet
astippich added a comment. +1, also fixes the warnings in Elisa REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21514 To: dfaure, mart, apol, broulik Cc: astippich, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
