D22429: Make "Updates Available" notification persistent but low priority

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:b9bf6a37ef6f: Make Updates Available 
notification persistent but low priority (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22429?vs=61680=61685

REVISION DETAIL
  https://phabricator.kde.org/D22429

AFFECTED FILES
  libdiscover/resources/discoverabstractnotifier.notifyrc
  notifier/DiscoverNotifier.cpp
  notifier/DiscoverNotifier.h

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Stefan Brüns]

bruns added a comment.


  In D22333#494810 , @apol wrote:
  
  > In D22333#494774 , @bruns wrote:
  >
  > > Also, the code is calling non-threadsafe code from multiple threads now 
(e.g. once from each the two dataengines helper threads). Each one will call 
the udisks2 `Manager::deviceCache()` method.
  >
  >
  > There's a Backend per-thread and deviceCache is not static so each thread 
will call its own.
  
  
  Sorry, but you are wrong, look for
  `Q_GLOBAL_STATIC(Solid::DeviceManagerStorage, globalDeviceStorage)`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Aleix Pol Gonzalez]

apol added a comment.


  In D22333#494774 , @bruns wrote:
  
  > Also, the code is calling non-threadsafe code from multiple threads now 
(e.g. once from each the two dataengines helper threads). Each one will call 
the udisks2 `Manager::deviceCache()` method.
  
  
  There's a Backend per-thread and deviceCache is not static so each thread 
will call its own.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22390: ksmserver/autostart: remove qstandardpaths queries

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a75b330f9868: ksmserver/autostart: remove qstandardpaths 
queries (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22390?vs=61558=61682

REVISION DETAIL
  https://phabricator.kde.org/D22390

AFFECTED FILES
  startkde/plasma-session/autostart.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 290 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/290/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:48:10 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/81)17%
(67/390)17%
(67/390)13%
(4721/36193)11%
(2555/24096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kicker.plugin0%
(0/37)0%
(0/37)0%
(0/3320)0%
(0/2626)applets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/348)0%
(0/232)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/246)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2351)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
  

Re: RFC: Running clang-format across all Plasma (and more?) repos

[Allan Sandfeld Jensen]

On Donnerstag, 11. Juli 2019 16:18:08 CEST David Edmundson wrote:
> One topic discussed at the recent Plasma sprint was that we should run
> a code formatting tool (clang-format) over all our repos to ease all
> future review comments about whitespace.
> 
> All new contributions simply have to run the same tool and we get
> consistent code without having to comment on every minor thing in a
> review individually.
> 
> I've written up a wall of text outlining steps, challenges etc.
> https://phabricator.kde.org/T11214
> 
> Does anyone have any thoughts / objections?
> 
I would argue against it. clang-format is extremely primitive and stupid, it 
can't implement KDE or Qt coding styles or anything close to it, and will just 
make mess of manually indented code. You can could try to make a style that 
rougly appriximates KDE coding style (as good as clang-format can get with its 
primitive configuration), and then offer that for newbies so they follow at 
least basic rules, but a total reformatting of all code would be an objective 
downgrade of source code readablity and requires simplifying KDE coding styles 
to something that clang-format supports.

'Allan

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 150 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/150/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Jul 2019 11:47:55 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/81)17%
(67/390)17%
(67/390)13%
(4631/36079)10%
(2509/23954)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kicker.plugin0%
(0/37)0%
(0/37)0%
(0/3318)0%
(0/2622)applets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/348)0%
(0/232)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/246)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2351)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Technical gibberish is better than nothing at least. :)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf added a comment.


  Failure messages do seem to be generated
  
  F7013711: image.png 

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 61681.
filipf added a comment.


  remove message box on successful operation, use job error text when the 
operation fails

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=61669=61681

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> advanceconfig.cpp:207
> +qDebug() << job->errorText();
> +KMessageBox::error(this, i18n("Synchronization failed."));
> +} else {

"Synchronization failed." is a pretty frustrating error message. The user will 
wonder, "How did it fail? What happened? How can I fix it?" etc. Since we have 
the error text, let's show it in the message box, since it could provide some 
clues.

> advanceconfig.cpp:211
> +qDebug() << "Synchronization successful";
> +KMessageBox::information(this, i18n("Synchronization successful."));
> +}

I don't think we need a dialog box for the success case. That'll just annoy 
people.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22429: Make "Updates Available" nofication persistent but low priority

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Discover's "Updates are available" notification currently suffers from some 
problems:
  
  1. With the default timeout, it disappears quickly and is likely to be missed
  2. After timing out, it appears in thie history, where is is both redundant 
(because the Update Notifier system tray icon has become visible) and also 
useless (because it can't be interacted with due to 
https://bugs.kde.org/show_bug.cgi?id=407361 and 
https://bugs.kde.org/show_bug.cgi?id=407667)
  3. Once updates are performed, the notification in the history sticks around 
uselessly because notifications can't be revoked once they're in the history 
(See https://bugs.kde.org/show_bug.cgi?id=409323#c3)
  
  This patch fixes those issues by making the update persistent but low 
priority.
  
  This means it must be noticed by the user and interacted with in some way 
before it
  disappears from the screen--either by dismissing it or running the updates. 
But once
  dismissed, it's gone forever, and doesn't clutter up your history.
  
  BUG: 409757
  BUG: 409331
  FIXED-IN: 5.17.0

TEST PLAN
  1. Have updates available
  2. Deploy patch
  3. Restart plasmashell
  4. See that the notification is now persistent
  5. Dismiss notification
  6. See that it no longer clogs up the history
  7. Restart plasmashell again
  8. Click on the notification's body or "Update" button
  9. See that Discover opens and the notification disappears

REPOSITORY
  R134 Discover Software Store

BRANCH
  polish-notification-behavior (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22429

AFFECTED FILES
  libdiscover/resources/discoverabstractnotifier.notifyrc
  notifier/DiscoverNotifier.cpp
  notifier/DiscoverNotifier.h

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22426: Add Unsplash POTD Provider

[Yunhe Guo]

guoyunhe updated this revision to Diff 61678.
guoyunhe added a comment.


  Fix Unix new line format

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22426?vs=61673=61678

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22426

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:e0b126692a87: Add Unsplash POTD Provider (authored by Guo 
Yunhe i...@guoyunhe.me).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22426?vs=61678=61679

REVISION DETAIL
  https://phabricator.kde.org/D22426

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Stefan Brüns]

bruns added a comment.


  In D22333#494415 , @apol wrote:
  
  > In D22333#494389 , @bruns wrote:
  >
  > > Again, where is it blocking? Which backend?
  >
  >
  > udisks2 mainly, but every backend can block by its virtue.
  
  
  The code can still block, as every invocation of 'Solid::Device(udi)` does a 
blocking DBus call to udisks2.
  
  Also, the code is calling non-threadsafe code from multiple threads now (e.g. 
once from each the two dataengines helper threads). Each one will call the 
udisks2 `Manager::deviceCache()` method.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice. Works great and I don't see any problems with the code here. Let's 
try to avoid a ton of bikeshedding over the licenses since these are CC0 IMO.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22426

To: guoyunhe, #plasma, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Yunhe Guo]

guoyunhe added a comment.


  Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be 
copyright issues.
  
  I do think it is good to show photographers' credits. But that will require 
changes to POTD class and wallpaper widget.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22426

To: guoyunhe, #plasma
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Filip Fila]

filipf added a comment.


  Unsplash has very good wallpapers; in my opinion this automatically becomes 
the most attractive POTD plugin.
  
  Keep in mind though that when I tried to add Unsplash wallpapers to KDE in 
D18078  I was told I need to contact the 
authors and have them re-licence their work for us...
  
  Hopefully this issue can be avoided here as it's not exactly the same 
situation. You have a big +1 from me for the idea.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22426

To: guoyunhe, #plasma
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22426: Add Unsplash POTD Provider

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Add Unsplash Wallpaper as picture of the day provider. Unsplash provides high 
quality photos under public domain license.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22426

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 61669.
filipf added a comment.


  Use KMessageBox to show information whether or not the sync and reset 
operations succeeded

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=61480=61669

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Nathaniel Graham]

ngraham added a comment.


  I no longer have any crashes with this latest version! \o/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: RFC: Running clang-format across all Plasma (and more?) repos

[David Edmundson]

> Presumably this would impose a common coding style throughout all KDE
> repositories? Or would each project be able to specify its own clang-format
> configuration? In past discussions about KDE coding style, it was accepted 
> that
> while Frameworks and PIM libraries would adopt a common style, Applications
> would be left to decide for themselves.
>

It would definitely have to be opt-in.
Right now I'm only aiming for adjusting everything that's part of Plasma.

David

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 63 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/63/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Jul 2019 13:17:20 +
 Build duration:
1 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-12T13:19:00.300Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-12T13:19:00.300Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-12T13:19:00.300Z] PROCESSOR_LEVEL   = '6'[2019-07-12T13:19:00.300Z] PROCESSOR_REVISION= '5e03'[2019-07-12T13:19:00.300Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-12T13:19:00.300Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-12T13:19:00.300Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-12T13:19:00.300Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-12T13:19:00.300Z] PROMPT= '$P$G'[2019-07-12T13:19:00.300Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-12T13:19:00.300Z] PUBLIC= 'C:\Users\Public'[2019-07-12T13:19:00.300Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/63/display/redirect?page=changes'[2019-07-12T13:19:00.300Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/63/display/redirect'[2019-07-12T13:19:00.300Z] STAGE_NAME= 'Configuring Build'[2019-07-12T13:19:00.300Z] SYSTEMDRIVE   = 'C:'[2019-07-12T13:19:00.300Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-12T13:19:00.300Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-12T13:19:00.300Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-12T13:19:00.300Z] UCRTVERSION   = '10.0.17763.0'[2019-07-12T13:19:00.300Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-12T13:19:00.300Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-12T13:19:00.300Z] USERNAME  = 'Jenkins'[2019-07-12T13:19:00.300Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-12T13:19:00.300Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-12T13:19:00.300Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-12T13:19:00.300Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-12T13:19:00.300Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-12T13:19:00.300Z] VCTOOLSVERSION= '14.16.27023'[2019-07-12T13:19:00.300Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-12T13:19:00.300Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-12T13:19:00.300Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-12T13:19:00.300Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-12T13:19:00.300Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-12T13:19:00.300Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-12T13:19:00.300Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-12T13:19:00.300Z] VSCMD_VER = '16.0.3'[2019-07-12T13:19:00.300Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-12T13:19:00.300Z] WINDIR= 'C:\WINDOWS'[2019-07-12T13:19:00.300Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-12T13:19:00.300Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-12T13:19:00.300Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-12T13:19:00.300Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-12T13:19:00.300Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-12T13:19:00.300Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-12T13:19:00.300Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-12T13:19:00.300Z] __DOTNET_ADD_64BIT= '1'[2019-07-12T13:19:00.300Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-12T13:19:00.300Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-12T13:19:00.300Z] 

D22401: change debug dir order to prefer appDir and do not duplicate Debuggers

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:d8cf681eb060: change debug dir order to prefer appDir and 
do not duplicate Debuggers (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22401?vs=61640=61656

REVISION DETAIL
  https://phabricator.kde.org/D22401

AFFECTED FILES
  src/debugger.cpp

To: sitter, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

Re: RFC: Running clang-format across all Plasma (and more?) repos

[David Jarvie]

On Thursday 11 Jul 2019 14:18:08 David Edmundson wrote:
> One topic discussed at the recent Plasma sprint was that we should run
> a code formatting tool (clang-format) over all our repos to ease all
> future review comments about whitespace.
> 
> All new contributions simply have to run the same tool and we get
> consistent code without having to comment on every minor thing in a
> review individually.
> 
> I've written up a wall of text outlining steps, challenges etc.
> https://phabricator.kde.org/T11214
> 
> Does anyone have any thoughts / objections?

Presumably this would impose a common coding style throughout all KDE 
repositories? Or would each project be able to specify its own clang-format 
configuration? In past discussions about KDE coding style, it was accepted that 
while Frameworks and PIM libraries would adopt a common style, Applications 
would be left to decide for themselves.

There may be more benefits from what you propose for larger projects, because 
of the larger number of contributors and larger volume of reviews. But for 
smaller ones with one or two contributors and few reviews, it bring few 
benefits.

It should be for individual projects to decide whether automatic code 
formatting would be desirable or useful to them. This will allow projects to 
continue to use their own coding styles where they wish, and allow for hand-
crafted formatting to be left intact where this is desired.

-- 
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 62 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/62/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Jul 2019 12:51:15 +
 Build duration:
2 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-12T12:53:45.668Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-12T12:53:45.668Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-12T12:53:45.668Z] PROCESSOR_LEVEL   = '6'[2019-07-12T12:53:45.668Z] PROCESSOR_REVISION= '5e03'[2019-07-12T12:53:45.668Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-12T12:53:45.668Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-12T12:53:45.668Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-12T12:53:45.668Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-12T12:53:45.668Z] PROMPT= '$P$G'[2019-07-12T12:53:45.668Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-12T12:53:45.668Z] PUBLIC= 'C:\Users\Public'[2019-07-12T12:53:45.668Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/62/display/redirect?page=changes'[2019-07-12T12:53:45.668Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/62/display/redirect'[2019-07-12T12:53:45.668Z] STAGE_NAME= 'Configuring Build'[2019-07-12T12:53:45.668Z] SYSTEMDRIVE   = 'C:'[2019-07-12T12:53:45.668Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-12T12:53:45.668Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-12T12:53:45.668Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-12T12:53:45.668Z] UCRTVERSION   = '10.0.17763.0'[2019-07-12T12:53:45.668Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-12T12:53:45.668Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-12T12:53:45.668Z] USERNAME  = 'Jenkins'[2019-07-12T12:53:45.668Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-12T12:53:45.668Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-12T12:53:45.668Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-12T12:53:45.668Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-12T12:53:45.668Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-12T12:53:45.668Z] VCTOOLSVERSION= '14.16.27023'[2019-07-12T12:53:45.668Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-12T12:53:45.668Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-12T12:53:45.668Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-12T12:53:45.668Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-12T12:53:45.668Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-12T12:53:45.668Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-12T12:53:45.668Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-12T12:53:45.668Z] VSCMD_VER = '16.0.3'[2019-07-12T12:53:45.668Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-12T12:53:45.668Z] WINDIR= 'C:\WINDOWS'[2019-07-12T12:53:45.668Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-12T12:53:45.668Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-12T12:53:45.668Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-12T12:53:45.668Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-12T12:53:45.668Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-12T12:53:45.668Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-12T12:53:45.668Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-12T12:53:45.668Z] __DOTNET_ADD_64BIT= '1'[2019-07-12T12:53:45.668Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-12T12:53:45.668Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-12T12:53:45.668Z] 

D22400: disambiguate the names of Debugger

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:76f5df262eb4: disambiguate the names of Debugger 
(authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22400?vs=61594=61651

REVISION DETAIL
  https://phabricator.kde.org/D22400

AFFECTED FILES
  src/backtracewidget.cpp
  src/debugger.cpp
  src/debugger.h
  src/debuggerlaunchers.cpp
  src/drkonqibackends.cpp

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22398: always log raw exception data

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:68ccdf540ee3: always log raw exception data (authored by 
sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22398?vs=61592=61652

REVISION DETAIL
  https://phabricator.kde.org/D22398

AFFECTED FILES
  src/bugzillaintegration/libbugzilla/exceptions.cpp

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22399: prevent exhausting the maximum size of bug reports

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:c07434bf8e2e: prevent exhausting the maximum size of bug 
reports (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22399?vs=61593=61654

REVISION DETAIL
  https://phabricator.kde.org/D22399

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportinterface.cpp
  src/bugzillaintegration/reportinterface.h

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22403: qobject_cast rather than dynamic_cast

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:ec63673c3695: qobject_cast rather than dynamic_cast 
(authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22403?vs=61599=61649

REVISION DETAIL
  https://phabricator.kde.org/D22403

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp

To: sitter, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22402: only benchmark once

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:854c95323993: only benchmark once (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22402?vs=61598=61653

REVISION DETAIL
  https://phabricator.kde.org/D22402

AFFECTED FILES
  src/tests/backtraceparsertest/backtraceparsertest.cpp

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22404: do not dereference `current` outside guard condition

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:88918ab8a59d: do not dereference `current` outside guard 
condition (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22404?vs=61600=61650

REVISION DETAIL
  https://phabricator.kde.org/D22404

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre updated this revision to Diff 61648.
davidre added a comment.


  - Only restore wallpaper on startup
  - Guard against empty path
  
  I couldn't understand why this was being called with an empty string so I 
just guard 
  against it at the call site. Maybe this also helps @ngrahams crash but I 
still don't know
  where it is coming from.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61335=61648

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22418: wayland: make automatic backend selection truly automatic

[Alexey Min]

alexeymin created this revision.
alexeymin added reviewers: romangg, zzag.
Herald added a project: KWin.
Herald added a subscriber: kwin.
alexeymin requested review of this revision.

REVISION SUMMARY
  Choose backend automatically, based on actually available
  plugins at runtime, independently of kwin compile options.
  Don't limit command line options too.

TEST PLAN
  compile kwin without some of backends. Then
  compile kwin with that backend separately, manually
  copy the appropriate plugin into plugins directory.
  Verify that `kwin_wayland --help` lists that option,
  and running kwin_wayland without arguments, with proper
  environment automatically selects proper backend plugin.

REPOSITORY
  R108 KWin

BRANCH
  alexeymin/automatic-backend-selection

REVISION DETAIL
  https://phabricator.kde.org/D22418

AFFECTED FILES
  main_wayland.cpp

To: alexeymin, romangg, zzag
Cc: kwin, plasma-devel, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, 
mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart

D22034: Introduce ContainmentLayoutManager QML plugin

[Marco Martin]

mart updated this revision to Diff 61642.
mart added a comment.


  - manage differently screen resize and other kind of resizes
  - fix snapping on RTL and BTT positioning

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22034?vs=61576=61642

BRANCH
  mart/containmentlayoutmanager

REVISION DETAIL
  https://phabricator.kde.org/D22034

AFFECTED FILES
  components/CMakeLists.txt
  components/containmentlayoutmanager/CMakeLists.txt
  components/containmentlayoutmanager/abstractlayoutmanager.cpp
  components/containmentlayoutmanager/abstractlayoutmanager.h
  components/containmentlayoutmanager/appletcontainer.cpp
  components/containmentlayoutmanager/appletcontainer.h
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/configoverlay.cpp
  components/containmentlayoutmanager/configoverlay.h
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.cpp
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.h
  components/containmentlayoutmanager/gridlayoutmanager.cpp
  components/containmentlayoutmanager/gridlayoutmanager.h
  components/containmentlayoutmanager/itemcontainer.cpp
  components/containmentlayoutmanager/itemcontainer.h
  components/containmentlayoutmanager/qml/BasicAppletContainer.qml
  components/containmentlayoutmanager/qml/ConfigOverlayWithHandles.qml
  components/containmentlayoutmanager/qml/PlaceHolder.qml
  components/containmentlayoutmanager/qml/private/BasicResizeHandle.qml
  components/containmentlayoutmanager/qml/qmldir
  components/containmentlayoutmanager/resizehandle.cpp
  components/containmentlayoutmanager/resizehandle.h

To: mart, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22401: change debug dir order to prefer appDir and do not duplicate Debuggers

[Harald Sitter]

sitter updated this revision to Diff 61640.
sitter added a comment.


  - constify
  - use qasconst on both loops
  - don't make string concatations unecessarily complicate

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22401?vs=61595=61640

BRANCH
  debugger-load-override

REVISION DETAIL
  https://phabricator.kde.org/D22401

AFFECTED FILES
  src/debugger.cpp

To: sitter, #plasma
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

Re: RFC: Running clang-format across all Plasma (and more?) repos

[Martin Flöser]

Am 2019-07-11 16:18, schrieb David Edmundson:

One topic discussed at the recent Plasma sprint was that we should run
a code formatting tool (clang-format) over all our repos to ease all
future review comments about whitespace.

All new contributions simply have to run the same tool and we get
consistent code without having to comment on every minor thing in a
review individually.

I've written up a wall of text outlining steps, challenges etc.
https://phabricator.kde.org/T11214

Does anyone have any thoughts / objections?


As someone being guilty of only focusing on whitespace changes I'm very 
much in favor of this idea.


Cheers
Martin