D12916: Panel should not stop auto-hiding if a window wants attention

[Michael Moon]

michaelmoon updated this revision to Diff 61838.
michaelmoon added a comment.


  Altered patch to apply against plasma-desktop:b2ce4bd 
 
(current git master)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12916?vs=61785&id=61838

REVISION DETAIL
  https://phabricator.kde.org/D12916

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/main.qml

To: michaelmoon, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> handler.cpp:170
> +{
> +NetworkManager::AccessPoint::Ptr ap;
> +NetworkManager::WirelessDevice::Ptr wifiDev;

I actually thought that instead of all this logic, where you search for 
wireless device, AP and then to get the security type, you will pass those 
information from the applet, instead of the **specificObject**. Even ssid is 
exposed from the model so you can just pass ssid as an argument and security 
type as another one and almost all this code below can go away.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22482: WIP: Show file dialog in directory mode when only directory is requested

[Jan Grulich]

jgrulich added a comment.


  The FileChooser portal will never ask for directories, it's currently not 
possible to expose a directory to the sandbox environment. If you look at [1], 
you can see it always uses native file dialog in case of directories, which 
means native file dialog will be opened inside the sandbox, not through the 
portal.
  
  [1] - 
https://code.woboq.org/qt5/qtbase/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp.html#_ZN27QXdgDesktopPortalFileDialog4execEv

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22482

To: volkov, apol, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Nathaniel Graham]

ngraham added a comment.


  In D22468#496130 , @davidedmundson 
wrote:
  
  > > Screen size and DPI combinations are so variable that I think it makes 
sense to support a higher level of precision.
  >
  > Talking of which, there were some updated plans with regards to the UI for 
X scaling in the meeting that everyone in this thread was at.
  >  I don't want to have made a plan in a meeting, and then discard it one 
week later.  I think it's easier to leave that in an external dialog for the X 
case, then you don't have to worry about it in this patch.
  
  
  Here's what I wrote in 
https://notes.kde.org/p/usability-productivity-sprint-2019:
  
  > - Discuss with Plasma folks on unifying our scaling methods; maybe remove 
or hide the Force Fonts DPI setting to avoid confusing people: 
https://phabricator.kde.org/T9500. Conclusion:
  >   - Move the Force Fonts DPI control into the scaling window and make them 
more visually connected to one another; see task for more details F6920969: 
20190621_151413.jpg 
  
  
  
  > - Also discuss how we can eventually make Plasma use the global scale 
factor on X11: https://bugs.kde.org/show_bug.cgi?id=356446. Conclusion:
  >   - We can do it! See https://bugs.kde.org/show_bug.cgi?id=356446 We 
discussed this at the Plasma sprint and came to the following conclusion:
  > 
  > We will re-investigate doing this, but first need to resolve the 
following blockers:
  > - Fix the Task Manager's minimize animation zooming into out of the wrong 
location
  > - A few other Task Manager-related positioning and screen-related issues
  > 
  >   We have a path forward and the blocking issues will be marked 
appropriately.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> broulik wrote in ShowQR.qml:27
> Can you instad do a `StackView` and show the barcode inside the applet like 
> Klipper does it? This would make it more consistent.

I thought about that too, my use-case was though to give access to wifi on 
somebody by my side, making them aim at my screen would be weird.

> broulik wrote in handler.cpp:230
> What does this do?

Yeah forgot to remove it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61836.
apol added a comment.


  Fix visible logic

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22457?vs=61835&id=61836

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/ShowQR.qml
  libs/handler.cpp
  libs/handler.h

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61835.
apol marked 5 inline comments as done.
apol added a comment.


  addressed comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22457?vs=61773&id=61835

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/ShowQR.qml
  libs/handler.cpp
  libs/handler.h

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[David Edmundson]

davidedmundson added a comment.


  > Ha, you're totally right. Amazing! Is this something to fix in Plasma 
frameworks?
  
  The problem relates to use of Handlers instead of old style MouseArea.
  
  I haven't finished investigating, but I have a bad feeling 
QQuickWindow/QQuickWidget is the part that will need fixing :/

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Greg Varsanyi]

gvarsanyi added a comment.


  In D22468#496052 , @ngraham wrote:
  
  > I'm not sold on the proposal to use 1.25x increments, personally. For my 
personal use case, I like using 1.1x (13" 1080p screen) and I wouldn't want to 
lose that. Screen size and DPI combinations are so variable that I think it 
makes sense to support a higher level of precision. Apple can get away with 
their very low configurability because of tight control over the hardware that 
allows them to avoid selling machines where a given option wouldn't work.
  >
  > That said, I could get behind 0.25x increments if there's some "advanced" 
page or mods in the GUI that exposes 0.1 incrememebts, or even a spinbox or 
text box or something.
  >
  > Either is better than 0.2 increments though. As pointed out, that missed 
the all-important 1.5x.
  
  
  I think we'd all like to support everyone's use cases. My argument is that 
0.25/0.75 steps are almost as important as 0.5. If devs/users are not concerned 
about too much granularity (e.g. artifacts, testing), this can be fixed easily 
by doing 0.05 increments - it's just a slider anyway.
  I also like the idea of adding a simple stepper with few predefined values, 
and an "advanced" configuration option for very precise settings.
  
  This makes me think: current KCM partially breaks if I set fractional scaling 
on Wayland to a non-integer value (the scale is not represented on the preview 
pane, and there is no selection in the scale dropdown). Probably a slider can 
better represent a value like 1.375x, even if it doesn't allow for picking it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[David Edmundson]

davidedmundson added a comment.


  > Screen size and DPI combinations are so variable that I think it makes 
sense to support a higher level of precision.
  
  Talking of which, there were some updated plans with regards to the UI for X 
scaling in the meeting that everyone in this thread was at.
  I don't want to have made a plan in a meeting, and then discard it one week 
later.  I think it's easier to leave that in an external dialog for the X case, 
then you don't have to worry about it in this patch.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Michail Vourlakos]

mvourlakos added a comment.


  In D22468#496123 , @ngraham wrote:
  
  > I guess I was thinking that it should be aligned to the slider itself, like 
this:
  >
  >   Scale:  |---o---|
  >   1x 1.5x2x
  >
  
  
  Yep! Looks fine!
  
  +1

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Filip Fila]

filipf added a comment.


  There is an example in the Fuzzy Clock config:
  
  F7029166: image.png 
  
  In D22468#496052 , @ngraham wrote:
  
  > I'm not sold on the proposal to use 1.25x increments, personally. For my 
personal use case, I like using 1.1x (13" 1080p screen) and I wouldn't want to 
lose that. Screen size and DPI combinations are so variable that I think it 
makes sense to support a higher level of precision.
  
  
  Strongly agree.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Nathaniel Graham]

ngraham added a comment.


  I guess I was thinking that it should be aligned to the slider itself, like 
this:
  
Scale:  |---o---|
1x 1.5x2x

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Michail Vourlakos]

mvourlakos added a comment.


  In D22468#496052 , @ngraham wrote:
  
  > For the scale slider, I'd put the numbers underneath, and have 
threenumbers; one on each end and one in the middle. So if the maximum value 
was 2x, it would look like this:
  >
  >   |---o---|
  >   1x 1.5x2x
  >
  >
  >
  
  
  In that case what will be the vertical alignment of the Scale text? I am 
asking because for this case the vertical center alignment for Scale text looks 
weird in my opinion

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Nathaniel Graham]

ngraham added a comment.


  #plasma  ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22482: WIP: Show file dialog in directory mode when only directory is requested

[Alexander Volkov]

volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D22482

AFFECTED FILES
  src/filechooser.cpp

To: volkov
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D12916: Panel should not stop auto-hiding if a window wants attention

[Nathaniel Graham]

ngraham added a comment.


  This patch doesn't apply due to some path weirdness:
  
Checking patch 
plasma-desktop-5.15.5_old/applets/taskmanager/package/contents/ui/main.qml => 
applets/taskmanager/package/contents/ui/main.qml...
error: 
plasma-desktop-5.15.5_old/applets/taskmanager/package/contents/ui/main.qml: 
does not exist in index
  
  Instead of doing a manual diff between two files (old and new), you'd be 
better off editing the files in the plasma-desktop git repo and then running 
`git diff` to get your diff for this.
  
  Also make sure you're working on git master, since that where the patch will 
be merged to once accepted.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61825.
cblack added a comment.


  More sizing tweaks

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61819&id=61825

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I woudn't actually mind showing the Plasma logo and text there by 
default at some point as long as it's small and tasteful. Our branding is 
pretty weak right now and any improvement there is welcome IMO.
  
  But yeah, that's a discussion for later.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Nathaniel Graham]

ngraham added a comment.


  For the scale slider, I'd put the numbers underneath, and have threenumbers; 
one on each end and one in the middle. So if the maximum value was 2x, it would 
look like this:
  
|---o---|
1x 1.5x2x
  
  I'm not sold on the proposal to use 1.25x increments, personally. For my 
personal use case, I like using 1.1x (13" 1080p screen) and I wouldn't want to 
lose that. Screen size and DPI combinations are so variable that I think it 
makes sense to support a higher level of precision. Apple can get away with 
their very low configurability because of tight control over the hardware that 
allows them to avoid selling machines where a given option wouldn't work.
  
  That said, I could get behind 0.25x increments if there's some "advanced" 
page or mods in the GUI that exposes 0.1 incrememebts, or even a spinbox or 
text box or something.
  
  Either is better than 0.2 increments though. As pointed out, that missed the 
all-important 1.5x.
  
  Regardless, +100 for turning on fractional scaling on Wayland!

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Filip Fila]

filipf added a comment.


  Logo size still looks too big to me; IMO these things shouldn't be too much 
in the users' face and the logo shouldn't overpower the clock. Also I think the 
second screenshot doesn't accurately represent new code.
  
  You had `units.largeSpacing * 8` before => 8 * 8 = 64
  
  Now it's `units.gridUnits * 6` => 18 * 6 = 108
  
  Ideally we'd multiply `units.gridUnits` with 3 or 4 to get to 64 again (or do 
Math.round when multiplying with 3.5).
  
  For me `units.gridUnits * 3` looks perfect:
  
  F7028361: Screenshot_20190715_210721.png 

  
  And it seems I didn't give the best of advice for `sourceSize.width` as 
there's now a binding loop. If `width` is changed with `implicitWidth` it goes 
away though.
  
  
  
  On a more general note, I'd keep the logo turned off by default but let's see 
what others think. Looking into the future it would also be good to add a UI 
option and chooser too, but not important now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22481: Do not show play/pause button when no media is playing

[Noah Davis]

ndavis added a comment.


  This is how the widget currently looks: F7028324: 
Screenshot_20190715_150118.png 
  
  Without the controls or text, it would just be a box, which makes it 
impossible to know which widget it's supposed to be.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22481

To: shubham, broulik, #plasma, #vdg
Cc: ndavis, davidedmundson, #vdg, #plasma, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22481: Do not show play/pause button when no media is playing

[David Edmundson]

davidedmundson added a comment.


  Why?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22481

To: shubham, broulik, #plasma, #vdg
Cc: davidedmundson, #vdg, #plasma, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22481: Do not show play/pause button when no media is playing

[Shubham]

shubham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22481

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: shubham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22480: Don't use KPluginInfo if we can use KPluginMetaData

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  KPluginInfo would force the load of the desktop file for information we don't 
need.

TEST PLAN
  Plasma still works

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22480

AFFECTED FILES
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  I'll have to do this downstream, anyway...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Hazem Salem]

Codezela added a comment.


  please don't make this
  it look not good
  we can make it more smaller and put it on any corner

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Greg Varsanyi]

gvarsanyi added inline comments.

INLINE COMMENTS

> OutputPanel.qml:96
> +to: 3
> +stepSize: 0.2
> +live: true

`stepSize` settings confuse me a bit. For perOutput it's 0.2, for global, it's 
0.1.

I recommend setting both to 0.25 increments.

Both Windows and Gnome devs decided to do 0.25 increments for fractional 
scaling, and OSX also only has 3 fractional scales for every integer (albeit in 
logarithmic increments).
Although KDE doesn't have to follow suit, they all might have been onto 
something.
Advantages of 0.25 steps:

- less prone to weird pixel-problems and artifacts that would come with scales 
like 1.6 or 1.1
- does not skip the important 1.5 factor (like 0.2 steps would)
- users probably want the 1.25 and 1.75 scale options more than 1.1, 1.2, 1.3, 
1.4, 1.6, 1.7, 1.8, 1.9 - but they are unavailable with the 0.1 steps
- much easier to run test apps against less (4 vs 10) variants

On the other hand, 0.25 should be good enough granularity for most.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61819.
cblack added a comment.


  Sizing tweaks

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61814&id=61819

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Filip Fila]

filipf added a comment.


  I'm testing this out now and there seems to be only one obstacle left, see 
inline comment

INLINE COMMENTS

> Main.qml:424
> +fillMode: Image.PreserveAspectFit
> +height: units.gridUnit * 8
> +Behavior on opacity {

units.gridUnit is larger than units.largeSpacing, you can't keep 8 as the 
multiplier:

F7028050: Screenshot_20190715_195255.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61814.
cblack added a comment.


  Add sourceSize.width to the party

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61813&id=61814

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> cblack wrote in Main.qml:415
> I don't really have a defined width, but I guess I could define the height

You'll notice that in my example I didn't have height defined, but the 
`sourceSize `code should still work because the `fillMode` magic does set some 
definitive width.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61813.
cblack added a comment.


  Define sourceSize.height

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61809&id=61813

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> filipf wrote in Main.qml:415
> to the height and width of the item I believe, at least that's what I did 
> here: https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54

I don't really have a defined width, but I guess I could define the height

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> cblack wrote in Main.qml:415
> I haven't a clue what I should set `sourceSize` to ¯\_(ツ)_/¯

to the height and width of the item I believe, at least that's what I did here: 
https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> broulik wrote in Main.qml:415
> Also set a `sourceSize` and probably `asynchronous: true`

I haven't a clue what I should set `sourceSize` to ¯\_(ツ)_/¯

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61809.
cblack added a comment.


  Rename config file properties to not say "distro"
  Use gridunit
  Use opacityanimator

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61774&id=61809

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Noah Davis]

ndavis added a comment.


  The latest version of this patch is better because it works well for people 
using the Breeze GTK theme with the Breeze colorscheme and it doesn't make the 
Breeze Dark GTK theme worse when combined with the Breeze Dark colorscheme. 
However, it does cause Breeze GTK to look odd when used with the Breeze Dark 
colorscheme: F7027817: Screenshot_20190715_124709.png 

  
  Normally, I wouldn't consider this too much of a problem since people usually 
want to use the same theme system wide, but sometimes apps that use GTK themes 
don't play well with dark GTK themes. It is realistic to assume some people who 
normally use Breeze Dark will use the Breeze GTK theme for GTK apps via the 
system settings rather than an environment variable for the few problematic 
apps (`GTK_THEME=Breeze app-name-here`). Examples of apps that don't play well 
with dark GTK themes are Eclipse, Intellij IDEA 

 and Firefox (before version 68).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> broulik wrote in Main.qml:414
> Why not just a bool?

the config object exposes `true` as `"true"`, not `true`, so ¯\_(ツ)_/¯

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22467: Make captive portal notification persistent but low priority

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:87fa14955632: Make captive portal notification persistent 
but low priority (authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22467?vs=61772&id=61805

REVISION DETAIL
  https://phabricator.kde.org/D22467

AFFECTED FILES
  kded/networkmanagement.notifyrc
  kded/portalmonitor.cpp

To: ngraham, #plasma, jgrulich
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Kai Uwe Broulik]

broulik added a comment.


  In D22468#495897 , @romangg wrote:
  
  > Ha, you're totally right. Amazing! Is this something to fix in Plasma 
frameworks?
  
  
  Breeze kstyle. I bet the issue is that handlers don't accept the events 
and/or process them differently from how we expect it from `MouseArea`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  In D22468#495791 , @davidedmundson 
wrote:
  
  > > On Wayland everything works fine. Might be a Qt bug in input handlers 
directly and not the code here. Other ideas?
  >
  > It'll be our code. Try running with --style=fusion and see if the problem 
magically goes away.
  >
  > If so, it'll be us not accepting the input event, so it propagates up to 
the window, and hits the QWidget underneath the QML which starts a system move. 
Something that doesn't work on wayland.
  
  
  Ha, you're totally right. Amazing! Is this something to fix in Plasma 
frameworks?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22429: Make "Updates Available" notification persistent but low priority

[Nathaniel Graham]

ngraham added a comment.


  In D22429#495652 , @broulik wrote:
  
  > Oh God, please not make it persistent. This notification comes up every 
single time I start plasmashell and now I have to explicitly manually get rid 
of it.
  
  
  That's kind of the point though. The user should be seeing these 
notifications and having to explicitly acknowledge them in some way; updates 
are important. If it's annoying for you, maybe you should turn Discover's 
notifications off entirely?
  
  Or maybe persistent/close on timeout behavior should be user-configurable. It 
actually is on macOS where each individual notification can be made persistent, 
close-on-timeout, or disabled.
  
  > Also I disagree security updates available notification should be "low 
urgency". Instead of making everything that shouldn't be in the history low 
priority (which is not what low priority means, it is just a side-effect) I 
would suggest you add a flag for `KNotification` to not keep in history.
  
  Fair point. I'll give it a go.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22429

To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Nathaniel Graham]

ngraham added a comment.


  In D22452#495666 , @mthw wrote:
  
  > In D22452#495325 , @ngraham 
wrote:
  >
  > > Whether or not it's better is not relevant for this patch, which right 
now is only about fixing the text color. It's best not to mix multiple changes 
like this, unless you want to expand the patch in scope, in which case it 
should be re-titled accordingly.
  > >
  > > Still, I would recommend doing one change per patch, because it makes 
each one more likely to get in compared to patches with multiple changes 
(especially when any one of those individual changes may be controversial or 
require discussion).
  >
  >
  > If I did re-title and change the description, would this have a better 
chance of passing?
  
  
  Yes, but then you would still have to convince people that the other included 
color change is good as well.
  
  > The chage is so small (number of lines) that It probably wouldn't make 
sense to split it.
  
  It's not about number of lines; it's about how many distinct changes it 
introduces. Imagine a three-line patch that introduces three changes, where one 
is a bugfix and two of which are potentially controversial visual or behavioral 
changes. It's a small patch, but it would benefit from being split into three 
so the uncontroversial bugfix can be committed ASAP, without getting derailed 
by a discussion of the other issues.
  
  Does that make sense? If the problem here is that you don't know how to 
separate your bugfix from the visual change, I would encourage you to big into 
that a bit!

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[David Edmundson]

davidedmundson added a comment.


  Idea makes sense.
  
  lets drop the word "distro" and then we can use it for 
corporation/city/whatever logos

INLINE COMMENTS

> Main.qml:423
> +Behavior on opacity {
> +NumberAnimation {
> +duration: units.longDuration

OpacityAnimator is better where possible

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Meeting week 29 notes

[Bhushan Shah]

kbroulik: 
- Not much to report, busy with company stuff

romangg:
- https://phabricator.kde.org/D22468
- This week KDE connect and next week KWin sprint

nicofee:
Done:
- Re-write plasma-settings (death to ugly code! 145 additions, 1474 deletions)
- Ported few mobile KCM to ConfigModule/SimpleKCM
- Some polish to mobile wifi KCM (mainly porting it to form layout)
Todo:
- More polish
- Port plasma-pa to SimpleKCM


bshah:
Done:
- Some research about ofono in current mobile image... kinda meh due to amount 
of forking
- Built images with puremaps and telegram installed as flatpak as experiment
Todo:
- Some more mobile related work, writing blog about plasma sprint

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D22445: WIP: Open from cache / Open Normally

[Harald Sitter]

sitter added a comment.


  I would break the problem apart: pretend you only have one cached report. By 
wanting to deal with multiple reports at once I imagine you are making this 
more complicated than it is.
  
  With a single report you have two discrete input source options: live and 
cached. They represent the exactly same thing with (ideally) complete values 
for everything (name,exe,pid...) so all you need to do is rejigger the backend 
classes so they read the relevant information.
  The way I imagine this should work is in main() you branch depending on 
whether drkonqi is loading cached or live info, factorize the information (i.e. 
set it in DrKonqi) and construct a debugger (derive gdbdebugger and make it 
load data from in-memory for cached) + parser, then everything should 
technically work.
  
  Once you can report a single cached report it needs to be made to scale 
For multiple cached reports I think it's entirely feasible to then simply have 
your CacheWidget dialog be a separate process that forks a drkonqi process for 
each report that needs filing. Each drkonqi process is then still only 
responsible for a single report and all previously made assumptions about how 
there is only one crashed application etc. continue to hold true.
  
  From there we can still refactor to make the classes not rely on singletons 
and allow multiple reports to exist within the same process (if necessary at 
all, it may make no UX difference in the end).

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22445

To: tcanabrava
Cc: sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D22453

To: ngraham, #plasma, #vdg, drosca
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Main.qml:414
> +id: logo
> +visible: config.showdistrologo == "shown"
> +source: config.distrologo

Why not just a bool?

> Main.qml:415
> +visible: config.showdistrologo == "shown"
> +source: config.distrologo
> +anchors.horizontalCenter: parent.horizontalCenter

Also set a `sourceSize` and probably `asynchronous: true`

> Main.qml:421
> +fillMode: Image.PreserveAspectFit
> +height: units.largeSpacing * 8
> +Behavior on opacity {

This is not what `spacing` is supposed to be used for. Try `units.gridUnit`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[David Edmundson]

davidedmundson added a comment.


  > On Wayland everything works fine. Might be a Qt bug in input handlers 
directly and not the code here. Other ideas?
  
  It'll be our code. Try running with --style=fusion and see if the problem 
magically goes away.
  
  If so, it'll be us not accepting the input event, so it propagates up to the 
window, and hits the QWidget underneath the QML which starts a system move. 
Something that doesn't work on wayland.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  On X11 I had problems moving the outputs in the overview. For some reason the 
click was not caught by the ui but KWin tries to move the whole window instead. 
On Wayland everything works fine. Might be a Qt bug in input handlers directly 
and not the code here. Other ideas?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Abandoning because it can negatively affect other widget styles.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: filipf, IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22034: Introduce ContainmentLayoutManager QML plugin

[Marco Martin]

mart updated this revision to Diff 61786.
mart added a comment.


  - never auto resize while on edit mode
  - try to restore size as soon as possible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22034?vs=61642&id=61786

BRANCH
  mart/containmentlayoutmanager

REVISION DETAIL
  https://phabricator.kde.org/D22034

AFFECTED FILES
  components/CMakeLists.txt
  components/containmentlayoutmanager/CMakeLists.txt
  components/containmentlayoutmanager/abstractlayoutmanager.cpp
  components/containmentlayoutmanager/abstractlayoutmanager.h
  components/containmentlayoutmanager/appletcontainer.cpp
  components/containmentlayoutmanager/appletcontainer.h
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/configoverlay.cpp
  components/containmentlayoutmanager/configoverlay.h
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.cpp
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.h
  components/containmentlayoutmanager/gridlayoutmanager.cpp
  components/containmentlayoutmanager/gridlayoutmanager.h
  components/containmentlayoutmanager/itemcontainer.cpp
  components/containmentlayoutmanager/itemcontainer.h
  components/containmentlayoutmanager/qml/BasicAppletContainer.qml
  components/containmentlayoutmanager/qml/ConfigOverlayWithHandles.qml
  components/containmentlayoutmanager/qml/PlaceHolder.qml
  components/containmentlayoutmanager/qml/private/BasicResizeHandle.qml
  components/containmentlayoutmanager/qml/qmldir
  components/containmentlayoutmanager/resizehandle.cpp
  components/containmentlayoutmanager/resizehandle.h

To: mart, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D12916: Panel should not stop auto-hiding if a window wants attention

[Michael Moon]

michaelmoon updated this revision to Diff 61785.
michaelmoon edited the summary of this revision.
michaelmoon edited the test plan for this revision.
michaelmoon changed the repository for this revision from R120 Plasma Workspace 
to R119 Plasma Desktop.
michaelmoon added a comment.


  Add an option to prevent Task Manager unhiding panels when a window wants 
attention. Default is existing behaviour.
  
  See discussion in https://bugs.kde.org/show_bug.cgi?id=394119

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12916?vs=34256&id=61785

REVISION DETAIL
  https://phabricator.kde.org/D12916

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/main.qml

To: michaelmoon, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Filip Fila]

filipf added a comment.


  In D22468#495727 , @filipf wrote:
  
  > Yeah I may have improvised that with the Night Color KCM 😊
  >
  > The HIG way  
(and looking at other places) is to put the value to the right of the slider.
  >
  > In D22468#495721 , @romangg 
wrote:
  >
  > > In D22468#495679 , @filipf 
wrote:
  > >
  > > > Looks better, in particular I like the approach with buttons for 
orientation because it saves the second or two of having to remember what's 
clockwise or counter-clockwise.
  > > >
  > > > Only some minor things I noticed in the screenshots:
  > > >
  > > > - can the margins on the view area be increased so that it's in line 
with where the text begins (red is what I'd remove)? F7026173: image.png 

  > >
  > >
  > > Do you know if there is an "official" margin value for that?
  >
  >
  > Looks like smallSpacing but not quite so I'm going to check it out live and 
report back.
  
  
  Couldn't get any changes shown with kdesrc-build, but I zoomed in on the 
screenshot and it's 6px of space so `smallSpacing * 1.5`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> broulik wrote in OutputPanel.qml:41
> `i18n` and everywhere else

> i18n and everywhere else

I saw in other KCMs the Kirigami label being set without the i18n macro and I 
hoped Kirigami would do this internally. But apparently not, so I will add them.

> broulik wrote in OutputPanel.qml:141
> Why not just bind those properties directly?

When I try it with model.refreshRateIndex directly it takes the ComboBox model 
and not the output model. Is there another solution? Thinking of it I could add 
a `outputModel` property to the whole OutputPanel component and bind to that 
here then instead. Does this sound better?

> broulik wrote in Panel.qml:88
> Why is "Scale" under arrangement?

It's the global scale on X11 affecting every output in the arrangement and not 
only a single one. On X11 there are no scale values per output. Note to self: 
Change this label to "Global scale".

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Filip Fila]

filipf added a comment.


  Yeah I may have improvised that with the Night Color KCM 😊
  
  The HIG way  
(and looking at other places) is to put the value to the right of the slider.
  
  In D22468#495721 , @romangg wrote:
  
  > In D22468#495679 , @filipf wrote:
  >
  > > Looks better, in particular I like the approach with buttons for 
orientation because it saves the second or two of having to remember what's 
clockwise or counter-clockwise.
  > >
  > > Only some minor things I noticed in the screenshots:
  > >
  > > - can the margins on the view area be increased so that it's in line with 
where the text begins (red is what I'd remove)? F7026173: image.png 

  >
  >
  > Do you know if there is an "official" margin value for that?
  
  
  Looks like smallSpacing but not quite so I'm going to check it out live and 
report back.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Michail Vourlakos]

mvourlakos added a subscriber: ngraham.
mvourlakos added a comment.


  In D22468#495723 , @romangg wrote:
  
  > In D22468#495719 , @mvourlakos 
wrote:
  >
  > > This looks really nice,
  > >
  > > one question, having current values under the Slider does it follow a HIG 
rule or is it a proposition?
  >
  >
  > I copied this style from Night Color KCM. I didn't consult the HIG on that 
and to be honest I don't really like the look of it. Lone numbers feels 
unconnected to the slider and margins are kind of messed up. Imo slider 
components should provide an interface to add current value labels to them in a 
convenient and standardized fashion. Maybe as a Kirigami component?
  
  
  I agree it looks weird, especially because it breaks visual vertical 
alignment with the label on the left.
  
  @ngraham is there any HIG proposition how current values of sliders should be 
positioned?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  In D22468#495719 , @mvourlakos 
wrote:
  
  > This looks really nice,
  >
  > one question, having current values under the Slider does it follow a HIG 
rule or is it a proposition?
  
  
  I copied this style from Night Color KCM. I didn't consult the HIG on that 
and to be honest I don't really like the look of it. Lone numbers feels 
unconnected to the slider and margins are kind of messed up. Imo slider 
components should provide an interface to add current value labels to them in a 
convenient and standardized fashion. Maybe as a Kirigami component?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  In D22468#495679 , @filipf wrote:
  
  > Looks better, in particular I like the approach with buttons for 
orientation because it saves the second or two of having to remember what's 
clockwise or counter-clockwise.
  >
  > Only some minor things I noticed in the screenshots:
  >
  > - can the margins on the view area be increased so that it's in line with 
where the text begins (red is what I'd remove)? F7026173: image.png 

  
  
  Do you know if there is an "official" margin value for that?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Michail Vourlakos]

mvourlakos added a comment.


  This looks really nice,
  
  one question, having current values under the Slider does it follow a HIG 
rule or is it a proposition?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  In D22468#495713 , @knambiar wrote:
  
  > The `Scale` slider UI position is different in X11 and Wayland. Is this 
intentional?
  
  
  Yea, on Wayland we can set the scale for each output individually. On X11 
there is only a single scale factor to be set. But I plan to rename the slider 
label in the X11 case to `Global scale` to make this distinction more clear.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Rajeesh K Nambiar]

knambiar added a comment.


  The `Scale` slider UI position is different in X11 and Wayland. Is this 
intentional?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Kai Uwe Broulik]

broulik added a comment.


  Pretty cool!

INLINE COMMENTS

> kcm.cpp:48
> +qmlRegisterType();
> +qmlRegisterType("org.kde.kscreen", 1, 0, 
> "KScreenOutput");
> +

Given this is for the KCM only, I would suggest to name the import 
`org.kde.private.kcm.kscreen`

> output_model.cpp:45
> +const KScreen::OutputPtr &output = m_outputs[index.row()].ptr;
> +if (role == Qt::DisplayRole) {
> +return output->name();

`switch`?

> output_model.cpp:157
> +QHash roles;
> +roles[Qt::DisplayRole] = "display";
> +roles[EnabledRole] = "enabled";

You could also initialize it with `QAbstractItemModel::roleNames()` (which has 
"display") and then add yours to it

> OutputPanel.qml:41
> +Controls.CheckBox {
> +   Kirigami.FormData.label: "Enabled"
> +   checked: model.enabled

`i18n` and everywhere else

> OutputPanel.qml:41
> +Controls.CheckBox {
> +   Kirigami.FormData.label: "Enabled"
> +   checked: model.enabled

Try `Kirigami.FormData.checkable: true` to make the checkbox to the left 
instead of having a lonely tiny checkbox floating there

> OutputPanel.qml:49
> +   checked: model.primary
> +   onCheckedChanged: model.primary = checked
> +   visible: kcm.primaryOutputSupported

Use `onClicked` which only fires when the user explicitly clicks it, not in 
case a property/model role changes on its own, also everywhere else

> OutputPanel.qml:56
> +Layout.fillWidth: true
> +Controls.Slider {
> +id: resSlider

When you have loads of resolutions, we change the `Slider` for a `ComboBox`. I 
don't really like that but a slider could be fiddly to operate with many steps

> OutputPanel.qml:111
> +
> +   RotationButton {
> +   value: 0

I think you might want to use a `ButtonGroup` here to make them semantically 
mutally exclusive (just a suggestion)

> OutputPanel.qml:114
> +   tooltip: i18n("No Rotation")
> +   onClicked: model.rotation = 1
> +   checked: model.rotation === 1

Please use enum names here instead of magic numbers

> OutputPanel.qml:138
> +Controls.ComboBox {
> +Layout.fillWidth: true
> +Kirigami.FormData.label: "Refresh rate"

You sure this combobox should be full width?

> OutputPanel.qml:140
> +Kirigami.FormData.label: "Refresh rate"
> +model: outputPanel.refreshRates
> +currentIndex: outputPanel.getRefreshRateIndex()

They lack formatting (decimal separator and "Hz" suffix)

> OutputPanel.qml:141
> +model: outputPanel.refreshRates
> +currentIndex: outputPanel.getRefreshRateIndex()
> +onCurrentIndexChanged:

Why not just bind those properties directly?

> OutputPanel.qml:142
> +currentIndex: outputPanel.getRefreshRateIndex()
> +onCurrentIndexChanged:
> +outputPanel.setRefreshRateIndex(currentIndex)

Use `onActivated`  which only fires when the user explicitly changes it

> Panel.qml:34
> +}
> +// TODO: this is a hack to align the label with other labels
> +//   what we probably really want is using a FormLayout from

Have you tried `twinFormLayouts`?

> Panel.qml:88
> +Layout.fillWidth: true
> +Kirigami.FormData.label: "Scale"
> +

Why is "Scale" under arrangement?

> Panel.qml:98
> +to: 3
> +stepSize: 0.1
> +live: true

Can we make it not show all the tick marks but only the integer ones like in 
the current scale UI?

> Panel.qml:101
> +value: kcm.globalScale
> +onValueChanged: kcm.globalScale = value
> +}

Use `onMoved` which blabla, see `onClicked` and `onActivated`

> Panel.qml:105
> +Layout.alignment: Qt.AlignHCenter
> +text: Math.round(globalScaleSlider.value * 10) / 10
> +}

You can pretty-format the number like this:

  globalScaleSlider.value.toLocaleString(Qt.locale(), "f", 1)

(If that doesn't work wrap it in `Number(...).toLocaleString(...)`)

> Panel.qml:122
> +
> +onCheckedChanged: checked ? kcm.outputRetention = 0 : 0
> +}

`onClicked`
I also think the operator priorities are a bit mixed up here

> RotationButton.qml:32
> +
> +PlasmaComponents.ToolButton {
> +id: button

Don't use `PlasmaComponents` stuff in widget-like dialogs.
Instead, you want to be using `QQC2.Button` and then overriding its 
`contentItem` (I think). It is a bit convoluted as qqc2-desktop-style paints 
the entire button as `background`

or you just turn the button on its side like you do below :D

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: broulik, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Filip Fila]

filipf added a comment.


  Looks better, in particular I like the approach with buttons for orientation 
because it saves the second or two of having to remember what's clockwise or 
counter-clockwise.
  
  Only some minor things I noticed in the screenshots:
  
  - can the margins on the view area be increased so that it's in line with 
where the text begins (red is what I'd remove)?
  
  F7026173: image.png 
  
  - for every form data label I'd add ":" at the end
  - in the case of sliders I would simply add the label to the slider, not the 
column layout

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22452: Fix text color in non-selected tabs in Firefox

[Matej Mrenica]

mthw added a comment.


  In D22452#495325 , @ngraham wrote:
  
  > Whether or not it's better is not relevant for this patch, which right now 
is only about fixing the text color. It's best not to mix multiple changes like 
this, unless you want to expand the patch in scope, in which case it should be 
re-titled accordingly.
  >
  > Still, I would recommend doing one change per patch, because it makes each 
one more likely to get in compared to patches with multiple changes (especially 
when any one of those individual changes may be controversial or require 
discussion).
  
  
  If I did re-title and change the description, would this have a better chance 
of passing? The chage is so small (number of lines) that It probably wouldn't 
make sense to split it. If not, then I am stuck and I have clearly bitten more 
than I can chew.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22429: Make "Updates Available" notification persistent but low priority

[Kai Uwe Broulik]

broulik added a comment.


  Oh God, please not make it persistent. This notification comes up every 
single time I start plasmashell and now I have to explicitly manually get rid 
of it.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22429

To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ShowQR.qml:25
> +import org.kde.kirigami 2.3 as Kirigami
> +import org.kde.prison 1.0 as Prison
> +

Add this as `RUNTIME` Cmake dependency

> ShowQR.qml:27
> +
> +Window
> +{

Can you instad do a `StackView` and show the barcode inside the applet like 
Klipper does it? This would make it more consistent.

> handler.cpp:230
> +
> +KNotification *notification = new KNotification("WifiQR", 
> KNotification::CloseOnTimeout);
> +notification->setComponentName("networkmanagement");

What does this do?

> handler.h:72
> +
> +QString wifiCode(const QString& connection, const QString& 
> specificObject) const;
> +

Docs, coding style.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21905: [Digital Clock] Open KOrganizer with event details on click

[Kai Uwe Broulik]

broulik added a comment.


  > this should not be merged until Plasma master can depend on KF5 5.61
  
  Or you do a check of `enabled: typeof monthView.daysModel.showEventDetails 
=== "function"`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21905

To: dvratil, #plasma
Cc: broulik, apol, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart