D22482: WIP: Show file dialog in directory mode when only directory is requested

[Alexander Volkov]

volkov added a comment.


  This is for non-sandboxed applications that want to use KDE file dialog.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22482

To: volkov, apol, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22482: WIP: Show file dialog in directory mode when only directory is requested

[Jan Grulich]

jgrulich added a comment.


  If this is meant to be used by Firefox, then it won't work either, even when 
you use GTK_USE_PORTAL=1.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22482

To: volkov, apol, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22429: Make "Updates Available" notification persistent but low priority

[Kai Uwe Broulik]

broulik added a comment.


  > That's kind of the point though. The user should be seeing these 
notifications and having to explicitly acknowledge them in some way;
  
  It wasn't nearly as annoying if a kded module was responsible for it and not 
the applet, so it wouldn't show up every single time I restart plasmashell 
which I tend to do a lot.

INLINE COMMENTS

> DiscoverNotifier.cpp:77
>  KRun::runCommand(QStringLiteral("plasma-discover"), nullptr);
> +if (m_updatesAvailableNotification) { 
> m_updatesAvailableNotification->close(); }
>  }

Coding style, put contents on a new line

> DiscoverNotifier.h:87
>  QNetworkConfigurationManager* m_manager = nullptr;
> +KNotification* m_updatesAvailableNotification = nullptr;
>  };

This has to be a `QPointer`.

`KNotification` self-deletes when closed leading to crashes in `close()` calls 
below accessing garbage memory.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22429

To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[kwrited] [Bug 409854] New: Remove progress bar on each note, which indicates time left for fade out

[Postix]

https://bugs.kde.org/show_bug.cgi?id=409854

Bug ID: 409854
   Summary: Remove progress bar on each note, which indicates time
left for fade out
   Product: kwrited
   Version: 5.16.2
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: pos...@posteo.eu
  Target Milestone: ---

Created attachment 121545
  --> https://bugs.kde.org/attachment.cgi?id=121545&action=edit
Screenshot of the the issue.

The rewritten notification system shows a progress bar on the right side for
each note. If you hover the mouse on the notification the progress bar will
reset.

In my opinion these progress bars are only distracting and don't give you any
extra value. If you miss a notification you can still look it up in the
applet's list.

That's why I suggest to remove it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-knotifications] [Bug 409854] Remove progress bar on each note, which indicates time left for fade out

[Postix]

https://bugs.kde.org/show_bug.cgi?id=409854

Postix  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|kdelibs-b...@kde.org
 CC||k...@privat.broulik.de,
   ||kdelibs-b...@kde.org,
   ||n...@kde.org,
   ||pos...@posteo.eu
Version|5.16.2  |5.59.0
Product|kwrited |frameworks-knotifications
  Component|general |general

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12916: Panel should not stop auto-hiding if a window wants attention

[David Edmundson]

davidedmundson resigned from this revision.
davidedmundson added a comment.


  No objection from me.
  
  I'll wait a few days in case Eike has comments, but from my POV, ship it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Filip Fila]

filipf accepted this revision as: filipf.
filipf added a comment.
This revision is now accepted and ready to land.


  As far as I'm concerned the patch is landable; I really like that it's 
developed into a more generic placeholder rather than one just for distro 
logos. Nice work @cblack, make sure to edit the commit title and message to 
reflect this though.
  
  Some things to still consider in the near or more distant future:
  
  - present to distros (namely openSUSE) and see if this is what they wanted
  - see if we want this on by default
  - add a UI option for having a logo and then an image chooser
  - see if the drop shadow will be interfering with existing drop shadows in 
logos (but logo authors can just remove it themselves I guess)
  - move the default svg to the artwork subfolder since it feels like it 
belongs there
  - fix the binding loop related to `sourceSize.width`

INLINE COMMENTS

> Main.qml:421
> +sourceSize.height: height
> +sourceSize.width: width
> +opacity: loginScreenRoot.uiVisible ? 0 : 1

try implicitWidth to avoid binding loop

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this way we can control both their visibility in a single call. with the
  previous code we'd only set the label as hidden and leave a dangling
  spacer to mess with the layout.
  
  BUG: 409807

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22485

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> filipf wrote in Main.qml:421
> try implicitWidth to avoid binding loop

Just remove sourceSize.width

We dont define a width.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22429: Make "Updates Available" notification persistent but low priority

[Nathaniel Graham]

ngraham added a comment.


  In D22429#496180 , @broulik wrote:
  
  > > That's kind of the point though. The user should be seeing these 
notifications and having to explicitly acknowledge them in some way;
  >
  > It wasn't nearly as annoying if a kded module was responsible for it and 
not the applet, so it wouldn't show up every single time I restart plasmashell 
which I tend to do a lot.
  
  
  Me too. However, this is a developer workflow, not a typical user workflow. 
Defaults should be optimized for users, not developers. Weirdos like us who are 
killing and restarting plasmashell 30 times a day can just turn off Discover's 
updates notification.
  
  I agree that it would be nice if we could somehow make the notification only 
appear when plasmashell is started due to a login, not every time.
  
  Will fix the code issues you bring up in another patch.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22429

To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

how about a developer KCM

[Harald Sitter]

Kai keeps asking where to expose some of the "hidden" config options
in Drkonqi and I keep not having a good answer.

How about we make a developer-only KCM where we can have any amount of
silly configuration options that we would generally not know how to
expose to the user or don't want the user to have readily available?

I seem to recall kwin having some settings which intentionally have no
UI backing. Drkonqi has like 3 or 4 of them even (all to streamline
crash processing for developers) that I am sure maybe 3 people know
about.

There was also some lamenting of persistent notifications in
https://phabricator.kde.org/D22429 which perhaps too could be
influenced by developer-only settings.

Taking a trick from android's playbook you'd have to click the distro
icon kinfocenter 7 times to enable dev mode, which enables a special
KCM to show up in systemsettings where you can then configure hidden
stuff.

Thoughts?

Re: how about a developer KCM

[Nate Graham]

No objections, sounds like a good idea to me. I would even say it should 
be something that gets built when you compile Plasma from source, and in 
this case, you just automatically get it. That way regular users will 
never see it, and developers always will, with no configuration or 
secret Konami codes or anything required.


Nate


On 7/16/19 7:33 AM, Harald Sitter wrote:

Kai keeps asking where to expose some of the "hidden" config options
in Drkonqi and I keep not having a good answer.

How about we make a developer-only KCM where we can have any amount of
silly configuration options that we would generally not know how to
expose to the user or don't want the user to have readily available?

I seem to recall kwin having some settings which intentionally have no
UI backing. Drkonqi has like 3 or 4 of them even (all to streamline
crash processing for developers) that I am sure maybe 3 people know
about.

There was also some lamenting of persistent notifications in
https://phabricator.kde.org/D22429 which perhaps too could be
influenced by developer-only settings.

Taking a trick from android's playbook you'd have to click the distro
icon kinfocenter 7 times to enable dev mode, which enables a special
KCM to show up in systemsettings where you can then configure hidden
stuff.

Thoughts?

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack updated this revision to Diff 61859.
cblack added a comment.


  Remove sourceSize.width

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61825&id=61859

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Stefan Brüns]

bruns added a comment.


  In D22333#494852 , @anthonyfieroni 
wrote:
  
  > 
https://phabricator.kde.org/source/solid/browse/master/src/solid/devices/frontend/devicemanager.cpp$301
  >  @bruns, It's backend per thread
  
  
  Yes, you are correct, so there are no threading issues, sorry.
  
  On the other hand, this IMHO makes this approach even less profitable:
  
  1. every backend is initialized once from the two helpers (assuming both 
dataengines are used).
  2. after the threads finish, all but the relevant UDIs are thrown away (and 
care must be taken not to use anything else - the devices would be dangling 
pointers in the now gone thread storage)
  3. the first completing thread triggers the initialization of the backends 
again - in the main thread.
  
  As the initialization happens implicitly by the Device instantiation, for 
e.g. UDisks there are two synchronous DBus calls now, one for introspection 
from the manager backend and one for the device itself from the device backend. 
Both are done in the main thread, and we will block even longer.
  
  So any gain here is AFAICS from the fact the constructor no longer blocks on 
a DBus call.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: anthonyfieroni, bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: how about a developer KCM

[David Edmundson]

I have one hidden KCM already.

It was requested I make the super awesome qtquicksettings module hidden.
It uses a little hack to make it findable in krunner, but not listed
in system settings by parenting to a group, then hiding that group.

I  have no objections to things that are only useful to devs being in
a hidden KCM.

However, I fear it will end up becoming some sort of hidden
plasma-tweaks, where we dump general aesthetic/behaviour settings in
here which we think are too niche for the main UI.
I don't want that to happen.

Re: how about a developer KCM

[Nate Graham]

On 7/16/19 8:32 AM, David Edmundson wrote:

However, I fear it will end up becoming some sort of hidden
plasma-tweaks, where we dump general aesthetic/behaviour settings in
here which we think are too niche for the main UI.
I don't want that to happen.


Strongly agreed.

Nate

D22429: Make "Updates Available" notification persistent but low priority

[Felix Ernst]

felixernst added a comment.


  How about only making security update notifications persistent? There is no 
real harm in missing non-security updates in my opinion.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D22429

To: ngraham, apol, #discover_software_store
Cc: felixernst, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22492: pull platforms/distributions dynamically out of the bugzilla api

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this ensures that all known platforms are actually in the comobox and
  reduces the amount of string duplication.
  
  the new code gets the list of platforms from bugzilla and then either
  attempts to select the one which was auto-detected by systeminformation
  or recycle the one previously used.
  
  setup is now triggered in the constructor. loading from the api is still
  fairly cheap but even so takes longer than the hardcoded list, so
  loading this on aboutToShow is fairly unattractive at this point.
  
  the now useless members for combobox state tracking are gone entirely.
  
  BUG: 383530

TEST PLAN
  list gets loaded as expected
  list errors as expected when offline

REPOSITORY
  R871 DrKonqi

BRANCH
  distros

REVISION DETAIL
  https://phabricator.kde.org/D22492

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/ui/assistantpage_bugzilla_information.ui

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22491: implement parts of the bug field api endpoint

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  excessively unnecessary properties are not mapped currently as the only
  use we have for this endpoint is to get the list of remotely known
  platforms/distros. this may change in the future of course.

TEST PLAN
  unit test passes

REPOSITORY
  R871 DrKonqi

BRANCH
  fields

REVISION DETAIL
  https://phabricator.kde.org/D22491

AFFECTED FILES
  src/bugzillaintegration/libbugzilla/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/autotests/bugfieldtest.cpp
  src/bugzillaintegration/libbugzilla/autotests/data/field.rep_platform.json
  src/bugzillaintegration/libbugzilla/clients/bugfieldclient.cpp
  src/bugzillaintegration/libbugzilla/clients/bugfieldclient.h
  src/bugzillaintegration/libbugzilla/models/bugfield.cpp
  src/bugzillaintegration/libbugzilla/models/bugfield.h

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 67 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/67/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 16 Jul 2019 15:28:16 +
 Build duration:
2 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-16T15:30:41.126Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-16T15:30:41.126Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-16T15:30:41.126Z] PROCESSOR_LEVEL   = '6'[2019-07-16T15:30:41.126Z] PROCESSOR_REVISION= '5e03'[2019-07-16T15:30:41.126Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-16T15:30:41.126Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-16T15:30:41.126Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-16T15:30:41.126Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-16T15:30:41.126Z] PROMPT= '$P$G'[2019-07-16T15:30:41.126Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-16T15:30:41.126Z] PUBLIC= 'C:\Users\Public'[2019-07-16T15:30:41.126Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/67/display/redirect?page=changes'[2019-07-16T15:30:41.126Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/67/display/redirect'[2019-07-16T15:30:41.126Z] STAGE_NAME= 'Configuring Build'[2019-07-16T15:30:41.126Z] SYSTEMDRIVE   = 'C:'[2019-07-16T15:30:41.126Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-16T15:30:41.126Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-16T15:30:41.126Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-16T15:30:41.126Z] UCRTVERSION   = '10.0.17763.0'[2019-07-16T15:30:41.126Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-16T15:30:41.126Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-16T15:30:41.126Z] USERNAME  = 'Jenkins'[2019-07-16T15:30:41.126Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-16T15:30:41.126Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-16T15:30:41.126Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-16T15:30:41.126Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-16T15:30:41.126Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-16T15:30:41.126Z] VCTOOLSVERSION= '14.16.27023'[2019-07-16T15:30:41.126Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-16T15:30:41.126Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-16T15:30:41.126Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-16T15:30:41.126Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-16T15:30:41.126Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-16T15:30:41.126Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-16T15:30:41.126Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-16T15:30:41.126Z] VSCMD_VER = '16.0.3'[2019-07-16T15:30:41.126Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-16T15:30:41.126Z] WINDIR= 'C:\WINDOWS'[2019-07-16T15:30:41.126Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-16T15:30:41.126Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-16T15:30:41.126Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-16T15:30:41.126Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-16T15:30:41.126Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-16T15:30:41.126Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-16T15:30:41.126Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-16T15:30:41.126Z] __DOTNET_ADD_64BIT= '1'[2019-07-16T15:30:41.126Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-16T15:30:41.126Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-16T15:30:41.126Z] CMAKE_PREFIX_PAT

D22493: [Notifications] Move history items' icons over to the left a bit

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Move the expired history items' icons over a bit so there isn't such an icon 
soup
  on the right-hand size of the widget. This patch makes them vertically aligned
  with the configure button, not the close button.
  
  BUG: 409855
  FIXED-IN: 5.16.4

TEST PLAN
  F7033425: Moved over.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  tweak-history-icon-placement (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D22493

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: ngraham, broulik, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> theme.conf.cmake:2
>  [General]
> +showlogo=shown
> +logo=${KDE_INSTALL_FULL_DATADIR}/sddm/themes/breeze/default-logo.svg

I thought this was going to be off by default for now?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

[Carson Black]

cblack added a comment.


  Doesn't really matter to me ¯\_(ツ)_/¯
  If other people want it off by default, I'll update the default theme.conf

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  All right, let's try having it on by default for now and see if we hate it 
during the time before 5.17 branches. If so, we can always turn it off before 
then.
  
  #Plasma  folks?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf, ngraham
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12916: Panel should not stop auto-hiding if a window wants attention

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: hein.
ngraham added a comment.
This revision is now accepted and ready to land.


  @hein?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Here are some linking issues beyond my knowledge of C++ and CMake. Any 
suggestions?

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

[David Edmundson]

davidedmundson added a comment.


  Off.
  
  A login manager does not know what session you will be using.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf, ngraham
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61872.
guoyunhe added a comment.


  Solve linking issue

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61868&id=61872

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61873.
guoyunhe added a comment.


  Remove KIO linking

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61872&id=61873

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61876.
guoyunhe added a comment.


  Use constructor parameter to pass collection ID

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61873&id=61876

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61877.
guoyunhe added a comment.


  Better naming

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61876&id=61877

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashbaseprovider.cpp
  dataengines/potd/unsplashbaseprovider.h
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[David Edmundson]

davidedmundson added a comment.


  Kinda, you're summary missing a key part.
  (the commit description is a bit poor)
  
  This patch does the following:
  
  - It does the search in the other thread. That creates and iterates every 
possible device. This is expensive as there are lots of potential devices. We 
fetch pretty much everything udisks knows.
  
  - From the given list we recreate the select few devices that are relevant. 
This is relatively cheap. It does still block as you point out, but now for a 
much much smaller set of objects compared to before.
  
  (on my laptop that's 56 devices created when searching, resulting in 8 useful 
devices).
  
  This is where the main thread saving is meant to come in.
  
  As for dangling pointers. The private manager object dies as its backed by 
TLS. The device object itself does not. The device object has guards against a 
deleted manager internally. It won't crash, but will return "dead" values.
  
  
  
  You're absolutely right it's a hack around the current state, rather than a 
good long term direction. I'm not exactly loving it.
  I would love to rework solid to have a nice async api, and also to not use 
data engines. I'm not sure its doable within kf5.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: anthonyfieroni, bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22333: Move Solid::Device::listFromQuery calls to a separate thread

[Aleix Pol Gonzalez]

apol added a comment.


  Things we could do right now, without a super big refactoring:
  
  On a solid level:
  
  - Maybe a useful intermediate change would be to add API in Solid to move 
devices between threads.
  - Alternatively we could consider making sure backends stick to one specific 
non-GUI thread, keeping only 1 backend per application and have internals speak 
to it (admittedly a bigger refactoring).
  
  On a plasma level:
  
  - Keep Solid::Device::listFromQuery calls into a separate QThread and only 
extract tuples with the information we need rather than a Solid::Device (which 
was obviously faster but crashed because we can't move devices between threads).
  
  Either way, it's not a matter of KF5, adding new API is perfectly fine, 
problem is that we may end up redesigning both the frontend and the backend and 
this is far too much work right now. And so it will be when we're porting 
things to KF6.
  
  Also, I would suggest not really expecting to be able to do a nice, in-thread 
async API. Note that here we have exactly the same problem we have on plasma-nm 
and in Qt bearing networkmanager backend. It's hard to use these types 
asynchronously and we shouldn't go through hoops to make it thread-local.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: anthonyfieroni, bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Aleix Pol Gonzalez]

apol updated this revision to Diff 61885.
apol added a comment.


  Pass different data as function arguments as suggested

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22457?vs=61836&id=61885

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/ShowQR.qml
  libs/handler.cpp
  libs/handler.h

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22457: Make it possible to show the QR of a network connection

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Much simple! Thanks.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Bhushan Shah]

bshah added a comment.


  bump

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

Re: how about a developer KCM

[Eike Hein]

On 7/16/19 11:36 PM, Nate Graham wrote:

On 7/16/19 8:32 AM, David Edmundson wrote:

However, I fear it will end up becoming some sort of hidden
plasma-tweaks, where we dump general aesthetic/behaviour settings in
here which we think are too niche for the main UI.
I don't want that to happen.


Strongly agreed.


Same.

I think DrKonqi-related options are natural fit in 'kdebugsettings' 
however. This app already exists, is essentially for devs, and has 
domain overlap with what DrKonqi does.





Nate


Cheers,
Eike

D18860: Add comment / description to the translations kcm

[Eike Hein]

hein added a comment.


  Agreed with Harald, the wording's misleading sorry :)

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart