D22553: guard against plasmashell being properly dead and not showing the SNI

[Harald Sitter]

sitter added a comment.


  This actually sucks tremendously.
  
  Kai said he used that service because he primarily cared about the 
notification being pretty.
  
  BUUUT actually considering the StatusNotifierHost is hugely horrible. We'd 
have to check and watch StatusNotifierWatcher (kded) which tracks the hosts 
(plasmashell) and then watch its host registration property. This would blow 
things up quite a bit and honestly it's not wroth the faff as we could just 
latch on to the Notifications service and get much the same end result in 99% 
of cases I imagine?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22553

To: sitter, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22634: Sync NumLock preference

[Nathaniel Graham]

ngraham added a comment.


  Yeah, you're steadily chewing through 
https://bugs.kde.org/buglist.cgi?bug_status=__open__&component=kcm_sddm&list_id=1645796&product=systemsettings
 :-)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22634

To: filipf, #plasma, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22634: Sync NumLock preference

[Filip Fila]

filipf added a comment.


  Ah cool, there was a feature request. I have NumLock on by default so I'll 
also be making use of the feature :)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22634

To: filipf, #plasma, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22627: Add a GUI option for choosing the input method

[Filip Fila]

filipf added a comment.


  Yeah an empty entry is bad UI but it works for the code since it ends up just 
grabbing the text from the combobox and writing it to the config file :P ... it 
was a quick solution I'll admit.
  
  The feature request was this, a much more straightforward idea: 
https://forum.kde.org/viewtopic.php?f=285&t=161536&p=420073#p420073
  
  But having that checkbox seemed too specific and it seemed like having a 
general input method chooser might be more useful. What do you think?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22627

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22634: Sync NumLock preference

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:7d51edcc094b: Sync NumLock preference (authored by 
filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22634?vs=62264&id=62349

REVISION DETAIL
  https://phabricator.kde.org/D22634

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp

To: filipf, #plasma, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

camiloh updated this revision to Diff 62345.
camiloh added a comment.


  now using root.parent instead of applicationWindow()

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22648?vs=62309&id=62345

BRANCH
  handle-follow-drawer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 updated this revision to Diff 62338.
luc4 added a comment.


  Removed volatile modifier, not probably useful in that context.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22306?vs=62170&id=62338

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/plugin/draghelper.cpp
  applets/kicker/plugin/draghelper.h

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D12916: Panel should not stop auto-hiding if a window wants attention

[Eike Hein]

hein added a comment.


  In D12916#500367 , @davidedmundson 
wrote:
  
  > "does the task manager need attention simply because some different window 
needs attention"?
  
  
  There's an easy answer: We have a lot of users who rely on that.
  
  A lot of people want to be able to focus without disturbance, but a lot of 
people also don't want to miss that important notification they're waiting for. 
For the latter, having an off-desktop window be able to punch through and raise 
the panel is important.
  
  If you look at industry trends, there's currently a very active discussion on 
how to mediate the range of "leave me alone, all these notifications are 
killing me" and "let the important stuff punch through". In 5.16 we introduced 
some of the same ideas others have: DND mode and per-app configurability.
  
  This problem is broadly part of the same conversation and so it's not really 
specific to the TM or the panel. What the TM does is provide a view into system 
state sharded by application. The notification applet does the same. The window 
attention state and notification messages are both notification mechanisms. 
Some of the "can this punch through?" configurability should likey be there, 
because most definitely some things should be able to.
  
  The other angle to attack this problem from is purely the panel UX, where you 
can pick between the model of "attention is needed permanently until nothing 
needs attention" and a model of "requests for attention need to be explicitly 
acknowledged, and after they have been can be ignored", i.e. allowing the panel 
to hide after enter+exit clears a bit. I like this one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham, hein
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21829: Improved Touch support for Kickoff

[Eike Hein]

hein added a comment.


  In D21829#498921 , @steffenh wrote:
  
  > I have the last days looking at plasma-frameworks, but my knowledge of the 
working of plasma is close to zero, so I am afraid I'm not able to do this.
  
  
  Before we discuss alternatives: Are you willing to have me try and teach you? 
I'm actually going to be very busy with a move in the next few weeks, so this 
could end up taking quite significant time between the two of us, but if you 
have the time and patience I don't mind helping you through creating the patch 
I had in mind.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

To: steffenh, #plasma, hein, ngraham
Cc: mart, sbergeron, davidedmundson, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12916: Panel should not stop auto-hiding if a window wants attention

[Eike Hein]

hein added a comment.


  If that's how it worked in KDE 4 I think it could well qualify as a 
regression.
  
  Regardless of that, my personal take would be that the user entering and 
exiting the panel constitutes having explicitly acknowledged "needs attention" 
status and then ignoring it after is fine.
  
  Implementation-wise, that means in the part where you removed that block 
earlier we need to evaluate a dirty flag for whether the status change has been 
acknowledged with an enter+leave or not.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham, hein
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12916: Panel should not stop auto-hiding if a window wants attention

[David Edmundson]

davidedmundson added a comment.


  @eike please also see my comments in the bug report for context.
  
  -
  
  The core part that's up for discussion is simply:
  "does the task manager need attention simply because some different window 
needs attention"?
  
  Semantically the scope of that question is purely within the task manager, 
and not a wider panel problem.
  
  If we want to avoid option creep, we could simply re-evaluate that.
  
  I agree the text isn't great, but I didn't have anything else that didn't 
expose internals.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham, hein
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12916: Panel should not stop auto-hiding if a window wants attention

[Michael Moon]

michaelmoon added a comment.


  > would having to move your mouse over the panel and exiting again to hide it 
again work?
  
  Like it did in KDE4? Yeah that would work for me!
  
  Does that make the associated bug a regression?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham, hein
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22654: Fix typo

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:00ccd9019816: Fix typo (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22654?vs=62328&id=62334

REVISION DETAIL
  https://phabricator.kde.org/D22654

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: jbbgameich, #kirigami, davidedmundson, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D12916: Panel should not stop auto-hiding if a window wants attention

[Eike Hein]

hein added a comment.


  I wonder if there's another fix we could attempt: Rather than permanently 
staying visible, would having to move your mouse over the panel and exiting 
again to hide it again work?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham, hein
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22648: make handle follow arbitrary height of the drawer

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> OverlayDrawer.qml:210
> +if(root.height < applicationWindow().height) {
> +margin = applicationWindow().height - root.height - 
> root.y + Units.smallSpacing;
> +}

applicationWindow() should be replaceable with root.parent, and that makes it 
work also when not in a kirigami applicationwindow

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22648

To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22654: Fix typo

[Jonah Brüchert]

jbbgameich updated this revision to Diff 62328.
jbbgameich added a comment.


  Fix another occurence

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22654?vs=62324&id=62328

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22654

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: jbbgameich, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D12916: Panel should not stop auto-hiding if a window wants attention

[Michael Moon]

michaelmoon added a comment.


  @hein thanks for your comments.
  
  Fwiw, the reason I use KDE in the first place is that it has //all// the 
options, and I can control my desktop experience to a significantly greater 
degree than any other DE I've tried so far - but there's just one option it 
seems to be missing, to my great frustration (and several others, see bug 
394119)!
  
  I'm a fairly experienced programmer, but mostly in embedded rather than 
graphical, let alone Qt/KDE specifics, so any hints on where specifically to 
look for places to inject the ability to stop Panels getting in my way when 
some random stupid app sets its attention flag would be deeply appreciated.
  
  As you can see in the history, I originally submitted this at the Panel level 
rather than the Task Manager level, although admittedly with a clumsy hammer - 
would you prefer if it were moved back to the panel? @davidedmundson listed 
some reasons that this might be inappropriate in bug 394119, which is why I 
moved the behaviour change from Panel to Task Manager in the first place.
  
  Are you suggesting that I would need to set KDE permanently into this 'Do Not 
Disturb' mode to avoid one single frustrating behaviour? What other features 
might I lose access to in that case?
  
  Global setting in notification settings sounds fine, any hints on where to 
find those settings, and how to plumb it into the Task Manager or Panel? 
However I'm somewhat concerned that this may also conceptually be the wrong 
spot since the core issue (see bug 394119) specifically and uniquely affects 
the interaction between Task Manager's handling of random windows' rogue 
flag-setting, and Panels acting on the results of that.
  
  In short, where exactly should this option go and what should it be called, 
given the conceptual structure of KDE as a whole? All I want is for panels 
containing a task manager to not *stay* visible if some application randomly 
decides it needs attention..

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham, hein
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22654: Fix typo

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  leftLargin -> leftMargin

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22654

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22564: [SwipeListItem] Take into account scrollbar visibility and form factor for handle and inline actions

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f8617ce137a6: [SwipeListItem] Take into account scrollbar 
visibility and form factor for… (authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22564?vs=62319&id=62322

REVISION DETAIL
  https://phabricator.kde.org/D22564

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D22564: [SwipeListItem] Take into account scrollbar visibility and form factor for handle and inline actions

[Nathaniel Graham]

ngraham updated this revision to Diff 62319.
ngraham added a comment.


  - Make it work when using a Flickable too
  - Make the logic more generic
  - Handle RTL too

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22564?vs=62313&id=62319

BRANCH
  respect-scrollbar-visibility-for-swipelistitem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22564

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D22652: Desktop scripting: support args

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dbd2cd472153: Desktop scripting: support args (authored 
by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22652?vs=62312&id=62314

REVISION DETAIL
  https://phabricator.kde.org/D22652

AFFECTED FILES
  shell/scripting/containment.cpp
  shell/scripting/containment.h

To: mart, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D12916: Panel should not stop auto-hiding if a window wants attention

[Eike Hein]

hein added a comment.


  I don't like this.
  
  - I think it's option creep
  - The user would have to configure this for each of their Task Manager 
applets to make it pervasive (consider multiple monitors with multiple Task 
Managers)
  - It won't address other applets that may use the same status
  
  I think a better approach to this problem would be to make the panels aware 
of the new Do Not Disturb mode feature introduced in 5.16, and if necessary add 
some config to what DND affects.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12916

To: michaelmoon, ngraham
Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22652: Desktop scripting: support args

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  support args in applet creation with an optional argument to
  containment::addWidget
  scripts not using it will continue to work as before

TEST PLAN
  arguments get understood byt the created applet
  applets can still be created without arguments

REPOSITORY
  R120 Plasma Workspace

BRANCH
  args

REVISION DETAIL
  https://phabricator.kde.org/D22652

AFFECTED FILES
  shell/scripting/containment.cpp
  shell/scripting/containment.h

To: mart, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

[Nathaniel Graham]

ngraham updated this revision to Diff 62313.
ngraham added a comment.


  Make the scrollbar test work (thanks @mart)

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22564?vs=62116&id=62313

BRANCH
  respect-scrollbar-visibility-for-swipelistitem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22564

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

camiloh updated this revision to Diff 62309.
camiloh added a comment.


  take into consideration the y position
  
  Summary: if the drawer height prop has been set to a custom value, might as 
well the y position too, so take it into account to position the handle

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22648?vs=62302&id=62309

BRANCH
  handle-follow-drawer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22648: make handle follow arbitrary height of the drawer

[Camilo Higuita]

camiloh created this revision.
camiloh added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  If the height of the drawer is set to a different value from the 
applicationWindow height, then the drawer handle follows the bottom on the 
drawer, staying at the bottom the the new arbitrary height value

REPOSITORY
  R169 Kirigami

BRANCH
  handle-follow-drawer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22648

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: camiloh, mart
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D22630: Slow down the busy indicator's rotation speed

[Nathaniel Graham]

ngraham added a comment.


  Yup, See D22645  and D22646 
. Turns out that they were already using a 
different duration, so with those patch landed, all the busy indicators will 
use the same rotational speed.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: broulik, cfeck, filipf, plasma-devel, cullmann, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22627: Add a GUI option for choosing the input method

[Nathaniel Graham]

ngraham added a comment.


  In D22627#499798 , @filipf wrote:
  
  > In D22627#499699 , @ngraham 
wrote:
  >
  > > Also these hardcoded values make me feel a little leery. Is there a way 
we can programmatically generate them or get them from SDDM or something?
  >
  >
  > Not that I know of. The only time they're mentioned in the SDDM codebase is 
in this documentation file: 
https://github.com/sddm/sddm/blob/develop/data/man/sddm.conf.rst.in
  
  
  Okay, that's fine.
  
  In D22627#499798 , @filipf wrote:
  
  > In D22627#499699 , @ngraham 
wrote:
  >
  > > Why is there a blank entry?
  >
  >
  > The blank entry is sort of the whole point of the option. The way to fix 
the virtual keyboard popping up on its own with some themes is to leave 
InputMethod empty:
  >
  > 
https://github.com/MarianArlt/sddm-sugar-light/issues/2#issuecomment-439741458
  >  https://www.reddit.com/r/kde/comments/7lk2bs/onscreen_keyboard_on_sddm/
  
  
  So maybe this entry should be called "System Default" or something then? 
Having an empty entry in the combobox is just a really weird UI. Also, I feel 
like the mapping between this UI and the actual bug is not very clear. If the 
purpose is to work around that bug, IMO the UI should reflect that. If on the 
other hand the feature has more general utility, then the UI should make more 
clear just what it is and does, while somehow including a connection to the 
worked-around bug.
  
  Does that make sense?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22627

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22634: Sync NumLock preference

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Nice. This is becoming a very useful feature rich in bug fixes. Shipit!

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sync-numlock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22634

To: filipf, #plasma, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22641: Inject content script also into about:blank

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ed5982697c83: Inject content script also into about:blank 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22641?vs=62283&id=62288

REVISION DETAIL
  https://phabricator.kde.org/D22641

AFFECTED FILES
  extension/manifest.json

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22642: Monitor entire document rather than the documentElement specifically

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:88f2da50b640: Monitor entire document rather than the 
documentElement specifically (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22642?vs=62284&id=62289

REVISION DETAIL
  https://phabricator.kde.org/D22642

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22641: Inject content script also into about:blank

[Fabian Vogt]

fvogt added a comment.


  An iframe without source, the things web devs come up with...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22641

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22572: Remove scaling of iconsize unit for isMobile

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a89b2334f137: Remove scaling of iconsize unit for 
isMobile (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22572?vs=62086&id=62285

REVISION DETAIL
  https://phabricator.kde.org/D22572

AFFECTED FILES
  src/controls/Units.qml

To: camiloh, #vdg, mart, ngraham
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22642: Monitor entire document rather than the documentElement specifically

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Calling `document.write` will replace the entire `documentElement` with a new 
one, effectively removing our mutation observers.

TEST PLAN
  Together with D22641  I can now 
successfully control that kaltura player thing heise uses, see the video on [1].
  Normal website is still monitored correctly
  
  [1] 
https://www.heise.de/newsticker/meldung/Star-Trek-Picard-Neuer-Trailer-mit-alten-Bekannten-4475986.html

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22642

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22613: kstart: Prevent crash when running without args

[Tasos Sahanidis]

tasossahanidis marked an inline comment as done.
tasossahanidis added a comment.


  Assuming I did everything correctly, it should be okay now.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22613

To: tasossahanidis, davidedmundson
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22641: Inject content script also into about:blank

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  A completely dynamically created `` might not have a source but 
default to `about:blank` with its content being added by JavaScript. In this 
case our extension would not be executed in said iframe.

TEST PLAN
  Extension is executed in that kaltura player thing heise uses, see the video 
on [1]
  
  [1] 
https://www.heise.de/newsticker/meldung/Star-Trek-Picard-Neuer-Trailer-mit-alten-Bekannten-4475986.html

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D22641

AFFECTED FILES
  extension/manifest.json

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22613: kstart: Prevent crash when running without args

[Tasos Sahanidis]

tasossahanidis updated this revision to Diff 62282.
tasossahanidis added a comment.


  kstart: Use isEmpty()

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22613?vs=62196&id=62282

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22613

AFFECTED FILES
  kstart/kstart.cpp

To: tasossahanidis, davidedmundson
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f3d914c0fafc: Port FolderView to ContainmentLayoutManager 
plugin (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22035?vs=61988&id=62269#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=61988&id=62269

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  desktoppackage/contents/updates/move_desktop_layout_config.js

To: mart, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22034: Introduce ContainmentLayoutManager QML plugin

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f59aecbcfec6: Introduce ContainmentLayoutManager QML 
plugin (authored by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22034?vs=61987&id=62268

REVISION DETAIL
  https://phabricator.kde.org/D22034

AFFECTED FILES
  components/CMakeLists.txt
  components/containmentlayoutmanager/CMakeLists.txt
  components/containmentlayoutmanager/abstractlayoutmanager.cpp
  components/containmentlayoutmanager/abstractlayoutmanager.h
  components/containmentlayoutmanager/appletcontainer.cpp
  components/containmentlayoutmanager/appletcontainer.h
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  components/containmentlayoutmanager/configoverlay.cpp
  components/containmentlayoutmanager/configoverlay.h
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.cpp
  components/containmentlayoutmanager/containmentlayoutmanagerplugin.h
  components/containmentlayoutmanager/gridlayoutmanager.cpp
  components/containmentlayoutmanager/gridlayoutmanager.h
  components/containmentlayoutmanager/itemcontainer.cpp
  components/containmentlayoutmanager/itemcontainer.h
  components/containmentlayoutmanager/qml/BasicAppletContainer.qml
  components/containmentlayoutmanager/qml/ConfigOverlayWithHandles.qml
  components/containmentlayoutmanager/qml/PlaceHolder.qml
  components/containmentlayoutmanager/qml/private/BasicResizeHandle.qml
  components/containmentlayoutmanager/qml/qmldir
  components/containmentlayoutmanager/resizehandle.cpp
  components/containmentlayoutmanager/resizehandle.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart