D22700: Sync scaling DPI from Plasma to SDDM

2019-07-23 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


   

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sync-scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Bhushan Shah
bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.


  Nice work finding this bug!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22707

To: arojas, bshah, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Antonio Rojas
arojas added a comment.


  Just noticed this is fixed in master already, so this is for 5.16 only

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22707

To: arojas, bshah, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Antonio Rojas
arojas created this revision.
arojas added reviewers: bshah, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Otherwise they may not get assigned any value if the xft exclude range is 
(0,0), which will make them write random values to the xft exclude range later.
  
  BUG: 409518

TEST PLAN
  Open the fonts KCM a few times, check that no random font size interval is 
being excluded from antialiasing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22707

AFFECTED FILES
  kcms/fonts/previewimageprovider.cpp

To: arojas, bshah, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22684: [Klipper] Fix clipboard history management

2019-07-23 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 62444.
pdabrowski retitled this revision from "[Klipper] Fix clipboard history 
clearing" to "[Klipper] Fix clipboard history management".
pdabrowski edited the summary of this revision.
pdabrowski added a comment.
This revision is now accepted and ready to land.


  new diff: proper fix for clipboard history management

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22684?vs=62410=62444

REVISION DETAIL
  https://phabricator.kde.org/D22684

AFFECTED FILES
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/tray.cpp
  klipper/tray.h

To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22691: Remove the share dataengine.

2019-07-23 Thread Aleix Pol Gonzalez
apol added a comment.


  +1 this was used by the pastebin plasmoid which was replaced by QuickShare 
when ported to Plasma 5.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22691

To: aacid
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart


D22702: [fileitemaction] Clean up includes

2019-07-23 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added a reviewer: ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

TEST PLAN
  Builds, actions in Dolphin work

REPOSITORY
  R845 Plasma Vault

BRANCH
  incl

REVISION DETAIL
  https://phabricator.kde.org/D22702

AFFECTED FILES
  fileitemplugin/plasmavaultfileitemaction.cpp

To: nicolasfella, ivan
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22700: Sync scaling DPI from Plasma to SDDM

2019-07-23 Thread Filip Fila
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch adds scaling to the list of Plasma settings that can be synced 
with SDDM.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sync-scaling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22700

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp
  src/ui/advanceconfig.ui

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev abandoned this revision.
rgeorgiev added a comment.


  @broulik Hmm, now I think that I understood the rationale why SoundCloud 
support is activated using the **Enhanced Media Controls** option.  As you 
commented on my other revision (D22632 ), 
SoundCloud uses the Media Session API, support for which is enabled using the 
aforementioned option.  My fault for making uniformed changes :D

REVISION DETAIL
  https://phabricator.kde.org/D22631

To: rgeorgiev
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22632: Implement support for the "next" and "previous" actions in SoundCloud

2019-07-23 Thread Radoslav Georgiev
rgeorgiev added a comment.


  In D22632#499813 , @broulik wrote:
  
  > -1
  >  Site-specific workarounds are not in scope for this extension.
  >  Also, SoundCloud uses Media Session API and provides callbacks on its own.
  
  
  I'm sorry; I was not aware of that requirement.  What it more, it seems that 
the "next" and "previous" buttons work properly when the **Enhanced Media 
Controls** option is enabled, so my changes won't be necessary at all.

REVISION DETAIL
  https://phabricator.kde.org/D22632

To: rgeorgiev
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev planned changes to this revision.
rgeorgiev added a comment.


  In D22631#499815 , @broulik wrote:
  
  > I'm confused - what does this change? There's no context, so I can't tell 
where it's being moved to. Soundcloud works fine here. You might want to enable 
"Enhanced Media Controls" in settings.
  
  
  Well, the reason why I made these changes is that in my understanding, the 
enabling of the **Media Controls** option should ensure the basic functioning 
of media controls for all sites (even if the **Enhanced Media Controls** option 
is disabled, which currently breaks SoundCloud support).  That's why I decided 
to move the logic which detects media player (i.e.  `audio` or `video`) 
elements being added to the page after its loading from the 
`loadMediaSessionsShim` function (which is executed only if the **Enhanced 
Media Controls** option is enabled) to the `loadMpris` function (which is 
executed if the **Media Controls** option is enabled).
  
  To clear any misunderstanding on my side, what's the exact purpose of the 
**Enhanced Media Controls** option?  I thought that the idea behind it is to 
toggle the displaying of the metadata and the thumbnail for the currently 
playing media.

REVISION DETAIL
  https://phabricator.kde.org/D22631

To: rgeorgiev
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22684: [Klipper] Fix clipboard history clearing

2019-07-23 Thread Piotr Dabrowski
pdabrowski added a comment.


  Weak pointer might not work well for this after all.
  I need to have a second look at this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22684

To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


Re: plasma-thunderbolt

2019-07-23 Thread Harald Sitter
IIRC it's been sitting in review for months and weeks ago on IRC we
already agreed that it only needs moving?

Specifically that conversation caused me to fix a daemon lookup issue
for debian distros as I recall.

On Tue, Jul 23, 2019 at 5:17 PM Nate Graham  wrote:
>
> That was the idea. Let's get it through the process ASAP if this has to
> happen first.
>
>
> Nate
>
>
> On 7/23/19 8:26 AM, Jonathan Riddell wrote:
> > Is Plasma Thunderbolt expected to be a new git repo to be released as
> > part of Plasma 5.17?  If so it should go through kdereview pronto.
> >
> > Jonathan
> >
>
>


D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing

2019-07-23 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for the patch!
  
  A more descriptive Description section would be appreciated: you could 
explain what the issue is and how specifically this patch fixes it. In general 
that improves the likelihood of quick review. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22684

To: pdabrowski, #plasma, #plasma_workspaces, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22627: Add a GUI option for choosing the input method

2019-07-23 Thread Nathaniel Graham
ngraham added a comment.


  In D22627#500454 , @filipf wrote:
  
  > Yeah an empty entry is bad UI but it works for the code since it ends up 
just grabbing the text from the combobox and writing it to the config file :P 
... it was a quick solution I'll admit.
  
  
  Instead of just passing the string in the combobox directly to whatever 
writes the value to the file, you'd need to translate the value first.
  
  > The feature request was this, a much more straightforward idea: 
https://forum.kde.org/viewtopic.php?f=285=161536=420073#p420073
  > 
  > But having that checkbox seemed too specific and it seemed like having a 
general input method chooser might be more useful. What do you think?
  
  The generic solution you've implemented here makes sense if the features 
you're exposing actually work in SDDM with all themes (in which case, we need 
to improve the UI here). If not, maybe do the simple checkbox as suggested in 
that forum post.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22627

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


Re: Plasma 2020 release schedules

2019-07-23 Thread Alexander Potashev
вт, 23 июл. 2019 г. в 19:04, Rik Mills :
>
> On 23/07/2019 16:53, Jonathan Riddell wrote:
>
> > https://community.kde.org/Schedules/Plasma_5
>
> Has someone made changes to how table formatting is done there, or on
> the wiki as a whole? That lack of table lines and borked alignment looks
> dreadful.

Hi,

Wikis have been updated: https://carlschwan.eu/2019/07/12/new-userbase.html

-- 
Alexander Potashev


D21829: Improved Touch support for Kickoff

2019-07-23 Thread Steffen Hartleib
steffenh added a comment.


  Hi @hein.
  
  > Before we discuss alternatives: Are you willing to have me try and teach 
you? I'm actually going to be very busy with a move in the next few weeks, so 
this could end up taking quite significant time between the two of us, but if 
you have the time and patience I don't mind helping you through creating the 
patch I had in mind.
  
  If you can help me with that, that would be the great.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

To: steffenh, #plasma, hein, ngraham
Cc: mart, sbergeron, davidedmundson, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D22691: Remove the share dataengine.

2019-07-23 Thread Albert Astals Cid
aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  It seems it's unused and also is the only source code in all of the KDE repos 
that uses kjsembed

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22691

AFFECTED FILES
  CMakeLists.txt
  dataengines/CMakeLists.txt
  dataengines/share/CMakeLists.txt
  dataengines/share/Messages.sh
  dataengines/share/backends/CMakeLists.txt
  dataengines/share/backends/im9/CMakeLists.txt
  dataengines/share/backends/im9/contents/code/main.js
  dataengines/share/backends/im9/metadata.desktop
  dataengines/share/backends/imgsusepasteorg/CMakeLists.txt
  dataengines/share/backends/imgsusepasteorg/contents/code/main.js
  dataengines/share/backends/imgsusepasteorg/metadata.desktop
  dataengines/share/backends/imgur/CMakeLists.txt
  dataengines/share/backends/imgur/contents/code/main.js
  dataengines/share/backends/imgur/metadata.desktop
  dataengines/share/backends/kde/CMakeLists.txt
  dataengines/share/backends/kde/contents/code/main.js
  dataengines/share/backends/kde/metadata.desktop
  dataengines/share/backends/pastebincom/CMakeLists.txt
  dataengines/share/backends/pastebincom/contents/code/main.js
  dataengines/share/backends/pastebincom/metadata.desktop
  dataengines/share/backends/pasteopensuseorg/CMakeLists.txt
  dataengines/share/backends/pasteopensuseorg/contents/code/main.js
  dataengines/share/backends/pasteopensuseorg/metadata.desktop
  dataengines/share/backends/pasteubuntucom/CMakeLists.txt
  dataengines/share/backends/pasteubuntucom/contents/code/main.js
  dataengines/share/backends/pasteubuntucom/metadata.desktop
  dataengines/share/backends/privatepaste/CMakeLists.txt
  dataengines/share/backends/privatepaste/contents/code/main.js
  dataengines/share/backends/privatepaste/metadata.desktop
  dataengines/share/backends/simplestimagehosting/CMakeLists.txt
  dataengines/share/backends/simplestimagehosting/contents/code/main.js
  dataengines/share/backends/simplestimagehosting/metadata.desktop
  dataengines/share/backends/wklej/CMakeLists.txt
  dataengines/share/backends/wklej/contents/code/main.js
  dataengines/share/backends/wklej/metadata.desktop
  dataengines/share/backends/wstaw/CMakeLists.txt
  dataengines/share/backends/wstaw/contents/code/main.js
  dataengines/share/backends/wstaw/metadata.desktop
  dataengines/share/data/plasma_shareprovider.desktop
  dataengines/share/packagestructure/CMakeLists.txt
  dataengines/share/packagestructure/plasma-packagestructure-share.desktop
  dataengines/share/packagestructure/share_package.cpp
  dataengines/share/packagestructure/share_package.h
  dataengines/share/plasma-dataengine-share.desktop
  dataengines/share/share.operations
  dataengines/share/shareengine.cpp
  dataengines/share/shareengine.h
  dataengines/share/shareprovider.cpp
  dataengines/share/shareprovider.h
  dataengines/share/shareservice.cpp
  dataengines/share/shareservice.h

To: aacid
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


Re: Plasma 2020 release schedules

2019-07-23 Thread Rik Mills
On 23/07/2019 16:53, Jonathan Riddell wrote:

> https://community.kde.org/Schedules/Plasma_5

Has someone made changes to how table formatting is done there, or on
the wiki as a whole? That lack of table lines and borked alignment looks
dreadful.

> Distros, please say if you would like any of these to be considered
for LTS.

5.18 as an LTS would be ideal for Kubuntu, and really would be the only
thing that would work for 20.04 LTS.




Plasma 2020 release schedules

2019-07-23 Thread Jonathan Riddell
I've added proposed release schedules for Plasma for 2020.

It sticks to the current formula of three releases a year, repo freeze
before the KF5 release, beta after the KF5 release, .0 3 weeks after that,
then five bugfix releases in 1,1,2,3,5 fibbonchi week periods.

https://community.kde.org/Schedules/Plasma_5

https://phabricator.kde.org/calendar/query/KhNLCxe1xjoI/2020/01/

https://calendar.google.com/calendar?cid=MDMxZ2tncWcxaGpmOGxjbWowZW0xZDJzajhAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ

Let me know if you want any adjustments.

Distros, please say if you would like any of these to be considered for LTS.

Jonathan


Re: plasma-thunderbolt

2019-07-23 Thread Nate Graham
That was the idea. Let's get it through the process ASAP if this has to 
happen first.



Nate


On 7/23/19 8:26 AM, Jonathan Riddell wrote:
Is Plasma Thunderbolt expected to be a new git repo to be released as 
part of Plasma 5.17?  If so it should go through kdereview pronto.


Jonathan






D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

2019-07-23 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 62410.
pdabrowski added a comment.


  new diff: much better patch

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22684?vs=62398=62410

REVISION DETAIL
  https://phabricator.kde.org/D22684

AFFECTED FILES
  klipper/klipper.cpp
  klipper/klipper.h

To: pdabrowski, #plasma, #plasma_workspaces, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22680: Airplane mode improvements

2019-07-23 Thread Nathaniel Graham
ngraham added a comment.


  Nice! This resolves the only issues I had with it.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  airplane-improved

REVISION DETAIL
  https://phabricator.kde.org/D22680

To: jgrulich, #plasma, apol
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


Re: Qt version needed by Plasma 5.17

2019-07-23 Thread Kai Uwe Broulik

Hi,

I would prefer to keep Qt 5.12 supported, but maybe explicitly the 
latest patch release, i.e. 5.12.4 or so. Quickly skimming through the 
changelogs of Qt 5.13 I don't see any groundbreaking new features that I 
would want to use.


The Frameworks Qt requirement policy [1] was also updated recently to 
accomodate distributions better since there are Qt LTS releases now.


Cheers
Kai Uwe

[1] https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements


plasma-thunderbolt

2019-07-23 Thread Jonathan Riddell
Is Plasma Thunderbolt expected to be a new git repo to be released as part
of Plasma 5.17?  If so it should go through kdereview pronto.

Jonathan


D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

2019-07-23 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 62398.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22684?vs=62395=62398

REVISION DETAIL
  https://phabricator.kde.org/D22684

AFFECTED FILES
  klipper/klipper.cpp

To: pdabrowski, #plasma, #plasma_workspaces, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

2019-07-23 Thread Piotr Dabrowski
pdabrowski created this revision.
pdabrowski added reviewers: Plasma, Plasma: Workspaces, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pdabrowski requested review of this revision.

REVISION SUMMARY
  Fixed clipboard history clearing in Klipper:
  https://bugs.kde.org/show_bug.cgi?id=409366

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22684

AFFECTED FILES
  klipper/klipper.cpp

To: pdabrowski, #plasma, #plasma_workspaces, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 71 - Still Failing!

2019-07-23 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/71/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 23 Jul 2019 13:45:22 +
 Build duration:
8 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-23T13:53:02.903Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-23T13:53:02.903Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 42 Stepping 1, GenuineIntel'[2019-07-23T13:53:02.903Z] PROCESSOR_LEVEL   = '6'[2019-07-23T13:53:02.903Z] PROCESSOR_REVISION= '2a01'[2019-07-23T13:53:02.903Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-23T13:53:02.903Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-23T13:53:02.903Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-23T13:53:02.903Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-23T13:53:02.903Z] PROMPT= '$P$G'[2019-07-23T13:53:02.903Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-23T13:53:02.903Z] PUBLIC= 'C:\Users\Public'[2019-07-23T13:53:02.903Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/71/display/redirect?page=changes'[2019-07-23T13:53:02.903Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/71/display/redirect'[2019-07-23T13:53:02.903Z] STAGE_NAME= 'Configuring Build'[2019-07-23T13:53:02.903Z] SYSTEMDRIVE   = 'C:'[2019-07-23T13:53:02.903Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-23T13:53:02.903Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-23T13:53:02.903Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-23T13:53:02.903Z] UCRTVERSION   = '10.0.17763.0'[2019-07-23T13:53:02.903Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-23T13:53:02.903Z] USERDOMAIN= 'DESKTOP-V7LQR8M'[2019-07-23T13:53:02.903Z] USERNAME  = 'Jenkins'[2019-07-23T13:53:02.903Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-23T13:53:02.903Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-23T13:53:02.903Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-23T13:53:02.903Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-23T13:53:02.903Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-23T13:53:02.903Z] VCTOOLSVERSION= '14.16.27023'[2019-07-23T13:53:02.903Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-23T13:53:02.903Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-23T13:53:02.904Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-23T13:53:02.904Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-23T13:53:02.904Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-23T13:53:02.904Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-23T13:53:02.904Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-23T13:53:02.904Z] VSCMD_VER = '16.0.3'[2019-07-23T13:53:02.904Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-23T13:53:02.904Z] WINDIR= 'C:\WINDOWS'[2019-07-23T13:53:02.904Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-23T13:53:02.904Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-23T13:53:02.904Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-23T13:53:02.904Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-23T13:53:02.904Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-23T13:53:02.904Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-23T13:53:02.904Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-23T13:53:02.904Z] __DOTNET_ADD_64BIT= '1'[2019-07-23T13:53:02.904Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-23T13:53:02.904Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-23T13:53:02.904Z] 

D22553: guard against plasmashell being properly dead and not showing the SNI

2019-07-23 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:3eeb0ce5bc1e: guard against plasmashell being properly 
dead and not showing the SNI (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22553?vs=62045=62393#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22553?vs=62045=62393

REVISION DETAIL
  https://phabricator.kde.org/D22553

AFFECTED FILES
  src/statusnotifier.cpp

To: sitter, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


Qt version needed by Plasma 5.17

2019-07-23 Thread Jonathan Riddell
Qt 5.13 was released on June 19th
https://blog.qt.io/blog/2019/06/19/qt-5-13-released/

Plasma 5.17 is scheduled for 10th October
https://community.kde.org/Schedules/Plasma_5

We have yet to decide which version of Qt we will say Plasma 5.17 works
with.  If nobody has a reason to need Qt 5.13 I will set it to say it works
with both Qt 5.12 and 5.13.

Jonathan


D22680: Airplane mode improvements

2019-07-23 Thread Jan Grulich
jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  - make the airplane mode to persist reboot/suspend or plasma restart
  - make the airplane mode to disable/enable BT devices
  - make the airplane mode hidden when there is no Wireless or Wwan device

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  airplane-improved

REVISION DETAIL
  https://phabricator.kde.org/D22680

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/connectionicon.cpp
  libs/declarative/connectionicon.h
  libs/handler.cpp

To: jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart