D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-04 Thread Kai Uwe Broulik 
broulik added a comment.


  This doesn't apply the colors on startup, does it?
  Probably needs the new flag passed in `kcminit_style`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: [System Tray]

2019-08-04 Thread David Edmundson 
On Thu, Aug 1, 2019 at 10:30 AM Konrad Materka  wrote:
>
> Hi,
>
> recently I was fixing two bugs related to SystemTray (in review:
> https://phabricator.kde.org/D22804,
> https://phabricator.kde.org/D22767). I noticed that code is highly
> coupled and "fragile" with some unclear references like:
> item.parent.parent.attrbute etc. Items are imperatively assigned to
> different parents depending on the status.

Firstly, thanks ever so much for looking into the xembedsniproxy code!
It's good to have someone active on it.

(note that I have a super minor review comment on one, then let's ship it
ASAP)

>
> I would like to add one meta-model with all items (both
> SystemNotifications and plasmoids) plus Delegate Model(s) with groups:
> * active
> * passive/hidden
> * disabled etc
> and additional sorting:
> * notification always as first
> * other rules possible

Seems sane.

If you use actual models, see KExtraRowsProxyModel for merging.

>
> That model will allow:
> * better separation between data and view, it is additional abstract
> layer between backend data (SystemNotifications model + plasmoids
> list) and current view.
> * ability to filter/sort/group easily - no need for
> plasmoid.nativeInterface.reorderItemAfter
> * clear information about the model used in active/hidden containers
> * easier implementation of new features like ordering, even with drag
> and drop  (https://bugs.kde.org/show_bug.cgi?id=384782)
> * decoupled code (with further refactoring, preferably not in one step)
> no direct parent assignment.
>
> The biggest disadvantage (?) I see is that it adds some complexity,
> change is big and will require quite long review process.
> I predict it will take around 4 weeks + 4 weeks (or more) for
reviews/fixes.
>
> What do you think? Should I start work or someone else is working on
SystemTray?

Go for it. You might find it useful to review Marco's new containment
management plugin for the desktop. It has a controls like approach for
creating loaders.

There should be some crossover which might be relevant.

> --
> Regards,
> Konrad Materka

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 160 - Fixed!

2019-08-04 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/160/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 05 Aug 2019 02:57:44 +
 Build duration:
32 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)37%
(46/124)37%
(46/124)35%
(4615/13206)26%
(2504/9662)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(872/917)52%
(438/848)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(780/2302)27%
(394/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1488/3481)33%
(943/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)47%
(746/1574)35%
(372/1048)src.plasma.scripting67%
(2/3)67%
(2/3)27%
(48/176)20%
(23/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(588/2025)19%
(324/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1185)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 159 - Failure!

2019-08-04 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/159/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 05 Aug 2019 02:45:33 +
 Build duration:
5 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 3106 lines...][2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/calendar/MonthView.qml[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/calendar/CalendarToolbar.qml[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/calendar/MonthMenu.qml[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/calendar/qmldir[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/calendar/DayDelegate.qml[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/calendar/DaysCalendar.qml[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/qml/org/kde/plasma/calendar/plugins.qmltypes[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/bin/plasmapkg2[2019-08-05T02:51:08.337Z] -- Set runtime path of "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert//home/jenkins/install-prefix/bin/plasmapkg2" to "/home/jenkins/install-prefix/lib64"[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/plugins/plasma/scriptengines/plasma_appletscript_declarative.so[2019-08-05T02:51:08.337Z] -- Set runtime path of "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert//home/jenkins/install-prefix/lib64/plugins/plasma/scriptengines/plasma_appletscript_declarative.so" to "/home/jenkins/install-prefix/lib64"[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/kservices5/plasma-scriptengine-applet-declarative.desktop[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/share/kservicetypes5/plasma-wallpaper.desktop[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/libKF5PlasmaQuick.so.5.61.0[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/libKF5PlasmaQuick.so.5[2019-08-05T02:51:08.337Z] -- Set runtime path of "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert//home/jenkins/install-prefix/lib64/libKF5PlasmaQuick.so.5.61.0" to "/home/jenkins/install-prefix/lib64"[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/lib64/libKF5PlasmaQuick.so[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/include/KF5/plasmaquick/plasmaquick_export.h[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/include/KF5/plasmaquick/packageurlinterceptor.h[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/include/KF5/plasmaquick/appletquickitem.h[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/include/KF5/plasmaquick/containmentview.h[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/include/KF5/plasmaquick/configview.h[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/install-divert/home/jenkins/install-prefix/include/KF5/plasmaquick/configmodel.h[2019-08-05T02:51:08.337Z] -- Installing: /home/jenkins/w

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-04 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks very much. This is excellent work, and I'm impressed. The feature 
works perfectly and the code structure and implementation makes sense to me. I 
think people are really going to love this in Plasma 5.17.
  
  #Plasma  people, what say ye?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma, ngraham
Cc: ngraham, davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22934: [KCM] Improve text for "lock after wake" feature

2019-08-04 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:9cca999319b3: [KCM] Improve text for "lock after 
wake" feature (authored by ngraham).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22934?vs=63086&id=63087

REVISION DETAIL
  https://phabricator.kde.org/D22934

AFFECTED FILES
  kcm/kcm.ui

To: ngraham, #vdg, GB_2
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Nathaniel Graham 
ngraham added a comment.


  Noticed one more change I'd like to make while screenshotting it for next 
week's blog post. See D22934 .

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22911

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22934: [KCM] Improve text for "lock after wake" feature

2019-08-04 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The word "resume" is a technical term that's only clear when suspending is 
mentioned
  in conjunction with it. But we don't use the term "suspend" anymore; we say 
"sleep."
  So its inverse is "wake from sleep".
  
  This patch improves the text according to the above reasoning.

TEST PLAN
  F7160676: new string.png 

REPOSITORY
  R133 KScreenLocker

BRANCH
  improve-lock-on-wake-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22934

AFFECTED FILES
  kcm/kcm.ui

To: ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:bf5040930785: Improve the look of the Lock Screen KCM UI 
(authored by GB_2).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22911?vs=63079&id=63083

REVISION DETAIL
  https://phabricator.kde.org/D22911

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.ui
  kcm/screenlocker.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22908: avoid qml warnings when controlRoot is not set

2019-08-04 Thread Nathaniel Graham 
ngraham added subscribers: mart, ngraham.
ngraham accepted this revision.
ngraham added reviewers: mart, Plasma.
ngraham added a comment.
This revision is now accepted and ready to land.


  @mart, does this look correct to you?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22908

To: dakon, ngraham, mart, #plasma
Cc: ngraham, mart, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-04 Thread Nathaniel Graham 
ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> GB_2 wrote in kcm_desktoptheme.desktop:41
> You forgot to change the name here too.

Oops, sorry! Fixed in 2bedabd96d37c48a67a80dcc48f3368b1e9713ef 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22880

To: ngraham, #vdg, #plasma, GB_2
Cc: leinir, GB_2, plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, 
fbampaloukas, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM! Nice work.

REPOSITORY
  R133 KScreenLocker

BRANCH
  improved-lock-screen-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22911

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Björn Feber 
GB_2 updated this revision to Diff 63079.
GB_2 added a comment.


  Correct ki18ncp comment

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22911?vs=63078&id=63079

BRANCH
  improved-lock-screen-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22911

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.ui
  kcm/screenlocker.desktop

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Björn Feber 
GB_2 updated this revision to Diff 63078.
GB_2 added a comment.


  Address comments

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22911?vs=63030&id=63078

BRANCH
  improved-lock-screen-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22911

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.ui
  kcm/screenlocker.desktop

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

2019-08-04 Thread Nathaniel Graham 
ngraham added a comment.


  File a bug on KInfoCenter :)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22742

To: ngraham, #vdg, #plasma, filipf, GB_2
Cc: KonqiDragon, mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> GB_2 wrote in kcm.ui:49
> Ok, I just followed the style from D21610 
> , if it's wrong then it needs to be 
> corrected ther too.

That was kind of an exception for just that item because it's written as a 
multi-part sentence. You can see in the checkbox below it that it used the 
normal capitalization style.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22911

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Björn Feber 
GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in kcm.ui:49
> Capitalize Automatically

Ok, I just followed the style from D21610 , 
if it's wrong then it needs to be corrected ther too.

> ngraham wrote in kcm.ui:78
> While we're at it, I might rephrase this to say, "Allow unlocking without a 
> password during the first"

Ok

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22911

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

2019-08-04 Thread KonqiDragon 
KonqiDragon added a comment.


  Can add a GPU information in **Hardware**?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22742

To: ngraham, #vdg, #plasma, filipf, GB_2
Cc: KonqiDragon, mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Nathaniel Graham 
ngraham added a comment.


  A good future improvement would be to change "mins" and "secs" in the 
spinboxes to "minutes" and "seconds".

INLINE COMMENTS

> kcm.ui:49
> 
> -Lock screen automatically after:
> +automatically after:
> 

Capitalize Automatically

> kcm.ui:71
> + 
> +  on resume
> + 

Capitalize On

> kcm.ui:78
> + 
> +  Re&quire password after locking:
> + 

While we're at it, I might rephrase this to say, "Allow unlocking without a 
password during the first"

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22911

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22929: Bring back and install System Administration category

2019-08-04 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:fa5ca1189c95: Bring back and install System 
Administration category (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22929?vs=63071&id=63075#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22929?vs=63071&id=63075

REVISION DETAIL
  https://phabricator.kde.org/D22929

AFFECTED FILES
  categories/CMakeLists.txt
  categories/old/settings-system-administration.desktop
  categories/settings-system-administration.desktop

To: ngraham, #vdg, GB_2
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22929: Bring back and install System Administration category

2019-08-04 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  D22742  added the info KCM to the System 
Administration category, but that
  category isn't actually shipped with System Settings. It only appears if you 
have
  the systemd-kcm instatted, because it ships its own local version of that 
file (boo).
  
  This patch makes System Settings ship the category itself. It will be removed 
from
  systemd-kcm in .

TEST PLAN
  F7159603: Now visible.png 

REPOSITORY
  R124 System Settings

BRANCH
  bring-back-system-administration-category (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22929

AFFECTED FILES
  categories/CMakeLists.txt
  categories/old/settings-system-administration.desktop
  categories/settings-system-administration.desktop

To: ngraham, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

2019-08-04 Thread Vlad Zagorodniy 
zzag added a comment.


  I'll land this patch in 24h if there are no objections from #plasma 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22923

To: zzag, #plasma, #vdg, GB_2, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22924: [Night Color KCM] Don't show advanced controls for constant mode

2019-08-04 Thread Vlad Zagorodniy 
zzag added a comment.


  I'll land this patch in 24h if there are no objections from #plasma 
.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  rename-manual-to-constant

REVISION DETAIL
  https://phabricator.kde.org/D22924

To: zzag, #plasma, #vdg, GB_2, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22925: Fix POTD doesn't update

2019-08-04 Thread Yunhe Guo 
guoyunhe added a comment.


  In D22925#506462 , @ngraham wrote:
  
  > Have you tested to make sure this doesn't break other providers?
  
  
  I need several days to test because it only change once a day... (changing 
local time won't work)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-04 Thread Nathaniel Graham 
ngraham added a comment.


  Have you tested to make sure this doesn't break other providers?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

2019-08-04 Thread Luca Carlon 
luc4 added a comment.


  Hello, I'm not a Plasma expert, but I tried to investigate the situation a 
bit in Qt and plasma-framework. My understanding is that the notes applet is 
using TextArea from QtQuick.Controls 1. TextArea 1 creates an edit menu inside 
Qt, probably the one defined in EditMenu_base.qml 
.
 I see it is probably possible to replace this. Not sure if this can be 
modified, it is not public.
  
  I could not find a default edit menu in QtQuick.Controls 2. I see that 
plasma-framework also includes a template for TextArea from QtQuick.Controls 2. 
It may be possible to define a edit menu in the template, making it disabled by 
default. This would have the benefit of showing a menu with a more consistent 
look.
  
  Can someone confirm this? What about upgrading the TextArea element in notes 
to QtQuick.Controls 2 and adding the menu in the template in plasma-frameworks? 
Or is there a edit menu available already somewhere? If someone could provide a 
hint I may be able to go on with this. Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

2019-08-04 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Previous patch for Unsplash Wallpapers changed the identifier format. So we 
can not simply detect whether an identifier contains date by looking for `:`. 
This patch detect date string with regular expression.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22925

AFFECTED FILES
  dataengines/potd/potd.cpp

To: guoyunhe
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22924: [Night Color KCM] Don't show advanced controls for constant mode

2019-08-04 Thread Vlad Zagorodniy 
zzag created this revision.
zzag added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The user can only change the color temperature when the constant mode is
  selected. Therefore, it doesn't make sense to display all irrelevant input
  controls (e.g. latitude and longitude inputs, etc).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  rename-manual-to-constant

REVISION DETAIL
  https://phabricator.kde.org/D22924

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: zzag, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

2019-08-04 Thread Vlad Zagorodniy 
zzag created this revision.
zzag added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Both the Night Color (KDE Plasma) and the Night Light (GNOME Shell) have
  so called "Manual" mode. In each case, this mode denotes something
  different.
  
  If the Night Color operates in the Manual mode, then the color temperature
  remains constant throughout the day. On other hand, the Manual mode in the
  Night Light is similar to the Timings mode in the Night Color.
  
  This change renames the Manual mode in order to alleviate the mismatch in
  terminology.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22923

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: zzag, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart