D23018: [notifications] Remove unread counter, use icons instead

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Text inside a small circle has a lot of problems with fitting in there
  and being properly aligned.
  
  Also use notification-disabled for DND from notification.svg. It's
  probably best to not to make the widget partially use the icon theme and
  the desktop theme.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23018

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: ndavis, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22960: Add handle icons

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:29dffaf4cd72: Add handle icons (authored by hein).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22960?vs=63155=63327

REVISION DETAIL
  https://phabricator.kde.org/D22960

AFFECTED FILES
  KF5Kirigami2Macros.cmake

To: hein, #frameworks, apol, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 72 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/72/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 08 Aug 2019 03:05:26 +
 Build duration:
3 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 216 lines...][2019-08-08T03:07:51.862Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-08-08T03:07:51.862Z] PROCESSOR_LEVEL   = '6'[2019-08-08T03:07:51.862Z] PROCESSOR_REVISION= '5e03'[2019-08-08T03:07:51.862Z] PROGRAMDATA   = 'C:\ProgramData'[2019-08-08T03:07:51.862Z] PROGRAMFILES  = 'C:\Program Files'[2019-08-08T03:07:51.862Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-08-08T03:07:51.862Z] PROGRAMW6432  = 'C:\Program Files'[2019-08-08T03:07:51.862Z] PROMPT= '$P$G'[2019-08-08T03:07:51.862Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-08-08T03:07:51.862Z] PUBLIC= 'C:\Users\Public'[2019-08-08T03:07:51.862Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/72/display/redirect?page=changes'[2019-08-08T03:07:51.862Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/72/display/redirect'[2019-08-08T03:07:51.862Z] STAGE_NAME= 'Configuring Build'[2019-08-08T03:07:51.862Z] SYSTEMDRIVE   = 'C:'[2019-08-08T03:07:51.862Z] SYSTEMROOT= 'C:\WINDOWS'[2019-08-08T03:07:51.862Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-08-08T03:07:51.862Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-08-08T03:07:51.862Z] UCRTVERSION   = '10.0.17763.0'[2019-08-08T03:07:51.862Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-08-08T03:07:51.862Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-08-08T03:07:51.862Z] USERNAME  = 'Jenkins'[2019-08-08T03:07:51.862Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-08-08T03:07:51.862Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-08-08T03:07:51.862Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-08-08T03:07:51.862Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-08-08T03:07:51.862Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-08-08T03:07:51.862Z] VCTOOLSVERSION= '14.16.27023'[2019-08-08T03:07:51.862Z] VISUALSTUDIOVERSION   = '16.0'[2019-08-08T03:07:51.862Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-08-08T03:07:51.862Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-08-08T03:07:51.862Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-08-08T03:07:51.862Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-08-08T03:07:51.862Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-08-08T03:07:51.863Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-08-08T03:07:51.863Z] VSCMD_VER = '16.0.3'[2019-08-08T03:07:51.863Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-08-08T03:07:51.863Z] WINDIR= 'C:\WINDOWS'[2019-08-08T03:07:51.863Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-08-08T03:07:51.863Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-08-08T03:07:51.863Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-08-08T03:07:51.863Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-08-08T03:07:51.863Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-08-08T03:07:51.863Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-08-08T03:07:51.863Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-08-08T03:07:51.863Z] __DOTNET_ADD_64BIT= '1'[2019-08-08T03:07:51.863Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-08-08T03:07:51.863Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-08-08T03:07:51.863Z] CMAKE_PREFIX_PATH = 'C:\CI\Software 

D22866: [Kickoff] Always select previous category in Applications View when navigating backwards

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Good idea!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-appview-remember-previous-category (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22866

To: akozlovskiy, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

[Eike Hein]

hein added a comment.


  ... I'm not the author or maintainer of this code, but I had a look anyway :).
  
  @lisin, I agree with you that the sizing bug should be fixed in TabBar 
instead, in plasma-frameworks.git. It's very unorthodox to call a property 
change handler as a function, and it's not going to fix this for other 
potential users of the component.
  
  Otherwise the patch looks good. Could you resubmit it without line 435, and 
then submit a seperate patch to plasma-frameworks?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22988

To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Nathaniel Graham]

ngraham resigned from this revision.
ngraham added a comment.


  Okay, sure.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, 
broulik, filipf, plasma-devel, LeGast00n, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  In D22468#508314 , @ngraham wrote:
  
  > In D22468#508290 , @romangg 
wrote:
  >
  > > I currently concentrate on libkscreen backend work and output duplication 
and have based other patches on this rewrite here. So I only want to touch this 
diff again in case of critical issues but not add more detail work on top of 
what's already there. Instead after merge of the rewrite please create a task 
with your list of ideas so we can go with multiple small patches afterwards. 
Also some of these points should be discussed some more and a task is better 
suited for that.
  >
  >
  > I can do that, but in principle I think when a patch involves a UI rewrite, 
it's fair game to offer UI suggestions. If you don't want to change the new UI 
you've written in this patch, it might be better to break this patch up into a 
backend component that you can use as a base for other patches, and a front-end 
leaf node patch where we can do the UI review independently of the other 
dependent backend work.
  
  
  Problem is that you can't really break this patch up since the front- and 
back-end changes are dependent on each other. But it's definitely fine to 
further refine the Ui afterwards. I see the Ui more as a first revision than 
the end goal. And because of that I want to break up continuous work into 
smaller chunks as soon as possible after a large rewrite involving both front- 
and back-end. This gives other front-end contributors a chance to put in their 
own ideas and me concentrate on the back-end again.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg, ngraham
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, 
broulik, filipf, plasma-devel, LeGast00n, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Nathaniel Graham]

ngraham added a comment.


  In D22468#508290 , @romangg wrote:
  
  > I currently concentrate on libkscreen backend work and output duplication 
and have based other patches on this rewrite here. So I only want to touch this 
diff again in case of critical issues but not add more detail work on top of 
what's already there. Instead after merge of the rewrite please create a task 
with your list of ideas so we can go with multiple small patches afterwards. 
Also some of these points should be discussed some more and a task is better 
suited for that.
  
  
  I can do that, but in principle I think when a patch involves a UI rewrite, 
it's fair game to offer UI suggestions. If you don't want to change the new UI 
you've written in this patch, it might be better to break this patch up into a 
backend component that you can use as a base for other patches, and a front-end 
leaf node patch where we can do the UI review independently of the other 
dependent backend work.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg, ngraham
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, 
broulik, filipf, plasma-devel, alexandermilos, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22925: Fix POTD doesn't update

[Yunhe Guo]

guoyunhe updated this revision to Diff 63301.
guoyunhe added a comment.


  Add import

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22925?vs=63300=63301

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22925

AFFECTED FILES
  dataengines/potd/cachedprovider.cpp
  dataengines/potd/potd.cpp

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22925: Fix POTD doesn't update

[Yunhe Guo]

guoyunhe updated this revision to Diff 63300.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Fix CacheProvider's cache validation function

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22925?vs=63061=63300

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22925

AFFECTED FILES
  dataengines/potd/cachedprovider.cpp
  dataengines/potd/potd.cpp

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

[Roman Gilg]

romangg added a comment.


  In D22468#507819 , @ngraham wrote:
  
  > Thanks Roman! This is really excellent overall. A big improvement over the 
current one . Nevertheless I think we can make it even better and I have some 
UI review comments:
  >
  > 1. The "Output Settings" section header should contain the name of the 
output ("Settings for ") and then you can remove the output name that's 
in the FormLayout.
  > 2. The visualization at the top of the KCM with the white background needs 
a visible frame around it. Just give the `Rectangle` in `Screen.qml` an 
appropriate border color and radius.
  > 3. The padding between the refresh rate combo box and the horizontal spacer 
is way too high (and it's not consistent in the amount of spacing above and 
below the spacer)
  > 4. Need to add labels below the slider and also a label to the right that 
shows its current value like this: ``` Global Scale:  |--o| 
1.6x 1x 1.5x2x ```
  > 5. You could save some vertical space in the visualization by putting the 
Identify button within each output in the visualization and putting the Center 
View button in the corner and making it only appear on hover (on the desktop at 
least)
  > 6. For that matter, you can hide the visualization  entirely when there's 
only a single output. That will make the display much simpler and easier to 
parse for the common case of one screen.
  
  
  I currently concentrate on libkscreen backend work and output duplication and 
have based other patches on this rewrite here. So I only want to touch this 
diff again in case of critical issues but not add more detail work on top of 
what's already there. Instead after merge of the rewrite please create a task 
with your list of ideas so we can go with multiple small patches afterwards. 
Also some of these points should be discussed some more and a task is better 
suited for that.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin, #vdg, ngraham
Cc: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, 
broulik, filipf, plasma-devel, alexandermilos, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D22992: [KRDB] Fix wrong names in GTK colordef exports

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:87d9610e206f: [KRDB] Fix wrong names in GTK colordef 
exports (authored by cblack, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22992?vs=63277=63299

REVISION DETAIL
  https://phabricator.kde.org/D22992

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Only current user known is plasma-desktop, from 
R119:737b114c2fa5bf0b01951eeb2eef22ce7fcdcfa1 
 No 
other hits seen on internet
  
  No idea what is the most simple approach here, given KF releases are 
branchless, and Plasma has branches, and there are rolling distributions and 
non-rolling distributions, thus combining old KF and new Plasma, as well as new 
KF and new Plasma.
  
  Perhaps install backward-compat version, and drop once Plasma 5.16 is no 
longer released due to Plasma 5.17 ?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D23005

To: kossebau, mart, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: mart, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  fixcmakeconfigname

REVISION DETAIL
  https://phabricator.kde.org/D23005

AFFECTED FILES
  CMakeLists.txt
  KF5QQC2DeskopStyleConfig.cmake.in
  KF5QQC2DesktopStyleConfig.cmake.in

To: kossebau, mart, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks very much for the patch! This fixes both issues for me and looks 
conceptually like an appropriate fix to me, but I'm not the original author or 
maintainer of this code as @hein is, so let's wait for his review.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22988

To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23004: Wayland: manage outputs without id mapping

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Instead of having a separate mapping from KWayland ids to KScreen ids for
  output removal connect to the removed signal.
  
  For that create the output device through the Registry instead of binding.

TEST PLAN
  Manually plugged in and removed output in Wayland session.

REPOSITORY
  R110 KScreen Library

BRANCH
  waylandOutputRemoval

REVISION DETAIL
  https://phabricator.kde.org/D23004

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22992: [KRDB] Fix wrong names in GTK colordef exports

[Nathaniel Graham]

ngraham added a comment.


  Could you attach before-and-after pictures showing what was broken and how 
it's fixed now? That's very helpful with this kind of patch where you may be 
more of a subject matter expert than your reviewers. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22992

To: cblack, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22992: [KRDB] Fix wrong names in GTK colordef exports

[Carson Black]

cblack updated this revision to Diff 63277.
cblack added a comment.


  Fix foreground color names

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22992?vs=63276=63277

BRANCH
  fix-colordef-names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22992

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 144 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/144/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 07 Aug 2019 12:19:17 +
 Build duration:
2 hr 15 min and counting
   CONSOLE OUTPUT
  [...truncated 2381 lines...][2019-08-07T14:34:55.236Z]   |^~~~[2019-08-07T14:34:55.236Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:256:108: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-08-07T14:34:55.236Z]   256 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::SuspendState, nullptr, nullptr);[2019-08-07T14:34:55.236Z]   |^[2019-08-07T14:34:55.236Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T14:34:55.236Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-08-07T14:34:55.236Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: declared here[2019-08-07T14:34:55.236Z]83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-08-07T14:34:55.236Z]   |^~~~[2019-08-07T14:34:55.236Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:256:108: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-08-07T14:34:55.236Z]   256 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::SuspendState, nullptr, nullptr);[2019-08-07T14:34:55.236Z]   |^[2019-08-07T14:34:55.236Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T14:34:55.236Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-08-07T14:34:55.236Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: declared here[2019-08-07T14:34:55.236Z]83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-08-07T14:34:55.236Z]   |^~~~[2019-08-07T14:34:55.236Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:259:41: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-08-07T14:34:55.236Z]   259 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);[2019-08-07T14:34:55.236Z]   | ^~~~[2019-08-07T14:34:55.236Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T14:34:55.236Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-08-07T14:34:55.236Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: note: declared here[2019-08-07T14:34:55.236Z]83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void requestSleep(SleepState state, QObject *receiver, const char *member);[2019-08-07T14:34:55.236Z]   |^~~~[2019-08-07T14:34:55.236Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:259:110: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-08-07T14:34:55.236Z]   259 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, nullptr, nullptr);[2019-08-07T14:34:55.236Z]   |  ^[2019-08-07T14:34:55.236Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T14:34:55.236Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 

D22992: [KRDB] Fix wrong names in GTK colordef exports

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The background color states of the button color variants were exporting to 
the wrong name.

TEST PLAN
  Ensure that the button variant colors export properly now (backdrop 
[unfocused window], insensitive [disabled])

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-colordef-names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22992

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  good direction, unfortunately we can't remove the custom toolbutton 
contentitem yet, so for now let's keep the custom icon group

INLINE COMMENTS

> camiloh wrote in Action.qml:76
> from Kirigami actionIconGroup:
> string name
> string source
> int width
> int height
> color color
> 
> from QQC2 icon property:
> icon.name
> icon.source
> icon.width
> icon.height
> icon.color

ok, please remove all code that you commented out

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22974

To: camiloh, #kirigami, mart
Cc: astippich, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 143 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/143/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 07 Aug 2019 09:44:23 +
 Build duration:
2 hr 34 min and counting
   CONSOLE OUTPUT
  [...truncated 2247 lines...][2019-08-07T12:19:05.440Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T12:19:05.440Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-08-07T12:19:05.440Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: declared here[2019-08-07T12:19:05.440Z]74 | KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();[2019-08-07T12:19:05.440Z]   |^~~~[2019-08-07T12:19:05.440Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:185:106: warning: ���QSet Solid::PowerManagement::supportedSleepStates()��� is deprecated [-Wdeprecated-declarations][2019-08-07T12:19:05.440Z]   185 | QSet< Solid::PowerManagement::SleepState > states = Solid::PowerManagement::supportedSleepStates();[2019-08-07T12:19:05.440Z]   |  ^[2019-08-07T12:19:05.440Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T12:19:05.440Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-08-07T12:19:05.440Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: declared here[2019-08-07T12:19:05.440Z]74 | KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();[2019-08-07T12:19:05.440Z]   |^~~~[2019-08-07T12:19:05.440Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:185:106: warning: ���QSet Solid::PowerManagement::supportedSleepStates()��� is deprecated [-Wdeprecated-declarations][2019-08-07T12:19:05.440Z]   185 | QSet< Solid::PowerManagement::SleepState > states = Solid::PowerManagement::supportedSleepStates();[2019-08-07T12:19:05.440Z]   |  ^[2019-08-07T12:19:05.440Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T12:19:05.440Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:34:[2019-08-07T12:19:05.440Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:74:52: note: declared here[2019-08-07T12:19:05.440Z]74 | KDELIBS4SUPPORT_DEPRECATED_EXPORT QSet supportedSleepStates();[2019-08-07T12:19:05.440Z]   |^~~~[2019-08-07T12:19:05.440Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp: In member function ���void PowerDevilRunner::addSuspendMatch(int, QList&)���:[2019-08-07T12:19:05.440Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:212:12: warning: enumeration value ���HybridSuspendState��� not handled in switch [-Wswitch][2019-08-07T12:19:05.440Z]   212 | switch ((Solid::PowerManagement::SleepState)value) {[2019-08-07T12:19:05.440Z]   |^[2019-08-07T12:19:05.440Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp: In member function ���virtual void PowerDevilRunner::run(const Plasma::RunnerContext&, const Plasma::QueryMatch&)���:[2019-08-07T12:19:05.440Z] /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 SUSEQt5.12/runners/powerdevil/PowerDevilRunner.cpp:256:41: warning: ���void Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, QObject*, const char*)��� is deprecated [-Wdeprecated-declarations][2019-08-07T12:19:05.440Z]   256 | Solid::PowerManagement::requestSleep(Solid::PowerManagement::SuspendState, nullptr, nullptr);[2019-08-07T12:19:05.440Z]   | ^~~~[2019-08-07T12:19:05.440Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,[2019-08-07T12:19:05.440Z]  from /home/jenkins/workspace/Plasma/plasma-workspace/stable-kf5-qt5 

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

[Konstantin Lisin]

lisin added a comment.


  I also couldn't reproduce the gray overlay (which is caused by 
`tabBarSeparator` having a wrong size and taking the whole view - yesterday I 
could reproduce it but no more) that is shown in the comment 16 here: 
https://bugs.kde.org/show_bug.cgi?id=395390#c16 
  So it may still be present. Currently, I can't see any separator but it's a 
different issue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22988

To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22925: Fix POTD doesn't update

[Yunhe Guo]

guoyunhe added a comment.


  This is not working. Unsplash wallpapers still don't update daily. I need 
further debugging.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22925

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

[Konstantin Lisin]

lisin created this revision.
lisin added reviewers: Plasma, hein, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lisin requested review of this revision.

REVISION SUMMARY
  This fixes the incorrect initial positioning of the tab bar (first tab is 
placed out of bounds) when Kickoff is in a vertical panel that persists until 
the user selects another tab manually.
  BUG: 395390
  
  And the broken layout of the tab bar (tab bar takes the whole view) when a 
panel is changed from horizontal to vertical that persists until plasmashell is 
restarted.
  BUG: 393888

TEST PLAN
  BUG: 395390
  Place Kickoff in a vertical panel. Restart plasmashell and open Kickoff.
  Before fix: first tab is positioned out of bounds (y<0).
  After fix: first tab is positioned correctly (y=0).
  
  BUG: 393888
  Change panel orientation from horizontal to vertical. Open Kickoff.
  Before fix: tab bar fills the whole view making the Kickoff unusable even if 
you make the panel horizontal again.
  After fix: tab bar has the correct size.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22988

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

[Konstantin Lisin]

lisin added a comment.


  Line `onHeightChanged: onWidthChanged()` fixes BUG: 395390
  I'm not sure if this is the best solution. For some reason, 
`plasmacomponents/qml/TabBar.qml` lacks an `onHeightChanged()` function but it 
has `onWidthChanged()` that seems to do what needs to happen here. Maybe 
`TabBar.qml` should be changed instead.
  
  The rest of the changes is for BUG: 393888
  It seems to me that the removed code was a more clean way to do this, but it 
didn't update the values without restarting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22988

To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Issues with Jenkins Builds

[Ben Cooksley]

Hi all,

Recently we were affected by a regression within Jenkins, the effect
of which meant that in some circumstances builds would not be
triggered when new commits were introduced.

In addition, the views showing the list of all builds would also not
show the last successfully completed build in some circumstances.

This fault has now been worked around on build.kde.org, and rebuilds
have been initiated of a number of jobs which have been identified as
either affected or potentially affected, which unfortunately will take
the better part of the next day or so for the system to process.

For all those projects not being rebuilt, maintainers are asked to
please check their builds to ensure that the latest build reflects the
current state of their repository. Particular attention should be paid
to stable builds, which are the most likely to be affected by the
above issues.

Should your project(s) builds be affected by this issue (with the
latest build being an old one) then the issue will be corrected by
performing a rebuild manually, after which it should behave properly.

Please respond to this email with the names of the affected projects
and we'll arrange for this if you don't have access to do this
yourself.

Apologies for the inconvenience caused.

Regards,
Ben Cooksley
KDE Sysadmin

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8eec2cfd36c4: [MPRIS Data Engine] Ignore non-standards 
compliant players (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22596?vs=62151=63258

REVISION DETAIL
  https://phabricator.kde.org/D22596

AFFECTED FILES
  dataengines/mpris2/mpris2engine.cpp

To: broulik, #plasma, fvogt
Cc: fvogt, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Code looks good, if you tested successfully with vlc this can IMO go in

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22596

To: broulik, #plasma, fvogt
Cc: fvogt, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22814: Remove colon (:) prefix when looking up dictionary word

[Wolfgang Bauer]

wbauer added a comment.


  Thank you!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22814

To: broulik, #plasma, mart, kossebau, davidedmundson
Cc: wbauer, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22970: Wayland: config update code cleanup

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:f99858504d93: Wayland: config update code cleanup 
(authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22970?vs=63208=63255

REVISION DETAIL
  https://phabricator.kde.org/D22970

AFFECTED FILES
  backends/kwayland/waylandbackend.cpp
  backends/kwayland/waylandbackend.h
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22966: Wayland: backend code cleanup

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:479d07200861: Wayland: backend code cleanup (authored by 
romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22966?vs=63182=63254

REVISION DETAIL
  https://phabricator.kde.org/D22966

AFFECTED FILES
  backends/kwayland/waylandbackend.cpp
  backends/kwayland/waylandbackend.h
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h

To: romangg, #plasma
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22814: Remove colon (:) prefix when looking up dictionary word

[Kai Uwe Broulik]

broulik added a comment.


  @wbauer done: 
https://cgit.kde.org/kdeplasma-addons.git/commit/?h=Plasma/5.12=eac0dbd5f1c0f1ba54bd9c9682da096d9c78db2a

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22814

To: broulik, #plasma, mart, kossebau, davidedmundson
Cc: wbauer, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

[Kai Uwe Broulik]

broulik added a comment.


  The vertical text alignment is quite off.
  F7174857: Screenshot_20190807_085002.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22977

To: GB_2, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, #vdg, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart