D23188: Fix supported OS attributes for api.kde.org

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> metainfo.yaml:12
>  - name: Windows
> -- name: macOS (maintainer needed)
> +- name: MacOSX
> +  note: maintainer needed

Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to 
change elsewhere?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23188

To: vkrause, #frameworks
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D23185: [libtaskmanager] Port to lighter KProcessList

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23185

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:f803a89e2443: Fix colors from KStatefulBrushes not using 
application colorschemes (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23170?vs=63839=63958

REVISION DETAIL
  https://phabricator.kde.org/D23170

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: hpereiradacosta, mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis added a comment.


  Considering the changes were already agreed upon before I made this diff, it 
seem safe to land without further review.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: hpereiradacosta, mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma installation clarification requested

[Sahlan]

Obtained a Nexus 5X on which to install Plasma OS, for porting software 
which I am also porting to Sailfish and Tizen devices.


All going well except the final step, so I am requesting some advice 
please.


I have successfully followed the instructions to unlock the phone's 
bootloader
I have checked that there is a plugdev group on my Ubuntu 18.04 box, and 
that my user name is a member of it

I have successfully fastboot formatted cache and userdata
I have downloaded pm-flashtool.git and run pm-flash when the phone is 
booted into fastboot mode
pm-flash asks me to confirm my device is a bullhead device (this is 
correct)
I type y for yes, and after a short delay the phone shows me the TWRP 
3.0.2.2 main screen, while on the Linux box I see a repeating pattern of

adb shell
echo 1
test -x
echo +n
sleep 3

This is not what I was expecting, because no documentation, nor any 
youtube videos, tell me this is what should happen. Have I done 
something wrong, or should I now be selecting one of the options from 
the TWRP main screen? In case security is an issue, I should tell you 
that I am logged in to Ubuntu under my regular user name, but running 
the fastboot commands under sudo.


With thanks for any advice.

D23228: Port away from deprecated KWindowSystem API

[David Faure]

dfaure created this revision.
dfaure added reviewers: zzag, graesslin, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Call the all-in-one method (which handles numeric keypad better),
  then split out modifiers and keycode.

TEST PLAN
  Builds, didn't test yet.

REPOSITORY
  R133 KScreenLocker

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D23228

AFFECTED FILES
  globalaccel.cpp

To: dfaure, zzag, graesslin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Björn Feber]

GB_2 added a comment.


  I just tried it on Wayland and it looks like for some reason instead of a 
number it shows some kind of UUID.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Nathaniel Graham]

ngraham added a comment.


  Cool, thanks. Once it's verified on Wayland, we can change `CCBUG:` to `BUG:`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  Thanks, now I got your point much clearer.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 63936.
cblack added a comment.


  The new highlight style has been yeeted in favor of the current one

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=60379=63936

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  If it's the exact same code as before, then my opinion will be the same.
  
  The digital clock set the text height to 0.7 of the panel and the width is 
inferred through layouting.
  This patch sets the width based on the height of the parent. Which is why you 
need a different magic number.
  
  We adjust the layout with which in turn adjust the width which in turn 
adjusts the digitH..it's all very messy.
  
  Our best bet will be to fix the layouting, so that the width can be inferred 
automatically and you can use the same logic to set the height.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23218: Fix compile warning

[Méven Car]

meven created this revision.
meven added a reviewer: ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Add a Q_UNUSED to avoid a compile warning

TEST PLAN
  Build

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23218

AFFECTED FILES
  src/common/database/Database.cpp

To: meven, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:acbc21c15622: Add a event Spy for GtkFileChooser recent 
files (authored by meven).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63913=63915

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  kactivitymanagerd.categories
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63913.
meven added a comment.


  Reduce the amount of included code and linked libraries

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63890=63913

BRANCH
  arcpatch-D23112

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  kactivitymanagerd.categories
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Jonathan Marten]

marten added a comment.


  In D22740#512556 , @ngraham wrote:
  
  > So does this fully fix 410190, or only partially?
  
  
  Fixes it completely for X11.
  Should really verify on Wayland before considering the bug to be completely 
fixed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Björn Feber]

GB_2 added a comment.


  @mart is this good now?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, 
fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63890.
meven added a comment.


  Ensure the log category is exported, compare only chars, variable naming fix

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63830=63890

BRANCH
  arcpatch-D23112

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  kactivitymanagerd.categories
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart