D23198: Skip mime type check only for files on network mounts

2019-08-25 Thread Méven Car
meven added a comment.


  In D23198#518001 , @dfaure wrote:
  
  > What I mean is:
  >
  > 1. improve KFileItem::isSlow to use this Solid code
  
  
  diff at D23420 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D23448: Capacity degradation -> Battery health

2019-08-25 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  After the change to "Capacity degradation" was announced on 
  https://pointieststick.com/2019/08/24/kde-usability-productivity-week-85/, it 
turned out
  that nobody could understand the new string either. :(
  
  This patch changes it to something much clearer: suggested by a user: 
"Battery health".
  This string has the advantage that it does not require knowing that batteries 
degrade,
  and uses the same percentage scale as other operating systems.

TEST PLAN
  F7279584: Systray popup.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  degradation-to-health (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23448

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23449: Capacity degradation -> Battery health

2019-08-25 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Companion to D23448 

TEST PLAN
  F7279583: KInfocenter.png 

REPOSITORY
  R102 KInfoCenter

BRANCH
  degradation-to-health (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23449

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

2019-08-25 Thread Carson Black
cblack created this revision.
cblack added reviewers: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Window titlebuttons on CSD windows now respect the user's colorscheme, 
preventing colorschemes such as Breeze Light, which has black on white instead 
of white on dark window buttons, from having barely discernable window buttons.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  window-button-symbolics (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23451

AFFECTED FILES
  src/assets/breeze-close-active-symbolic.svg
  src/assets/breeze-close-hover-symbolic.svg
  src/assets/breeze-close-symbolic.svg
  src/assets/breeze-maximize-active-symbolic.svg
  src/assets/breeze-maximize-hover-symbolic.svg
  src/assets/breeze-maximize-symbolic.svg
  src/assets/breeze-maximized-active-symbolic.svg
  src/assets/breeze-maximized-hover-symbolic.svg
  src/assets/breeze-maximized-symbolic.svg
  src/assets/breeze-minimize-active-symbolic.svg
  src/assets/breeze-minimize-hover-symbolic.svg
  src/assets/breeze-minimize-symbolic.svg
  src/build_theme.sh
  src/gtk3/applications/_chromium.scss
  src/gtk3/widgets/_window_decorations.scss

To: cblack, #breeze, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23449: Capacity degradation -> Battery health

2019-08-25 Thread Filip Fila
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  I was okay with the //degradation// as well, but if users are saying they 
want to have the same value as in other DEs/OSs, //health// seems like a good 
compromise. It's commonly used to describe the state of SSDs I think so it 
should be familiar to people.

REPOSITORY
  R102 KInfoCenter

BRANCH
  degradation-to-health (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23449

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D21860: Set a font for gtk applications in the fonts kcm

2019-08-25 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 64619.
gikari edited the test plan for this revision.
gikari added a comment.


  Fix harfbuzz include directories when Pango verison is 1.44 or greater

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21860?vs=64517&id=64619

BRANCH
  set-gtk-font-in-fonts-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21860

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGSettingSchemas.cmake
  cmake/modules/FindGTK2.cmake
  cmake/modules/FindGTK3.cmake
  gtkconfig/CMakeLists.txt
  gtkconfig/gtk2apps_reloader/CMakeLists.txt
  gtkconfig/gtk2apps_reloader/gtk2reloader.c
  gtkconfig/kded/CMakeLists.txt
  gtkconfig/kded/configeditor.cpp
  gtkconfig/kded/configeditor.h
  gtkconfig/kded/gtkconfig.cpp
  gtkconfig/kded/gtkconfig.h
  gtkconfig/kded/gtkconfig.json
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D23448: Capacity degradation -> Battery health

2019-08-25 Thread Alexander Potashev
aspotashev added a comment.


  Your own screenshot demonstrates capitalization inconsistency, should 
probably be "Battery Health"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23448

To: ngraham, #vdg, #plasma
Cc: aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D23448: Capacity degradation -> Battery health

2019-08-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 64621.
ngraham added a comment.


  Correct capitalization and i18n context

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23448?vs=64602&id=64621

BRANCH
  degradation-to-health (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23448

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: ngraham, #vdg, #plasma
Cc: aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D23152: [energy kcm] Display Vendor and model

2019-08-25 Thread Méven Car
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:708879b54aa8: [energy kcm] Display Vendor and model 
(authored by meven).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23152?vs=64424&id=64627

REVISION DETAIL
  https://phabricator.kde.org/D23152

AFFECTED FILES
  Modules/energy/batterymodel.cpp
  Modules/energy/batterymodel.h
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart