D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

[Björn Feber]

GB_2 updated this revision to Diff 66102.
GB_2 added a comment.


  Don't hide "Lock Widgets" for panels

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23950?vs=66094&id=66102

BRANCH
  
only-show-add-widgets-and-lock-widgets-panel-contextmenu-options-in-panel-edit-mode
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23950

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Yunhe Guo]

guoyunhe updated this revision to Diff 66101.
guoyunhe added a comment.


  Unify button look

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23868?vs=66074&id=66101

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23868

AFFECTED FILES
  kcms/kfontinst/apps/Installer.cpp
  kcms/kfontinst/kcmfontinst/16-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/16-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/22-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/22-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/FontFilter.h
  kcms/kfontinst/kcmfontinst/FontList.cpp
  kcms/kfontinst/kcmfontinst/GroupList.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/viewpart/FontPreview.cpp

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Yunhe Guo]

guoyunhe added a comment.


  I changed it to QToolButton, but it still look different:
  
  F7352361: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  See M144  and T10047 
. This cleans up the menu, the hidden 
options are already available in panel edit mode. This is how it looks like 
together with PATCH_HERE:
  
  Unlocked Widgets: F7352335: Improved Panel Context Menu Widgets Unlocked.png 

  
  Locked Widgets: F7352331: Improved Panel Context Menu Widgets Locked.png 


TEST PLAN
  Open the panel context menu

REPOSITORY
  R120 Plasma Workspace

BRANCH
  
only-show-add-widgets-and-lock-widgets-panel-contextmenu-options-in-panel-edit-mode
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23950

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66093.
cblack added a comment.


  Clean up commented code, colorscheme -> color scheme

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66092&id=66093

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66092.
cblack added a comment.


  Wrap text, add custom message handler to get rid of Qt SVG renderer spam

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66089&id=66092

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Awesome, so close! We're just at little nitpick territory now.

INLINE COMMENTS

> IconGridDelegate.qml:69
>  
> -PlasmaComponents.Label {
> +QQC2.Label {
>  font.pointSize: iconSize > 96 ? theme.defaultFont.pointSize : 
> theme.smallestFont.pointSize

There's a lot of commented code in here that could also be cleaned up

> Preview.qml:254
> +QQC2.MenuItem {
> +text: i18n("Screenshot with Active Colorscheme")
> +onTriggered: {

Colorscheme -> Color Scheme

> SvgGrid.qml:92
>  opacity: iconGrid.currentIndex == index ? 1.0 : 0.7
>  anchors {
>  left: parent.left

Could also get rid of the commented code in here

> Tools.qml:111
> +QQC2.ComboBox {
> +model: ["System Colorscheme", "Breeze (Normal)", "Breeze Dark"]
> +delegate: QQC2.ItemDelegate {

System Colorscheme -> System Color Scheme

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> Preview.qml:82
>  
> -Item { height: units.gridUnit / 2 }
> -
> -PlasmaExtras.Heading {
> -level: 3
> -elide: Text.ElideRight
> +Kirigami.Heading {
> +level: 1

Maybe add `wrapMode: Text.Wrap`, so the heading can have multiple lines.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66089.
cblack added a comment.


  Add a space

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66088&id=66089

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66088.
cblack added a comment.


  Shortcut fixemups

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66087&id=66088

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> Tools.qml:108
> +QQC2.Label {
> +text: i18n("Colorscheme:")
>  }

"Color scheme"

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Sweet, once the Ctrl+Q shortcut is fixed (Maybe that's an upstream issue 
too?), the UI will get a thumbs-up from me!

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Definitely should be fixed upstream. Feel free to send a patch for that!

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66087.
cblack added a comment.


  Begone, modality and hello remembering sizes

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66070&id=66087

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack added a comment.


  In D23712#531391 , @ngraham wrote:
  
  > Whoa, I just noticed someehing really weird happening: when I click on any 
of the comboboxes in the toolbar, the whole UI now darkens except for the 
combobox's popup. This effect isn't done anywhere else and should be removed.
  
  
  That comes from the `org.kde.desktop` style setting the combobox's popup to 
be modal, which results in a scrim being added. I added an override here, but 
that should probably be fixed in the desktop style as well.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Either use a ToolButton for the filter feature, or turn "Scan for duplicate 
fonts" into a PushButton, so they match one way or another.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Oh another thing: now the window size doesn't get remembered across launches, 
which is super annoying due to the excessively small default size (worth fixing 
here IMO) that results in the sidebar taking up like 40% of the view.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Whoa, I just noticed someehing really weird happening: when I click on any of 
the comboboxes in the toolbar, the whole UI now darkens except for the 
combobox's popup. This effect isn't done anywhere else and should be removed.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23868: kfontinst HiDPI icons

[Yunhe Guo]

guoyunhe updated this revision to Diff 66074.
guoyunhe added a comment.


  Change icon name. To match patch D23942 

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23868?vs=65841&id=66074

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23868

AFFECTED FILES
  kcms/kfontinst/apps/Installer.cpp
  kcms/kfontinst/kcmfontinst/16-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/16-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/22-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/22-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/FontFilter.h
  kcms/kfontinst/kcmfontinst/FontList.cpp
  kcms/kfontinst/kcmfontinst/GroupList.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/viewpart/FontPreview.cpp

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D6764: Use a smaller font size for digital clock plasmoid

[Yunhe Guo]

guoyunhe added a comment.


  I think we can make another applet called Small Digital Clock, which can be 
an alternative of Digital Clock. Just like we have different alternatives for 
launcher and task bar.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6764

To: januz, #plasma, #vdg, romangg
Cc: guoyunhe, romangg, mmustac, IlyaBizyaev, davidedmundson, ngraham, Zren, 
mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack added a comment.


  In D23712#531076 , @ngraham wrote:
  
  > Ctrl+Q still doesn't work.
  
  
  QML shortcut type seems to not be firing regardless of where it's placed in 
the program.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66070.
cblack added a comment.


  Add global menu bar for users with a global menu bar.

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66064&id=66070

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66064.
cblack added a comment.


  Padding and focus fixes

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=65929&id=66064

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66063.
alexde added a comment.


  Remove redundant and now wrong comment

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66062&id=66063

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23941: Compensate smaller icon sizes on mobile in the ActionButton

[Jonah Brüchert]

jbbgameich added a comment.


  I believe the new icon sizes were intentional for the drawer and own uses of 
Kirigami.Icon, but they influence the size of the whole ActionButton as well 
making it rather hard to click on a touch screen.
  Probably Camilo tested his changes only with mauikit which doesn't even use 
the bottom action nuttons.
  
  F7351130: Screenshot_20190914-175603.png 

  (I had to hide some jabber ids in my contact list, I hope the action buttons 
are still visible properly)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23941

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66062.
alexde added a comment.


  Fix offset calculation for the one hour graph

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66055&id=66062

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23578: Before requesting a scan, check the time threshold

[Méven Car]

meven added a comment.


  @jgrulich if you could have a second look, I improved this because my 
previous code could have prevented requestScan to be fired.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D23578

REVISION DETAIL
  https://phabricator.kde.org/D23578

To: meven, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23578: Before requesting a scan, check the time threshold

[Méven Car]

meven updated this revision to Diff 66060.
meven added a comment.


  Add a timer per interface allowing to scan devices as soon as technically 
possible, rescheduling wifi scan for when it will be possible

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23578?vs=66015&id=66060

BRANCH
  arcpatch-D23578

REVISION DETAIL
  https://phabricator.kde.org/D23578

AFFECTED FILES
  applet/contents/ui/main.qml
  libs/handler.cpp
  libs/handler.h

To: meven, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde added a comment.


  In D23520#531168 , @ngraham wrote:
  
  > Thanks, that's fixed now. However the "Last hour" graph still looks a 
little odd...
  >
  > F7350933: Screenshot_20190914_084935.png 

  
  
  Mm, I cannot reproduce this issue on my side and I cannot explain why you may 
experience it as the code behaves all the same of for all timespans. Very odd.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Nathaniel Graham]

ngraham added a comment.


  Thanks, that's fixed now. However the "Last hour" graph still looks a little 
odd...
  
  F7350933: Screenshot_20190914_084935.png 


REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66055.
alexde added a comment.


  Fix typo in variable and by that make all X axis labels appear again.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66044&id=66055

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm, now the X axis labels have disappeared for "Last hour", "Last 2 hours" 
and "Last 12 hours".

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Ctrl+Q still doesn't work.
  
  Found one more thing: the search field is no longer focused by default like 
it is with the current/old version.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23941: Compensate smaller icon sizes on mobile in the ActionButton

[Nathaniel Graham]

ngraham added a comment.


  I thought the smaller sizes now were intentional?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23941

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

Re: New Plasma Desktop website

[Nate Graham]

Maybe combine the first two images, then? Put the current release's 
wallpaper in the laptop background and add that "Latest release" window 
on top of it? Or do the opposite and remove the first image with the 
laptop. But having both seems a bit redundant.


Nate


On 9/14/19 7:48 AM, Carl Schwan wrote:

Hi,

I don't think that removing the two first images is a good idea. The second 
image is used to link to the latest announcement and if I only remove the first 
image, the user when landing on the page will not see a screenshot of Plasma 
without scrolling.

I now changed the Plasma wallpaper for the first screenshot so that I don't 
overpromote the Ice Cold wallpaper and this also makes the page less version 
specific (less work after each release).

Cheers

Carl

‐‐‐ Original Message ‐‐‐
On Saturday, September 14, 2019 3:10 PM, Christoph Feck  wrote:


On 09/14/19 14:38, Carl Schwan wrote:




I finalized the first version of the new plasma-desktop webpage, a preview is 
available at https://kde.carlschwan.eu/plasma-desktop. There are still two 
parts missing (p-b-i and privacy) and some possible improvement that I would 
like to add later. Can I get approval from the Plasma team to land the current 
state?





Nice work! I would remove the first two images, since they don't show
anything that isn't already shown in the first Laptop screenshot. They
basically only show the Ice wallpaper.

Re: New Plasma Desktop website

[Carl Schwan]

Hi,

I don't think that removing the two first images is a good idea. The second 
image is used to link to the latest announcement and if I only remove the first 
image, the user when landing on the page will not see a screenshot of Plasma 
without scrolling.

I now changed the Plasma wallpaper for the first screenshot so that I don't 
overpromote the Ice Cold wallpaper and this also makes the page less version 
specific (less work after each release).

Cheers

Carl

‐‐‐ Original Message ‐‐‐
On Saturday, September 14, 2019 3:10 PM, Christoph Feck  wrote:

> On 09/14/19 14:38, Carl Schwan wrote:
> 

> > I finalized the first version of the new plasma-desktop webpage, a preview 
> > is available at https://kde.carlschwan.eu/plasma-desktop. There are still 
> > two parts missing (p-b-i and privacy) and some possible improvement that I 
> > would like to add later. Can I get approval from the Plasma team to land 
> > the current state?
> 

> Nice work! I would remove the first two images, since they don't show
> anything that isn't already shown in the first Laptop screenshot. They
> basically only show the Ice wallpaper.



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

Re: New Plasma Desktop website

[Nate Graham]

On 9/14/19 7:10 AM, Christoph Feck wrote:

On 09/14/19 14:38, Carl Schwan wrote:
I finalized the first version of the new plasma-desktop webpage, a 
preview is available at https://kde.carlschwan.eu/plasma-desktop. 
There are still two parts missing (p-b-i and privacy) and some 
possible improvement that I would like to add later. Can I get 
approval from the Plasma team to land the current state?


Nice work! I would remove the first two images, since they don't show 
anything that isn't already shown in the first Laptop screenshot. They 
basically only show the Ice wallpaper.


+1

Beautiful work overall!

Nate

Re: New Plasma Desktop website

[Christoph Feck]

On 09/14/19 14:38, Carl Schwan wrote:

I finalized the first version of the new plasma-desktop webpage, a preview is 
available at https://kde.carlschwan.eu/plasma-desktop. There are still two 
parts missing (p-b-i and privacy) and some possible improvement that I would 
like to add later. Can I get approval from the Plasma team to land the current 
state?


Nice work! I would remove the first two images, since they don't show 
anything that isn't already shown in the first Laptop screenshot. They 
basically only show the Ice wallpaper.

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66044.
alexde added a comment.


  The former scaling of the x-Positions of the data points did not fit to the 
time axis.
  Now the x-values of the points, i. e. their timestamps, are correctly aligned.
  
  For some unknown reasons, all data points, which come before/after a certain, 
  abitrary timestamp, seem to have a non-valid timestamp = 0.
  That's why I have added a if-statement to ignore those values.
  
  This feels more like a workaround and the underlying issue should be fixed 
instead in the future.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66034&id=66044

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

New Plasma Desktop website

[Carl Schwan]

Hello Plasma team,

It was nice to meet you all to the Akademy, I hope you had all a safe travel 
back home and see you all next year. :p

I finalized the first version of the new plasma-desktop webpage, a preview is 
available at https://kde.carlschwan.eu/plasma-desktop. There are still two 
parts missing (p-b-i and privacy) and some possible improvement that I would 
like to add later. Can I get approval from the Plasma team to land the current 
state?

Cheers,

Carl Schwan



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

D23941: Compensate smaller icon sizes on mobile in the ActionButton

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  They became smaller since D22572 . This 
should restore the intended state.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23941

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66034.
alexde added a comment.


  Remove redundant semicolons and move comment about unit (ms) to the 
declaration of the var

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66031&id=66034

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66031.
alexde added a comment.


  Use a switch statement for xTicksAt

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65457&id=66031

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> Graph.qml:165
> +
> +if (xTicksAt == xTicksAtTwelveOClock) {
> +diff = ((hours - 12) * 60 * 60 + minutes * 60 + seconds) * 1000 
> // ms

A switch statement should be clearer here.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19337: Fixed some undefined properties runtime errors.

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19337

To: malteveerman, #kirigami, mart, aacid
Cc: aacid, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein