D23952: Remove panel toolbox clean up editing options

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  With D23951  we greatly improve the 
discoverability of the panel edit mode, so there isn't a need for a button in 
the panel anymore that just takes up space (especially since with D23951 
 we're basically always in unlocked mode) 
and we get asked about how to remove it from time to time. This also cleans up 
the panel editing options:
  
  - Only show "Show Alternatives..." in panel edit mode
  - Remove "Lock Widgets" option from the panel edit mode, like in D23951 

  
  F7354567: Panel.png 
  F7354564: Task Manager Hidden Show Alternatives Item.png 

  F7354562: Panel Edit Mode.png 

TEST PLAN
  Open panel edit mode. Also open the context menu for the task manager.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-panel-toolbox-clean-up-editing-options (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23952

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml
  toolboxes/CMakeLists.txt
  toolboxes/paneltoolbox/Messages.sh
  toolboxes/paneltoolbox/contents/ui/main.qml
  toolboxes/paneltoolbox/metadata.desktop
  toolboxes/plasma-toolbox-paneltoolbox.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KF6 Sprint

[Volker Krause]

Hi,

as you might have seen in David's summary of the KF6 BoF at Akademy (https://
mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), 
there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we 
had in Randa a few years back, to determine what we actually want to achieve 
with KF6 beyond just porting to Qt6.

If you are interested please subscribe to https://phabricator.kde.org/T11535 
and indicate your interest to participate, as well as times that would work 
for you. I'm not just looking at the current KF5 contributors for this, but 
also those of you heavily using KF5.

If you are willing to help organize the sprint, please indicate so there too, 
help with that would be greatly appreciated (I'm not organizing this, I'm just 
writing this email because Albert asked me too ;-) ).

With Qt 6 planned for Nov 2020 we are probably looking at a 18-24 month time 
frame towards KF6, so it's time to get this going.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

Re: Plasma 5.18 as LTS

[Elvis Stansvik]

Den fre 13 sep. 2019 kl 18:13 skrev David Edmundson
:
>
> Yes.

Great thanks. Was just curious which Plasma we can look forward to in
Kubuntu 20.04 (we use Kubuntu LTS versions at work).

Elvis

Re: Plasma 5.18 as LTS

[Nate Graham]

Presumably the next LTS Plasma version (5.18), which is slated for 
release in February of 2020[1]; plenty of time to get ready for the 
April 2020 release of Kubuntu 20.04


Nate


[1] https://community.kde.org/Schedules/Plasma_5


On 9/15/19 5:31 AM, Elvis Stansvik wrote:

Den fre 13 sep. 2019 kl 18:13 skrev David Edmundson
:


Yes.


Great thanks. Was just curious which Plasma we can look forward to in
Kubuntu 20.04 (we use Kubuntu LTS versions at work).

Elvis

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Jonathan Marten]

marten updated this revision to Diff 66138.
marten added a comment.


  Ignore the desktop ID and simply use the loop index, adjusted so that the 
desktop numbers start at 1.  This is the same formatting as used by KWin 
(kwin/useractions.cpp) and the Task Manager applet 
(plasma-desktop/applets/taskmanager/package/contents/ui/ContextMenu.qml).  This 
should work as intended on both X11 and Wayland.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22740?vs=62545&id=66138

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma
Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Nathaniel Graham]

ngraham added a comment.


  Maybe in the interests of #consistency 
, let's make the filter feature 
look the same way that it does in the Colors KCM: F7357040: 
Screenshot_20190915_131425.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23952: Remove panel toolbox and clean up editing options

[Nathaniel Graham]

ngraham added a comment.


  Hmm, after applying and compiling all three patches and then restarting 
plasmashell, I still see the panel toolbox.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  In D22740#513873 , @marten wrote:
  
  > @GB_2 thanks for testing;  a desktop UUID is obviously not friendly to show 
to the user, so there needs to be some sort of X11/Wayland runtime check here.
  
  
  Yes, that's right, KWin will generate a UUID for each new virtual desktop.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma, #kwin, zzag
Cc: zzag, GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23952: Remove panel toolbox and clean up editing options

[Björn Feber]

GB_2 added a comment.


  In D23952#532034 , @ngraham wrote:
  
  > Hmm, after applying and compiling all three patches and then restarting 
plasmashell, I still see the panel toolbox.
  
  
  That's because you still have the files and manually compiling and installing 
won't delete them :-)
  The package manager does that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23952: Remove panel toolbox and clean up editing options

[Nathaniel Graham]

ngraham added a comment.


  Oh, of course.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Yunhe Guo]

guoyunhe added a comment.


  In D23868#532016 , @ngraham wrote:
  
  > Maybe in the interests of #consistency 
, let's make the filter feature 
look the same way that it does in the Colors KCM: F7357040: 
Screenshot_20190915_131425.png 
  
  
  There is a major difference: the color filter is a combobox but the font 
filter is a menu with checkbox and child menu. I cannot change it to a combobox 
but can swap the order and try to add borders.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Since the tab view is dead, we should improve the keyboard navigation of the 
sidebar view

TEST PLAN
  Played a bit with it, it looks like it's working.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23975

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/main.qml

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Nathaniel Graham]

ngraham added a comment.


  Definitely better than before!
  
  One use case still doesn't work though: Returning to the first column of the 
sidebar when you're in the second column and only a single column is visible 
(i.e. because the window is unmaximized).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Nathaniel Graham]

ngraham added a comment.


  In D23868#532046 , @guoyunhe wrote:
  
  > In D23868#532016 , @ngraham 
wrote:
  >
  > > Maybe in the interests of #consistency 
, let's make the filter feature 
look the same way that it does in the Colors KCM: F7357040: 
Screenshot_20190915_131425.png 
  >
  >
  > There is a major difference: the color filter is a combobox but the font 
filter is a menu with checkbox and child menu. I cannot change it to a combobox 
but can swap the order and try to add borders.
  
  
  Radio buttons, not checkboxes. Which means the entries are all mutually 
exclusive, which means it could actually be a combobox, but for the fact that 
some of its items have sub-menus.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Yunhe Guo]

guoyunhe added a comment.


  Now I can get something like this (the QLineEdit and QPushButton still have 
different height):
  
  F7357403: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb planned changes to this revision.
ognarb added a comment.


  In D23975#532059 , @ngraham wrote:
  
  > Definitely better than before!
  >
  > One use case still doesn't work though: Returning to the first column of 
the sidebar when you're in the second column and only a single column is 
visible (i.e. because the window is unmaximized).
  
  
  Good catch, I will try to fix this case too.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Nathaniel Graham]

ngraham added a comment.


  In D23868#532065 , @guoyunhe wrote:
  
  > Now I can get something like this (the QLineEdit and QPushButton still have 
different height):
  >
  > F7357403: image.png 
  
  
  That's better, and we should just fix 
https://bugs.kde.org/show_bug.cgi?id=411811

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Yunhe Guo]

guoyunhe updated this revision to Diff 66157.
guoyunhe added a comment.


  Similar filter layout as Colors KCM. Move "Scan Duplicates..." button to the 
bottom button group.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23868?vs=66101&id=66157

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23868

AFFECTED FILES
  kcms/kfontinst/apps/Installer.cpp
  kcms/kfontinst/kcmfontinst/16-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/16-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/16-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/22-actions-disablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-enablefont.png
  kcms/kfontinst/kcmfontinst/22-actions-font-disable.png
  kcms/kfontinst/kcmfontinst/22-actions-font-enable.png
  kcms/kfontinst/kcmfontinst/CMakeLists.txt
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/FontFilter.h
  kcms/kfontinst/kcmfontinst/FontList.cpp
  kcms/kfontinst/kcmfontinst/GroupList.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.h
  kcms/kfontinst/viewpart/FontPreview.cpp

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb added a comment.


  Looking at the behavior more in details. The 'bug' with a smaller screen 
should be fixed in kirigami instead. The focus is correct and I can move back 
the main category and select anoter subcategory.  The problem is that Kirigami 
pageStack should display the page that as focus automaticly.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right, let's land this then, and fix it in Kirigami. Do you fancy sending 
a patch for that?

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

ognarb added a comment.


  Thanks, I will try to send a kirigami patch, if I don't send anything before 
the next weekend consider that I forgot ;p

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23975

To: ognarb, #plasma, #plasma_accessibility, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23975: Improve keyboard navigation

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:e649d5a706b6: Improve keyboard navigation (authored by 
ognarb).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23975?vs=66154&id=66158

REVISION DETAIL
  https://phabricator.kde.org/D23975

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/main.qml

To: ognarb, #plasma, #plasma_accessibility, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Uh-oh, moving the button down to the lower row now causes the layout to get 
so wide with English that it overflows the default System Settings window size: 
F7357577: Screenshot_20190915_150638.png .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Noah Davis]

ndavis added a comment.


  The colorscheme selector does not work

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23952: Remove panel toolbox and clean up editing options

[Björn Feber]

GB_2 updated this revision to Diff 66159.
GB_2 added a comment.


  - Add back "Show Alternatives..." item and remove reference to panel toolbox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23952?vs=66105&id=66159

BRANCH
  arcpatch-D23952

REVISION DETAIL
  https://phabricator.kde.org/D23952

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml
  desktoppackage/contents/defaults
  toolboxes/CMakeLists.txt
  toolboxes/paneltoolbox/Messages.sh
  toolboxes/paneltoolbox/contents/ui/main.qml
  toolboxes/paneltoolbox/metadata.desktop
  toolboxes/plasma-toolbox-paneltoolbox.desktop

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Noah Davis]

ndavis added a comment.


  The sidebar seems a bit wide. Maybe remove the 128px view? As a Breeze icon 
designer, I don't really need it.

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Noah Davis]

ndavis added a comment.


  Text still gets cut off on the left side: F7357632: 
Screenshot_20190915_171434.png 

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Noah Davis]

ndavis added a comment.


  The clickable area is significantly smaller than the highlight.

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Noah Davis]

ndavis added a comment.


  There seems to be a blank entry at the bottom of the category list: F7357648: 
Screenshot_20190915_171648.png 

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23977: [Notifications] Introduce dedicated "read" state for notification

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Currently, a notification is considered "unread" when it was created or 
updated after the last time the user opened the history.
  To alleviate this, when the notification popup is hovered, e.g. because the 
user wanted to drag an image out, select some text, or open the "More" menu, it 
is considered read. It will still end up in the history but will not needlessly 
show the "unread notification" bell icon.
  
  Moreover, job finished notifications are always considered read, as they are 
either from long-standing jobs which the user is likely aware of, or 
confirmation of short tasks the user doesn't need explicit confirmation about. 
For example, extracting an archive in Dolphin, I get an "Extracting (Finished)" 
but I don't want to explicitly acknowledge that notification because I can just 
enter the folder that was just created in Dolphin.
  
  This surely doesn't fix the underlying problem of notification expiration and 
history, and the user might just interact wiht some tray icons or the clock and 
not actually deal with the notification popup but this is imho an acceptable 
stopgap until a proper solution is found, which won't happen in time for Plasma 
5.17 anyway.

TEST PLAN
  - Took a screenshot, dragged notification out, let notification expire, 
didn't get a bell
  - Copied some files, got a finished notification, didn't get a bell
  - Copied some files, killed Dolphin, got a persistent error notification as 
before
  - Created four notifications, opened history, got four notifications expanded 
(all unread notifications are expanded by default)
  - Created two notifications, hovered them, created three more, opened 
history, got three notifications (the unread) shown, and "two more"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23977

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/global/Globals.qml
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationgroupcollapsingproxymodel.cpp
  libnotificationmanager/notifications.cpp
  libnotificationmanager/notifications.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23977: [Notifications] Introduce dedicated "read" state for notification

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Lovely, this is much nicer behavior!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23977

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66177.
cblack added a comment.


  Whole buncha stuff

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66093&id=66177

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Menu.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66178.
cblack added a comment.


  Spacing fixes

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66177&id=66178

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Menu.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Lovely stuff.
  
  The addition of a 256px icon in the sidebar makes it absurdly wide though. 
I'd recommend removing it.

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66179.
cblack added a comment.


  Shrink sidebar

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66178&id=66179

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Menu.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Awesome.
  
  Didn't the main icon grid used to have a white background? I kind of liked 
that. Speaking of the icon grid, I'm somehow only not noticing that it's not 
sorted in any appreciable way. Maybe it should be alphabetical.

REPOSITORY
  R118 Plasma SDK

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

[Carson Black]

cblack updated this revision to Diff 66180.
cblack added a comment.


  Alphabetical sort and more telling Qt's garbage SVG renderer to shut up

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23712?vs=66179&id=66180

BRANCH
  modernization (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23712

AFFECTED FILES
  cuttlefish/package/contents/ui/DualMontage.qml
  cuttlefish/package/contents/ui/GlobalMenuBar.qml
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Menu.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/main.cpp
  cuttlefish/src/view.cpp
  cuttlefish/src/view.h

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, 
plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23910: startplasma: Respect KDEWM again

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0fcd29399b9d: startplasma: Respect KDEWM again (authored 
by heikobecker).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23910?vs=65932&id=66181

REVISION DETAIL
  https://phabricator.kde.org/D23910

AFFECTED FILES
  startkde/startplasma.cpp

To: heikobecker, #plasma, apol, davidedmundson
Cc: broulik, nicolasfella, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart