D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting updated this revision to Diff 66980.
whiting added a comment.


  - Add speech synthesis engine selection combobox to general klipper settings 
page.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24276?vs=66978=66980

BRANCH
  speech

REVISION DETAIL
  https://phabricator.kde.org/D24276

AFFECTED FILES
  CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/configdialog.cpp
  klipper/generalconfig.ui
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/klipper.kcfg
  klipper/tts.cpp
  klipper/tts.h

To: whiting, davidedmundson, gladhorn
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24276: Add text to speech functionality to klipper.

[Jeremy Whiting]

whiting created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
whiting requested review of this revision.

REVISION SUMMARY
  Add action with global shortcut to speak text selection and another
  to speak clipboard contents.
  Add another action to stop speaking.
  Add another action to pause/resume speaking.
  Add a setting to klipper for the QTextToSpeech engine to use, if it
  changes reload the QTTS object with the chosen engine.
  
  TODO: Add a ui element to allow selecting the tts engine.
  Make a kcm to allow configuration of speech-dispatcher with a gui
  and add a button next to the klipper engine config if speechd is
  selected to launch kcm for further configuration.
  Possibly disable keyboard shortcuts by default so users don't
  accidentally trigger speech features.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  speech

REVISION DETAIL
  https://phabricator.kde.org/D24276

AFFECTED FILES
  CMakeLists.txt
  klipper/CMakeLists.txt
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/klipper.kcfg
  klipper/tts.cpp
  klipper/tts.h

To: whiting
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Carson Black]

cblack added a comment.


  Does it work if you use an absolute path to the library? Go to 
`$BUILDROOT/color-reload-module/libcolorreload-gtk-module.so` and run `gedit 
--gtk-module $PWD/libcolorreload-gtk-module.so`

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Nathaniel Graham]

ngraham added a comment.


$ gedit --gtk-module colorreload-gtk-module
Gtk-Message: 17:44:24.968: Failed to load module "colorreload-gtk-module"
  
  What am I doing wrong?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Nathaniel Graham]

ngraham added a comment.


  Nice work. Landed on master so we have plenty of time to polish it up in 
follow-up patches. Speaking of that, I have a suggestions for unifying the UI 
even more: for multi-port devices, show the port chooser combobox instead of 
the name of the current port, in both the KCM and the applet. There's 
guaranteed to be enough room (we'd be replacing a string with the same string 
in a combobox). Then remove the "Ports" items in the applet's hamburger menu.
  
  Oh and I just noticed a regression I didn't see before landing the patch, 
sorry. :/ The icons no longer match between the KCM and the applet when I add 
an external bluetooth device: F7450714: Screenshot_20190927_163022.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg, ngraham, GB_2
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D24161: Make KCM look more like applet

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:608e9e6fe793: Make KCM look more like applet (authored by 
sefaeyeoglu, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=66945=66976

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg, ngraham, GB_2
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The title is somewhat self explanatory.

TEST PLAN
  `gtk-app-here --gtk-module colorreload-gtk-module`

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  color-reload-module (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24275

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/meson.build
  color-reload-module/reloader.c

To: cblack, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24269: [krunner] Port old style connect

[David Edmundson]

davidedmundson updated this revision to Diff 66964.
davidedmundson added a comment.


  keep order

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24269?vs=66963=66964

REVISION DETAIL
  https://phabricator.kde.org/D24269

AFFECTED FILES
  krunner/view.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24269: [krunner] Port old style connect

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24269

AFFECTED FILES
  krunner/view.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24268: [libtaskmanager] Port to new connect syntax

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  UniqueConnection I dropped as we disconnect the old source model above
  regardless, so it seemed superfluous.

TEST PLAN
  Compiles
  Opened N dolphins
  They were still grouped

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24268

AFFECTED FILES
  libtaskmanager/taskgroupingproxymodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24267: [soliduiserver] Port deprecated KPasswordDialog::setPixmap method

[David Edmundson]

davidedmundson updated this revision to Diff 66961.
davidedmundson added a comment.


  asdfasd

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24267?vs=66960=66961

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24267

AFFECTED FILES
  soliduiserver/soliduiserver.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24267: [soliduiserver] Port deprecated KPasswordDialog::setPixmap method

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  None

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24267

AFFECTED FILES
  soliduiserver/soliduiserver.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14

[David Faure]

dfaure closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24255

To: dfaure, apol, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ToolBoxButton.qml:286
> +icon.height: units.iconSizes.smallMedium
> +onClicked: qAction.trigger()
> +}

Locking the widgets while in edit mode doesn't update the menu item, so it's 
possible to end up in this state:

F7448695: Screenshot_20190927_111420.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24264: edit mode action and dbus

[Nathaniel Graham]

ngraham added a comment.


  I wonder if the widget resize handles should become visible all the time when 
in edit mode. Otherwise nothing visually changes with the widgets on the 
desktop, and it might not be obvious enough that you can change them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24260: [Style KCM] Don't explicitly reload KWin's configuration

[Kai Uwe Broulik]

broulik added a comment.


  > You could probably make a compelling case that this one thing doesn't matter
  
  It doesn't matter because we don't signal KWin when we change the style, only 
when changing the "effects" settings (toolbar style, show icons on buttons and 
in menus), so the pixel metric isn't affected by this at all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24260

To: broulik, #plasma, #kwin
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66959.
mthw marked an inline comment as done.
mthw added a comment.


  > Also, what's the reason for not showing percentage when power management is 
disabled? This isn't about the service not running or being a desktop PC, this 
is true when screens are forced on.
  
  Makes sense, but it was like this before, so I just kept it that way. 
Secondly will the string still be translated using "plasmoid.title"?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66958=66959

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> batterymonitor.qml:56
> +if (powermanagementDisabled) {
> +return i18n("Battery and Brightness")
> +}

You can probably just return `plasmoid.title` in the default case.
Also, what's the reason for not showing percentage when power management is 
disabled? This isn't about the service not running or being a desktop PC, this 
is true when screens are forced on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  In D24070#538806 , @mthw wrote:
  
  > Like this? Don't we need to return something when "remainingTime <= 0"?
  
  
  No, because in this case it just doesn't show a subtitle, which I think is 
fine.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 66958.
mthw added a comment.


  Like this? Don't we need to return something when "remainingTime <= 0"?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66487=66958

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  From what I can tell, the problem with  `remainingTime` being 0 sometimes is 
a pre-existing bug that the current code is hiding fairly well by not showing 
the string that uses that value when the time is 0. We should fix that later, 
but for now what we should do is replicate the hiding logic for all cases in 
the new style too (see inline comment). Than I think this can go in, pending 
@broulik's approval.

INLINE COMMENTS

> batterymonitor.qml:93
> +}
> +if (pmSource.data["AC Adapter"] && pmSource.data["AC 
> Adapter"]["Plugged in"]) {
> +return i18n("%1 until fully charged", 
> KCoreAddons.Format.formatDuration(remainingTime, 
> KCoreAddons.FormatTypes.HideSeconds))

This block also needs` if (remainingTime > 0) {` like the one below it

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  yes, it's completely ortogonal to that one

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Björn Feber]

GB_2 added a comment.


  Nice! I guess D23951  is still relevant?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24264: edit mode action and dbus

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> appletslayout.cpp:100
>  connect(m_window, ::activeChanged, this, [this]() {
> -if (!m_window->isActive()) {
> +if (!qApp->focusWindow()) {
>  setEditMode(false);

But we only evaluate this when this window changes - doesn't that mean we could 
when any other plasma window had focus and then loses it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  still has the problem of long press not working with the folderview layout 
(stolen events) will look into that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  Is there still something that needs to be fixed, or can this go in?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart added a comment.


  F7447783: vokoscreen-2019-09-27_17-03-51.mp4 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  desktop and panel toolboxes are only visible in "edit mode"
  edit mode can be triggered by
  
  - long press in desktop
  - context menu action
  - dbus property (to be eventually used by systemsettings)
  
  The desktop toolbox becomes a "toolbar" with just few selected actions
  the presence of that toolbar both fullfills "long press should usually show 
some 
  contextual actions" and being a very visible hint that "we are now in edit 
mode"
  toolbox is still movable around in case would obscure any important stuff 
where it's 
  by default
  depends from D24263  and D24264 


TEST PLAN
  ui works as planned, toolbox position is saved and restored correctly

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems sane enough to me. Even though it's a new esoteric option, it does seem 
useful for certain use cases and it's buried in a config window that almost 
nobody will ever see, so I think it's all right.
  
  #plasma  folks, any comments or 
objections?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24264: edit mode action and dbus

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  edit mode menu action
  edit mode dbus property for systemsettings
  containmentlayoutmanager goes out of edit mode only when the whole
  plasma app loses focus, so the panel controlled doesn't make it go out
  of it

TEST PLAN
  iaction shows in context menu, works
  property exposed on dbus works

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24264

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp
  containmentactions/contextmenu/menu.cpp
  shell/dbus/org.kde.PlasmaShell.xml

To: mart, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66952.
sefaeyeoglu added a comment.


  Change behaviour of configuration.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13243?vs=66951=66952

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66951.
sefaeyeoglu added a comment.


  Put checkbox into own category

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13243?vs=66926=66951

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24260: [Style KCM] Don't explicitly reload KWin's configuration

[David Edmundson]

davidedmundson added a comment.


  I had a look through kwin and kdecoration
  
  There's 5 or so things that fetch things from qstyle directly, but nothing 
seems to cache the value, with the exception of:
  effects/startupfeedback/startupfeedback.cpp:cursorSize = 
QApplication::style()->pixelMetric(QStyle::PM_LargeIconSize);
  
  You could probably make a compelling case that this one thing doesn't matter

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24260

To: broulik, #plasma, #kwin
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigGeneral.qml:89
> +
> +QQC2.CheckBox {
> +id: showRealDevicesOnly

This isn't a feedback-related item so it shouldn't be in the Feedback section. 
I would do it more like this:

  Item {
  Kirigami.FormData.isSection: true
  }
  
  QQC2.CheckBox {
  id: showRealDevicesOnly
  Kirigami.FormData.label: i18n("Show:")
  text: i18n("Virtual audio streams and devices")
  }

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24260: [Style KCM] Don't explicitly reload KWin's configuration

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24260

To: broulik, #plasma, #kwin
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24260: [Style KCM] Don't explicitly reload KWin's configuration

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This ways only done for changes to the "effects", not the actual widget 
style, but:
  
  - plasma-integration updates `ShowIconsOnPushButtons` and 
`ShowIconsInMenuItems` when a change to `SETTINGS_STYLE` is notified by the KCM
  - plasma-integration updates toolbar style when `ToolbarStyleChanged` is 
notified by the KCM

TEST PLAN
  - Disabled icons on menus, decoration menu icons were gone immediately
  - Don't know where KWin actually has a dialog with buttons or toolbars

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24260

AFFECTED FILES
  kcms/style/kcmstyle.cpp

To: broulik, #plasma, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66945.
sefaeyeoglu added a comment.


  Align mute button centered with slider

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=66943=66945

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg, ngraham
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D24258: Forward error message from backend to ui

[Nathaniel Graham]

ngraham added a comment.


  Heh, if that's a more accurate error message, I as a user would still have no 
clue what do to about it...

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24258

To: nicolasfella, #plasma, #kwin
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66943.
sefaeyeoglu added a comment.


  Fix wrong display name of default-device button

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=66920=66943

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg, ngraham
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D24161: Make KCM look more like applet

[Björn Feber]

GB_2 added a comment.


  I'd also align the mute button with the slider, like in the applet.

INLINE COMMENTS

> DeviceListItem.qml:89
> +Button {
> +text: i18n("Default device")
> +icon.name: "favorite"

"Default Device"

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg, ngraham
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:ff0ac9ab879d: Fix clipping and use a real ScrollView for 
the Display Configuration KCM screen… (authored by GB_2).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24129?vs=66614=66942

REVISION DETAIL
  https://phabricator.kde.org/D24129

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml

To: GB_2, #plasma, #vdg, ngraham, romangg
Cc: romangg, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24258: Forward error message from backend to ui

[Kai Uwe Broulik]

broulik added a comment.


  Maybe at least show "Failed to contact screen management service: $msg"

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24258

To: nicolasfella, #plasma, #kwin
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24258: Forward error message from backend to ui

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Saying that no backend was found is not accurate when there was a different 
error in the backend. The backend gives us an error message we can display 
instead.

TEST PLAN
  I get a different error message now

REPOSITORY
  R104 KScreen

BRANCH
  errormsg

REVISION DETAIL
  https://phabricator.kde.org/D24258

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/package/contents/ui/main.qml

To: nicolasfella, #plasma, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24208: [Notifications] Dodge Plasma dialogs

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cc0c125479d4: [Notifications] Dodge Plasma dialogs 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24208?vs=66793=66940

REVISION DETAIL
  https://phabricator.kde.org/D24208

AFFECTED FILES
  applets/notifications/CMakeLists.txt
  applets/notifications/notificationapplet.cpp
  applets/notifications/notificationapplet.h
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D24208: [Notifications] Dodge Plasma dialogs

[Marco Martin]

mart accepted this revision.
mart added a comment.


  this may be good in both .17 and master, then to see if is possible, only in 
master to actually move the notivications out of the way

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 27 Sep 2019 08:44:13 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.tests.processtest

D24208: [Notifications] Dodge Plasma dialogs

[Marco Martin]

mart added a comment.


  In D24208#538239 , @ngraham wrote:
  
  > This works great!
  >
  > Instead of temporarily hiding the pop-ups, maybe it should appear above the 
dialog? Not a huge deal though.
  >
  > 5.17 branch?
  
  
  would make sense...
  unless you are showing the notification full representation tough, where 
things would be kinda redundant

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

To: broulik, #plasma, #vdg, ngraham
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23675: [Folder View] Don't query file information if tooltips are disabled

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b636aa1a9ab3: [Folder View] Dont query file 
information if tooltips are disabled (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23675?vs=65229=66939

REVISION DETAIL
  https://phabricator.kde.org/D23675

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: broulik, #plasma, hein, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: ddcutil in Plasma Powerdevil

[Dorian Vogel]

Hey Jonathan,
Unfortunately I did not test it for a long time (last time was around
5.15), and don't really have the possibility now because I'm away from home.
*If I remember correctly,* back then I had a few instances when the startup
of plasma (during the splashscreen) was quite longer due to retries of the
DDC communication (of course this will not happen if the user does not have
ddcutil itself installed). As I understand it, this is due to the
architecture of Powerdevil, which assumes the monitors are a fixed
configuration as far as brightness is concerned: backends are queried at
startup and never refreshed. This is why enumeration has to happen during
startup of plasma, and one would have to restart powerdevil when connecting
a new DDC capable monitor

Thinking back I wonder if a plasmoid would have been a better way, enabling
to have the enumeration done after startup is finished, and making it
easier to have a "refresh" button, and would still allow to have both an
integrated screen (laptop) and external (for now the backends in powerdevil
are exclusive).

Considering this is my first contribution and I am not sure of the quality,
I think some testing from more experienced devs would be required. I
haven't heard much so far.

Cheers,
*Dorian*

On Thu, Sep 26, 2019 at 11:13 AM Jonathan Riddell  wrote:

> The DDCUtil features of Powerdevil in KDE Plasma are currently disabled by
> default
> "DDCUtil library support is disabled by default as recomended by authors,
> add -DHAVE_DDCUTIL=On to enable"
> This is based on a conversation from 2017 where it was decided it was
> unstable.
>
> I see work has continued on DDCUtil and on support for it in Powerdevil.
> Is it ready to be set to on by default?
>
> It is too late for Plasma 5.17 due for release in 2 weeks but we can tell
> distros the message is old as appropriate.
>
> Jonathan
>
>

-- 
VOGEL Dorian