D24265: support global edit mode

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> ngraham wrote in ToolBoxButton.qml:286
> Locking the widgets while in edit mode doesn't update the menu item, so it's 
> possible to end up in this state:
> 
> F7448695: Screenshot_20190927_111420.png 
> 

latest revision should fix that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24265: support global edit mode

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> mart wrote in ToolBoxButton.qml:286
> latest revision should fix that

actually, revision of D24263 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24304: [Cuttlefish] Add 48 to the sizeslider

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The initial icon size Cuttlefish starts with is 48 
(Kirigami.Unis.iconSizes.large).
  However this size cannot be selected using the slider. To quickly see this
  start Cuttlefish (note the slider says 64) and move the slide to some other
  value and back to 64. The icons have now a different size than before. Since 
we
  also show a preview for 48 add this size to the selectable ones.

REPOSITORY
  R118 Plasma SDK

BRANCH
  48 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24304

AFFECTED FILES
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The icon in different installed themes is shown in an overlay sheet.

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

AFFECTED FILES
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

[Filip Fila]

filipf added a comment.


  LGTM. Can the overlay be spawned in the vertical center of the window as well 
or is that defined in Kirigami itself? Also what happens when there are a lot 
of themes, does the overlay remain the same size and just get a scrollbar?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

monday meeting notes for 30/9/2019

[Marco Martin]

Nico Fe:
* Ported Koko to Android
* Needs more work to be useful
For review:
 * Diff 24173 "Fix build against exiv for real" [Needs Review]
https://phabricator.kde.org/D24173
 * Diff 24175 "Don't use KDBusService on Android" [Needs Review]
https://phabricator.kde.org/D24175
 * Diff 24186 "Request permission for accessing external storage"
[Needs Review] https://phabricator.kde.org/D24186
Other stuff:
 * replaced accounts KCM with version from plasma-settings
 * port kaccounts away from foreach
 * Diff 24218 "Port away from foreach" [Needs Review]
https://phabricator.kde.org/D24218
 * Diff 24221 "Port to new connect syntax" [Needs Review]
https://phabricator.kde.org/D24221
 * Diff 24258 "Forward error message from backend to ui" [Needs
Review] https://phabricator.kde.org/D24258
 * fixed stuff in plasma-settings

David:
* last week I merged all the migration and addition of a global
animation speed slider
new config value in another place, kconf_update, porting kwin to use
that new value, kai ported ** p-f to use that value, and then moving
the UI
* I've also added a useful thing into kwin making it easy to render
QtQuick into an effect scene (at any layer, not just hacky overlays)
* in other news I'm trying to push forward with my "lets run
clang-format on everything"
* push forward with my "lets run clang-format on everything":
** Diff 24283 "Add clang format file" [Needs Review]
https://phabricator.kde.org/D24283
* also after Saturday I'm going to merge my QML plugin into KItemModels
** we should discuss what we do with Plasma's QSortFilterProxyModel

Bhushan:
- Pushed patch in plamo dialer to make it not crash since it seemed to work
- WIP initial setup thing based on current plasma settings app
- Testing plasma nano shell and reporting issues back to notmart
- Testing on different hardware
- If someone can take a quick look at the :
https://phabricator.kde.org/D24112 it would be lovely.

Marco:
# Kirigami
* bugfixing
* New PagePool and PagePoolAction components: makes much easier to
make apps with a sidebar and main content page which is a very common
pattern
* examples and documentation for PagePool*
# Plasma
* helping and finishing a patch a VDG person did for systemsettings
(home button to go back to intro page)
* work on the edit mode agreed with the vdg at valencia sprint,
patches all aound p-f p-d p-w D24263 D24264 D24265
* Diff 24263 "edit mode action" [Needs Review]
https://phabricator.kde.org/D24263
* Diff 24264 "edit mode action and dbus" [Needs Review]
https://phabricator.kde.org/D24264
* Diff 24265 "support global edit mode" [Needs Review]
https://phabricator.kde.org/D24265
# Plasma Mobile
* merged the plasmanano branch, can be tested as soon lands on neon

D24264: edit mode action and dbus

[Marco Martin]

mart added a comment.


  In D24264#538820 , @ngraham wrote:
  
  > I wonder if the widget resize handles should become visible all the time 
when in edit mode. Otherwise nothing visually changes with the widgets on the 
desktop, and it might not be obvious enough that you can change them.
  
  
  I tought about it too, tough maybe if everyhting is visible (right now the 
resize handles and the bigger applet handle are linked in visibility) wouldn't 
look very messy and cluttered?

INLINE COMMENTS

> davidedmundson wrote in appletslayout.cpp:100
> But we only evaluate this when this window changes - doesn't that mean we 
> could when any other plasma window had focus and then loses it?

right.. it wouldn't notice if the edit mode was initiated when its window not 
in focus, i-.e. dbus from systemsettings case.
that may probably mean the logic should be completely removed from here and put 
in shellcorona i guess?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

[David Redondo]

davidre added a comment.


  In D24305#539727 , @filipf wrote:
  
  > LGTM. Can the overlay be spawned in the vertical center of the window as 
well or is that defined in Kirigami itself? Also what happens when there are a 
lot of themes, does the overlay remain the same size and just get a scrollbar?
  
  
  I didn't look into sizing positioning the overlay yet. But a scrollbar 
appears if the content doesn't fit into the available size.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: ddcutil in Plasma Powerdevil

[Jonathan Riddell]

I put ddcutils package in Neon unstable to be able to test it, using
Sanford's packaging from Debian but with the libraries turned on.  However
powerdevil doesn't compile with DDCUtils turned on, it fails on a cmake
error.

Jonathan


On Fri, 27 Sep 2019 at 07:14, Dorian Vogel  wrote:

> Hey Jonathan,
> Unfortunately I did not test it for a long time (last time was around
> 5.15), and don't really have the possibility now because I'm away from home.
> *If I remember correctly,* back then I had a few instances when the
> startup of plasma (during the splashscreen) was quite longer due to retries
> of the DDC communication (of course this will not happen if the user does
> not have ddcutil itself installed). As I understand it, this is due to the
> architecture of Powerdevil, which assumes the monitors are a fixed
> configuration as far as brightness is concerned: backends are queried at
> startup and never refreshed. This is why enumeration has to happen during
> startup of plasma, and one would have to restart powerdevil when connecting
> a new DDC capable monitor
>
> Thinking back I wonder if a plasmoid would have been a better way,
> enabling to have the enumeration done after startup is finished, and making
> it easier to have a "refresh" button, and would still allow to have both an
> integrated screen (laptop) and external (for now the backends in powerdevil
> are exclusive).
>
> Considering this is my first contribution and I am not sure of the
> quality, I think some testing from more experienced devs would be required.
> I haven't heard much so far.
>
> Cheers,
> *Dorian*
>
> On Thu, Sep 26, 2019 at 11:13 AM Jonathan Riddell  wrote:
>
>> The DDCUtil features of Powerdevil in KDE Plasma are currently disabled
>> by default
>> "DDCUtil library support is disabled by default as recomended by authors,
>> add -DHAVE_DDCUTIL=On to enable"
>> This is based on a conversation from 2017 where it was decided it was
>> unstable.
>>
>> I see work has continued on DDCUtil and on support for it in Powerdevil.
>> Is it ready to be set to on by default?
>>
>> It is too late for Plasma 5.17 due for release in 2 weeks but we can tell
>> distros the message is old as appropriate.
>>
>> Jonathan
>>
>>
>
> --
> VOGEL Dorian
>

D24265: support global edit mode

[Marco Martin]

mart updated this revision to Diff 67069.
mart added a comment.


  - state machine for right order of opacity and visible

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24265?vs=66955&id=67069

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/main.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: mart, #plasma
Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

[David Redondo]

davidre updated this revision to Diff 67070.
davidre added a comment.


  Show a symbol when a theme doesn't have the icon

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24305?vs=67053&id=67070

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

AFFECTED FILES
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, #vdg
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  In D22210#498933 , @fvogt wrote:
  
  > In D22210#498929 , 
@asturmlechner wrote:
  >
  > > drop translations, rename to 'Plasma on Xorg'
  >
  >
  > That would not be symmetric to "Plasma (Wayland)" though as produced by 
sddm.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24264: edit mode action and dbus

[Marco Martin]

mart updated this revision to Diff 67071.
mart added a comment.


  - move logic of out of editmode in shellcorona

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24264?vs=66954&id=67071

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24264

AFFECTED FILES
  components/containmentlayoutmanager/appletslayout.cpp
  components/containmentlayoutmanager/appletslayout.h
  containmentactions/contextmenu/menu.cpp
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp

To: mart, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24264: edit mode action and dbus

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in appletslayout.cpp:100
> But we only evaluate this when this window changes - doesn't that mean we 
> could when any other plasma window had focus and then loses it?

different approach in current version

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24194: Add per-origin media controls blacklist

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> action_popup.js:217
> +TabUtils.getCurrentTab().then((tab) => {
> +return sendMessage("mpris", "hasTabPlayer", {
> +tabId: tab.id

Does this also hit all the frames inside?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24194

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24194: Add per-origin media controls blacklist

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fvogt wrote in action_popup.js:217
> Does this also hit all the frames inside?

Effectively, yes. It asks the extension.js whether it knows any players on the 
given tab, which will include all frames, see the actual implementation of 
"hasTabPlayer" which checks `playerIds` containing all of them.
(Also, I tested with an embedded YouTube player iframe which showed up 
alongside the main page)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24194

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24299: Fix "Show intro page" button not resetting titlebar title

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  this doesn't work for the case of clicking on one of the categories shown on 
the home page and then clicking on the home button.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D24299

To: GB_2, #plasma, mart, ngraham
Cc: ngraham, mart, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24264: edit mode action and dbus

[Nathaniel Graham]

ngraham added a comment.


  In D24264#539730 , @mart wrote:
  
  > I thought about it too, tough maybe if everything is visible (right now the 
resize handles and the bigger applet handle are linked in visibility) wouldn't 
look very messy and cluttered?
  
  
  Maybe, but this is an explicit edit mode, so it might make sense to have the 
editing controls more obvious?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24264

To: mart, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice!

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24289: Fix wrong KCM device icon for specific form factors

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:5f6b290728a8: Fix wrong KCM device icon for specific form 
factors (authored by sefaeyeoglu, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24289?vs=67006&id=67073

REVISION DETAIL
  https://phabricator.kde.org/D24289

AFFECTED FILES
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/DeviceListItem.qml

To: sefaeyeoglu, #vdg, #plasma, ngraham, GB_2
Cc: #plasma, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24289: Fix wrong KCM device icon for specific form factors

[Nathaniel Graham]

ngraham added a comment.


  I notice that the Bluetooth applet has the same icon issues. I wonder if we 
should put this function in plasma-framework so it can be used by lots of other 
things without having to duplicate it multiple times.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24289

To: sefaeyeoglu, #vdg, #plasma, ngraham, GB_2
Cc: #plasma, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now we have a problem in that the important scale factors of 1.25 and 
1.75 are
  not reachable using the UI. However just reducing the slider increment to 
0.05 would
  result in way too many slider values. Instead, this patch implements the 
following:
  
  - Slider goes by increments of 0.25
  - The user can show an advanced scaling settings dialog that exposes a UI to 
set the scale factor with increments of 0.05
  
  This way the commonly-used scale factors are more accessible, but more 
granular values
  are made available to people who really need them and are likely to go poking 
around.
  
  BUG: 412447
  FIXED-IN: 5.18.0

TEST PLAN
  F7477024: advanced scaling settings.webm 


REPOSITORY
  R104 KScreen

BRANCH
  advanced-scaling-control (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24321

AFFECTED FILES
  kcm/package/contents/ui/CustomScalingSheet.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  0.05 is no good idea either ;)
  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  If we really need something finer than 0.25, could we stick with 1/8 or 1/16?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: ddcutil in Plasma Powerdevil

[Jonathan Riddell]

https://build.neon.kde.org/job/bionic_unstable_kde_powerdevil_bin_amd64/127/console

*17:40:13* CMake Error at CMakeLists.txt:56
(add_compile_definitions):*17:40:13*   Unknown CMake command
"add_compile_definitions".

Is the cmake error I get for Powerdevil


https://cgit.kde.org/powerdevil.git/

Jonathan



On Mon, 30 Sep 2019 at 21:17, Sanford Rockowitz 
wrote:

> You might want to look at the launchpad packaging (
> https://launchpad.net/~rockowitz/+archive/ubuntu/ddcutil), which includes
> the library version and development package.  It is at the current release
> level (0.9.7).
>
> If the cmake error is not obvious, let me know what it is.  The locus of
> the problem may jump out at me.
>
> Sanford
>
> On 9/30/19 9:07 AM, Jonathan Riddell wrote:
>
> I put ddcutils package in Neon unstable to be able to test it, using
> Sanford's packaging from Debian but with the libraries turned on.  However
> powerdevil doesn't compile with DDCUtils turned on, it fails on a cmake
> error.
>
> Jonathan
>
>
> On Fri, 27 Sep 2019 at 07:14, Dorian Vogel  wrote:
>
>> Hey Jonathan,
>> Unfortunately I did not test it for a long time (last time was around
>> 5.15), and don't really have the possibility now because I'm away from home.
>> *If I remember correctly,* back then I had a few instances when the
>> startup of plasma (during the splashscreen) was quite longer due to retries
>> of the DDC communication (of course this will not happen if the user does
>> not have ddcutil itself installed). As I understand it, this is due to the
>> architecture of Powerdevil, which assumes the monitors are a fixed
>> configuration as far as brightness is concerned: backends are queried at
>> startup and never refreshed. This is why enumeration has to happen during
>> startup of plasma, and one would have to restart powerdevil when connecting
>> a new DDC capable monitor
>>
>> Thinking back I wonder if a plasmoid would have been a better way,
>> enabling to have the enumeration done after startup is finished, and making
>> it easier to have a "refresh" button, and would still allow to have both an
>> integrated screen (laptop) and external (for now the backends in powerdevil
>> are exclusive).
>>
>> Considering this is my first contribution and I am not sure of the
>> quality, I think some testing from more experienced devs would be required.
>> I haven't heard much so far.
>>
>> Cheers,
>> *Dorian*
>>
>> On Thu, Sep 26, 2019 at 11:13 AM Jonathan Riddell 
>> wrote:
>>
>>> The DDCUtil features of Powerdevil in KDE Plasma are currently disabled
>>> by default
>>> "DDCUtil library support is disabled by default as recomended by
>>> authors, add -DHAVE_DDCUTIL=On to enable"
>>> This is based on a conversation from 2017 where it was decided it was
>>> unstable.
>>>
>>> I see work has continued on DDCUtil and on support for it in
>>> Powerdevil.  Is it ready to be set to on by default?
>>>
>>> It is too late for Plasma 5.17 due for release in 2 weeks but we can
>>> tell distros the message is old as appropriate.
>>>
>>> Jonathan
>>>
>>>
>>
>> --
>> VOGEL Dorian
>>
>
>

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540011 , @cullmann wrote:
  
  > 0.05 is no good idea either ;)
  >  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  >  If we really need something finer than 0.25, could we stick with 1/8 or 
1/16?
  
  
  I don't want to lock people out of the finer scale factor numbers. Depending 
on your screen DPI and size, you may want to set and be quite happy with a 
weird scale factor like 1.65x. The idea here is to expose the more common and 
bug-free scale factors in the main UI, while letting experts and risk-takers 
set whatever they want. Maybe I should add a warning in the dialog that people 
who set a weird value there are on their own?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Noah Davis]

ndavis added a comment.


  what would be wrong with replacing the label with the spinbox? For normal 
control, use the slider. For fine control, use the spinbox. Then we wouldn't 
need an extra dialog.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540015 , @ndavis wrote:
  
  > what would be wrong with replacing the label with the spinbox? For normal 
control, use the slider. For fine control, use the spinbox. Then we wouldn't 
need an extra dialog.
  
  
  That isn't a bad idea, but then it feels a bit redundant since you'd have two 
adjacent controls that set the same value.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Björn Feber]

GB_2 added a comment.


  The KDE HIG suggests something like this: 
https://hig.kde.org/_images/Slider.Speed.qml.png

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[KonqiDragon]

KonqiDragon added a comment.


  How about breeze icon of SimpleScreenRecorder  #VDG 
?
  Maybe repaint digiKam icon to make SSR icon?
  F7477107: Breezeicons-apps-48-digikam.svg.png 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  In D24321#540014 , @ngraham wrote:
  
  > In D24321#540011 , @cullmann 
wrote:
  >
  > > 0.05 is no good idea either ;)
  > >  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  > >  If we really need something finer than 0.25, could we stick with 1/8 or 
1/16?
  >
  >
  > I don't want to lock people out of the finer scale factor numbers. 
Depending on your screen DPI and size, you may want to set and be quite happy 
with a weird scale factor like 1.65x. The idea here is to expose the more 
common and bug-free scale factors in the main UI, while letting experts and 
risk-takers set whatever they want. Maybe I should add a warning in the dialog 
that people who set a weird value there are on their own?
  
  
  That is fine, but please use some step width that is a proper float.
  Just use 1/16, that is 0,0625.
  0.05 will just lead to the same issues as 0.1, it looks nice in the input 
field but is no floating pointer number you can calculate sanely with.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Noah Davis]

ndavis added a comment.


  In D24321#540029 , @KonqiDragon 
wrote:
  
  > How about breeze icon of SimpleScreenRecorder  #VDG 
?
  >  Maybe repaint digiKam icon to make SSR icon?
  >  F7477107: Breezeicons-apps-48-digikam.svg.png 

  
  
  I think you accidentally posted in the wrong discussion.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  And the custom scale factor dialog really should have some warning text like 
on Windows ;=)
  
  see e.g.
  
  
https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html
  
  (custom scale factor not recommended)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: ddcutil in Plasma Powerdevil

[Dorian Vogel]

Rah that's dicky me trying to add the WITH_DDCUTIL symbol and propagate it to 
be used 
in a #ifdef in the actual code (ddcutilbrightness.{c, h}) I spent a lot of 
time trying to get it 
to work although it's probably basic cmake stuff...

Hmm after a bit of research, is it possible that the jenkins uses a Cmake older 
than 3.12 ? 
It seems "add_compile_definitions" was introduced with this version.
Related discussion 
https://github.com/facebookresearch/habitat-sim/issues/137[1] 

The "old" command would be:
add_definitions(-DWITH_DDCUTIL)

Cheers,
*Dorian*


On Monday, 30 September 2019 22:27:51 CEST Jonathan Riddell wrote:
> https://build.neon.kde.org/job/bionic_unstable_kde_powerdevil_bin_amd64/127/
> console
> 
> *17:40:13* CMake Error at CMakeLists.txt:56
> (add_compile_definitions):*17:40:13*   Unknown CMake command
> "add_compile_definitions".
> 
> Is the cmake error I get for Powerdevil
> 
> 
> https://cgit.kde.org/powerdevil.git/
> 
> Jonathan
> 
> 
> 
> On Mon, 30 Sep 2019 at 21:17, Sanford Rockowitz 
> 
> wrote:
> > You might want to look at the launchpad packaging (
> > https://launchpad.net/~rockowitz/+archive/ubuntu/ddcutil), which includes
> > the library version and development package.  It is at the current release
> > level (0.9.7).
> > 
> > If the cmake error is not obvious, let me know what it is.  The locus of
> > the problem may jump out at me.
> > 
> > Sanford
> > 
> > On 9/30/19 9:07 AM, Jonathan Riddell wrote:
> > 
> > I put ddcutils package in Neon unstable to be able to test it, using
> > Sanford's packaging from Debian but with the libraries turned on.  However
> > powerdevil doesn't compile with DDCUtils turned on, it fails on a cmake
> > error.
> > 
> > Jonathan
> > 
> > On Fri, 27 Sep 2019 at 07:14, Dorian Vogel  wrote:
> >> Hey Jonathan,
> >> Unfortunately I did not test it for a long time (last time was around
> >> 5.15), and don't really have the possibility now because I'm away from
> >> home. *If I remember correctly,* back then I had a few instances when
> >> the startup of plasma (during the splashscreen) was quite longer due to
> >> retries of the DDC communication (of course this will not happen if the
> >> user does not have ddcutil itself installed). As I understand it, this
> >> is due to the architecture of Powerdevil, which assumes the monitors are
> >> a fixed configuration as far as brightness is concerned: backends are
> >> queried at startup and never refreshed. This is why enumeration has to
> >> happen during startup of plasma, and one would have to restart
> >> powerdevil when connecting a new DDC capable monitor
> >> 
> >> Thinking back I wonder if a plasmoid would have been a better way,
> >> enabling to have the enumeration done after startup is finished, and
> >> making
> >> it easier to have a "refresh" button, and would still allow to have both
> >> an
> >> integrated screen (laptop) and external (for now the backends in
> >> powerdevil
> >> are exclusive).
> >> 
> >> Considering this is my first contribution and I am not sure of the
> >> quality, I think some testing from more experienced devs would be
> >> required.
> >> I haven't heard much so far.
> >> 
> >> Cheers,
> >> *Dorian*
> >> 
> >> On Thu, Sep 26, 2019 at 11:13 AM Jonathan Riddell 
> >> 
> >> wrote:
> >>> The DDCUtil features of Powerdevil in KDE Plasma are currently disabled
> >>> by default
> >>> "DDCUtil library support is disabled by default as recomended by
> >>> authors, add -DHAVE_DDCUTIL=On to enable"
> >>> This is based on a conversation from 2017 where it was decided it was
> >>> unstable.
> >>> 
> >>> I see work has continued on DDCUtil and on support for it in
> >>> Powerdevil.  Is it ready to be set to on by default?
> >>> 
> >>> It is too late for Plasma 5.17 due for release in 2 weeks but we can
> >>> tell distros the message is old as appropriate.
> >>> 
> >>> Jonathan
> >> 
> >> --
> >> VOGEL Dorian




[1] https://github.com/facebookresearch/habitat-sim/issues/137

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Noah Davis]

ndavis added a comment.


  In D24321#540034 , @cullmann wrote:
  
  > And the custom scale factor dialog really should have some warning text 
like on Windows ;=)
  >
  > see e.g.
  >
  > 
https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html
  >
  > (custom scale factor not recommended)
  
  
  Ah, if it's not recommended, that might be a good reason to keep it in a 
separate dialog.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540026 , @GB_2 wrote:
  
  > The KDE HIG suggests something like this: 
https://hig.kde.org/_images/Slider.Speed.qml.png
  
  
  I kind of like this idea. Then if you set a weird value, an InlineMessage at 
the top of the screen would appear warning you that it's not a recommended 
value.
  
  Also without any string changes, it would go into Plasma 5.17. :)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Btw., I think GNOME is more clever than us, too, they allow just sane 
scalings in the UI:
  
  https://www.omgubuntu.co.uk/2019/06/enable-fractional-scaling-ubuntu-19-04

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Johan Ouwerkerk]

ouwerkerk added a comment.


  Ideally you would also warn if the reciprocal times the horizontal, vertical 
resolution yields a non-integer output, not just if some value is chosen which 
cannot be represented in floating point exactly.
  
  E.g. on a 4K (3840 × 2160) a scaling factor of 1.5 is fine because the 
horizontal resolution scales down to effectively 3840 × 2 ÷ 3 = 2160 and the 
vertical resolution scales down to 2160 × 2 ÷ 3 = 1440. This means that the 
scaled renders will fit the physical display exactly.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Johan Ouwerkerk]

ouwerkerk added a comment.


  Also side note, as a non-native English speaker I find "grossly" to be a bit 
of an odd adjective to use here -- "coarsely" would be more familiar: as in 
fine/coarse grained. Perhaps something to keep in mind when this lands and you 
start blogging about it :)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[David Edmundson]

davidedmundson added a comment.


  > it would go into Plasma 5.17. :)
  
  There's still a feature freeze.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  No you're right, "grossly" is a poor choice of wording.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  Anyway I'm going to see if the textfield-next-to-the-slider approach works 
better (in conjunction with a warning message).

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24324: [GTK2] Add program to libexec for GTK2 recoloration

[Carson Black]

cblack created this revision.
cblack added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  There is now a Python program installed to a distro's libexec dir
  which will generate assets based on the user's current colorscheme. This is
  needed for complete recolouration because of the fact that most of 
  the GTK2 theme is pixmaps. Currently, recoloration only recolors the things
  that are not pixmaps, which leads to stuff like 
  https://bugsfiles.kde.org/attachment.cgi?id=122870.
  
  This is one part of the solution to fixing bug 412331, but is not the whole
  solution.

TEST PLAN
  See that the program is installed to libexec and that it generates
  GTK2 assets correctly.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  gtk2-recoloration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24324

AFFECTED FILES
  src/CMakeLists.txt
  src/color_gtk2_theme

To: cblack, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24325: [runners/calculator] Port old style connect

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24325

AFFECTED FILES
  runners/calculator/qalculate_engine.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24080: Fix copying urls to the clipboard

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:296fa55e21c0: Fix copying urls to the clipboard (authored 
by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24080?vs=66458&id=67098

REVISION DETAIL
  https://phabricator.kde.org/D24080

AFFECTED FILES
  src/controls/UrlButton.qml
  src/kirigamiplugin.cpp

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Hi, I thought about this a bit more ;)
  
  I really think we shall limit the minimal increase to 0.25, without any 
advanced field. Perhaps the range should be larger, like 1-4, if some people 
get "really" high DPI screens.
  
  Rational:
  
  1. For small 0.1 changes: Just change your font size, we did that always for 
the old non-hidpi world were displays did differ a bit in the DPI, that works 
without any glitches
  
  2. Anything below 0.25 will just break half of our applications. For 
KTextEditor I did some hack in master that might avoid artifacts if you only 
scale with stuff like .25 or .5, it will still break with small stuff and most 
of our applications look horrible with small scalings, look at attached 
screenshot fo 1.1, do we really want to advertise that?
  
  F7481758: screenshot.png 
  
  Qt 5.14 will even have "opt-out" of fractional scaling and perhaps we even 
need to do that for some applications...

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  In D24321#540056 , @davidedmundson 
wrote:
  
  > > it would go into Plasma 5.17. :)
  >
  > There's still a feature freeze.
  
  
  At least moving away from 0.1 increases is actually a bugfix. Look at my 
konsole screenshot, similar artifacts can be created with most of our 
applications.
  (sadly still with 0.25/0.5, too, but at least not that often and you then can 
try to fix that by choosing some better font...)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart