date:20191020

D24720: [applets/systemtray] Rewrite popups with layouts

2019-10-20 Thread Filip Fila

filipf added a comment.


  In D24720#550200 , @ngraham wrote:
  
  > Seems like the RTL problem may be that your RowLayouts that are within the 
parent ColumnLayout don't have `Layout.fillWidth: true` set. Does the problem 
go away if you set that?
  
  
  The heading RowLayout had that set in the previous version of the diff but it 
didn't help.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24798: Migrate QQC1 to QQC2

2019-10-20 Thread Yunhe Guo

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The TableView in digital clock widget time zone configuration is replaced 
with ListView. Other UI didn't change.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24798

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml
  applets/digital-clock/plugin/timezonesi18n.cpp
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/customwallpaper.qml

To: guoyunhe
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24265: support global edit mode

2019-10-20 Thread Björn Feber

GB_2 added a comment.


  In D24265#549640 , @mart wrote:
  
  > i would prefer not to, but can be tried with eventually in the future
  
  
  Ok, we can do that in another patch. This is fine once you address my inline 
comment "Not done." and fix this:
  
  In D24265#549581 , @GB_2 wrote:
  
  > Only one last issue: the widget resizing handles disappear if the cursor is 
on a blank area of the widget handle (the bar to the left/right).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 6.25% on X11

2019-10-20 Thread Mayeul Cantan

MayeulC added a comment.


  @cullmann  from what I understand, it is related to what you wrote in 
https://cullmann.io/posts/kde-qt-highdpi-scaling/ ?  How is it only related to 
X11?
  
  Just a small note: we will probably see some platform that do not use IEEE 
754 floating points appear in the next years (unums like posit are well 
positioned to make an entry on the market, together with RISC-V CPUs). Those 
will have different tradeofs.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg, mart
Cc: MayeulC, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Nicolas Fella

nicolasfella created this revision.
nicolasfella added a reviewer: meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  D23578  removed the 
wirelessScanTimerEnabled signal. The mobile wifi KCM needs to be adjusted.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  reg

REVISION DETAIL
  https://phabricator.kde.org/D24804

AFFECTED FILES
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, meven, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Méven Car

meven accepted this revision.
meven added a comment.


  I wish I had caught this, thanks @nicolasfella

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24804

To: nicolasfella, meven, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Nicolas Fella

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:fefb9ef507ef: Fix regression in mobile wifi kcm (authored 
by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24804?vs=68360&id=68364

REVISION DETAIL
  https://phabricator.kde.org/D24804

AFFECTED FILES
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, meven, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Méven Car

meven added inline comments.

INLINE COMMENTS

> main.qml:30
>  
> -PlasmaNM.Handler {
> -id: handler

PlasmNM.Handler must be kept, (used line 56)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24804

To: nicolasfella, meven, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Nicolas Fella

nicolasfella added inline comments.

INLINE COMMENTS

> meven wrote in main.qml:30
> PlasmNM.Handler must be kept, (used line 56)

oops, fixed

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24804

To: nicolasfella, meven, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 6.25% on X11

2019-10-20 Thread Christoph Cullmann

cullmann added a comment.


  On Wayland one seems to always scale up to the next full factor (e.g. 2) and 
then scale down the rendered stuff via gl to the selected factor (e.g 1.5).
  
  That leads to other issues but doesn't let rounding stuff creep into the 
rendering via Qt.
  
  For non IEEE stuff: perhaps that will be available in the future, but at the 
moment all really available RISC-V ISAs provide just IEEE, too.
  And staying in some 1/(2^x) range won't hurt any alternative approach I 
assume.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg, mart
Cc: MayeulC, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24808: [mobile/wifi] Group networks by connection state

2019-10-20 Thread Nicolas Fella

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  groups

REVISION DETAIL
  https://phabricator.kde.org/D24808

AFFECTED FILES
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24810: Ensure defintion of XDG_DATA_DIRS

2019-10-20 Thread Tobias C. Berner

tcberner created this revision.
tcberner added reviewers: FreeBSD, dfaure, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  Similar to XDG_DATA_DIRS defaulting to KDE_INSTALL_FULL_DATAROOTDIR, and
  some sensible constants, also make XDG_DATA_DIRS default to 
KDE_INSTALL_FULL_CONFDIR
  and some sensible constants.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24810

AFFECTED FILES
  startkde/config-startplasma.h.cmake
  startkde/startplasma.cpp

To: tcberner, #freebsd, dfaure, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24808: [mobile/wifi] Group networks by connection state

2019-10-20 Thread Jan Grulich

jgrulich added inline comments.

INLINE COMMENTS

> main.qml:89
>  
> -header: Kirigami.ListSectionHeader {
> -text: mobileProxyModel.showSavedMode ? i18n("Saved networks") : 
> i18n("Available networks")
> +section.property: "ConnectionState"
> +section.delegate: Kirigami.ListSectionHeader {

You can use  "Section" property from the model, which already contains either 
"Active connections" or "Available connections".

We use it in the applet as well:

  section.property: showSections ? "Section" : ""
  section.delegate: Header { text: section }

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24808

To: nicolasfella, jgrulich, #plasma, #plasma:_mobile
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24810: Ensure defintion of XDG_DATA_DIRS

2019-10-20 Thread David Faure

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Bug in the commit log: s/ also make XDG_DATA_DIRS/ also make XDG_CONFIG_DIRS/

INLINE COMMENTS

> startplasma.cpp:195
>  }
> +   // Additionally also set default value for XDG_CONFIG_DIRS which is not 
> set by default on FreeBSD.
> +   if (!qEnvironmentVariableIsSet("XDG_CONFIG_DIRS")) {

I see nothing FreeBSD specific about this, I suggest simplifying the comment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24810

To: tcberner, #freebsd, dfaure, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-20 Thread Filip Fila

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6b4295b313af: [applets/taskmanager] Revert 
"forceStripes" checkbox string change (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24534?vs=67609&id=68381

REVISION DETAIL
  https://phabricator.kde.org/D24534

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: #localization, jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-20 Thread Jan Grulich

jgrulich updated this revision to Diff 68382.
jgrulich added a comment.


  - Improvements based on review comments

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68218&id=68382

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24009: RFC: Make Breeze Dark darker

2019-10-20 Thread Filip Fila

filipf abandoned this revision.
filipf added a comment.


  Gonna leave all color scheme updates to @ndavis and @cblack who have been 
working on a new palette for Breeze etc.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24009

To: filipf, cblack, ndavis, #vdg, ngraham, #plasma
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-20 Thread Nathaniel Graham

ngraham added a comment.


  So close! You don't need to create a `Rectangle` to give the ScrollView a 
white background; just set `Component.onCompleted: background.visible = true` 
on the scrollview itself. Here's an example of how it's done in the 
Notifications KCM: 
https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24785: Store stashed model index as QPersistentModelIndex

2019-10-20 Thread Aleix Pol Gonzalez

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes a lot of sense.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24785

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

2019-10-20 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently it's a text box that doesn't give you any indication of what the 
units are.
  
  BUG:413249
  FIXED-IN: 5.18.0

TEST PLAN
  F7639735: Spinbox.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  spinbox-for-nightcolor-duration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24813

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24814: [KCMs] Make spinboxes editable

2019-10-20 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Otherwise they're annoying to use because you can only interact with them 
using a scroll
  or by clicking on the tiny arrows.

TEST PLAN
  You can nowenter text in the spinboxes

REPOSITORY
  R119 Plasma Desktop

BRANCH
  editable-spinboxes (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24814

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml
  kcms/launch/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24815: [Weather] Make update time spinbox editable

2019-10-20 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

TEST PLAN
  Now you can enter text in it using the keyboard. To make this more 
predictible, the
  custom stepSize value is removed so all integer valued between the min and 
max are
  acceptable now.

REPOSITORY
  R114 Plasma Addons

BRANCH
  editable-spinbox (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24815

AFFECTED FILES
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24816: [Applet] Make spinboxes editable

2019-10-20 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Otherwise you can't enter numbers in them and it's really annoying

TEST PLAN
  Now you can change the max volume and volume step spinboxes without raising 
your
  blood pressure

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  editable-spinboxes (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D24816

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24786: [GTK3] Add styles for libhandy widgets

2019-10-20 Thread Nathaniel Graham

ngraham added a comment.


  I don't see the harm. We can always adjust it later.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24786

To: cblack, #breeze, #vdg
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24798: Migrate QQC1 to QQC2

2019-10-20 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  ++. The new table in the clock settings is much nicer anyway. :) See the 
following inline comments:

INLINE COMMENTS

> configTimeZones.qml:22
>  import QtQuick 2.0
> -import QtQuick.Controls 1.2 as QtControls
> +import QtQuick.Controls 2.8
>  import QtQuick.Layouts 1.0

`import QtQuick.Controls 2.5 as QQC2`

> configTimeZones.qml:53
>  
>  Rectangle {
>  id: messageWidget

While you're doing some porting, this entire thing can be replaced with a 
`Kirigami.InlineMessage` which will drastically reduce the amount of code here, 
and you can also remove the `PlasmaComponents` import (`PlasmaCore` is still 
needed for units, unless you want to also port things to use `Kirigami.Units` 
instead)

> configTimeZones.qml:143
> +clip: true
> +spacing: 5
>  

`units.largeSpacing` is preferable to hardcoded spacing values

> configTimeZones.qml:153
> +width: parent.width
> +text: !city || city.indexOf("UTC") === 0 ? comment : 
> comment ? i18n("%1, %2 (%3)", city, region, comment) : i18n("%1, %2", city, 
> region)
> +checked: model.checked

This is pretty hard to follow. I would recommend expanding it to a conventional 
if/else block for clarity.

> timezonesi18n.cpp:463
>  {QStringLiteral("UTC+08:00"), i18nc("This is a generic time zone 
> name, localize as needed", "UTC+08:00")},
> +{QStringLiteral("UTC+08:30"), i18nc("This is a generic time zone 
> name, localize as needed", "UTC+08:30")},
>  {QStringLiteral("UTC+09:00"), i18nc("This is a generic time zone 
> name, localize as needed", "UTC+09:00")},

Seems unrelated; probably best done in another patch

> ConfigGeneral.qml:20
>  import QtQuick 2.5
> -import QtQuick.Controls 1.4 as QQC1
> -import QtQuick.Controls 2.5 as QQC2
> +import QtQuick.Controls 2.5
>  import QtQuick.Layouts 1.3

`import QtQuick.Controls 2.5 as QQC2`

> ConfigGeneral.qml:126
> +stepSize: 100
> +to: 100
> +textFromValue: function(value) {

Add `editable: true` and an appropriate `valueFromText` converter

> BreezeMenuStyle.qml:6
> +import QtQuick.Controls.Styles 1.4
> +import QtQuick.Controls 2.8
>  

`import QtQuick.Controls 2.5 as QQC2`

> KeyboardButton.qml:6
>  
> -import QtQuick.Controls 1.3 as QQC
> +import QtQuick.Controls 2.8
>  

`import QtQuick.Controls 2.5 as QQC2`

> Main.qml:23
>  import QtQuick.Layouts 1.1
> -import QtQuick.Controls 1.1
> +import QtQuick.Controls 2.8
>  import QtGraphicalEffects 1.0

`import QtQuick.Controls 2.5 as QQC2`

> SessionButton.qml:25
>  
> -import QtQuick.Controls 1.3 as QQC
> +import QtQuick.Controls 2.8
>  

`import QtQuick.Controls 2.8 as QQC2`

> config.qml:25
>  import org.kde.kquickcontrolsaddons 2.0
> -import QtQuick.Controls 1.0 as QtControls
> +import QtQuick.Controls 2.8
>  

`import QtQuick.Controls 2.5 as QQC2`

> customwallpaper.qml:25
>  import org.kde.kquickcontrolsaddons 2.0
> -import QtQuick.Controls 1.0 as QtControls
> +import QtQuick.Controls 2.8
>  

`import QtQuick.Controls 2.5 as QQC2`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24798

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-20 Thread Jan Grulich

jgrulich added a comment.


  In D24732#550902 , @ngraham wrote:
  
  > So close! You don't need to create a `Rectangle` to give the ScrollView a 
white background; just set `Component.onCompleted: background.visible = true` 
on the scrollview itself. Here's an example of how it's done in the 
Notifications KCM: 
https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94
  
  
  It doesn't seem to work in my case.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24816: [Applet] Make spinboxes editable

2019-10-20 Thread Kai Uwe Broulik

broulik added a comment.


  Does it also need a `valueFromText` function then?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24816

To: ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24818: Filter invalid services in most used model

2019-10-20 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise there'll be a blank spot.
  
  BUG: 413178
  FIXED-IN: 5.17.1

TEST PLAN
  - Put a broken desktop file in the model, had it not show up
  
  (The actual crash is in tool tip manager but this patch makes it not show 
such items in the first place)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D24818

AFFECTED FILES
  sidebar/SidebarMode.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24720: [applets/systemtray] Rewrite popups with layouts

D24798: Migrate QQC1 to QQC2

D24265: support global edit mode

D24373: [KCM] Limit scale factor increment to 6.25% on X11

D24804: Fix regression in mobile wifi kcm

D24804: Fix regression in mobile wifi kcm

D24804: Fix regression in mobile wifi kcm

D24804: Fix regression in mobile wifi kcm

D24804: Fix regression in mobile wifi kcm

D24373: [KCM] Limit scale factor increment to 6.25% on X11

D24808: [mobile/wifi] Group networks by connection state

D24810: Ensure defintion of XDG_DATA_DIRS

D24808: [mobile/wifi] Group networks by connection state

D24810: Ensure defintion of XDG_DATA_DIRS

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

D24732: Rewrite AppChooser dialog

D24009: RFC: Make Breeze Dark darker

D24732: Rewrite AppChooser dialog

D24785: Store stashed model index as QPersistentModelIndex

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

D24814: [KCMs] Make spinboxes editable

D24815: [Weather] Make update time spinbox editable

D24816: [Applet] Make spinboxes editable

D24786: [GTK3] Add styles for libhandy widgets

D24798: Migrate QQC1 to QQC2

D24732: Rewrite AppChooser dialog

D24816: [Applet] Make spinboxes editable

D24818: Filter invalid services in most used model

28 matches

Site Navigation

Mail list logo

Footer information