D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D24942#556062 , @ngraham wrote:
  
  > Thanks, that fixes the issue. This works quite well now.
  >
  > Would be nice to address the bugs I filed before 5.18 is released so it 
really gets polished up all nice and shiny. :)
  
  
  Thanks for the confirmation! :)
  
  Definitely would, i'm endeavouring to run through the issues quick as 
possible :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

To: leinir, #plasma, #knewstuff, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  In D24744#550210 , @ngraham wrote:
  
  > In D24744#549568 , @broulik 
wrote:
  >
  > > Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK 
and drop the cursor to position radios
  >
  >
  > Yeah I'm working on exposing that for QWidgets apps in the General Behavior 
KCM.
  
  
  Is that configuration even needed? Most of non-qt and non-gtk apps are using 
default behavior - scroll to one "page" up or down. On gnome scroll behavior is 
the same by default (and I haven't found any way to configure it with dconf or 
gnome-tweaks, may be I'm missing something). Even more, there is a bug report, 
that this option does not work with Chromium-based browsers: 
https://bugs.kde.org/show_bug.cgi?id=411762. May be we should forget about that 
option, remove it from the view and always set it to "one page per click"?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, 
mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c21a8bd82ec2: Require and use the new NewStuffQuick 
Button component (authored by leinir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24942?vs=68958&id=69032

REVISION DETAIL
  https://phabricator.kde.org/D24942

AFFECTED FILES
  CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir, #plasma, #knewstuff, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24126: [GTK3] CSD windows show handles on .solid-csd

[Wolfgang Bauer]

wbauer added a comment.


  Could this be backported to 5.12 too maybe?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24126

To: cblack, #breeze, ngraham, ndavis
Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

5.18 kickoff meeting today

[Jonathan Riddell]

Plasma 5.18 kickoff meeting today in less than 4 hours at 14:00UTC/15:00CET

D24846: Port kcm icons to kconfigxt

[Benjamin Port]

bport updated this revision to Diff 69036.
bport added a comment.


  Take in consideration feedback (cache kicon call)
  Port to ManagedConfigModule

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=68498&id=69036

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24847: KCM Icons fix theme selected when we hit delete theme

[Benjamin Port]

bport updated this revision to Diff 69037.
bport added a comment.


  Take Nate feedback and do a proper fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24847?vs=68499&id=69037

REVISION DETAIL
  https://phabricator.kde.org/D24847

AFFECTED FILES
  kcms/icons/iconsmodel.cpp

To: bport, mart, ervin, #plasma, crossi
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Björn Feber]

GB_2 added a comment.


  I'd be fine with that (we could always add it later in the Application Style 
KCM when we have it for Qt).

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, 
mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24744: Remove unneeded options in GTK KCM

[Kai Uwe Broulik]

broulik added a comment.


  > remove it from the view and always set it to "one page per click"?
  
  Absolutely not.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, 
mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This removes quite a lot of uneeded code and fixes the automatic default
  handling from KConfigXT point of view (this was the wrong integration
  scheme with combo boxes).
  
  It also gives me a nice testing ground for a widget based KCM usable
  with kcmshell. :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25068

AFFECTED FILES
  kcms/qtquicksettings/kcmqtquicksettings.cpp
  kcms/qtquicksettings/kcmqtquicksettings.h
  kcms/qtquicksettings/kcmqtquicksettingswidget.ui
  kcms/qtquicksettings/renderer.kcfg

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25074: Disable the restore defaults button if the KCModule says so

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25074

AFFECTED FILES
  core/ModuleView.cpp

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25076: Force reevaluating state on pending deletion changes

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, bport, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This was missing and thus the apply button wouldn't get enabled in case
  of a pending deletion. This is due to this mechanism being outside of
  the KConfigXT realm.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25076

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp

To: ervin, #plasma, bport, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

[David Edmundson]

davidedmundson added a comment.


  That's significantly tidier!

INLINE COMMENTS

> renderer.kcfg:10
> +
> +
> +

Will this mean we write "automaticloop" to the config file?

If so, we'll need to change  the KQuickAddons::QtQuickSettings::init
As it passes the variables in the config directly to Qt envs, which wouldn't be 
ideal.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25068

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in renderer.kcfg:10
> Will this mean we write "automaticloop" to the config file?
> 
> If so, we'll need to change  the KQuickAddons::QtQuickSettings::init
> As it passes the variables in the config directly to Qt envs, which wouldn't 
> be ideal.

Nope. KConfigXT is so clever that if you write a value which is the default to 
it, it kills the key in the config file instead. :-)

This is why you always want KConfigXT btw, managing defaults is error prone, 
people forget to kill the key when they do readEntry/writeEntry manually... 
which means you got something in the config file when the default changes, so 
you don't see the new default.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25068

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24870: Apply autoplay prevention evasion also to document.createElement

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  IMO this looks uglier than multiline C macros, but ok...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24870

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24870: Apply autoplay prevention evasion also to document.createElement

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.




REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24870

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:101
>  
> -connect(m_model, &IconsModel::selectedThemeChanged, this, [this] {
> -m_selectedThemeDirty = true;
> -setNeedsSave(true);
> -});
> -connect(m_model, &IconsModel::pendingDeletionsChanged, this, [this] {
> -setNeedsSave(true);
> -});
> +connect(m_model, SIGNAL(selectedThemeChanged()), this, 
> SLOT(_k_settingsChanged()));
> +connect(m_model, SIGNAL(pendingDeletionsChanged()), this, 
> SLOT(_k_settingsChanged()));

Shouldn't you be able to remove that connect? I'd expect this signal trickling 
down to changing the settings object, wouldn't it?

> main.cpp:102
> +connect(m_model, SIGNAL(selectedThemeChanged()), this, 
> SLOT(_k_settingsChanged()));
> +connect(m_model, SIGNAL(pendingDeletionsChanged()), this, 
> SLOT(_k_settingsChanged()));
>  

Now that my ManagedConfigModule change landed, you should use a proper compile 
time check connect to settingsChanged here.

> main.cpp:110
>  {
> +foreach (KIconTheme* theme, m_kicon_theme_map) {
> +delete theme;

Don't do foreach. Instead write:

  for (auto theme : qAsConst(m_iconThemeCache)) {

Or even better, just use qDeleteAll:

  qDeleteAll(m_iconThemeCache)

Or even better yet : try to use std::unique_ptr, std::shared_ptr or 
QScopedPointer as values in your associative container (I let you check which 
one fits best).

> main.cpp:137
>  {
> -return m_iconSizes[group];
> -}
> -
> -void IconModule::setIconSize(int group, int size)
> -{
> -if (iconSize(group) == size) {
> -return;
> +QString themeName(m_model->selectedTheme());
> +if (!m_kicon_theme_map.contains(m_model->selectedTheme())) {

nitpick, I find = more readable in such a context (and less prone to the most 
vexing parse since you don't use curly braces init).

I'd write: `const auto themeName = m_model->selectedTheme();`

> main.cpp:138
> +QString themeName(m_model->selectedTheme());
> +if (!m_kicon_theme_map.contains(m_model->selectedTheme())) {
> +m_kicon_theme_map.insert(themeName, new KIconTheme(themeName));

Couldn't you fill the cache as soon as the selected theme changes instead? This 
way you wouldn't need to modify your cache here.

> main.h:34
>  #include 
> +#include 
>  

s/QMap/QHash/

> main.h:83
>  
> -Q_INVOKABLE int iconSize(int group) const;
> -Q_INVOKABLE void setIconSize(int group, int size);
> -Q_INVOKABLE QList availableIconSizes(int group) const;
> +Q_INVOKABLE QList availableIconSizes(int group);
>  

Killing the const here is semantically wrong IMO.

> main.h:117
>  
> -QVector m_iconSizes;
> +QMap m_kicon_theme_map;
>  

You don't need the keys to be sorted, so please use QHash instead.

Also we do camel case here, not snake case. :-)

> IconSizePopup.qml:81
>  
> +property var sizesMap: [
> +{"settingName":"desktopSize", "displayName": 
> i18n("Desktop")},

I think I'd have expected that logic on the C++ side actually. Others might 
disagree. :-)

> IconSizePopup.qml:91
> +function sizeDisplayName(index) {
> +index = index <0 ? 0 : index;
> +return iconTypeList.sizesMap[index].displayName;

Urgh, I'd assert than silently swallow that I think.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24847: KCM Icons fix theme selected when we hit delete theme

[Kevin Ottens]

ervin added a comment.


  nitpick, but otherwise LGTM, giving time to others (in particular Nate) to 
chip in.

INLINE COMMENTS

> iconsmodel.cpp:87
>  }
> -
>  emit pendingDeletionsChanged();

I'd say keep the empty line please.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25076: Force reevaluating state on pending deletion changes

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:35c84cb5f9d2: Force reevaluating state on pending 
deletion changes (authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25076?vs=69046&id=69050

REVISION DETAIL
  https://phabricator.kde.org/D25076

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp

To: ervin, #plasma, bport, mart, davidedmundson, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:61cd3d4b19a9: Adjust QtQuickSettings KCM to use KConfigXT 
in full (authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25068?vs=69038&id=69049

REVISION DETAIL
  https://phabricator.kde.org/D25068

AFFECTED FILES
  kcms/qtquicksettings/kcmqtquicksettings.cpp
  kcms/qtquicksettings/kcmqtquicksettings.h
  kcms/qtquicksettings/kcmqtquicksettingswidget.ui
  kcms/qtquicksettings/renderer.kcfg

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 472 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/472/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 30 Oct 2019 12:17:52 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 3044 lines...][2019-10-30T12:29:41.848Z]   |~^~[2019-10-30T12:29:41.848Z] [ 48%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/scmeditoroptions.cpp.o[2019-10-30T12:29:42.348Z] [ 48%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/globalshortcuts.cpp.o[2019-10-30T12:29:42.348Z] make[2]: *** [kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/build.make:88: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcm.cpp.o] Error 1[2019-10-30T12:29:42.348Z] make[1]: *** [CMakeFiles/Makefile2:5297: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/all] Error 2[2019-10-30T12:29:42.348Z] make[1]: *** Waiting for unfinished jobs[2019-10-30T12:29:43.398Z] [ 48%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/select_scheme_dialog.cpp.o[2019-10-30T12:29:43.897Z] [ 48%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/scmeditorcolors.cpp.o[2019-10-30T12:29:44.946Z] [ 48%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kglobalaccel_interface.cpp.o[2019-10-30T12:29:45.444Z] [ 48%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/styleconfdialog.cpp.o[2019-10-30T12:29:47.127Z] [ 48%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/kcmstyle.cpp.o[2019-10-30T12:29:48.788Z] [ 48%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/scmeditoreffects.cpp.o[2019-10-30T12:29:50.446Z] [ 49%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kglobalaccel_component_interface.cpp.o[2019-10-30T12:29:51.496Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In lambda function:[2019-10-30T12:29:51.496Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-30T12:29:51.496Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-30T12:29:51.496Z]   |  ^[2019-10-30T12:29:51.496Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-30T12:29:51.496Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-30T12:29:51.496Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-30T12:29:51.496Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-30T12:29:51.496Z]   |^~[2019-10-30T12:29:51.496Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-30T12:29:51.496Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-30T12:29:51.496Z]   |  ^[2019-10-30T12:29:51.496Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-30T12:29:51.496Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-30T12:29:51.496Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-30T12:29:51.496Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-30T12:29:51.496Z]   |^~[2019-10-30T12:29:51.496Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In member function ���virtual void KCMStyle::save()���:[2019-10-30T12:29:51.496Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:333:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-30T12:29:51.496Z]   333 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-30T12:29:51.496Z]   |  ^[2019-10-30T12:29:51.496Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-30T12:29:51.496Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 185 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/185/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 30 Oct 2019 12:17:52 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 3461 lines...][2019-10-30T12:30:58.204Z]   ^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-30T12:30:58.204Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-30T12:30:58.204Z]^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-30T12:30:58.204Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-30T12:30:58.204Z]  ^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:20: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-30T12:30:58.204Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-30T12:30:58.204Z]^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-30T12:30:58.204Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-30T12:30:58.204Z]   ^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-30T12:30:58.204Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-30T12:30:58.204Z]^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-30T12:30:58.204Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-30T12:30:58.204Z]  ^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:30: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-30T12:30:58.204Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-30T12:30:58.204Z]  ^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-30T12:30:58.204Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-30T12:30:58.204Z]^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-30T12:30:58.204Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-30T12:30:58.204Z]  ^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:56: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-30T12:30:58.204Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-30T12:30:58.204Z]^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-30T12:30:58.204Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-30T12:30:58.204Z]   ^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-30T12:30:58.204Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-30T12:30:58.204Z]^[2019-10-30T12:30:58.204Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-30T12:30:58.204Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-30T12:30:58.204Z]   

D24856: Add a .desktop file to ksplashqml

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ksplashqml.desktop.cmake:7
> +Type=Application
> +X-KDE-Wayland-Interfaces=org_kde_plasma_window_management
> +

Are you sure the wayland interface is required?

It seems like the warning is broken, so we could just as well remove it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24856

To: meven, apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[Cyril Rossi]

crossi updated this revision to Diff 69053.
crossi added a comment.


  Remove assignement to currentIndex.
  Add a C++ bypass to setCurrentIndex without breaking the binding.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25000?vs=68874&id=69053

REVISION DETAIL
  https://phabricator.kde.org/D25000

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  plugin/CMakeLists.txt
  plugin/kpropertywriter.cpp
  plugin/kpropertywriter.h
  plugin/qqc2desktopstyleplugin.cpp

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24744: Remove unneeded options in GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  "Absolutely not" is right. We can't remove this option entirely; that would 
be a big regression. If not all apps respect it, we need to fix those apps.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24744

To: gikari, #vdg, #plasma
Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, 
mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D24126: [GTK3] CSD windows show handles on .solid-csd

[Nathaniel Graham]

ngraham added a comment.


  Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24126

To: cblack, #breeze, ngraham, ndavis
Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24126: [GTK3] CSD windows show handles on .solid-csd

[Wolfgang Bauer]

wbauer added a comment.


  In D24126#556709 , @ngraham wrote:
  
  > Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.
  
  
  Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the 
gtk.css in the first place.
  
  It should be possible to adjust that directly though, no?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24126

To: cblack, #breeze, ngraham, ndavis
Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24126: [GTK3] CSD windows show handles on .solid-csd

[Nathaniel Graham]

ngraham added a comment.


  Yeah, probably.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24126

To: cblack, #breeze, ngraham, ndavis
Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24126: [GTK3] CSD windows show handles on .solid-csd

[Carson Black]

cblack added a comment.


  In D24126#556711 , @wbauer wrote:
  
  > In D24126#556709 , @ngraham 
wrote:
  >
  > > Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 
IIRC.
  >
  >
  > Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the 
gtk.css in the first place.
  >
  > It should be possible to adjust that directly though, no?
  
  
  This wouldn't be too hard to backport the results by hand.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24126

To: cblack, #breeze, ngraham, ndavis
Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Almost there! Glad we're getting near a proper fix. Can you confirm this 
works with *and* without D24916  applied?
  Can you also confirm this doesn't break the KScreen KCM? (as mentioned in 
Kai's comment on D24916 ).
  
  I want to make sure we don't introduce a regression for those who had started 
to workaround that bug on their side.

INLINE COMMENTS

> kpropertywriter.h:1
> +/*
> + *   Copyright (C) 2019 Cyril Rossi 

This file should be named kpropertywriter_p.h since it's not installed and the 
class not exported from a library.

> kpropertywriter.h:39
> +
> +Q_INVOKABLE bool writeProperty(QVariant value);
> +

const QVariant &

> kpropertywriter.h:43
> +void setTarget(QObject *target);
> +void setPropertyName(QString propertyName);
> +

const QString &

> kpropertywriter.h:47
> +void targetChanged(QObject *target);
> +void propertyNameChanged(QString propertyName);
> +

const QString &

> kpropertywriter.h:50
> +private:
> +QObject *m_target = nullptr;
> +QString m_propertyName;

If you want to play like this, you could have had a "using QObject::QObject;" 
for the ctor declaration and have no ctor definition in the cpp file. ;-)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25000

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24916: KCM style : fix combobox that weren't updated after user made change

[Kevin Ottens]

ervin added a comment.


  Once we got D25000  completed, please 
remember to abandon that one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24916

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Plasma 5.18 features document

[Bhushan Shah]

https://share.kde.org/s/6AfZWwfcweKHi68

please add new features!

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D25000: Do not assign combobox currentIndex as it breaks binding.

[Cyril Rossi]

crossi updated this revision to Diff 69055.
crossi added a comment.


  Missing const ref, rename private header accordingly

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25000?vs=69053&id=69055

REVISION DETAIL
  https://phabricator.kde.org/D25000

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  plugin/CMakeLists.txt
  plugin/kpropertywriter.cpp
  plugin/kpropertywriter_p.h
  plugin/qqc2desktopstyleplugin.cpp

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> main.qml:268
> -property: "visible"
> -value: plasmoid.configuration.showToolbox
> -}

A conf update isn't needed as it's this code hiding the toolbox when disabled, 
so without it it will just always show

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25053: Don't show "Customize Layout..." menu item in panel context menu

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:968a136f4243: Don't show "Customize 
Layout..." menu item in panel context menu (authored by GB_2).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25053?vs=68995&id=69056

REVISION DETAIL
  https://phabricator.kde.org/D25053

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: GB_2, #plasma, #vdg, mart, ngraham
Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24855: Rename "Close Edit Mode" tooltip to "Finish Customizing Layout"

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a74c3657a071: Rename "Close Edit Mode" tooltip 
to "Finish Customizing Layout" (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24855?vs=68986&id=69057

REVISION DETAIL
  https://phabricator.kde.org/D24855

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:268
> A conf update isn't needed as it's this code hiding the toolbox when 
> disabled, so without it it will just always show

Ah of course!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 186 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/186/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 30 Oct 2019 14:56:43 +
 Build duration:
2 min 51 sec and counting
   CONSOLE OUTPUT
  [...truncated 3189 lines...][2019-10-30T14:59:16.155Z]^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-30T14:59:16.155Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-30T14:59:16.155Z]  ^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:340:34: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-30T14:59:16.155Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-30T14:59:16.155Z]  ^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-30T14:59:16.155Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-30T14:59:16.155Z]^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-30T14:59:16.155Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-30T14:59:16.155Z]  ^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/style/kcmstyle.cpp:340:60: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-30T14:59:16.155Z] KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);[2019-10-30T14:59:16.155Z]^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-30T14:59:16.155Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-30T14:59:16.155Z]   ^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-30T14:59:16.155Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-30T14:59:16.155Z]^[2019-10-30T14:59:16.155Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-30T14:59:16.155Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-30T14:59:16.155Z]  ^[2019-10-30T14:59:16.449Z] 1 error generated.[2019-10-30T14:59:16.450Z] gmake[2]: *** [kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/build.make:88: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcm.cpp.o] Error 1[2019-10-30T14:59:16.450Z] gmake[1]: *** [CMakeFiles/Makefile2:6081: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/all] Error 2[2019-10-30T14:59:16.450Z] gmake[1]: *** Waiting for unfinished jobs[2019-10-30T14:59:16.450Z] [ 55%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/globalshortcuts.cpp.o[2019-10-30T14:59:16.744Z] 13 warnings generated.[2019-10-30T14:59:16.744Z] [ 55%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/select_scheme_dialog.cpp.o[2019-10-30T14:59:17.013Z] [ 55%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kglobalaccel_interface.cpp.o[2019-10-30T14:59:17.013Z] [ 55%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/symbol_parser.cpp.o[2019-10-30T14:59:17.013Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keys/kglobalshortcutseditor.cpp:21:[2019-10-30T14:59:17.013Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/build/kcms/keys/ui_select_application.h:40:38: warning: 'KFilterProxySearchLine' is deprecated: Since 5.50. See class API docs [-Wdeprecated-declarations][2019-10-30T14:59:17.013Z] kfilterproxysearchline = new KFilterProxySearchLine(SelectApplicationDialog);[2019-10-30T14:59:17.013Z]  ^[2019-10-30T14:59:17.013Z] /usr/home/jenkins/install-prefix/include/KF5/KItemViews/kfilterproxysearchline.h:57:5: note: 'KFilterProxySearchLine' has been explicitly marked 

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 473 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/473/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 30 Oct 2019 14:56:43 +
 Build duration:
5 min 55 sec and counting
   CONSOLE OUTPUT
  [...truncated 3016 lines...][2019-10-30T15:02:08.449Z] [ 46%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcm.cpp.o[2019-10-30T15:02:10.111Z] [ 46%] Building CXX object kcms/standard_actions/CMakeFiles/kcm_standard_actions.dir/standard_actions_module.cpp.o[2019-10-30T15:02:10.612Z] [ 46%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/kcmstyle.cpp.o[2019-10-30T15:02:11.665Z] [ 46%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysymhelper.cpp.o[2019-10-30T15:02:12.165Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/desktoptheme/kcm.cpp: In member function ���void KCMDesktopTheme::setPendingDeletion(int, bool)���:[2019-10-30T15:02:12.165Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/desktoptheme/kcm.cpp:119:5: error: ���settingsChanged��� was not declared in this scope; did you mean ���buttonsChanged���?[2019-10-30T15:02:12.165Z]   119 | settingsChanged();[2019-10-30T15:02:12.165Z]   | ^~~[2019-10-30T15:02:12.165Z]   | buttonsChanged[2019-10-30T15:02:13.833Z] make[2]: *** [kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/build.make:88: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/kcm.cpp.o] Error 1[2019-10-30T15:02:13.833Z] make[1]: *** [CMakeFiles/Makefile2:5297: kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/all] Error 2[2019-10-30T15:02:13.833Z] make[1]: *** Waiting for unfinished jobs[2019-10-30T15:02:13.833Z] [ 46%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysym2ucs.cpp.o[2019-10-30T15:02:13.833Z] [ 46%] Linking CXX shared module ../../bin/kcm_standard_actions.so[2019-10-30T15:02:13.833Z] [ 46%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/stylesmodel.cpp.o[2019-10-30T15:02:14.332Z] [ 47%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/debug.cpp.o[2019-10-30T15:02:14.332Z] [ 47%] Built target kcm_standard_actions[2019-10-30T15:02:14.332Z] [ 47%] Building CXX object kcms/style/CMakeFiles/kcm_style.dir/previewitem.cpp.o[2019-10-30T15:02:14.835Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In lambda function:[2019-10-30T15:02:14.835Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-30T15:02:14.835Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-30T15:02:14.835Z]   |  ^[2019-10-30T15:02:14.835Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-30T15:02:14.835Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-30T15:02:14.835Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-30T15:02:14.835Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-30T15:02:14.835Z]   |^~[2019-10-30T15:02:14.835Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:237:74: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2019-10-30T15:02:14.835Z]   237 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2019-10-30T15:02:14.835Z]   |  ^[2019-10-30T15:02:14.835Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2019-10-30T15:02:14.835Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:50:[2019-10-30T15:02:14.835Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2019-10-30T15:02:14.835Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-30T15:02:14.835Z]   |^~[2019-10-30T15:02:14.835Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp: In member function ���virtual void KCMStyle::save()���:[2019-10-30T15:02:14.835Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/style/kcmstyle.cpp:333:74: warning: ���static void KGlobalSettings::emitCha

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  In D25055#556751 , @mart wrote:
  
  > I would prefer keeping the press to move stuff
  
  
  As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  I would prefer keeping the press to move stuff

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Björn Feber]

GB_2 added a comment.


  In D25055#556751 , @mart wrote:
  
  > I would prefer keeping the press to move stuff
  
  
  Is there a reason to disable it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  In D25055#556752 , @ngraham wrote:
  
  > In D25055#556751 , @mart wrote:
  >
  > > I would prefer keeping the press to move stuff
  >
  >
  > As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?
  
  
  it makes the handles appear on mouse over, like they did in kde4, i spent a 
lot of time to make that work in the new layout

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Björn Feber]

GB_2 added a comment.


  I wonder, can that be added to mouse actions instead of a page with only one 
option?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  In D25055#556756 , @GB_2 wrote:
  
  > I wonder, can that be added to mouse actions instead of a page with only 
one option?
  
  
  makes sense

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[David Edmundson]

davidedmundson added a comment.


  There's a Plasma rule that if we're working round a Qt bug, there should be a 
Qt bug created and linked before accepting a workaround.
  
  From the sounds of it we want a QQuickControls::ComboBox::setIndex(int) 
invokable that doesn't update the binding?
  Or is it a more generic problem of somehow exposing 
QQmlPropertyData::WriteFlags ?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25000

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kpropertywriter_p.h:26
> +
> +class KPropertyWriter : public QObject
> +{

Throwing out another option

  class KPropertyWriter : public QObject, public QQmlPropertyValueSource
  {
  Q_INVOKABLE bool writeProperty(QVariant value);
  }
  
  writeProperty(QVariant) {
object()->setProperty(name(), value());
// we can't use property().write() as that'll break the binding
  }
  
  
  PropertyWriter on currentIndex {
 id: controlRootWriter
  }

Though it's basically the same thing, so don't feel you have to, just wanted to 
share the suggestion as it reduces two properties.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25000

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  In D25055#556755 , @mart wrote:
  
  > In D25055#556752 , @ngraham 
wrote:
  >
  > > In D25055#556751 , @mart wrote:
  > >
  > > > I would prefer keeping the press to move stuff
  > >
  > >
  > > As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?
  >
  >
  > it makes the handles appear on mouse over, like they did in kde4, i spent a 
lot of time to make that work in the new layout
  
  
  Can you be specific about how the behavior gets invoked? For me, when not in 
edit mode, the handles now always appear on hover, while outside of edit mode, 
the handles now only appear on press-and-hold. None of this changes regardless 
of whether or not the press-and-hold setting in Tweaks is checked.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24847: KCM Icons fix theme selected when we hit delete theme

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The behavior is now fine, but your ability to actually delete icon themes has 
regressed. Once you click on a delegate's inline delete button, the apply 
button at the bottom of the page never becomes enabled.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi, ngraham
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein, GB_2
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

Notes from 5.18 kickoff meeting

[Jonathan Riddell]

apol, nate, veggero, romang, fvogt, gb_2, bhushan, veqz, ahiemstra,
nicofee, notmart, kbroulik, leinir

Discuss VDG priorities: Breeze theme evolution
https://phabricator.kde.org/T10891.  also (Re)define modes when editing
panels and widgets,
Discuss themes being installed by default
Discussed 5.17.  There were some regressions and crashers.  kscreen
refactor added to this.
We pondered restricting features and refactors but decided not to.  David
says he's up for a feature freeze for the next LTS.

We should find ways to help people test betas, we often start getting bug
reports the day plasma gets released
We are happy with the schedule, freeze and beta mid-january, release feb
11th

We will support Qt 5.12 and 5.13
Soft feature freeze at same time as repo freeze, no 'take the piss new
features' after this [action jriddell]

share.kde.org doc to be made for 5.18 pronto [action bshah]
Announce to get written for beta, any rewrite for final will be blocked.
Dot story just a copy+paste of the final announce.
Web stats show beta announce more read than the final one

Reviewed some old Workboard items

New Workboard items..
 plasma-nano and plasma-phone-components to be part of release but
announced separately and not part of the Plasma desktop or the LTS [action
jriddell]
 to be moved to kdereview [action bshah]
  output rotation is certainly a TODO item for 5.18
  ksysguard work by d_ed
  DRM
  apol: regarding kwin, I also have a poc for for stylus but it's not
working that well yet, definitely not blocking anyway
  ddcutil needs cmake fixes, bshah wants pinged with it

D25081: [kcms/krdb] Fix krdb executable

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  krdb is mostly a library used by some KCMs.
  
  It also exists as an executable script that works by invoking kcminit
  style which in turn runs the krdb code.
  
  This broke after a port that involved a rename.

TEST PLAN
  krdb on a distro that doesn't have old files
  It ran instead of giving a warning

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25081

AFFECTED FILES
  kcms/krdb/ad/krdb

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KF6 Sprint

[Volker Krause]

Hi,

we have a date and venue by now: November 22 - 24 at the MBition office in 
Berlin (Dovestraße 1, 10587 Berlin), that's right after the Qt Contributor 
Summit to reduce travel overhead a bit. Thanks to Eike and Agustin for making 
this possible!

Please subscribe to https://phabricator.kde.org/T11535 and indicate there if 
you are going to attend. And please encourage people not on the list yet that 
should be there to attend.

Help in organizing this is also still very much needed (e.g. finding 
accommodation and dealing with e.V. reimbursements), despite how this may look 
like, I'm just passing messages here ;-)

I'd also again encourage everyone to put topics and ideas for KF6 into the KF6 
workboard (https://phabricator.kde.org/project/board/310/query/all/), which 
will help to make the sprint as effective as possible.

Thanks,
Volker


On Sunday, 15 September 2019 13:14:28 CET Volker Krause wrote:
> Hi,
> 
> as you might have seen in David's summary of the KF6 BoF at Akademy
> (https://
> mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html),
> there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we
> had in Randa a few years back, to determine what we actually want to
> achieve with KF6 beyond just porting to Qt6.
> 
> If you are interested please subscribe to https://phabricator.kde.org/T11535
> and indicate your interest to participate, as well as times that would work
> for you. I'm not just looking at the current KF5 contributors for this, but
> also those of you heavily using KF5.
> 
> If you are willing to help organize the sprint, please indicate so there
> too, help with that would be greatly appreciated (I'm not organizing this,
> I'm just writing this email because Albert asked me too ;-) ).
> 
> With Qt 6 planned for Nov 2020 we are probably looking at a 18-24 month time
> frame towards KF6, so it's time to get this going.
> 
> Regards,
> Volker



signature.asc
Description: This is a digitally signed message part.

D24847: KCM Icons fix theme selected when we hit delete theme

[Benjamin Port]

bport added a comment.


  Indeed don't know why even if isSaveNeeded return true, button is not 
updated. I will investigate
  Thanks for the catch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi, ngraham
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[Kevin Ottens]

ervin added a comment.


  In D25000#556761 , @davidedmundson 
wrote:
  
  > There's a Plasma rule that if we're working round a Qt bug, there should be 
a Qt bug created and linked before accepting a workaround.
  >
  > From the sounds of it we want a QQuickControls::ComboBox::setIndex(int) 
invokable that doesn't update the binding?
  >  Or is it a more generic problem of somehow exposing 
QQmlPropertyData::WriteFlags ?
  
  
  It's the former, not the latter. And good luck having setIndex invokable, it 
would never go through a Qt review IMHO (and for good reason). Now we need this 
really because our own combo style insists on emulating a corner case of 
QComboBox behavior, it's fairly unusual and specific.
  I don't think it warrants putting something in Qt directly.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25000

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25082: [applets/weather] Reduce label minimum width to accommodate narrow vertical panels

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The temperature label's minimum width was set high enough to overflow in a 
narrow
  vertical panel. This patch reduces it, without regressing the layout 
elsewhere.
  
  BUG: 413592
  FIXED-IN: 5.17.3

TEST PLAN
  F7695929: demo-2019-10-30_11.38.16.webm 

REPOSITORY
  R114 Plasma Addons

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D25082

AFFECTED FILES
  applets/weather/package/contents/ui/IconAndTextItem.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kpropertywriter_p.h:26
> Throwing out another option
> 
>   class KPropertyWriter : public QObject, public QQmlPropertyValueSource
>   {
>   Q_INVOKABLE bool writeProperty(QVariant value);
>   }
>   
>   writeProperty(QVariant) {
> object()->setProperty(name(), value());
> // we can't use property().write() as that'll break the binding
>   }
>   
>   
>   PropertyWriter on currentIndex {
>  id: controlRootWriter
>   }
> 
> Though it's basically the same thing, so don't feel you have to, just wanted 
> to share the suggestion as it reduces two properties.

Didn't think about that one, clever trick indeed. :-)

That being said I think it'd be more work in the end, indeed setTarget is pure 
virtual in there, and also I'm not sure that calling write() on QQmlProperty 
doesn't break bindings.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25000

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25000: Do not assign combobox currentIndex as it breaks binding.

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Please just wait a bit before pushing to give David a 
chance to object to my comments. ;-)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25000

To: crossi, #plasma, ervin, mart, bport, broulik
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24126: [GTK3] CSD windows show handles on .solid-csd

[Wolfgang Bauer]

wbauer added a comment.


  FTR, we got a downstream bug report about this for openSUSE Leap 15.1 (which 
ships Plasma 5.12 LTS):
  https://bugzilla.opensuse.org/show_bug.cgi?id=1155387
  
  That's mainly why I asked... ;-)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24126

To: cblack, #breeze, ngraham, ndavis
Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  Approach is fine, but please move the MouseArea into the 
audioStreamIconLoader's source component so it's not always instantiated even 
when it's not needed. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein, GB_2
Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 419 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/419/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Oct 2019 11:06:06 +
 Build duration:
1 day 7 hr and counting

D24743: Update GTK settings according to Plasma settings

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> configeditor.cpp:49
> +QString 
> configLocation(QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation));
> +QString gtk3ConfigPath(configLocation + "/gtk-3.0/settings.ini");
> +

Better wrap the const char* in a QStringLiteral.

Also, but more of a nitpick this time: style wise I'd favor using = for those 
initialization (and others in the file) than parenthesis. It gets too close the 
most vexing parse territory, I'd rather not potentially expose a future 
developer touching that file to it.

> configeditor.cpp:81
> +{
> +QString gtkrcPath(QDir::homePath() + "/.gtkrc-2.0");
> +QFile gtkrc(gtkrcPath);

QStringLiteral please.

> configeditor.cpp:96
> +} else {
> +return "";
> +}

QString() or {} instead of ""

> configeditor.cpp:102
> +{
> +const QRegularExpression regExp(paramName + "=[^\n]*($|\n)");
> +

QStringLiteral please

There are more of those in the file, I'll stop pointing them out. ;-)

> configeditor.h:45
> +QString readFileContents(QFile >krc) const;
> +pid_t getPidOfXSettingsd() const;
> +};

We don't prefix getters with get.

> configvalueprovider.cpp:35
> +
> +KSharedConfigPtr 
> config(KSharedConfig::openConfig(QStringLiteral("kdeglobals")));
> +KConfigGroup configGroup(config->group(QStringLiteral("General")));

I will contradict my previous comment about making those functions static or 
turning into a namespace. I think it'd be better to avoid creating and ditching 
those KSharedConfig instances at each call, so why not instantiate it when 
ConfigValueProvider is created?

You might have to load() from the config at right point in times though.

> configvalueprovider.h:37
> +
> +QString getConfigFontName() const;
> +QString getConfigIconThemeName() const;

We don't prefix getters with get

Beside none of those have any state AFAICT, why not make them static or turn 
this into a namespace?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24126: [GTK3] CSD windows show handles on .solid-csd

[David Edmundson]

davidedmundson added a comment.


  Code wise. Very sensible +++
  Good to know gtk thought about our case.
  
  Pixel pushing details I'll leave up to the vdg, but +1

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24126

To: cblack, #breeze, ngraham, ndavis
Cc: davidedmundson, wbauer, ngraham, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 187 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/187/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 02:25:13 +
 Build duration:
2 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 3328 lines...][2019-10-31T02:27:17.786Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T02:27:17.786Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T02:27:17.786Z]^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T02:27:17.786Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T02:27:17.786Z]  ^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:20: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T02:27:17.786Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-31T02:27:17.786Z]^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T02:27:17.786Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T02:27:17.786Z]   ^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T02:27:17.786Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T02:27:17.786Z]^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T02:27:17.786Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T02:27:17.786Z]  ^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:30: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2019-10-31T02:27:17.786Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-31T02:27:17.786Z]  ^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2019-10-31T02:27:17.786Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2019-10-31T02:27:17.786Z]^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T02:27:17.786Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T02:27:17.786Z]  ^[2019-10-31T02:27:17.786Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/lookandfeel/kcm.cpp:456:56: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2019-10-31T02:27:17.787Z] KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);[2019-10-31T02:27:17.787Z]^[2019-10-31T02:27:17.787Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2019-10-31T02:27:17.787Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2019-10-31T02:27:17.787Z]   ^[2019-10-31T02:27:17.787Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2019-10-31T02:27:17.787Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2019-10-31T02:27:17.787Z]^[2019-10-31T02:27:17.787Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2019-10-31T02:27:17.787Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2019-10-31T02:27:17.787Z]   

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/20/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 31 Oct 2019 04:33:33 +
 Build duration:
18 min and counting
   CONSOLE OUTPUT
  [...truncated 323 lines...][2019-10-31T04:50:50.349Z]   warning.[2019-10-31T04:50:50.349Z] [2019-10-31T04:50:50.349Z]   Quoted variables like "MSVC" will no longer be dereferenced when the policy[2019-10-31T04:50:50.349Z]   is set to NEW.  Since the policy is not set the OLD behavior will be used.[2019-10-31T04:50:50.349Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-10-31T04:50:50.349Z] [2019-10-31T04:50:54.592Z] C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- atspi (LoadError)[2019-10-31T04:50:54.592Z] 	from C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'[2019-10-31T04:50:54.592Z] 	from -e:1:in `'[2019-10-31T04:50:54.592Z] -- The following REQUIRED packages have been found:[2019-10-31T04:50:54.592Z] [2019-10-31T04:50:54.592Z]  * ECM (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * Qt5Core[2019-10-31T04:50:54.592Z]  * Qt5Gui (required version >= 5.13.0)[2019-10-31T04:50:54.592Z]  * Qt5Widgets[2019-10-31T04:50:54.592Z]  * Qt5DBus[2019-10-31T04:50:54.592Z]  * Qt5Concurrent[2019-10-31T04:50:54.592Z]  * Qt5 (required version >= 5.12.0)[2019-10-31T04:50:54.592Z]  * Gettext[2019-10-31T04:50:54.592Z]  * KF5I18n (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5CoreAddons (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5Service (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5ConfigWidgets (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5JobWidgets (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5KIO (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5Crash (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5Completion (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5WidgetsAddons (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5Wallet (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5Notifications (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5IdleTime (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5WindowSystem (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KF5 (required version >= 5.61.0)[2019-10-31T04:50:54.592Z]  * KDEWin[2019-10-31T04:50:54.592Z]  * Qt5Test[2019-10-31T04:50:54.592Z] [2019-10-31T04:50:54.592Z] -- The following features have been disabled:[2019-10-31T04:50:54.592Z] [2019-10-31T04:50:54.592Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2019-10-31T04:50:54.592Z] [2019-10-31T04:50:54.592Z] -- The following RECOMMENDED packages have not been found:[2019-10-31T04:50:54.592Z] [2019-10-31T04:50:54.592Z]  * Qt5X11Extras (required version >= 5.12.0)[2019-10-31T04:50:54.592Z]Recommended for better integration on X11.[2019-10-31T04:50:54.592Z] [2019-10-31T04:50:54.592Z] -- Configuring done[2019-10-31T04:51:04.728Z] -- Generating done[2019-10-31T04:51:05.317Z] -- Build files have been written to: C:/CI/workspace/Plasma/drkonqi/kf5-qt5 WindowsMSVCQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-10-31T04:51:06.393Z] [2019-10-31T04:51:06.393Z] C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-10-31T04:51:07.389Z] **[2019-10-31T04:51:07.389Z] ** Visual Studio 2019 Developer Command Prompt v16.3.0[2019-10-31T04:51:07.389Z] ** Copyright (c) 2019 Microsoft Corporation[2019-10-31T04:51:07.389Z] **[2019-10-31T04:51:17.641Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-10-31T04:51:17.641Z] [2019-10-31T04:51:17.641Z] jom 1.1.3 - empower your cores[2019-10-31T04:51:17.641Z] [2019-10-31T04:51:17.955Z] jom: parallel job execution disabled for Makefile[2019-10-31T04:51:17.955Z] Scanning dependencies of target lsb_release_autogen[2019-10-31T04:51:17.955Z] Scanning dependencies of target kdbgwin_autogen[2019-10-31T04:51:17.955Z] Scanning dependencies of target qbugzilla_autogen[2019-10-31T04:51:17.955Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-10-31T04:51:17.955Z] Scanning dependencies of target crashtest_autogen[2019-10-31T04:51:17.955Z] [  3%] Automatic MOC for target qbugzilla[2019-10-31T04:51:18.317Z] [  0%] Automatic MOC for target lsb_release[2019-10-31T04:51:18.317Z] [  4%] Built target lsb_release_autogen[2019-10-31T04:51:18.734Z] [  4%] Automatic MOC for target cr

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 188 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/188/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 31 Oct 2019 04:35:04 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 3206 lines...][2019-10-31T04:58:22.898Z] Scanning dependencies of target kcm_keys[2019-10-31T04:58:22.898Z] [ 54%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kcm_keys_autogen/mocs_compilation.cpp.o[2019-10-31T04:58:23.163Z] [ 54%] Building CXX object kcms/desktoptheme/CMakeFiles/kcm_desktoptheme.dir/desktopthemesettings.cpp.o[2019-10-31T04:58:23.163Z] [ 54%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/previewwidget.cpp.o[2019-10-31T04:58:23.420Z] [ 55%] Generating ui_smserverconfigdlg.h[2019-10-31T04:58:23.420Z] [ 55%] Generating login1_manager.cpp, login1_manager.h[2019-10-31T04:58:23.420Z] [ 55%] Generating login1_manager.moc[2019-10-31T04:58:23.420Z] [ 56%] Linking CXX shared module ../../bin/kcm_style.so[2019-10-31T04:58:23.698Z] Scanning dependencies of target kcm_smserver[2019-10-31T04:58:23.698Z] [ 56%] Built target kcm_style[2019-10-31T04:58:23.698Z] [ 56%] Building CXX object kcms/ksmserver/CMakeFiles/kcm_smserver.dir/kcm_smserver_autogen/mocs_compilation.cpp.o[2019-10-31T04:58:23.698Z] [ 56%] Building CXX object kcms/standard_actions/CMakeFiles/kcm_standard_actions.dir/standard_actions_module.cpp.o[2019-10-31T04:58:23.698Z] [ 57%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/kglobalshortcutseditor.cpp.o[2019-10-31T04:58:24.294Z] [ 58%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysymhelper.cpp.o[2019-10-31T04:58:24.294Z] [ 58%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysym2ucs.cpp.o[2019-10-31T04:58:24.294Z] [ 58%] Building CXX object kcms/colors/editor/CMakeFiles/kcolorschemeeditor.dir/setpreviewwidget.cpp.o[2019-10-31T04:58:24.553Z] [ 58%] Building CXX object kcms/keys/CMakeFiles/kcm_keys.dir/globalshortcuts.cpp.o[2019-10-31T04:58:24.553Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/desktoptheme/kcm.cpp:119:5: error: use of undeclared identifier 'settingsChanged'; did you mean 'buttonsChanged'?[2019-10-31T04:58:24.553Z] settingsChanged();[2019-10-31T04:58:24.553Z] ^~~[2019-10-31T04:58:24.553Z] buttonsChanged[2019-10-31T04:58:24.553Z] /usr/home/jenkins/install-prefix/include/KF5/KDeclarative/kquickaddons/configmodule.h:498:10: note: 'buttonsChanged' declared here[2019-10-31T04:58:24.553Z] void buttonsChanged();[2019-10-31T04:58:24.553Z]  ^[2019-10-31T04:58:24.821Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keys/kglobalshortcutseditor.cpp:21:[2019-10-31T04:58:24.821Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/build/kcms/keys/ui_select_application.h:40:38: warning: 'KFilterProxySearchLine' is deprecated: Since 5.50. See class API docs [-Wdeprecated-declarations][2019-10-31T04:58:24.821Z] kfilterproxysearchline = new KFilterProxySearchLine(SelectApplicationDialog);[2019-10-31T04:58:24.821Z]  ^[2019-10-31T04:58:24.821Z] /usr/home/jenkins/install-prefix/include/KF5/KItemViews/kfilterproxysearchline.h:57:5: note: 'KFilterProxySearchLine' has been explicitly marked deprecated here[2019-10-31T04:58:24.821Z] KITEMVIEWS_DEPRECATED_VERSION(5, 50, "See class API docs")[2019-10-31T04:58:24.821Z] ^[2019-10-31T04:58:24.821Z] /usr/home/jenkins/install-prefix/include/KF5/KItemViews/kitemviews_export.h:138:59: note: expanded from macro 'KITEMVIEWS_DEPRECATED_VERSION'[2019-10-31T04:58:24.821Z] #define KITEMVIEWS_DEPRECATED_VERSION(major, minor, text) KITEMVIEWS_DEPRECATED_VERSION_##major(minor, "Since "#major"."#minor". " text)[2019-10-31T04:58:24.821Z]   ^[2019-10-31T04:58:24.821Z] :68:1: note: expanded from here[2019-10-31T04:58:24.821Z] KITEMVIEWS_DEPRECATED_VERSION_5[2019-10-31T04:58:24.821Z] ^[2019-10-31T04:58:24.821Z] /usr/home/jenkins/install-prefix/include/KF5/KItemViews/kitemviews_export.h:137:59: note: expanded from macro 'KITEMVIEWS_DEPRECATED_VERSION_5'[2019-10-31T04:58:24.821Z] #define KITEMVIEWS_DEPRECATED_VERSION_5(minor, text)  KITEMVIEWS_DEPRECATED_VERSION_5_##minor(text)[2019-10-31T04:58:24.821Z]   ^[2019-10-31T04:58:24.821Z] :69:1: note: expanded from here[2019-10-31T04:58:24.821Z] KITEMVIEWS_DEPRECATED_VERSION_5_50[2019-10-31T04:58:24.821Z] ^[2019-10-31T04:58:24.821Z] /usr/home/jenkins/install-prefix/include/KF5/KItemViews/kitemviews_export.h:132:52: note: expanded from macro 'KITEMVIEWS_DEPRECATED_VERSION_5_50'[2019-10-31T04:58:24.821Z] #  define KITEMVIEWS_DEPRECATED_VERSION_5_50(text) KITEMVIEWS_DECL_DEPRECATED_TEXT(text)[2019-10-31T04:58:24.821Z]