KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 276 - Failure!

2019-11-20 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/276/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 21 Nov 2019 04:36:02 +
 Build duration:
3 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 1195 lines...][2019-11-21T04:39:05.227Z]  * KF5ConfigWidgets (required version >= 5.64.0)[2019-11-21T04:39:05.227Z]  * KF5XmlGui (required version >= 5.64.0)[2019-11-21T04:39:05.227Z]  * KF5Parts (required version >= 5.64.0)[2019-11-21T04:39:05.227Z]  * KF5TextEditor[2019-11-21T04:39:05.227Z]  * KF5Holidays, Holidays provider for Plasma calendar[2019-11-21T04:39:05.227Z]Needed to for holidays plugin for Plasma Calendar.[2019-11-21T04:39:05.227Z]  * KF5Activities (required version >= 5.62.0), management of Plasma activities[2019-11-21T04:39:05.227Z]Needed by activity related plasmoids.[2019-11-21T04:39:05.227Z]  * Freetype[2019-11-21T04:39:05.227Z]  * Fontconfig[2019-11-21T04:39:05.227Z]  * KF5Prison (required version >= 5.62.0), Prison library, [2019-11-21T04:39:05.227Z]Needed to create mobile barcodes from clipboard data[2019-11-21T04:39:05.227Z]  * Phonon4Qt5Experimental (required version == 4.11.1)[2019-11-21T04:39:05.227Z]  * PkgConfig[2019-11-21T04:39:05.227Z] [2019-11-21T04:39:05.227Z] -- The following RECOMMENDED packages have been found:[2019-11-21T04:39:05.227Z] [2019-11-21T04:39:05.227Z]  * KF5Baloo, File Searching[2019-11-21T04:39:05.227Z]Needed for the File Search runner.[2019-11-21T04:39:05.227Z] [2019-11-21T04:39:05.227Z] -- The following REQUIRED packages have been found:[2019-11-21T04:39:05.227Z] [2019-11-21T04:39:05.227Z]  * Qt5Qml (required version >= 5.13.2)[2019-11-21T04:39:05.227Z]  * Qt5QuickWidgets[2019-11-21T04:39:05.227Z]  * Qt5Test[2019-11-21T04:39:05.227Z]  * KF5Runner (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5NotifyConfig (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5Su (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5NewStuff (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5Wallet (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5IdleTime (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * Qt5Quick (required version >= 5.11.0)[2019-11-21T04:39:05.227Z]  * KF5Declarative (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5KCMUtils (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5DocTools (required version >= 5.64.0)[2019-11-21T04:39:05.227Z]  * KF5KDELibs4Support (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5Crash (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5GlobalAccel (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5DBusAddons (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5Wayland (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5People (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KF5ActivitiesStats (required version >= 5.62.0)[2019-11-21T04:39:05.227Z]  * KDED[2019-11-21T04:39:05.227Z]  * KF5Plasma (required version >= 5.64.0)[2019-11-21T04:39:05.227Z]  * KF5PlasmaQuick[2019-11-21T04:39:05.227Z]  * KF5SysGuard[2019-11-21T04:39:05.227Z]  * ECM (required version >= 1.6.0)[2019-11-21T04:39:05.227Z]  * KF5Package[2019-11-21T04:39:05.227Z]  * KF5[2019-11-21T04:39:05.227Z]  * Qt5Network (required version >= 5.11.0)[2019-11-21T04:39:05.227Z]  * Qt5Concurrent (required version >= 5.11.0)[2019-11-21T04:39:05.228Z]  * Gettext[2019-11-21T04:39:05.228Z]  * KF5I18n (required version >= 5.64.0)[2019-11-21T04:39:05.228Z]  * KF5TextWidgets (required version >= 5.64.0)[2019-11-21T04:39:05.228Z]  * KF5CoreAddons (required version >= 5.64.0)[2019-11-21T04:39:05.228Z]  * KWinDBusInterface[2019-11-21T04:39:05.228Z]  * KF5Screen[2019-11-21T04:39:05.228Z]  * KScreenLocker (required version >= 5.13.80)[2019-11-21T04:39:05.228Z]  * ScreenSaverDBusInterface[2019-11-21T04:39:05.228Z]  * ZLIB, Support for gzip compressed files and data streams, [2019-11-21T04:39:05.228Z]  * Qt5Gui (required version >= 5.11.0)[2019-11-21T04:39:05.228Z]  * Qt5Sql[2019-11-21T04:39:05.228Z]  * Qt5[2019-11-21T04:39:05.228Z]  * Qt5Core[2019-11-21T04:39:05.228Z]  * Qt5Widgets[2019-11-21T04:39:05.228Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2019-11-21T04:39:05.228Z]  * XCB, X protocol C-language Binding, [2019-11-21T04:39:05.228Z]Required for enabling special X11 multihead mode[2019-11-21T04:39:05.228Z] [2019-11-21T04:39:05.228Z] -- The following RUNTIME packages have not been found:[2019-11-21T04:39:05.228Z] [2019-11-21T04:39:05.228Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2019-11-21T04:39:05.228Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2019-11-21T04:39:05.228Z] [2019-11-21T04:39:05.228Z] -- The following OPTIONAL packages have not been found:[2019-11-21T04:39:05.228Z] [2019-11-21T04:39:05.228Z]  * KF5NetworkManagerQt (required version >=

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Failure!

2019-11-20 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 21 Nov 2019 04:34:01 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 168 lines...][Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[2019-11-21T04:35:02.562Z] + python3 -u ci-tooling/helpers/configure-build.py --product Plasma --project kde-gtk-config --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/[2019-11-21T04:35:02.562Z] == Using the following environment to perform the build:[2019-11-21T04:35:02.562Z] JOB_NAME  = 'Plasma/kde-gtk-config/kf5-qt5 FreeBSDQt5.13'[2019-11-21T04:35:02.562Z] BUILD_NUMBER  = '27'[2019-11-21T04:35:02.562Z] LOGNAME   = 'jenkins'[2019-11-21T04:35:02.562Z] LANG  = 'en_US.UTF-8'[2019-11-21T04:35:02.562Z] PAGER = 'more'[2019-11-21T04:35:02.562Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-11-21T04:35:02.562Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/display/redirect'[2019-11-21T04:35:02.562Z] MAIL  = '/var/mail/jenkins'[2019-11-21T04:35:02.562Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/27/display/redirect?page=changes'[2019-11-21T04:35:02.562Z] JENKINS_URL   = 'https://build.kde.org/'[2019-11-21T04:35:02.562Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-11-21T04:35:02.562Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.13'[2019-11-21T04:35:02.562Z] EDITOR= 'vi'[2019-11-21T04:35:02.562Z] ENV   = '/home/jenkins/.shrc'[2019-11-21T04:35:02.562Z] HUDSON_HOME   = '/home/production/data'[2019-11-21T04:35:02.562Z] CCACHE_DIR= '/home/jenkins/.ccache/'[2019-11-21T04:35:02.562Z] BUILD_ID  = '27'[2019-11-21T04:35:02.562Z] OLDPWD= '/usr/home/jenkins'[2019-11-21T04:35:02.562Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-gtk-config/kf5-qt5 FreeBSDQt5.13'[2019-11-21T04:35:02.562Z] _ = '/usr/local/bin/java'[2019-11-21T04:35:02.562Z] TERM  = 'su'[2019-11-21T04:35:02.562Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.13'[2019-11-21T04:35:02.562Z] BUILD_TAG = 'jenkins-Plasma-kde-gtk-config-kf5-qt5 FreeBSDQt5.13-27'[2019-11-21T04:35:02.562Z] BUILD_DISPLAY_NAME= '#27'[2019-11-21T04:35:02.562Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/27/display/redirect'[2019-11-21T04:35:02.562Z] USER  = 'jenkins'[2019-11-21T04:35:02.562Z] HOME  = '/home/jenkins'[2019-11-21T04:35:02.562Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/27/'[2019-11-21T04:35:02.562Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/'[2019-11-21T04:35:02.562Z] HUDSON_URL= 'https://build.kde.org/'[2019-11-21T04:35:02.562Z] SHELL = '/usr/local/bin/bash'[2019-11-21T04:35:02.562Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-gtk-config/kf5-qt5 FreeBSDQt5.13'[2019-11-21T04:35:02.562Z] MM_CHARSET= 'UTF-8'[2019-11-21T04:35:02.562Z] STAGE_NAME= 'Configuring Build'[2019-11-21T04:35:02.562Z] NODE_NAME = 'FreeBSD Builder 2'[2019-11-21T04:35:02.562Z] BLOCKSIZE = 'K'[2019-11-21T04:35:02.562Z] EXECUTOR_NUMBER   = '0'[2019-11-21T04:35:02.562Z] SHLVL = '0'[2019-11-21T04:35:02.562Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-11-21T04:35:02.562Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2019-11-21T04:35:02.562Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-11-21T04:35:02.562Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-11-21T04:35:02.562Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-11-21T04:35:02.562Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-11-21T04:35:02.562Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-11-21T04:35:02.562Z] QT_SELECT =

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Failure!

2019-11-20 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/68/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 21 Nov 2019 02:29:10 +
 Build duration:
52 sec and counting
   CONSOLE OUTPUT
  [...truncated 705 lines...][2019-11-21T02:29:56.345Z] [ 44%] Building CXX object CMakeFiles/kinfocenter.dir/main.cpp.o[2019-11-21T02:29:56.345Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24:[2019-11-21T02:29:56.345Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:211:50: warning: unused parameter 'lBox' [-Wunused-parameter][2019-11-21T02:29:56.345Z] static bool GetInfo_XServer_Generic(QTreeWidget *lBox) {[2019-11-21T02:29:56.345Z]  ^[2019-11-21T02:29:56.345Z] 1 warning generated.[2019-11-21T02:29:56.345Z] [ 45%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/usbdevices.cpp.o[2019-11-21T02:29:56.345Z] [ 47%] Building CXX object CMakeFiles/kinfocenter.dir/sidepanel.cpp.o[2019-11-21T02:29:56.346Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:43:22: warning: unused function 'Value' [-Wunused-function][2019-11-21T02:29:56.346Z] static const QString Value(int val, int numbers=1) {[2019-11-21T02:29:56.346Z]  ^[2019-11-21T02:29:56.346Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:47:22: warning: unused function 'HexStr' [-Wunused-function][2019-11-21T02:29:56.346Z] static const QString HexStr(unsigned long val, int digits) {[2019-11-21T02:29:56.346Z]  ^[2019-11-21T02:29:56.346Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:68:22: warning: unused function 'BitString' [-Wunused-function][2019-11-21T02:29:56.346Z] static const QString BitString(unsigned long n) {[2019-11-21T02:29:56.346Z]  ^[2019-11-21T02:29:56.346Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:72:22: warning: unused function 'ByteString' [-Wunused-function][2019-11-21T02:29:56.346Z] static const QString ByteString(unsigned long n) {[2019-11-21T02:29:56.346Z]  ^[2019-11-21T02:29:56.346Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:332:12: warning: unused function 'GetInfo_ReadfromPipe' [-Wunused-function][2019-11-21T02:29:56.346Z] static int GetInfo_ReadfromPipe(QTreeWidget* tree, const char *FileName, bool WithEmptyLines = true) {[2019-11-21T02:29:56.346Z]^[2019-11-21T02:29:56.609Z] [ 48%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/totalMemoryChart.cpp.o[2019-11-21T02:29:56.609Z] [ 50%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/ksmbstatus.cpp.o[2019-11-21T02:29:56.609Z] 6 warnings generated.[2019-11-21T02:29:56.609Z] [ 51%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/info_wayland.cpp.o[2019-11-21T02:29:56.900Z] [ 52%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcmsambaimports.cpp.o[2019-11-21T02:29:57.158Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.cpp:11:[2019-11-21T02:29:57.158Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.h:24:4: warning: "The USB subsystem has changed in 8.0. Disabling." [-W#warnings][2019-11-21T02:29:57.158Z] #  warning "The USB subsystem has changed in 8.0. Disabling."[2019-11-21T02:29:57.158Z]^[2019-11-21T02:29:57.432Z] [ 54%] Linking CXX shared module ../../../bin/kcm_about_distro.so[2019-11-21T02:29:57.432Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.h:72:64: warning: private field '_power' is not used [-Wunused-private-field][2019-11-21T02:29:57.432Z] int _bus, _level, _parent, _port, _count, _device, _channels, _power;[2019-11-21T02:29:57.432Z]   ^[2019-11-21T02:29:57.432Z] [ 54%] Built target kcm_about_distro[2019-11-21T02:29:57.432Z] [ 55%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/physicalMemoryChart.cpp.o[2019-11-21T02:29:57.715Z] [ 56%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/soldevice.cpp.o[2019-11-21T02:29:57.715Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/samba/ksmbstatus.cpp:122:13: warning: variable length array used [-Wvla][2019-11-21T02:29:57.715Z] char buffer[buflen];[2019-11-21T02:29:57.715Z]^[2019-11-21T02:29:57.715Z] [ 58%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/devinfo.cpp.o[2019-11-21T02:29:57.715Z] 2 warnings

D25418: [Folder view] Use selected text color for selected items in full representation

2019-11-20 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D25418#565427 , @ngraham wrote:
  
  > That was my first reaction in the bug report as well (see the discussion 
there). But try clicking on that file, not just highlighting it. :)
  
  
  I see. It seems like it's stuck halfway between looking like Kickoff and 
behaving like Dolphin. F7774899: Screenshot_20191120_170350.png 

  
  If you make the text use the highlighted text color, we might have to undo 
that later on with the Breeze theme evolution. I'm not yet sure what the best 
way to differentiate selected list items and a hovered list items is.
  
  I suppose it wouldn't hurt to do this change now just to fix the bug though.

INLINE COMMENTS

> FolderItemDelegate.qml:354
> +color: frameLoader.textShadow && 
> frameLoader.textShadow.visible
> +? "#fff" : (model.selected ? 
> PlasmaCore.ColorScope.highlightedTextColor : PlasmaCore.ColorScope.textColor)
>  

Is there not a better way to make nested if statements in QML?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-folderview-selected-text (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D25418

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25418: [Folder view] Use selected text color for selected items in full representation

2019-11-20 Thread Nathaniel Graham 
ngraham added a comment.


  That was my first reaction in the bug report as well (see the discussion 
there). But try clicking on that file, not just highlighting it. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25418

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25418: [Folder view] Use selected text color for selected items in full representation

2019-11-20 Thread Noah Davis 
ndavis added a comment.


  It looks like your highlight effect is bugged or you are using a modified 
desktop theme. Here's what mine looks like: F7774871: 
Screenshot_20191120_165311.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25418

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25019: Ensure that GlobalDrawer topContent always stays on top

2019-11-20 Thread Nathaniel Graham 
ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of D25426  and D25425 
.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25019

To: ngraham, #kirigami, mart, apol, ahiemstra
Cc: dfaure, wbauer, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, mart, hein

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-11-20 Thread Nathaniel Graham 
ngraham added a reviewer: Baloo.
ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

2019-11-20 Thread Nathaniel Graham 
ngraham added a reviewer: Baloo.
ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25430: fix layout of overlaysheet

2019-11-20 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> ProgressView.qml:60
>  separatorVisible: false
> +//implicitWidth: 400//tasksView.width
>  hoverEnabled: model.application

Needed?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25430

To: mart, #discover_software_store
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25415: Improve package documentation

2019-11-20 Thread Filip Fila 
filipf updated this revision to Diff 70082.
filipf added a comment.


  simpler dependencies list

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25415?vs=70020=70082

BRANCH
  better-documentation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25415

AFFECTED FILES
  README
  README.md

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25006: Make sure -dpi value is valid

2019-11-20 Thread David Edmundson 
davidedmundson added a comment.


  Turning a number into a string and back again isn't ideal
  
  I would suggest:
  
int dpiValue = dpiConfigGroup.readEntry("forceFontDPI", -1);


if (dpiValue  > 24) {
 const QString dpiArgument = QStringLiteral("-dpi ") + 
QString::number(dpiValue);
args[QStringLiteral("kde_settings.conf/X11/ServerArguments")] = 
dpiArgument;
}
  
  Though I'm not sure I fully understand why we have this sort of wrong value 
in the config anyway?
  
  Also do we want
  
} else {
args[QStringLiteral("kde_settings.conf/X11/ServerArguments")] = 
QString();
}
  
  so that a broken DPI wipes the old config entry out? Not sure.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D25006

To: gcraciunescu, filipf, #plasma, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25415: Improve package documentation

2019-11-20 Thread David Edmundson 
davidedmundson added a comment.


  > The list would probably get outdated soon and maybe the deps can be listed 
more abstractly so there's fewer lines.
  
  Yeah. Also this looks like the output of running cmake anyway, so I don't see 
what we gain by writing it in another place.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  better-documentation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25415

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25430: fix layout of overlaysheet

2019-11-20 Thread Marco Martin 
mart created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  makes the overlaysheet howit's supposed to be rendered:
  since it's "global" in the app, it should be parented to the
  applicationwindow overlay, and have a "non 100%" width, but something
  based upon readability

REPOSITORY
  R134 Discover Software Store

BRANCH
  phab/overlaysheet

REVISION DETAIL
  https://phabricator.kde.org/D25430

AFFECTED FILES
  discover/qml/ProgressView.qml
  libdiscover/backends/DummyBackend/DummyTransaction.cpp

To: mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

2019-11-20 Thread Carl Schwan 
ognarb added a comment.


  :)

INLINE COMMENTS

> CMakeLists.txt:2
>  # KI18N Translation Domain for this library
> +# KI18N Translation Domain for this library
>  add_definitions(-DTRANSLATION_DOMAIN=\"kcmaccess\")

Duplicate line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-20 Thread Yunhe Guo 
guoyunhe added a comment.


  I checked all KCM modules, the bottom row of buttons are all in same height 
(like the smaller button in your screenshot). Have you tried reboot?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

2019-11-20 Thread Steffen Hartleib 
steffenh updated this revision to Diff 70078.
steffenh added a comment.


  oops was wrong diff, now is it the correct version

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25428?vs=70066=70078

BRANCH
  touchFolderView

REVISION DETAIL
  https://phabricator.kde.org/D25428

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: steffenh, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

2019-11-20 Thread Steffen Hartleib 
steffenh created this revision.
steffenh added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
steffenh requested review of this revision.

REVISION SUMMARY
  moving icon's on the desktop around with touch
  open/launch icons with tap (only singe tap, regardless of mouse workspace 
behavior)
  access the icons context menu with tap and hold
  
  BUG: 366462

TEST PLAN
  activate "folder view" desktop mode, and try to interact with the icons via 
touch

REPOSITORY
  R119 Plasma Desktop

BRANCH
  touchFolderView

REVISION DETAIL
  https://phabricator.kde.org/D25428

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: steffenh, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-20 Thread Nathaniel Graham 
ngraham added a comment.


  QWidgets KCMs in English.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-20 Thread Yunhe Guo 
guoyunhe added a comment.


  @ngraham which applications are they? I didn't see similar thing in my system.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-20 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Things seem noticeably too short to me now, and QWidgets things are smaller 
than their QML versions. Observe:
  
  Above, QWidgets. Below, QML:
  
  F7774370: Screenshot_20191120_105955.png 

  
  This seems like too invasive a change. I think we should fix this bug, but 
not by resizing //everything//.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25426: use the new GlobalDrawer header property

2019-11-20 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> DiscoverDrawer.qml:26
>  import org.kde.discover.app 1.0
>  import org.kde.kirigami 2.8 as Kirigami
>  import "navigation.js" as Navigation

2.12 now, right?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25426

To: mart, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25425: header property for the drawer

2019-11-20 Thread Marco Martin 
mart updated this revision to Diff 70072.
mart added a comment.


  - apidocs

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25425?vs=70070=70072

BRANCH
  mart/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25425

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarStyleGroup.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/icon.cpp

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart, hein

D25426: use the new GlobalDrawer header property

2019-11-20 Thread Nathaniel Graham 
ngraham added a comment.


  Is `header:` new API? Does this need a kirigami version increase in cmake?

REPOSITORY
  R134 Discover Software Store

BRANCH
  phab/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25426

To: mart, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25426: use the new GlobalDrawer header property

2019-11-20 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great with D25426 !

REPOSITORY
  R134 Discover Software Store

BRANCH
  phab/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25426

To: mart, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25425: header property for the drawer

2019-11-20 Thread Nathaniel Graham 
ngraham added a comment.


  Looks great with D25426 !

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25425

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart, hein

D25413: [Weather] Make compact representation temperature text match size of clock text

2019-11-20 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:edb1367acc39: [Weather] Make compact representation 
temperature text match size of clock text (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25413?vs=70017=70069

REVISION DETAIL
  https://phabricator.kde.org/D25413

AFFECTED FILES
  applets/weather/package/contents/ui/IconAndTextItem.qml

To: ngraham, #vdg, #plasma, spstarr
Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25425: header property for the drawer

2019-11-20 Thread Marco Martin 
mart updated this revision to Diff 70070.
mart added a comment.


  - single item for header

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25425?vs=70065=70070

BRANCH
  mart/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25425

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarStyleGroup.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/icon.cpp

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25426: use the new GlobalDrawer header property

2019-11-20 Thread Marco Martin 
mart updated this revision to Diff 70071.
mart added a comment.


  small fixes

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25426?vs=70068=70071

BRANCH
  phab/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25426

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25426: use the new GlobalDrawer header property

2019-11-20 Thread Marco Martin 
mart updated this revision to Diff 70068.
mart added a comment.


  - actually use header

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25426?vs=70067=70068

BRANCH
  phab/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25426

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25426: use the new GlobalDrawer header property

2019-11-20 Thread Marco Martin 
mart created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  depends from D25425 

REPOSITORY
  R134 Discover Software Store

BRANCH
  phab/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25426

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25425: header property for the drawer

2019-11-20 Thread Marco Martin 
mart added a comment.


  WIP: apidocs still missing

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25425

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25425: header property for the drawer

2019-11-20 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  GlobalDrawer has the new property header, which does not scroll.
  It can be used for toolbars that need to match with the global kirigami 
toolbar.
  the banner image by default is *not* shown on desktop but only on mobile
  the result makes easier to make apps look more at home on desktops

TEST PLAN
  apps that don't use it still look the same

REPOSITORY
  R169 Kirigami

BRANCH
  mart/drawerHeader

REVISION DETAIL
  https://phabricator.kde.org/D25425

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarStyleGroup.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/icon.cpp

To: mart, #plasma
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25413: [Weather] Make compact representation temperature text match size of clock text

2019-11-20 Thread Nathaniel Graham 
ngraham added a comment.


  Can you formally accept, maybe?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25413

To: ngraham, #vdg, #plasma
Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25413: [Weather] Make compact representation temperature text match size of clock text

2019-11-20 Thread Shawn Starr 
spstarr added a comment.


  as for the change, it looks good to me..

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25413

To: ngraham, #vdg, #plasma
Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25413: [Weather] Make compact representation temperature text match size of clock text

2019-11-20 Thread Shawn Starr 
spstarr added a comment.


  Probably could also say the same for, winds/visibility those could be rounded 
in some places depending on the unit(s).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25413

To: ngraham, #vdg, #plasma
Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25413: [Weather] Make compact representation temperature text match size of clock text

2019-11-20 Thread Nathaniel Graham 
ngraham added a comment.


  In D25413#565258 , @spstarr wrote:
  
  > I wonder, some users might not want to see the temperature decimal points, 
maybe an option to hide it? The reason I exposed that level of temperature in 
the engine was when you live in cold climates the exact decimal temperature 
might help to tell you if there was ice possible. But from the UI side we could 
hide it by default instead and make it optional to expose the decimals?
  
  
  I would say that for Celsius it is always useful because Censius is has a 
more restricted range of common temperatures, but for Fahrenheit with its wider 
range, it's never useful. Material for the next patch, maybe. Is this one okay?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25413

To: ngraham, #vdg, #plasma
Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25413: [Weather] Make compact representation temperature text match size of clock text

2019-11-20 Thread Shawn Starr 
spstarr added a comment.


  I wonder, some users might not want to see the temperature decimal points, 
maybe an option to hide it? The reason I exposed that level of temperature in 
the engine was when you live in cold climates the exact decimal temperature 
might help to tell you if there was ice possible. But from the UI side we could 
hide it by default instead and make it optional to expose the decimals?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25413

To: ngraham, #vdg, #plasma
Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25395: Make avatar icon dpr aware aka HiDPI rendered

2019-11-20 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R128:a6f37349cd40: Make avatar icon dpr aware aka HiDPI 
rendered (authored by meven).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25395?vs=70008=70063

REVISION DETAIL
  https://phabricator.kde.org/D25395

AFFECTED FILES
  src/accountinfo.cpp
  src/lib/accountmodel.cpp
  src/lib/accountmodel.h

To: meven, #plasma, ngraham
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25424: Fix default card background

2019-11-20 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:dddef02dad95: Fix default card background (authored by 
ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25424?vs=70058=70060

REVISION DETAIL
  https://phabricator.kde.org/D25424

AFFECTED FILES
  src/controls/private/DefaultCardBackground.qml

To: ngraham, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-20 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 70059.
guoyunhe added a comment.


  Force height consistency

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25381?vs=69954=70059

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25381

AFFECTED FILES
  kstyle/breezestyle.cpp

To: guoyunhe, #breeze, #plasma
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25424: Fix default card background

2019-11-20 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  A theme-collowing color background got lost in 
4203a779031cb7c2268fbdd75d3d9d786056 
.

TEST PLAN
  Cards are no longer white when using the Breeze Dark color scheme
  
  BUG: 414329
  FIXED-IN: 5.65

REPOSITORY
  R169 Kirigami

BRANCH
  fix-default-card-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25424

AFFECTED FILES
  src/controls/private/DefaultCardBackground.qml

To: ngraham, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25404: Just return applicationDisplayName in MPRIS Identity

2019-11-20 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:78347989fca8: Just return applicationDisplayName in MPRIS 
Identity (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25404?vs=7=70057

REVISION DETAIL
  https://phabricator.kde.org/D25404

AFFECTED FILES
  host/mprisplugin.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25398: Check values have changed before setting the model

2019-11-20 Thread Nathaniel Graham 
ngraham added a comment.


  Agreed. Works for me and looks safe, but maybe let's do master only for 
safety.
  
  Can you file a bug upstream on the odd behavior in AccountsService?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D25398

To: meven, #plasma
Cc: ngraham, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25408: [KCM] Port main page to QQC2

2019-11-20 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:b5f223f36da2: [KCM] Port main page to QQC2 (authored by 
ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25408?vs=70009=70056

REVISION DETAIL
  https://phabricator.kde.org/D25408

AFFECTED FILES
  kcm/qml/main.qml

To: ngraham, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

2019-11-20 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:42
> Needs keyboard navigation. See 
> https://cgit.kde.org/plasma-desktop.git/commit/?id=659fe0a76f19b60021733c4a74e451d4318a8359
>  for details regarding how.

more than that, the correct way of doing keyboard navigation in ListView is 
setting in the ListView instance

activeFocusOnTab: true
keyNavigationEnabled: true

(and leaving keyNavigationWraps to false)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-20 Thread Yunhe Guo 
guoyunhe added a comment.


  The remaining 1px difference between QPushButton and QLineEdit is caused by 
content. QLineEdit directly expands from its content size, while QPushButton 
calculate size of text metrics and icons.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25415: Improve package documentation

2019-11-20 Thread Filip Fila 
filipf added a comment.


  Maybe I shouldn't list all those dependencies like that. The list would 
probably get outdated soon and maybe the deps can be listed more abstractly so 
there's fewer lines.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  better-documentation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25415

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25140: kcm/fonts: set initial settings correctly

2019-11-20 Thread Bhushan Shah 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:243d0b6d4ea3: kcm/fonts: set initial settings correctly 
(authored by bshah).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25140?vs=69258=70038

REVISION DETAIL
  https://phabricator.kde.org/D25140

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart