D25428: Improved support for desktop "Folder View"

2019-11-23 Thread Steffen Hartleib 
steffenh updated this revision to Diff 70247.
steffenh added a comment.


  simulate left mouse click, if touchtap ended

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25428?vs=70078&id=70247

BRANCH
  folderview

REVISION DETAIL
  https://phabricator.kde.org/D25428

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: steffenh, #plasma, hein, ngraham
Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Fixed!

2019-11-23 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 24 Nov 2019 07:24:14 +
 Build duration:
1 min 9 sec and counting

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

2019-11-23 Thread David Faure 
dfaure added a comment.


  Thanks for the idea, done in 
https://commits.kde.org/kwayland-integration/3ce73d56ca5364242be3eb7cb1b5c4f5eaf47196

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25488

To: dfaure, kossebau, jriddell, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

2019-11-23 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25488

To: dfaure, kossebau, jriddell, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

2019-11-23 Thread Friedrich W. H. Kossebau 
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  For a backport, one could perhaps do this after the includes:
  
#fndef KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE
#ifndef KWINDOWSYSTEM_NO_DEPRECATED
#define KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE(x, y) 1
#else
#define KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE(x, y) 0
#endif
#endif
  
  Otherwise seems fine with me from pure patch reading.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25488

To: dfaure, kossebau, jriddell, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Failure!

2019-11-23 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 17:34:00 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 184 lines...][2019-11-23T17:34:41.347Z] EDITOR= 'vi'[2019-11-23T17:34:41.347Z] ENV   = '/home/jenkins/.shrc'[2019-11-23T17:34:41.347Z] HUDSON_HOME   = '/home/production/data'[2019-11-23T17:34:41.347Z] BUILD_ID  = '29'[2019-11-23T17:34:41.347Z] OLDPWD= '/usr/home/jenkins'[2019-11-23T17:34:41.347Z] PWD   = '/usr/home/jenkins/workspace/Plasma/breeze-gtk/kf5-qt5 FreeBSDQt5.13'[2019-11-23T17:34:41.347Z] _ = '/usr/local/bin/java'[2019-11-23T17:34:41.347Z] TERM  = 'su'[2019-11-23T17:34:41.347Z] NODE_LABELS   = 'FreeBSD Builder Theta FreeBSDQt5.13'[2019-11-23T17:34:41.347Z] BUILD_TAG = 'jenkins-Plasma-breeze-gtk-kf5-qt5 FreeBSDQt5.13-29'[2019-11-23T17:34:41.347Z] BUILD_DISPLAY_NAME= '#29'[2019-11-23T17:34:41.347Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.13/29/display/redirect'[2019-11-23T17:34:41.347Z] USER  = 'jenkins'[2019-11-23T17:34:41.347Z] HOME  = '/home/jenkins'[2019-11-23T17:34:41.347Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.13/29/'[2019-11-23T17:34:41.347Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.13/'[2019-11-23T17:34:41.347Z] HUDSON_URL= 'https://build.kde.org/'[2019-11-23T17:34:41.347Z] SHELL = '/bin/sh'[2019-11-23T17:34:41.347Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/breeze-gtk/kf5-qt5 FreeBSDQt5.13'[2019-11-23T17:34:41.347Z] STAGE_NAME= 'Configuring Build'[2019-11-23T17:34:41.347Z] NODE_NAME = 'FreeBSD Builder Theta'[2019-11-23T17:34:41.613Z] BLOCKSIZE = 'K'[2019-11-23T17:34:41.613Z] EXECUTOR_NUMBER   = '0'[2019-11-23T17:34:41.613Z] SHLVL = '0'[2019-11-23T17:34:41.613Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-11-23T17:34:41.613Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2019-11-23T17:34:41.613Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-11-23T17:34:41.613Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-11-23T17:34:41.613Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-11-23T17:34:41.613Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-11-23T17:34:41.613Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-11-23T17:34:41.613Z] QT_SELECT = 'qt5'[2019-11-23T17:34:41.613Z] LANG  = 'en_US.UTF-8'[2019-11-23T17:34:41.613Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-11-23T17:34:41.613Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-11-23T17:34:41.613Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-11-23T17:34:41.613Z] [2019-11-23T17:34:41.613Z] [2019-11-23T17:34:41.613Z] == Commencing Configuration:[2019-11-23T17:34:41.613Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/breeze-gtk/kf5-qt5 FreeBSDQt5.13"[2019-11-23T17:34:41.613Z] -- The C compiler identification is Clang 8.0.1[2019-11-23T17:34:41.613Z] -- The CXX compiler identification is Clang 8.0.1[2019-11-23T17:34:41.613Z] -- Check for working C compiler: /usr/bin/cc[2019-11-23T17:34:41.613Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-11-23T17:34:41.613Z] -- Detecting C compiler ABI info[2019-11-23T17:34:41.870Z] -- Detecting C compiler ABI info - done[2019-11-23T17:34:41.870Z] -- Detecting C compile features[2019-11-23T17:34:41.870Z] -- Detecting C compile features - done[2019-11-23T17:34:41.870Z] -- Check for working CXX compiler: /usr/bin/c++[2019-11-23T17:34:41.870Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-11-23T17:34:41.870Z] -- Detecting CXX compiler ABI info[2019-11-23T17:34:41.870Z] -- Detecting CXX compiler ABI info - done[2019-11-23T17:34:41.870Z] -- Detecting CXX compile features[2019-11-23T17:34:41.870Z] -- Detecting CXX co

KDE CI: Plasma » breeze-gtk » stable-kf5-qt5 FreeBSDQt5.13 - Build # 14 - Failure!

2019-11-23 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.13/14/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 17:33:32 +
 Build duration:
26 sec and counting
   CONSOLE OUTPUT
  [...truncated 187 lines...][2019-11-23T17:33:58.380Z] ENV   = '/home/jenkins/.shrc'[2019-11-23T17:33:58.380Z] HUDSON_HOME   = '/home/production/data'[2019-11-23T17:33:58.380Z] CCACHE_DIR= '/home/jenkins/.ccache/'[2019-11-23T17:33:58.380Z] BUILD_ID  = '14'[2019-11-23T17:33:58.380Z] OLDPWD= '/usr/home/jenkins'[2019-11-23T17:33:58.380Z] PWD   = '/usr/home/jenkins/workspace/Plasma/breeze-gtk/stable-kf5-qt5 FreeBSDQt5.13'[2019-11-23T17:33:58.380Z] _ = '/usr/local/bin/java'[2019-11-23T17:33:58.380Z] TERM  = 'su'[2019-11-23T17:33:58.380Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.13'[2019-11-23T17:33:58.380Z] BUILD_TAG = 'jenkins-Plasma-breeze-gtk-stable-kf5-qt5 FreeBSDQt5.13-14'[2019-11-23T17:33:58.380Z] BUILD_DISPLAY_NAME= '#14'[2019-11-23T17:33:58.380Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.13/14/display/redirect'[2019-11-23T17:33:58.380Z] USER  = 'jenkins'[2019-11-23T17:33:58.380Z] HOME  = '/home/jenkins'[2019-11-23T17:33:58.380Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.13/14/'[2019-11-23T17:33:58.380Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2019-11-23T17:33:58.380Z] HUDSON_URL= 'https://build.kde.org/'[2019-11-23T17:33:58.380Z] SHELL = '/usr/local/bin/bash'[2019-11-23T17:33:58.380Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/breeze-gtk/stable-kf5-qt5 FreeBSDQt5.13'[2019-11-23T17:33:58.380Z] MM_CHARSET= 'UTF-8'[2019-11-23T17:33:58.380Z] STAGE_NAME= 'Configuring Build'[2019-11-23T17:33:58.380Z] NODE_NAME = 'FreeBSD Builder 1'[2019-11-23T17:33:58.380Z] BLOCKSIZE = 'K'[2019-11-23T17:33:58.380Z] EXECUTOR_NUMBER   = '0'[2019-11-23T17:33:58.380Z] SHLVL = '0'[2019-11-23T17:33:58.380Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-11-23T17:33:58.380Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2019-11-23T17:33:58.380Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-11-23T17:33:58.380Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-11-23T17:33:58.380Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-11-23T17:33:58.380Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-11-23T17:33:58.380Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-11-23T17:33:58.380Z] QT_SELECT = 'qt5'[2019-11-23T17:33:58.380Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-11-23T17:33:58.380Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-11-23T17:33:58.380Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-11-23T17:33:58.380Z] [2019-11-23T17:33:58.380Z] [2019-11-23T17:33:58.380Z] == Commencing Configuration:[2019-11-23T17:33:58.380Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/breeze-gtk/stable-kf5-qt5 FreeBSDQt5.13"[2019-11-23T17:33:58.380Z] -- The C compiler identification is Clang 8.0.1[2019-11-23T17:33:58.380Z] -- The CXX compiler identification is Clang 8.0.1[2019-11-23T17:33:58.380Z] -- Check for working C compiler: /usr/bin/cc[2019-11-23T17:33:58.380Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-11-23T17:33:58.380Z] -- Detecting C compiler ABI info[2019-11-23T17:33:58.637Z] -- Detecting C compiler ABI info - done[2019-11-23T17:33:58.637Z] -- Detecting C compile features[2019-11-23T17:33:58.637Z] -- Detecting C compile features - done[2019-11-23T17:33:58.637Z] -- Check for working CXX compiler: /usr/bin/c++[2019-11-23T17:33:58.637Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-11-23T17:33:58.637Z] -- Detecting CXX compiler ABI info[2019-11-23T17:33:58.637Z] -- Detecting CXX compiler ABI info - done[2019-11-23T17:33:58.637Z

D25476: [GTK3] Fix invalid colour name in treeview

2019-11-23 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:8c16c1961491: [GTK3] Fix invalid colour name in treeview 
(authored by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25476?vs=70186&id=70230

REVISION DETAIL
  https://phabricator.kde.org/D25476

AFFECTED FILES
  src/gtk3/widgets/_treeview.scss

To: cblack, #breeze, #vdg, davidedmundson, ndavis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25487: [lockscreen] Clear password field when system suspends

2019-11-23 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a4e18e2be134: [lockscreen] Clear password field when 
system suspends (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25487?vs=70217&id=70223

REVISION DETAIL
  https://phabricator.kde.org/D25487

AFFECTED FILES
  libkworkspace/sessionmanagement.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: meven, #plasma, broulik, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-11-23 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> constants.js:23
> +
> +var State = {
> +Idle: 0,

Why doesn't this come from the plugin?

> main.qml:111
> +if (monitor.state == Constants.State.ContentIndexing) {
> +return i18n("Currently indexing: %1 ", 
> monitor.filePath)
> +} else {

Is the space after %1 deliberate?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

2019-11-23 Thread Nathaniel Graham 
ngraham added a comment.


  In D25369#566434 , @davidre wrote:
  
  > In D25369#566318 , @guoyunhe 
wrote:
  >
  > > I didn't find good solutions for QQC2. It has been a blocker for a long 
time https://bugs.kde.org/show_bug.cgi?id=403153
  >
  >
  > Then don't port things before it's fixed.  It's a blocker for a reason.
  
  
  In this case we had to port to fix an even worse bug. See D25354 
.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-11-23 Thread Nathaniel Graham 
ngraham added a comment.


  In D25447#566622 , @astippich 
wrote:
  
  > For the concept a big +1 from me. I did not even know that we had that in 
the infocenter...
  
  
  I think most people don't know this, because it's an odd place to have 
controls to start and stop indexing. If and when this patch lands, I think we 
could consider removing the Baloo page entirely.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns
Cc: astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-11-23 Thread Alexander Stippich 
astippich added a comment.


  For the concept a big +1 from me. I did not even know that we had that in the 
infocenter...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns
Cc: astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25487: [lockscreen] Clear password field when system suspends

2019-11-23 Thread Méven Car 
meven updated this revision to Diff 70217.
meven added a comment.


  Amend commit message

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25487?vs=70216&id=70217

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25487

AFFECTED FILES
  libkworkspace/sessionmanagement.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25487: [lockscreen] Clear password field when system suspends

2019-11-23 Thread Méven Car 
meven updated this revision to Diff 70216.
meven added a comment.


  Add missing signal transmission resumingFromSuspend for future-proofing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25487?vs=70215&id=70216

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25487

AFFECTED FILES
  libkworkspace/sessionmanagement.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25486: [Greeter] Add a onSuspend() signal to Authenticator

2019-11-23 Thread Méven Car 
meven abandoned this revision.
meven added a comment.


  In D25486#566549 , @broulik wrote:
  
  > Have you had a look at the libkworkspace2 stuff? It should have that signal 
in it and is ready to be made a qml import iirc
  
  
  I tried to find code that had this feature but missed it, thanks for pointing 
it out.
  So I guess `libkworkspace2 stuff` means `plasma-workspace/libkworkspace` + 
`plasma-workspace/components`
  This solution works only SessionManangements did not emit aboutToSuspend 
signal to users.
  
  I have updated D25487  to remove the need 
for this dependency.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D25486

To: meven, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25487: [lockscreen] Clear password field when system suspends

2019-11-23 Thread Méven Car 
meven updated this revision to Diff 70215.
meven added a comment.


  Reuse SessionManagement component from libkworkspace 
org.kde.plasma.private.sessions

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25487?vs=70204&id=70215

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25487

AFFECTED FILES
  libkworkspace/sessionmanagement.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25486: [Greeter] Add a onSuspend() signal to Authenticator

2019-11-23 Thread Kai Uwe Broulik 
broulik added a comment.


  Have you had a look at the libkworkspace2 stuff? It should have that signal 
in it and is ready to be made a qml import iirc

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D25486

To: meven, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

2019-11-23 Thread David Faure 
dfaure created this revision.
dfaure added reviewers: kossebau, jriddell, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  I build kwindowsystem with -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.62.0,
  and this broke here. Use the exact same condition as the one around
  those virtual methods in the base class.
  
  This required upgrading the KF5 requirement from 5.62 to 5.64,
  so no backport to Plasma/5.17 unfortunately.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25488

AFFECTED FILES
  CMakeLists.txt
  src/windowsystem/windowsystem.cpp
  src/windowsystem/windowsystem.h

To: dfaure, kossebau, jriddell, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25486: [Greeter] Add a onSuspend() signal to Authenticator

2019-11-23 Thread Méven Car 
meven added a comment.


  If this solution is the one expected, I will probably offer a patch to sddm's 
greeter following the same pattern.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D25486

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25486: [Greeter] Add a onSuspend() signal to Authenticator

2019-11-23 Thread Méven Car 
meven updated this revision to Diff 70205.
meven added a comment.


  Undo blank line changes

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25486?vs=70203&id=70205

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25486

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/authenticator.h
  greeter/dbus/org.freedesktop.login1.Manager.xml
  greeter/fallbacktheme/Greeter.qml
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25487: [lockscreen] Clear password field when system suspends

2019-11-23 Thread Méven Car 
meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 414399
  FIXED-IN: 5.18

TEST PLAN
  Depends on D25486 
  
  1. Lock screen
  2. type something in the password field
  3. Close lid/suspend system
  4. Reopen Lid
  
  Before:
  Password text is kept as in step 2
  
  After:
  Password text is empty

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25487

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25486: [Greeter] Add a onSuspend() signal to Authenticator

2019-11-23 Thread Méven Car 
meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  CCBUG: 414399

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25486

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/authenticator.h
  greeter/dbus/org.freedesktop.login1.Manager.xml
  greeter/fallbacktheme/Greeter.qml
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25345: use new icon for search category

2019-11-23 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:a7a2d277e81f: use new icon for search category (authored 
by astippich).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25345?vs=69860&id=70202

REVISION DETAIL
  https://phabricator.kde.org/D25345

AFFECTED FILES
  CMakeLists.txt
  categories/settings-workspace-search.desktop

To: astippich, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25344: change icon for baloo kcm

2019-11-23 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f1a6bfa3b876: change icon for baloo kcm (authored by 
astippich).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25344?vs=69858&id=70201

REVISION DETAIL
  https://phabricator.kde.org/D25344

AFFECTED FILES
  kcms/baloo/kcm_baloofile.desktop

To: astippich, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KInit - Current state and benchmarks

2019-11-23 Thread Milian Wolff 
On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote:
> El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va 
escriure:
> > > Are we sure it's fair to assume people have SSD? our of the 4 laptops i
> > > own, only 2 have SSD.> 
> > It's at least safe to assume it's the trend moving forward.
> > 
> > > Do you think it's worth me trying in one of the two that don't have SSD?
> > 
> > More data is normally a good thing. If you or anyone else wants to
> > collect stats:
> > From my git link above, it's as simple as running the normal ; cmake;
> > make ; ./kinittest -median 5
> 
> On my very old/very slow computer seems to make a lot of difference
> 
> RESULT : DaveTest::testQProcess():
>  2,625 msecs per iteration (total: 2,625, iterations: 1)
> RESULT : DaveTest::testKInit():
>  1,852 msecs per iteration (total: 1,852, iterations: 1)
> 
> 
> RESULT : DaveTest::testQProcess():
>  2,390 msecs per iteration (total: 2,390, iterations: 1)
> RESULT : DaveTest::testKInit():
>  1,846 msecs per iteration (total: 1,846, iterations: 1)

Hey Albert,

these numbers are quite impressive but I can't quite explain those. Are you 
measuring maybe a full debug build without any compiler optimizations? Then 
the library sizes will be _much_ larger and thus trigger more page faults. If 
every one of those is extremely slow on that machine compared to more modern 
machines?

May I ask how old this machine is and what the speed of the HDD is?

Thanks

-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.

D25369: Shorten POTD provider names and remove description that is not used anywhere

2019-11-23 Thread David Redondo 
davidre added a comment.


  In D25369#566318 , @guoyunhe wrote:
  
  > I didn't find good solutions for QQC2. It has been a blocker for a long 
time https://bugs.kde.org/show_bug.cgi?id=403153
  
  
  Then don't port things before it's fixed.  It's a blocker for a reason.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart