date:20191204

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Oh, well done! 
  I'd seen the bug report but hadn't been able to fix it.

INLINE COMMENTS

> IconMode.cpp:119
>  d->categoryView = nullptr;
> +moduleView()->setFaceType(KPageView::Plain);
>  }

In general we want to not mix two styles in the same method.

The rest of the code uses
d->moduleView->

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Filip Fila

filipf added a comment.

  In D25728#571848 , @ngraham wrote:

  > But... the "Before" image looks better. :/
  >
  > Having the titlebar blend with the window kind of requires that nothing 
wants to be touching the titlebar, or else it just looks bad IMO. Personally my 
preference is to restore consistency by moving in the opposite direction by 
always showing a separator between what I'm calling the window's "tools area" 
(which consists of its titlebar + menubar if visible + toolbar if visible). 
That's what T10201  is all about and I had 
thought we had some agreement on that. If we land this patch, then there's no 
separator below the Tools Area for these windows, going against the goal of 
T10201 .

  From a visual POV I understand, we want to "finish the grid". But consistency 
and philosophically-wise we find ourselves in an awkward place now.

  We tell the people who don't want titlebars separators here that they should 
live with it, but to those who want titlebar separators in QWidgets config 
windows we tell that they should turn on KWin's option.

  Why I actually don't see this patch going against T10201 
 is that something's not a tools area if it 
there are no tools (or even menus) in it. It's just a titlebar.

  I take the tools area separator as proposed in the task to make sense as it's 
an element of internal design meant to help the structure of the whole 
application by singling out one of its semantic units.

  On the level of the fluidity of design it works because it doesn't separate 
KWin out from everything else in doing so.

  A titlebar separator doesn't do the two things just mentioned and I'd say 
it's is even somewhat orthogonal to the task because it's added externally with 
blindness to a specific app's design.

  tl;dr: for T10201  I wouldn't add a 
separator when we only have the titlebar.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Filip Fila

filipf planned changes to this revision.
filipf added a comment.


  I just realized this kills the sidebar when there's more than 1 kcm under a 
category :(

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-12-04 Thread Friedrich W. H. Kossebau

kossebau added a comment.


  Np other opinion? Would then go with this in the next days...

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D23005

To: kossebau, mart, broulik
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Filip Fila

filipf added a comment.


  So we also fix this by setting:
  
  ` d->moduleView()->setFaceType(KPageView::List);`
  
  But then then a sidebar shows up even if there is only 1 category.
  
  So just need to check for the number of categories and do `List` if > 1, 
otherwise `Plain`.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Filip Fila

filipf updated this revision to Diff 70889.
filipf added a comment.
This revision is now accepted and ready to land.


  don't break the sidebar

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25726?vs=70870&id=70889

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

AFFECTED FILES
  icons/IconMode.cpp

To: filipf, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25729: Make it compile without qt deprecated method

2019-12-04 Thread Laurent Montel

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f32965ea3a9f: Make it compile without qt deprecated 
method (authored by mlaurent).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25729?vs=70877&id=70890

REVISION DETAIL
  https://phabricator.kde.org/D25729

AFFECTED FILES
  discover/DiscoverDeclarativePlugin.cpp
  discover/DiscoverObject.cpp

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25709: Make it compile against qt5.14 without deprecated method

2019-12-04 Thread Laurent Montel

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8eca435225b6: Make it compile against qt5.14 without 
deprecated method (authored by mlaurent).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25709?vs=70876&id=70891

REVISION DETAIL
  https://phabricator.kde.org/D25709

AFFECTED FILES
  plugin/kquickstyleitem.cpp
  plugin/qqc2desktopstyleplugin.cpp

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-12-04 Thread Friedrich W. H. Kossebau

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8b0372d2932e: Fix typo in name of installed CMake Config: 
Deskop->Desktop (authored by kossebau).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23005?vs=70633&id=70894

REVISION DETAIL
  https://phabricator.kde.org/D23005

AFFECTED FILES
  CMakeLists.txt
  KF5QQC2DesktopStyleConfig.cmake.in

To: kossebau, mart, broulik, davidedmundson, apol
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25736: Make it compile without deprecated method

2019-12-04 Thread Laurent Montel

mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without deprecated method

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25736

AFFECTED FILES
  src/qml/plugin.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Anthony Fieroni

anthonyfieroni added a comment.


  Is that configurable (Window decorations -> ^ Draw separator between titlebar 
and a window ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Filip Fila

filipf added a comment.


  In D25728#572036 , @anthonyfieroni 
wrote:
  
  > Is that configurable (Window decorations -> ^ Draw separator between 
titlebar and a window ?
  
  
  No, the separator is always drawn.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Anthony Fieroni

anthonyfieroni added a comment.


  So with the patch is it drawn when it is ticked in window decoration?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Filip Fila

filipf added a comment.


  In D25728#572043 , @anthonyfieroni 
wrote:
  
  > So with the patch is it drawn when it is ticked in window decoration?
  
  
  Yes. With the patch there is only a top separator on the sidebar, not between 
the titlebar and window.
  
  Then you can turn on KWin's separator and get this:
  
  F7798893: image.png 
  
  TBH the top sidebar separator should ideally be disabled when KWin's 
separator is on.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Anthony Fieroni

anthonyfieroni added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25740: Add item spacing to size hint

2019-12-04 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: ndavis, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is what Adwaita Qt does [1] and it fixes the popup text being elided in 
Krita's filter popup with D25739 
  
  [1] 
https://github.com/FedoraQt/adwaita-qt/blob/master/style/adwaitastyle.cpp#L2856

TEST PLAN
  5.17?
  
  - Other comboboxes look unchanged because iirc it only uses that size hint 
for the popup contents in SH_ComboBoxPopup mode, not in the default case we 
have in Breeze usually
  
  Before
  F7798929: Screenshot_20191204_145032.png 

  After
  F7798925: Screenshot_20191204_144508.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25740

AFFECTED FILES
  kstyle/breezestyle.cpp

To: broulik, ndavis, hpereiradacosta
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> IconMode.cpp:144
> +// avoid double titles by setting the right face type before loading the 
> module
> +const int categoryCount = 
> d->categoryView->model()->rowCount(activeModule);
> +

Since this is only used once, you don't really need to define a variable to 
hold it; just use it directly in the `if` statement.

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-12-04 Thread Nathaniel Graham

ngraham updated this revision to Diff 70904.
ngraham marked an inline comment as done.
ngraham added a comment.


  ALso check for LowPowerIdle state

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25447?vs=70859&id=70904

BRANCH
  suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25447

AFFECTED FILES
  kcms/baloo/package/contents/ui/constants.js
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, #baloo, bruns
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-12-04 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in constants.js:23
> Why doesn't this come from the plugin?

I'm not sure exactly what that means or how to do it; can you help me with it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-12-04 Thread David Edmundson

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ngraham wrote in constants.js:23
> I'm not sure exactly what that means or how to do it; can you help me with it?

See D25743 

Code here would become Baloo.Idle

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25310: Use the right value of EnableMagicMimeActions

2019-12-04 Thread Tranter Madi

trmdi added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-enableMagicMimeActions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25310

To: trmdi, #plasma, ngraham, apol
Cc: ngraham, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25744: support userBackgroundhints in the scripting ui

2019-12-04 Thread Marco Martin

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  bind userBackgroundHints to the desktopscript interface

TEST PLAN
  from the scripting console is possible to correctly change applets background 
and 
  it gets immediately applied

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/hints

REVISION DETAIL
  https://phabricator.kde.org/D25744

AFFECTED FILES
  shell/scripting/widget.cpp
  shell/scripting/widget.h

To: mart, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25744: support userBackgroundhints in the scripting ui

2019-12-04 Thread Aleix Pol Gonzalez

apol added inline comments.

INLINE COMMENTS

> widget.h:71
> +QString userBackgroundHints() const;
> +void setUserBackgroundHints(QString hint);
> +

const&

or should it be Plasma::Types::BackgroundHints?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25744

To: mart, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25744: support userBackgroundhints in the scripting ui

2019-12-04 Thread Marco Martin

mart added inline comments.

INLINE COMMENTS

> apol wrote in widget.h:71
> const&
> 
> or should it be Plasma::Types::BackgroundHints?

everthing else presents strings to the engine.

i don't know if it's possible making enums work correctly with qjsengine (that 
is without qml)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25744

To: mart, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule

2019-12-04 Thread Tomaz Canabrava

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  showcase_kcofig_issue

REVISION DETAIL
  https://phabricator.kde.org/D25745

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/showcasekconfigerror/CMakeLists.txt
  kcms/showcasekconfigerror/Messages.sh
  kcms/showcasekconfigerror/README
  kcms/showcasekconfigerror/kcm.cpp
  kcms/showcasekconfigerror/kcm.h
  kcms/showcasekconfigerror/kcm_showcasekconfigerror.desktop
  kcms/showcasekconfigerror/package/contents/ui/main.qml
  kcms/showcasekconfigerror/package/metadata.desktop
  kcms/showcasekconfigerror/showcasekconfigerrorsettings.kcfg
  kcms/showcasekconfigerror/showcasekconfigerrorsettings.kcfgc

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.


  Otherwise LGTM

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25310: Use the right value of EnableMagicMimeActions

2019-12-04 Thread David Edmundson

davidedmundson added a comment.


  I can't really object, as you're just following the existing code, but I 
don't really understand why we're doing this.

INLINE COMMENTS

> urlgrabber.cpp:106
> -KConfigGroup cg(KSharedConfig::openConfig(), "Actions");
> -if(!cg.readEntry("EnableMagicMimeActions",true)) {
>  //qCDebug(KLIPPER_LOG) << "skipping mime magic due to configuration";

if (!KlipperSettings::enableMagicMimeActions())

without any other changes would do the same thing and be just as fast. The 
KConfigSkeletonItem keeps the value locally without reading every time.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-enableMagicMimeActions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25310

To: trmdi, #plasma, ngraham, apol
Cc: davidedmundson, ngraham, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25740: Add item spacing to size hint

2019-12-04 Thread Nathaniel Graham

ngraham added a comment.


  5.17 I'd say.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25740

To: broulik, ndavis, hpereiradacosta
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25310: Use the right value of EnableMagicMimeActions

2019-12-04 Thread Tranter Madi

trmdi added a comment.


  Ah, I think like you, just following the existing code. :D
  
  In D25310#572211 , @davidedmundson 
wrote:
  
  > I can't really object, as you're just following the existing code, but I 
don't really understand why we're doing this.
  
  
  Ah, I'm just following the existing code style.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-enableMagicMimeActions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25310

To: trmdi, #plasma, ngraham, apol
Cc: davidedmundson, ngraham, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Filip Fila

filipf updated this revision to Diff 70915.
filipf added a comment.


  define condition without creating a variable

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25726?vs=70889&id=70915

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

AFFECTED FILES
  icons/IconMode.cpp

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> IconMode.cpp:144
> +// avoid double titles by setting the right face type before loading the 
> module
> +if ( d->categoryView->model()->rowCount(activeModule) > 1) {
> +d->moduleView->setFaceType(KPageView::List);

pedantic nitpick: space before the final `)`

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Filip Fila

filipf updated this revision to Diff 70916.
filipf added a comment.


  add space before final )

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25726?vs=70915&id=70916

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

AFFECTED FILES
  icons/IconMode.cpp

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.


  5.17 I say

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Aleix Pol Gonzalez

apol created this revision.
apol added reviewers: Plasma, bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Allows specifying the shell through an environment variable.
  Allows forwarding command line arguments to kwin_wayland, since the arguments 
we
  use on plasma phone are slightly different.

TEST PLAN
  Builds, still starts

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

AFFECTED FILES
  shell/main.cpp
  startkde/startplasma-wayland.cpp

To: apol, #plasma, bshah
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Alexey Min

alexeymin added a comment.


  Good to see more flexibility!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Alexey Min

alexeymin added inline comments.

INLINE COMMENTS

> startplasma-wayland.cpp:91
> +} else {
> +args = QStringList { QStringLiteral("--xwayland"), 
> QStringLiteral("--libinput"), QStringLiteral("--exit-with-session=" 
> CMAKE_INSTALL_FULL_LIBEXECDIR "/startplasma-waylandsession") };
> +}

having `--xwayland` always by default will unfortunately break my device port 
(xwayland crashes for me for some reason)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule

2019-12-04 Thread Aleix Pol Gonzalez

apol commandeered this revision.
apol added a reviewer: tcanabrava.
apol added a comment.


  This can be closed now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25745

To: apol, ervin, tcanabrava
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Aleix Pol Gonzalez

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> alexeymin wrote in startplasma-wayland.cpp:91
> having `--xwayland` always by default will unfortunately break my device port 
> (xwayland crashes for me for some reason)

This is not changing, --xwayland is already on by default. In fact it will be 
possible to change the defaults by passing some arguments to 
startplasma-wayland.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Alexey Min

alexeymin added inline comments.

INLINE COMMENTS

> apol wrote in startplasma-wayland.cpp:91
> This is not changing, --xwayland is already on by default. In fact it will be 
> possible to change the defaults by passing some arguments to 
> startplasma-wayland.

Currently I can edit simple shell script (kwinwrapper) and remove the argument 
to kwin_wayland. If this is going to be hardcoded in the executable, it cannot 
be edited easily. I know I can work around (continue to use script). But 
despite the words "more flexible" in title, some flexibility in fact will be 
lost in the end (when using startplasma_wayland to start plasma-mobile session)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah
Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Marco Martin

mart accepted this revision as: mart.
mart added a comment.
This revision is now accepted and ready to land.


  +1 from me, would still like other opinions

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah, mart
Cc: mart, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

2019-12-04 Thread Filip Fila

filipf added a comment.


  In D25726#572255 , @ngraham wrote:
  
  > 5.17 I say
  
  
  I think that makes sense.
  
  I tested this by comparing every KCM with 5.17 system settings and saw no 
issues. Breadcrumb navigation worked as well.

REPOSITORY
  R124 System Settings

BRANCH
  no-double-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25726

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25751: [Notifications] Split draggable thumbnail area into its own component

2019-12-04 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I'm planning to use it in job notifications, too.
  This should also make it easier to migrate away from a custom drag 
implementation to using Qt's if we were to do that.

TEST PLAN
  - Took a screenshot:
  - clicking still opened the screenshot
  - right click still brought up the file menu
  - dragging the screenshot somewhere still worked
  - while the drag was active the timeout was halted
  - context menu button still worked

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25751

AFFECTED FILES
  applets/notifications/package/contents/ui/DraggableFileArea.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

2019-12-04 Thread Kai Uwe Broulik

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:31c75e48c833: Read BAMF_DESKTOP_FILE_HINT from 
environment (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22506?vs=61900&id=70923#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22506?vs=61900&id=70923

REVISION DETAIL
  https://phabricator.kde.org/D22506

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Manuel Jesús de la Fuente

manueljlin added a comment.


  But that style of line / divider was going to be after the toolbars too, like 
kirigami apps, so removing it just would make that inconsistent later on. If 
it's possible, fixing the color scheme and making it configurable should 
probably be the way to go.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Filip Fila

filipf added a comment.

  In D25728#572350 , @manueljlin 
wrote:

  > But that style of line / divider was going to be after the toolbars too, 
like kirigami apps, so removing it just would make that inconsistent later on. 
The divider needs to be inside the application itself to make this possible, 
instead of in the titlebar.
  >
  > If it's possible, fixing the color scheme and making it configurable should 
probably be the way to go.

  It's just wrong to locally draw a titlebar separator if there's a global 
option for it.

  For consistency with the proposals see: D25728#571938 

  I can also say that after seeing Sierra Breeze Enhanced implementing most of 
what was decided there (only!) when the titlebar separator option is on that 
it's something that we should also do.

  F7799465: sbe 

  KWin's titlebar option essentially becomes a "tools area distinguisher": 
turns on the titlebar separator (which gets hidden when app sends a hint that 
it has a tool area that is will separate on its own) and the different tool 
area color as well. Everything is consistent and in accordance to user choice.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2019-12-04 Thread Manuel Jesús de la Fuente

manueljlin added a comment.


  I though that would just affect every app's titlebar without actually 
checking if the app has a toolbar, etc etc and just add/remove the divider 
everywhere and be done with it. However, if the app can actually send a hint to 
Kwin to make it hide or show the divider depending if it has a toolbar or not 
(or maybe through a window / app rule), then it's great

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Aleix Pol Gonzalez

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> alexeymin wrote in startplasma-wayland.cpp:91
> Currently I can edit simple shell script (kwinwrapper) and remove the 
> argument to kwin_wayland. If this is going to be hardcoded in the executable, 
> it cannot be edited easily. I know I can work around (continue to use 
> script). But despite the words "more flexible" in title, some flexibility in 
> fact will be lost in the end (when using startplasma_wayland to start 
> plasma-mobile session)

Please see https://invent.kde.org/kde/plasma-phone-components/merge_requests/38

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah, mart
Cc: mart, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25758: Use the right value of enableMagicMimeActions

2019-12-04 Thread Tranter Madi

trmdi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25758

AFFECTED FILES
  klipper/urlgrabber.cpp

To: trmdi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25310: Use the right value of EnableMagicMimeActions

2019-12-04 Thread Tranter Madi

trmdi updated this revision to Diff 70933.
trmdi added a comment.


  Remove unneeded code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25310?vs=69759&id=70933

BRANCH
  fix-enableMagicMimeActions

REVISION DETAIL
  https://phabricator.kde.org/D25310

AFFECTED FILES
  klipper/urlgrabber.cpp

To: trmdi, #plasma, ngraham, apol
Cc: davidedmundson, ngraham, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25310: Use the right value of EnableMagicMimeActions

2019-12-04 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:895e31d6946b: Use the right value of 
EnableMagicMimeActions (authored by trmdi, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25310?vs=70933&id=70934

REVISION DETAIL
  https://phabricator.kde.org/D25310

AFFECTED FILES
  klipper/urlgrabber.cpp

To: trmdi, #plasma, ngraham, apol
Cc: davidedmundson, ngraham, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25459: fix(kcm): improve i18n of device combobox

2019-12-04 Thread Yunhe Guo

guoyunhe added a comment.


  Should we reassign a reviewer?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25459

To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik
Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Bhushan Shah

bshah added inline comments.

INLINE COMMENTS

> main.cpp:93
>  KConfigGroup startupConfGroup(startupConf, "Shell");
> -const QString defaultShell = startupConfGroup.readEntry("ShellPackage", 
> "org.kde.plasma.desktop");
> +const QString defaultShell = startupConfGroup.readEntry("ShellPackage", 
> qEnvironmentVariable("PLASMA_DEFAULT_SHELL", "org.kde.plasma.desktop"));
>  

I am bit unsure about this. We can simply write a configuration file in 
/etc/xdg using the plasma-phone-settings package.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah, mart, davidedmundson
Cc: mart, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Bhushan Shah

bshah accepted this revision.
bshah added inline comments.

INLINE COMMENTS

> bshah wrote in main.cpp:93
> I am bit unsure about this. We can simply write a configuration file in 
> /etc/xdg using the plasma-phone-settings package.

On second thought, scratch all this.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah, mart, davidedmundson
Cc: mart, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

2019-12-04 Thread Alexey Min

alexeymin added inline comments.

INLINE COMMENTS

> apol wrote in startplasma-wayland.cpp:91
> Please see 
> https://invent.kde.org/kde/plasma-phone-components/merge_requests/38

Indeed, I overlooked, probably lack of `{ }` around `for` loop confused me..

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25750

To: apol, #plasma, bshah, mart, davidedmundson
Cc: mart, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

54 matches

Mail list logo