date:20191206

D25800: docs: fix minor typos and address of plasma page

2019-12-06 Thread Yuri Chornoivan

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:f1b45c375d6e: docs: fix minor typos and address of plasma 
page (authored by yurchor).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25800?vs=71043&id=71046

REVISION DETAIL
  https://phabricator.kde.org/D25800

AFFECTED FILES
  kcm/package/contents/ui/main.qml
  kded/daemon.cpp
  kded/generator.cpp
  kded/osdmanager.cpp
  kded/output.cpp
  plasmoid/kscreenapplet.h
  plasmoid/package/metadata.desktop

To: yurchor, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25459: fix(kcm): improve i18n of device combobox

2019-12-06 Thread Phabricator

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:3b10f0da5aa9: fix(kcm): improve i18n of device combobox 
(authored by Guo Yunhe ).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25459?vs=70151&id=71045

REVISION DETAIL
  https://phabricator.kde.org/D25459

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml

To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik, romangg
Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25459: fix(kcm): improve i18n of device combobox

2019-12-06 Thread Yunhe Guo

guoyunhe added a comment.


  It seems impossible to align them if they are not in one QML file. 
`twinFormLayouts` can only refer ids of current context. This happens in 
several different KCMs. Would be great to have a solution for global alignment. 
But I think that need some changes to Kirigami.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25459

To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik, romangg
Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25800: docs: fix minor typos and address of plasma page

2019-12-06 Thread Yuri Chornoivan

yurchor created this revision.
yurchor added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Resubmit rejected trivial patch to conform kscreen standards of contributing

TEST PLAN
  the patch is trivial

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25800

AFFECTED FILES
  kcm/package/contents/ui/main.qml
  kded/daemon.cpp
  kded/generator.cpp
  kded/osdmanager.cpp
  kded/output.cpp
  plasmoid/kscreenapplet.h
  plasmoid/package/metadata.desktop

To: yurchor, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-12-06 Thread Nathaniel Graham

ngraham abandoned this revision.
ngraham added a comment.


  All right, sounds like I'm fighting the tide on this one. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: IlyaBizyaev, feverfew, tcanabrava, bruns, davidedmundson, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-12-06 Thread Ilya Bizyaev

IlyaBizyaev added a comment.


  Somehow I also feel Baloo is not a name to be surfaced...
  
  1. It's not really a brand, and if it was, it would have a terrible 
reputation due to all the user frustration accumulated.
  2. Those users on social media who know the name "Baloo" follow KDE 
development or have faced specific Baloo issues that made them learn the name. 
I agree with @davidedmundson in that the wider audience might be more confused 
by the change rather than enlightened.
  3. FWIW in Russian localization, the name "KRunner" was replaced everywhere 
with "Search and launch field", since "KRunner" does not mean anything to 
people who do not speak English.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: IlyaBizyaev, feverfew, tcanabrava, bruns, davidedmundson, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D25459: fix(kcm): improve i18n of device combobox

2019-12-06 Thread Roman Gilg

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Ignore my previous comment. I thought it was aligned before. But it wasn't 
aligned there either.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25459

To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik, romangg
Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25459: fix(kcm): improve i18n of device combobox

2019-12-06 Thread Roman Gilg

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  With this change controls are not aligned anymore in English language:
  
  F7802717: Screenshot_20191206_211348.png 

  
  Did you test it?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25459

To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik, romangg
Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[plasmashell] [Bug 370648] SDDM Breeze theme hardly usable on multiscreen set up with different DPIs

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=370648

--- Comment #3 from Nate Graham  ---
Ach. Wanna close this as UPSTREAM and mention the SDDM bug report?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384129] Rename colors from British to American English

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=384129

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/webs
   ||ites/hig-kde-org/commit/4b5
   ||ee2545247cb262762450b068118
   ||57137de900

--- Comment #6 from Nate Graham  ---
Git commit 4b5ee2545247cb262762450b06811857137de900 by Nate Graham.
Committed on 06/12/2019 at 19:48.
Pushed by ngraham into branch 'master'.

Replace Grey with Gray

...Since we use American English everywhere.

M  +---HIG/source/img/Breeze_Color_Palette.png
M  +21   -21   HIG/source/style/color/dark.rst
M  +12   -12   HIG/source/style/color/default.rst
M  +13   -13   HIG/source/style/color/high.rst
M  +9-9HIG/source/style/color/light.rst

https://invent.kde.org/websites/hig-kde-org/commit/4b5ee2545247cb262762450b06811857137de900

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 370648] SDDM Breeze theme hardly usable on multiscreen set up with different DPIs

2019-12-06 Thread David Edmundson

https://bugs.kde.org/show_bug.cgi?id=370648

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #2 from David Edmundson  ---
Urgh, we need to do this in SDDM itself, with a filtered screen selection like
we have in plasmashell.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 374074] Login/Lock Screen: "Show Password" button vulnerable to social engineering

2019-12-06 Thread David Edmundson

https://bugs.kde.org/show_bug.cgi?id=374074

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #10 from David Edmundson  ---


*** This bug has been marked as a duplicate of bug 412252 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 373668] Keyboard layout indicator is easy to miss due to placement in the corner of the screen

2019-12-06 Thread David Edmundson

https://bugs.kde.org/show_bug.cgi?id=373668

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 CC||k...@davidedmundson.co.uk
 Status|REPORTED|RESOLVED

--- Comment #19 from David Edmundson  ---
This is just a personal preference not a bug report. 
The original concern of making it obvious in the event of a wrong password has
been addressed in Kai's patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384129] Rename colors from British to American English

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=384129

--- Comment #5 from Nate Graham  ---
Just the HIG at this point. I'm changing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384129] Rename colors from British to American English

2019-12-06 Thread David Edmundson

https://bugs.kde.org/show_bug.cgi?id=384129

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #4 from David Edmundson  ---
Where does Breeze use the term grey/gray?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

2019-12-06 Thread Filip Fila

filipf added a comment.


  Yeah, that might not be a bad idea. Our GridDelegates do not support more 
than 1 line of text right now if I'm not mistaken though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25785

To: filipf, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25792: Add notifiers to workspace options kcfg

2019-12-06 Thread David Edmundson

davidedmundson added a comment.


  Linked revision is needed to have it work properly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25792

To: davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25792: Add notifiers to workspace options kcfg

2019-12-06 Thread David Edmundson

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  A write flag got lost in the KCFG port. This adds it back.

TEST PLAN
  dragged slider, kwin animation speed reloaded

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25792

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=340137

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 356619] I miss the option that you can change the width of the "blinking cursor" (=caret)

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=356619

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 370216] breeze sddm theme could have the password and username field text centered

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=370216

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |INTENTIONAL
 Status|REPORTED|RESOLVED

--- Comment #3 from Nate Graham  ---
I don't really think we should do this. As you've said, nothing else has the
proposed behavior. It would feel weird and I guarantee that we would get bug
reports about it.

Sorry. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 356619] I miss the option that you can change the width of the "blinking cursor" (=caret)

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=356619

Nate Graham  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REPORTED

--- Comment #2 from Nate Graham  ---
Oops, closed the wrong bug, sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 376620] breeze-dark: badly readable gray on gray text in plasma widgets

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=376620

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---
This has since been fixed. We improved the colors of the text to increase
contrast.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 356619] I miss the option that you can change the width of the "blinking cursor" (=caret)

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=356619

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||n...@kde.org
 Resolution|--- |FIXED

--- Comment #1 from Nate Graham  ---
This has since been fixed. We improved the colors of the text to increase
contrast.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378305] breeze-icons.rcc can't be cross-compiled

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=378305

Nate Graham  changed:

   What|Removed |Added

  Component|general |Icons
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---
Any chance you'd be interested i fixing this, Harald?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 370569] kde4breeze.upd ignores system distributor values from XDG_CONFIG_DIRS/kdeglobals

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=370569

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Nate Graham  ---
Is there anything about this that's still relevant today where Plasma 4 has
been obsolete for years?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 378528] WhisList: Dynamic Themes

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=378528

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Filip Fila  ---
We now have our own "redshift" so it's a possibility and has been discussed.

For the time being there's this if you haven't seen it:
https://github.com/zzag/plasma5-wallpapers-dynamic

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 370216] breeze sddm theme could have the password and username field text centered

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=370216

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com

--- Comment #2 from Filip Fila  ---
In both the login and logout screen we're using a generic Plasma component for
the input field:

https://api.kde.org/frameworks/plasma-framework/html/classorg_1_1kde_1_1plasma_1_1components_1_1TextField.html

If we change the text to be centered we're creating an inconsistency.

I'm also not don't know if it's doable.

And I've also not really seen lock and login screens with this sort of a
behavior.

Nate, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 379022] Update Task Switcher screenshots

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=379022

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||n...@kde.org,
   ||plasma-b...@kde.org
 Status|REPORTED|RESOLVED
   Target Milestone|--- |1.0
Product|Breeze  |plasmashell
  Component|general |Look & Feel package

--- Comment #6 from Nate Graham  ---
This has since been done.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=375909

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com

--- Comment #5 from Filip Fila  ---
I haven't been seeing this in the recent releases. The SDDM theme points to the
Next wallpaper.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375684] Please improve app status indicators in icon-only task manager

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=375684

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||n...@kde.org
 Status|REPORTED|RESOLVED

--- Comment #2 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 370465 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 384129] Rename colors from British to American English

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=384129

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |minor
 Ever confirmed|0   |1
 CC||n...@kde.org
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=375909

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Nate Graham  ---
Can anyone still reproduce this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 373668] Keyboard layout indicator is easy to miss due to placement in the corner of the screen

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=373668

Nate Graham  changed:

   What|Removed |Added

Summary|Lock Screen should warn |Keyboard layout indicator
   |when the keyboard status is |is easy to miss due to
   |not default |placement in the corner of
   |(layout/capslock)   |the screen
   Target Milestone|--- |1.0
 CC||n...@kde.org,
   ||plasma-b...@kde.org
  Component|general |Look & Feel package
Product|Breeze  |plasmashell

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 374074] Login/Lock Screen: "Show Password" button vulnerable to social engineering

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=374074

Nate Graham  changed:

   What|Removed |Added

Summary|Lock Screen: "Show  |Login/Lock Screen: "Show
   |Password" - lockscreen  |Password" button vulnerable
   |vulnerable to social|to social engineering
   |engineering |
Version|unspecified |5.17.4
 CC||n...@kde.org,
   ||plasma-b...@kde.org
   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=414399
   Target Milestone|--- |1.0
Product|Breeze  |plasmashell
  Component|general |Look & Feel package

--- Comment #9 from Nate Graham  ---
(In reply to Elias Probst from comment #0)
> The password field should be cleared:
> 
> - after X seconds of inactivity
> - when switching to another VT
> - when suspending/resuming

Done in
https://cgit.kde.org/plasma-workspace.git/commit/?id=a4e18e2be1348e7d6fd7fbe0c553ef0eb7120319

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 368942] Splash screen spinner should disappear instead of pause when fading into desktop

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=368942

Nate Graham  changed:

   What|Removed |Added

   Target Milestone|--- |1.0
 CC||n...@kde.org,
   ||plasma-b...@kde.org
  Component|general |Look & Feel package
Product|Breeze  |plasmashell
Version|unspecified |5.17.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 368942] Splash screen spinner should disappear instead of pause when fading into desktop

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=368942

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com
Version|5.7.95  |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 352510] Wifi Icons (Airplane Mode, Wifi) Doesn't display sometimes in network menu in menu bar

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=352510

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Nate Graham  ---
This is fixed now, by improvements in the icon theme.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 370216] breeze sddm theme could have the password and username field text centered

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=370216

Nate Graham  changed:

   What|Removed |Added

Product|Breeze  |plasmashell
  Component|general |Look & Feel package
 CC||n...@kde.org,
   ||plasma-b...@kde.org
   Target Milestone|--- |1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 370648] SDDM Breeze theme hardly usable on multiscreen set up with different DPIs

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=370648

Nate Graham  changed:

   What|Removed |Added

Product|Breeze  |plasmashell
  Component|general |Look & Feel package
 CC||n...@kde.org,
   ||plasma-b...@kde.org
   Target Milestone|--- |1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 374057] Breeze Gimp Theme

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=374057

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #1 from Nate Graham  ---
GIMP 2.10 already includes a monochrome icon theme that doesn't look exactly
like Breeze, but it's in the same vein. I don't think we're going to explicitly
create a Breeze icon theme for GIMP, but of course if someone else wanted to
and submit it to GIMP, that would be lovely. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 368941] SDDM theme: Login screen password field is not auto selected when returning from Different Users list

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=368941

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
Summary|Login screen password field |SDDM theme: Login screen
   |is not auto selected when   |password field is not auto
   |returning from Different|selected when returning
   |Users list  |from Different Users list
Version|5.7.95  |unspecified

--- Comment #1 from Filip Fila  ---
This is true for 5.17, but is fixed in master (pre 5.18)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=365318

Filip Fila  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||filipfila@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #15 from Filip Fila  ---
I can't reproduce this. Is it still happening for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 365690] kaccessibleapp icon

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=365690

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Filip Fila  ---
Is this still an issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 365264] The color of the border in the bottom of the panel is very bright.

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=365264

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Filip Fila  ---
I can't reproduce this anymore, I'm only seeing the panel shadow, no white
line.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 364395] Icon indicating grouped windows is oddly large and off-center

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=364395

Filip Fila  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||filipfila@gmail.com

--- Comment #3 from Filip Fila  ---
It's a lot smaller nowadays.

https://i.imgur.com/v57SZm5.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[plasmashell] [Bug 362387] breeze sddm theme is unusable with a large number of users

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=362387

Nate Graham  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
   Target Milestone|--- |1.0
 CC||plasma-b...@kde.org
  Component|general |Look & Feel package
Product|Breeze  |plasmashell
Version|5.6.3   |5.8.0
 Resolution|WAITINGFORINFO  |FIXED

--- Comment #4 from Nate Graham  ---
Thanks, sounds like it's been fixed by the 10-user maximum limit on showing the
icon row.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-12-06 Thread Nathaniel Graham

ngraham added a comment.


  In D25278#573294 , @feverfew wrote:
  
  > What about "Baloo file search"?
  
  
  That's exactly what this patch changes it to in the tooltip and help text.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: feverfew, tcanabrava, bruns, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-12-06 Thread Alexander Saoutkin

feverfew added a comment.


  What about "Baloo file search"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: feverfew, tcanabrava, bruns, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=364953

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||n...@kde.org
 Ever confirmed|0   |1
   Keywords||usability

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

2019-12-06 Thread Nathaniel Graham

ngraham added a comment.


  In D25785#573291 , @broulik wrote:
  
  > Alternatively, maybe we need a second line of label text?
  >  so it is
  > Breeze
  >  [lighter gray text] Follows system colors [/lighter gray text]
  
  
  Ooh, I like that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25785

To: filipf, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

2019-12-06 Thread Kai Uwe Broulik

broulik added a comment.


  That double tooltip looks a bit unpolished but not sure what to do about it. 
Perhaps instead sow that as tooltip for the icon theme? so it shows "Breeze 
(This theme follows your system color scheme)"`?
  Alternatively, maybe we need a second line of label text?
  so it is
  Breeze
  [lighter gray text] Follows system colors [/lighter gray text]

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25785

To: filipf, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

2019-12-06 Thread Nathaniel Graham

ngraham added a comment.


  Very nice! I wonder if the symbol's meaning might be too obscure though 
(icons with no labels generally have poor usability; see 
https://www.nngroup.com/articles/icon-usability/). It's good to have a tooltip, 
but this won't help for the touch use case, or for the desktop.laptop users who 
don't think to hover the icon. Maybe a label in the KCM's footer explaining 
what that symbol means might help? There's room to the left of the buttons, so 
it wouldn't take up any additional vertical space.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25785

To: filipf, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=341762

Nate Graham  changed:

   What|Removed |Added

 CC||marco.nape...@gmail.com

--- Comment #15 from Nate Graham  ---
*** Bug 365710 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 365710] sddm really slow when using Breeze theme

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=365710

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 341762 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 362387] breeze sddm theme is unusable with a large number of users

2019-12-06 Thread Antony Lee

https://bugs.kde.org/show_bug.cgi?id=362387

--- Comment #3 from Antony Lee  ---
(I don't run into this use case anymore, so I'll let you hash this out :))

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=341762

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||n...@kde.org
 Status|REPORTED|RESOLVED

--- Comment #14 from Nate Graham  ---
Since there have been changes relevant to this bug since it was filed, and
folks can no longer reproduce it, let's close it until we get new reports.
Thanks everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=369158

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Nate Graham  ---
(Please respond if it does)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 362387] breeze sddm theme is unusable with a large number of users

2019-12-06 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=362387

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability
 Resolution|--- |WAITINGFORINFO
 CC||n...@kde.org
 Status|CONFIRMED   |NEEDSINFO

--- Comment #2 from Nate Graham  ---
Could you attach a picture of what it looks like when it's in this sub-optimal
view today? The UI has changed a lot in the intervening years and the theme no
longer displays a horizontal row of icons when there are more than 10 users.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

2019-12-06 Thread Filip Fila

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The discoverability of the system color scheme awareness feature of some 
Plasma themes right now is very poor.
  
  In addition to that the previews for Breeze and Breeze Light look identical 
when using the default color scheme.
  
  To fix this we add a little color wheel icon in the top right corner of the 
theme preview that only shows up if the theme supports this.
  
  Credits go to @broulik for most of the code, I just positioned the icon.
  
  BUG: 364953

REPOSITORY
  R119 Plasma Desktop

BRANCH
  little-color-sign (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25785

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml

To: filipf
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-12-06 Thread Nathaniel Graham

ngraham added a comment.


  In D25278#573181 , @tcanabrava 
wrote:
  
  > I would also say that 'Baloo' means nothing to users, and File search 
should be used instead. It's an internal name, not really a brand.
  
  
  It's an internal name that has its own logo and that we use in communication 
to users in release announcements. It's a widely-used name in social media. 
Even if we didn't indend for it to be a brand name, it happened anyway, so at 
this point we can ignore that, or embrace it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: tcanabrava, bruns, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25375: Start of the accessibility KCM

2019-12-06 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Now the KCM doesn't load:
  

"file:///home/nate/kde/usr/share/kpackage/kcms/kcmaccess/contents/ui/main.qml" 
 "Error loading QML file.\n76: ListElement: cannot use script for property 
value\n"
  
  Also can you mark the inline comments as done once they're addressed? That 
makes it easier to review. Thanks!

INLINE COMMENTS

> tcanabrava wrote in ModifierKeys.qml:51
> I can't correct you here, those where the original texts and since haven't 
> got a clue on what they are talking about I choose not to change them.

> since haven't got a clue on what they are talking about

That's a great sign that they're in desperate need of being changed. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D13243: [applet] Add checkbox to show virtual streams

2019-12-06 Thread Nathaniel Graham

ngraham added a comment.


  Oh that's the easy part. Check out the code in KScreen to see how it's 
possible to export values under a "kcm" namespace.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: baberts, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25782: [Notifications] Add draggable file icon when single file job finishes

2019-12-06 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> ngraham wrote in notificationapplet.h:73
> maybe use one of the standard sizes instead of a hardcoded int?

That's the default, there's a `Binding` to `units.iconSizes.large` in `main.qml`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25782

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25782: [Notifications] Add draggable file icon when single file job finishes

2019-12-06 Thread Nathaniel Graham

ngraham added a comment.


  Awesome, this is super-dee-duper useful! +1!

INLINE COMMENTS

> notificationapplet.h:73
>  bool m_dragActive = false;
> +int m_dragPixmapSize = 64;
>  

maybe use one of the standard sizes instead of a hardcoded int?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25782

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-12-06 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:93
> Monitor's property is called state. Lowercase S.
> 
> A switch statement here might make this a bit easier to read.

Done, but now opening the KCM prints a ton of these errors:

  QMetaProperty::read: Unable to handle unregistered datatype 
'Baloo::IndexerState' for property 'Baloo::Monitor::state'

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2019-12-06 Thread Nathaniel Graham

ngraham updated this revision to Diff 71013.
ngraham added a comment.


  Address review comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25447?vs=70998&id=71013

BRANCH
  suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25447

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov, 
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-12-06 Thread Tomaz Canabrava

tcanabrava added a comment.


  I would also say that 'Baloo' means nothing to users, and File search should 
be used instead. It's an internal name, not really a brand.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: tcanabrava, bruns, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25449: Start of the new Formats KCM

2019-12-06 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> Messages.sh:2
>  #! /usr/bin/env bash
> -$EXTRACTRC *.ui >> rc.cpp
> -$XGETTEXT *.cpp -o $podir/kcmformats.pot
> +$EXTRACTRC `find . -name "*.ui"` >> rc.cpp || exit 11
> +$XGETTEXT `find . -name "*.cpp"` -o $podir/kcm5_formats.pot

this should say qml  somewhere?

> README:1
> +Plasma KCM Template
> +--

not relevant

> formatssettings.kcfg:2
> +
> +http://www.kde.org/standards/kcfg/1.0";
> +  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";

ooh, nice

> localemodel.cpp:15
> +// Ensure that the "Default (C)" locale always appears at the top
> +if (c1.name()== QLatin1Char('C') && c2.name()!=QLatin1String("C")) 
> return true;
> +if (c2.name()== QLatin1Char('C')) return false;

c1 == QLocale::c()

might be better than comparing names?

> localemodel.h:29
> +Q_INVOKABLE int indexFor(const QString& value) const;
> +Q_INVOKABLE QString valueFor(int idx) const;
> +private:

this is duplicating data()  no?

> main.qml:117
> +currentIndex: kcm.model.indexFor(kcm.settings.lC_REGION)
> +onCurrentIndexChanged: {
> +kcm.settings.lC_REGION = kcm.model.valueFor(currentIndex)

there's another signal should be used

onActivated or sth that only includes user updates

> metadata.desktop:3
> +Name=Formats
> +Comment=what your app does in a few words
> +Icon=Plasma

->

> metadata.desktop:12-15
> +X-KDE-ServiceTypes=Plasma/Generic
> +X-Plasma-API=declarativeappletscript
> +
> +X-Plasma-MainScript=ui/main.qml

All of these 3 lines are wrong

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24374: WIP: Initial port of the Date and Time KCM

2019-12-06 Thread Tomaz Canabrava

tcanabrava added a comment.


  F7802151: kcm_clock.png  Quite ugly I'm 
afraid.
  I'll port this to KConfigXT over next week.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24374

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25449: Start of the new Formats KCM

2019-12-06 Thread Tomaz Canabrava

tcanabrava added a comment.


  ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 352506] Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=352506

Filip Fila  changed:

   What|Removed |Added

Version|5.4.0   |unspecified
 CC||filipfila@gmail.com,
   ||noaha...@gmail.com,
   ||uhh...@gmail.com

--- Comment #3 from Filip Fila  ---
Unfortunately I believe this is still a problem. 

We've actually been working to solve the problem of white text on the awfully
bright Plasma Blue everywhere.

Noah and Carson, would you want to fix the high contrast theme in the meantime?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25375: Start of the accessibility KCM

2019-12-06 Thread Tomaz Canabrava

tcanabrava added a comment.


  Updated texts by ngraham sugestions.

INLINE COMMENTS

> ngraham wrote in ActivationGestures.qml:50
> This section doesn't have anything to do with activation gestures. Its 
> checkboxes might be better placed on other pages more relevant to their 
> content.

Agree. This is a 1 to 1 translation of the old KCM. I'm doing the changes you 
requested.

> ngraham wrote in ModifierKeys.qml:51
> Can be shortened to "Use system bell when modifier keys are used" (I *think* 
> this is what the string is trying to  communicate; correct me if I'm wrong)

I can't correct you here, those where the original texts and since haven't got 
a clue on what they are talking about I choose not to change them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

2019-12-06 Thread Tomaz Canabrava

tcanabrava updated this revision to Diff 71008.
tcanabrava added a comment.


  - Fix localization calls

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=71005&id=71008

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25782: [Notifications] Add draggable file icon when single file job finishes

2019-12-06 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This adds a file icon to a finished job for a single total file which can be 
dragged anywhere for convenience.

TEST PLAN
  Often I download a file and then want to send it to someone, so being able to 
drag it off the notification similar to how you can do it with the screenshot 
notification is super useful.
  
  The button glows on hover and has the open hand cursor to indicate it can be 
dragged
  F7802057: Screenshot_20191206_125415.png 

  Clicking it opens the file and right click opens a file context menu. It is 
kinda redundant with the "Open" and menu button but I think something that 
looks like a file should be have like a file and those visual actions should be 
kept for accessibility.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25782

AFFECTED FILES
  applets/notifications/notificationapplet.cpp
  applets/notifications/notificationapplet.h
  applets/notifications/package/contents/ui/JobItem.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

2019-12-06 Thread Tomaz Canabrava

tcanabrava updated this revision to Diff 71005.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Typos and onToggled instead of onCheckStateChanged
  - Better UX / Texts
  - Text updates
  - Remove ActivationGestures page, Fix orca information

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70754&id=71005

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-06 Thread Filip Fila

filipf added inline comments.

INLINE COMMENTS

> main.qml:97
>  fill: parent
>  margins: 10
>  }

I would do something standardized like largeSpacing.

> main.qml:100
> +Layout.alignment: Qt.AlignHCenter
> +ColumnLayout {
> +Layout.alignment: Qt.AlignHCenter

No need to have this IMO.

Just put the buttons in the Form Layout and then have them match the fields' 
width.

Normally you would just have them fill the width but because the label above 
can be long you'd need to assign an id to one of the field and have the 
buttons's implicitWidth match the width of the field.

F7802006: image.png 

> main.qml:106
> +QQC2.Label {
> +text: i18n("Plugin Name:") + lnfLogic.theme
> +}

("Plugin name: ")

> main.qml:165
>  anchors.centerIn: parent
>  text: i18n("click to open an image")
>  visible: thumbnail.source == ""

"Click to set preview image..."

I think it has to be that way because further action is required when clicking.

> main.qml:195
>  }
> -Button {
> +QQC2.Button {
>  anchors {

This button need more margins.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma
Cc: filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 361170] breeze sddm theme login screen should use a specific font (Noto Sans?)

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=361170

Filip Fila  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|REPORTED|RESOLVED
 CC||filipfila@gmail.com

--- Comment #1 from Filip Fila  ---
This might have been different in 2016, but nowadays I know the login screen
always uses 9pt Noto Sans. 

Once sddm 0.19 gets released the sync option in the sddm kcm will enabled easy
syncing of font you're using in Plasma (if should happen the login screen one
is wrong in any way).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 350434] SDDM theme does not use Breeze user icons

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=350434

Filip Fila  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||filipfila@gmail.com
 Resolution|--- |FIXED

--- Comment #5 from Filip Fila  ---
This was an issue with the old theme.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 362387] breeze sddm theme is unusable with a large number of users

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=362387

Filip Fila  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||filipfila@gmail.com

--- Comment #1 from Filip Fila  ---
I agree that our default design is inadequate when there are a lot of users.

We could have another theme where manual input is default.

Not sure how feasible it is to have a combobox of sorts of users though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 365710] sddm really slow when using Breeze theme

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=365710

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com

--- Comment #1 from Filip Fila  ---
Do you still have this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=341762

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com

--- Comment #13 from Filip Fila  ---
Is this still relevant?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

2019-12-06 Thread Filip Fila

https://bugs.kde.org/show_bug.cgi?id=369158

Filip Fila  changed:

   What|Removed |Added

 CC||filipfila@gmail.com

--- Comment #3 from Filip Fila  ---
Does this still happen?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D13243: [applet] Add checkbox to show virtual streams

2019-12-06 Thread Sefa Eyeoglu

sefaeyeoglu added a comment.


  In D13243#572829 , @ngraham wrote:
  
  > @sefaeyeoglu what do you think about the above? ^^
  
  
  I could find the time to work on this yet. Generally I like that idea. We 
could then also make the volume step global instead of per applet, which is 
already weird, too. I guess the plasma-pa KCM's Advanced tab would be suitable 
for these options. How could we expose the values of the KCM to the applet 
though?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: baberts, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Still Failing!

2019-12-06 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/25/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 06 Dec 2019 08:35:43 +
 Build duration:
2 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 269 lines...][2019-12-06T08:38:18.981Z] BUILD_ID  = '25'[2019-12-06T08:38:18.981Z] LESSKEY   = '/etc/lesskey.bin'[2019-12-06T08:38:18.981Z] OLDPWD= '/home/jenkins'[2019-12-06T08:38:18.981Z] LC_CTYPE  = 'C.UTF-8'[2019-12-06T08:38:18.981Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-12-06T08:38:18.981Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-12-06T08:38:18.981Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-12-06T08:38:18.981Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-12-06T08:38:18.981Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-12-06T08:38:18.981Z] QT_SELECT = 'qt5'[2019-12-06T08:38:18.981Z] LANG  = 'en_US.UTF-8'[2019-12-06T08:38:18.981Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-12-06T08:38:18.981Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-12-06T08:38:18.981Z] [2019-12-06T08:38:18.981Z] [2019-12-06T08:38:18.981Z] == Commencing Configuration:[2019-12-06T08:38:18.981Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12"[2019-12-06T08:38:19.923Z] -- The C compiler identification is GNU 9.2.1[2019-12-06T08:38:19.923Z] -- The CXX compiler identification is GNU 9.2.1[2019-12-06T08:38:19.923Z] -- Check for working C compiler: /usr/bin/cc[2019-12-06T08:38:19.923Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-12-06T08:38:19.923Z] -- Detecting C compiler ABI info[2019-12-06T08:38:19.923Z] -- Detecting C compiler ABI info - done[2019-12-06T08:38:19.923Z] -- Detecting C compile features[2019-12-06T08:38:19.923Z] -- Detecting C compile features - done[2019-12-06T08:38:19.923Z] -- Check for working CXX compiler: /usr/bin/c++[2019-12-06T08:38:20.180Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-12-06T08:38:20.180Z] -- Detecting CXX compiler ABI info[2019-12-06T08:38:20.180Z] -- Detecting CXX compiler ABI info - done[2019-12-06T08:38:20.180Z] -- Detecting CXX compile features[2019-12-06T08:38:20.180Z] -- Detecting CXX compile features - done[2019-12-06T08:38:20.180Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for kgamma.[2019-12-06T08:38:20.180Z] -- Looking for __GLIBC__[2019-12-06T08:38:20.180Z] -- Looking for __GLIBC__ - found[2019-12-06T08:38:20.180Z] -- Performing Test _OFFT_IS_64BIT[2019-12-06T08:38:20.180Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-12-06T08:38:20.180Z] -- Performing Test HAVE_DATE_TIME[2019-12-06T08:38:20.438Z] -- Performing Test HAVE_DATE_TIME - Success[2019-12-06T08:38:20.438Z] -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.65.0") [2019-12-06T08:38:20.438Z] -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.65.0") [2019-12-06T08:38:20.438Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.65.0") [2019-12-06T08:38:20.438Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2019-12-06T08:38:20.438Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.65.0") [2019-12-06T08:38:20.438Z] -- Found KF5: success (found suitable version "5.65.0", minimum required is "5.62.0") found components:  Config ConfigWidgets DocTools I18n [2019-12-06T08:38:20.438Z] -- Found X11: /usr/include   [2019-12-06T08:38:20.438Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so[2019-12-06T08:38:20.438Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found[2019-12-06T08:38:20.438Z] -- Looking for gethostbyname[2019-12-06T08:38:20.438Z] -- Looking for gethostbyname - found[2019-12-06T08:38:20.438Z] -- Looking for connect[2019-12-06T08:38:20.438Z] -- Looking for connect - found[2019-12-06T08:38:20.438Z] -- Looking for remove[2019-12-06T08:38:20.699Z] -- Looking for remove - found[2019-12-06T08:38:20.699Z] -- Looking for shmat[2019-12-06T08:38:20.699Z] -- Looking for shmat - found[2019-12-06T08:38:20.699Z] -- Looking for IceConnectionNumber in ICE[2019-12-06T08:38:20.699Z

D25780: [Notifications] Set total amount to processed amount if no total and no error

2019-12-06 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Some jobs only set a processed amount and no total. This patch ensures when 
the job finishes, the total amount at least matches the processed amount.
  The UI handles 1 out of 0 gracefully (only shows "1 file") but only if there 
is 1 total file will it offer to open the file.

TEST PLAN
  5.17
  The job should probably be fixed but I've seen others (I think trash job) 
also not doing it properly
  
  - Sent a file from KDE Connect to my PC, got "Open" offered for that file

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25780

AFFECTED FILES
  libnotificationmanager/job_p.cpp

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-06 Thread Yunhe Guo

guoyunhe added a comment.


  If your use `as QQC2` in your imports, `ComboBox` need to be changed to 
`QQC2.ComboBox`.

INLINE COMMENTS

> MetadataEditor.qml:108
>  }
>  ComboBox {
>  id: licenseField

This need to be changed to `QQC2.ComboBox`

> main.qml:49
> +collapsed: false;
>  topContent: ComboBox {
>  id: themeSelector

This need to be changed to `QQC2.ComboBox`

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25778

To: ognarb, #vdg, #plasma
Cc: guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

87 matches

Mail list logo