D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Michail Vourlakos 
mvourlakos added inline comments.

INLINE COMMENTS

> shellcorona.h:94
> +// plasmashellCorona's value
> +QRegion _availableScreenRegion(int id) const;
> +QRect _availableScreenRect(int id) const;

maybe concerning naming, plasmaAvailableScreenRegion would be better

> shellcorona.h:95
> +QRegion _availableScreenRegion(int id) const;
> +QRect _availableScreenRect(int id) const;
> +

maybe concerning naming, plasmaAvailableScreenRect would be better

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Tranter Madi 
trmdi updated this revision to Diff 71980.
trmdi added a comment.


  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
add-otherShellHelper
  - Just rename the screenId parameter of test()

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=71979&id=71980

BRANCH
  add-otherShellHelper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Tranter Madi 
trmdi updated this revision to Diff 71979.
trmdi added a comment.


  - Use screenName instead of id in setAvailableScreenRect/Region()

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=71802&id=71979

BRANCH
  add-otherShellHelper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26069: Fix usage of deprecated QSet/QList methods

2019-12-21 Thread Alexey Min 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:34d68d4ec5a5: Fix usage of deprecated QSet/QList methods 
(authored by alexeymin).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26069?vs=71749&id=71977

REVISION DETAIL
  https://phabricator.kde.org/D26069

AFFECTED FILES
  libdiscover/resources/StandardBackendUpdater.cpp

To: alexeymin, apol, ngraham
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

2019-12-21 Thread Nathaniel Graham 
ngraham commandeered this revision.
ngraham edited reviewers, added: hallas; removed: ngraham.
ngraham added a comment.


  Done in D26139 .

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: ngraham, #vdg, #breeze, abetts, ndavis, hallas
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-21 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much clearer.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26147

To: meven, ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Michail Vourlakos 
mvourlakos added a comment.


  In D25807#581178 , @trmdi wrote:
  
  > In D25807#581161 , @mvourlakos 
wrote:
  >
  > > In D25807#581126 , @trmdi 
wrote:
  > >
  > > > @mvourlakos 
  > > >  Latte can guard that the order of screens within Latte is synced with 
plasmashell right? Because I see this: 
https://github.com/KDE/latte-dock/blob/master/app/screenpool.cpp
  > >
  > >
  > > why the screens order is relevant in this patch? the external application 
isnt just using the screen name?
  >
  >
  > Because I don't know which one latte could use for setting the 
availablescreenrect. Currently I use id, but David said that the id might be 
not synced between processes.
  >  So you mean I should use screen name instead? The screen names are the 
same within latte vs plasmashell right?
  
  
  Even though Latte understands the plasma screen ids and can use them, I dont 
think the external apps should have that burden. The screenName is enough from 
my understanding.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Tranter Madi 
trmdi added a comment.


  In D25807#581161 , @mvourlakos 
wrote:
  
  > In D25807#581126 , @trmdi wrote:
  >
  > > @mvourlakos 
  > >  Latte can guard that the order of screens within Latte is synced with 
plasmashell right? Because I see this: 
https://github.com/KDE/latte-dock/blob/master/app/screenpool.cpp
  >
  >
  > why the screens order is relevant in this patch? the external application 
isnt just using the screen name?
  
  
  Because I don't know which one latte could use for setting the 
availablescreenrect. Currently I use id, but David said that the id might be 
not synced between processes.
  So you mean I should use screen name instead? The screen names are the same 
within latte vs plasmashell right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26149: Change krunner calculator to display significant digits

2019-12-21 Thread Lukas Pichler 
lukjp created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lukjp requested review of this revision.

REVISION SUMMARY
  Change the qalculate krunner module to print only significant digits instead 
of an interval as this is sometimes unreadable.
  BUG: 412627

REPOSITORY
  R120 Plasma Workspace

BRANCH
  krunner-qalculate-no-interval (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26149

AFFECTED FILES
  runners/calculator/qalculate_engine.cpp

To: lukjp
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Michail Vourlakos 
mvourlakos added a comment.


  In D25807#581126 , @trmdi wrote:
  
  > @mvourlakos 
  >  Latte can guard that the order of screens within Latte is synced with 
plasmashell right? Because I see this: 
https://github.com/KDE/latte-dock/blob/master/app/screenpool.cpp
  
  
  why the screens order is relevant in this patch? the external application 
isnt just using the screen name?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26139: Revert "Revert "Reduce the indicator arrow size for press-and-hold menus in QToolButtons""

2019-12-21 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:288c3b85f16c: Revert "Revert "Reduce the 
indicator arrow size for press-and-hold menus in… (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26139?vs=71931&id=71964

REVISION DETAIL
  https://phabricator.kde.org/D26139

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26121: Kicker/RecentDocument display file path as decoration

2019-12-21 Thread Méven Car 
meven added a comment.


  In D26121#581070 , @ngraham wrote:
  
  > Nice, I think this makes sense. Now Kickoff's Computer tab needs the same 
treatment or else the paths are oddly inconsistent.
  
  
  In another diff, the patch is very simple : D26147 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26121

REVISION DETAIL
  https://phabricator.kde.org/D26121

To: meven, #vdg, #plasma, ngraham, ervin
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-21 Thread Méven Car 
meven created this revision.
meven added reviewers: ngraham, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  The path of places is not very informative to users
  Follow the path of D26121 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26147

AFFECTED FILES
  applets/kicker/plugin/computermodel.cpp

To: meven, ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Tranter Madi 
trmdi added a comment.


  @mvourlakos 
  Latte can guard that the order of screens are the same with plasmashell 
right? Because I see this: 
https://github.com/KDE/latte-dock/blob/master/app/screenpool.cpp

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-21 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d21cb2e7a95b: Add byte display option in Network Monitor 
plasmoid (authored by gvgeo, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26124?vs=71926&id=71961

REVISION DETAIL
  https://phabricator.kde.org/D26124

AFFECTED FILES
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: gvgeo, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-21 Thread Nathaniel Graham 
ngraham added a comment.


  Lovely contribution, thanks very much!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26124

To: gvgeo, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-21 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Maybe next you can figure out what causes this bizarre behavior: F7828232: 
demo-2019-12-21_09.54.54.webm 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26052

To: bport, #plasma, ervin, crossi, ngraham
Cc: ngraham, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

2019-12-21 Thread Filip Fila 
filipf added a comment.


  In D21978#581032 , @GB_2 wrote:
  
  > Can you please try to further investigate this?
  
  
  I already tried finding some other solution, but this is the best I can do 
unfortunately. I just run a local copy of Kickoff with this patch to avoid the 
bug.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21978

To: filipf, hein, #plasma, ngraham
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26045: Add immutability to KCM Icons

2019-12-21 Thread Nathaniel Graham 
ngraham added a comment.


  Needs a rebase

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-21 Thread Tranter Madi 
trmdi added a comment.


  In D25807#578640 , @davidedmundson 
wrote:
  
  > The problem is that on wayland (and to some extent x11 is racey) the order 
of screens within QApplication::screens might not be in sync across processes.
  
  
  Is it possible to handle this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-21 Thread Benjamin Port 
bport updated this revision to Diff 71958.
bport added a comment.


  Call ManagedConfiModule load/save/defaults parent method

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26052?vs=71681&id=71958

REVISION DETAIL
  https://phabricator.kde.org/D26052

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, ervin, crossi
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26121: Kicker/RecentDocument display file path as decoration

2019-12-21 Thread Nathaniel Graham 
ngraham added a comment.


  Nice, I think this makes sense. Now Kickoff's Computer tab needs the same 
treatment or else the paths are oddly inconsistent.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26121

REVISION DETAIL
  https://phabricator.kde.org/D26121

To: meven, #vdg, #plasma, ngraham, ervin
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26045: Add immutability to KCM Icons

2019-12-21 Thread Benjamin Port 
bport added inline comments.

INLINE COMMENTS

> bport wrote in main.qml:55
> Problem with this solution it will disable also icon size components, and we 
> don't want that, if you have a nicer solution

my bad missread indeed view.enabled do what I want

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26045: Add immutability to KCM Icons

2019-12-21 Thread Benjamin Port 
bport updated this revision to Diff 71957.
bport added a comment.


  Take in consideration broulik feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26045?vs=71672&id=71957

REVISION DETAIL
  https://phabricator.kde.org/D26045

AFFECTED FILES
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-21 Thread Benjamin Port 
bport updated this revision to Diff 71956.
bport added a comment.


  Remone unused include

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=71668&id=71956

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/changeicons.cpp
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/iconsmodel.cpp
  kcms/icons/iconsmodel.h
  kcms/icons/iconssettings.cpp
  kcms/icons/iconssettings.h
  kcms/icons/iconssettingsbase.kcfg
  kcms/icons/iconssettingsbase.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25915: Don't set a new palette if the application has a custom color scheme set

2019-12-21 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:69b756e274cb: Don't set a new palette if the 
application has a custom color scheme set (authored by davidre).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25915?vs=71343&id=71953

REVISION DETAIL
  https://phabricator.kde.org/D25915

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: davidre, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26078: Ship plasma-logo in repo

2019-12-21 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:957c5cf9e44e: Ship plasma-logo in repo (authored by 
davidre).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26078?vs=71763&id=71952

REVISION DETAIL
  https://phabricator.kde.org/D26078

AFFECTED FILES
  sidebar/package/contents/images/plasma-logo.svg
  sidebar/package/contents/ui/introPage.qml

To: davidre, #plasma, GB_2, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26121: Kicker/RecentDocument display file path as decoration

2019-12-21 Thread Méven Car 
meven updated this revision to Diff 71950.
meven added a comment.


  Use KFilePlacesModel to improve display of history

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26121?vs=71893&id=71950

BRANCH
  arcpatch-D26121

REVISION DETAIL
  https://phabricator.kde.org/D26121

AFFECTED FILES
  applets/kicker/CMakeLists.txt
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: meven, #vdg, #plasma, ngraham, ervin
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

2019-12-21 Thread Björn Feber 
GB_2 added a comment.


  Can you please try to further investigate this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21978

To: filipf, hein, #plasma, ngraham
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26045: Add immutability to KCM Icons

2019-12-21 Thread Benjamin Port 
bport added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:38
> Why this change?

my bad, need to keep the downloaded stuff there

> broulik wrote in main.qml:55
> Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff 
> Marco fixed a while back?

Problem with this solution it will disable also icon size components, and we 
don't want that, if you have a nicer solution

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26142: KCM Icons: Fix bug (https://bugs.kde.org/show_bug.cgi?id=415129), need to remove leading slash

2019-12-21 Thread Benjamin Port 
bport created this revision.
bport added reviewers: Plasma, ngraham, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

TEST PLAN
  Try installing using plasma-changeicons executable (used by discover) and 
from discover directly

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26142

AFFECTED FILES
  kcms/icons/changeicons.cpp

To: bport, #plasma, ngraham, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26139: Revert "Revert "Reduce the indicator arrow size for press-and-hold menus in QToolButtons""

2019-12-21 Thread Noah Davis 
ndavis added a comment.


  After D26139  was reopened, there was 
some discussion about the reason it was reverted and the problems it 
introduced. It is possible that an icon could partially cover this arrow, but 
it seemed uncommon enough that ignoring the problem was deemed acceptable. The 
type of control that this arrow is used for is also pretty uncommon because it 
does not feel very good to use with a mouse or touchpad.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26139

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26139: Revert "Revert "Reduce the indicator arrow size for press-and-hold menus in QToolButtons""

2019-12-21 Thread Noah Davis 
ndavis created this revision.
ndavis added reviewers: VDG, Breeze, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This reverts commit c9aa535863e09bf736b1fb64c182b93530780c5d 
.
  
  Also makes the small down arrow pixel perfect. I will make the other arrows 
pixel perfect in a separate patch.

REPOSITORY
  R31 Breeze

BRANCH
  dropdown-arrows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26139

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-21 Thread George Vogiatzis 
gvgeo updated this revision to Diff 71926.
gvgeo added a comment.


  Correct label of displayUnits in xml.
  Add values to displayUints options.
  Correct copyright message.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26124?vs=71921&id=71926

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26124

AFFECTED FILES
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: gvgeo, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart