D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Breeze, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  As stated in https://doc.qt.io/qt-5/qweakpointer-obsolete.html :
  QWeakPointer::data() "Returns the value of the pointer being tracked by this 
QWeakPointer, without ensuring that it cannot get deleted. To have that 
guarantee, use toStrongRef(), which returns a QSharedPointer object."

REPOSITORY
  R31 Breeze

BRANCH
  replace-deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26267

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsprovider.cpp
  kdecoration/breezesizegrip.cpp

To: ndavis, #breeze, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Brian Aberts]

baberts added a comment.


  In D26261#584039 , @gikari wrote:
  
  > In D26261#584037 , @ngraham 
wrote:
  >
  > > Everything that's left here could easily fit into a popup on that KCM, or 
we could use the multi-page KCM system to put all of this stuff on a sub-page 
on that KCM.
  >
  >
  > By the way, I've already made a popup in Applications Style KCM. Personally 
I have no objections whatsoever on that style and would gladly use it.
  >
  > F7847462: Screenshot_20191228_220227.png 

  >
  > Nevertheless, this patch is still needed. For the most part the logic and 
approaches in this code, that I wrote here, will be almost identical to the 
ones in the future Application KCM code. So I would like to hear comments on 
how it is good\bad or could be improved, before I make changes in different 
repository. If I had made changes in two repositories at the same time, it 
would have been a bit harder to maintain the changes, after revisions.
  
  
  I don't personally think that fits with the Plasma style, as i never see any 
pop-ups like that, but maybe that's just me. Either way, something is better 
than nothing, so that people don't get confused. After 5.18 it can be improved 
to elegantly integrate the remaining functionality into the style kcm.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg
Cc: baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Latte Dock, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Follow Plasma codes
  
https://github.com/KDE/plasma-framework/blob/ccceb83b107213ba5d2077fc346d4ab8a027d049/src/plasma/private/applet_p.cpp#L386

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26266

AFFECTED FILES
  containment/package/contents/ui/editmode/ConfigOverlay.qml
  shell/package/contents/configuration/LatteDockConfiguration.qml

To: trmdi, #latte_dock, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Noah Davis]

ndavis added a comment.


  Review summary area: F7847927: discover-review_summary_area.svg.png 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Nathaniel Graham]

ngraham updated this revision to Diff 72312.
ngraham added a comment.


  Rebase

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25889?vs=71290=72312

BRANCH
  polish-review-reviewing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25889

AFFECTED FILES
  discover/qml/ReviewDelegate.qml

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Noah Davis]

ndavis added a comment.


  In D25889#584040 , @apol wrote:
  
  > I'm not convinced about using emoji in place of icons. Are we sure about 
that?
  >
  > I like ndavis's suggestion, but as a delegate, having so many lines could 
look cluttered.
  >
  > Should we consider using cards?
  
  
  
  
  In D25889#584040 , @apol wrote:
  
  > I'm not convinced about using emoji in place of icons. Are we sure about 
that?
  >
  > I like ndavis's suggestion, but as a delegate, having so many lines could 
look cluttered.
  >
  > Should we consider using cards?
  
  
  Here's one with fewer lines:
  F7847844: discover-review_card.svg.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26264: Add record keystrokes feature to the hotkeys KCM module

[Miklos Marton]

martonmiklos created this revision.
martonmiklos added reviewers: mlaurent, lunakl, jriddell.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
martonmiklos requested review of this revision.

REVISION SUMMARY
  To add a keystroke sending shortcut to KDE the user had to understand the 
ways KCM interprets the keystroke commands.
  This patch adds option to record the key presses by typing:
  https://imgur.com/delete/Kz5duowvpGVuhZl

TEST PLAN
  1. Create a new global shortcut with KCM
  2. Go to Action page
  3. Hit Record key strokes button
  4. Type something
  5. Click again on the button
  6. Save with Apply
  7. Open up Kate for e.g.
  8. Trigger the global sortcut
  
  https://imgur.com/delete/Kz5duowvpGVuhZl

REPOSITORY
  R101 KHotKeys

REVISION DETAIL
  https://phabricator.kde.org/D26264

AFFECTED FILES
  kcm_hotkeys/actions/keyboard_input_action_widget.cpp
  kcm_hotkeys/actions/keyboard_input_action_widget.h
  kcm_hotkeys/actions/keyboard_input_action_widget.ui

To: martonmiklos, mlaurent, lunakl, jriddell
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

[Andreas Hartmetz]

ahartmetz added a comment.


  In D26185#583991 , @anthonyfieroni 
wrote:
  
  > Can forcing bigger font DPI make things better?
  
  
  AFAICS no. If scaling is conceptually enabled, i.e. if an application 
//would// be scaled //if// you attached a high DPI screen and moved the 
application to it, you get no hinting. That's all.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D25889: Polish the "review this review" UI and presentation

[Aleix Pol Gonzalez]

apol added a comment.


  I'm not convinced about using emoji in place of icons. Are we sure about that?
  
  I like ndavis's suggestion, but as a delegate, having so many lines could 
look cluttered.
  
  Should we consider using cards?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  In D26261#584037 , @ngraham wrote:
  
  > Everything that's left here could easily fit into a popup on that KCM, or 
we could use the multi-page KCM system to put all of this stuff on a sub-page 
on that KCM.
  
  
  By the way, I've already made a popup in Applications Style KCM. Personally I 
have no objections whatsoever on that style and would gladly use it.
  
  F7847462: Screenshot_20191228_220227.png 

  
  Nevertheless, this patch is still needed. For the most part the logic and 
approaches in this code, that I wrote here, will be almost identical to the 
ones in the future Application KCM code. So I would like to hear comments on 
how it is good\bad or could be improved, before I make changes in different 
repository. If I had made changes in two repositories at the same time, it 
would have been a bit harder to maintain the changes, after revisions.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  Nice work, but I think we should shoot for moving the remaining (small) 
functionality into the Application Style KCM for Plasma 5.18. Everything that's 
left here could easily fit into a popup on that KCM, or we could use the 
multi-page KCM system to put all of this stuff on a sub-page on that KCM.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [WIP][Applet] Make 'raise maximum volume' global

[George Vogiatzis]

gvgeo added a comment.


  Actually I never touch volume control, so don't have strong opinion. Either 
way I'm good, no worries.
  But in general believe, that should simplify UI and usability, while trying 
to keep features.
  
  This patch removes 2 options.
  While the other could have the mockup as a default, while also giving more 
options to advanced users.
  
  But if it is about code maintenance, I will not disagree.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26256

To: gvgeo, ngraham, #vdg, #plasma, drosca
Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari created this revision.
gikari added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  After several changes, GTK Applications settings are now in
  sync with KDE equivalent ones, so that GTK KCM now controls only the
  theme of the GTK applications. But GTK KCM was written with the thought
  that it controls entire GTK apps appearance in mind. Its code structure
  is now redundant and needs to be either rewritten or purged in favour of
  new one, that will be present in Application Style KCM code base.
  
  The last approach is preferable, because of the goal of removing GTK KCM
  to simplify System Settings structure. However, there are some points to
  be noted:
  
  1. The consensus of where exactly to put the GTK applications settings in App 
Style KCM is not yet reached.
  2. A couple of changes to the kded settings sync daemon are needed, to 
provide functionality, that is left in GTK KCM (Themes Installation/Deletion, 
Preview etc) without depending on GTK libs
  3. There are some bugs in KCM, that are present in the moment, that could 
only be fixed with architecture changes (for example: not working previews, 
when the xsettingsd daemon is running; broken icons in the previews; gtk themes 
do not applying for flatpak apps)
  
  Given the points above I decided to rewrite GTK KCM, so that complex
  design task (1) would be solved after changes (2) are made. And also
  in the process some bugs (3) will be fixed.
  
  Now, GTK KCM is not responsible for managing GTK configs, the one who
  does is the kded module, that is asked through DBus, when it is needed
  to do so.
  The stuff, that is managed by kded module:
  
  1. Setting selected GTK2 and GTK3 themes for applications
  2. Getting current GTK2 and GTK3 themes for applications
  3. Previewing GTK2 and GTK3 applications for selected themes
  
  Technically 2 and 3 could be done in KCM directly, because they do not
  depend on GTK libs, but I thought, that it would be logically related to
  the stuff, that is done via kded module. If you think, that that
  approach is not right, feel free to criticise.
  
  The stuff, that is done in KCM directly:
  
  1. Getting the list of installed GTK themes
  2. Installing and removing the GTK theme
  
  Also there are some visual changes:
  
  1. Theme deletion is now done via button near GTK theme combo, instead of 
separate dialog
  2. Theme installation from file is now done via button at the bottom, as in 
the other similar KCMs
  3. Preview button now has a title with an ellipsis to indicate, that it 
launches GTK app in a pop up window
  
  BUG: 405405

TEST PLAN
  1. Relaunch kded5
  2. Open GTK KCM
  3. Check if gtk themes changing works
  4. Check if the previews are working
  5. Check if the local themes deletion works
  6. Check if theme installation from archive works
  7. Check if GHNS theme installation works

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/themepreviewer.cpp
  kded/themepreviewer.h
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk2.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/dialog_installer.cpp
  src/dialog_installer.h
  src/dialog_uninstaller.cpp
  src/dialog_uninstaller.h
  src/gtkconfigkcmodule.cpp
  src/gtkconfigkcmodule.h
  src/installer.cpp
  src/installer.h
  src/thread.cpp
  src/thread.h
  src/ui/dialog_installer.ui
  src/ui/dialog_uninstaller.ui
  src/ui/gui.ui
  tests/CMakeLists.txt
  tests/configsavetest.cpp
  tests/configsavetest.h

To: gikari, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

[Anthony Fieroni]

anthonyfieroni added a comment.


  Can forcing bigger font DPI make things better?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26256: [WIP][Applet] Make 'raise maximum volume' global

[Nathaniel Graham]

ngraham added reviewers: VDG, Plasma, drosca.
ngraham added a subscriber: drosca.
ngraham added a comment.


  Thanks for this patch. I won't try to make you go forward with something you 
don't agree with, so let's continue the discussion here and hopefully we can 
reach a consensus of some sort.
  
  IIRC VDG people decided that 1) it made sense to have only a single way to 
raise the maximum volume rather than two, 2) that this single method should be 
global rather than per-app/per-device because global is simpler, more 
comprehensible, and more likely to be what the user wants to do, and 3) that 
the option to do this should be more discoverable than being in the config 
window.
  
  Adding #VDG  for more comments, and see 
T10470  for more details. Also adding 
@drosca as he's the maintainer.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26256

To: gvgeo, ngraham, #vdg, #plasma, drosca
Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

[Andreas Hartmetz]

ahartmetz added a comment.


  It's probably okay to still say that scaling is enabled "in general" but for 
scaling <2, and why not, maybe even greater, hinting should not be inhibited. 
The screen is still made of pixels. Qt is not going to be able to throw out all 
the hinting and subpixel code like Apple did, because it still needs to be 
supported for non-Retina screens anyway, for a long time. I'll open a Qt bug 
and see how it goes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

[Nathaniel Graham]

ngraham added a comment.


  Heh, you asked for it! :)
  
  T12441: Consider using a vertical Icons-Only Task Manager populated with apps 
by default 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  some-apps-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25773

To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Fix font rendering when compiled against Qt >= 5.14

[Andreas Hartmetz]

ahartmetz added a comment.


  I think I see the problem. You pay for the //possibility// to have scaling 
with unhinted fonts. I am pretty sure that that isn't an acceptable way of 
handling it. Most Linux desktop fonts are intended to be used with some hinting 
(slight hinting usually?). QHighDpiScaling::isActive() returns true even when 
the scale factor is 1.0 as in my case. Looks like a Qt bug to me.
  
diff --git 
a/src/platformsupport/fontdatabases/fontconfig/qfontconfigdatabase.cpp 
b/src/platformsupport/fontdatabases/fontconfig/qfontconfigdatabase.cpp
index e28b40c240..05bd01f158 100644
--- a/src/platformsupport/fontdatabases/fontconfig/qfontconfigdatabase.cpp
+++ b/src/platformsupport/fontdatabases/fontconfig/qfontconfigdatabase.cpp
@@ -611,7 +611,7 @@ QFontEngine::HintStyle 
defaultHintStyleFromMatch(QFont::HintingPreference hintin
 }
 
 if (QHighDpiScaling::isActive())
-return QFontEngine::HintNone;
+return QFontEngine::HintNone; // OOO
 
 int hint_style = 0;
 if (FcPatternGetInteger (match, FC_HINT_STYLE, 0, _style) == 
FcResultMatch) {
@@ -908,7 +908,7 @@ QFont QFontconfigDatabase::defaultFont() const
 void QFontconfigDatabase::setupFontEngine(QFontEngineFT *engine, const 
QFontDef ) const
 {
 bool antialias = !(fontDef.styleStrategy & QFont::NoAntialias);
-bool forcedAntialiasSetting = !antialias || 
QHighDpiScaling::isActive();
+bool forcedAntialiasSetting = !antialias || 
QHighDpiScaling::isActive(); // OOO
 
 const QPlatformServices *services = 
QGuiApplicationPrivate::platformIntegration()->services();
 bool useXftConf = false;

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

[Méven Car]

meven added a comment.


  ping @hein

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26147

To: meven, ngraham, #plasma, #vdg, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [WIP][Applet] Make 'raise maximum volume' global

[George Vogiatzis]

gvgeo updated this revision to Diff 72295.
gvgeo added a comment.


  Fixed shortcut keys.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26256?vs=72293=72295

BRANCH
  global (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26256

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [WIP][Applet] Make 'raise maximum volume' global

[George Vogiatzis]

gvgeo added a comment.


  Have a problem that marked with a TODO comment in code, but the desired 
functionality is working.
  @ngraham I should mention that I still oppose to the functionality of this 
patch, and I believe the better way is D26234 
 that maybe missed cause of the status 
change.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26256

To: gvgeo, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [WIP][Applet] Make 'raise maximum volume' global

[George Vogiatzis]

gvgeo created this revision.
gvgeo added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Remove maximum volume control from configuration.
  Remove individual maximum volume.
  Add a checkbox in applet to enable raise maximum volume for all devices. (not 
applications)

TEST PLAN
  Before:
  2 options exist to raise maximum volume.
  One options controls the default output device(by setting the limit).
  And a second one controls individual devices/applications.
  After:
  A checkbox in the applet will raise the max volume for all devices to 150%.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  global (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26256

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

[Noah Davis]

ndavis updated this revision to Diff 72281.
ndavis added a comment.


  - Change newPenWidthFrameRadius to frameRadiusNewPenWidth
  
  This sounds slightly better to me and allows it to show up next to 
frameRadius when autocompleting.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26225?vs=72280=72281

BRANCH
  replace-hardcoded-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26225

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart