D26514: Delay popup for containments

[Tranter Madi]

trmdi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Make use of the new parameter added in D26484 

  
  BUG: 415917

TEST PLAN
  Drop files into desktop folder layout/folder widget, the menu is shown 
correctly in all cases.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

[Bernhard Rosenkraenzer]

On Tuesday, January 07, 2020 10:51 CET, David Edmundson 
 wrote:

> I propose that we completely drop the Qt4 builds from Breeze+Oxygen
> after Plasma 5.18.

+1 from OpenMandriva -- we've dropped Qt 4.x a couple of months ago.

ttyl
bero

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

[A. Wilcox]

On Jan 7, 2020, at 3:51 AM, David Edmundson  wrote:
> 
> We're starting to see a lot of preparation for Qt6 porting API which
> we know will be deprecated.
> 
> One place where this is problematic is Breeze + Oxygen QStyles where
> we currently provide Qt4 builds. I don't want this to hold us back and
> be a problem later. It's also a problem for some shadow cleanup
> happening now (D26475)
> 
> I propose that we completely drop the Qt4 builds from Breeze+Oxygen
> after Plasma 5.18.
> 
> We're seeing distros phase Qt4 out, even Debian - and if a distro does
> still want to package these, they will still have the option of
> building the Plasma 5.18 tarball for Qt4 even after Plasma moves to a
> new revision.
> 
> CC'ing packagers to give them a chance to shout.
> 
> David


FWIW, we haven't shipped Qt 4 in over two years. +1 from here.

--
A. Wilcox (Sent from my iPhone - not signed)
Project Lead, Adélie Linux
https://www.adelielinux.org/

D26482: [Folder view] Don't create a rubberband when dragging during a rename

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d4d39892d62e: [Folder view] Dont create a 
rubberband when dragging during a rename (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26482?vs=72940=73024

REVISION DETAIL
  https://phabricator.kde.org/D26482

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, hein, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[Nathaniel Graham]

ngraham updated this revision to Diff 73023.
ngraham added a comment.


  Add a `preferred://wallpaperlocations` token and replace it with the real 
values

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26483?vs=72941=73023

BRANCH
  add-a-default-wallpaper-slideshow-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26483

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26510: [wallpapers/image] Disambiguate identical folder names in paths list

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  When multiple paths that end in the same folder name are added (for example 
with D26483 ),
  currently the list shows multiple identical entries distinguished only by 
their different
  tooltips. This patch improves the situation by putting the path to the folder 
in a
  subtitle.

TEST PLAN
  Before: F7868784: Before.png 
  
  After: F7868785: After.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  disambiguate-identical-foldernames (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26510

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Good stuff!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This rewrites the "Background services" KCM in QML using `ScrollViewKCM`.
  The two separate list views are merged into a single one with the 
configurable services at the top, and the ones that are loaded on-demand and 
"only for your convenience" at the bottom.
  A search field is added searching through name and plugin ID. Since the 
sortable table headers are gone, a filter combo is provided instead to filter 
for all, running, or non running services.
  As an extra Schmankerl when starting a service that immediately disables 
itself again (which technically isn't an error that would be indicated as such) 
a hint is shown to the user so they're not left wondering why it doesn't start.
  Furthermore, the code is cleaned up a lot (quite eerie, adding a 2020 
Copyright to an existing 2002 one :), ported to json plugin data, and a proper 
`QAbstractListModel` added.

TEST PLAN
  F7868523: Screenshot_20200107_223707.png 

  F7868524: Screenshot_20200107_223814.png 

  Trying to start the device automounter which disables itself on load when 
automounting is disabled in the KCM
  F7868525: Screenshot_20200107_223859.png 

  Starting or stopping a service shows a little animation
  F7868531: Screenshot_20200107_224027.png 

  This is mostly for when you apply changes and kded reloads, it will start all 
autoloaded modules, even if user manually stopped them. Originally I wanted to 
show an inline message along the lines of "some services were started again 
when you saved your changes because..." but that turned out to be too 
brittle/unreliable.
  
  Issues remaining:
  
  - Somehow that Kirigami listdelegate feature of adding right padding to take 
into account the scrollbar doesn't work in ScrollViewKCM
  - Since it's using delegaterecycler, the animation will play as you scroll up 
and down since as far as the item is concerned, status does change.
  - Some qt 5.14 adjustments (qregisteranonymoustype)
  - I get a binding loop on `Kirigami.AbstractListItem.implicitHeight` for my 
delegate for some reason

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26506

AFFECTED FILES
  kcms/kded/CMakeLists.txt
  kcms/kded/filterproxymodel.cpp
  kcms/kded/filterproxymodel.h
  kcms/kded/kcmkded.cpp
  kcms/kded/kcmkded.desktop
  kcms/kded/kcmkded.h
  kcms/kded/modulesmodel.cpp
  kcms/kded/modulesmodel.h
  kcms/kded/package/contents/ui/main.qml
  kcms/kded/package/metadata.desktop

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari requested review of this revision.
gikari marked an inline comment as done.
gikari added a comment.
This revision is now accepted and ready to land.


  > Taking advantage of the GTK_THEME environment variable would be a more 
elegant solution
  
  On the other hand this does not work for GTK2 applications, so I'll leave it 
as it is.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham, cblack
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari updated this revision to Diff 73015.
gikari added a comment.


  - Fixed combobox selection after theme deletion (please test)
  - Minor code style changes

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26261?vs=73006=73015

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/themepreviewer.cpp
  kded/themepreviewer.h
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk2.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/dialog_installer.cpp
  src/dialog_installer.h
  src/dialog_uninstaller.cpp
  src/dialog_uninstaller.h
  src/gtkconfigkcmodule.cpp
  src/gtkconfigkcmodule.h
  src/installer.cpp
  src/installer.h
  src/thread.cpp
  src/thread.h
  src/ui/dialog_installer.ui
  src/ui/dialog_uninstaller.ui
  src/ui/gui.ui
  tests/CMakeLists.txt
  tests/configsavetest.cpp
  tests/configsavetest.h

To: gikari, apol, #vdg, ngraham, cblack
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

[Vlad Zahorodnii]

On 1/7/20 11:51 AM, David Edmundson wrote:
> I propose that we completely drop the Qt4 builds from Breeze+Oxygen
> after Plasma 5.18.

+1

D26504: [WIP] [Panel Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

TEST PLAN
  Compile check only.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26504

AFFECTED FILES
  shell/panelshadows.cpp

To: zzag, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 48 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/48/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 18:11:24 +
 Build duration:
3 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/4071)0%
(0/2777)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1438)0%
(0/1110)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/823)0%
(0/484)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/237)0%
(0/122)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1026)0%
(0/780)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 49 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/49/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 18:11:20 +
 Build duration:
3 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2586)14%
(212/1503)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/165)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1249)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/258)0%
(0/136)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/26/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 18:11:21 +
 Build duration:
2 min 29 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  In D26261#589834 , @cblack wrote:
  
  > Code-wise, all of the stuff touching GTK looks fine except for the 
overengineered GTK3 theme preview, but that's relatively minor since it should 
still work as intended.
  
  
  I will fix it. My reinventing-the-wheel stupid solution introduces side 
effect - xsettingsd is not running, when preview window is active.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham, cblack
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Carson Black]

cblack accepted this revision.
cblack added a comment.


  Code-wise, all of the stuff touching GTK looks fine except for the 
overengineered GTK3 theme preview, but that's relatively minor since it should 
still work as intended.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham, cblack
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  that's weird, it started working for me after your last update...

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  In D26261#589829 , @ngraham wrote:
  
  > Everything works
  
  
  Wait, I didn't fixed the empty combobox thing yet

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right, we can fix that separately then.
  
  Everything works, so I'm giving this my QA blessing. Please wait for code 
review approval from @cblack or a #plasma 
 person before landing it.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  In D26261#589827 , @ngraham wrote:
  
  > I don't know if this is a bug in the KCM or a bug in the GHNS dialog, but 
when I delete a theme from the KCM, it's still listed as installed in the 
dialog. However when I delete a theme from the dialog, it disappears from the 
KCM as expected.
  
  
  It happens in the old GTK KCM too.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  Nice, works fine for those now. I don't know if this is a bug in the KCM or a 
bug in the GHNS dialog, but when I delete a theme from the KCM, it's still 
listed as installed in the dialog. However when I delete a theme from the 
dialog, it disappears from the KCM as expected.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari updated this revision to Diff 73006.
gikari added a comment.


  Do not display error, when the theme archive selection is canceled

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26261?vs=72305=73006

BRANCH
  set-theme-through-kded

REVISION DETAIL
  https://phabricator.kde.org/D26261

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/themepreviewer.cpp
  kded/themepreviewer.h
  src/abstractappearance.cpp
  src/abstractappearance.h
  src/appearancegtk2.cpp
  src/appearancegtk2.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/dialog_installer.cpp
  src/dialog_installer.h
  src/dialog_uninstaller.cpp
  src/dialog_uninstaller.h
  src/gtkconfigkcmodule.cpp
  src/gtkconfigkcmodule.h
  src/installer.cpp
  src/installer.h
  src/thread.cpp
  src/thread.h
  src/ui/dialog_installer.ui
  src/ui/dialog_uninstaller.ui
  src/ui/gui.ui
  tests/CMakeLists.txt
  tests/configsavetest.cpp
  tests/configsavetest.h

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  If it needs to instantly apply something, sure, I guess it can instantly 
apply Breeze.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  > It doesn't need to instantly apply it, but it should select Breeze and mark 
the state as dirty so the Apply button becomes enabled.
  
  But the theme is now deleted and configuration is in the incorrect state - 
GTK apps are requesting a theme, that does not exist anymore.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  In D26261#589811 , @gikari wrote:
  
  > > - When you delete the current theme, the combobox becomes empty. It 
should probably go back to the default theme or Breeze or something.
  >
  > So, it needs to select Breeze in otherwise empty combobox and instantly 
apply it?
  
  
  It doesn't need to instantly apply it, but it should select Breeze and mark 
the state as dirty so the Apply button becomes enabled.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Mikhail Zolotukhin]

gikari added a comment.


  > - When you delete the current theme, the combobox becomes empty. It should 
probably go back to the default theme or Breeze or something.
  
  So, it needs to select Breeze in otherwise empty combobox and instantly apply 
it?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> themepreviewer.cpp:85
> +
> +void ThemePreviewer::showGtk3App(const QString& themeName)
> +{

Taking advantage of the `GTK_THEME` environment variable would be a more 
elegant solution than copying the current configuration to another place, 
applying test configuration, stopping xsettingsd, and then starting the demo 
application.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: cblack, baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  Never mind, I was an idiot and hadn't restarted kded5. Almost everything 
works perfectly after that. I only found two bugs:
  
  - When you delete the current theme, the combobox becomes empty. It should 
probably go back to the default theme or Breeze or something.
  - If you click on the Install from File... button and cancel the dialog, you 
get an ugly error message: F7867995: Screenshot_20200107_101224.png 


REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  When I apply this and go to the rewritten KCM, the comboboxes are both empty: 
F7867971: Screenshot_20200107_095737.png 
  
  Also clicking on the Preview buttons does nothing.
  
  Downloading a new theme using GHNS does not make it appear in the theme list 
combobox.
  
  On top of that, applying themes doesn't work: F7867976: 
demo-2020-01-07_09.58.47.webm 
  
  Given the number of regressions found with simple testing, I'm not 
comfortable doing this so close to the release of an LTS plasma version. Just 
in general, huge patches of this size are not really reviewable and don't make 
sense unless you're also planning on becoming the maintainer.
  
  Given the proximity of the Plasma 5.18 feature freeze, I would suggest 
finding a way to unify the KCMs that does not require such drastic code changes.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg, ngraham
Cc: baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

[Méven Car]

meven planned changes to this revision.
meven added inline comments.

INLINE COMMENTS

> actionlist.cpp:62
>  
> +if (!icon.isEmpty()) {
> +map[QStringLiteral("icon")] = icon;

Remove this if

> recentcontactsmodel.cpp:93
>  
> -actionList << Kicker::createActionItem(i18n("Show Contact 
> Information..."), QStringLiteral("showContactInfo"));
> +actionList << Kicker::createActionItem(i18n("Show Contact 
> Information..."), QString(), QStringLiteral("showContactInfo"));
>  

Missing icon

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

[Luca Beltrame]

In data martedì 7 gennaio 2020 10:51:19 CET, David Edmundson ha scritto:

> I propose that we completely drop the Qt4 builds from Breeze+Oxygen
> after Plasma 5.18.

From the openSUSE side: +1. We're trying to get rid of Qt4 applications / libs 
/ whatever entirely and this is another nail in the coffin.

-- 
Luca Beltrame
GPG key ID:  A29D259B

signature.asc
Description: This is a digitally signed message part.

D26261: Rewrite GTK KCM

[Nathaniel Graham]

ngraham added a comment.


  I think in the VDG channel we decided to put the GTK config stuff on another 
page accessed by clicking on a button.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26261

To: gikari, apol, #vdg
Cc: baberts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[David Edmundson]

davidedmundson added a comment.


  Sure

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[Nathaniel Graham]

ngraham added a comment.


  In D26483#589401 , @broulik wrote:
  
  > Perhaps we could leverage some code from Task Manager to have a fake 
`preferred://wallpaperlocation` URL or something like that?
  
  
  That might be able to work. @davidedmundson, could this be a path forward, or 
did you have something else in mind?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 57 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/57/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 15:33:54 +
 Build duration:
56 min and counting

Plasma 5.17.5

[Jonathan Riddell]

Plasma 5.17.5 sources are out now for packaging and distributing
https://kde.org/announcements/plasma-5.17.5.php

D26447: Dynamically show and hide based on whether or not any vaults are configured

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:f8c6924510ea: Dynamically show and hide based on whether 
or not any vaults are configured (authored by ngraham).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26447?vs=72841=73000

REVISION DETAIL
  https://phabricator.kde.org/D26447

AFFECTED FILES
  plasma/package/contents/ui/main.qml
  plasma/vaultsmodel.cpp
  plasma/vaultsmodel.h

To: ngraham, broulik, ivan, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26447: Dynamically show and hide based on whether or not any vaults are configured

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R845 Plasma Vault

BRANCH
  dynamically-show-and-hide (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26447

To: ngraham, broulik, ivan, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26149: Change krunner calculator to display significant digits

[Nathaniel Graham]

ngraham added a comment.


  Thanks very much for the patch! May it be the first of many. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26149

To: lukjp, broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26149: Change krunner calculator to display significant digits

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e374492d24f4: Change krunner calculator to display 
significant digits (authored by lukjp, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26149?vs=71965=72999

REVISION DETAIL
  https://phabricator.kde.org/D26149

AFFECTED FILES
  runners/calculator/qalculate_engine.cpp

To: lukjp, broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: New Emojier translations

[Aleix Pol]

On Mon, Dec 30, 2019 at 8:26 PM Luigi Toscano  wrote:
>
> Yuri Chornoivan ha scritto:
> > Hi,
> >
> > There is a report in Russian mailing list that the translations for the new
> > emoji KCM [1] do not work. It is reported that the catalog name
> > (plasma_applet_org.kde.kimpanel.po [2]) does not work for KCM (aka Emojier).
> >
> > It was suggested to use i18nd() (tested to work) and found that the category
> > names are completely untranslatable.
> >
> > The way that I had handled the last two reports on plasma-desktop by the 
> > same
> > reporter arose some tension and I was asked to file bug reports or ask kde-
> > i18n-doc first. So please advice on what to do or fix the problem in a
> > conventional way.
> >
> > Thanks in advance for your help.
> >
> > Best regards,
> > Yuri
> >
> > [1] 
> > https://pointieststick.com/2019/12/08/this-week-in-kde-easy-emoji-input-and-more/
> >
> > [2] https://cgit.kde.org/plasma-desktop.git/tree/applets/kimpanel/backend/
> > ibus/emojier
>
> Redirecting to the plasma list. I remember some discussions about the forced
> name of the KCM catalogs; I think someone said that a solution was possible,
> but probably hasn't been implemented yet.
>
> --
> Luigi

The emojier thingie is an application, not a KCM. It should work just
like Discover or any other KDE component.

Category translation loading was indeed broken, I just fixed it with:
https://commits.kde.org/plasma-desktop/51f8849e4c17e451e40ece5b47e43337c572d1d5

You can see it's a slightly weird pattern we have there, but it seems
to work just fine.

I also saw the domain was broken while debugging, so that's sorted as well.

Thanks for the message and sorry for taking so long to reply!

Aleix


Aleix

D26037: feat(kded): add orientation sensor

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> romangg wrote in orientation_sensor.cpp:29
> Yea, we need to start it in the beginning to see if a sensor is available. 
> But we could cache the result and then shut it off again in case auto 
> rotation or screen is off. Needs some more logic though.

From what I can tell, we can call

if (!sensor->connectToBackend()) {
 m_available = false;
}

in the constructor

and then we have the option to call start/stop whenever.

> romangg wrote in orientation_sensor.h:38
> Looking at it again I don't think it is advisable to remove these two values 
> from the class interface. Instead having them in there for later and ignoring 
> them in the meantime in the implementation in the KScreenDaemon is fine. See 
> the comment there:
> 
> > We currently don't do anything with FaceUp/FaceDown, but in the future we 
> > could use them to shut off and switch on again a display when display is 
> > facing downwards/upwards.

I don't really understand.

The only reason to wrap QOrientationSensor in a wrapper class is to try and 
encapsulate the details of the sensor into something domain specific.

If we just forward everything 1:1, what does this wrapper provide over just 
having the other code use QOrietnationSensor directly.

(but whatever this isn't a topic I'm particularly passionate about, so whatever)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26037

To: romangg, #plasma
Cc: plasma-devel, davidedmundson, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26499: remove an unused header

[Miklós Máté]

miklosm created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
miklosm requested review of this revision.

REVISION SUMMARY
  It was imported from libksysguard, but I don't know why.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26499

AFFECTED FILES
  dataengines/systemmonitor/sensorclient.h

To: miklosm
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 86 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/86/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 15:17:41 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26310: feat: use Control and logical size APIs for replicas

[Roman Gilg]

romangg added a comment.


  I missed to update the test plan. So for reference: this is at it landed 
unrelated to Wayland and instead altering the behavior on X11. This should make 
the saving and loading of replications there more robust.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26310

To: romangg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 239 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/239/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 15:13:10 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/79)19%
(67/350)19%
(67/350)15%
(4728/32389)12%
(2566/21028)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/356)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/242)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2350)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
(0/3)0%
(0/386)0%
(0/224)kaccess0%
(0/3)0%

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 56 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/56/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 15:03:18 +
 Build duration:
30 min and counting
   CONSOLE OUTPUT
  [...truncated 207 lines...][2020-01-07T15:33:32.074Z] PWD   = '/usr/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 FreeBSDQt5.13'[2020-01-07T15:33:32.074Z] _ = '/usr/local/bin/java'[2020-01-07T15:33:32.074Z] TERM  = 'su'[2020-01-07T15:33:32.074Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.13'[2020-01-07T15:33:32.074Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-stable-kf5-qt5 FreeBSDQt5.13-56'[2020-01-07T15:33:32.074Z] BUILD_DISPLAY_NAME= '#56'[2020-01-07T15:33:32.074Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/56/display/redirect'[2020-01-07T15:33:32.074Z] USER  = 'jenkins'[2020-01-07T15:33:32.074Z] HOME  = '/home/jenkins'[2020-01-07T15:33:32.074Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/56/'[2020-01-07T15:33:32.074Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-01-07T15:33:32.074Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-07T15:33:32.074Z] SHELL = '/usr/local/bin/bash'[2020-01-07T15:33:32.074Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 FreeBSDQt5.13'[2020-01-07T15:33:32.074Z] MM_CHARSET= 'UTF-8'[2020-01-07T15:33:32.074Z] STAGE_NAME= 'Configuring Build'[2020-01-07T15:33:32.074Z] NODE_NAME = 'FreeBSD Builder 2'[2020-01-07T15:33:32.074Z] BLOCKSIZE = 'K'[2020-01-07T15:33:32.074Z] EXECUTOR_NUMBER   = '0'[2020-01-07T15:33:32.074Z] SHLVL = '0'[2020-01-07T15:33:32.074Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:33:32.074Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-01-07T15:33:32.074Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-01-07T15:33:32.074Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-01-07T15:33:32.074Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-01-07T15:33:32.074Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-01-07T15:33:32.074Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-01-07T15:33:32.074Z] QT_SELECT = 'qt5'[2020-01-07T15:33:32.074Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:33:32.074Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-01-07T15:33:32.074Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-01-07T15:33:32.074Z] [2020-01-07T15:33:32.074Z] [2020-01-07T15:33:32.074Z] == Commencing Configuration:[2020-01-07T15:33:32.074Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 FreeBSDQt5.13"[2020-01-07T15:33:32.685Z] -- The C compiler identification is Clang 8.0.1[2020-01-07T15:33:32.685Z] -- The CXX compiler identification is Clang 8.0.1[2020-01-07T15:33:32.685Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:33:32.685Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:33:32.685Z] -- Detecting C compiler ABI info[2020-01-07T15:33:32.977Z] -- Detecting C compiler ABI info - done[2020-01-07T15:33:32.977Z] -- Detecting C compile features[2020-01-07T15:33:32.977Z] -- Detecting C compile features - done[2020-01-07T15:33:32.977Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:33:33.249Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-07T15:33:33.249Z] -- Detecting CXX compiler ABI info[2020-01-07T15:33:33.531Z] -- Detecting CXX compiler ABI info - done[2020-01-07T15:33:33.531Z] -- Detecting CXX compile features[2020-01-07T15:33:33.531Z] -- Detecting CXX compile features - done[2020-01-07T15:33:33.531Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for systemsettings.[2020-01-07T15:33:33.531Z] -- Could not set up the 

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:a18bc820ca90: Add applet for controlling Night Color 
(authored by zzag).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25947?vs=72987=72988

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in main.qml:98
> Could you please explain why it needs to be in an else?

I assumed it was trying to remove the action created here:
plasmoid.setAction(..."configure");

I see now that "configure" on the setAction is the icon name and this is 
removing a different action

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D25947

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag updated this revision to Diff 72987.
zzag added a comment.


  Add braces.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25947?vs=71537=72987

BRANCH
  arcpatch-D25947

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag added a comment.


  > Does it make sense to dump the C++ classes in libcolorcorrect?
  
  I think it will be better to keep them here for now. Once somebody needs one 
of them, we can move them to libcolorcorrect (bad name).

INLINE COMMENTS

> davidedmundson wrote in main.qml:98
> Should
> 
>   plasmoid.removeAction("configure");
> 
> be in an else?

Could you please explain why it needs to be in an else?

REPOSITORY
  R114 Plasma Addons

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 93 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/93/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 15:14:40 +
 Build duration:
9 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/6)0%
(0/18)0%
(0/18)0%
(0/1535)0%
(0/607)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/272)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/100)0%
(0/27)core0%
(0/9)0%
(0/9)0%
(0/501)0%
(0/232)icons0%
(0/3)0%
(0/3)0%
(0/244)0%
(0/50)sidebar0%
(0/1)0%
(0/1)0%
(0/314)0%
(0/139)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/104)0%
(0/33)

D26481: feat(kcm): control scale

[David Edmundson]

davidedmundson added a comment.


  I don't understand where you're going with this.
  
  Can you explain what backend doesn't have a scale that is still worth saving 
on the output?
  
  On wayland we do have scale transmitted, for X we don't currently support 
per-output scaling.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26481

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 85 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/85/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 15:00:28 +
 Build duration:
17 min and counting
   CONSOLE OUTPUT
  [...truncated 217 lines...][2020-01-07T15:17:26.652Z] USER  = 'jenkins'[2020-01-07T15:17:26.652Z] HOME  = '/home/jenkins'[2020-01-07T15:17:26.652Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/85/'[2020-01-07T15:17:26.652Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-01-07T15:17:26.652Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-07T15:17:26.652Z] SHELL = '/usr/local/bin/bash'[2020-01-07T15:17:26.652Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13'[2020-01-07T15:17:26.652Z] MM_CHARSET= 'UTF-8'[2020-01-07T15:17:26.652Z] STAGE_NAME= 'Configuring Build'[2020-01-07T15:17:26.652Z] NODE_NAME = 'FreeBSD Builder 2'[2020-01-07T15:17:26.652Z] BLOCKSIZE = 'K'[2020-01-07T15:17:26.652Z] EXECUTOR_NUMBER   = '0'[2020-01-07T15:17:26.652Z] SHLVL = '0'[2020-01-07T15:17:26.652Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:17:26.652Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-01-07T15:17:26.652Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-01-07T15:17:26.652Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-01-07T15:17:26.652Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-01-07T15:17:26.652Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-01-07T15:17:26.652Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-01-07T15:17:26.652Z] QT_SELECT = 'qt5'[2020-01-07T15:17:26.652Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:17:26.652Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-01-07T15:17:26.652Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-01-07T15:17:26.652Z] [2020-01-07T15:17:26.652Z] [2020-01-07T15:17:26.652Z] == Commencing Configuration:[2020-01-07T15:17:26.652Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13"[2020-01-07T15:17:26.908Z] -- The C compiler identification is Clang 8.0.1[2020-01-07T15:17:26.908Z] -- The CXX compiler identification is Clang 8.0.1[2020-01-07T15:17:26.908Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:17:27.167Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:17:27.167Z] -- Detecting C compiler ABI info[2020-01-07T15:17:27.167Z] -- Detecting C compiler ABI info - done[2020-01-07T15:17:27.167Z] -- Detecting C compile features[2020-01-07T15:17:27.167Z] -- Detecting C compile features - done[2020-01-07T15:17:27.168Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:17:27.168Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-07T15:17:27.168Z] -- Detecting CXX compiler ABI info[2020-01-07T15:17:27.168Z] -- Detecting CXX compiler ABI info - done[2020-01-07T15:17:27.168Z] -- Detecting CXX compile features[2020-01-07T15:17:27.168Z] -- Detecting CXX compile features - done[2020-01-07T15:17:27.168Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-desktop.[2020-01-07T15:17:27.168Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-01-07T15:17:27.429Z] -- Looking for __GLIBC__[2020-01-07T15:17:27.429Z] -- Looking for __GLIBC__ - not found[2020-01-07T15:17:27.429Z] -- Performing Test _OFFT_IS_64BIT[2020-01-07T15:17:27.429Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-07T15:17:27.429Z] -- Performing Test HAVE_DATE_TIME[2020-01-07T15:17:27.429Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-07T15:17:27.429Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.66.0") [2020-01-07T15:17:27.429Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 92 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/92/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 15:03:18 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 267 lines...][2020-01-07T15:13:50.171Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-07T15:13:50.171Z] USER  = 'jenkins'[2020-01-07T15:13:50.171Z] MORE  = '-sl'[2020-01-07T15:13:50.171Z] CSHEDIT   = 'emacs'[2020-01-07T15:13:50.171Z] SHLVL = '2'[2020-01-07T15:13:50.171Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-stable-kf5-qt5 SUSEQt5.12-92'[2020-01-07T15:13:50.171Z] WINDOWMANAGER = 'xterm'[2020-01-07T15:13:50.171Z] PAGER = 'less'[2020-01-07T15:13:50.171Z] EXECUTOR_NUMBER   = '0'[2020-01-07T15:13:50.171Z] CVS_RSH   = 'ssh'[2020-01-07T15:13:50.171Z] LIBGL_DEBUG   = 'quiet'[2020-01-07T15:13:50.171Z] STAGE_NAME= 'Configuring Build'[2020-01-07T15:13:50.171Z] NODE_LABELS   = 'Docker Swarm-3889f57667b8 SUSEQt5.12'[2020-01-07T15:13:50.171Z] XCURSOR_THEME = 'DMZ-Black'[2020-01-07T15:13:50.171Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-07T15:13:50.171Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-07T15:13:50.171Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-07T15:13:50.171Z] PROFILEREAD   = 'true'[2020-01-07T15:13:50.171Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-07T15:13:50.171Z] HOSTTYPE  = 'x86_64'[2020-01-07T15:13:50.171Z] BUILD_ID  = '92'[2020-01-07T15:13:50.171Z] LESSKEY   = '/etc/lesskey.bin'[2020-01-07T15:13:50.171Z] OLDPWD= '/home/jenkins'[2020-01-07T15:13:50.171Z] LC_CTYPE  = 'C.UTF-8'[2020-01-07T15:13:50.171Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:13:50.171Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-07T15:13:50.171Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-07T15:13:50.171Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-07T15:13:50.171Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-07T15:13:50.171Z] QT_SELECT = 'qt5'[2020-01-07T15:13:50.171Z] LANG  = 'en_US.UTF-8'[2020-01-07T15:13:50.171Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:13:50.171Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-07T15:13:50.171Z] [2020-01-07T15:13:50.171Z] [2020-01-07T15:13:50.171Z] == Commencing Configuration:[2020-01-07T15:13:50.171Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12"[2020-01-07T15:13:50.732Z] -- The C compiler identification is GNU 9.2.1[2020-01-07T15:13:50.732Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-07T15:13:50.732Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:13:50.990Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:13:50.990Z] -- Detecting C compiler ABI info[2020-01-07T15:13:54.376Z] -- Detecting C compiler ABI info - done[2020-01-07T15:13:54.376Z] -- Detecting C compile features[2020-01-07T15:13:54.376Z] -- Detecting C compile features - done[2020-01-07T15:13:54.376Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:13:54.636Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-07T15:13:54.636Z] -- Detecting CXX compiler ABI info[2020-01-07T15:13:54.901Z] -- Detecting CXX compiler ABI info - done[2020-01-07T15:13:54.901Z] -- Detecting CXX compile features[2020-01-07T15:13:54.901Z] -- Detecting CXX compile features - done[2020-01-07T15:13:54.901Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2020-01-07T15:13:54.901Z] -- Looking for __GLIBC__[2020-01-07T15:13:55.466Z] -- Looking for __GLIBC__ - found[2020-01-07T15:13:55.466Z] -- Performing Test _OFFT_IS_64BIT[2020-01-07T15:13:57.356Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-07T15:13:57.356Z] -- Performing Test HAVE_DATE_TIME[2020-01-07T15:13:59.242Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-07T15:13:59.242Z] -- Found KF5Crash: 

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 47 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/47/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 15:03:02 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 260 lines...][2020-01-07T15:13:00.625Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-01-07T15:13:00.625Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'[2020-01-07T15:13:00.625Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-07T15:13:00.625Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-01-07T15:13:00.625Z] NODE_NAME = 'Docker Swarm-458880c396eb'[2020-01-07T15:13:00.625Z] HOST  = '458880c396eb'[2020-01-07T15:13:00.625Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-07T15:13:00.625Z] USER  = 'jenkins'[2020-01-07T15:13:00.625Z] MORE  = '-sl'[2020-01-07T15:13:00.625Z] CSHEDIT   = 'emacs'[2020-01-07T15:13:00.625Z] SHLVL = '2'[2020-01-07T15:13:00.625Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-47'[2020-01-07T15:13:00.625Z] WINDOWMANAGER = 'xterm'[2020-01-07T15:13:00.625Z] PAGER = 'less'[2020-01-07T15:13:00.625Z] EXECUTOR_NUMBER   = '0'[2020-01-07T15:13:00.625Z] CVS_RSH   = 'ssh'[2020-01-07T15:13:00.625Z] LIBGL_DEBUG   = 'quiet'[2020-01-07T15:13:00.625Z] STAGE_NAME= 'Configuring Build'[2020-01-07T15:13:00.625Z] NODE_LABELS   = 'Docker Swarm-458880c396eb SUSEQt5.12'[2020-01-07T15:13:00.625Z] XCURSOR_THEME = 'DMZ-Black'[2020-01-07T15:13:00.625Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-07T15:13:00.625Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-07T15:13:00.625Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-07T15:13:00.625Z] PROFILEREAD   = 'true'[2020-01-07T15:13:00.625Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-07T15:13:00.625Z] HOSTTYPE  = 'x86_64'[2020-01-07T15:13:00.625Z] BUILD_ID  = '47'[2020-01-07T15:13:00.625Z] LESSKEY   = '/etc/lesskey.bin'[2020-01-07T15:13:00.625Z] OLDPWD= '/home/jenkins'[2020-01-07T15:13:00.625Z] LC_CTYPE  = 'C.UTF-8'[2020-01-07T15:13:00.625Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:13:00.625Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-07T15:13:00.625Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-07T15:13:00.625Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-07T15:13:00.625Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-07T15:13:00.625Z] QT_SELECT = 'qt5'[2020-01-07T15:13:00.625Z] LANG  = 'en_US.UTF-8'[2020-01-07T15:13:00.625Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:13:00.625Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-07T15:13:00.625Z] [2020-01-07T15:13:00.625Z] [2020-01-07T15:13:00.625Z] == Commencing Configuration:[2020-01-07T15:13:00.625Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"[2020-01-07T15:13:01.188Z] -- The C compiler identification is GNU 9.2.1[2020-01-07T15:13:03.730Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-07T15:13:03.730Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:13:07.027Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:13:07.027Z] -- Detecting C compiler ABI info[2020-01-07T15:13:09.554Z] -- Detecting C compiler ABI info - done[2020-01-07T15:13:09.554Z] -- Detecting C compile features[2020-01-07T15:13:09.554Z] -- Detecting C compile features - done[2020-01-07T15:13:09.554Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:13:09.554Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-07T15:13:09.554Z] -- Detecting CXX compiler ABI info[2020-01-07T15:13:09.554Z] -- Detecting CXX compiler ABI info - done[2020-01-07T15:13:09.554Z] -- Detecting CXX compile features[2020-01-07T15:13:09.554Z] -- Detecting CXX compile features - done[2020-01-07T15:13:09.554Z] Installing in 

D26354: Introduce ActionRow widget

[Nathaniel Graham]

ngraham added a comment.


  In D26354#589352 , @mart wrote:
  
  > also a component like that back then was chosen to not be added by purpose 
in part because gesture-wise conflicts with the navigate back of pagerow
  
  
  Personally I don't find Kirigami's 
swipe-left-and-right-to-navigate-through-the-stack gestures to be very useful. 
You generally only ever use a swipe to go backwards, because to navigate 
forward you just tap the item. And having these swipes bound to pagerow 
navigation prevents the use of more useful gestures like these. I find these 
kinds of gesture-actions super useful in iOS and Android apps (particularly 
email apps where I use it to delete emails quickly).
  
  > every component added in kirigami needs to work as is on the desktop as 
well, modifying itself as much as needed.
  > 
  >   (in this case it would get fixed buttons for the actions at the edges i 
guess)
  
  This would suggest to me that we need to add these gestures to an even higher 
level component, or to add this to a BasicLictItem with `leftSwipeAction:` and 
`rightSwipeAction` properties or something, kind of like how SwipeListItem 
shows buttons on desktop. That way it the component would have buttons on 
desktop, and use the specified swipe actions on mobile automatically.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26354

To: cblack, #vdg, #kirigami, mart
Cc: mart, ouwerkerk, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, hein

D26481: feat(kcm): control scale

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:a5c4e9906322: feat(kcm): control scale (authored by 
romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26481?vs=72939=72982

REVISION DETAIL
  https://phabricator.kde.org/D26481

AFFECTED FILES
  common/control.cpp
  common/control.h
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/output_model.cpp

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26281: feat: add auto rotate and tablet mode information

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:50969ab6cbb7: feat: add auto rotate and tablet mode 
information (authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26281?vs=72351=72981

REVISION DETAIL
  https://phabricator.kde.org/D26281

AFFECTED FILES
  backends/kwayland/CMakeLists.txt
  backends/kwayland/org.kde.KWin.TabletModeManager.xml
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  src/config.cpp
  src/config.h

To: romangg, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 238 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/238/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 15:00:28 +
 Build duration:
7 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 277 lines...][2020-01-07T15:07:59.032Z] WINDOWMANAGER = 'xterm'[2020-01-07T15:07:59.032Z] PAGER = 'less'[2020-01-07T15:07:59.032Z] EXECUTOR_NUMBER   = '0'[2020-01-07T15:07:59.032Z] CVS_RSH   = 'ssh'[2020-01-07T15:07:59.032Z] LIBGL_DEBUG   = 'quiet'[2020-01-07T15:07:59.032Z] STAGE_NAME= 'Configuring Build'[2020-01-07T15:07:59.032Z] NODE_LABELS   = 'Docker Swarm-e0dfe5d246ad SUSEQt5.12'[2020-01-07T15:07:59.032Z] XCURSOR_THEME = 'DMZ-Black'[2020-01-07T15:07:59.032Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-07T15:07:59.032Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-07T15:07:59.032Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-07T15:07:59.032Z] PROFILEREAD   = 'true'[2020-01-07T15:07:59.032Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-07T15:07:59.032Z] HOSTTYPE  = 'x86_64'[2020-01-07T15:07:59.032Z] BUILD_ID  = '238'[2020-01-07T15:07:59.032Z] LESSKEY   = '/etc/lesskey.bin'[2020-01-07T15:07:59.032Z] OLDPWD= '/home/jenkins'[2020-01-07T15:07:59.032Z] LC_CTYPE  = 'C.UTF-8'[2020-01-07T15:07:59.032Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:07:59.032Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-07T15:07:59.032Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-07T15:07:59.032Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-07T15:07:59.032Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-07T15:07:59.032Z] QT_SELECT = 'qt5'[2020-01-07T15:07:59.032Z] LANG  = 'en_US.UTF-8'[2020-01-07T15:07:59.032Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:07:59.032Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-07T15:07:59.032Z] [2020-01-07T15:07:59.032Z] [2020-01-07T15:07:59.032Z] == Commencing Configuration:[2020-01-07T15:07:59.032Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12"[2020-01-07T15:07:59.310Z] -- The C compiler identification is GNU 9.2.1[2020-01-07T15:07:59.584Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-07T15:07:59.584Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:07:59.584Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:07:59.584Z] -- Detecting C compiler ABI info[2020-01-07T15:07:59.839Z] -- Detecting C compiler ABI info - done[2020-01-07T15:07:59.839Z] -- Detecting C compile features[2020-01-07T15:07:59.839Z] -- Detecting C compile features - done[2020-01-07T15:07:59.839Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:07:59.839Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-07T15:07:59.839Z] -- Detecting CXX compiler ABI info[2020-01-07T15:08:00.098Z] -- Detecting CXX compiler ABI info - done[2020-01-07T15:08:00.098Z] -- Detecting CXX compile features[2020-01-07T15:08:00.098Z] -- Detecting CXX compile features - done[2020-01-07T15:08:00.098Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-07T15:08:00.098Z] -- Looking for __GLIBC__[2020-01-07T15:08:00.098Z] -- Looking for __GLIBC__ - found[2020-01-07T15:08:00.098Z] -- Performing Test _OFFT_IS_64BIT[2020-01-07T15:08:00.354Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-07T15:08:00.354Z] -- Performing Test HAVE_DATE_TIME[2020-01-07T15:08:00.609Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-07T15:08:00.609Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.66.0") [2020-01-07T15:08:00.609Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-01-07T15:08:00.609Z] Installing in /home/jenkins/install-prefix. Run 

D26310: feat: use Control and logical size APIs for replicas

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:b3a8d590: feat: use Control and logical size APIs for 
replicas (authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26310?vs=72430=72980#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26310?vs=72430=72980

REVISION DETAIL
  https://phabricator.kde.org/D26310

AFFECTED FILES
  common/control.cpp
  kcm/config_handler.cpp
  kcm/config_handler.h
  kcm/output_model.cpp
  kcm/output_model.h
  kded/config.cpp
  kded/output.cpp

To: romangg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 48 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/48/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 14:57:55 +
 Build duration:
2 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 258 lines...][2020-01-07T15:00:30.191Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-01-07T15:00:30.191Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/48/display/redirect'[2020-01-07T15:00:30.191Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-01-07T15:00:30.191Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-01-07T15:00:30.191Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-07T15:00:30.191Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-01-07T15:00:30.191Z] NODE_NAME = 'Docker Swarm-676183ebf632'[2020-01-07T15:00:30.191Z] HOST  = '676183ebf632'[2020-01-07T15:00:30.191Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-07T15:00:30.191Z] USER  = 'jenkins'[2020-01-07T15:00:30.191Z] MORE  = '-sl'[2020-01-07T15:00:30.191Z] CSHEDIT   = 'emacs'[2020-01-07T15:00:30.191Z] SHLVL = '2'[2020-01-07T15:00:30.191Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-48'[2020-01-07T15:00:30.191Z] WINDOWMANAGER = 'xterm'[2020-01-07T15:00:30.191Z] PAGER = 'less'[2020-01-07T15:00:30.191Z] EXECUTOR_NUMBER   = '0'[2020-01-07T15:00:30.191Z] CVS_RSH   = 'ssh'[2020-01-07T15:00:30.191Z] LIBGL_DEBUG   = 'quiet'[2020-01-07T15:00:30.191Z] STAGE_NAME= 'Configuring Build'[2020-01-07T15:00:30.191Z] NODE_LABELS   = 'Docker Swarm-676183ebf632 SUSEQt5.12'[2020-01-07T15:00:30.191Z] XCURSOR_THEME = 'DMZ-Black'[2020-01-07T15:00:30.191Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-07T15:00:30.191Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-07T15:00:30.191Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-07T15:00:30.191Z] PROFILEREAD   = 'true'[2020-01-07T15:00:30.191Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-07T15:00:30.191Z] HOSTTYPE  = 'x86_64'[2020-01-07T15:00:30.191Z] BUILD_ID  = '48'[2020-01-07T15:00:30.191Z] LESSKEY   = '/etc/lesskey.bin'[2020-01-07T15:00:30.191Z] OLDPWD= '/home/jenkins'[2020-01-07T15:00:30.191Z] LC_CTYPE  = 'C.UTF-8'[2020-01-07T15:00:30.191Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:00:30.191Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-07T15:00:30.191Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-07T15:00:30.191Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-07T15:00:30.191Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-07T15:00:30.191Z] QT_SELECT = 'qt5'[2020-01-07T15:00:30.191Z] LANG  = 'en_US.UTF-8'[2020-01-07T15:00:30.191Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:00:30.191Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-07T15:00:30.191Z] [2020-01-07T15:00:30.191Z] [2020-01-07T15:00:30.191Z] == Commencing Configuration:[2020-01-07T15:00:30.191Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-01-07T15:00:30.191Z] -- The C compiler identification is GNU 9.2.1[2020-01-07T15:00:30.446Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-07T15:00:30.446Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:00:30.446Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:00:30.446Z] -- Detecting C compiler ABI info[2020-01-07T15:00:30.446Z] -- Detecting C compiler ABI info - done[2020-01-07T15:00:30.446Z] -- Detecting C compile features[2020-01-07T15:00:30.446Z] -- Detecting C compile features - done[2020-01-07T15:00:30.446Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:00:30.446Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-07T15:00:30.446Z] -- Detecting CXX compiler ABI 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 25 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/25/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 07 Jan 2020 14:57:55 +
 Build duration:
2 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 199 lines...][2020-01-07T15:00:42.188Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2020-01-07T15:00:42.188Z] EDITOR= 'vi'[2020-01-07T15:00:42.188Z] ENV   = '/home/jenkins/.shrc'[2020-01-07T15:00:42.188Z] HUDSON_HOME   = '/home/production/data'[2020-01-07T15:00:42.188Z] CCACHE_DIR= '/home/jenkins/.ccache/'[2020-01-07T15:00:42.188Z] BUILD_ID  = '25'[2020-01-07T15:00:42.188Z] OLDPWD= '/usr/home/jenkins'[2020-01-07T15:00:42.188Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-01-07T15:00:42.188Z] _ = '/usr/local/bin/java'[2020-01-07T15:00:42.188Z] TERM  = 'su'[2020-01-07T15:00:42.188Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.13'[2020-01-07T15:00:42.188Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-25'[2020-01-07T15:00:42.188Z] BUILD_DISPLAY_NAME= '#25'[2020-01-07T15:00:42.188Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/25/display/redirect'[2020-01-07T15:00:42.188Z] USER  = 'jenkins'[2020-01-07T15:00:42.188Z] HOME  = '/home/jenkins'[2020-01-07T15:00:42.188Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/25/'[2020-01-07T15:00:42.188Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-01-07T15:00:42.188Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-07T15:00:42.188Z] SHELL = '/usr/local/bin/bash'[2020-01-07T15:00:42.188Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-01-07T15:00:42.188Z] MM_CHARSET= 'UTF-8'[2020-01-07T15:00:42.188Z] STAGE_NAME= 'Configuring Build'[2020-01-07T15:00:42.188Z] NODE_NAME = 'FreeBSD Builder 2'[2020-01-07T15:00:42.188Z] BLOCKSIZE = 'K'[2020-01-07T15:00:42.188Z] EXECUTOR_NUMBER   = '0'[2020-01-07T15:00:42.188Z] SHLVL = '0'[2020-01-07T15:00:42.188Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:00:42.188Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-01-07T15:00:42.188Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-01-07T15:00:42.188Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-01-07T15:00:42.188Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-01-07T15:00:42.188Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-01-07T15:00:42.188Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-01-07T15:00:42.188Z] QT_SELECT = 'qt5'[2020-01-07T15:00:42.188Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:00:42.188Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-01-07T15:00:42.188Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-01-07T15:00:42.188Z] [2020-01-07T15:00:42.188Z] [2020-01-07T15:00:42.188Z] == Commencing Configuration:[2020-01-07T15:00:42.188Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2020-01-07T15:00:42.188Z] -- The C compiler identification is Clang 8.0.1[2020-01-07T15:00:42.448Z] -- The CXX compiler identification is Clang 8.0.1[2020-01-07T15:00:42.448Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:00:42.448Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:00:42.448Z] -- Detecting C compiler ABI info[2020-01-07T15:00:42.448Z] -- Detecting C compiler ABI info - done[2020-01-07T15:00:42.448Z] -- Detecting C compile features[2020-01-07T15:00:42.448Z] -- Detecting C compile features - done[2020-01-07T15:00:42.448Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:00:42.707Z] -- Check for working CXX compiler: /usr/bin/c++ -- 

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 30 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/30/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 07 Jan 2020 14:58:26 +
 Build duration:
2 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 271 lines...][2020-01-07T15:00:23.713Z] BUILD_ID  = '30'[2020-01-07T15:00:23.713Z] LESSKEY   = '/etc/lesskey.bin'[2020-01-07T15:00:23.713Z] OLDPWD= '/home/jenkins'[2020-01-07T15:00:23.713Z] LC_CTYPE  = 'C.UTF-8'[2020-01-07T15:00:23.713Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-07T15:00:23.713Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-07T15:00:23.713Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-07T15:00:23.713Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-07T15:00:23.713Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-07T15:00:23.713Z] QT_SELECT = 'qt5'[2020-01-07T15:00:23.713Z] LANG  = 'en_US.UTF-8'[2020-01-07T15:00:23.713Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-07T15:00:23.713Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-07T15:00:23.713Z] [2020-01-07T15:00:23.713Z] [2020-01-07T15:00:23.713Z] == Commencing Configuration:[2020-01-07T15:00:23.713Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12"[2020-01-07T15:00:23.969Z] -- The C compiler identification is GNU 9.2.1[2020-01-07T15:00:24.225Z] -- The CXX compiler identification is GNU 9.2.1[2020-01-07T15:00:24.225Z] -- Check for working C compiler: /usr/bin/cc[2020-01-07T15:00:24.483Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-01-07T15:00:24.483Z] -- Detecting C compiler ABI info[2020-01-07T15:00:25.053Z] -- Detecting C compiler ABI info - done[2020-01-07T15:00:25.053Z] -- Detecting C compile features[2020-01-07T15:00:25.053Z] -- Detecting C compile features - done[2020-01-07T15:00:25.053Z] -- Check for working CXX compiler: /usr/bin/c++[2020-01-07T15:00:25.620Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-01-07T15:00:25.620Z] -- Detecting CXX compiler ABI info[2020-01-07T15:00:26.185Z] -- Detecting CXX compiler ABI info - done[2020-01-07T15:00:26.185Z] -- Detecting CXX compile features[2020-01-07T15:00:26.185Z] -- Detecting CXX compile features - done[2020-01-07T15:00:26.185Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for kgamma.[2020-01-07T15:00:26.185Z] -- Looking for __GLIBC__[2020-01-07T15:00:26.449Z] -- Looking for __GLIBC__ - found[2020-01-07T15:00:26.449Z] -- Performing Test _OFFT_IS_64BIT[2020-01-07T15:00:31.951Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-01-07T15:00:31.951Z] -- Performing Test HAVE_DATE_TIME[2020-01-07T15:00:32.223Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-07T15:00:32.223Z] -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.66.0") [2020-01-07T15:00:32.223Z] -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.66.0") [2020-01-07T15:00:32.223Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.66.0") [2020-01-07T15:00:32.223Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2020-01-07T15:00:32.223Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.66.0") [2020-01-07T15:00:32.223Z] -- Found KF5: success (found suitable version "5.66.0", minimum required is "5.62.0") found components:  Config ConfigWidgets DocTools I18n [2020-01-07T15:00:32.223Z] -- Found X11: /usr/include   [2020-01-07T15:00:32.223Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so[2020-01-07T15:00:32.489Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found[2020-01-07T15:00:32.489Z] -- Looking for gethostbyname[2020-01-07T15:00:32.489Z] -- Looking for gethostbyname - found[2020-01-07T15:00:32.489Z] -- Looking for connect[2020-01-07T15:00:32.757Z] -- Looking for connect - found[2020-01-07T15:00:32.757Z] -- Looking for remove[2020-01-07T15:00:32.757Z] -- Looking for remove - found[2020-01-07T15:00:32.757Z] -- Looking for shmat[2020-01-07T15:00:33.021Z] -- Looking for shmat - found[2020-01-07T15:00:33.021Z] -- Looking for IceConnectionNumber in 

D26220: feat: control replication

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:19e6756fc1ae: feat: control replication (authored by 
romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26220?vs=72429=72979

REVISION DETAIL
  https://phabricator.kde.org/D26220

AFFECTED FILES
  common/control.cpp
  common/control.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26309: feat: replace replication source with logical size API

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:6a5a180bbedf: feat: replace replication source with 
logical size API (authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26309?vs=72890=72977

REVISION DETAIL
  https://phabricator.kde.org/D26309

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandrconfig.h
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h
  src/output.cpp
  src/output.h

To: romangg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26447: Dynamically show and hide based on whether or not any vaults are configured

[Ivan Čukić]

ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.


  That is why I put the "or in addition to" part.
  
  Anyhow, I don't mind this to go in as is.

REPOSITORY
  R845 Plasma Vault

BRANCH
  dynamically-show-and-hide (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26447

To: ngraham, broulik, ivan, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26494: Runner/Windows make the window finding more reliable

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Call gatherInfo immediately after prepareForMatchSession
  QTimer::singleShot could dispatched gatherInfo after the next 
WindowsRunner::match was called in a not-ready state.
  
  BUG: 414804
  FIXED-IN: 5.18

REPOSITORY
  R120 Plasma Workspace

BRANCH
  improve-windowrunner

REVISION DETAIL
  https://phabricator.kde.org/D26494

AFFECTED FILES
  runners/windows/windowsrunner.cpp

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[David Edmundson]

davidedmundson added a comment.


  I don't think so, as we use a runtime evaluation of kcfg files within plasma. 
Code tags won't work there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[David Redondo]

davidre added a comment.


  Couldn't we just use wrap the folders from the single image case in a code 
tag?
  `QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, 
QStringLiteral("wallpapers/"), QStandardPaths::LocateDirectory)`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Does it make sense to dump the C++ classes in libcolorcorrect?
  
  It has an import for use client side usage for the KCM, his is just another 
client, especially inhibitor.

INLINE COMMENTS

> main.qml:96
> +Component.onCompleted: {
> +if (KCMShell.authorize("kcm_nightcolor.desktop").length > 0)
> +plasmoid.setAction("KCMNightColor", i18n("Configure Night 
> Color..."), "configure");

I don't think we have an official QML coding guideline, but convention 
throughout plasma has been to put {} for single line if statements.

> main.qml:98
> +plasmoid.setAction("KCMNightColor", i18n("Configure Night 
> Color..."), "configure");
> +plasmoid.removeAction("configure");
> +}

Should

  plasmoid.removeAction("configure");

be in an else?

REPOSITORY
  R114 Plasma Addons

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

[Aleix Pol]

+1

On Tue, Jan 7, 2020 at 11:29 AM Harald Sitter  wrote:
>
> +1
>
> On Tue, Jan 7, 2020 at 10:51 AM David Edmundson
>  wrote:
> >
> > We're starting to see a lot of preparation for Qt6 porting API which
> > we know will be deprecated.
> >
> > One place where this is problematic is Breeze + Oxygen QStyles where
> > we currently provide Qt4 builds. I don't want this to hold us back and
> > be a problem later. It's also a problem for some shadow cleanup
> > happening now (D26475)
> >
> > I propose that we completely drop the Qt4 builds from Breeze+Oxygen
> > after Plasma 5.18.
> >
> > We're seeing distros phase Qt4 out, even Debian - and if a distro does
> > still want to package these, they will still have the option of
> > building the Plasma 5.18 tarball for Qt4 even after Plasma moves to a
> > new revision.
> >
> > CC'ing packagers to give them a chance to shout.
> >
> > David

D25179: Don't move the drawer collapse button if there's no icon or image

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  collapseButton isn't a thing anymore, at least as is.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25179

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26421: Only show full name in review dialog

[Jan Grulich]

jgrulich added a comment.


  I don't really remember, but I can see in the userHash() it's not used so 
this is probably safe. In the userHash() we directly use KUser().

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26398: [KCM/Activities] Use KConfigXT in ui

[Méven Car]

meven updated this revision to Diff 72964.
meven added a comment.


  Handle BlacklistedApplicationsModel properly, prevent a warning 'duplicate 
connection name'

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26398?vs=72850=72964

BRANCH
  arcpatch-D26398

REVISION DETAIL
  https://phabricator.kde.org/D26398

AFFECTED FILES
  kcms/activities/ActivitiesTab.cpp
  kcms/activities/ActivitiesTab.h
  kcms/activities/BlacklistedApplicationsModel.cpp
  kcms/activities/BlacklistedApplicationsModel.h
  kcms/activities/MainConfigurationWidget.cpp
  kcms/activities/MainConfigurationWidget.h
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/SwitchingTab.cpp
  kcms/activities/SwitchingTab.h
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: meven, #plasma, ervin, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26489: Use qmlRegisterAnonymousType

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  needs a qt version `ifdef`

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D26489

To: tcanabrava, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26183: Fix build with Qt 5.14

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added a comment.


  since this is commited already I'm closing, and opened a follow up commit:
  https://phabricator.kde.org/D26489

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D26183

To: tcanabrava, davidedmundson, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26489: Use qmlRegisterAnonymousType

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R112 Milou

BRANCH
  useQmlRegisterAnonymousType

REVISION DETAIL
  https://phabricator.kde.org/D26489

AFFECTED FILES
  lib/draghelper.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

[Fabian Vogt]

fvogt added a comment.


  IMO it should still be considered if it's the only one.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26330

To: broulik, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

[Harald Sitter]

+1

On Tue, Jan 7, 2020 at 10:51 AM David Edmundson
 wrote:
>
> We're starting to see a lot of preparation for Qt6 porting API which
> we know will be deprecated.
>
> One place where this is problematic is Breeze + Oxygen QStyles where
> we currently provide Qt4 builds. I don't want this to hold us back and
> be a problem later. It's also a problem for some shadow cleanup
> happening now (D26475)
>
> I propose that we completely drop the Qt4 builds from Breeze+Oxygen
> after Plasma 5.18.
>
> We're seeing distros phase Qt4 out, even Debian - and if a distro does
> still want to package these, they will still have the option of
> building the Plasma 5.18 tarball for Qt4 even after Plasma moves to a
> new revision.
>
> CC'ing packagers to give them a chance to shout.
>
> David

D26485: [Pager] Fix switching pages on

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  f5d1675a0dc1a1a0098eb5b1c727b5fe197e9930 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26485

To: broulik, #plasma, hein, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d2d30a9667d2: [KRunner KCM] Mark KCM as dirty when plugin 
configuration changes (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26445?vs=72830=72957

REVISION DETAIL
  https://phabricator.kde.org/D26445

AFFECTED FILES
  kcms/runners/kcm.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26425: [Notifications KCM] Fixup current item syncing logic

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b639338291d4: [Notifications KCM] Fixup current item 
syncing logic (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26425?vs=72770=72958

REVISION DETAIL
  https://phabricator.kde.org/D26425

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26476: [kstyle] Remove shadows in Qt 4 style plugin

[Vlad Zahorodnii]

zzag added a comment.


  Do you suggest to move qt 4 style plugin to its own repo? I'm not sure that I 
follow you.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26476

To: zzag, #kwin, #plasma
Cc: davidedmundson, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26476: [kstyle] Remove shadows in Qt 4 style plugin

[David Edmundson]

davidedmundson added a comment.


  I don't think this is the right approach as it regresses the Qt4 style. 
  We can achieve the same thing by having packagers just continue to build an 
existing old tarball. They keep the shadows, and we can fix Breeze not just for 
this but other Qt5 porting.
  
  I've emailed plasma and kde-distro-packagers for feedback.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26476

To: zzag, #kwin, #plasma
Cc: davidedmundson, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

RFC: Dropping Breeze + Oxygen Qt4 builds after

[David Edmundson]

We're starting to see a lot of preparation for Qt6 porting API which
we know will be deprecated.

One place where this is problematic is Breeze + Oxygen QStyles where
we currently provide Qt4 builds. I don't want this to hold us back and
be a problem later. It's also a problem for some shadow cleanup
happening now (D26475)

I propose that we completely drop the Qt4 builds from Breeze+Oxygen
after Plasma 5.18.

We're seeing distros phase Qt4 out, even Debian - and if a distro does
still want to package these, they will still have the option of
building the Plasma 5.18 tarball for Qt4 even after Plasma moves to a
new revision.

CC'ing packagers to give them a chance to shout.

David

D26416: Kicker/Documents optimization: Lazily build KFileItem

[Kai Uwe Broulik]

broulik added a comment.


  Would be lovely in the future to cache those items and make it a proper model 
with backing data rather than requesting everything on demand every time `data` 
is called.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26416

To: meven, #frameworks, apol
Cc: broulik, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25984: Load translations

[Marco Martin]

mart added a comment.


  ping, what's the current status of this?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, hein

D26475: [kstyle] Port to KWindowSystem shadows API

[Marco Martin]

mart accepted this revision as: Plasma, mart.
mart added a comment.
This revision is now accepted and ready to land.


  on the breeze-style side, this looks good

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26475

To: zzag, #kwin, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26476: [kstyle] Remove shadows in Qt 4 style plugin

[Marco Martin]

mart added a comment.


  not an huge loss for me, qt4 clients are becoming very rare anyways

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26476

To: zzag, #kwin, #plasma
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26456: KCM runners : fix reset and default behavior

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9d200f06d6cd: KCM runners : fix reset and default 
behavior (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26456?vs=72861=72952

REVISION DETAIL
  https://phabricator.kde.org/D26456

AFFECTED FILES
  kcms/runners/kcm.cpp

To: bport, #plasma, ervin, crossi, meven, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26467: KCM runners: fix default button

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:be1eacc05b1f: KCM runners: fix default button (authored 
by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26467?vs=72905=72953

REVISION DETAIL
  https://phabricator.kde.org/D26467

AFFECTED FILES
  kcms/runners/kcm.cpp

To: bport, #plasma, ervin, meven, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[Kai Uwe Broulik]

broulik added a comment.


  Perhaps we could leverage some code from Task Manager to have a fake 
`preferred://wallpaperlocation` URL or something like that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25103: Simplify application load

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  I wanted to keep this as an example since while in here having 2 different 
main files doesn't change much , but for complex apps is really the way i would 
ask for it to be done in cases the mobile app must be significantly simpler 
than the desktop one

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D25103

To: dkardarakos, mart
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, hein

D26485: [Pager] Fix switching pages on

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The code was clearly intending to use the index, as indicated by a comparison 
with `currentPage` (which is an `int`) and `changePage` taking an `int`.
  
  BUG: 415423
  FIXED-IN: 5.17.5

TEST PLAN
  - Dragged a file onto pager, waited for desktop switch, plasma no longer 
crashed
  - Activity pager also works fine the same way

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26485

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26200: Add shortcut for closing pages

[Marco Martin]

mart added a comment.


  hmm, not sure about it.
  it would probably be ok for most of the cases, but i'm pretty sure it may 
break some existing app.
  an app may want at least two pages always loaded for instance (if uses one 
for sidebar, one for main content)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D26354: Introduce ActionRow widget

[Marco Martin]

mart added a comment.


  my gripe is that is a lot of javascript which could be simply implemented 
with a swipedelegate, having less heavy javascript which is a serious problem 
when used in delegates.
  
  also a component like that back then was chosen to not be added by purpose in 
part because gesture-wise conflicts with the navigate back of pagerow and in 
part because every component added in kirigami needs to work as is on the 
desktop as well, modifying itself as much as needed.
   (in this case it would get fixed buttons for the actions at the edges i 
guess)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26354

To: cblack, #vdg, #kirigami
Cc: mart, ouwerkerk, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, hein

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  It's not ok for the reasons you identified.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26304: [PageRow] Disable swipe forwards/backwards gesture by default

[Marco Martin]

mart added a comment.


  also, on plasma mobile, there is no global back button, and i don't want any 
back button anywhere in the app

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26304

To: cblack, #vdg, #kirigami, mart
Cc: mart, ndavis, ouwerkerk, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson, hein