D27045: [wallpapers] Use more high-quality JPEGs for Next

[Nikita Babin]

raveomelette added a comment.


  Yup, definitely looks nicer!

REPOSITORY
  R31 Breeze

BRANCH
  more-hq-next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27045

To: filipf, #plasma, #vdg, ngraham
Cc: The-Feren-OS-Dev, rikmills, raveomelette, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27045: [wallpapers] Use more high-quality JPEGs for Next

[Filip Fila]

filipf added a subscriber: rikmills.
filipf added a comment.


  In D27045#603590 , @ngraham wrote:
  
  > Noticeably less JPEG-compression-artifacty.
  >
  > If this lands, make sure it's on the `Plasma/5.18` branch.
  
  
  Will do! Any objections from #plasma 
 or distro folks (@rikmills)?
  
  Some more numbers: the size of the wallpaper pack is increased from 8.1 MiB 
to 17.4 MiB. Original Volna PNGs are 45. Ice Cold totaled at about 13.

REPOSITORY
  R31 Breeze

BRANCH
  more-hq-next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27045

To: filipf, #plasma, #vdg, ngraham
Cc: rikmills, raveomelette, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27045: [wallpapers] Use more high-quality JPEGs for Next

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Noticeably less JPEG-compression-artifacty.
  
  If this lands, make sure it's on the `Plasma/5.18` branch.

REPOSITORY
  R31 Breeze

BRANCH
  more-hq-next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27045

To: filipf, #plasma, #vdg, ngraham
Cc: raveomelette, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D27047

AFFECTED FILES
  Mainpage.dox

To: nicolasfella, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27034: Fix message box when passing a remote url that includes a file

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:317a899dc774: Fix message box when passing a remote url 
that includes a file (authored by apol).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27034?vs=74692&id=74725

REVISION DETAIL
  https://phabricator.kde.org/D27034

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: apol, #frameworks, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27045: [wallpapers] Use more high-quality JPEGs for Next

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Due to filesize concerns, we optimized the Volna wallpaper to be JPEG 
compressed at 90% quality.
  
  JPEGs seems like the right way to go, but at 90% there is a noticeable loss 
of sharpness and JPEG artifacts appear, both of which are more prominent the 
smaller the resolution.
  
  I used the same tool (squoosh) to generate more high quality JPEGs, paying 
attention to how each resolution responded to a certain quality setting.
  
  In the end I had to use values between 94 and 98 in order to ensure there is 
no noticeable difference with the original PNGs.
  
  This brings up the total file size to 17.4 MiB, which I think is still fine, 
especially given that this is our default wallpaper for an LTS release.

REPOSITORY
  R31 Breeze

BRANCH
  more-hq-next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27045

AFFECTED FILES
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/5120x2880.jpg

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27041: fix incorrect parsing of "at foo.so" and empty function name

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  for unknown reasons gdb seems to behave inconsistently here. usually
  'at' denotes a file, but there are backtraces where it doesn't
  e.g. https://bugs.kde.org/show_bug.cgi?id=416923
  
  I've add a trivial suffix check to ensure parsing of these lines works
  correctly even when 'at' is used in combination with a library name.
  
  this is a bit hackish, but in reality this entire parsing tech should
  probably be replaced by a python plugin for gdb so we can get interactive
  access to the frames and serialize them in a well defined format instead of
  having to parse "random" text
  
  on top of that our regex assumed we'd always have a function name, which is
  also not true as that bug report shows. to mitigate this the matching group
  has been made optional.
  
  this commit also adds a test for the gdb line parsing unit with some
  obvious line samples I could find just now

TEST PLAN
  all tests pass

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27041

AFFECTED FILES
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h
  src/tests/CMakeLists.txt
  src/tests/gdbbacktracelinetest.cpp

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26640: [applets/weather] Port weather station picker to QQC2+ListView

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:8861250b2e47: [applets/weather] Port weather station 
picker to QQC2+ListView (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26640?vs=74184&id=74709

REVISION DETAIL
  https://phabricator.kde.org/D26640

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26845: [context menu] Remove last traces of "Lock Widgets" action from UI

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:66940389d66b: [context menu] Remove last traces of 
"Lock Widgets" action from UI (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26845?vs=74140&id=74707

REVISION DETAIL
  https://phabricator.kde.org/D26845

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: ngraham, mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:37a8d5945ec7: [Applets/Folder] Re-arrange positioning of 
"Arrange in" and "Align" submenus (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26882?vs=74270&id=74706

REVISION DETAIL
  https://phabricator.kde.org/D26882

AFFECTED FILES
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp

To: ngraham, hein, #vdg, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26912: Use Qt5 signal syntax, format files, optimizations

[Alexander Lohnau]

alex added a comment.


  Yes, I have used an automatic formatter.
  
  And in general about formatting: When I commit a patch which contains code 
changes, should I format the files (even the code that I don't directly edit) 
or would it be easier for the reviewers if I commit this in a separate patch ?
  Or should I not reformat the files, to not stress the reviewers/maintainers ?
  
  And what would be a good place to ask about the code of a project or discuss 
some ideas (on both Phabricator and Gitlab).
  
  Thank you very much :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26884: [Folder View] Fix text label color in pop-up

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:78eccc8bda2c: [Folder View] Fix text label color in 
pop-up (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26884?vs=74274&id=74703

REVISION DETAIL
  https://phabricator.kde.org/D26884

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: ngraham, #vdg, #plasma, hein, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham updated this revision to Diff 74702.
ngraham added a comment.


  "Battery may be damaged" -> "Not charging" (it's more accurate)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=73554&id=74702

BRANCH
  arcpatch-D24070

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27019

To: meven, #plasma, broulik, ngraham, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27037: [Notifications] Fixup setSourceModel

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Qt says to do a proper model reset in this method.
  I also noticed something funky going on with the `LimitedRowCountProxyModel` 
not showing any data which went away with this.

TEST PLAN
  5.18

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27037

AFFECTED FILES
  libnotificationmanager/limitedrowcountproxymodel.cpp
  libnotificationmanager/notificationgroupcollapsingproxymodel.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27027: Clip the flickable parent item

[Aleix Pol Gonzalez]

apol added a comment.


  The fact that isn't preexistent doesn't change that if the flicked item were 
to be placed properly, clipping wouldn't be necessary

REPOSITORY
  R169 Kirigami

BRANCH
  scrollview_clip

REVISION DETAIL
  https://phabricator.kde.org/D27027

To: ahiemstra, #kirigami, ngraham
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D27030: remove all platform conditionals not pertaining to linux or *bsd

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:43cd7a26f31a: remove all platform conditionals not 
pertaining to linux or *bsd (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27030?vs=74678&id=74695

REVISION DETAIL
  https://phabricator.kde.org/D27030

AFFECTED FILES
  CMakeLists.txt
  Modules/CMakeLists.txt
  Modules/base/CMakeLists.txt
  Modules/base/info_aix.cpp
  Modules/base/info_hpux.cpp
  Modules/base/info_osx.cpp
  Modules/base/info_sgi.cpp
  Modules/base/info_solaris.cpp
  Modules/base/os_current.cpp
  Modules/base/os_current.h
  Modules/memory/base.h
  Modules/memory/memory.cpp
  Modules/memory/memory_hpux.cpp
  Modules/memory/memory_osx.cpp
  Modules/memory/memory_sgi.cpp
  Modules/memory/memory_solaris.cpp
  Modules/memory/memory_tru64.cpp
  Modules/memory/physicalMemoryChart.cpp
  Modules/nics/nic.cpp
  Modules/pci/CMakeLists.txt
  kcontrol/menus/CMakeLists.txt

To: sitter, broulik, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27026: add trivial systemsettings finder and mark it as RUNTIME dep

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:35b19106c5cb: add trivial systemsettings finder and mark 
it as RUNTIME dep (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27026?vs=74673&id=74696

REVISION DETAIL
  https://phabricator.kde.org/D27026

AFFECTED FILES
  CMakeLists.txt
  cmake/FindSystemSettings.cmake

To: sitter, mart, broulik, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Here the initial patch to get a plasma subcategory on api.kde.org started,
  as thought about by David E. in D26894 .
  Though this will need some further thinking what the concept of that
  subcategory is. And how to help people with the naming clashes when it comes
  to Plasma-the-workspace vs. Plasma-the-lib.
  
  All that naming and descriptions have to be sorted out by you Plasma people,
  I just can get you started here with this :)
  
  So please someone commandeer this patch immediately, I have to pass on here
  given no own resources to work on this.
  
  And while there might be some people working on a successor for api.kde.org
  generation, those naming and grouping concepts are orthogonal, you will need
  to have an idea about this in any case, I think.

TEST PLAN
  cd ~
  mkdir plasmadox
  cd plasmadox
  ~/path/to/kapidox/src/kapidox_generate ~/path/to/kdecoration/
  firefox index.html &
  
  To update after editing the metainfo.yaml:
  rm * -r
  ~/path/to/kapidox/src/kapidox_generate ~/path/to/kdecoration/
  *reload in firefox*

REPOSITORY
  R129 Window Decoration Library

BRANCH
  addplasmaapigroup

REVISION DETAIL
  https://phabricator.kde.org/D27036

AFFECTED FILES
  docs/plasma.svg
  metainfo.yaml

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27034: Fix message box when passing a remote url that includes a file

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  The if was negated, I assume it was a typo

TEST PLAN
  I don't get the following screenshot anymore

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27034

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27027: Clip the flickable parent item

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah the cut-off is a pre-existing issue.
  
  This fixes the visual issue I've been seeing with the System Tray 
configuration view and the Notifications KCM's applications list. +1.

REPOSITORY
  R169 Kirigami

BRANCH
  scrollview_clip

REVISION DETAIL
  https://phabricator.kde.org/D27027

To: ahiemstra, #kirigami, ngraham
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D27027: Clip the flickable parent item

[Arjen Hiemstra]

ahiemstra added a comment.


  That's because the KCM for some reason does not want to size smaller even 
when the kcmshell window does get smaller. This is not related to the scrollbar 
however, I get the same result without the scrollbar:
  
  F8025393: Screenshot_20200130_152414.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27027

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D26875: Make it possible to stream only input

[Aleix Pol Gonzalez]

apol closed this revision.
apol added a comment.


  
https://commits.kde.org/xdg-desktop-portal-kde/46ebf487e8075635179cf18bc5f6ec5ea79388aa

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26875

To: apol, #plasma, #kde_connect, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27027: Clip the flickable parent item

[Aleix Pol Gonzalez]

apol added a comment.


  after looks cropped now, are you sure this is the right fix? (not that it 
isn't necessary...)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27027

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in DeviceModel.cpp:119
> Do we want to add items that are *not* a `StorageAccess`?
> Shouldn't this be more like
> 
>   if (access && !access->isIgnored())`

I needed to add the not mounted storage access as storage access ignores not 
mounted system

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27019

To: meven, #plasma, broulik, ngraham, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 421 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/421/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 12:21:04 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26912: Use Qt5 signal syntax, format files, optimizations

[Méven Car]

meven added a comment.


  In D26912#603041 , @alex wrote:
  
  > Hello,
  >
  > I already wondered how this will be handled.
  >
  > Should I abandon this revision now and maybe create a new one with the 
relevant changes once your request has been merged ?
  
  
  I think that's the easiest way. Hopefully you use a script for this 
formatting and won't loose too much time.
  
  > And is there any way I could have known that this kcm is going to be 
refactored ?
  
  Unfortunately there is no easy way but follow a little the activity on 
phabricator which is how I found your review.
  
  I wish we had some notification/information when we touch a file or folder 
that has currently running reviews.
  I don't know any forge platform that does this kind of thing.
  
  > And a general question: When are accepted patches merged ?
  
  It is variable.
  The smallest the more inconsequential and more consensual, the more tested 
and the more easy to test, the more people and experienced people have accepted 
it, the fastest it should land.
  On the opposite, the more code you touch or on the more sensible things 
should make you should be patient and give reasonable time for other reviewers 
to comment/accept/or require change, especially experienced reviewers or 
maintainers.
  You will then probably need to remind reviewers to have a look. We have 
sortof a reviewer shortage.
  Doc does not specify this :/ 
https://community.kde.org/Infrastructure/Phabricator#Step_3:_Land_your_diff
  
  > For instance your patch https://phabricator.kde.org/D26478 is very simple 
and has been accepted for a few weeks now, but has not been merged.
  
  This one I forgot about, I thought I landed it.
  
  A tip, use https://phabricator.kde.org/differential/query/active/ to have a 
quick overview on your reviews.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26478: KCM/baloo Display full mount point in list of excluded mount points

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3d5719e76a57: KCM/baloo Display full mount point in list 
of excluded mount points (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26478?vs=73033&id=74679

REVISION DETAIL
  https://phabricator.kde.org/D26478

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp

To: meven, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27030: remove all platform conditionals not pertaining to linux or *bsd

[Harald Sitter]

sitter created this revision.
sitter added reviewers: broulik, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  we do not support plasma on anything else, nor do we CI on other platforms,
  so all these conditionals were unnecessary complexity and code nobody needs

TEST PLAN
  still builds on linux

REPOSITORY
  R102 KInfoCenter

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27030

AFFECTED FILES
  CMakeLists.txt
  Modules/CMakeLists.txt
  Modules/base/CMakeLists.txt
  Modules/base/info_aix.cpp
  Modules/base/info_hpux.cpp
  Modules/base/info_osx.cpp
  Modules/base/info_sgi.cpp
  Modules/base/info_solaris.cpp
  Modules/base/os_current.cpp
  Modules/base/os_current.h
  Modules/memory/base.h
  Modules/memory/memory.cpp
  Modules/memory/memory_hpux.cpp
  Modules/memory/memory_osx.cpp
  Modules/memory/memory_sgi.cpp
  Modules/memory/memory_solaris.cpp
  Modules/memory/memory_tru64.cpp
  Modules/memory/physicalMemoryChart.cpp
  Modules/nics/nic.cpp
  Modules/pci/CMakeLists.txt
  kcontrol/menus/CMakeLists.txt

To: sitter, broulik, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27029: Remove header top margin from private ScrollView

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  With the scrollbars taking up actual width, the top margin of the vertical
  scrollbar being set to the list header looks really awkward and buggy. This
  removes the top margin, making the scrollbar take the entire flickable's
  height. This change also applies to overlay scrollbars as I consider the
  margin behaviour to be incorrect even for those, as the top margin will
  change based on the header height, which causes the scrollbar to resize
  when the header shrinks.

REPOSITORY
  R169 Kirigami

BRANCH
  scrollbar_topmargin

REVISION DETAIL
  https://phabricator.kde.org/D27029

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27027: Clip the flickable parent item

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Without clipping the contents, they can draw stuff outside of the scrollview
  bounds, leading to issues with content being drawn underneath the scrollbar,
  among others.
  
  BUG: 416877

REPOSITORY
  R169 Kirigami

BRANCH
  scrollview_clip

REVISION DETAIL
  https://phabricator.kde.org/D27027

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27026: add trivial systemsettings finder and mark it as RUNTIME dep

[Harald Sitter]

sitter created this revision.
sitter added reviewers: mart, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  simply finds systemsettings5 in the expected path and report it as part
  of the feature summary so everyone makes sure systemsettings is actually
  installed

TEST PLAN
  reported missing/present as applicable

REPOSITORY
  R102 KInfoCenter

BRANCH
  sys-runtime

REVISION DETAIL
  https://phabricator.kde.org/D27026

AFFECTED FILES
  CMakeLists.txt
  cmake/FindSystemSettings.cmake

To: sitter, mart, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 420 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/420/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 10:57:39 +
 Build duration:
2 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 2707 lines...][2020-01-30T11:00:13.557Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keyboard/flags.h:29:1: warning: struct 'LayoutUnit' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags][2020-01-30T11:00:13.557Z] struct LayoutUnit;[2020-01-30T11:00:13.557Z] ^[2020-01-30T11:00:13.557Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keyboard/x11_helper.h:90:7: note: previous use is here[2020-01-30T11:00:13.557Z] class LayoutUnit {[2020-01-30T11:00:13.557Z]   ^[2020-01-30T11:00:13.557Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keyboard/flags.h:29:1: note: did you mean class here?[2020-01-30T11:00:13.557Z] struct LayoutUnit;[2020-01-30T11:00:13.557Z] ^~[2020-01-30T11:00:13.557Z] class[2020-01-30T11:00:13.557Z] [ 35%] Built target kcmdatetimehelper[2020-01-30T11:00:13.557Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/dateandtime/dtime.cpp:26:[2020-01-30T11:00:13.557Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/dateandtime/dtime.h:25:[2020-01-30T11:00:13.557Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/build/kcms/dateandtime/ui_dateandtime.h:157:25: warning: 'K4TimeZoneWidget' is deprecated [-Wdeprecated-declarations][2020-01-30T11:00:13.557Z] tzonelist = new K4TimeZoneWidget(tab_2);[2020-01-30T11:00:13.557Z] ^[2020-01-30T11:00:13.557Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/k4timezonewidget.h:73:5: note: 'K4TimeZoneWidget' has been explicitly marked deprecated here[2020-01-30T11:00:13.557Z] KDELIBS4SUPPORT_DEPRECATED explicit K4TimeZoneWidget(QWidget *parent = nullptr, KTimeZones *timeZones = nullptr);[2020-01-30T11:00:13.557Z] ^[2020-01-30T11:00:13.557Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-01-30T11:00:13.557Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-01-30T11:00:13.557Z]  ^[2020-01-30T11:00:13.557Z] [ 35%] Building CXX object kcms/autostart/CMakeFiles/kcm_autostart.dir/autostartitem.cpp.o[2020-01-30T11:00:13.557Z] Scanning dependencies of target kcm_launchfeedback[2020-01-30T11:00:13.837Z] [ 35%] Building CXX object kcms/launch/CMakeFiles/kcm_launchfeedback.dir/kcm_launchfeedback_autogen/mocs_compilation.cpp.o[2020-01-30T11:00:13.837Z] 4 warnings generated.[2020-01-30T11:00:13.837Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/flags.cpp.o[2020-01-30T11:00:15.825Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keyboard/flags.cpp:36:[2020-01-30T11:00:15.825Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keyboard/x11_helper.h:30:9: warning: keyword is hidden by macro definition [-Wkeyword-macro][2020-01-30T11:00:15.825Z] #define explicit explicit_is_keyword_in_cpp[2020-01-30T11:00:15.825Z] ^[2020-01-30T11:00:15.825Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keyboard/x11_helper.h:90:1: warning: 'LayoutUnit' defined as a class here but previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags][2020-01-30T11:00:15.825Z] class LayoutUnit {[2020-01-30T11:00:15.825Z] ^[2020-01-30T11:00:15.825Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.13/kcms/keyboard/flags.h:29:1: note: did you mean class here?[2020-01-30T11:00:15.825Z] struct LayoutUnit;[2020-01-30T11:00:15.825Z] ^~[2020-01-30T11:00:15.825Z] class[2020-01-30T11:00:15.825Z] [ 35%] Generating colorssettings.h, colorssettings.cpp[2020-01-30T11:00:15.825Z] [ 35%] Generating colorssettings.moc[2020-01-30T11:00:16.117Z] 1 warning generated.[2020-01-30T11:00:16.117Z] [ 35%] Building CXX object kcms/dateandtime/CMakeFiles/kcm_clock.dir/main.cpp.o[2020-01-30T11:00:16.375Z] 2 warnings generated.[2020-01-30T11:00:16.375Z] Scanning dependencies of target kcm_colors[2020-01-30T11:00:16.375Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/xkb_rules.cpp.o[2020-01-30T11:00:16.375Z] [ 35%] Building CXX object kcms/autostart/CMakeFiles/kcm_autostart.dir/addscriptdialog.cpp.o[2020-01-30T11:00:16.375Z] [ 35%] Building CXX object kcms/colors/CMakeFiles/kcm_colors.dir/kcm_colors_autogen/mocs_compilation.cpp.o[2020-01-30T11:

D27023: Port to UpdateLaunchEnvJob

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9e3fd9215245: Port to UpdateLaunchEnvJob (authored by 
broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27023?vs=74666&id=74670

REVISION DETAIL
  https://phabricator.kde.org/D27023

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/fonts/CMakeLists.txt
  kcms/krdb/krdb.cpp
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/autotests/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/mouse/CMakeLists.txt
  kcms/mouse/backends/x11/x11_backend.cpp
  kcms/style/CMakeLists.txt

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6253163af827: [libkworkspace] Introduce 
UpdateLaunchEnvJob (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26993?vs=74668&id=74669

REVISION DETAIL
  https://phabricator.kde.org/D26993

AFFECTED FILES
  libkworkspace/CMakeLists.txt
  libkworkspace/updatelaunchenvjob.cpp
  libkworkspace/updatelaunchenvjob.h

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

[Kai Uwe Broulik]

broulik updated this revision to Diff 74668.
broulik added a comment.


  - docs

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26993?vs=74587&id=74668

REVISION DETAIL
  https://phabricator.kde.org/D26993

AFFECTED FILES
  libkworkspace/CMakeLists.txt
  libkworkspace/updatelaunchenvjob.cpp
  libkworkspace/updatelaunchenvjob.h

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27023: Port to UpdateLaunchEnvJob

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in krdb.cpp:39-40
> I don't understand why this changes

I don't either but it wouldn't build without.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27023

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Méven Car]

meven created this revision.
meven added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  A user might find odd that when a known device in the UI is unmounted, it 
disappears.
  Despite the fact that restarting the kcm would show it.

TEST PLAN
  Open `kcmshell5 device_automounter_kcm`
  Plug in a usb stick, set a setting for it and Apply
  Unplug the stick
  
  Before:
  The disconnected usb stick does not appear
  After:
  The usb stick appears at the bottom of the disconnected section
  
  Forget the stick in the UI and Apply
  Plug in the usb stick
  Unplug it
  
  The usb stick is not visible (as before)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27024

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27023: Port to UpdateLaunchEnvJob

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Beautiful.
  
  I suspect this will fix a few bugs whilst we're at it.
  There were a lot running after startplasma has started, so wouldn't have been 
synced properly to the DBus env.

INLINE COMMENTS

> krdb.cpp:39-40
>  #include 
> -#include 
> +#include 
> +#include 
>  

I don't understand why this changes

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27023

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> updatelaunchenvjob.h:28
> +
> +class KWORKSPACE_EXPORT UpdateLaunchEnvJob : public KJob
> +{

Docs

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26993

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27023: Port to UpdateLaunchEnvJob

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Depends on D26993 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27023

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/fonts/CMakeLists.txt
  kcms/krdb/krdb.cpp
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/autotests/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/mouse/CMakeLists.txt
  kcms/mouse/backends/x11/x11_backend.cpp
  kcms/style/CMakeLists.txt

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21764: Port all plasma workspace to new libkworkspace API

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:26a217fa3d61: Port all plasma workspace to new 
libkworkspace API (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21764?vs=74288&id=74664

REVISION DETAIL
  https://phabricator.kde.org/D21764

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  dataengines/powermanagement/powermanagementjob.cpp
  dataengines/powermanagement/powermanagementjob.h
  runners/sessions/sessionrunner.cpp
  runners/sessions/sessionrunner.h

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 94 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/94/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 10:00:38 +
 Build duration:
4 min 4 sec and counting

D27020: Port plasma-desktop to autoconfig.kde.org

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fc668c5574dd: Port plasma-desktop to autoconfig.kde.org 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27020?vs=74651&id=74657#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27020?vs=74651&id=74657

REVISION DETAIL
  https://phabricator.kde.org/D27020

AFFECTED FILES
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  kcms/colors/colorschemes.knsrc
  kcms/cursortheme/xcursor/xcursor.knsrc
  kcms/desktoptheme/plasma-themes.knsrc
  kcms/emoticons/emoticons.knsrc
  kcms/icons/icons.knsrc

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 156 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/156/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 30 Jan 2020 10:00:38 +
 Build duration:
3 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/12)0%
(0/50)0%
(0/50)0%
(0/3226)0%
(0/1378)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsModules.about-distro.src0%
(0/2)0%
(0/2)0%
(0/150)0%
(0/64)Modules.base0%
(0/3)0%
(0/3)0%
(0/403)0%
(0/134)Modules.devinfo0%
(0/11)0%
(0/11)0%
(0/664)0%
(0/194)Modules.energy0%
(0/8)0%
(0/8)0%
(0/268)0%
(0/127)Modules.fileindexermonitor0%
(0/2)0%
(0/2)0%
(0/7)100%
(0/0)Modules.info0%
(0/2)0%
(0/2)0%
(0/53)0%
(0/6)Modules.memory0%
(0/6)0%
(0/6)0%
(0/274)0%
(0/64)Modules.nics0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/38)Modules.opengl0%
(0/1)0%
(0/1)0%
(0/409)0%
(0/223)Modules.pci0%
(0/1)0%
(0/1)0%
(0/28)100%
(0/0)Modules.samba0%
(0/9)0%
(0/9)0%
(0/542)0%
(0/348)Modules.usbview0%
(0/4)0%
(0/4)0%
(0/327)0%
(0/180)

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 09:53:18 +
 Build duration:
3 min 43 sec and counting

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 16 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/16/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 30 Jan 2020 09:53:18 +
 Build duration:
3 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/16)0%
(0/16)0%
(0/744)0%
(0/331)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalscontainments.homescreen0%
(0/5)0%
(0/5)0%
(0/233)0%
(0/164)containments.panel0%
(0/2)0%
(0/2)0%
(0/31)0%
(0/12)containments.taskpanel0%
(0/2)0%
(0/2)0%
(0/92)0%
(0/40)dialer.src0%
(0/7)0%
(0/7)0%
(0/388)0%
(0/115)

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Méven Car]

meven updated this revision to Diff 74656.
meven added a comment.


  Checking if this is a not-ignored or not mounted StorageAccess is what we need

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27019?vs=74654&id=74656

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27019

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27021: Port plasma-workspace to autoconfig.kde.org

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7eaf278a7de6: Port plasma-workspace to autoconfig.kde.org 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27021?vs=74653&id=74655#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27021?vs=74653&id=74655

REVISION DETAIL
  https://phabricator.kde.org/D27021

AFFECTED FILES
  components/shellprivate/widgetexplorer/plasmoids.knsrc
  wallpapers/image/wallpaper.knsrc

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Méven Car]

meven updated this revision to Diff 74654.
meven marked an inline comment as done.
meven added a comment.


  Only display device that are not ignored Solid::StorageVolume and 
Solid::StorageAccess

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27019?vs=74649&id=74654

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27019

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27021: Port plasma-workspace to autoconfig.kde.org

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  As D27020 , might want to backport this 
to any branches still being released.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27021

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27020: Port plasma-desktop to autoconfig.kde.org

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Goodness me, yes please. Land in 5.18 for sure (also perhaps backport to 
anywhere that's still being released)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27020

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 09:30:13 +
 Build duration:
6 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 622 lines...][2020-01-30T09:36:07.032Z] Scanning dependencies of target plasma_containment_phone_homescreen[2020-01-30T09:36:07.032Z] [ 47%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/plasma_containment_phone_homescreen_autogen/mocs_compilation.cpp.o[2020-01-30T09:36:07.032Z] [ 50%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/homescreen.cpp.o[2020-01-30T09:36:07.032Z] [ 52%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/applicationlistmodel.cpp.o[2020-01-30T09:36:07.032Z] Scanning dependencies of target plasma_applet_phonepanel[2020-01-30T09:36:07.032Z] Scanning dependencies of target plasma_containment_phone_taskpanel[2020-01-30T09:36:07.032Z] [ 55%] Building CXX object containments/taskpanel/CMakeFiles/plasma_containment_phone_taskpanel.dir/plasma_containment_phone_taskpanel_autogen/mocs_compilation.cpp.o[2020-01-30T09:36:07.032Z] [ 58%] Building CXX object containments/panel/CMakeFiles/plasma_applet_phonepanel.dir/plasma_applet_phonepanel_autogen/mocs_compilation.cpp.o[2020-01-30T09:36:08.506Z] [ 61%] Building CXX object containments/taskpanel/CMakeFiles/plasma_containment_phone_taskpanel.dir/taskpanel.cpp.o[2020-01-30T09:36:08.506Z] [ 64%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/colouraverage.cpp.o[2020-01-30T09:36:09.077Z] [ 67%] Building CXX object containments/panel/CMakeFiles/plasma_applet_phonepanel.dir/phonepanel.cpp.o[2020-01-30T09:36:10.031Z] [ 70%] Linking CXX shared module ../../bin/plasma_containment_phone_homescreen.so[2020-01-30T09:36:10.031Z] Scanning dependencies of target plasmaphonedialer[2020-01-30T09:36:10.031Z] [ 73%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/plasmaphonedialer_autogen/mocs_compilation.cpp.o[2020-01-30T09:36:10.031Z] [ 76%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/main.cpp.o[2020-01-30T09:36:10.031Z] [ 76%] Built target plasma_containment_phone_homescreen[2020-01-30T09:36:10.301Z] [ 79%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/call-handler.cpp.o[2020-01-30T09:36:10.301Z] [ 82%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/dialerutils.cpp.o[2020-01-30T09:36:10.562Z] [ 85%] Linking CXX shared module ../../bin/plasma_applet_phonepanel.so[2020-01-30T09:36:10.873Z] [ 85%] Built target plasma_applet_phonepanel[2020-01-30T09:36:10.873Z] [ 88%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/callhistorymodel.cpp.o[2020-01-30T09:36:11.151Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/dialer/src/call-handler.cpp:17:[2020-01-30T09:36:11.151Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/dialer/src/call-handler.h:20:[2020-01-30T09:36:11.151Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/AbstractClientHandler:8:[2020-01-30T09:36:11.151Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/abstract-client.h:31:[2020-01-30T09:36:11.151Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/SharedPtr:8:[2020-01-30T09:36:11.151Z] /usr/local/include/telepathy-qt5/TelepathyQt/shared-ptr.h:112:13: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register][2020-01-30T09:36:11.151Z] register int tmp = sc->strongref.fetchAndAddOrdered(0);[2020-01-30T09:36:11.151Z] ^[2020-01-30T09:36:11.419Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/dialer/src/plasmaphonedialer_autogen/mocs_compilation.cpp:2:[2020-01-30T09:36:11.419Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/dialer/src/plasmaphonedialer_autogen/EWIEGA46WW/moc_call-handler.cpp:10:[2020-01-30T09:36:11.419Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/dialer/src/call-handler.h:20:[2020-01-30T09:36:11.419Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/AbstractClientHandler:8:[2020-01-30T09:36:11.419Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/abstract-client.h:31:[2020-01-30T09:36:11.419Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/SharedPtr:8:[2020-01-30T09:36:11.419Z] /usr/local/include/telepathy-qt5/TelepathyQt/shared-ptr.h:112:13: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wde

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 15 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/15/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 30 Jan 2020 09:30:13 +
 Build duration:
2 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 1355 lines...][2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:6822:18: warning: ���virtual void Tp::Client::ChannelInterfaceTubeInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  6822 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:7690:18: warning: ���virtual void Tp::Client::ChannelTypeCallInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  7690 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:7782:18: warning: ���virtual void Tp::Client::ChannelTypeContactListInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  7782 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:8136:18: warning: ���virtual void Tp::Client::ChannelTypeContactSearchInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  8136 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:8396:18: warning: ���virtual void Tp::Client::ChannelTypeDBusTubeInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  8396 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:9046:18: warning: ���virtual void Tp::Client::ChannelTypeFileTransferInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  9046 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:9312:18: warning: ���virtual void Tp::Client::ChannelTypeRoomListInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  9312 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:9425:18: warning: ���virtual void Tp::Client::ChannelTypeServerAuthenticationInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  9425 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:9581:18: warning: ���virtual void Tp::Client::ChannelTypeServerTLSConnectionInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  9581 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.051Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:9933:18: warning: ���virtual void Tp::Client::ChannelTypeStreamTubeInterface::invalidate(Tp::DBusProxy*, const QString&, const QString&)��� can be marked override [-Wsuggest-override][2020-01-30T09:32:19.051Z]  9933 | virtual void invalidate(Tp::DBusProxy *, const QString &, const QString &);[2020-01-30T09:32:19.051Z]   |  ^~[2020-01-30T09:32:19.313Z] /usr/include/telepathy-qt5/TelepathyQt/_gen/cli-channel.h:10538:18: warning: ���virtual void Tp::Client::ChannelTypeStreamedMediaInter

D27021: Port plasma-workspace to autoconf.kde.org

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, leinir, bcooksley.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  As per Ben's request in 
https://mail.kde.org/pipermail/kde-frameworks-devel/2020-January/102543.html

TEST PLAN
  I guess this is good for 5.18?
  
  - Can still list plasmoids and wallpapers in plasmashell ghns

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27021

AFFECTED FILES
  components/shellprivate/widgetexplorer/plasmoids.knsrc
  wallpapers/image/wallpaper.knsrc.cmake

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27020: Port plasma-desktop to autoconf.kde.org

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, leinir, bcooksley.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  As per Ben's request in 
https://mail.kde.org/pipermail/kde-frameworks-devel/2020-January/102543.html

TEST PLAN
  I guess this is good for 5.18?
  
  - Can still list icons, cursorthemes, look and feel themes in KCMs

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27020

AFFECTED FILES
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  kcms/colors/colorschemes.knsrc
  kcms/cursortheme/xcursor/xcursor.knsrc
  kcms/desktoptheme/plasma-themes.knsrc
  kcms/emoticons/emoticons.knsrc
  kcms/icons/icons.knsrc

To: broulik, #plasma, leinir, bcooksley
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27018: [sddm-theme] Fix broken wallpaper loading

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9573fd8c99ca: [sddm-theme] Fix broken wallpaper loading 
(authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27018?vs=74646&id=74650

REVISION DETAIL
  https://phabricator.kde.org/D27018

AFFECTED FILES
  sddm-theme/theme.conf.cmake

To: filipf, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> DeviceModel.cpp:119
> +const Solid::StorageAccess *access = dev.as();
> +if (access == nullptr || !access->isIgnored()) {
> +beginInsertRows(index(0, 0), m_attached.size(), 
> m_attached.size());

Do we want to add items that are *not* a `StorageAccess`?
Shouldn't this be more like

  if (access && !access->isIgnored())`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27019

To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Méven Car]

meven updated this revision to Diff 74649.
meven added a comment.


  Separate foreach conversions

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27019?vs=74647&id=74649

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27019

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26912: Use Qt5 signal syntax, format files, optimizations

[Alexander Lohnau]

alex added a comment.


  Hello,
  
  I already wondered how this will be handled.
  
  Should I abandon this revision now and maybe create a new one with the 
relevant changes once your request has been merged ?
  And is there any way I could have known that this kcm is going to be 
refactored ?
  
  And a general question: When are accepted patches merged ? For instance your 
patch https://phabricator.kde.org/D26478 is very simple and has been accepted 
for a few weeks now, but has not been merged.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26999: [Notifications] Fix action button size

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:aaf9c38749b2: [Notifications] Fix action button size 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26999?vs=74603&id=74648

REVISION DETAIL
  https://phabricator.kde.org/D26999

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Kai Uwe Broulik]

broulik added a comment.


  Can we do the foreach ports separately, please

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27019

To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 396537
  FIXED-IN: 5.18

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27019

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27018: [sddm-theme] Fix broken wallpaper loading

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We switched to .jpg for Next but SDDM theme's code still points to .png so we 
got a white screen instead.
  
  Have the code point to .jpg instead.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-broken-sddm-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27018

AFFECTED FILES
  sddm-theme/theme.conf.cmake

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  Are you asking for my approval?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Méven Car]

meven added a comment.


  > I may want to reconsider and simply add whatever service is in Default 
Application and display it, ignoring entries in "Added Associations", as I do 
elsewhere.
  
  I am thinking about doing this, as it makes the code more similar with other 
cfgplugin, and the current code in the email cfgpluginexisted mostly because it 
was the first one I edited.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D26797

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26912: Use Qt5 signal syntax, format files, optimizations

[Méven Car]

meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  This kcms is going through some refactoring in D26934 
 , not the greatest time for a mostly 
formatting PR.
  This will introduce a lot of conflict.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart