D26797: KCM/Component Refactor UI to a single list of combobox

2020-02-02 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f55252fbf5d6: KCM/Component Refactor UI to a single list 
of combobox (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26797?vs=74541&id=74892

REVISION DETAIL
  https://phabricator.kde.org/D26797

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/componentconfig_ui.ui
  kcms/componentchooser/emailclientconfig_ui.ui
  kcms/componentchooser/filemanagerconfig_ui.ui
  kcms/componentchooser/kcm_componentchooser.cpp
  kcms/componentchooser/kcm_componentchooser.h
  kcms/componentchooser/terminalemulatorconfig_ui.ui

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27053: Solid-device-automounter/kcm: Improve width of columns

2020-02-02 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8eb9e9b72a47: Solid-device-automounter/kcm: Improve width 
of columns (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27053?vs=74776&id=74891

REVISION DETAIL
  https://phabricator.kde.org/D27053

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, ngraham, ervin, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

2020-02-02 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5eb5c9ab7d7e: Solid-device-automounter/kcm: Hide ignored 
Solid::StorageAccess (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27019?vs=74767&id=74890

REVISION DETAIL
  https://phabricator.kde.org/D27019

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, #plasma, broulik, ngraham, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27071: Remove KCM Init Phase 2

2020-02-02 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> main.cpp:133
>libphase = vphase.toInt();
>  
>if( phase != -1 && libphase != phase )

can you add

if (libphase > 1 ) 
 libphase = 1

just in case of some hypothetical 3rd party out there

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27071

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27113: Delete cache when resetting user settings

2020-02-02 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Can you explain what happens that would require us to delete the cache and 
why this isn't the case when you change colour themes on a regular session.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27113

To: filipf, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27113: Delete cache when resetting user settings

2020-02-02 Thread Filip Fila 
filipf created this revision.
filipf added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Apparently SDDM's cache is not always allowing for a clean reset of user 
theming preferences so we can delete it when performing the reset.
  
  BUG: 417057
  FIXED-IN: 5.18.0

TEST PLAN
  The folder was deleted (but got created again by SDDM when logging in again)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  delete-sddm-cache (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27113

AFFECTED FILES
  sddmauthhelper.cpp

To: filipf, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Upgrade theme to Breeze GTK on startup

2020-02-02 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 74881.
gikari added a comment.


  Rename files to provide ground for more kconf scripts in the future

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26891?vs=74815&id=74881

BRANCH
  apply-theme-on-startup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26891

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kconf_update/gtkconfig.upd
  kconf_update/gtktheme.cpp
  kded/configeditor.cpp

To: gikari, fvogt
Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: Remove redundant reparse configuration call

2020-02-02 Thread David Edmundson 
davidedmundson added a comment.


  > Would it make sense to port other methods to be triggered by corresponding 
KConfigWatchers
  
  Absolutely.
  It means changing some stuff upstream to emit the change notifications, but 
it's the direction I want to take us.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: Remove redundant reparse configuration calls

2020-02-02 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 74877.
gikari added a comment.


  Rollback the reparsings that are actually needed

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27107?vs=74872&id=74877

BRANCH
  remove-reparse-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27107

AFFECTED FILES
  kded/configvalueprovider.cpp

To: gikari
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: Remove redundant reparse configuration calls

2020-02-02 Thread Mikhail Zolotukhin 
gikari added a comment.


  In D27107#604878 , @davidedmundson 
wrote:
  
  > You need to be careful here.
  >
  > Some of this code is re-evaluated on receipt of other direct DBus signals. 
Not from kconfigwatcher.
  >
  > In those cases, you will have to reparse.
  
  
  OK, so that makes 90% of this diff pointless :) Only the decorations button 
order change are triggered by `KConfigWatcher`. Would it make sense to port 
other methods to be triggered by corresponding `KConfigWatcher`s or would it 
slow down the whole process of syncing settings significantly?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

2020-02-02 Thread Alexander Lohnau 
alex updated this revision to Diff 74875.
alex added a comment.


  Minor formatting improvements

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27109?vs=74874&id=74875

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, broulik, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

2020-02-02 Thread Alexander Lohnau 
alex created this revision.
alex added reviewers: broulik, davidedmundson, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The sessions are now only loaded when the plugin is initialized or the folder 
changes.
  Additionally the option to search for a session just by the name has been 
removed,
  because Kate itself provides this functionality (demonstated in screenshots).

TEST PLAN
  Create sessions, they should show up like in the last two screenshots.
  After testing this create/edit/delete sessions, the changes should be 
automatically applied.
  Before:
  F8078772: before_duplicate_launch_entries.png 

  After:
  F8078770: after_no_duplicates.png 
  Search with "kate" prefix should work as before:
  F8078771: works_same.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, broulik, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: Remove redundant reparse configuration calls

2020-02-02 Thread David Edmundson 
davidedmundson added a comment.


  You need to be careful here.
  
  Some of this code is re-evaluated on receipt of other direct DBus signals. 
Not from kconfigwatcher.
  
  In those cases, you will have to reparse.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: Remove redundant reparse configuration calls

2020-02-02 Thread Mikhail Zolotukhin 
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since KConfigWatcher automatically reparses configuration on change, these 
calls are redundant.

TEST PLAN
  Check if config changes are detected by changing cursor theme, font name etc.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  remove-reparse-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27107

AFFECTED FILES
  kded/configvalueprovider.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

2020-02-02 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> ListItemBase.qml:111
>  RowLayout {
> -Layout.fillWidth: true
> +Layout.minimumHeight: contextMenuButton.height
>  

That's asking for a binding loop.

An implicit size should never be based on a current size.

This could be:
Layout.minimumHeight: contextMenuButton.implicitHeight

Though I'm surprised you need this line at all.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: davidedmundson, cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27100: Parameterise GTK config editing

2020-02-02 Thread Mikhail Zolotukhin 
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  This diff is only touches the editing part of the ConfigEditor.
  
  Changes:
  
  1. Pass config values as the respecting types: `int`, `bool` and `string`. 
This simplifies config editing in some extent - no more hardcoded options 
names, that requires quotes around values in gtkrc-2.0 and xsettingsd.conf. 
Also it simplifies working with GSettings API and helps to transform KDE config 
options to GTK config options.
  2. Remove redundant `\\n` symbols, when adding new option in gtkrc-2.0 and 
xsettingsd.conf

TEST PLAN
  1. Restart Kded
  2. Test all settings syncing. Specifically boolean ones and enum ones, as the 
format in configuration files has changed:
  3. `Settings.ini` uses new booleans (`true` and `false` instead of `1` and 
`0`)
  4. `Settings.ini`, `.gtkrc-2.0` and `xsettingsd.conf` use `int` value of enum 
instead of `string`

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

2020-02-02 Thread Alexander Lohnau 
alex updated this revision to Diff 74853.
alex added a comment.


  Allow search for profiles without "konsole" prefix

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=74852&id=74853

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

2020-02-02 Thread Alexander Lohnau 
alex created this revision.
alex added reviewers: davidedmundson, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Now Konsole is actually startet when an option is selected.
  Additionally the match method has been rewritten and the profiles are only 
loaded when the plugin
  is initialized or the config folder changes.

TEST PLAN
  Create different profiles and start the runner using the keyword "konsole", 
all profiles should show
  up, if one is selected, konsole launches with this profile.
  To filter the profiles you can type "konsole KEYWORD" and only the profiles 
that contain the keyword show up.
  Furthermore you can create/edit/delete new profiles after the runner is 
initailized and they still show up.

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart