date:20200207

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-02-07 Thread Carson Black

cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in reloader.c:26
> What is this 801?

GTK loads in the original colors.css at priority 800, so priority 801 will 
override it.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol
Cc: davidedmundson, nicolasfella, GB_2, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-02-07 Thread Carson Black

cblack marked an inline comment as done.
cblack added a comment.


  Looking at documentation, the colour module should gracefully fail when it's 
unable to locate the colors.css, however I have not tested this.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol
Cc: davidedmundson, nicolasfella, GB_2, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-02-07 Thread David Edmundson

davidedmundson added a comment.


  This would also be loaded and operational when running in a gnome session. 
It's important we don't cause issues there.
  
  Does this work if colours.css doesn't exist and is then created at runtime?

INLINE COMMENTS

> reloader.c:26
> +801
> +);
> +gtk_css_provider_load_from_file(

What is this 801?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol
Cc: davidedmundson, nicolasfella, GB_2, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-02-07 Thread Carson Black

cblack updated this revision to Diff 75205.
cblack added a comment.


  Fix memory leak

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24275?vs=75203=75205

BRANCH
  arcpatch-D24275_1

REVISION DETAIL
  https://phabricator.kde.org/D24275

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, apol
Cc: nicolasfella, GB_2, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-02-07 Thread Carson Black

cblack updated this revision to Diff 75203.
cblack added a comment.


  Drop meson.build, clean CMakeLists.txt, rebase on master

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24275?vs=70834=75203

BRANCH
  arcpatch-D24275_1

REVISION DETAIL
  https://phabricator.kde.org/D24275

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, apol
Cc: nicolasfella, GB_2, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27225: Add support for static platformtheme plugins

2020-02-07 Thread Mason McParlane

masonm created this revision.
masonm added reviewers: VDG, Kirigami, mart.
masonm added a project: Kirigami.
masonm requested review of this revision.

REVISION SUMMARY
  PlatformTheme::qmlAttachedProperties is currently not looking for static 
KirigamiPluginFactory plugins. This change will search for static plugins for 
static builds, otherwise it will search shared object plugins.
  
  It also includes a fix for missing QIcon header.

TEST PLAN
  Register a custom, static KirigamiPluginFactory plugin using Q_IMPORT_PLUGIN 
and verify the attached properties work as expected. For example, regardless of 
what the style is set to when building with KIRIGAMI_BUILD_TYPE_STATIC below 
the theme should load with bright-green components:
  
// In main.cpp

#ifdef KIRIGAMI_BUILD_TYPE_STATIC
#include 
#include 
Q_IMPORT_PLUGIN(DefaultThemeFactory)
#endif

int main(int argc, char argv[]) {

  // ...
  
#ifdef KIRIGAMI_BUILD_TYPE_STATIC
KirigamiPlugin::registerTypes();
#endif

  // ...
  
}

// In KirigamiThemes/Default/defaulttheme.h

#ifndef DEFAULTTHEME_H
#define DEFAULTTHEME_H

#include "../KirigamiThemes_global.h"
#include 

class KIRIGAMITHEMES_EXPORT DefaultTheme : public Kirigami::PlatformTheme
{
Q_OBJECT
QPalette lightPalette;

public:
explicit DefaultTheme(QObject* parent = nullptr);
};

class KIRIGAMITHEMES_EXPORT DefaultThemeFactory
: public Kirigami::KirigamiPluginFactory
{
Q_OBJECT
Q_PLUGIN_METADATA(IID KirigamiPluginFactory_iid)
Q_INTERFACES(Kirigami::KirigamiPluginFactory)

public:
explicit DefaultThemeFactory(QObject* parent = nullptr)
: Kirigami::KirigamiPluginFactory(parent)
{
}

Kirigami::PlatformTheme *createPlatformTheme(QObject *parent) override;
};

#endif


// In KirigamiThemes/Default/defaulttheme.cpp

#include "defaulttheme.h"

DefaultTheme::DefaultTheme(QObject* parent) : 
Kirigami::PlatformTheme(parent)
{
for (auto group : {QPalette::Active, QPalette::Inactive, 
QPalette::Disabled}) {
lightPalette.setColor(group, QPalette::WindowText, "#00FF00");
lightPalette.setColor(group, QPalette::Window, "#00FF00");
lightPalette.setColor(group, QPalette::Base, "#00FF00");
lightPalette.setColor(group, QPalette::Text, "#00FF00");
lightPalette.setColor(group, QPalette::Button, "#00FF00");
lightPalette.setColor(group, QPalette::ButtonText, "#00FF00");
lightPalette.setColor(group, QPalette::Highlight, "#00FF00");
lightPalette.setColor(group, QPalette::HighlightedText, "#00FF00");
lightPalette.setColor(group, QPalette::ToolTipBase, "#00FF00");
lightPalette.setColor(group, QPalette::ToolTipText, "#00FF00");
lightPalette.setColor(group, QPalette::Link, "#00FF00");
lightPalette.setColor(group, QPalette::LinkVisited, "#00FF00");
}

setTextColor(lightPalette.color(QPalette::Active, 
QPalette::WindowText));
setBackgroundColor(lightPalette.color(QPalette::Active, 
QPalette::Window));
setHighlightColor(lightPalette.color(QPalette::Active, 
QPalette::Highlight));
setHighlightedTextColor(lightPalette.color(QPalette::Active, 
QPalette::HighlightedText));
setLinkColor(lightPalette.color(QPalette::Active, QPalette::Link));
setVisitedLinkColor(lightPalette.color(QPalette::Active, 
QPalette::LinkVisited));
}

Kirigami::PlatformTheme *DefaultThemeFactory::createPlatformTheme(QObject 
*parent)
{
return new DefaultTheme(parent);
}

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27225

AFFECTED FILES
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: masonm, #vdg, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27199: [WIP][Applet]Update layout based on T10470

2020-02-07 Thread Manuel Jesús de la Fuente

manueljlin added a comment.


  I think that it should use a footer to be consistent with the other ones

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [WIP][Applet]Update layout based on T10470

2020-02-07 Thread George Vogiatzis

gvgeo planned changes to this revision.
gvgeo added a comment.


  Found a better way to hide the separator.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27212: Have pullback toolbars on scrollable pages also for footers

2020-02-07 Thread Camilo Higuita

camiloh updated this revision to Diff 75195.
camiloh added a comment.


  correct undefined line

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27212?vs=75168=75195

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27212

AFFECTED FILES
  src/controls/templates/AbstractApplicationHeader.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes, per VDG mockup

2020-02-07 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Depends on D27221 

TEST PLAN
  Before: F8090890: Small.png 
  
  After: F8090880: SmallMedium.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  smallMedium-playback-toolbuttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27222

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-07 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5194d6183094: [applets/taskmanager] Clean up Tooltip code 
(authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27182?vs=75189=75190

REVISION DETAIL
  https://phabricator.kde.org/D27182

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, ndavis
Cc: hein, trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-07 Thread Nathaniel Graham

ngraham updated this revision to Diff 75189.
ngraham added a comment.


  @trmdi was right, I did make it a bit bigger by accident

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27182?vs=75188=75189

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, ndavis
Cc: hein, trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-07 Thread Nathaniel Graham

ngraham updated this revision to Diff 75188.
ngraham added a comment.


  Remove unnecessary spacing in the ColumnLayout with all Headings in it

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27182?vs=75109=75188

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, ndavis
Cc: hein, trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-07 Thread Eike Hein

hein added a comment.


  trmdi's point is good, otherwise I like it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: hein, trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

2020-02-07 Thread Tranter Madi

trmdi added a comment.


  Could you post screenshots of a same tab?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma
Cc: trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

2020-02-07 Thread Nathaniel Graham

ngraham added a comment.


  The strings could use a bit of adjustment, but I'll have to do that on master.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

2020-02-07 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We use this centered style in many other places and are moving towards using 
it
  everywhere. This patch applies the same style to the System Tray popups for
  notifications and devices, which were still using the old style.

TEST PLAN
  F8090777: notifications.png 
  
  F8090776: device notifier.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 186 - Failure!

2020-02-07 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/186/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 07 Feb 2020 17:21:34 +
 Build duration:
1 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 343 lines...][2020-02-07T17:22:58.278Z]  * KF5XmlGui (required version >= 5.66.0)[2020-02-07T17:22:58.278Z]  * Qt5Network (required version >= 5.12.0)[2020-02-07T17:22:58.278Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-02-07T17:22:58.278Z]  * Qt5DBus (required version >= 5.12.0)[2020-02-07T17:22:58.278Z]  * KF5KIO[2020-02-07T17:22:58.278Z]  * KF5[2020-02-07T17:22:58.278Z] [2020-02-07T17:22:58.278Z] -- The following OPTIONAL packages have not been found:[2020-02-07T17:22:58.278Z] [2020-02-07T17:22:58.278Z]  * packagekitqt5 (required version >= 1.0.1), Library that exposes PackageKit resources, [2020-02-07T17:22:58.278Z]Required to build the PackageKit backend[2020-02-07T17:22:58.278Z]  * AppStreamQt (required version >= 0.11.1), Library that lists Appstream resources, [2020-02-07T17:22:58.278Z]Required to build the PackageKit and Flatpak backends[2020-02-07T17:22:58.278Z]  * Snapd, Library that exposes Snapd, [2020-02-07T17:22:58.278Z]Required to build the Snap backend[2020-02-07T17:22:58.278Z] [2020-02-07T17:22:58.278Z] -- Configuring done[2020-02-07T17:22:58.905Z] -- Generating done[2020-02-07T17:22:58.905Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-07T17:22:59.874Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project discover --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-02-07T17:23:00.142Z] Scanning dependencies of target DiscoverCommon_autogen[2020-02-07T17:23:00.142Z] [  1%] Automatic MOC for target DiscoverCommon[2020-02-07T17:23:00.142Z] Scanning dependencies of target DiscoverNotifiers_autogen[2020-02-07T17:23:00.423Z] Scanning dependencies of target PaginateModelTest_autogen[2020-02-07T17:23:00.423Z] [  2%] Automatic MOC for target DiscoverNotifiers[2020-02-07T17:23:00.423Z] [  3%] Automatic MOC for target PaginateModelTest[2020-02-07T17:23:03.212Z] [  3%] Built target DiscoverNotifiers_autogen[2020-02-07T17:23:03.212Z] Scanning dependencies of target DiscoverNotifiers[2020-02-07T17:23:03.212Z] [  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[2020-02-07T17:23:03.513Z] [  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[2020-02-07T17:23:04.507Z] [  5%] Built target PaginateModelTest_autogen[2020-02-07T17:23:04.800Z] Scanning dependencies of target PaginateModelTest[2020-02-07T17:23:05.067Z] [  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[2020-02-07T17:23:05.067Z] [  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[2020-02-07T17:23:05.067Z] [  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[2020-02-07T17:23:07.046Z] [  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/discover_debug.cpp.o[2020-02-07T17:23:07.650Z] [  9%] Linking CXX shared library ../../bin/libDiscoverNotifiers.so[2020-02-07T17:23:07.650Z] [  9%] Built target DiscoverNotifiers[2020-02-07T17:23:07.650Z] [  9%] Built target DiscoverCommon_autogen[2020-02-07T17:23:07.650Z] Scanning dependencies of target DummyNotifier_autogen[2020-02-07T17:23:07.650Z] Scanning dependencies of target DiscoverNotifier_autogen[2020-02-07T17:23:07.922Z] [ 10%] Automatic MOC for target DummyNotifier[2020-02-07T17:23:07.922Z] [ 11%] Automatic MOC for target DiscoverNotifier[2020-02-07T17:23:08.542Z] [ 11%] Built target DummyNotifier_autogen[2020-02-07T17:23:08.542Z] Scanning dependencies of target DummyNotifier[2020-02-07T17:23:08.542Z] [ 12%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[2020-02-07T17:23:08.542Z] [ 13%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[2020-02-07T17:23:08.803Z] [ 13%] Built target DiscoverNotifier_autogen[2020-02-07T17:23:09.067Z] Scanning dependencies of target DiscoverCommon[2020-02-07T17:23:09.067Z] [ 14%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[2020-02-07T17:23:09.067Z] Scanning dependencies of target DiscoverNotifier[2020-02-07T17:23:09.067Z] [ 15%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[2020-02-07T17:23:09.067Z] [ 15%] Building CXX object

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 333 - Failure!

2020-02-07 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/333/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 07 Feb 2020 17:21:34 +
 Build duration:
52 sec and counting
   CONSOLE OUTPUT
  [...truncated 402 lines...][2020-02-07T17:22:20.486Z]  * Qt5Core (required version >= 5.12.0)[2020-02-07T17:22:20.486Z]  * Qt5Xml (required version >= 5.12.0)[2020-02-07T17:22:20.486Z]  * KF5Config (required version >= 5.67.0)[2020-02-07T17:22:20.486Z]  * Qt5Widgets (required version >= 5.12.0)[2020-02-07T17:22:20.486Z]  * KF5XmlGui (required version >= 5.67.0)[2020-02-07T17:22:20.486Z]  * Qt5Network (required version >= 5.12.0)[2020-02-07T17:22:20.486Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-02-07T17:22:20.486Z]  * Qt5DBus (required version >= 5.12.0)[2020-02-07T17:22:20.486Z]  * KF5KIO[2020-02-07T17:22:20.486Z]  * KF5[2020-02-07T17:22:20.486Z] [2020-02-07T17:22:20.486Z] -- The following OPTIONAL packages have not been found:[2020-02-07T17:22:20.486Z] [2020-02-07T17:22:20.486Z]  * packagekitqt5 (required version >= 1.0.1), Library that exposes PackageKit resources, [2020-02-07T17:22:20.486Z]Required to build the PackageKit backend[2020-02-07T17:22:20.486Z]  * Snapd, Library that exposes Snapd, [2020-02-07T17:22:20.486Z]Required to build the Snap backend[2020-02-07T17:22:20.486Z] [2020-02-07T17:22:20.745Z] -- Configuring done[2020-02-07T17:22:20.745Z] -- Generating done[2020-02-07T17:22:20.745Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-07T17:22:21.575Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project discover --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-02-07T17:22:21.575Z] Scanning dependencies of target DiscoverCommon_autogen[2020-02-07T17:22:21.575Z] Scanning dependencies of target DiscoverNotifiers_autogen[2020-02-07T17:22:21.575Z] Scanning dependencies of target PaginateModelTest_autogen[2020-02-07T17:22:21.575Z] [  1%] Automatic MOC for target DiscoverCommon[2020-02-07T17:22:21.575Z] [  2%] Automatic MOC for target DiscoverNotifiers[2020-02-07T17:22:21.575Z] [  3%] Automatic MOC for target PaginateModelTest[2020-02-07T17:22:21.837Z] [  3%] Built target DiscoverNotifiers_autogen[2020-02-07T17:22:21.837Z] Scanning dependencies of target DiscoverNotifiers[2020-02-07T17:22:21.837Z] [  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[2020-02-07T17:22:21.837Z] [  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[2020-02-07T17:22:21.837Z] [  4%] Built target PaginateModelTest_autogen[2020-02-07T17:22:21.837Z] Scanning dependencies of target PaginateModelTest[2020-02-07T17:22:21.837Z] [  5%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[2020-02-07T17:22:21.837Z] [  5%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/discover_debug.cpp.o[2020-02-07T17:22:21.837Z] [  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[2020-02-07T17:22:21.837Z] [  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[2020-02-07T17:22:22.098Z] [  7%] Built target DiscoverCommon_autogen[2020-02-07T17:22:22.098Z] Scanning dependencies of target DiscoverCommon[2020-02-07T17:22:22.098Z] [  7%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[2020-02-07T17:22:22.098Z] [  8%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[2020-02-07T17:22:22.098Z] [  9%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[2020-02-07T17:22:22.098Z] [ 10%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[2020-02-07T17:22:22.098Z] [ 11%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[2020-02-07T17:22:22.098Z] [ 12%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[2020-02-07T17:22:22.357Z] [ 12%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[2020-02-07T17:22:22.357Z] [ 13%] Linking CXX shared library ../../bin/libDiscoverNotifiers.so[2020-02-07T17:22:22.357Z] [ 14%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[2020-02-07T17:22:22.616Z] [ 14%] Built target DiscoverNotifiers[2020-02-07T17:22:22.616Z] [ 15%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[2020-02-07T17:22:22.616Z] [ 16%] Building CXX object

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-07 Thread Tranter Madi

trmdi added inline comments.

INLINE COMMENTS

> ngraham wrote in ToolTipInstance.qml:100
> Depends on the font; you can't necessarily count on that.

Heading has `lineHeight: 1.2`, so there are 2 things for padding here right? 
Could we remove one?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-07 Thread Nathaniel Graham

ngraham added a comment.


  Is `gridUnit` screen-size-aware? That would be kind of weird.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D15418: Dim application icon when it is not playing anything

2020-02-07 Thread George Vogiatzis

gvgeo added a comment.


  In D15418#604205 , @alexde wrote:
  
  > ...what about adding an overlay pause-icon, similar to D3302 
?...
  
  
  This could be interpreted as a button.
  
  Not that we removed the audiostream description, can add a message to the 
right ` (No output)`
  
  Although I like none of these two. I prefer simply dimming the label.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-07 Thread Tranter Madi

trmdi added a comment.


  It's super big on my 1366x768 screen:
  
  Before:
  F8090526: image.png 
  After:
  F8090521: image.png 
  
  And the Before and After size are not the same.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread George Vogiatzis

gvgeo updated this revision to Diff 75176.
gvgeo added a comment.


  i18n without context.
  Fix typo, from previous commit.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27205?vs=75167=75176

BRANCH
  names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27205

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27084: Don't delay ksplash until the entire lideshow is loaded

2020-02-07 Thread David Redondo

davidre added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27084

To: davidre, davidedmundson, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27136: [Cuttlefish] Remove last traces of themes and plasma themes

2020-02-07 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:bd130c6b0225: [Cuttlefish] Remove last traces of themes 
and plasma themes (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27136?vs=74942=75174#toc

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27136?vs=74942=75174

REVISION DETAIL
  https://phabricator.kde.org/D27136

AFFECTED FILES
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

2020-02-07 Thread Harald Sitter

sitter updated this revision to Diff 75170.
sitter added a comment.


  move from qmap to straight up qlist as values() within the map wouldn't 
necessarily have the expected order. instead find_by udi on add/remove and rely 
on index within the list the rest of the time
  
  additional qa: have 2 mounts, mount/umount randomly

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27061?vs=74992=75170

BRANCH
  smb

REVISION DETAIL
  https://phabricator.kde.org/D27061

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/MIT.txt
  Modules/samba/CMakeLists.txt
  Modules/samba/autotests/CMakeLists.txt
  Modules/samba/autotests/ksambasharemodeltest.cpp
  Modules/samba/autotests/smbmountmodeltest.cpp
  Modules/samba/kcmsambaimports.cpp
  Modules/samba/kcmsambaimports.h
  Modules/samba/kcmsambalog.cpp
  Modules/samba/kcmsambalog.h
  Modules/samba/kcmsambastatistics.cpp
  Modules/samba/kcmsambastatistics.h
  Modules/samba/ksambasharemodel.cpp
  Modules/samba/ksambasharemodel.h
  Modules/samba/ksmbstatus.cpp
  Modules/samba/ksmbstatus.h
  Modules/samba/main.cpp
  Modules/samba/smbmountmodel.cpp
  Modules/samba/smbmountmodel.h

To: sitter, #localization, #plasma, #vdg
Cc: jriddell, davidedmundson, ltoscano, yurchor, ngraham, alexde, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27079: Don't escape search text in search page title

2020-02-07 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:9bf3f942d329: Dont escape search text in search 
page title (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27079?vs=74948=75169

REVISION DETAIL
  https://phabricator.kde.org/D27079

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread George Vogiatzis

gvgeo planned changes to this revision.
gvgeo added a comment.


  I get some more messages now...

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27205

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27212: Have pullback toolbars on scrollable pages also for footers

2020-02-07 Thread Camilo Higuita

camiloh created this revision.
camiloh added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27212

AFFECTED FILES
  src/controls/templates/AbstractApplicationHeader.qml

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27061: replace samba module with data that works

2020-02-07 Thread Jonathan Riddell

jriddell added a comment.


  As release mangler for Plasma I'd normally point out this is a breach of 
feature freeze, but it seems to have the support of important Plasma people so 
great go ahead when ready.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27061

To: sitter, #localization, #plasma, #vdg
Cc: jriddell, davidedmundson, ltoscano, yurchor, ngraham, alexde, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27079: Don't escape search text in search page title

2020-02-07 Thread Aleix Pol Gonzalez

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  whatever

REPOSITORY
  R134 Discover Software Store

BRANCH
  show-search-text-un-escaped (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread George Vogiatzis

gvgeo added a comment.


  > If this is something that should be shown to the user
  
  It should not. It worked like that for years. I have never encounter this, as 
a UI bug. And I don't expect that I'll ever see that message.
  It's more to avoid error messages. And for the rare occasion for a device not 
having a Description.
  
  But if it exist, it can be shown to user. Feel sorry for the translators. 
This may never be read.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27205

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread George Vogiatzis

gvgeo updated this revision to Diff 75167.
gvgeo added a comment.


  localize

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27205?vs=75154=75167

BRANCH
  names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27205

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

2020-02-07 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> smbmountmodel.cpp:73
> +case ColumnRole::Share:
> +return 
> devices().at(index.row()).as()->url();
> +case ColumnRole::Path:

This looks dangerous.

You always add row indexes to the end, but you're taking an index of 
map.values() for the source.

Qmap::values retains order within entires, but the whole list is not ordered by 
global insertion time.

i.e If you call addDevice it could insert in the middle of what .values returns 
even though from a model pov you've said it's at the end. This will break a UI.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27061

To: sitter, #localization, #plasma, #vdg
Cc: davidedmundson, ltoscano, yurchor, ngraham, alexde, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread Nathaniel Graham

ngraham added a reviewer: VDG.
ngraham added inline comments.

INLINE COMMENTS

> DeviceListItem.qml:49
> +}
> +return "Device name not found";
>  }

If this is something that should be shown to the user (is it?), then it needs 
to be localized by wrapping it in `i18n()`

> StreamListItem.qml:35
> +}
> +return "Stream name not found";
> +}

ditto

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27205

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

2020-02-07 Thread Luigi Toscano

ltoscano added a comment.


  As no one else complained, and given the general brokeness of the current 
code, I'd say: please go for it. 5.18.0 is already tagged, there are ~11 days 
before 5.18.1 (planned for Tue 11th) and ~18 before 5.18.2, so we will probably 
catch up.
  
  +1 from the localization point of view (I can't comment on the rest of the 
code).

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27061

To: sitter, #localization, #plasma, #vdg
Cc: ltoscano, yurchor, ngraham, alexde, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

2020-02-07 Thread Nathaniel Graham

ngraham added a comment.


  #localization  folks, can we 
get an approval or rejection for this?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27061

To: sitter, #localization, #plasma, #vdg
Cc: yurchor, ngraham, alexde, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27079: Don't escape search text in search page title

2020-02-07 Thread Nathaniel Graham

ngraham added a comment.


  But again, what user would actually write, by hand, "potato" in the 
search field? When users type into a search field, they don't add HTML styling. 
That only happens if they're copying and pasting from another source. In this 
case, if that do that and the tags come along for the ride, I'm claiming that 
the tags are unintentional and should be stripped to reflect the user's true 
intent--which is to search for the word "potato".
  
  I feel like I'm missing something here.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27079: Don't escape search text in search page title

2020-02-07 Thread Aleix Pol Gonzalez

apol added a comment.


  In D27079#607311 , @ngraham wrote:
  
  > Why is that not entirely correct? The bold tags are just styling; the user 
clearly intended to search for the word "potato".
  
  
  Because the user actually wrote "potato",  it's only styling because 
you're thinking of html :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27191: [KSplash KCM] Fix ghns button label

2020-02-07 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1e10987d5af9: [KSplash KCM] Fix ghns button label 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27191?vs=75100=75162

REVISION DETAIL
  https://phabricator.kde.org/D27191

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml

To: broulik, #plasma, yurchor, kde-i18n-doc
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

rewrite samba KIC plugin in stable branch

2020-02-07 Thread Harald Sitter

It's come to my attention that people don't read diff emails so here's
your explicit notification that there is a rewrite diff up for landing
in 5.18 https://phabricator.kde.org/D27061

D27079: Don't escape search text in search page title

2020-02-07 Thread Nathaniel Graham

ngraham added a comment.


  Why is that not entirely correct? The bold tags are just styling; the user 
clearly intended to search for the word "potato".

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27206: [Sessions KCM] Fix firmware setup

2020-02-07 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We hide the UI after we show it in `initFirmwareSetup`

TEST PLAN
  5.18, should we respin?
  
  - Can reboot to firwmare setup again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27206

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp

To: broulik, #plasma, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread George Vogiatzis

gvgeo updated this revision to Diff 75154.
gvgeo added a comment.


  typo

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27205?vs=75152=75154

BRANCH
  names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27205

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread George Vogiatzis

gvgeo added a comment.


  Occasionally I get this.
  
kf5.ki18n: "0 instead of 1 arguments to message {Adjust volume for %1} 
supplied before conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Mute %1} supplied before 
conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Show additional opti...} 
supplied before conversion."
org.kde.plasma.pulseaudio: No object for name 
"alsa_output.pci-_00_1b.0.analog-stereo"

qrc:/plasma/plasmoids/org.kde.plasma.volume/contents/ui/ListItemBase.qml:118: 
TypeError: Value is undefined and could not be converted to an object

qrc:/plasma/plasmoids/org.kde.plasma.volume/contents/ui/ListItemBase.qml:144: 
TypeError: Value is undefined and could not be converted to an object
kf5.ki18n: "0 instead of 1 arguments to message {Adjust volume for %1} 
supplied before conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Mute %1} supplied before 
conversion."
kf5.ki18n: "0 instead of 1 arguments to message {Show additional opti...} 
supplied before conversion."
org.kde.plasma.pulseaudio: No object for name 
"alsa_output.pci-_00_1b.0.analog-stereo"
org.kde.plasma.pulseaudio: No object for name 
"alsa_input.pci-_00_1b.0.analog-stereo"
org.kde.plasma.pulseaudio: No object for name "PulseEffects_apps.monitor"
org.kde.plasma.pulseaudio: No object for name "PulseEffects_apps.monitor"
org.kde.plasma.pulseaudio: No object for name 
"alsa_input.pci-_00_1b.0.analog-stereo"
  
  This patch will hide the warnings from the applet side and make it more 
foolproof.
  The problem still exists.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27205

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

2020-02-07 Thread George Vogiatzis

gvgeo created this revision.
gvgeo added reviewers: Plasma, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Added more checks and an error message.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27205

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [WIP][Applet]Update layout based on T10470

2020-02-07 Thread George Vogiatzis

gvgeo updated this revision to Diff 75150.
gvgeo edited the summary of this revision.
gvgeo added a comment.


  Remove active connections section.
  
  I had a typo in my script.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75129=75150

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/main.qml
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27079: Don't escape search text in search page title

2020-02-07 Thread Aleix Pol Gonzalez

apol added a comment.


  So with this change, if you search "potato", you'll get as a title 
"potato". I wouldn't say that's entirely correct.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27079

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27129: [Notifications] Allow expiring an entire group

2020-02-07 Thread Kai Uwe Broulik

broulik added a comment.


  Hmm just crashed on me:
  
#6  0x7f7a94c1cdf4 in 
NotificationManager::NotificationGroupingProxyModel::index(int, int, 
QModelIndex const&) const (this=0x555f621dd0e0, row=0, column=, 
parent=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:241
#7  0x7f7a94c0e92f in 
NotificationManager::Notifications::expire(QModelIndex const&) 
(this=0x555f621c08b0, idx=...) at 
/home/kaiuwe/Projekte/kf5/plasma-workspace/libnotificationmanager/notifications.cpp:672

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27129

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

50 matches

Mail list logo