D27262: Reduce blank space inside header

2020-02-08 Thread Tranter Madi 
trmdi created this revision.
trmdi added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Make the tooltip as compact as possible. This is also consistent with texts 
inside playerControlRow

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reduce-tooltip-blank-space (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27262

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-08 Thread Tranter Madi 
trmdi updated this revision to Diff 75287.
trmdi added a comment.


  - Remove the redundant line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75286=75287

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-08 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  LGTM! @broulik, are you happy with this now?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-08 Thread Tranter Madi 
trmdi updated this revision to Diff 75286.
trmdi added a comment.


  - Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75026=75286

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis
Cc: broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27261: [Folder view] Fix binding loop on width

2020-02-08 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This fixes the binding loop and replaces a complicated bit of code with 
something much
  simpler.

TEST PLAN
  No more binding loop warning when running `plasmashell` on the CLI
  
  No meaningful difference in appearance for every combination of icon size and 
label
  width in icon view

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-folderview-binding-loop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27261

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still unstable!

2020-02-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/33/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 08 Feb 2020 22:58:45 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 56 - Still Failing!

2020-02-08 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/56/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Feb 2020 22:58:45 +
 Build duration:
56 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-02-08T22:59:39.351Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-08T22:59:39.351Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-02-08T22:59:39.351Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/56/display/redirect'[2020-02-08T22:59:39.351Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-08T22:59:39.351Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-08T22:59:39.351Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-08T22:59:39.351Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-08T22:59:39.351Z] NODE_NAME = 'Docker Swarm-7ad722637e37'[2020-02-08T22:59:39.351Z] HOST  = '7ad722637e37'[2020-02-08T22:59:39.351Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-08T22:59:39.351Z] USER  = 'jenkins'[2020-02-08T22:59:39.351Z] MORE  = '-sl'[2020-02-08T22:59:39.351Z] CSHEDIT   = 'emacs'[2020-02-08T22:59:39.351Z] SHLVL = '2'[2020-02-08T22:59:39.351Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-56'[2020-02-08T22:59:39.351Z] WINDOWMANAGER = 'xterm'[2020-02-08T22:59:39.351Z] PAGER = 'less'[2020-02-08T22:59:39.351Z] EXECUTOR_NUMBER   = '0'[2020-02-08T22:59:39.351Z] CVS_RSH   = 'ssh'[2020-02-08T22:59:39.351Z] LIBGL_DEBUG   = 'quiet'[2020-02-08T22:59:39.351Z] STAGE_NAME= 'Configuring Build'[2020-02-08T22:59:39.351Z] NODE_LABELS   = 'Docker Swarm-7ad722637e37 SUSEQt5.12'[2020-02-08T22:59:39.351Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-08T22:59:39.351Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-08T22:59:39.351Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-08T22:59:39.351Z] PROFILEREAD   = 'true'[2020-02-08T22:59:39.351Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-08T22:59:39.351Z] HOSTTYPE  = 'x86_64'[2020-02-08T22:59:39.351Z] BUILD_ID  = '56'[2020-02-08T22:59:39.351Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-08T22:59:39.351Z] OLDPWD= '/home/jenkins'[2020-02-08T22:59:39.351Z] LC_CTYPE  = 'C.UTF-8'[2020-02-08T22:59:39.352Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-08T22:59:39.352Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-08T22:59:39.352Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-08T22:59:39.352Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-08T22:59:39.352Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-08T22:59:39.352Z] QT_SELECT = 'qt5'[2020-02-08T22:59:39.352Z] LANG  = 'en_US.UTF-8'[2020-02-08T22:59:39.352Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-08T22:59:39.352Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-08T22:59:39.352Z] [2020-02-08T22:59:39.352Z] [2020-02-08T22:59:39.352Z] == Commencing Configuration:[2020-02-08T22:59:39.352Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-02-08T22:59:39.617Z] -- The C compiler identification is GNU 9.2.1[2020-02-08T22:59:39.617Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-08T22:59:39.617Z] -- Check for working C compiler: /usr/bin/cc[2020-02-08T22:59:39.876Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-08T22:59:39.876Z] -- Detecting C compiler ABI info[2020-02-08T22:59:39.876Z] -- Detecting C compiler ABI info - done[2020-02-08T22:59:39.876Z] -- Detecting C compile features[2020-02-08T22:59:39.876Z] -- Detecting C compile features - done[2020-02-08T22:59:39.876Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-08T22:59:40.139Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-08T22:59:40.139Z] --

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Failing!

2020-02-08 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/32/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 08 Feb 2020 21:02:12 +
 Build duration:
56 min and counting
   CONSOLE OUTPUT
  [...truncated 499 lines...][2020-02-08T21:58:20.765Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-02-08T21:58:20.765Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-02-08T21:58:20.765Z] ^[2020-02-08T21:58:20.765Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-02-08T21:58:20.765Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-02-08T21:58:20.765Z] ^[2020-02-08T21:58:20.765Z] /usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13/kstart/kstart.cpp:189:2: warning: #warning is a language extension [-Wpedantic][2020-02-08T21:58:20.765Z] #warning "Porting required"[2020-02-08T21:58:20.765Z]  ^[2020-02-08T21:58:20.765Z] /usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13/kstart/kstart.cpp:189:2: warning: "Porting required" [-W#warnings][2020-02-08T21:58:20.765Z] /usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13/kstart/kstart.cpp:222:2: warning: #warning is a language extension [-Wpedantic][2020-02-08T21:58:20.765Z] #warning "Porting required."[2020-02-08T21:58:20.765Z]  ^[2020-02-08T21:58:20.765Z] /usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13/kstart/kstart.cpp:222:2: warning: "Porting required." [-W#warnings][2020-02-08T21:58:20.765Z] /usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13/kstart/kstart.cpp:252:16: warning: 'flush' is deprecated [-Wdeprecated-declarations][2020-02-08T21:58:20.765Z] QApplication::flush();[2020-02-08T21:58:20.765Z]   ^[2020-02-08T21:58:20.765Z] /usr/local/include/qt5/QtCore/qcoreapplication.h:169:5: note: 'flush' has been explicitly marked deprecated here[2020-02-08T21:58:20.765Z] QT_DEPRECATED static void flush();[2020-02-08T21:58:20.765Z] ^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-02-08T21:58:20.766Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-02-08T21:58:20.766Z] ^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-02-08T21:58:20.766Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-02-08T21:58:20.766Z] ^[2020-02-08T21:58:20.766Z] /usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13/kstart/kstart.cpp:282:37: warning: 'screenGeometry' is deprecated: Use QGuiApplication::screens() [-Wdeprecated-declarations][2020-02-08T21:58:20.766Z] QRect r = QApplication::desktop()->screenGeometry();[2020-02-08T21:58:20.766Z]^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtWidgets/qdesktopwidget.h:79:5: note: 'screenGeometry' has been explicitly marked deprecated here[2020-02-08T21:58:20.766Z] QT_DEPRECATED_X("Use QGuiApplication::screens()") const QRect screenGeometry(int screen = -1) const;[2020-02-08T21:58:20.766Z] ^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2020-02-08T21:58:20.766Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2020-02-08T21:58:20.766Z] ^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2020-02-08T21:58:20.766Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2020-02-08T21:58:20.766Z]   ^[2020-02-08T21:58:20.766Z] /usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13/kstart/kstart.cpp:295:19: warning: 'flush' is deprecated [-Wdeprecated-declarations][2020-02-08T21:58:20.766Z] QApplication::flush();[2020-02-08T21:58:20.766Z]   ^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtCore/qcoreapplication.h:169:5: note: 'flush' has been explicitly marked deprecated here[2020-02-08T21:58:20.766Z] QT_DEPRECATED static void flush();[2020-02-08T21:58:20.766Z] ^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-02-08T21:58:20.766Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-02-08T21:58:20.766Z] ^[2020-02-08T21:58:20.766Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-02-08T21:58:20.766Z] #  define

D27257: [Applet]Move toolbar to the bottom

2020-02-08 Thread Nathaniel Graham 
ngraham added a comment.


  While you're at it, can you center the `disabledMessage` label and make it a 
disabled Level 3 heading? See D27219 .

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c5a6ba369c4e: Center placeholder texts in system tray 
popups (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27219?vs=75258=75284

REVISION DETAIL
  https://phabricator.kde.org/D27219

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

2020-02-08 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Depends on D27221 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 55 - Still Failing!

2020-02-08 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/55/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Feb 2020 21:02:11 +
 Build duration:
1 min 53 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-02-08T21:04:03.356Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-08T21:04:03.356Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-02-08T21:04:03.356Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/55/display/redirect'[2020-02-08T21:04:03.356Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-08T21:04:03.356Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-08T21:04:03.356Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-08T21:04:03.356Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-08T21:04:03.356Z] NODE_NAME = 'Docker Swarm-d8083db7efba'[2020-02-08T21:04:03.356Z] HOST  = 'd8083db7efba'[2020-02-08T21:04:03.356Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-08T21:04:03.356Z] USER  = 'jenkins'[2020-02-08T21:04:03.356Z] MORE  = '-sl'[2020-02-08T21:04:03.356Z] CSHEDIT   = 'emacs'[2020-02-08T21:04:03.356Z] SHLVL = '2'[2020-02-08T21:04:03.356Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-55'[2020-02-08T21:04:03.356Z] WINDOWMANAGER = 'xterm'[2020-02-08T21:04:03.356Z] PAGER = 'less'[2020-02-08T21:04:03.356Z] EXECUTOR_NUMBER   = '0'[2020-02-08T21:04:03.356Z] CVS_RSH   = 'ssh'[2020-02-08T21:04:03.356Z] LIBGL_DEBUG   = 'quiet'[2020-02-08T21:04:03.356Z] STAGE_NAME= 'Configuring Build'[2020-02-08T21:04:03.356Z] NODE_LABELS   = 'Docker Swarm-d8083db7efba SUSEQt5.12'[2020-02-08T21:04:03.356Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-08T21:04:03.356Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-08T21:04:03.356Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-08T21:04:03.356Z] PROFILEREAD   = 'true'[2020-02-08T21:04:03.356Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-08T21:04:03.356Z] HOSTTYPE  = 'x86_64'[2020-02-08T21:04:03.356Z] BUILD_ID  = '55'[2020-02-08T21:04:03.356Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-08T21:04:03.356Z] OLDPWD= '/home/jenkins'[2020-02-08T21:04:03.356Z] LC_CTYPE  = 'C.UTF-8'[2020-02-08T21:04:03.356Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-08T21:04:03.356Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-08T21:04:03.356Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-08T21:04:03.356Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-08T21:04:03.356Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-08T21:04:03.356Z] QT_SELECT = 'qt5'[2020-02-08T21:04:03.356Z] LANG  = 'en_US.UTF-8'[2020-02-08T21:04:03.356Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-08T21:04:03.356Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-08T21:04:03.356Z] [2020-02-08T21:04:03.356Z] [2020-02-08T21:04:03.356Z] == Commencing Configuration:[2020-02-08T21:04:03.356Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-02-08T21:04:03.622Z] -- The C compiler identification is GNU 9.2.1[2020-02-08T21:04:03.622Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-08T21:04:03.622Z] -- Check for working C compiler: /usr/bin/cc[2020-02-08T21:04:03.884Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-08T21:04:03.884Z] -- Detecting C compiler ABI info[2020-02-08T21:04:03.884Z] -- Detecting C compiler ABI info - done[2020-02-08T21:04:03.884Z] -- Detecting C compile features[2020-02-08T21:04:03.884Z] -- Detecting C compile features - done[2020-02-08T21:04:03.884Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-08T21:04:04.145Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-08T21:04:04.145Z] --

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread David Edmundson 
davidedmundson added a comment.


  From a code pov. +1
  
  I don't have an opinion on the UI change, but if vdg approve, ship it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27241: sddm-theme: Use non-deprecated KDEInstallDirs variable

2020-02-08 Thread Heiko Becker 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:76ccc090: sddm-theme: Use non-deprecated 
KDEInstallDirs variable (authored by heikobecker).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27241?vs=75240=75282

REVISION DETAIL
  https://phabricator.kde.org/D27241

AFFECTED FILES
  sddm-theme/theme.conf.cmake

To: heikobecker, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [WIP][Applet]Update layout based on T10470

2020-02-08 Thread George Vogiatzis 
gvgeo updated this revision to Diff 75280.
gvgeo added a comment.


  Fixed hiding function of the separator.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75150=75280

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

2020-02-08 Thread George Vogiatzis 
gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, jgrulich, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
gvgeo requested review of this revision.

REVISION SUMMARY
  Based on T10470 .
  
  Added line between search text field and buttons row.
  Added disabled wifi, mobile, airplane mode messages.
  And a `No available connections` message with a 5 second delay.
  Replaced GridLayout of toolbar with RowLayout.
  
  Depends on D27199 .

TEST PLAN
  Use buttons of the toolbar and make sure the correct message appears,
  with appropriate delay.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  flip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27257

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-08 Thread Noah Davis 
ndavis added a comment.


  Now it's unable to apply the patch because a commit it uses isn't present in 
my local git repo. Even if I create another branch based on D27221 
 and then fetch the patch with 
`--nobranch`, I get the same error.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  smallMedium-playback-toolbuttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27222

To: ngraham, #vdg, manueljlin
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

2020-02-08 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:f1768f7b3ab9: replace samba module with data that works 
(authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27061?vs=75170=75272#toc

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27061?vs=75170=75272

REVISION DETAIL
  https://phabricator.kde.org/D27061

AFFECTED FILES
  Modules/samba/CMakeLists.txt
  Modules/samba/autotests/CMakeLists.txt
  Modules/samba/autotests/ksambasharemodeltest.cpp
  Modules/samba/autotests/smbmountmodeltest.cpp
  Modules/samba/kcmsambaimports.cpp
  Modules/samba/kcmsambaimports.h
  Modules/samba/kcmsambalog.cpp
  Modules/samba/kcmsambalog.h
  Modules/samba/kcmsambastatistics.cpp
  Modules/samba/kcmsambastatistics.h
  Modules/samba/ksambasharemodel.cpp
  Modules/samba/ksambasharemodel.h
  Modules/samba/ksmbstatus.cpp
  Modules/samba/ksmbstatus.h
  Modules/samba/main.cpp
  Modules/samba/smbmountmodel.cpp
  Modules/samba/smbmountmodel.h

To: sitter, #localization, #plasma, #vdg, davidedmundson
Cc: jriddell, davidedmundson, ltoscano, yurchor, ngraham, alexde, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

2020-02-08 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I'm happy with the model.
  
  As for 5.18. I would normally be super against, but if it really didn't work 
before, then there's no point blindly following the rules if the user 
experience would be ultimately worse. Your call

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb

REVISION DETAIL
  https://phabricator.kde.org/D27061

To: sitter, #localization, #plasma, #vdg, davidedmundson
Cc: jriddell, davidedmundson, ltoscano, yurchor, ngraham, alexde, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27135: Add PagePoolAction to QRC file

2020-02-08 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c94988a6dc37: Add PagePoolAction to QRC file (authored by 
masonm, committed by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27135?vs=74940=75262

REVISION DETAIL
  https://phabricator.kde.org/D27135

AFFECTED FILES
  kirigami.qrc.in

To: masonm, #vdg, apol
Cc: plasma-devel, manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, domson, crozbo, dkardarakos, ndavis, firef, ngraham, skadinna, 
aaronhoneycutt, apol, ahiemstra, davidedmundson, mbohlender, mart, hein

D27251: Relicense to LGPL-2.0-or-later

2020-02-08 Thread Andreas Cord-Landwehr 
cordlandwehr created this revision.
cordlandwehr added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Request to Marco to relicense both files to the license
  LGPL-2.0-or-later, which is the default license for all other
  files in this repository. Right now, the these files are licensed
  via GPL and thus making the compiled Kirigami library a GPL-library.

REPOSITORY
  R169 Kirigami

BRANCH
  relicenseTabetModeWatcher

REVISION DETAIL
  https://phabricator.kde.org/D27251

AFFECTED FILES
  src/libkirigami/tabletmodewatcher.cpp
  src/libkirigami/tabletmodewatcher.h

To: cordlandwehr, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread Nathaniel Graham 
ngraham updated this revision to Diff 75258.
ngraham marked an inline comment as done.
ngraham added a comment.


  Fill, don't center

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27219?vs=75184=75258

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-08 Thread Nathaniel Graham 
ngraham added a comment.


  Try adding `--skip-dependencies`. It's probably getting confused by the 
dependent patch for a different repo.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  smallMedium-playback-toolbuttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27222

To: ngraham, #vdg, manueljlin
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27250: Add PagePoolAction to QRC file

2020-02-08 Thread Mason McParlane 
masonm created this revision.
masonm added a reviewer: VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
masonm requested review of this revision.

REVISION SUMMARY
  Missing PagePoolAction causes crash on static builds.
  Resubmission of https://phabricator.kde.org/D27135 using Arcanist.

TEST PLAN
  Create/launch static build before and after. Before will crash due to missing 
PagePoolAction.qml file.

REPOSITORY
  R169 Kirigami

BRANCH
  add-pagepool-to-qrc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27250

AFFECTED FILES
  kirigami.qrc.in

To: masonm, #vdg
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:41
>  PlasmaExtras.Heading {
> +anchors.centerIn: parent
> +horizontalAlignment: Text.AlignHCenter

Why not fill given you set the text alignment

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Failing!

2020-02-08 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.13/3/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 08 Feb 2020 14:31:48 +
 Build duration:
1 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 216 lines...][2020-02-08T14:33:16.119Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-08T14:33:16.119Z] STAGE_NAME= 'Configuring Build'[2020-02-08T14:33:16.119Z] NODE_NAME = 'FreeBSD Builder Theta'[2020-02-08T14:33:16.119Z] BLOCKSIZE = 'K'[2020-02-08T14:33:16.119Z] EXECUTOR_NUMBER   = '0'[2020-02-08T14:33:16.119Z] SHLVL = '0'[2020-02-08T14:33:16.119Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-08T14:33:16.119Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-02-08T14:33:16.119Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-08T14:33:16.119Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-02-08T14:33:16.119Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-02-08T14:33:16.119Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-08T14:33:16.119Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-02-08T14:33:16.119Z] QT_SELECT = 'qt5'[2020-02-08T14:33:16.119Z] LANG  = 'en_US.UTF-8'[2020-02-08T14:33:16.119Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-08T14:33:16.119Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-08T14:33:16.119Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-08T14:33:16.119Z] [2020-02-08T14:33:16.119Z] [2020-02-08T14:33:16.119Z] == Commencing Configuration:[2020-02-08T14:33:16.119Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-08T14:33:16.379Z] -- The C compiler identification is Clang 8.0.1[2020-02-08T14:33:16.379Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-08T14:33:16.379Z] -- Check for working C compiler: /usr/bin/cc[2020-02-08T14:33:16.379Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-08T14:33:16.379Z] -- Detecting C compiler ABI info[2020-02-08T14:33:16.639Z] -- Detecting C compiler ABI info - done[2020-02-08T14:33:16.639Z] -- Detecting C compile features[2020-02-08T14:33:16.639Z] -- Detecting C compile features - done[2020-02-08T14:33:16.639Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-08T14:33:16.639Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-08T14:33:16.639Z] -- Detecting CXX compiler ABI info[2020-02-08T14:33:16.639Z] -- Detecting CXX compiler ABI info - done[2020-02-08T14:33:16.639Z] -- Detecting CXX compile features[2020-02-08T14:33:16.639Z] -- Detecting CXX compile features - done[2020-02-08T14:33:16.639Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for PowerDevil.[2020-02-08T14:33:16.639Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-08T14:33:16.639Z] -- Looking for __GLIBC__[2020-02-08T14:33:16.639Z] -- Looking for __GLIBC__ - not found[2020-02-08T14:33:16.639Z] -- Performing Test _OFFT_IS_64BIT[2020-02-08T14:33:16.902Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-08T14:33:16.902Z] -- Performing Test HAVE_DATE_TIME[2020-02-08T14:33:16.902Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-08T14:33:17.162Z] -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.67.0") [2020-02-08T14:33:17.162Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.67.0") [2020-02-08T14:33:17.162Z] -- Found KF5IdleTime: /usr/home/jenkins/install-prefix/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.67.0") [2020-02-08T14:33:17.162Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.67.0") [2020-02-08T14:33:17.162Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.67.0") [2020-02-08T14:33:17.162Z] -- Found KF5Solid:

D27241: sddm-theme: Use non-deprecated KDEInstallDirs variable

2020-02-08 Thread Heiko Becker 
heikobecker created this revision.
heikobecker added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  Also drop the prefix and use the KDE_INSTALL_FULL.. variant for an
  absolute path (similar to logo=${KDE_INSTALL_FULL_DATADIR}...).

TEST PLAN
  Checked that the background image is installed in the same
  location as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27241

AFFECTED FILES
  sddm-theme/theme.conf.cmake

To: heikobecker, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27078: Drag-and-drop files at the right coordinates

2020-02-08 Thread Painless Roaster 
painlessroaster updated this revision to Diff 75238.
painlessroaster added a comment.


  fix  unnecessary/unintentional whitespace change

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27078?vs=74819=75238

REVISION DETAIL
  https://phabricator.kde.org/D27078

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: painlessroaster, hein, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27237: [Background Finder] Create a valid invocation token

2020-02-08 Thread Vlad Zahorodnii 
zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  According to Qt docs, QUuid() creates a null UUID object.

TEST PLAN
  N/A, plasmashell is very unstable with Qt 5.15.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  valid-background-finder-token

REVISION DETAIL
  https://phabricator.kde.org/D27237

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Visually, LGTM

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-08 Thread Noah Davis 
ndavis added a comment.


  Arc's cherry picking fails when this patch tries to cherry pick from my 
arcpatch-D27221 branch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  smallMedium-playback-toolbuttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27222

To: ngraham, #vdg, manueljlin
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-02-08 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9ae855e0dcbc: Kicker/RecentUsageModel: Allow to open 
smb:/ sftp:/ resources (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26582?vs=73275=75211

REVISION DETAIL
  https://phabricator.kde.org/D26582

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, broulik, aleksejshilin, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-02-08 Thread Méven Car 
meven added a comment.


  Let's be safe and targe 5.19

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26582

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-02-08 Thread Méven Car 
meven added a comment.


  5.18 or not ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26582

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart