KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 807 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/807/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 26 Mar 2020 05:25:58 +
 Build duration:
2 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 3829 lines...][2020-03-26T05:28:14.852Z] In file included from /usr/include/qt5/QtCore/QSet:1,[2020-03-26T05:28:14.852Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/spellchecking/spellchecking.cpp:27:[2020-03-26T05:28:14.852Z] /usr/include/qt5/QtCore/qset.h:61:12: note: candidate: ���QSet::QSet(std::initializer_list<_Tp>) [with T = QString]���[2020-03-26T05:28:14.852Z]61 | inline QSet(std::initializer_list list)[2020-03-26T05:28:14.852Z]   |^~~~[2020-03-26T05:28:14.852Z] /usr/include/qt5/QtCore/qset.h:61:12: note:   candidate expects 1 argument, 2 provided[2020-03-26T05:28:14.852Z] /usr/include/qt5/QtCore/qset.h:59:12: note: candidate: ���QSet::QSet() [with T = QString]���[2020-03-26T05:28:14.852Z]59 | inline QSet() Q_DECL_NOTHROW {}[2020-03-26T05:28:14.852Z]   |^~~~[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:59:12: note:   candidate expects 0 arguments, 2 provided[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: ���QSet::QSet(const QSet&)���[2020-03-26T05:28:14.853Z]54 | class QSet[2020-03-26T05:28:14.853Z]   |   ^~~~[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note:   candidate expects 1 argument, 2 provided[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: ���QSet::QSet(QSet&&)���[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note:   candidate expects 1 argument, 2 provided[2020-03-26T05:28:14.853Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/spellchecking/spellchecking.cpp:68:119: error: no matching function for call to ���QSet::QSet(QList::iterator, QList::iterator)���[2020-03-26T05:28:14.853Z]68 | QSet currentPreferredLanguages(currentPreferredLanguagesList.begin(), currentPreferredLanguagesList.end());[2020-03-26T05:28:14.853Z]   |   ^[2020-03-26T05:28:14.853Z] In file included from /usr/include/qt5/QtCore/QSet:1,[2020-03-26T05:28:14.853Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/spellchecking/spellchecking.cpp:27:[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:61:12: note: candidate: ���QSet::QSet(std::initializer_list<_Tp>) [with T = QString]���[2020-03-26T05:28:14.853Z]61 | inline QSet(std::initializer_list list)[2020-03-26T05:28:14.853Z]   |^~~~[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:61:12: note:   candidate expects 1 argument, 2 provided[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:59:12: note: candidate: ���QSet::QSet() [with T = QString]���[2020-03-26T05:28:14.853Z]59 | inline QSet() Q_DECL_NOTHROW {}[2020-03-26T05:28:14.853Z]   |^~~~[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:59:12: note:   candidate expects 0 arguments, 2 provided[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: ���QSet::QSet(const QSet&)���[2020-03-26T05:28:14.853Z]54 | class QSet[2020-03-26T05:28:14.853Z]   |   ^~~~[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note:   candidate expects 1 argument, 2 provided[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: ���QSet::QSet(QSet&&)���[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:54:7: note:   candidate expects 1 argument, 2 provided[2020-03-26T05:28:14.853Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/spellchecking/spellchecking.cpp:69:119: error: no matching function for call to ���QSet::QSet(QList::iterator, QList::iterator)���[2020-03-26T05:28:14.853Z]69 | QSet defaultPreferredLanguages(defaultPreferredLanguagesList.begin(), defaultPreferredLanguagesList.end());[2020-03-26T05:28:14.853Z]   |   ^[2020-03-26T05:28:14.853Z] In file included from /usr/include/qt5/QtCore/QSet:1,[2020-03-26T05:28:14.853Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/spellchecking/spellchecking.cpp:27:[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:61:12: note: candidate: ���QSet::QSet(std::initializer_list<_Tp>) [with T = QString]���[2020-03-26T05:28:14.853Z]61 | inline QSet(std::initializer_list list)[2020-03-26T05:28:14.853Z]   |^~~~[2020-03-26T05:28:14.853Z] /usr/include/qt5/QtCore/qset.h:61:12: note:   candidate expects 1 argument, 2 

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  I use a kdesrc-build environment. My process was this:
  
cd breeze
arc patch D27669
ninja -C "$( pwd | sed 's:/src/:/build/:' )" install  #I use this through a 
script named kdesrc-ninja and it works well
source ~/kde/.setup-env  #This makes the terminal session use the 
kdesrc-build environment
dolphin
  
  
  
  In D27669#634824 , 
@hpereiradacosta wrote:
  
  > F8199260: Screenshot_20200325_210812.png 

  
  
  That white combo box looks a little nasty against the dark gray background. I 
wonder if there's anything that can be done about it.

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D27669#634758 , @ngraham wrote:
  
  > So I'm still having an issue with the feature um, not working. :( I have it 
turned on in the Breeze settings but it behaves as if off; that is to say, I 
see no different appearance compared to the status quo.
  >
  > Is anyone else experiencing this, or just me?
  
  
  ... it certainly is working here. 
  F8199260: Screenshot_20200325_210812.png 

  
  So ... can't help you (not to say that there isn't any problem. just that it 
is not completely trivial to find)

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  In D27669#634758 , @ngraham wrote:
  
  > So I'm still having an issue with the feature um, not working. :( I have it 
turned on in the Breeze settings but it behaves as if off; that is to say, I 
see no different appearance compared to the status quo.
  >
  > Is anyone else experiencing this, or just me?
  
  
  It doesn't work for me either. I tested with Dolphin and Kate.

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 78510.
cblack added a comment.


  Fix errors

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=78188=78510

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp
  src/pendingvalue.cpp
  src/pendingvalue.h

To: cblack, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  So I'm still having an issue with the feature um, not working. :( I have it 
turned on in the Breeze settings but it behaves as if off; that is to say, I 
see no different appearance compared to the status quo.
  
  Is anyone else experiencing this, or just me?

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  All good, as far as I am concerned. Thanks !

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78505.
cblack added a comment.


  Address feedback

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78306=78505

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> globalshortcuts.cpp:42
>  editor = new KGlobalShortcutsEditor(this, 
> KShortcutsEditor::GlobalAction);
> -connect(editor, SIGNAL(changed(bool)), this, SIGNAL(changed(bool)));
> +connect(editor, ::changed, this, 
> QOverload::of(::changed));
>  

Use markAsChanged then you don't need to overload.

> kglobalshortcutseditor.h:84
>   */
> -void exportConfiguration(QStringList componentsFriendly, KConfig 
> *config) const;
> +void exportConfiguration(const QStringList componentsFriendly, KConfig 
> *config) const;
>  

why not const QStringList &

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  I'll look into creating a `KNotificationUiDelegate` or something along the 
lines

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  I finally got some time to look at the code. Some minor comments below 
(compiler warnings)
  Also there is a problem with menubar text color when option is disabled. Here 
at least it is still set to the decoration color, leading to invisible text 
with default breeze color scheme.
  See: 
  F8199046: Screenshot_20200325_155010.png 

  F8199048: Screenshot_20200325_155034.png 


INLINE COMMENTS

> breezehelper.cpp:50
> +_config( std::move( config ) ),
> +_decorationConfig( new InternalSettings() ),
> +_kwinConfig( KSharedConfig::openConfig("kwinrc") ),

compiler complains about wrong initialization order

> breezestyle.cpp:4935
> +
> +bool Style::drawMenuBarEmptyAreaControl( const QStyleOption* option, 
> QPainter* painter, const QWidget* widget ) const
> +{

same remark about option being unused

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau added a comment.


  In D28262#634715 , @broulik wrote:
  
  > > I can not find a kcfg file in this applet to simply extend
  >
  > In applets it's the `config.xml` you edited, so from a technical POV patch 
is good. Not sure this option is very useful, however.
  
  
  Ok for the technical POV, thanks. I very understand the usefulness question 
such option can raise, letting the community integrating it or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Kai Uwe Broulik]

broulik added a comment.


  > I can not find a kcfg file in this applet to simply extend
  
  In applets it's the `config.xml` you edited, so from a technical POV patch is 
good. Not sure this option is very useful, however.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau added a comment.


  Thanks Nathaniel for your feedbacks.
  
  About your technical comment, I can not find a kcfg file in this applet to 
simply extend. I will have a closer look to existing kcfg files and create one 
for analog clock (next weekend I guess)
  
  About the conceptual comment, you are right: clocks without minute hand are 
not common :)
  I have a real one since few years after minute hand gets broken and removed. 
I finally found the result very ergonomic: faster to read and accurate enough, 
less disturbing / "attractive" (no need to take a look at it every five 
minutes).
  This is more common when it comes to watches, under the name "slow watches" 
which features a single hand for a full-day 24-hour circle (mid-day on top and 
mid-night on bottom). Since I have no doubt about the morning or the evening, I 
find the halfway with a 12-hours circle still useful and use it daily.
  
  Maybe in the future I will make a proposal for a more real slow clock option 
(24-hours circle) if someone find it useful.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: ngraham, aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth added a comment.


  I see. Then i'll let $things happen. Thanks!

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: The-Feren-OS-Dev, cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Carson Black]

cblack added a comment.


  In D28281#634702 , @sgoth wrote:
  
  > Cool thanks!
  >
  > As this is my first contribution via phabricator, can you give me a short 
advice on how to proceed?
  >  Do i "arc land" it myself? To master?
  
  
  Since there's two pending reviews, you probably want to wait on them first.
  
  However, you need to have a developer account in order to land your patches, 
and you most likely don't have one yet considering that this is your first 
contribution. When someone's landing your patch for you'll, they'll ask for 
authorship information (name, email) if it's missing and then land it for you.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: The-Feren-OS-Dev, cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D28281#634702 , @sgoth wrote:
  
  > Cool thanks!
  >
  > As this is my first contribution via phabricator, can you give me a short 
advice on how to proceed?
  >  Do i "arc land" it myself? To master?
  
  
  IIRC you can only do that if you get an accepted application for becoming a 
"KDE Developer", otherwise you'll need a KDE Developer to land it for you, 
which will most likely happen anyway.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: The-Feren-OS-Dev, cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth added a comment.


  Cool thanks!
  
  As this is my first contribution via phabricator, can you give me a short 
advice on how to proceed?
  Do i "arc land" it myself? To master?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth updated this revision to Diff 78498.
sgoth added a comment.


  Refactor show functions to be members of VolumeOsd

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28281?vs=78495=78498

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth marked an inline comment as done.
sgoth added a comment.


  Ah, that seems a lot better yes, thanks.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex added a comment.


  In D28057#634650 , @ngraham wrote:
  
  > Abandoning the existing `iconSize` config value and adding a new one called 
`gridViewIconSize` means that everyone'e existing icon view size will be reset, 
since nothing will be reading from the `iconSize` values in the config files 
anymore. You have two options here:
  >
  > 1. Don't abandon `iconSize` for the icon view; keep using it even though 
its name isn't perfectly descriptive anymore
  > 2. Create a kconf update script to migrate people's config files so that 
the existing `iconSize` values get transformed into `gridViewIconSize` See 
https://techbase.kde.org/Development/Tools/Using_kconf_update
  
  
  Thank you for your review @ngraham ,
  
  I think there was some misunderstanding on my explanation: I am not 
abandoning iconSize. In fact, I am doing the opposite! I am making iconSize 
always the "true" value. What I am doing is saving the values of grid icon size 
and list icon size in different variables ( to save the slider configs ) and 
then applying the proper sizing to iconSize !
  
  So instead of " if Grid or List -> iconSize or listIconSize" ... I do "always 
iconSize, when changing modes/size update iconSize with proper size".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Carson Black]

cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  Code looks good, bar one minor issue—instead of using global showOsdX 
functions, it would be more idiomatic to declare these functions on the OSD 
object itself. Other than that, this looks good.

INLINE COMMENTS

> main.qml:179
>  
> +function showOsdVolume(text) {
> +if (!Plasmoid.configuration.volumeOsd)

These functions would probably be better declared on the OSD object like so:

  VolumeOSD {
  id: osd
  
  function showVolume(text) {
  if (!Plasmoid.configuration.volumeOsd)
  return
  show(text)
  }
  }

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth added a comment.


  Yeah, was unsure too if it's a good idea but now with your sanitized wording 
i'd prefer it that way :)
  But if i should go for a single OSD on/off i wouldn't mind either.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca
Cc: drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: drosca.
ngraham added a subscriber: drosca.
ngraham added a comment.
This revision is now accepted and ready to land.


  This looks great to me!
  
  I have to admit I was skeptical when I first saw the patch, but I think 
making the options very granular like this actually helps to explain just what 
they'll do, and also disambiguates the visual vs audible feedback settings too.
  
  #plasma  people and/or @drosca, are 
folks okay with this?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca
Cc: drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth added a comment.


  now with spacing
  
  F8198928: image.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth updated this revision to Diff 78495.
sgoth added a comment.


  Add spacing

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28281?vs=78494=78495

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth updated this revision to Diff 78494.
sgoth added a comment.


  Change wording

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28281?vs=78483=78494

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth added a comment.


  "default output"
  "Default  output"
  "Default output device" ?
  
  looks like this then:
  
  F8198919: image.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Nathaniel Graham]

ngraham added a comment.


  This works great!
  
  In terms of the UI, it feels like we need a bit more logical separation 
between the groups now. I would adjust things (in this same patch) to be like 
this:
  
 Play audio feedback for changes to: [x] Audio volume

Show visual feedback for changes to: [x] Audio volume
 [x] Microphone sensitivity
 [x] Mute state
 [x] default output
  
  You can add the spacing between groups with an item like this:
  
Item {
Kirigami.FormData.isSection: true
}

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Nathaniel Graham]

ngraham added a comment.


  Abandoning the existing `iconSize` config value and adding a new one called 
`gridViewIconSize` means that everyone'e existing icon view size will be reset, 
since nothing will be reading from the `iconSize` values in the config files 
anymore. You have two options here:
  
  1. Don't abandon `iconSize` for the icon view; keep using it even though its 
name isn't perfectly descriptive anymore
  2. Create a kconf update script to migrate people's config files so that the 
existing `iconSize` values get transformed into `gridViewIconSize` See 
https://techbase.kde.org/Development/Tools/Using_kconf_update

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  I am not so sure about the QPlatform integration bit, it looks easier/cleaner 
to just use KFontChooserDialog; QFontDialog isn't widely used in KDE code, so 
porting to KFontChooserDialog is doable (though that sounds like going back in 
time to using KFontDialog in KDE4, then porting to QFontDialog in KF5... now 
back to KFont* variant).
  
  For now I'll port the code here to KFontChooserDialog.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  In D28208#634593 , @davidre wrote:
  
  > Do you know if `IconThemePath` is specified somewhere?
  
  
  Initial commit:
  
https://github.com/KDE/kde-workspace/commit/4c553dbf39f4189290387bba35589200ca051084
  Someone mentioned this property here:
  https://lists.freedesktop.org/archives/xdg/2015-December/013620.html
  https://mail.kde.org/pipermail/plasma-devel/2015-December/047019.html
  But he tried to create new specification. What we need is to update existing 
one to reflect all the changes...
  
  > What I could observe is that some apps create a folder hierachy under this 
path and palce their icon there. I currently don't have any idea how to handle 
this in qml. Maybe we need to do this in the model / c++  side again?
  
  Currently it is implemented in `statusnotifieritemsource.cpp`, it 
reconfigures KIconLoder to use themePath as additional icon location. 
  The best would be to have a similar implementation in `PlasmaCore.IconItem`, 
but this is a lot to change. `IconItem` is using global instance only 
`KIconLoader::global()`, while `StatusNotifierItemSource` has custom one (when 
needed) and fallbacks to the global one 
(`StatusNotifierItemSource::iconLoader()`).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28218: FileChooser: add option to open file with or without write access

[Nathaniel Graham]

ngraham added a comment.


  Honestly that's what makes sense to me. I don't think the use case of "I 
trust this app enough to open it and show it my files, but not enough to let it 
modify my files" really exists. I think most normal users would just not use an 
app they don't trust, or not let it access their files at all, rather than 
letting it access their files for reading but not writing.
  
  I'm not a security expert though, so maybe the above is hopelessly naive and 
dangerous. :/

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28218

To: jgrulich, #plasma, #vdg
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  In D28208#634593 , @davidre wrote:
  
  > Do you know if `IconThemePath` is specified somewhere?
  
  
  Initial commit:
  
  What I could observe is that some apps create a folder hierachy under this 
path and palce their icon there. I currently don't have any idea how to handle 
this in qml. Maybe we need to do this in the model / c++  side again?
  
  > For example 
  >  `Arguments: [Variant(QString): 
"/tmp/.org.chromium.Chromium.3WvReV/icons"]` as IconThemepath 
  >  and inside is 
`/tmp/.org.chromium.Chromium.3WvReV/icons/hicolor/22x22/apps/chrome_app_indicator2_91c0c89ea21003eb35a74c9caa4718cc.png`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[Ahmad Samir]

ahmadsamir added a comment.


  I don't know when the CI will be updated, probably soon based on what I read 
on IRC #kde-devel, but until then isn't it better to keep the CI working for 
plasma-desktop? I could rework the patch to make it conditional on 5.14 and 
keep the iterator-based ctors as-is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> backend.cpp:178
> +auto *job = new KIO::ApplicationLauncherJob(service, 
> serviceAction);
> +// TODO uidelegate
> +job->start();

Only if you like messageboxes.

Plasma code might prefer something else? A notification maybe? I think we both 
know a guy who likes them very much ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth marked an inline comment as done.
sgoth added a comment.


  Oh.. good catch thanks :)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth updated this revision to Diff 78483.
sgoth added a comment.


  Fix typo

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28281?vs=78456=78483

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28289: Refactor of OverlaySheet

[Nathaniel Graham]

ngraham added a comment.


  FWIW this needs a rebase as there were apparently some changes to 
OverlaySheet on master since this was branched.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28289

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre added a comment.


  Do you know if `IconThemePath` is specified somewhere? What I could observe 
is that some apps create a folder hierachy under this path and palce their icon 
there. I currently don't have any idea how to handle this in qml. Maybe we need 
to do this in the model / c++  side again?
  For example 
  `Arguments: [Variant(QString): "/tmp/.org.chromium.Chromium.3WvReV/icons"]` 
as IconThemepath 
  and inside is 
`/tmp/.org.chromium.Chromium.3WvReV/icons/hicolor/22x22/apps/chrome_app_indicator2_91c0c89ea21003eb35a74c9caa4718cc.png`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:198
> +function showOsdMicMute(text) {
> +if (!Plasmoid.configuration.mutecOsd)
> +return

`mutecOsd`? :-)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28289: Refactor of OverlaySheet

[Marco Martin]

mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Rework OverlaySheet to remove some sizing hacks that made ListView and 
GridView
  not work well, fix some appearance issues with the new scrollbar, make it 
easier 
  to dismiss sheets via swipe.
  the internal flickabe is never interactive, flicking is only managed by an 
  external flickable that manages both normal flicking and dismissal swipe

REPOSITORY
  R169 Kirigami

BRANCH
  mart/overlaysheetrefactor

REVISION DETAIL
  https://phabricator.kde.org/D28289

AFFECTED FILES
  src/controls/OverlaySheet.qml
  src/controls/templates/OverlaySheet.qml
  src/icon.cpp

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 78481.
davidre marked an inline comment as done.
davidre added a comment.


  Also change it in the tooltip icon

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78479=78481

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 78479.
davidre marked an inline comment as done.
davidre added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78384=78479

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28275: skip over supposed network shares that aren't

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:4847c9e2fed2: skip over supposed network shares that 
arent (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28275?vs=78442=78472

REVISION DETAIL
  https://phabricator.kde.org/D28275

AFFECTED FILES
  Modules/samba/smbmountmodel.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28276: only add devices to the smb mount model that are network shares

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:23d52fa33394: only add devices to the smb mount model 
that are network shares (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28276?vs=78443=78473

REVISION DETAIL
  https://phabricator.kde.org/D28276

AFFECTED FILES
  Modules/samba/smbmountmodel.cpp

To: sitter, ngraham, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In the process, port jump list actions from custom `KDesktopFile` parsing to 
`KServiceAction` on `KService`, simplifying the code a lot.

TEST PLAN
  - I do need this UI delegate, right?
  
  - Launching incognito tabs in my browser still works
  - Opening Dolphin places still works
  - Opening recent docs still work and do open in the app the task manager 
entry is for rather than the default app for the mimetype

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

AFFECTED FILES
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28275: skip over supposed network shares that aren't

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops!

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb-type-check

REVISION DETAIL
  https://phabricator.kde.org/D28275

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham added a comment.


  Right, so my intention was to make it easy to add a new entry to the combobox 
titled "Metadata-only indexing".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  In D28280#634471 , @ngraham wrote:
  
  > Such a complicated setup is probably not going to be typical, I expect. But 
for that we could have an Advanced Settings sheet that allows people to 
customize things with great detail. However we probably don't have to worry too 
much about that for the purpose of this patch since those advanced features 
haven't been made available to the UI yet.
  
  
  
  
  In D28280#634471 , @ngraham wrote:
  
  > Such a complicated setup is probably not going to be typical, I expect. But 
for that we could have an Advanced Settings sheet that allows people to 
customize things with great detail. However we probably don't have to worry too 
much about that for the purpose of this patch since those advanced features 
haven't been made available to the UI yet.
  
  
  We already have 5 of the 7 options, only "Metadata" is new. Though, currently 
only as a global setting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28277: [UrlButton] Disable when there is no URL

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

To: broulik, mart, #vdg, #kirigami, ngraham
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham added a comment.


  Such a complicated setup is probably not going to be typical, I expect. But 
for that we could have an Advanced Settings sheet that allows people to 
customize things with great detail. However we probably don't have to worry too 
much about that for the purpose of this patch since those advanced features 
haven't been made available to the UI yet.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  In D28280#634405 , @ngraham wrote:
  
  > In D28280#634388 , @bruns wrote:
  >
  > > Try do imagine how the combobox will look like when you add 'Index 
hidden' to the config options.
  >
  >
  > That would be fine. Comboboxes handle many options pretty well.
  
  
  I am more concerned how a user will handle it:
  
  [Disabled ; Filenames+Tags+Comments ; Metadata(Authors,EXIF,etc) ; FullText] 
x [NotHidden ; All] -> 8 options
  
  > In D28280#634390 , @bruns wrote:
  > 
  >> For the "Add folder setting...":
  >>  How about a config dialog **after** the File Dialog?
  >>
  >> This may seem over the top for now, but the next step is to make the 
excludeFilters and mimetype filters configurale from the KCM, and then also per 
folder.
  > 
  > 
  > Oh, that's interesting! Sounds cool. We can probably add that 
post-file-selection dialog for the indexing settings that require it, but since 
not all will, I'm not sure it should be added for all of them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28277: [UrlButton] Disable when there is no URL

[Kai Uwe Broulik]

broulik updated this revision to Diff 78460.
broulik retitled this revision from "[UrlButton] Don't show tooltip if it would 
be empty" to "[UrlButton] Disable when there is no URL".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Disable completely

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28277?vs=78448=78460

REVISION DETAIL
  https://phabricator.kde.org/D28277

AFFECTED FILES
  src/controls/UrlButton.qml

To: broulik, mart, #vdg, #kirigami
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham added a comment.


  In D28280#634388 , @bruns wrote:
  
  > Try do imagine how the combobox will look like when you add 'Index hidden' 
to the config options.
  
  
  That would be fine. Comboboxes handle many options pretty well.
  
  In D28280#634390 , @bruns wrote:
  
  > For the "Add folder setting...":
  >  How about a config dialog **after** the File Dialog?
  >
  > This may seem over the top for now, but the next step is to make the 
excludeFilters and mimetype filters configurale from the KCM, and then also per 
folder.
  
  
  Oh, that's interesting! Sounds cool. We can probably add that 
post-file-selection dialog for the indexing settings that require it, but since 
not all will, I'm not sure it should be added for all of them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  For the "Add folder setting...":
  How about a config dialog **after** the File Dialog?
  
  This may seem over the top for now, but the next step is to make the 
excludeFilters and mimetype filters configurabe from the KCM, and then also per 
folder.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  Try do imagine how the combobox will look like when you add 'Index hidden' to 
the config options.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth added a comment.


  F8198388: image.png 
  
  Not sure about the actual wording and whether we would want all 3 of them.
  Probably would use "input volume", "output volume" but i tried to match the 
existing "aural feedback" string.
  
  Also i actually tried to implement the various qml functions a single one 
taking a QML enum but failed to do so. If that or a string based version is 
preferred, just tell me (how :) ).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Méven Car]

meven created this revision.
meven added reviewers: ervin, bport, crossi, hchain, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  Builds, changed a shortcut and back again

REPOSITORY
  R119 Plasma Desktop

BRANCH
  shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28277: [UrlButton] Don't show tooltip if it would be empty

[Aleix Pol Gonzalez]

apol added a comment.


  disabling as suggested would make sense, thanks for looking into this!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

To: broulik, mart, #vdg, #kirigami
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D28281: Add options for OSD feedback

[Sebastian Goth]

sgoth created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sgoth requested review of this revision.

REVISION SUMMARY
  Extend configuration knobs for visual feedback by adding separate ones
  for output volume, input volume and mute state.
  
  BUG: 363983

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sgoth
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Nathaniel Graham]

ngraham added a comment.


  UI refinement is here: D28280 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28025

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham updated this revision to Diff 78455.
ngraham added a comment.


  use `onActivated:` rather than `onCurrentIndexChanged:` for the combobox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28280?vs=78454=78455

BRANCH
  refine-baloo-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28280

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #baloo, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Baloo, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch refines the UI added in D28025 
. The basic goal here is to to be able to 
choose
  what type of indexing is done for each path (none, full, or metadata only). I 
wrestled
  for a while with the best way to present this information and also allow it 
to be easily
  changed and eventually settled on a combobox, given that it combines both 
functions into
  one compact control.
  
  The code is made flexible so that once metadata-only indexing is added in the 
future, it
  will be easy to add the appropriate option into the UI.

TEST PLAN
  F8198344: vokoscreenNG-2020-03-25_08-28-23.webm 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  refine-baloo-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28280

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #baloo, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28218: FileChooser: add option to open file with or without write access

[Jan Grulich]

jgrulich added a comment.


  If there are objections to this change, we can just make all the opened files 
automatically writable.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28218

To: jgrulich, #plasma, #vdg
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Méven Car]

meven added a comment.


  With D28122  I think you can go ahead and 
port this code to it.
  Unless you want to take care of the QPlatform integration for it first.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28277: [UrlButton] Don't show tooltip if it would be empty

[Nathaniel Graham]

ngraham added reviewers: VDG, Kirigami.
ngraham added a comment.


  If `button.url` is undefined, then the whole thing won't work in the first 
place. Maybe instead the control could disable itself automatically, or change 
its color to red to indicate a broken link?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

To: broulik, mart, #vdg, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28272: Avoid copying buffer twice

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R838:f6e559702cf5: Avoid copying buffer twice (authored by 
jgrulich).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28272?vs=78437=78450

REVISION DETAIL
  https://phabricator.kde.org/D28272

AFFECTED FILES
  src/screencaststream.cpp
  src/screencaststream.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: jgrulich, #plasma, zzag
Cc: meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28272: Avoid copying buffer twice

[Méven Car]

meven added a comment.


  Seems good to me

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28272

To: jgrulich, #plasma
Cc: meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28272: Avoid copying buffer twice

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> screencaststream.cpp:549-563
> +// bind framebuffer to copy pixels from
> +GLuint framebuffer;
> +glGenFramebuffers(1, );
> +glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
> +glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, 
> GL_TEXTURE_2D, texture, 0);
> +const GLenum status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
> +if (status != GL_FRAMEBUFFER_COMPLETE) {

Do we actually need an fbo?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28272

To: jgrulich, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28277: [UrlButton] Don't show tooltip if it would be empty

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  F8198260: Screenshot_20200325_141929.png 

  None of these links do anything when installing packages but at least the 
tooltip now doesn't erroneously show anymore

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28277

AFFECTED FILES
  src/controls/UrlButton.qml

To: broulik, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28232: [SpellChecking KCM] Fix the build

[Benjamin Port]

bport added a comment.


  https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series
  So we need to see if we can update the CI

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28234: Use SyntaxHighlighter for highlighting

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:f304e0185fb8: Use SyntaxHighlighter for highlighting 
(authored by apol).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28234?vs=78354=78446

REVISION DETAIL
  https://phabricator.kde.org/D28234

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/backtracewidget.cpp
  src/backtracewidget.h
  src/gdbhighlighter.cpp
  src/gdbhighlighter.h

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[Ahmad Samir]

ahmadsamir added a comment.


  In D28232#634281 , @bport wrote:
  
  > Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem 
to depend on it
  
  
  But the CI still uses 5.12 for the opensuse image, and probably 5.13 for the 
freebsd AFAIK.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[Benjamin Port]

bport added a comment.


  Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to 
depend on it

INLINE COMMENTS

> CMakeLists.txt:9
>  set(QT_MIN_VERSION "5.12.0")
> -set(KF5_MIN_VERSION "5.66.0")
>  

Indeed this is needed thanks

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28232

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28234: Use SyntaxHighlighter for highlighting

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I love it!

INLINE COMMENTS

> backtracewidget.cpp:230
> +m_highlighter = new 
> KSyntaxHighlighting::SyntaxHighlighter(ui.m_backtraceEdit->document());
> +
> m_highlighter->setTheme((palette().color(QPalette::Base).lightness() < 128)
> + ? 
> repository.defaultTheme(KSyntaxHighlighting::Repository::DarkTheme)

Ugh that's awkward.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28234

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28276: only add devices to the smb mount model that are network shares

[Harald Sitter]

sitter added a comment.


  In D28276#634264 , @broulik wrote:
  
  > This is because the device monitor emits all devices, not the query 
returning unwanted devices?
  
  
  Yep
  
connect(Solid::DeviceNotifier::instance(), 
::DeviceNotifier::deviceAdded,
this, ::addDevice);

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb-type-check2

REVISION DETAIL
  https://phabricator.kde.org/D28276

To: sitter, ngraham, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28276: only add devices to the smb mount model that are network shares

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  This is because the device monitor emits all devices, not the query returning 
unwanted devices?

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb-type-check2

REVISION DETAIL
  https://phabricator.kde.org/D28276

To: sitter, ngraham, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28276: only add devices to the smb mount model that are network shares

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously we'd add all devices which would then cause a crash when
  trying to access them ->as() because they aren't

TEST PLAN
  have kcm open, plug in usb stick, observe no crash

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb-type-check2

REVISION DETAIL
  https://phabricator.kde.org/D28276

AFFECTED FILES
  Modules/samba/smbmountmodel.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28275: skip over supposed network shares that aren't

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  we explicitly request listFromType(Solid::DeviceInterface::NetworkShare)
  but apparently still can get devices that aren't actually of that type.
  add an explicit type check to guard against bogus shares coming out of
  listFromType.
  
  CCBUG: 419220

TEST PLAN
  mount an overlay (I am guessing that's what the problem with kubuntu is), 
observe no crash on init

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb-type-check

REVISION DETAIL
  https://phabricator.kde.org/D28275

AFFECTED FILES
  Modules/samba/smbmountmodel.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 806 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/806/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 25 Mar 2020 09:44:02 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 3801 lines...][2020-03-25T09:54:38.607Z]   170 | KDELIBS4SUPPORT_DEPRECATED explicit KDialog(QWidget *parent = nullptr, Qt::WindowFlags flags = {});[2020-03-25T09:54:38.607Z]   | ^~~[2020-03-25T09:54:38.607Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/hardware/joystick/caldialog.cpp:46:10: warning: ���KVBox��� is deprecated [-Wdeprecated-declarations][2020-03-25T09:54:38.607Z]46 |   KVBox *main = new KVBox( this );[2020-03-25T09:54:38.607Z]   |  ^~~~[2020-03-25T09:54:38.607Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/hardware/joystick/caldialog.cpp:32:[2020-03-25T09:54:38.607Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kvbox.h:36:41: note: declared here[2020-03-25T09:54:38.607Z]36 | class KDELIBS4SUPPORT_DEPRECATED_EXPORT KVBox : public KHBox[2020-03-25T09:54:38.607Z]   | ^[2020-03-25T09:54:38.607Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/hardware/joystick/caldialog.cpp:46:21: warning: ���KVBox��� is deprecated [-Wdeprecated-declarations][2020-03-25T09:54:38.607Z]46 |   KVBox *main = new KVBox( this );[2020-03-25T09:54:38.607Z]   | ^[2020-03-25T09:54:38.607Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/hardware/joystick/caldialog.cpp:32:[2020-03-25T09:54:38.607Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kvbox.h:36:41: note: declared here[2020-03-25T09:54:38.607Z]36 | class KDELIBS4SUPPORT_DEPRECATED_EXPORT KVBox : public KHBox[2020-03-25T09:54:38.607Z]   | ^[2020-03-25T09:54:38.607Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/hardware/joystick/caldialog.cpp:46:33: warning: ���KVBox::KVBox(QWidget*)��� is deprecated [-Wdeprecated-declarations][2020-03-25T09:54:38.607Z]46 |   KVBox *main = new KVBox( this );[2020-03-25T09:54:38.607Z]   | ^[2020-03-25T09:54:38.607Z] In file included from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/hardware/joystick/caldialog.cpp:32:[2020-03-25T09:54:38.607Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kvbox.h:46:41: note: declared here[2020-03-25T09:54:38.607Z]46 | KDELIBS4SUPPORT_DEPRECATED explicit KVBox(QWidget *parent = nullptr);[2020-03-25T09:54:38.607Z]   | ^[2020-03-25T09:54:38.607Z] [ 62%] Linking CXX shared module ../../bin/kcm_notifications.so[2020-03-25T09:54:39.170Z] [ 62%] Linking CXX shared module ../../../bin/kcm_joystick.so[2020-03-25T09:54:39.170Z] [ 62%] Built target kcm_notifications[2020-03-25T09:54:39.733Z] [ 62%] Built target kcm_joystick[2020-03-25T09:54:39.733Z] [ 62%] Building CXX object kcms/qtquicksettings/CMakeFiles/kcm_qtquicksettings.dir/renderersettings.cpp.o[2020-03-25T09:54:40.297Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp: In member function ���void KCMLookandFeel::setWidgetStyle(const QString&)���:[2020-03-25T09:54:40.297Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:414:70: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2020-03-25T09:54:40.297Z]   414 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2020-03-25T09:54:40.297Z]   |  ^[2020-03-25T09:54:40.297Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobalSettings:1,[2020-03-25T09:54:40.297Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:28:[2020-03-25T09:54:40.297Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:44: note: declared here[2020-03-25T09:54:40.298Z]   560 | static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2020-03-25T09:54:40.298Z]   |^~[2020-03-25T09:54:40.298Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/lookandfeel/kcm.cpp:414:70: warning: ���static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)��� is deprecated [-Wdeprecated-declarations][2020-03-25T09:54:40.298Z]   414 | KGlobalSettings::self()->emitChange(KGlobalSettings::StyleChanged);[2020-03-25T09:54:40.298Z]   | 

D28272: Avoid copying buffer twice

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  Previously we copied frames first to a temporary QImage and then to PipeWire 
buffer. This shouldn't be
  necessary as we can copy frames directly to PipeWire buffers which should be 
much more effecient.
  
  BUG: 419209

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  screensharing-improvements

REVISION DETAIL
  https://phabricator.kde.org/D28272

AFFECTED FILES
  src/screencaststream.cpp
  src/screencaststream.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 25 Mar 2020 09:44:02 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28270: [Colors KCM] Also save colors when active scheme was edited

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d0f673d0e92b: [Colors KCM] Also save colors when active 
scheme was edited (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28270?vs=78431=78436#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28270?vs=78431=78436

REVISION DETAIL
  https://phabricator.kde.org/D28270

AFFECTED FILES
  kcms/colors/colors.cpp

To: broulik, #plasma, meven
Cc: crossi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28270: [Colors KCM] Also save colors when active scheme was edited

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I fixed the case that the "Apply" button wasn't enabled when the selected 
scheme didn't change but was edited, but didn't actually have it save in this 
case...
  
  CCBUG: 419168

TEST PLAN
  5.18
  
  - Changing color schemes still works
  - Changed color scheme, applied it, edited it, applied again and my changes 
were reflected

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28270

AFFECTED FILES
  kcms/colors/colors.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27971: Solid-device-automounter/kcm: correctly update automountOn

[Méven Car]

meven added a comment.


  ping @ervin should be good now

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27971

To: meven, bport, #plasma, ervin, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

alex added a comment.


  Friendly Ping :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27513

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart