D28693: Replace old notification when new notification for connection appears

[Kai Uwe Broulik]

broulik added a comment.


  +1 I've been wanting to do exactly this forever

INLINE COMMENTS

> notification.cpp:431
> +
> +if (m_notifications.contains(connectionId)) {
> +notify = m_notifications[connectionId];

Avoid double look-up. `QHash` gives you a null value when not existing, so you 
can do:

  KNotification *notify = m_notifications.value(connectionId);
  if (!notify) {
  notify = new KNotification(...);
  ...
  m_notifications.insert(connectionId, notify);
  }

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  reuse

REVISION DETAIL
  https://phabricator.kde.org/D28693

To: nicolasfella, #plasma, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26185: Also disable automatic scaling on Qt >= 5.14

[Fabian Vogt]

fvogt added a comment.


  That sounds like a Qt bug, which fails to use the `QT_SCREEN_SCALE_FACTORS` 
value for pixmaps for some reason. Is it a multi-monitor setup? Can you open a 
new issue with details and a screenshot?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson, fvogt
Cc: powersnail, acooligan, fvogt, asturmlechner, dfaure, davidedmundson, 
anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

guide to build plasma mobile for pinephone

[Surendra Kumar]

Hi,

I would like to support in plasma development.

Can someone point to the build scripts that help in building the plasma
mobile for pinephone from source ?

Thanks in advance

regards
Suren

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/14/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 09 Apr 2020 04:38:50 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 312 lines...][2020-04-09T05:03:21.348Z] [2020-04-09T05:03:21.348Z]  * Screencast portal, Support for screen sharing[2020-04-09T05:03:21.348Z] [2020-04-09T05:03:21.348Z] -- The following OPTIONAL packages have not been found:[2020-04-09T05:03:21.348Z] [2020-04-09T05:03:21.348Z]  * PipeWire, PipeWire - multimedia processing, [2020-04-09T05:03:21.348Z]Required for screencast portal[2020-04-09T05:03:21.348Z] [2020-04-09T05:03:21.348Z] -- Configuring done[2020-04-09T05:03:21.348Z] -- Generating done[2020-04-09T05:03:21.348Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-04-09T05:03:22.167Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project xdg-desktop-portal-kde --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --usingInstall /home/jenkins/install-prefix/[2020-04-09T05:03:22.167Z] Scanning dependencies of target xdg-desktop-portal-kde_autogen[2020-04-09T05:03:22.167Z] [  3%] Automatic MOC for target xdg-desktop-portal-kde[2020-04-09T05:03:23.563Z] [  3%] Built target xdg-desktop-portal-kde_autogen[2020-04-09T05:03:23.563Z] [  6%] Generating ui_screenshotdialog.h[2020-04-09T05:03:23.563Z] [ 10%] Generating user_interface.cpp, user_interface.h[2020-04-09T05:03:23.563Z] [ 13%] Generating ui_appchooserdialog.h[2020-04-09T05:03:23.563Z] [ 16%] Generating ui_accessdialog.h[2020-04-09T05:03:23.563Z] [ 20%] Generating ui_userinfodialog.h[2020-04-09T05:03:23.563Z] [ 23%] Generating user_interface.moc[2020-04-09T05:03:23.563Z] Scanning dependencies of target xdg-desktop-portal-kde[2020-04-09T05:03:23.563Z] [ 26%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/access.cpp.o[2020-04-09T05:03:23.563Z] [ 30%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/account.cpp.o[2020-04-09T05:03:23.563Z] [ 33%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/xdg-desktop-portal-kde.cpp.o[2020-04-09T05:03:23.563Z] [ 36%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/xdg-desktop-portal-kde_autogen/mocs_compilation.cpp.o[2020-04-09T05:03:23.563Z] [ 40%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/background.cpp.o[2020-04-09T05:03:23.563Z] [ 43%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/accessdialog.cpp.o[2020-04-09T05:03:23.563Z] [ 46%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/appchooser.cpp.o[2020-04-09T05:03:23.563Z] [ 50%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/desktopportal.cpp.o[2020-04-09T05:03:23.563Z] [ 56%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/filechooser.cpp.o[2020-04-09T05:03:23.563Z] [ 53%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/appchooserdialog.cpp.o[2020-04-09T05:03:23.563Z] [ 60%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/email.cpp.o[2020-04-09T05:03:23.563Z] [ 63%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/inhibit.cpp.o[2020-04-09T05:03:24.965Z] [ 66%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/notification.cpp.o[2020-04-09T05:03:24.965Z] [ 70%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/print.cpp.o[2020-04-09T05:03:24.965Z] /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/src/access.cpp:45:40: warning: unused parameter 'results' [-Wunused-parameter][2020-04-09T05:03:24.965Z]   QVariantMap &results)[2020-04-09T05:03:24.965Z]^[2020-04-09T05:03:24.965Z] [ 73%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/request.cpp.o[2020-04-09T05:03:24.965Z] [ 76%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/session.cpp.o[2020-04-09T05:03:24.965Z] 1 warning generated.[2020-04-09T05:03:25.239Z] [ 80%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/screenshot.cpp.o[2020-04-09T05:03:25.239Z] [ 83%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/screenshotdialog.cpp.o[2020-04-09T05:03:25.239Z] [ 86%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/settings.cpp.o[2020-04-09T05:03:25.239Z] [ 90%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/utils.cpp.o[2020-04-09T05:03:25.239Z] [ 93%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/userinfodialog.cpp.o[2020-04-09T05:03:25.525Z] [ 96%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/user_interface.cpp.o[2020-04-09T05:03:26.505Z] /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/src/print.cpp:256:32

D28692: Don't leak DrKonqi dialog / fix crash on wayland

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> main.cpp:67
>  void openDrKonqiDialog () {
>  DrKonqiDialog *w = new DrKonqiDialog();
> +QObject::connect(qApp, &QCoreApplication::aboutToQuit, w, 
> &QObject::deleteLater);

Adding a qApp as a parent here?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28692

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28688: Document Kirigami::Icon

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> nicolasfella wrote in icon.h:69
> Maybe mention that it's read-only. Do we have some standard way of doing that?

It's mentioned by Doxygen

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28688

To: cblack, #kirigami
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D26185: Also disable automatic scaling on Qt >= 5.14

[Han Jin]

powersnail added a comment.


  Setting QT_AUTO_SCREEN_SCALE_FACTOR to 0 seems to affect the scaling of 
pixmaps.
  
  For example, designer-qt5 has extra small icons in the toolbar area.
  
  If I run designer-qt5 in commandline while unsetting 
QT_AUTO_SCREEN_SCALE_FACTOR, the icons are of the right size. (`env 
QT_AUTO_SCREEN_SCALE_FACTOR= designer-qt5`)
  
  Should this be opened as a new issue?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson, fvogt
Cc: powersnail, acooligan, fvogt, asturmlechner, dfaure, davidedmundson, 
anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28693: Replace old notification when new notification for connection appears

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When a second notification appears shortly after another, e.g. a wifi network 
disconnects and then reconnects, replace the first notification with the second 
one. This avoids having a disconnected and a connected notification 
simultaneously.

TEST PLAN
  dis- and reconnected my wifi

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  reuse

REVISION DETAIL
  https://phabricator.kde.org/D28693

AFFECTED FILES
  kded/notification.cpp

To: nicolasfella, #plasma, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28691: [kded] Clean up notification handling

[Nicolas Fella]

nicolasfella updated this revision to Diff 79676.
nicolasfella edited the summary of this revision.
nicolasfella added a comment.


  - Fix

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28691?vs=79673&id=79676

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D28691

AFFECTED FILES
  kded/notification.cpp

To: nicolasfella, jgrulich, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28692: Don't leak DrKonqi dialog / fix crash on wayland

[David Edmundson]

davidedmundson added a comment.


  Thread 1 "drkonqi" hit Breakpoint 1, 0x7f0664dd8570 in 
QtWaylandClient::QWaylandDisplay::handleWindowDeactivated(QtWaylandClient::QWaylandWindow*)@plt
 ()
  
from /opt/qt5/plugins/wayland-shell-integration/libxdg-shell.so
  
  (gdb) bt
  #0  0x7f0664dd8570 in 
QtWaylandClient::QWaylandDisplay::handleWindowDeactivated(QtWaylandClient::QWaylandWindow*)@plt
 ()
  
from /opt/qt5/plugins/wayland-shell-integration/libxdg-shell.so
  
  #1  0x7f0664dd9616 in 
QtWaylandClient::QWaylandXdgSurface::Toplevel::~Toplevel (this=0x55a21b293150, 
__in_chrg=)
  
at 
/home/david/projects/qt5/qtwayland/src/plugins/shellintegration/xdg-shell/qwaylandxdgshell.cpp:72
  
  #2  0x7f0664dd9696 in 
QtWaylandClient::QWaylandXdgSurface::Toplevel::~Toplevel (this=0x55a21b293150, 
__in_chrg=)
  
at 
/home/david/projects/qt5/qtwayland/src/plugins/shellintegration/xdg-shell/qwaylandxdgshell.cpp:81
  
  #3  0x7f0664dda57b in 
QtWaylandClient::QWaylandXdgSurface::~QWaylandXdgSurface (this=0x55a21b235190, 
__in_chrg=)
  
at 
/home/david/projects/qt5/qtwayland/src/plugins/shellintegration/xdg-shell/qwaylandxdgshell.cpp:262
  
  #4  0x7f0664dda61c in 
QtWaylandClient::QWaylandXdgSurface::~QWaylandXdgSurface (this=0x55a21b235190, 
__in_chrg=)
  
at 
/home/david/projects/qt5/qtwayland/src/plugins/shellintegration/xdg-shell/qwaylandxdgshell.cpp:270
  
  #5  0x7f066997f261 in QtWaylandClient::QWaylandWindow::reset 
(this=0x55a21b2920a0, sendDestroyEvent=false) at 
/home/david/projects/qt5/qtwayland/src/client/qwaylandwindow.cpp:243
  #6  0x7f066997e3d6 in QtWaylandClient::QWaylandWindow::~QWaylandWindow 
(this=0x55a21b2920a0, __in_chrg=)
  
at /home/david/projects/qt5/qtwayland/src/client/qwaylandwindow.cpp:94
  
  #7  0x7f066582325b in 
QtWaylandClient::QWaylandEglWindow::~QWaylandEglWindow (this=0x55a21b2920a0, 
__in_chrg=)
  
at 
/home/david/projects/qt5/qtwayland/src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.cpp:73
  
  #8  0x7f0665823284 in 
QtWaylandClient::QWaylandEglWindow::~QWaylandEglWindow (this=0x55a21b2920a0, 
__in_chrg=)
  
at 
/home/david/projects/qt5/qtwayland/src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.cpp:84
  
  #9  0x7f066e1199e0 in QWindowPrivate::destroy (this=0x55a21b1a8790) at 
/home/david/projects/qt5/qtbase/src/gui/kernel/qwindow.cpp:2000
  #10 0x7f066e11979a in QWindow::destroy (this=0x55a21b23ed00) at 
/home/david/projects/qt5/qtbase/src/gui/kernel/qwindow.cpp:1949
  #11 0x7f066f395166 in QWidgetPrivate::deleteTLSysExtra 
(this=0x55a21b1a9b40) at 
/home/david/projects/qt5/qtbase/src/widgets/kernel/qwidget.cpp:1697
  #12 0x7f066f3b1c1d in QWidget::destroy (this=0x55a21b0d4a30, 
destroyWindow=true, destroySubWindows=true) at 
/home/david/projects/qt5/qtbase/src/widgets/kernel/qwidget.cpp:12148
  #13 0x7f066f35399e in QApplication::~QApplication (this=0x7fff1c38d830, 
__in_chrg=) at 
/home/david/projects/qt5/qtbase/src/widgets/kernel/qapplication.cpp:730
  #14 0x55a2197f3a22 in main (argc=11, argv=0x7fff1c38d9b8) at 
/home/david/projects/kde5/src/kde/workspace/drkonqi/src/main.cpp:228

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28692

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28692: Don't leak DrKonqi dialog / fix crash on wayland

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  When a QApplication is in it's destructor it calls window->destroy()
  on all remaining QWindows. This deletes the platform window, whilst
  keeping the real object alive. QtWayland doesn't like this.
  
  Deleting the dialog fixes the issue. The deleteLater is fine because
  QCoreApplication teardown is magic.

TEST PLAN
  crashTest

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28692

AFFECTED FILES
  src/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28691: [kded] Clean up notification handling

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D28691

AFFECTED FILES
  kded/notification.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28690: Add unit tests for PagePool/PagePoolAction

[Mason McParlane]

masonm created this revision.
masonm added reviewers: Kirigami, mart.
masonm added a project: Kirigami.
masonm requested review of this revision.

REVISION SUMMARY
  In addition to the new unit tests a fix has been added for
  initialProperties being ignored when they are already
  specified in the QML Component file.

TEST PLAN
  See the tst_pagepool unit test included.

REPOSITORY
  R169 Kirigami

BRANCH
  pagepool-unit-tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28690

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/pagepool/TestPage.qml
  autotests/pagepool/tst_pagepool.qml
  src/controls/PagePoolAction.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: plasma-devel, mart, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28688: Document Kirigami::Icon

[Nicolas Fella]

nicolasfella added a comment.


  +1
  documentation improvements are always very welcome

INLINE COMMENTS

> icon.h:37
> + * @include icon/FilesystemSource.qml
> + * * The Internet:
> + * @include icon/InternetSource.qml

Maybe instead of internet something like "a remote url" since it may be from 
the local network as well

> icon.h:69
> +/**
> + * The `implicitWidth` of this item, derived from the `source` image.
> + */

Maybe mention that it's read-only. Do we have some standard way of doing that?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28688

To: cblack, #kirigami
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D28688: Document Kirigami::Icon

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  There are now documentation comments for Kirigami::Icon.

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/document-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28688

AFFECTED FILES
  Mainpage.dox
  src/doc/icon/CustomSource.qml
  src/doc/icon/Fallback.qml
  src/doc/icon/FilesystemSource.qml
  src/doc/icon/IconThemeSource.qml
  src/doc/icon/InternetSource.qml
  src/doc/icon/ResourceSource.qml
  src/icon.h
  src/img/icon/active.png
  src/img/icon/selected.png

To: cblack, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28685: Use ListSectionHeader in ListView example

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:ae736f9febcd: Use ListSectionHeader in ListView example 
(authored by nicolasfella).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28685?vs=79661&id=79668

REVISION DETAIL
  https://phabricator.kde.org/D28685

AFFECTED FILES
  src/data/contents/ui/gallery/ListViewGallery.qml

To: nicolasfella, #kirigami, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge updated this revision to Diff 79665.
jjorge added a comment.


  - A better cast to float

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28127?vs=79655&id=79665

BRANCH
  acpi-energy

REVISION DETAIL
  https://phabricator.kde.org/D28127

AFFECTED FILES
  ksysguardd/Linux/acpi.c
  ksysguardd/Linux/acpi.h

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wording

REVISION DETAIL
  https://phabricator.kde.org/D28686

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/logic.js

To: shubham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28685: Use ListSectionHeader in ListView example

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice!

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  sectionheader

REVISION DETAIL
  https://phabricator.kde.org/D28685

To: nicolasfella, #kirigami, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28685: Use ListSectionHeader in ListView example

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Kirigami.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  sectionheader

REVISION DETAIL
  https://phabricator.kde.org/D28685

AFFECTED FILES
  src/data/contents/ui/gallery/ListViewGallery.qml

To: nicolasfella, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart

D28684: Kate Runner: Implement drag and drop for sessions

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, Kate, cullmann, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  You can now drag the sessions from the runner to the taskbar or the desktop.

TEST PLAN
  Create sessions in kate, start KRunner and search for kate.
  You should be able to attach the session to the taskbar and desktop using 
drag and drop.

REPOSITORY
  R114 Plasma Addons

BRANCH
  kate_runner_mimetype (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28684

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, #plasma, #kate, cullmann, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28683: Get rid of workaround that prevents file dialog from being blocked

[Alexander Volkov]

volkov added a comment.


  DialogIsQtWindow was introduced in 
https://codereview.qt-project.org/c/qt/qtbase/+/144710

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D28683

To: volkov, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28683: Get rid of workaround that prevents file dialog from being blocked

[Alexander Volkov]

volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Invisible proxy QDialog blocks input when the native dialog is shown,
  and the workaround is to show the native file dialog with a delay.
  But it's not needed since Qt 5.13 after the
  QPlatformDialogHelper::DialogIsQtWindow hint was introduced.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28683

AFFECTED FILES
  autotests/kfiledialog_unittest.cpp
  autotests/kfiledialogqml_unittest.cpp
  src/platformtheme/kdeplatformfiledialogbase.cpp
  src/platformtheme/kdeplatformfiledialogbase_p.h
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h

To: volkov
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge updated this revision to Diff 79655.
jjorge added a comment.


  I should learn to better use arc...
  
  - typo

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28127?vs=79653&id=79655

BRANCH
  acpi-energy

REVISION DETAIL
  https://phabricator.kde.org/D28127

AFFECTED FILES
  ksysguardd/Linux/acpi.c
  ksysguardd/Linux/acpi.h

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge updated this revision to Diff 79653.
jjorge added a comment.


  - Oops fix bad named functions

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28127?vs=79629&id=79653

BRANCH
  acpi-energy

REVISION DETAIL
  https://phabricator.kde.org/D28127

AFFECTED FILES
  ksysguardd/Linux/acpi.c
  ksysguardd/Linux/acpi.h

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/13/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 08 Apr 2020 16:31:11 +
 Build duration:
52 sec and counting
   CONSOLE OUTPUT
  [...truncated 310 lines...][2020-04-08T16:31:49.771Z] [2020-04-08T16:31:49.771Z]  * Screencast portal, Support for screen sharing[2020-04-08T16:31:49.771Z] [2020-04-08T16:31:49.771Z] -- The following OPTIONAL packages have not been found:[2020-04-08T16:31:49.771Z] [2020-04-08T16:31:49.771Z]  * PipeWire, PipeWire - multimedia processing, [2020-04-08T16:31:49.771Z]Required for screencast portal[2020-04-08T16:31:49.771Z] [2020-04-08T16:31:49.771Z] -- Configuring done[2020-04-08T16:31:49.771Z] -- Generating done[2020-04-08T16:31:49.771Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-04-08T16:31:50.520Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project xdg-desktop-portal-kde --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --usingInstall /home/jenkins/install-prefix/[2020-04-08T16:31:50.520Z] Scanning dependencies of target xdg-desktop-portal-kde_autogen[2020-04-08T16:31:50.520Z] [  3%] Automatic MOC for target xdg-desktop-portal-kde[2020-04-08T16:31:53.059Z] [  3%] Built target xdg-desktop-portal-kde_autogen[2020-04-08T16:31:53.059Z] [ 10%] Generating ui_accessdialog.h[2020-04-08T16:31:53.059Z] [ 10%] Generating user_interface.cpp, user_interface.h[2020-04-08T16:31:53.059Z] [ 13%] Generating ui_screenshotdialog.h[2020-04-08T16:31:53.059Z] [ 16%] Generating ui_appchooserdialog.h[2020-04-08T16:31:53.059Z] [ 20%] Generating ui_userinfodialog.h[2020-04-08T16:31:53.059Z] [ 23%] Generating user_interface.moc[2020-04-08T16:31:53.631Z] Scanning dependencies of target xdg-desktop-portal-kde[2020-04-08T16:31:53.631Z] [ 26%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/xdg-desktop-portal-kde.cpp.o[2020-04-08T16:31:53.631Z] [ 30%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/xdg-desktop-portal-kde_autogen/mocs_compilation.cpp.o[2020-04-08T16:31:53.631Z] [ 33%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/access.cpp.o[2020-04-08T16:31:53.631Z] [ 36%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/accessdialog.cpp.o[2020-04-08T16:31:53.631Z] [ 40%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/account.cpp.o[2020-04-08T16:31:53.631Z] [ 43%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/appchooser.cpp.o[2020-04-08T16:31:55.053Z] /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/src/access.cpp:45:40: warning: unused parameter 'results' [-Wunused-parameter][2020-04-08T16:31:55.053Z]   QVariantMap &results)[2020-04-08T16:31:55.053Z]^[2020-04-08T16:31:55.342Z] [ 46%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/appchooserdialog.cpp.o[2020-04-08T16:31:55.342Z] [ 50%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/background.cpp.o[2020-04-08T16:31:55.342Z] 1 warning generated.[2020-04-08T16:31:55.342Z] [ 53%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/desktopportal.cpp.o[2020-04-08T16:31:55.342Z] [ 56%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/email.cpp.o[2020-04-08T16:31:55.608Z] [ 60%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/filechooser.cpp.o[2020-04-08T16:31:55.865Z] [ 63%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/inhibit.cpp.o[2020-04-08T16:31:56.865Z] [ 66%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/notification.cpp.o[2020-04-08T16:31:57.450Z] [ 70%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/print.cpp.o[2020-04-08T16:31:57.451Z] [ 73%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/request.cpp.o[2020-04-08T16:31:57.719Z] [ 76%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/session.cpp.o[2020-04-08T16:31:57.719Z] [ 80%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/screenshot.cpp.o[2020-04-08T16:31:57.719Z] [ 83%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/screenshotdialog.cpp.o[2020-04-08T16:31:59.142Z] [ 86%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/settings.cpp.o[2020-04-08T16:31:59.142Z] /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/src/print.cpp:256:32: warning: unused parameter 'results' [-Wunused-parameter][2020-04-08T16:31:59.142Z]   QVariantMap &results)[2020-04-08T16:31:59.142Z]^[2020-04-08T16:31:59.407Z] [ 90%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/utils.cpp.o[2020-04-08T16:31:59.407Z] /usr/home/jenkins/work

D28517: Send notification when screencasting fails

[Carson Black]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:1452cf0efde1: Send notification when screencasting fails 
(authored by cblack).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28517?vs=79524&id=79652#toc

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28517?vs=79524&id=79652

REVISION DETAIL
  https://phabricator.kde.org/D28517

AFFECTED FILES
  src/CMakeLists.txt
  src/screencaststream.cpp
  src/xdg-desktop-portal-kde.cpp
  src/xdg-desktop-portal-kde.notifyrc

To: cblack, #plasma, #vdg, ngraham, apol, jgrulich, broulik
Cc: broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28671: Improve appearance of gallery listing

[Carson Black]

cblack updated this revision to Diff 79650.
cblack retitled this revision from "Improved gallery listing" to "Improve 
appearance of gallery listing".
cblack edited the summary of this revision.
cblack added a comment.


  Add search

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28671?vs=79648&id=79650

BRANCH
  cblack/pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28671

AFFECTED FILES
  src/CMakeLists.txt
  src/data/contents/ui/MainPage.qml
  src/data/contents/ui/img/action-tool-bar.svg
  src/data/contents/ui/img/buttons.svg
  src/data/contents/ui/img/cardgrid.svg
  src/data/contents/ui/img/cardlayout.svg
  src/data/contents/ui/img/cardlist.svg
  src/data/contents/ui/img/colors.svg
  src/data/contents/ui/img/colorsets.svg
  src/data/contents/ui/img/columnview.svg
  src/data/contents/ui/img/drawers.svg
  src/data/contents/ui/img/formlayout.svg
  src/data/contents/ui/img/headers.svg
  src/data/contents/ui/img/inlinemessage.svg
  src/data/contents/ui/img/listview.svg
  src/data/contents/ui/img/metrics.svg
  src/data/contents/ui/img/miscwidgets.svg
  src/data/contents/ui/img/non-scroll-page.svg
  src/data/contents/ui/img/overlay-sheets.svg
  src/data/contents/ui/img/progress-bar.svg
  src/data/contents/ui/img/selection-controls.svg
  src/data/contents/ui/img/slider.svg
  src/data/contents/ui/img/tabbar.svg
  src/data/contents/ui/img/textfield.svg
  src/resources.qrc

To: cblack, #vdg, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> autostart.cpp:167
>  {
> -KOpenWithDialog owdlg( this );
> -if (owdlg.exec() != QDialog::Accepted)
> -return;
> +KOpenWithDialog* owdlg = new KOpenWithDialog(this);
> +connect(owdlg, &QDialog::finished, this, [this, owdlg] (int result) {

Space before * not after, or just use auto

> autostart.cpp:186
>  {
> -AddScriptDialog * addDialog = new AddScriptDialog(this);
> -int result = addDialog->exec();
> -if (result == QDialog::Accepted) {
> -if (addDialog->symLink())
> -KIO::link(addDialog->importUrl(), 
> QUrl::fromLocalFile(m_paths[0]));
> -else
> -KIO::copy(addDialog->importUrl(), 
> QUrl::fromLocalFile(m_paths[0]));
> -
> -ScriptStartItem * item = new ScriptStartItem( m_paths[0] + 
> addDialog->importUrl().fileName(), m_scriptItem,this );
> -addItem( item,  addDialog->importUrl().fileName(), 
> addDialog->importUrl().fileName(),ScriptStartItem::START );
> -}
> -delete addDialog;
> +AddScriptDialog* addDialog = new AddScriptDialog(this);
> +connect(addDialog, &QDialog::finished, this, [this, addDialog] (int 
> result) {

ditto

> autostart.cpp:214
>  {
> +Q_UNUSED(parent)
> +Q_UNUSED(last)

Actually I think I'd Q_ASSERT(!parent.isValid())

> autostart.cpp:215
> +Q_UNUSED(parent)
> +Q_UNUSED(last)
>  

This Q_UNUSED is now used ;-)

> autostart.cpp:276
> +
> +KPropertiesDialog* dlg = new KPropertiesDialog( kfi, this );
> +connect(dlg, &QDialog::finished, this, [this, index, fileName, 
> desktopItem, dlg] (int result) {

Space before * not after, or use auto
Also drop the spaces between the parentheses

> autostart.cpp:296
>  {
> -if ( widget->listCMD->currentItem() == nullptr )
> +if ( widget->listCMD->currentItem() == nullptr ) {
>  return;

Since you touched the line, please drop the spaces between the parentheses

> autostart.cpp:304
>  {
> -if ( widget->listCMD->currentItem() == nullptr )
> +if ( widget->listCMD->currentItem() == nullptr ) {
>  return;

Since you touched the line, please drop the spaces between the parentheses

> autostart.cpp:321
> +
> +QModelIndex Autostart::indexFromWidget(QTreeWidgetItem* widget) const {
> +int index = m_programItem->indexOfChild(widget);

Since you touched the line please fix the * and { positions

> ervin wrote in autostart.h:64
> Still needs being addressed

Still needs being addressed. :-)

> autostartmodel.cpp:130
> +
> +AutostartModel::AutostartModel(QWidget* parent)
> +: QAbstractListModel(parent)

Space before * not after

> ervin wrote in autostartmodel.cpp:177
> Makes me realize: are we sure it will always be the first entry? I'm not sure 
> we can guarantee that over time.

Still needs being addressed.

> autostartmodel.h:49
> +public:
> +explicit AutostartModel(QWidget* parent = nullptr);
> +

Since you touched the line, please drop the spaces between the parentheses

> autostartmodel.h:81
> +QVector m_entries;
> +QWidget* m_window;
> +};

Space before * not after

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28671: Improve appearance of gallery listing

[Carson Black]

cblack updated this revision to Diff 79648.
cblack added a comment.


  Adjust images to fit above a baseline

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28671?vs=79647&id=79648

BRANCH
  cblack/pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28671

AFFECTED FILES
  src/data/contents/ui/MainPage.qml
  src/data/contents/ui/img/action-tool-bar.svg
  src/data/contents/ui/img/buttons.svg
  src/data/contents/ui/img/cardgrid.svg
  src/data/contents/ui/img/cardlayout.svg
  src/data/contents/ui/img/cardlist.svg
  src/data/contents/ui/img/colors.svg
  src/data/contents/ui/img/colorsets.svg
  src/data/contents/ui/img/columnview.svg
  src/data/contents/ui/img/drawers.svg
  src/data/contents/ui/img/formlayout.svg
  src/data/contents/ui/img/headers.svg
  src/data/contents/ui/img/inlinemessage.svg
  src/data/contents/ui/img/listview.svg
  src/data/contents/ui/img/metrics.svg
  src/data/contents/ui/img/miscwidgets.svg
  src/data/contents/ui/img/non-scroll-page.svg
  src/data/contents/ui/img/overlay-sheets.svg
  src/data/contents/ui/img/progress-bar.svg
  src/data/contents/ui/img/selection-controls.svg
  src/data/contents/ui/img/slider.svg
  src/data/contents/ui/img/tabbar.svg
  src/data/contents/ui/img/textfield.svg
  src/resources.qrc

To: cblack, #vdg, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart

D28671: Improve appearance of gallery listing

[Carson Black]

cblack updated this revision to Diff 79647.
cblack added a comment.


  Fix opacity issues

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28671?vs=79622&id=79647

BRANCH
  cblack/pictures (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28671

AFFECTED FILES
  src/data/contents/ui/MainPage.qml
  src/data/contents/ui/img/action-tool-bar.svg
  src/data/contents/ui/img/buttons.svg
  src/data/contents/ui/img/cardgrid.svg
  src/data/contents/ui/img/cardlayout.svg
  src/data/contents/ui/img/cardlist.svg
  src/data/contents/ui/img/colors.svg
  src/data/contents/ui/img/colorsets.svg
  src/data/contents/ui/img/columnview.svg
  src/data/contents/ui/img/drawers.svg
  src/data/contents/ui/img/formlayout.svg
  src/data/contents/ui/img/headers.svg
  src/data/contents/ui/img/inlinemessage.svg
  src/data/contents/ui/img/listview.svg
  src/data/contents/ui/img/metrics.svg
  src/data/contents/ui/img/miscwidgets.svg
  src/data/contents/ui/img/non-scroll-page.svg
  src/data/contents/ui/img/overlay-sheets.svg
  src/data/contents/ui/img/progress-bar.svg
  src/data/contents/ui/img/selection-controls.svg
  src/data/contents/ui/img/slider.svg
  src/data/contents/ui/img/tabbar.svg
  src/data/contents/ui/img/textfield.svg
  src/resources.qrc

To: cblack, #vdg, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart

D28666: Refactor for loops

[Carson Black]

cblack added a comment.


  In D28666#644079 , @ngraham wrote:
  
  > I'm not a Javascript expert, but the old/current versions seem much more 
readable to me. Is there a performance advantage to your proposed new versions?
  
  
  No, the main point is writing idiomatic JavaScript. To people familiar with 
idiomatic JavaScript, these constructs will immediately let them know what's 
going on instead of them having to parse a multiline structure.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28666

To: cblack, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D28666: Refactor for loops

[Carson Black]

cblack updated this revision to Diff 79642.
cblack marked 3 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28666?vs=79623&id=79642

BRANCH
  cblack/for-refactor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28666

AFFECTED FILES
  src/controls/Action.qml
  src/controls/CardsLayout.qml
  src/controls/ContextDrawer.qml
  src/controls/FormLayout.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/PassiveNotification.qml

To: cblack, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D28666: Refactor for loops

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> broulik wrote in Action.qml:156
> Why are you going through the prototype? Or is `children` not a "proper" 
> Array?
> Also, can we use spread operator `...` here?
> And yes, please make those a bit more readable by using useful line breaks 
> and using parentheses and braces.

It's a QML `list`, not an ECMAScript `Array`. Also, I don't see why you would 
need to use the spread operator here.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28666

To: cblack, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D28665: Explicitly type ColorUtils lambda

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:3263c5a9b533: Explicitly type ColorUtils lambda (authored 
by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28665?vs=79613&id=79641

REVISION DETAIL
  https://phabricator.kde.org/D28665

AFFECTED FILES
  src/kirigamiplugin.cpp

To: cblack, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven updated this revision to Diff 79639.
meven marked 20 inline comments as done.
meven added a comment.


  Make most dialogs use open/finished, make all dialogs modal...

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26934?vs=78855&id=79639

BRANCH
  D26934-2

REVISION DETAIL
  https://phabricator.kde.org/D26934

AFFECTED FILES
  kcms/autostart/CMakeLists.txt
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.h
  kcms/autostart/autostartitem.cpp
  kcms/autostart/autostartitem.h
  kcms/autostart/autostartmodel.cpp
  kcms/autostart/autostartmodel.h

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28678: adjust smb kcm size to be sufficient vis a vis headers

[Harald Sitter]

sitter added a comment.


  F8225234: Screenshot_20200408_142242.png 

  
  F8225237: Screenshot_20200408_142227-1.png 

  
  F8225239: Screenshot_20200408_142309.png 


REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D28678

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28678: adjust smb kcm size to be sufficient vis a vis headers

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  we use Stretch to get a somewhat uniform appearance between the two views
  but Stretch is bit meh when it comes to actual sizing as it acts kind of
  like QSizePolicy::Preferred in that it allows shrinking columns so small
  that even the header gets cut off. this of course looks silly, so we
  now set the largest required width as minimal section width. this prevents
  the user from cutting off headers by resizing the window.
  
  secondly, and entirely related to that, because KCMs are embedded into
  a scrollview their sizehint kinda doesn't make any difference for
  the window size which then combined with the aforementioned stretch problem
  can lead to cut off headers by default as the window size is too small
  making the stretch cut into header text.
  to ensure the default size is reasonable let the view adjust to content
  on first show, effectively making the window as large as needed
  regardless of implicit hints.
  
  BUG: 419786
  FIXED-IN: 5.18.5

TEST PLAN
  - empty dialog
  - dialog with only shares
  - dialog with shares and mounts

REPOSITORY
  R102 KInfoCenter

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D28678

AFFECTED FILES
  Modules/samba/main.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28134: Add ColorUtils

[Allen Winter]

winterz added a comment.


  In D28134#643899 , @kossebau wrote:
  
  > Seems to no be compatible with Qt 5.12, see failing on CI: 
https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console
  
  
  same for Qt5.13.2
  please revert or fix asap.  lots of the build stack depends on kirigami
  
[3/5] Building CXX object 
src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o
FAILED: src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o 
/data/kde/src/5/frameworks/kirigami/src/kirigamiplugin.cpp:248:122: error: 
invalid user-defined conversion from ‘KirigamiPlugin::registerTypes(const 
char*)::’ to ‘QObject* (*)(QQmlEngine*, 
QJSEngine*)’ [-fpermissive]
  248 | qmlRegisterSingletonType(uri, 2, 12, "ColorUtils", 
[](QQmlEngine*, QJSEngine*) { return new ColorUtils; });
  | 
 ^
/data/kde/src/5/frameworks/kirigami/src/kirigamiplugin.cpp:248:68: note: 
candidate is: ‘KirigamiPlugin::registerTypes(const char*)operator ColorUtils* (*)(QQmlEngine*, QJSEngine*)() const’ 
  248 | qmlRegisterSingletonType(uri, 2, 12, "ColorUtils", 
[](QQmlEngine*, QJSEngine*) { return new ColorUtils; });
  |^
/data/kde/src/5/frameworks/kirigami/src/kirigamiplugin.cpp:248:68: note:   
no known conversion from ‘ColorUtils* (*)(QQmlEngine*, QJSEngine*)’ to 
‘QObject* (*)(QQmlEngine*, QJSEngine*)’
In file included from /usr/include/qt5/QtQml/qqmlengine.h:47,
 from /usr/include/qt5/QtQml/QQmlEngine:1,
 from 
/data/kde/src/5/frameworks/kirigami/src/kirigamiplugin.h:14

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28134

To: cblack, #plasma, mart, davidedmundson
Cc: winterz, dfaure, kossebau, fvogt, davidedmundson, plasma-devel, 
fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart

D28134: Add ColorUtils

[David Faure]

dfaure added a comment.


  Breaks compilation with Qt 5.13 too.
  
/data/kde/src/5/frameworks/kirigami/src/kirigamiplugin.cpp:248:122: error: 
invalid user-defined conversion from ‘KirigamiPlugin::registerTypes(const 
char*)::’ to ‘QObject* (*)(QQmlEngine*, 
QJSEngine*)’ [-fpermissive]
  248 | qmlRegisterSingletonType(uri, 2, 12, "ColorUtils", 
[](QQmlEngine*, QJSEngine*) { return new ColorUtils; });
  | 
 ^
  
  This overload is new in Qt 5.14.
  Please use something that works with 5.12, and/or use a QT_VERSION #if.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28134

To: cblack, #plasma, mart, davidedmundson
Cc: dfaure, kossebau, fvogt, davidedmundson, plasma-devel, fbampaloukas, GB_2, 
domson, dkardarakos, ngraham, apol, ahiemstra, mart

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 23 - Failure!

[David Edmundson]

Is a failure, caused by some baloo thing.

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> acpi.c:147
>  if ( maximum > 0) {
> -state = charge * 100 / maximum;
> +state = charge/(float)(maximum/100);/* to get 0.1% changes */
>  }

`(float)(var_int/var_int)` does not what you want, it should be 
`((float)var_int / var_int)`

> acpi.c:179
>  if (maximum > 0) {
> -state = charge * 100 / maximum;
> +state = charge/(float)(maximum/100);/* to get 0.1% changes */
>  }

ditto

> acpi.c:211
> +if ( maximum > 0) {
> +state = charge/(float)(maximum/100);/* to get 0.1% changes */
> +}

ditto

> acpi.c:243
> +if (maximum > 0) {
> +state = charge/(float)(maximum/100);/* to get 0.1% changes */
> +}

ditto

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/23/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Wed, 08 Apr 2020 10:54:19 +
 Build duration:
1 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 3241 lines...][2020-04-08T10:56:08.984Z] [ 45%] Linking CXX shared module ../../bin/kcm_feedback.so[2020-04-08T10:56:09.242Z] [ 45%] Building CXX object runners/baloo/CMakeFiles/baloorunner.dir/krunner1adaptor.cpp.o[2020-04-08T10:56:09.242Z] [ 45%] Linking CXX shared module ../../bin/kcm_translations.so[2020-04-08T10:56:09.242Z] [ 45%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarks_test.dir/bookmarkmatch.cpp.o[2020-04-08T10:56:09.500Z] [ 45%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarks_test.dir/faviconfromblob.cpp.o[2020-04-08T10:56:09.500Z] [ 45%] Built target plasma_containmentactions_applauncher[2020-04-08T10:56:09.500Z] Scanning dependencies of target krunner_placesrunner[2020-04-08T10:56:09.500Z] [ 45%] Building CXX object runners/places/CMakeFiles/krunner_placesrunner.dir/krunner_placesrunner_autogen/mocs_compilation.cpp.o[2020-04-08T10:56:09.758Z] [ 45%] Linking CXX shared module ../../bin/krunner_activities.so[2020-04-08T10:56:09.758Z] [ 45%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarksrunner.dir/faviconfromblob.cpp.o[2020-04-08T10:56:09.758Z] [ 45%] Built target kcm_feedback[2020-04-08T10:56:09.758Z] Scanning dependencies of target krunner_services_static[2020-04-08T10:56:09.758Z] [ 45%] Building CXX object runners/services/CMakeFiles/krunner_services_static.dir/krunner_services_static_autogen/mocs_compilation.cpp.o[2020-04-08T10:56:10.015Z] [ 45%] Built target kcm_translations[2020-04-08T10:56:10.015Z] [ 46%] Linking CXX shared module ../../bin/krunner_calculatorrunner.so[2020-04-08T10:56:10.015Z] Scanning dependencies of target krunner_recentdocuments[2020-04-08T10:56:10.015Z] [ 46%] Building CXX object runners/recentdocuments/CMakeFiles/krunner_recentdocuments.dir/krunner_recentdocuments_autogen/mocs_compilation.cpp.o[2020-04-08T10:56:10.015Z] [ 46%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarksrunner.dir/favicon.cpp.o[2020-04-08T10:56:10.273Z] [ 46%] Built target krunner_activities[2020-04-08T10:56:10.273Z] [ 46%] Building CXX object runners/locations/CMakeFiles/krunner_locations.dir/locationrunner.cpp.o[2020-04-08T10:56:10.273Z] Scanning dependencies of target krunner_shell[2020-04-08T10:56:10.273Z] [ 46%] Building CXX object runners/shell/CMakeFiles/krunner_shell.dir/krunner_shell_autogen/mocs_compilation.cpp.o[2020-04-08T10:56:10.531Z] [ 46%] Built target krunner_calculatorrunner[2020-04-08T10:56:10.788Z] [ 47%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarks_test.dir/favicon.cpp.o[2020-04-08T10:56:10.788Z] Scanning dependencies of target krunner_webshortcuts[2020-04-08T10:56:10.788Z] [ 47%] Building CXX object runners/webshortcuts/CMakeFiles/krunner_webshortcuts.dir/krunner_webshortcuts_autogen/mocs_compilation.cpp.o[2020-04-08T10:56:11.052Z] [ 47%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarks_test.dir/fetchsqlite.cpp.o[2020-04-08T10:56:11.317Z] [ 47%] Building CXX object runners/places/CMakeFiles/krunner_placesrunner.dir/placesrunner.cpp.o[2020-04-08T10:56:11.317Z] [ 47%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarksrunner.dir/fetchsqlite.cpp.o[2020-04-08T10:56:11.317Z] [ 48%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarksrunner.dir/bookmarks_debug.cpp.o[2020-04-08T10:56:11.581Z] [ 48%] Building CXX object runners/services/CMakeFiles/krunner_services_static.dir/servicerunner.cpp.o[2020-04-08T10:56:11.845Z] [ 48%] Building CXX object runners/services/CMakeFiles/krunner_services_static.dir/debug.cpp.o[2020-04-08T10:56:11.845Z] [ 48%] Building CXX object runners/shell/CMakeFiles/krunner_shell.dir/shellrunner.cpp.o[2020-04-08T10:56:11.845Z] [ 48%] Building CXX object runners/recentdocuments/CMakeFiles/krunner_recentdocuments.dir/recentdocuments.cpp.o[2020-04-08T10:56:12.109Z] [ 48%] Building CXX object runners/webshortcuts/CMakeFiles/krunner_webshortcuts.dir/webshortcutrunner.cpp.o[2020-04-08T10:56:12.109Z] [ 48%] Linking CXX shared module ../../bin/krunner_locations.so[2020-04-08T10:56:12.366Z] [ 48%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarks_test.dir/bookmarks_debug.cpp.o[2020-04-08T10:56:12.940Z] [ 48%] Linking CXX executable ../../bin/baloorunner[2020-04-08T10:56:12.940Z] [ 48%] Built target krunner_locations[2020-04-08T10:56:13.209Z] Scanning dependencies of target krunner_windowedwidgets[2020-04-08T10:56:13.209Z] [ 48%] Building CXX object runners/windowedwidgets/CMakeFiles/krunner_windowedwidgets.dir/krunner_windowedwidgets_autogen/mocs_compilation.cpp.o[2020-04-08T10:56:13.209Z] [ 48%] Building CXX object runners/bookmarks/CMakeFiles/krunner_bookmarksrunner.dir/bookmarksrunner.cpp.o[2020-04-08T10:56

D28676: Drop kdeinit from ksmserver

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5ea6a05ebb8e: Drop kdeinit from ksmserver (authored by 
davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28676?vs=79631&id=79637

REVISION DETAIL
  https://phabricator.kde.org/D28676

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/main.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28626: [plasma-session] Don't prematurely cache systemEnvironemnt

[David Edmundson]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4e681fdb580f: [plasma-session] Don't prematurely 
cache systemEnvironemnt (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28626?vs=79492&id=79636

REVISION DETAIL
  https://phabricator.kde.org/D28626

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Jan Grulich]

jgrulich added a comment.


  I asked on kde-distribution-packagers, so far I got only response from Slack 
and the response was they don't care about Wayland, if they would, they would 
have included PipeWire. I think it should be either don't support Wayland at 
all if distribution doesn't care or support it fully and let them get PipeWire 
included.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Jan Grulich]

jgrulich added a comment.


  In D28677#644196 , @davidedmundson 
wrote:
  
  > > Also allow to completely disable Wayland support in case some 
distribution don't ship PipeWire yet.
  >
  > I don't follow, why don't we just disable the screencasting thing if we 
don't have pipewire. I don't see why we would affect the rest.
  
  
  I wanted to avoid adding tons of ifdefs to the wayland integration part, 
which I currently use only for screencasting and background portal. Before it 
was used only for screencasting, which was fine and I just avoided building it, 
but it will be used more and more.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[David Edmundson]

davidedmundson added a comment.


  > Also allow to completely disable Wayland support in case some distribution 
don't ship PipeWire yet.
  
  I don't follow, why don't we just disable the screencasting thing if we don't 
have pipewire. I don't see why we would affect the rest.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  Also allow to completely disable Wayland support in case some distribution 
don't ship PipeWire yet

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  pipewire-required

REVISION DETAIL
  https://phabricator.kde.org/D28677

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/waylandintegration.cpp

To: jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28676: Drop kdeinit from ksmserver

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  As we don't launch with kinit, no point ksmserver linking against it

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28676

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28517: Send notification when screencasting fails

[Jan Grulich]

jgrulich added a comment.


  Looks good to me. @broulik what do you think?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28517

To: cblack, #plasma, #vdg, ngraham, apol, jgrulich
Cc: broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge added a comment.


  Hem, you are right, I missed it because I was testing old binary.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge updated this revision to Diff 79629.
jjorge added a comment.


  - fix pointer

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28127?vs=79321&id=79629

BRANCH
  acpi-energy

REVISION DETAIL
  https://phabricator.kde.org/D28127

AFFECTED FILES
  ksysguardd/Linux/acpi.c
  ksysguardd/Linux/acpi.h

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28666: Refactor for loops

[Kai Uwe Broulik]

broulik added a comment.


  +1 for the `.some()` use
  -1 on the convoluted `Array.prototype` things, especially when chained.

INLINE COMMENTS

> Action.qml:156
>  readonly property var visibleChildren: {
> -var visible = [];
> -var child;
> -for (var i in children) {
> -child = children[i];
> -if (!child.hasOwnProperty("visible") || child.visible) {
> -visible.push(child)
> -}
> -}
> -return visible;
> +return Array.prototype.filter.call(children, child => 
> !child.hasOwnProperty("visible") || child.visible)
>  }

Why are you going through the prototype? Or is `children` not a "proper" Array?
Also, can we use spread operator `...` here?
And yes, please make those a bit more readable by using useful line breaks and 
using parentheses and braces.

> FormLayout.qml:85
>  var hint = 0;
> -for (var i in knownItems) {
> -hint = Math.max(hint, knownItems[i].Layout.preferredWidth > 
> 0 ? knownItems[i].Layout.preferredWidth : knownItems[i].implicitWidth);
> -}
> +knownItems.forEach(item => hint = Math.max(hint, 
> item.Layout.preferredWidth > 0 ? item.Layout.preferredWidth : 
> item.implicitWidth));
>  return hint;

Looks like a usecas for `Array.reduce`?

> PassiveNotification.qml:62
>  
> -for (let i = 0; i < outerLayout.children.length - 3; ++i) {
> -outerLayout.children[i].close();
> -}
> +outerLayout.children.slice(0, -3).forEach(child => child.close());
>  

I would like a comment here. Note veryone is faimilar with `slice` in that 
fashion.

> PassiveNotification.qml:72
>  // Reorder items to have the last on top
> -let children = outerLayout.children;
> -for (let i in children) {
> -children[i].Layout.row = children.length-1-i;
> -}
> +outerLayout.children.forEach(function(value, index) => {
> +value.Layout.row = outerLayout.children.length-1-index;

Why no arrow function?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28666

To: cblack, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart