KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/21/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 16 Apr 2020 04:17:54 +
 Build duration:
21 sec and counting
   CONSOLE OUTPUT
  [...truncated 232 lines...][2020-04-16T04:18:14.020Z] -- Detecting CXX compiler ABI info[2020-04-16T04:18:14.020Z] -- Detecting CXX compiler ABI info - done[2020-04-16T04:18:14.020Z] -- Detecting CXX compile features[2020-04-16T04:18:14.020Z] -- Detecting CXX compile features - done[2020-04-16T04:18:14.020Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T04:18:14.020Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-04-16T04:18:14.020Z] -- Looking for __GLIBC__[2020-04-16T04:18:14.020Z] -- Looking for __GLIBC__ - not found[2020-04-16T04:18:14.020Z] -- Performing Test _OFFT_IS_64BIT[2020-04-16T04:18:14.276Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-04-16T04:18:14.276Z] -- Performing Test HAVE_DATE_TIME[2020-04-16T04:18:14.276Z] -- Performing Test HAVE_DATE_TIME - Success[2020-04-16T04:18:14.533Z] -- Could NOT find PipeWire (missing: PipeWire_LIBRARIES PipeWire_INCLUDE_DIRS Spa_INCLUDE_DIRS) (found version "")[2020-04-16T04:18:14.533Z] -- Found GBM: /usr/local/lib/libgbm.so (found version "18.3.2") [2020-04-16T04:18:14.789Z] -- Found Epoxy: /usr/local/lib/libepoxy.so  [2020-04-16T04:18:14.789Z] -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.70.0") [2020-04-16T04:18:14.789Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.70.0") [2020-04-16T04:18:14.789Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2020-04-16T04:18:14.789Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.70.0") [2020-04-16T04:18:14.789Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T04:18:14.789Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.70.0") [2020-04-16T04:18:14.789Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.70.0") [2020-04-16T04:18:14.789Z] -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.70.0") [2020-04-16T04:18:14.789Z] -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.70.0") [2020-04-16T04:18:14.789Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T04:18:15.053Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T04:18:15.053Z] -- Found KF5Plasma: /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.70.0") [2020-04-16T04:18:15.053Z] -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.70.0") [2020-04-16T04:18:15.053Z] -- Found KF5WidgetsAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.70.0") [2020-04-16T04:18:15.053Z] -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.70.0") [2020-04-16T04:18:15.053Z] -- Found KF5: success (found suitable version "5.70.0", minimum required is "5.66.0") found components: CoreAddons Config I18n Declarative KIO Kirigami2 Notifications Plasma Wayland WidgetsAddons WindowSystem [2020-04-16T04:18:15.053Z] -- The following OPTIONAL packages have been found:[2020-04-16T04:18:15.053Z] [2020-04-16T04:18:15.053Z]  * PkgConfig[2020-04-16T04:18:15.053Z]  * KF5Completion (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * KF5ItemViews (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * KF5JobWidgets (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * KF5Solid (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * KF5Auth (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * KF5Codecs (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * KF5ConfigWidgets (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * KF5XmlGui (required version >= 5.69.0)[2020-04-16T04:18:15.053Z]  * 

D28873: Add SwipeNavigator component

[Noah Davis]

ndavis added a comment.


  So are these just all views that run simultaneously like apps on a task bar? 
What makes this different from tabs?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D28873: Add SwipeNavigator component

[Carson Black]

cblack added a comment.


  In D28873#649388 , @ndavis wrote:
  
  > What is the usecase for this?
  
  
  Apps that have shallow and primarily lateral navigation.
  
  > The progress tab's page highlight changes width with the percent of 
progress, correct? I think it looks wrong like that, unless I'm missing an 
important bit of context.
  
  Yes.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D28873: Add SwipeNavigator component

[Noah Davis]

ndavis added a comment.


  What is the usecase for this?
  
  The progress tab's page highlight changes width with the percent of progress, 
correct? I think it looks wrong like that, unless I'm missing an important bit 
of context.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D28873: Add SwipeNavigator component

[Carson Black]

cblack updated this revision to Diff 80259.
cblack added a comment.


  Add end-of-file newlines

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28873?vs=80258=80259

BRANCH
  cblack/lateral (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28873

AFFECTED FILES
  src/controls/Page.qml
  src/controls/SwipeNavigator.qml
  src/controls/private/SwipeTabBar.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28873: Add SwipeNavigator component

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  SwipeNavigator is a component optimized for lateral
  page navigation rather than hierarchical page navigation.

TEST PLAN
  F8240680: test.qml  F8240681: 
ksnip_20200415-232411.png  F8240682: 
ksnip_20200415-232538.png 

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/lateral (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28873

AFFECTED FILES
  src/controls/Page.qml
  src/controls/SwipeNavigator.qml
  src/controls/private/SwipeTabBar.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Filip Fila]

filipf added a comment.


  I guess the top separator should be removed altogether then? (As opposed to 
just shortening it)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20569: RFC: Use more compact OSD

[Filip Fila]

filipf added a comment.


  I still like osds as notifications but I agree with @alexde, a vertical osd 
in the corner opposite (?) to where notifications spawn would be visually more 
pleasing than what is proposed in this patch and should even get in the way 
less.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, 
Codezela, Fuchs, filipf, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng added a comment.


  In D28859#649191 , @davidedmundson 
wrote:
  
  > I don't understand.
  >
  > We're still running this at compile time, so what's the practical 
difference?
  
  
  The old implement hard-codes it to (minor_version - 7), which is the old 
contract.
  
  This commit message says it will ties the version with minor version. (I 
don't think this will change anymore, because patch version will not introduce 
new API anyway).
  
https://github.com/qt/qtquickcontrols2/commit/3c7bfc156797b2f3ef08a8cf620b79da80e4b061
  
  In order to cover both cases, this code is doing the check simply checking 
minor , minor - 1 until it finds the highest available version.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[David Edmundson]

davidedmundson added a comment.


  I don't understand.
  
  We're still running this at compile time, so what's the practical difference?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Any update on the status of this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng updated this revision to Diff 80227.
xuetianweng added a comment.


  fix header

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28859?vs=80226=80227

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt
  detectqqc2version.qml

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: Plasma, rizzitello, davidedmundson, apol, mart.
xuetianweng added a project: Plasma.
Herald added a subscriber: plasma-devel.
xuetianweng requested review of this revision.

REVISION SUMMARY
  Whenever qqc release a new version the version need to be updated.
  Otherwise the feature is not available to user. This change tries
  to use real qml code to detect the version by creating object until
  success, force to use a minimal qpa platform when running it.

TEST PLAN
  Run the cmake under a env without display server and version is detected
  correctly.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28859

AFFECTED FILES
  CMakeLists.txt
  detectqqc2version.qml

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80224.
davidre added a comment.


  - Add section checkbox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80216=80224

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 80223.
cblack marked 3 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=79874=80223

BRANCH
  arcpatch-D28383

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  Mainpage.dox
  autotests/CMakeLists.txt
  autotests/tst_pagerouter.qml
  docs/pics/PageRouterModel.svg
  docs/pics/PageRouterNavigate.svg
  docs/pics/PageRouterPop.svg
  docs/pics/PageRouterPush.svg
  examples/PageRoute.qml
  examples/PageRouter.qml
  examples/PageRouterCachePagesDo.qml
  examples/PageRouterCachePagesDont.qml
  examples/PageRouterColumnView.qml
  examples/PageRouterInitialRoute.qml
  examples/PageRouterRoutes.qml
  src/CMakeLists.txt
  src/controls/PageRow.qml
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This is probably fine as-is, and we can fine-tune it later if need be.
  
  We should wait to land it until the companion patches for Breeze GTK 
(https://invent.kde.org/kde/breeze-gtk/-/merge_requests/2), Kirigami (TBD) and 
QQC2-desktop style (TBD) have also landed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80216.
davidre marked an inline comment as done.
davidre added a comment.


  - Use pointing hand cursor
  - Rename error signals to errorOccured

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80198=80216

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28462: [KCM] Add color state probe to allow system settings to display current default state

[Benjamin Port]

bport updated this revision to Diff 80215.
bport added a comment.


  fix build

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28462?vs=79781=80215

REVISION DETAIL
  https://phabricator.kde.org/D28462

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorsdata.cpp
  kcms/colors/colorsdata.h
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemedata.cpp
  kcms/cursortheme/cursorthemedata.h
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsdata.cpp
  kcms/fonts/fontsdata.h
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingdata.cpp
  kcms/spellchecking/spellcheckingdata.h

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ervin wrote in autostartmodel.h:52
> Weeell... knowing about Qt::DisplayRole is kind of prerequisite to making 
> your own model. :-)

As you want.
IMO this is not a good pattern to expect reviewers to have any previous 
knowledge about enum values, especially for new contributors (I was concerned 
by this when I started reading QAbstractModel implementations)
Better to teach them those values by making things explicit. It also helps when 
using an IDE for discoverability.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven updated this revision to Diff 80200.
meven added a comment.


  Use Qt::DisplayRole directly instead of using Roles::DisplayRole

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26934?vs=80196=80200

BRANCH
  D26934-2

REVISION DETAIL
  https://phabricator.kde.org/D26934

AFFECTED FILES
  kcms/autostart/CMakeLists.txt
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.h
  kcms/autostart/autostartitem.cpp
  kcms/autostart/autostartitem.h
  kcms/autostart/autostartmodel.cpp
  kcms/autostart/autostartmodel.h

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80198.
davidre added a comment.


  - Update the delegate

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80137=80198

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven updated this revision to Diff 80196.
meven marked 11 inline comments as done.
meven added a comment.


  Address review, fix an issue when adding a desktop item

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26934?vs=79639=80196

BRANCH
  D26934-2

REVISION DETAIL
  https://phabricator.kde.org/D26934

AFFECTED FILES
  kcms/autostart/CMakeLists.txt
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.h
  kcms/autostart/autostartitem.cpp
  kcms/autostart/autostartitem.h
  kcms/autostart/autostartmodel.cpp
  kcms/autostart/autostartmodel.h

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

[David Redondo]

davidre added subscribers: dfaure, davidre.
davidre added a comment.


  This causes expired notifications to not vanish any more. This is supposed to 
work in the following way `ExpiredRole` is assigned `true` and  
`NotficiationFilterProxyModel` filters expired notifications out. I verified 
that upon timeout of the timer the data is updated correctly but the filter 
model behaves in a strange way. Even though filterAcceptsRow returns false  the 
model still includes the index. I added the following debug output to the 
class:  https://phabricator.kde.org/P584
  Which results in this debug output
  
QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired
QModelIndex(-1,-1,0x0,QObject(0x0)) not expired
rowCount NotificationManager::NotificationFilterProxyModel(0x557a51f6ab00) 
QModelIndex(-1,-1,0x0,QObject(0x0)) 1
QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired
filter returns for filterAcceptsRow(index(0, mapToSource(parent)) false
rowCount NotificationManager::NotificationFilterProxyModel(0x557a51f6ab00) 
QModelIndex(-1,-1,0x0,QObject(0x0)) 1
QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired
filter returns for filterAcceptsRow(index(0, mapToSource(parent)) false
  
  So it still has one row even though the first row should get filtered.
  
  Adding @dfaure because he wrote both  K/QConcatenate... models

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28649

To: broulik, #plasma
Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28853: krunner: Prevent regression

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
apol added a project: Plasma.
apol requested review of this revision.

REVISION SUMMARY
  It was pointed out to me that using NoDisplay=true breaks starting
  krunner.
  
  Alternatively D24956  could be landed.

TEST PLAN
  Still works for me, for some reason

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28853

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28852: Yep

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28852

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28822: Create StreamRestore channel if none exists

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:5bdd13689579: Create StreamRestore channel if none exists 
(authored by nicolasfella).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28822?vs=80100=80189

REVISION DETAIL
  https://phabricator.kde.org/D28822

AFFECTED FILES
  src/streamrestore.cpp

To: nicolasfella, #plasma, drosca, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28833: [kcm/touchpad] Simplify directory structure

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9f34469d04e3: [kcm/touchpad] Simplify directory structure 
(authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28833?vs=80134=80185#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28833?vs=80134=80185

REVISION DETAIL
  https://phabricator.kde.org/D28833

AFFECTED FILES
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/applet/CMakeLists.txt
  kcms/touchpad/applet/dataengine.desktop
  kcms/touchpad/applet/qml/contents/ui/touchpad.qml
  kcms/touchpad/applet/qml/metadata.desktop
  kcms/touchpad/applet/touchpad.operations
  kcms/touchpad/applet/touchpad.svg
  kcms/touchpad/applet/touchpadengine.cpp
  kcms/touchpad/applet/touchpadengine.h
  kcms/touchpad/applet/touchpadservice.cpp
  kcms/touchpad/applet/touchpadservice.h
  kcms/touchpad/backends/kwin_wayland.cmake
  kcms/touchpad/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/backends/libinputcommon.cpp
  kcms/touchpad/backends/libinputcommon.h
  kcms/touchpad/backends/x11.cmake
  kcms/touchpad/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/backends/x11/libinputtouchpad.h
  kcms/touchpad/backends/x11/listdevices.cpp
  kcms/touchpad/backends/x11/propertyinfo.cpp
  kcms/touchpad/backends/x11/propertyinfo.h
  kcms/touchpad/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/backends/x11/synapticstouchpad.h
  kcms/touchpad/backends/x11/xcbatom.cpp
  kcms/touchpad/backends/x11/xcbatom.h
  kcms/touchpad/backends/x11/xlibbackend.cpp
  kcms/touchpad/backends/x11/xlibbackend.h
  kcms/touchpad/backends/x11/xlibnotifications.cpp
  kcms/touchpad/backends/x11/xlibnotifications.h
  kcms/touchpad/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/backends/x11/xlibtouchpad.h
  kcms/touchpad/backends/x11/xrecordkeyboardmonitor.cpp
  kcms/touchpad/backends/x11/xrecordkeyboardmonitor.h
  kcms/touchpad/kcm/kcm_touchpad.desktop
  kcms/touchpad/kcm/libinput/touchpad.qml
  kcms/touchpad/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/kcm/resources.qrc
  kcms/touchpad/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/kcm/touchpadconfigcontainer.h
  kcms/touchpad/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/kcm/touchpadconfigplugin.h
  kcms/touchpad/kcm/xlib/customconfigdialogmanager.cpp
  kcms/touchpad/kcm/xlib/customconfigdialogmanager.h
  kcms/touchpad/kcm/xlib/customslider.cpp
  kcms/touchpad/kcm/xlib/customslider.h
  kcms/touchpad/kcm/xlib/sliderpair.cpp
  kcms/touchpad/kcm/xlib/sliderpair.h
  kcms/touchpad/kcm/xlib/testarea.cpp
  kcms/touchpad/kcm/xlib/testarea.h
  kcms/touchpad/kcm/xlib/testbutton.cpp
  kcms/touchpad/kcm/xlib/testbutton.h
  kcms/touchpad/kcm/xlib/touchpad.kcfg
  kcms/touchpad/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/kcm/xlib/touchpadparameters.kcfgc
  kcms/touchpad/kcm/xlib/touchpadparametersbase.cpp
  kcms/touchpad/kcm/xlib/touchpadparametersbase.h
  kcms/touchpad/kcm/xlib/ui/kded.ui
  kcms/touchpad/kcm/xlib/ui/pointermotion.ui
  kcms/touchpad/kcm/xlib/ui/scroll.ui
  kcms/touchpad/kcm/xlib/ui/sensitivity.ui
  kcms/touchpad/kcm/xlib/ui/tap.ui
  kcms/touchpad/kcm/xlib/ui/testarea.ui
  kcms/touchpad/kded/kcm_touchpad.notifyrc
  kcms/touchpad/kded/kded.cpp
  kcms/touchpad/kded/kded.h
  kcms/touchpad/kded/kded_touchpad.desktop
  kcms/touchpad/kded/kdedactions.cpp
  kcms/touchpad/kded/kdedactions.h
  kcms/touchpad/kded/kdedsettings.kcfgc
  kcms/touchpad/kded/touchpaddaemon.kcfg
  kcms/touchpad/logging.cpp
  kcms/touchpad/logging.h
  kcms/touchpad/plugins.cpp
  kcms/touchpad/plugins.h
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/applet/CMakeLists.txt
  kcms/touchpad/src/applet/dataengine.desktop
  kcms/touchpad/src/applet/qml/contents/ui/touchpad.qml
  kcms/touchpad/src/applet/qml/metadata.desktop
  kcms/touchpad/src/applet/touchpad.operations
  kcms/touchpad/src/applet/touchpad.svg
  kcms/touchpad/src/applet/touchpadengine.cpp
  kcms/touchpad/src/applet/touchpadengine.h
  kcms/touchpad/src/applet/touchpadservice.cpp
  kcms/touchpad/src/applet/touchpadservice.h
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/listdevices.cpp
  

D28383: Add PageRouter component

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> tst_pagerouter.qml:56
> +id: router
> +initialRoute: "/home"
> +columnView: root.columnView

I find all the "/" in the examples confusing, not sure is a good naming 
convention (and works prefectly without having that /, and i don't necessarly 
care what the convention in other frameworks is).
in the hend you can't push directly something like "/home/login" as a single 
string so doesn't really make sense as paths, i would prefer examples had 
simple strings as route names, so your route would be indicated as ["home", 
"login"]

> pagerouter.cpp:214
> +
> +void PageRouter::navigateToRoute(QJSValue route)
> +{

I wouldn't expect a verb like navigate to be always destructive.
if the route happens to be the same, then the function should be a no-op
if the current route is
home/foo/bar and i want to navigate to home/foo/baz i would expect to remove 
and destroy only bar, keeping the first two pages

if the new route is foo/bar/baz, should just push the new one keeping all is 
there

> pagerouter.h:180
> + */
> +Q_PROPERTY(ColumnView* columnView MEMBER m_columnView NOTIFY 
> columnViewChanged)
> +

I know we are fixed to columnview now and its fine, but i would prefer the 
property being called pageStack like in applicationwindow (in reality i would 
like both being called pageview but it's too late) which doesn't assume which 
it is, if sme day we would like to support stackview or whatever else we 
wouldn't have a sore point in the api

also, to the property assigning the pagerow (which will look for the columnview 
internally, but not exposed trough the api)

> pagerouter.h:357
> +QML_DECLARE_TYPEINFO(PageRouter, QML_HAS_ATTACHED_PROPERTIES)
> \ No newline at end of file


newlines!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28383

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, mart

D28837: Add device icons to KDE Connect context menu

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:60d074467453: Add device icons to KDE Connect context 
menu (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28837?vs=80151=80180

REVISION DETAIL
  https://phabricator.kde.org/D28837

AFFECTED FILES
  extension/extension-kdeconnect.js
  extension/icons/computer-laptop-symbolic.svg
  extension/icons/computer-symbolic.svg
  extension/icons/smartphone-symbolic.svg
  extension/icons/tablet-symbolic.svg

To: broulik, #plasma, #kde_connect, fvogt, ndavis
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28849: [KSysGuardProcessList] Port away from KRun

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:d8e46779566f: [KSysGuardProcessList] Port away from KRun 
(authored by broulik).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28849?vs=80175=80181

REVISION DETAIL
  https://phabricator.kde.org/D28849

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/ksysguardprocesslist.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28707: Show purpose context menu only when enabled

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:7f3bc46f9044: Show purpose context menu only when enabled 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28707?vs=80177=80178

REVISION DETAIL
  https://phabricator.kde.org/D28707

AFFECTED FILES
  extension/extension-purpose.js
  extension/extension.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28707: Show purpose context menu only when enabled

[Kai Uwe Broulik]

broulik updated this revision to Diff 80177.
broulik added a comment.


  - Call `updatePurposeMenu()` on connect

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28707?vs=80149=80177

REVISION DETAIL
  https://phabricator.kde.org/D28707

AFFECTED FILES
  extension/extension-purpose.js
  extension/extension.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28849: [KSysGuardProcessList] Port away from KRun

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead use `ApplicationLauncherJob` with `KDialogJobUiDelegate`

TEST PLAN
  - Clicking "Run command" in More tools menu still works (this could also just 
call krunner on dbus maybe?)
  - Running the apps in more tools menu (konsole, ksysguard, etc) still works

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28849

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/ksysguardprocesslist.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Kickoff menu with empty history tab

[David Edmundson]

Either kactivitymanagerd not running, or it's database being corrupted.

Running kactivitymanagerd manually might tell you.

David

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fe4d395d792d: Touchpad kcm: On X11 hide scroll speed as 
it is not supported (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28829?vs=80122=80171

REVISION DETAIL
  https://phabricator.kde.org/D28829

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpad.qml

To: meven, #kwin, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart