Re: Information regarding upcoming Gitlab Migration

2020-04-26 Thread Ben Cooksley 
On Mon, Apr 27, 2020 at 6:33 PM Rolf Eike Beer  
wrote:
>
> Bhushan Shah wrote:
>
> > I've worked on draft "move" of the current set of the repositories in
> > their respective subgroups at the repo-metadata project's branch [1].
> > You can browse the directory structure to get idea of how final
> > structure on Gitlab would look like.
>
> No objection, just a request for clarification: it looks like everything
> in extragear or playground was merged into there, right?

That is correct - the Extragear/Playground/"KDE" modules aren't
represented in this.

>
> Eike

Cheers,
Ben

Re: Information regarding upcoming Gitlab Migration

2020-04-26 Thread Rolf Eike Beer 

Bhushan Shah wrote:


I've worked on draft "move" of the current set of the repositories in
their respective subgroups at the repo-metadata project's branch [1].
You can browse the directory structure to get idea of how final
structure on Gitlab would look like.


No objection, just a request for clarification: it looks like everything 
in extragear or playground was merged into there, right?


Eike

Information regarding upcoming Gitlab Migration

2020-04-26 Thread Bhushan Shah 
[Please keep sysad...@kde.org list or bs...@kde.org in the CC for
replies]

Hello Community members,

In view of upcoming Gitlab migration, we sysadmin team wants to share
the recommended structuring for the repositories on Gitlab.

We had multiple options,

- Flat structure: In this option we would have everything under one
  single namespace/group: https://invent.kde.org/kde/knetwalk
- Subgroups under top-level group: In this option we would have a groups
  under KDE namespace: https://invent.kde.org/kde/games/knetwalk
- Groups at top level: In this option we would establish a series of
  groups at the top level, e.g.  https://invent.kde.org/games/knetwalk

We have discussed this with small but representative group of
contributors or maintainers, and based on their suggestions, we
recommend that we go with option 3. Having sub-groups at top level will
allow us to,

- Provides good visibility on all reviews, tasks and other items within
  the groups/modules we define
- Provides improvements to discoverability of projects
- Makes it possible for groups of projects to establish a group level
  task board should it fit their needs (for tracking a release for
  instance)
- Makes the most semantic sense, as the ‘KDE’ top level group suggested
  in option 2 is duplicative considering the Gitlab instance is under
  kde.org.
- The discoverability of projects is maximised, as there is no need to
  open the top level ‘KDE’ group before going into the subgroup.

I've worked on draft "move" of the current set of the repositories in
their respective subgroups at the repo-metadata project's branch [1].
You can browse the directory structure to get idea of how final
structure on Gitlab would look like.

If we don't have any objections we would like to implement this next
week and move projects to https://invent.kde.org.

Thanks!
Bhushan for sysadmin team

[1] 
https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

Re: Type=FSDevice desktop files

2020-04-26 Thread Aleix Pol 
On Sun, Apr 26, 2020 at 11:45 PM David Faure  wrote:
>
> Would it be OK if we dropped support for desktop files that represent devices?
> This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with
> Type=FSDevice and Dev=/dev/sdc
> and this would give you Mount and Unmount in the context menu.
>
> This was useful back then, for USB keys and CDROMs (kids, ask your parents
> what that was), before Solid, before the plasma device notification popup...
>
> But has anyone been using this in the last 10 years? I kind of doubt it.
>
> Since I'm refactoring KRun and KDesktopFileActions to be asynchronous and
> independent from QtWidgets, I need to know what to do with this IMHO very dead
> code. Of course these classes will keep providing the feature, but once I
> write a KIO::OpenUrlJob as a replacement for KRun and we port the code to
> that, we'll lose the feature from a user's point of view.
> Not sure this is really a loss though ;)

I don't think anyone I've ever discussed OSs would miss it.

CCing plasma-devel since people there might know more about different use cases.

Aleix

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner 
asturmlechner closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29215

To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner 
asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Otherwise, this does not get the header from Synaptics_INCLUDE_DIRS.

TEST PLAN
  Still builds.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29215

AFFECTED FILES
  kcms/touchpad/backends/x11/synapticstouchpad.cpp

To: asturmlechner, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29214: [Notifications] Fix typo

2020-04-26 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Fixes notifications of different origins being grouped together when they 
shouldn't.

TEST PLAN
  - Now get notifications from different websites in chrome not grouped 
together anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29214

AFFECTED FILES
  libnotificationmanager/notificationgroupingproxymodel.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:061a750068a4: Remove unused QtConcurrent from colorutils 
(authored by patrickelectric).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29202?vs=81262&id=81278

REVISION DETAIL
  https://phabricator.kde.org/D29202

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/colorutils.cpp

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Jonah Brüchert 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8473aad62ed4: PlaceholderMessage: Remove Plasma units 
usage (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29209?vs=81263&id=81274

REVISION DETAIL
  https://phabricator.kde.org/D29209

AFFECTED FILES
  src/controls/PlaceholderMessage.qml

To: jbbgameich, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oops, thanks for catching this!

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29209

To: jbbgameich, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Jonah Brüchert 
jbbgameich created this revision.
jbbgameich added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Probably this was forgotten when importing the new component into Kirigami

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29209

AFFECTED FILES
  src/controls/PlaceholderMessage.qml

To: jbbgameich, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
patrickelectric updated this revision to Diff 81262.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29202?vs=81260&id=81262

REVISION DETAIL
  https://phabricator.kde.org/D29202

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/colorutils.cpp

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
patrickelectric added a comment.


  @apol done.

REVISION DETAIL
  https://phabricator.kde.org/D29202

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
patrickelectric updated this revision to Diff 81260.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29202?vs=81240&id=81260

REVISION DETAIL
  https://phabricator.kde.org/D29202

AFFECTED FILES
  src/colorutils.cpp

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
patrickelectric added a comment.


  In D29202#657702 , 
@patrickelectric wrote:
  
  > In D29202#657700 , @apol wrote:
  >
  > > Then remove it from CMakeLists.txt as well?
  >
  >
  > Can you point what exactly should be removed ?
  
  
  Oh, I found the concurrent in CMake, I was misspelling it in my ctrl+f

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29202

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
patrickelectric added a comment.


  In D29202#657700 , @apol wrote:
  
  > Then remove it from CMakeLists.txt as well?
  
  
  Can you point what exactly should be removed ?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29202

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread Aleix Pol Gonzalez 
apol added a comment.


  Then remove it from CMakeLists.txt as well?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29202

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
patrickelectric added a comment.


  It fails to build when QtConcurrent can't be found.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29202

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29203: kirigami.pri: Add missing includes

2020-04-26 Thread patrick j pereira 
patrickelectric created this revision.
patrickelectric added reviewers: apol, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
patrickelectric requested review of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29203

AFFECTED FILES
  kirigami.pri

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira 
patrickelectric created this revision.
patrickelectric added reviewers: apol, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
patrickelectric requested review of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29202

AFFECTED FILES
  src/colorutils.cpp

To: patrickelectric, apol, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29142: Add footer support to systray

2020-04-26 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0f28094f584c: Add footer support to systray (authored by 
niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29142?vs=81184&id=81221

REVISION DETAIL
  https://phabricator.kde.org/D29142

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart