D27203: Don't try to open files we can't figure out where they are

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:226
> +//passing non-local files as the working directory is not supported.
> +//See QFileDialogPrivate::initialSelections
> +//Selectingg files should be done through the correct method.

That's not what that method says. It just says it can't know if the initial 
*selection* is a file or directory.

That's unrelated to what is the start directory.

QFileDialogPrivate::workingDirectory does support remote dirs.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29595: Add gocryptfs support

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ivan wrote in vaultwizardbase.h:65
> Heh, it was my first impression when the priority patch was contributed to 
> Vaults. Now I'm extra careful :)

Perhaps the unintuitive nature of the numbering could be clarified with a 
comment in a follow-up patch

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29595

To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Fix POTD in lock screen (partly)

[Yunhe Guo]

guoyunhe updated this revision to Diff 82610.
guoyunhe added a comment.


  Draft for PoTD KDED. Not tested.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29140?vs=81064=82610

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29140

AFFECTED FILES
  CMakeLists.txt
  dataengines/potd/PoTD-list.txt
  dataengines/potd/cachedprovider.cpp
  kdeds/CMakeLists.txt
  kdeds/potd/CMakeLists.txt
  kdeds/potd/kded_potd.cpp
  kdeds/potd/kded_potd.desktop
  kdeds/potd/kded_potd.h

To: guoyunhe, #plasma, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg added a comment.


  In D29024#668884 , @ngraham wrote:
  
  > In D29024#668383 , @romangg 
wrote:
  >
  > > Note that I need to have this plugin system or something similar in for 
5.19 or I will be forced to fork libkscreen permanently for KWinFT. I would 
like to avoid this and instead continue my work on libkscreen as a KDE project 
like I have worked on it in the last two years.
  >
  >
  > Nobody's forcing you to do anything.
  
  
  How would you call it? I obviously need output management to work and if my 
integration patch to libkscreen is blocked I need to keep maintaining my 
libkscreen fork. For that I inevitably have to build up much more project 
infrastructure than I currently have for what I intended to provide only for a 
short intermediate period.
  
  > Note that Plasma 5.19 branches in three days and merging huge things like 
this right before branching has bitten us before and I'd like to avoid it if 
possible for 5.19. So if we do go with this patch in something like its current 
form (I have no technical opinions on it whatsoever), I would like it merged in 
after branching for 5.19, not right before.
  
  This patch without header export but the very same plugin system was 
published for review on here already three weeks ago. I asked for feedback and 
later help in regards to the exported headers but received very little. The so 
called "high level discussion first" was David adding some arguments that are 
not worth repeating if one knows the internal libksceen structure, me pointing 
that out and him then ignoring it. He calls this high level discussion, I call 
it stalling tactic.
  
  I uploaded three days ago an updated version incorporating changes that were 
requested in the other review. Again no feedback until finally I ask today one 
last time for //specific// issues but instead David comes with the very same 
high level discussion he had more than enough time to reply to but missed out 
on doing in time. If he wants to tell other people how to do their code he 
needs to stay on top with what they are doing or delegate it.
  
  I have done large changes shortly before beta release in the past and fixed 
remaining issues in the beta phase without problems. That's what the beta phase 
is for. Since I'm online on most days there is no delay in fixing bugs if there 
are any.
  
  In D29024#668978 , @davidedmundson 
wrote:
  
  > > These are not specific issues but some general complains about the 
overall concept chosen here without providing an alternative solution.
  >
  > Well yes, it makes sense to do high level discussion first.
  
  
  You had more than enough time for that but ignored it in the last three weeks.
  
  > With the Plasma agreed "new approach" that we will be porting to we will be 
using QtWaylandClientExtension and removing the need for the connection thread 
- having that in the interface will hold up progress we want to do upstream.
  
  Show me where the documentation for this QtWaylandClientExtension is and 
where you documented that we "agreed" on using that in Plasma exclusively and 
we can talk about libkscreen using it in 5.20. Personally, I think with the 
current Qt situation instead of making us more dependent on Qt Company 
offerings we should become more independent but that's a different topic.
  
  In any case the plugin system here is independent of some "connection 
thread". You only hand over a normal QThread.
  
  >> here without providing an alternative solution.
  > 
  > static bool isValid() in the plugin. That is made synchronous by use of 
roundtrip. The existing plugin gets a very tiny refactor.
  
  I know when you say "tiny refactor", "little change", it's in the end often a 
large one with major repercussions on the overall structure and internal logic.
  
  Why would you want a synchronous design? I explicitly opted for an 
asynchronous one such that we can directly select the active plugin instead of 
waiting for potentially multiple other ones to return without success.
  
  > (also you could just qputenv("KSCREEN_BACKEND") from your fork before 
launching the shell which is even less invasive)
  
  What would this help? I would still need to fork basically the whole 
libkscreen Wayland backend to create another plugin. And enforcing this 
environment variable is a hack for a problem I solved cleaner and in more 
generality with the plugin system presented here. How would you add a plugin 
for wlroots based compositors? Should they then set a different environment 
variable?
  
  It's telling that you call providing infrastructure for clean integration 
with independent projects "invasive". Plasma is an unwelcoming inward-looking 
project thanks to this mindset.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: ngraham, 

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  Default indicator discussion is now on https://phabricator.kde.org/T13008

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart
Cc: GB_2, mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra

D29603: Adds custom spacing between task manager icons

[Jacopo Martellini]

martellini added a comment.


  Sounds cool. I'll be working on it.
  I must that the iconSize setting is only visibile if the panel is vertical, 
why do you think it is so?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg, ngraham
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29595: Add gocryptfs support

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> mpilia wrote in vaultwizardbase.h:65
> Of course, sorry. For some reason I though 1 was highest priority.

Heh, it was my first impression when the priority patch was contributed to 
Vaults. Now I'm extra careful :)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29595

To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29595: Add gocryptfs support

[Martino Pilia]

mpilia added inline comments.

INLINE COMMENTS

> ivan wrote in vaultwizardbase.h:65
> Lower the priority to 1.
> 
> I don't want to have gocryptfs as the default. At least for the time being.

Of course, sorry. For some reason I though 1 was highest priority.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29595

To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29595: Add gocryptfs support

[Martino Pilia]

mpilia updated this revision to Diff 82601.
mpilia added a comment.


  Fix priority for gocryptfs

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29595?vs=82425=82601

BRANCH
  add-gocryptfs-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29595

AFFECTED FILES
  kded/CMakeLists.txt
  kded/engine/backend_p.cpp
  kded/engine/backends/gocryptfs/gocryptfsbackend.cpp
  kded/engine/backends/gocryptfs/gocryptfsbackend.h
  kded/engine/fusebackend_p.cpp
  kded/ui/vaultconfigurationdialog.cpp
  kded/ui/vaultcreationwizard.cpp
  kded/ui/vaultimportingwizard.cpp
  kded/ui/vaultwizardbase.h

To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[David Edmundson]

davidedmundson added a comment.


  > These are not specific issues but some general complains about the overall 
concept chosen here without providing an alternative solution.
  
  Well yes, it makes sense to do high level discussion first.
  
  With the Plasma agreed "new approach" that we will be porting to we will be 
using QtWaylandClientExtension and removing the need for the connection thread 
- having that in the interface will hold up progress we want to do upstream.
  
  > here without providing an alternative solution.
  
  static bool isValid() in the plugin. That is made synchronous by use of 
roundtrip. The existing plugin gets a very tiny refactor.
  
  (also you could just qputenv("KSCREEN_BACKEND") from your fork before 
launching the shell which is even less invasive)

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

[Eugene Popov]

epopov added a comment.


  Currently, the Notifications applet closes itself when the last element 
(notification) is removed (or all elements are removed by pressing "Clear 
History" button in the top-right corner). But also it closes itself, even if 
the applet is pinned, and I guess that this behaviour isn't correct. D29651 
 fixes this issue.
  
  Currently, the Clipboard applet remains visible when the last element 
(fragment) is removed (or all elements are removed by clicking "Clear History" 
button in the top-right corner), even if the applet isn't pinned. D29652 
 makes the Clipboard applet to close itself 
if there are no elements in the clipboard history and it's not pinned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29652

To: epopov, ngraham, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29595: Add gocryptfs support

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Great work!

INLINE COMMENTS

> vaultwizardbase.h:65
> +{ "cryfs", 2 },
> +{ "gocryptfs", 3 },
>  };

Lower the priority to 1.

I don't want to have gocryptfs as the default. At least for the time being.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29595

To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e6ed4a888314: [applets/notifications] Remain visible 
after removing all notifications while… (authored by epopov, committed by 
ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29651?vs=82594=82596

REVISION DETAIL
  https://phabricator.kde.org/D29651

AFFECTED FILES
  applets/notifications/package/contents/ui/main.qml

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

[Eugene Popov]

epopov updated this revision to Diff 82594.
epopov added a comment.


  Fixed.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29651?vs=82563=82594

REVISION DETAIL
  https://phabricator.kde.org/D29651

AFFECTED FILES
  applets/notifications/package/contents/ui/main.qml

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

[Nathaniel Graham]

ngraham added a comment.


  > (similar to how the Notification applet closes after the last notification 
is removed).
  
  But you're changing that in D29651 ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29652

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

[Eugene Popov]

epopov added a comment.


  I believe that there is a better solution, but I did not come up with it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29652

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Don't remove the curly braces for simple if statements

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Nathaniel Graham]

ngraham added a comment.


  In D29024#668383 , @romangg wrote:
  
  > Note that I need to have this plugin system or something similar in for 
5.19 or I will be forced to fork libkscreen permanently for KWinFT. I would 
like to avoid this and instead continue my work on libkscreen as a KDE project 
like I have worked on it in the last two years.
  
  
  Nobody's forcing you to do anything.
  
  Note that Plasma 5.19 branches in three days and merging huge things like 
this right before branching has bitten us before and I'd like to avoid it if 
possible for 5.19. So if we do go with this patch in something like its current 
form (I have no technical opinions on it whatsoever), I would like it merged in 
after branching for 5.19, not right before.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:00e64bdb3fa9: [applets/systemtray] Show base icon when 
AttentionIcon not set (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29544?vs=82321=82591

REVISION DETAIL
  https://phabricator.kde.org/D29544

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, 
mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Oh I forgot that it was only in 5.19.
  
  We can continue in D29633 , it's better.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29636

To: ngraham, broulik, #plasma, #localization, yurchor
Cc: yurchor, ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29570: Fix some alignments

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> niccolove wrote in PowerManagementItem.qml:34
> It does look a bit too close on the right border in LTS. I guess I should add 
> a rightMargin here?

Noah's point was that this doesn't automatically reverse itself due to a known 
Qt bug. However David recently submitted a patch to fix it, so I think we 
should stop manually working around it, which means this is fine as it is.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixspacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma, ngraham
Cc: ndavis, abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29595: Add gocryptfs support

[Nathaniel Graham]

ngraham added reviewers: ivan, Plasma.
ngraham added a comment.


  Very cool!

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29595

To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29603: Adds custom spacing between task manager icons

[Nathaniel Graham]

ngraham added a comment.


  In D29603#668422 , @martellini 
wrote:
  
  > > Also, it doesn't make sense IMO to expose separate horizontal and 
vertical controls; there should be just one control visible, and it should 
affect the task manager no matter its orientation.
  >
  > If that's the better way I totally agree, but I don't know recall that 
setting. Is there an open issue that I can look into?
  
  
  This thing: F8310217: this thing 
  
  Right now IMO its function is pretty unclear and useless. Adjusting it 
usually doesn't change anything at all, making it look broken. I think we 
should fix this first.
  
  Conceptually, I think by default, the icon size should smoothly scale with 
the panel thickness. Right now it roughly does this, but with hard sizes rather 
than smoothly scaling the icons, as the macOS Dock does. I think that would be 
a better default.
  
  Then, on top of that, we could additionally have the following settings for 
fine-tuning:
  
  - Spacing (narrow or wide)
  - Maximum icon size (or maybe we don't even need this at all?)
  
  How does that sound?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg, ngraham
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

[Jiří Paleček]

jpalecek updated this revision to Diff 82568.
jpalecek added a comment.


  Move the client deregistering code from SensorBrowserModel to HostInfo
  
  Also remove the clear function. After investigating further, I've
  found out it suffers from the same problem, that it doesn't deregister
  from the hosts it removes. On top of that, it leaves dangling pointers
  in mSensorInfoMap. It doesn't really clear all the other internal
  structures. And it is never used. So I think it's best to delete it.

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29616?vs=82486=82568

REVISION DETAIL
  https://phabricator.kde.org/D29616

AFFECTED FILES
  gui/SensorBrowser.cpp
  gui/SensorBrowser.h
  gui/ksysguard.cpp
  gui/ksysguard.h

To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29288: Improve PageRouter API

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:db704d344b2c: Improve PageRouter API (authored by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29288?vs=81555=82567

REVISION DETAIL
  https://phabricator.kde.org/D29288

AFFECTED FILES
  examples/PageRouterWatchedRoute.qml
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D29632: [kcms/keys] Use better collator settings

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidre wrote in shortcutsmodel.cpp:89
> We typically don't have apps with numbers but I can also add it?

Ah, this is for apps, but yeah, why not...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29644: Select application after it is added

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:97
> +id: transition
> +PropertyAnimation {
> +target: components

Sounds like you want `PropertyAction`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  addIndex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29644

To: davidre, broulik, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks
  please phrase the commit message the opposite way. State what the commit 
changes, not what the state was before the commit.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> batterymonitor.qml:61
> +} else {
> +return i18n("Battery charging, currently at %1%", 
> pmSource.data.Battery.Percent)
>  }

Also, just because it's plugged in, doesn't mean it's charging.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29636

To: ngraham, broulik, #plasma, #localization, yurchor
Cc: yurchor, ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  The tooltip logic was completely rewritten in 5.19. This patch does not apply 
to 5.18.
  Also, D29633 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29636

To: ngraham, broulik, #plasma, #localization, yurchor
Cc: yurchor, ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

[Eugene Popov]

epopov created this revision.
epopov added reviewers: ngraham, plasma-devel.
Herald added a project: Plasma.
epopov requested review of this revision.

REVISION SUMMARY
  It would be correct to close the Clipboard applet after clearing the history 
or deleting the last element, since there is nothing more to do with the empty 
Clipboard applet (similar to how the Notification applet closes after the last 
notification is removed).
  
  BUG: 421345

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29652

AFFECTED FILES
  applets/clipboard/contents/ui/clipboard.qml

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:63a6340a711d: Add global shortcut (authored by Guo Yunhe 
i...@guoyunhe.me).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29625?vs=82532=82564

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.desktop

To: guoyunhe, #plasma, mart
Cc: ngraham, davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

[Eugene Popov]

epopov created this revision.
epopov added reviewers: ngraham, plasma-devel.
Herald added a project: Plasma.
epopov requested review of this revision.

REVISION SUMMARY
  When I pin a Notifications applet and then remove all notifications, the 
Notifications applet closes itself.
  
  BUG: 421344

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

AFFECTED FILES
  applets/notifications/package/contents/ui/main.qml

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Superseeded by https://phabricator.kde.org/D29548 since there was no activity 
for >2 months.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27353

To: wstephenson, #plasma, ivan, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29548: Drag and drop assigning windows to activities in the default switcher

[Ivan Čukić]

ivan closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29548

To: ivan, #plasma, mart, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI

[Marco Martin]

mart added a comment.


  Sorry, i don't think it's the right path, for several reasons,
  
  - The spinbox look is different from the desktop one, better or worse is 
secondary, but it's actually a sore point of the plasma theme at the moment :/
  - It exposes very directly pixel numbers in the ui, unless it's a graphic 
application, i hate when it happens in an ui and in our software happens too 
much (and no, no user should ever be asked to know what a pixel is)
  - it keeps the window still when the panel resizes, looking kinda broken, but 
worse, making even possible for the panel to cover up the spinbox itself

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: mart, ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D29637: Introduce ImageColors

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> colorutils.h:182
> +/**
> + * Returns the Cielab "Chroma" of the color which is a slightly better 
> quantificator for how much a color appears 
> https://en.wikipedia.org/wiki/Colorfulness
> + * This is how much a color looks diffenent from a gray of the same

Returns the CIELAB chroma of the given color.
  
  CIELAB chroma may give a better quantification of how vibrant a color is 
compared to HSV saturation.
  
  \sa https://en.wikipedia.org/wiki/Colorfulness
  \sa https://en.wikipedia.org/wiki/CIELAB_color_space

> imagecolors.h:64-70
> + * The source which colors should be analyzed, it can be:
> + * * Any Item: it will be rendered to an image and the static grab 
> + * analyzed. It won't be updated if the item changes, but manual 
> + * calls to update() are needed.
> + * * A QImage (for example coming from a QAbstractItemModel data role)
> + * * A QIcon (for example coming from a QAbstractItemModel data role)
> + * * An icon name: an icon name present in the theme.

The source from which colors should be extracted from.
  `source` can be one of the following:
  * Item
  * QImage
  * QIcon
  * Icon name
  
  Note that an Item's color palette will only be extracted once unless you call 
`update()`, regardless of how the item hanges.

> imagecolors.h:75-82
> + * A list of the color palette extracted from the image.
> + * It uses K-means-clustering tecnique, by averaging groups of
> + * "similar" colors https://en.wikipedia.org/wiki/K-means_clustering
> + * it's a list of maps containing the following keys:
> + * * "color": the color of the cluster
> + * * "ratio": the ratio from 0 to 1 of diffusion of the cluster in the 
> image
> + * * "contrastingColor": another color from the clusters (if possible) 
> that is the nearest to its negative

A list of colors and related information about then.
  
  Each list item has the following properties:
  * `color`: The color of the list item.
  * `ratio`: How dominant the color is in the source image.
  * `contrastingColor`: The color from the source image that's closest to the 
inverse of `color`.
  
  The list is sorted by `ratio`; the first element is the most dominant color 
in the source image and the last element is the least dominant color of the 
image.
  
  \note K-means clustering is used to extract these colors; see 
https://en.wikipedia.org/wiki/K-means_clustering.

> imagecolors.h:86-89
> +/**
> + * If true, it should be considered a "Dark" color palette (this if the 
> dominant color is darker than a 50% gray
> + */
> +Q_PROPERTY(bool isDarkPalette READ isDarkPalette NOTIFY paletteChanged)

I think it would be better to have this return a `ColorUtils::Brightness` enum.

> imagecolors.h:92
> +/**
> + * The average color of the whole image.
> + */

The average color of the source image.

> imagecolors.h:97
> +/**
> + * The dominant color of the image. This is the color of the cluster 
> which covers the bigger area of the image
> + */

The dominant color of the source image.
  
  The dominant color of the image is the color of the largest cluster in the 
image.
  \sa https://en.wikipedia.org/wiki/K-means_clustering

> imagecolors.h:102
> +/**
> + * Suggested "contrasting" color to the dominant one. It's the color in 
> the palette nearest to the negative of the dominant
> + */

The color closest to the inverse of the dominant color found in the source 
image.

> imagecolors.h:107-109
> + * An "accent" color extracted from the image, heuristically found most 
> "vibrant" color from the cluster with highest CIELab Chroma
> + * https://en.wikipedia.org/wiki/Colorfulness#Chroma
> + * which is a better indication than saturation as doesn't decrease with 
> lightness

An accent color extracted from the source image.
  
  The accent color is the color cluster with the highest CIELAB chroma in the 
source image.
  
  \sa https://en.wikipedia.org/wiki/Colorfulness#Chroma

> imagecolors.h:114-116
> + * A color suggested for foreground items over the image
> + * * on dark palettes will be closestToWhite if light enough, or a very 
> light gray otherwise
> + * * on light palettes will be closestToBlack if dark enough or a very 
> dark gray

A color suitable for rendering text and other foreground over the source image.
  
  On dark items, this will be the color closest to white in the image if it's 
light enough, or a bright gray otherwise.
  On light items, this will be the color closest to black in the image if it's 
dark enough, or a dark gray otherwise.

> imagecolors.h:120-124
> +/**
> + * A color suggested for background items over the image, like a dialog 
> frame
> + * * on light palettes will be closestToWhite if light enough, or a very 
> light gray otherwise
> + * * on dark palettes will be closestToBlack if dark enough or a very 
> dark gray
> + 

D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI

[Marco Martin]

mart added a comment.


  -1 :(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: mart, ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D29548: Drag and drop assigning windows to activities in the default switcher

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  What Nate says, after that go for it

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29548

To: ivan, #plasma, mart, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

[Marco Martin]

mart added a comment.


  the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE
  all of them, including those in plasma-framework should be updated at once

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29462

To: Zren, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29644: Select application after it is added

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  After adding an application, an user will probably want to edit shortcuts for 
  the new application. Having to select it again is cumbersome.

TEST PLAN
  Add an application.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  addIndex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29644

AFFECTED FILES
  kcms/keys/package/contents/ui/main.qml

To: davidre, broulik, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Yuri Chornoivan]

yurchor accepted this revision as: yurchor.
yurchor added a comment.
This revision is now accepted and ready to land.


  Thanks. No objections for porting this into a stable translation branch from 
the Ukrainian team.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-non-updating-battery-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29636

To: ngraham, broulik, #plasma, #localization, yurchor
Cc: yurchor, ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Luigi Toscano]

ltoscano added a comment.


  Adding a few more details to make it easier to decide on the localization 
side:
  
  - Plasma 5.18 is the new LTS
  - its next releases (5.18.6) is currently planned for September 17th, 2020.
  
  I'd say there is enough time to fix this translation, and having the correct 
information about the charging status of the battery is important enough to 
have the fix in the LTS branch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29636

To: ngraham, broulik, #plasma, #localization
Cc: ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29637: Introduce ImageColors

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> imagecolorstest.qml:1
> +
> +import QtQuick 2.12

There's no test cases here, this should probably go in examples.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29637

To: mart, #kirigami
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29632: [kcms/keys] Use better collator settings

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> shortcutsmodel.cpp:89
>  QCollator collator;
> +collator.setCaseSensitivity(Qt::CaseInsensitive);
>  std::sort(m_components.begin(), m_components.end(), 
> [&](const Component , const Component ){

We typically don't have apps with numbers but I can also add it?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29637: Introduce ImageColors

[Marco Martin]

mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  ImageColors is a class to extract color statistics out of an image. it 
supports 
  as source :
  
  - Grabbing a static frame out of any Item
  - A QImage or a QIcon (for instance coming from a QAbstractItemModel
  - An icon name from the theme
  
  By a pixel-by pixel analisys it uses a K-means clustering algorythm 
  https://en.wikipedia.org/wiki/K-means_clustering
  that groups averages of colors group that have a computed "distance" less 
than an 
  arbitrary value and so extracts a palette of the "dominant" colors of the 
image,
  having also other imformations such as the % occurrence of each cluster, a 
  complementary color for each cluster, the global average color, the most 
  "vibrant" color of the image, usable as an accent, and good colors for text 
and 
  background, based on the extracted palette

REPOSITORY
  R169 Kirigami

BRANCH
  mart/imageColors

REVISION DETAIL
  https://phabricator.kde.org/D29637

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/imagecolors.cpp
  src/imagecolors.h
  src/kirigamiplugin.cpp
  tests/imagecolorstest.qml

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29632: [kcms/keys] Use better collator settings

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> shortcutsmodel.cpp:89
>  QCollator collator;
> +collator.setCaseSensitivity(Qt::CaseInsensitive);
>  std::sort(m_components.begin(), m_components.end(), 
> [&](const Component , const Component ){

Why no numeric mode here?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29603: Adds custom spacing between task manager icons

[Jacopo Martellini]

martellini added a comment.


  In D29603#668283 , @niccolove 
wrote:
  
  > Are we really sure this is worth exposing to the user?
  
  
  Not sure at all. I just can't stand the default spacing, because it feels 
like the icons are crammed. At least if compared with Win10 or Gnome with dash 
to panel.
  
  In D29603#668297 , @ngraham wrote:
  
  > I think it would make more sense to fix the default sizing behavior rather 
than adding these. We already have an "icon size" setting which roughly adjusts 
this already, just not very well. That should be fixed rather than adding 
additional user-facing settings, or at least before doing so.
  >
  > Also, it doesn't make sense IMO to expose separate horizontal and vertical 
controls; there should be just one control visible, and it should affect the 
task manager no matter its orientation.
  
  
  If that's the better way I totally agree, but I don't know recall that 
setting. Is there an open issue that I can look into?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg, ngraham
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, Plasma, Localization.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Current code only updates the text on the "not charging" condition, causing 
the tooltip
  display to get out of sync with the rest of the applet once charging begins. 
This patch
  fixes that.
  
  This is a bugfix for a bug that affects Plasma 5.18, but fixing it requires 
introducing a
  new string. As such, I am targeting 5.19, but if the #Localization 
 team approves, I can
  land this on the stable branch if it's accepted.
  
  BUG: 20920
  FIXED-IN: 5.19.0

TEST PLAN
  F8309775: tooltip updates now.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-non-updating-battery-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29636

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: ngraham, broulik, #plasma, #localization
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  It could make sense to leverage QCollatorSortKey in this class if it's 
sorting often.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

[Jiří Paleček]

jpalecek added inline comments.

INLINE COMMENTS

> ahiemstra wrote in SensorBrowser.cpp:53
> I agree with Anthony though, if you delete a hostInfo it _should_ remove its 
> connection. So it's better to move this code into a destructor for HostInfo.

But the host info, at least in its present form, doesn't have the client 
pointer to pass to `disconnectClient`. But I can see your point, I will change 
it.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29616

To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

[Arjen Hiemstra]

ahiemstra requested changes to this revision.
ahiemstra added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jpalecek wrote in SensorBrowser.cpp:53
> No, it only deletes the HostInfo structure. See the source 
> .
>  It doesn't disconnect anything. Nor does deleting `this`, as the Agent holds 
> the client as a bare pointer, it can't know that it ceased to exist. It isn't 
> even a `QPointer` (probably bc. `SensorClient` isn't a `QObject`).

I agree with Anthony though, if you delete a hostInfo it _should_ remove its 
connection. So it's better to move this code into a destructor for HostInfo.

> ksysguard.cpp:153
> +{
> +  if (KSGRD::SensorMgr) KSGRD::SensorMgr->disconnectClient(this);
> +}

Coding style: Single line ifs still need braces and should not be on a single 
line.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29616

To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29635: [kcms/keys] Make saving sync

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  If it's async it will not save when changing modules, or quitting kcmshell, 
see T13140 .
  BUG: 421333

TEST PLAN
  Make a change, change module in systemsettings. Changes are saved.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  syncSave (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29635

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg added a comment.


  These are not specific issues but some general complains about the overall 
concept chosen here without providing an alternative solution.
  
  I chose this plugin system because it allows robust extension to the current 
system. Plugins are well contained and reuse already existing infrastructure. 
Besides moving the code around there are practically no logic changes to the 
KWayland backend.
  
  Note that I need to have this plugin system or something similar in for 5.19 
or I will be forced to fork libkscreen permanently for KWinFT. I would like to 
omit this and instead continue my work on libkscreen as a KDE project like I 
have worked on it in the last two years.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Fix POTD in lock screen (partly)

[Yunhe Guo]

guoyunhe added a comment.


  I was looking for kded documentation but cannot find a good example. Do you 
know any?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:01776488ab8b: KCM/Autostart Add a model to separate logic 
from UI (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26934?vs=80200=82533

REVISION DETAIL
  https://phabricator.kde.org/D26934

AFFECTED FILES
  kcms/autostart/CMakeLists.txt
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.h
  kcms/autostart/autostartitem.cpp
  kcms/autostart/autostartitem.h
  kcms/autostart/autostartmodel.cpp
  kcms/autostart/autostartmodel.h

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[Yunhe Guo]

guoyunhe updated this revision to Diff 82532.
guoyunhe added a comment.


  Create symlink

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29625?vs=82515=82532

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.desktop

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Luigi Toscano]

ltoscano added a comment.


  Technically kcm should be called kcm_. So far the 
Plasma_version part has been ignored, but at least kcm_ should be there.
  
  I'm not sure about the lack of the button.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D27203: Don't try to open files we can't figure out where they are

[Méven Car]

meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:226
> +//passing non-local files as the working directory is not supported.
> +//See QFileDialogPrivate::initialSelections
> +//Selectingg files should be done through the correct method.

QFileDialogPrivate::initialSelection

> kdeplatformfiledialoghelper.cpp:227
> +//See QFileDialogPrivate::initialSelections
> +//Selectingg files should be done through the correct method.
> +m_fileWidget->setUrl(directory);

typo Selectingg

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Yuri Chornoivan]

yurchor added a subscriber: ltoscano.
yurchor added a comment.


  Please do not get me wrong (I'm fine with the new designs and updating the 
code and this new KCM is very good), but it would be good to hear some words 
from @ltoscano on the catalog (and KCM) naming.
  
  It is also evident that all the new KCMs do not have the "Help" button. Is it 
the new policy?
  
  Thanks in advance for your comments.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29633: [Battery Monitor] Fix toolTipMainText when plugged in

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It only had a return value for "NoCharge" since the else case was only for 
not plugged in, resulting in it effectively returning `undefined`, throwing 
during assignment "cannot assign [undefined] to string" and leaving whatever 
text happened to be shown last.

TEST PLAN
  Literally none

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29633

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: broulik, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: Use better collator settings

[David Redondo]

davidre created this revision.
davidre added reviewers: ognarb, broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ognarb, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[David Edmundson]

davidedmundson added a comment.


  It's still got this pointless plugin within plugin situation.
  
  > For that at least one Wayland event loop has to be launched
  
  It needs a roundrip after the registry is fetched. That doesn't need an event 
loop.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27203: Don't try to open files we can't figure out where they are

[Nathaniel Graham]

ngraham added a comment.


  Does this fix https://bugs.kde.org/show_bug.cgi?id=408174?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29548: Drag and drop assigning windows to activities in the default switcher

[Nathaniel Graham]

ngraham added a comment.


  So cool! Can you make the activity that the window is being dragged into 
highlight or otherwise somehow provide a visual indication that it's going to 
accept the drop?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29548

To: ivan, #plasma, mart, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

[Jiří Paleček]

jpalecek added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in SensorBrowser.cpp:53
> When you delete the map content, all agents should loose their connections, 
> no?

No, it only deletes the HostInfo structure. See the source 
.
 It doesn't disconnect anything. Nor does deleting `this`, as the Agent holds 
the client as a bare pointer, it can't know that it ceased to exist. It isn't 
even a `QPointer` (probably bc. `SensorClient` isn't a `QObject`).

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29616

To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29603: Adds custom spacing between task manager icons

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I think it would make more sense to fix the default sizing behavior rather 
than adding these. We already have an "icon size" setting which roughly adjusts 
this already, just not very well. That should be fixed rather than adding 
additional user-facing settings, or at least before doing so.
  
  Also, it doesn't make sense IMO to expose separate horizontal and vertical 
controls; there should be just one control visible, and it should affect the 
task manager no matter its orientation.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg, ngraham
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29626: Fix Warning about KF5::ProcessCore target being deprecated

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:baa168ede063: Fix Warning about KF5::ProcessCore target 
being deprecated (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29626?vs=82518=82524

REVISION DETAIL
  https://phabricator.kde.org/D29626

AFFECTED FILES
  CMakeLists.txt
  applets/taskmanager/CMakeLists.txt

To: meven, #plasma, ahiemstra
Cc: ahiemstra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29623: Fix Warning about KF5::KSysGuard target being deprecated

[Méven Car]

meven added a comment.


  Improved by D29628 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29623

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29603: Adds custom spacing between task manager icons

[Niccolò Venerandi]

niccolove added a comment.


  Are we really sure this is worth exposing to the user?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg
Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 104 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/104/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 11 May 2020 12:48:21 +
 Build duration:
7 min 7 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29570: Fix some alignments

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> ndavis wrote in PowerManagementItem.qml:34
> How does this affect RTL layouts?

It does look a bit too close on the right border in LTS. I guess I should add a 
rightMargin here?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixspacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma, ngraham
Cc: ndavis, abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29630: Use the new KSysGuard namespace for KSysGuard related targets

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  The targets in the KF5 namespace have been deprecated. This updates the
  cmake files to use the new targets.

TEST PLAN
  Builds correctly with most recent libksysguard.

REPOSITORY
  R845 Plasma Vault

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29630

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8ae9b561c82f: Use the right targets for KSysGuard 
(authored by ahiemstra).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29628?vs=82516=82522

REVISION DETAIL
  https://phabricator.kde.org/D29628

AFFECTED FILES
  CMakeLists.txt
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/systemmonitor/CMakeLists.txt
  runners/kill/CMakeLists.txt
  systemmonitor/CMakeLists.txt

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 103 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/103/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 11 May 2020 12:45:11 +
 Build duration:
2 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 546 lines...][2020-05-11T12:47:10.840Z]  * KF5DocTools (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5KDELibs4Support (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5Crash (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5GlobalAccel (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5DBusAddons (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5Wayland (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5People (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5ActivitiesStats (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KDED[2020-05-11T12:47:10.840Z]  * KF5Plasma (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5PlasmaQuick[2020-05-11T12:47:10.840Z]  * ECM (required version >= 1.6.0)[2020-05-11T12:47:10.840Z]  * KF5Package[2020-05-11T12:47:10.840Z]  * KF5[2020-05-11T12:47:10.840Z]  * Qt5Network (required version >= 5.12.0)[2020-05-11T12:47:10.840Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-05-11T12:47:10.840Z]  * Gettext[2020-05-11T12:47:10.840Z]  * KF5I18n (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5TextWidgets (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KF5CoreAddons (required version >= 5.70.0)[2020-05-11T12:47:10.840Z]  * KWinDBusInterface[2020-05-11T12:47:10.840Z]  * KF5Screen[2020-05-11T12:47:10.840Z]  * KScreenLocker (required version >= 5.13.80)[2020-05-11T12:47:10.840Z]  * ScreenSaverDBusInterface[2020-05-11T12:47:10.840Z]  * ZLIB, Support for gzip compressed files and data streams, [2020-05-11T12:47:10.840Z]  * Qt5X11Extras[2020-05-11T12:47:10.840Z]  * Qt5Gui (required version >= 5.12.0)[2020-05-11T12:47:10.840Z]  * Qt5Sql[2020-05-11T12:47:10.840Z]  * Qt5[2020-05-11T12:47:10.840Z]  * Qt5Core[2020-05-11T12:47:10.840Z]  * Qt5Widgets[2020-05-11T12:47:10.840Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2020-05-11T12:47:10.840Z]  * XCB, X protocol C-language Binding, [2020-05-11T12:47:10.840Z]Required for enabling special X11 multihead mode[2020-05-11T12:47:10.840Z] [2020-05-11T12:47:10.840Z] -- The following RUNTIME packages have not been found:[2020-05-11T12:47:10.840Z] [2020-05-11T12:47:10.840Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2020-05-11T12:47:10.840Z] [2020-05-11T12:47:10.840Z] -- The following OPTIONAL packages have not been found:[2020-05-11T12:47:10.840Z] [2020-05-11T12:47:10.840Z]  * KF5NetworkManagerQt (required version >= 5.70.0), Qt wrapper for NetworkManager API[2020-05-11T12:47:10.840Z]Needed by geolocation data engine.[2020-05-11T12:47:10.840Z]  * AppStreamQt (required version >= 0.10.6), Access metadata for listing available software, [2020-05-11T12:47:10.840Z]  * Qalculate, Qalculate Library, [2020-05-11T12:47:10.840Z]Needed to enable advanced features of the calculator runner[2020-05-11T12:47:10.840Z] [2020-05-11T12:47:11.409Z] -- Configuring done[2020-05-11T12:47:11.669Z] CMake Error at systemmonitor/CMakeLists.txt:22 (add_executable):[2020-05-11T12:47:11.669Z]   Target "systemmonitor" links to target "KF5::ProcessUi" but the target was[2020-05-11T12:47:11.669Z]   not found.  Perhaps a find_package() call is missing for an IMPORTED[2020-05-11T12:47:11.669Z]   target, or an ALIAS target is missing?[2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] CMake Error at runners/kill/CMakeLists.txt:22 (add_library):[2020-05-11T12:47:11.669Z]   Target "krunner_kill" links to target "KF5::ProcessCore" but the target was[2020-05-11T12:47:11.669Z]   not found.  Perhaps a find_package() call is missing for an IMPORTED[2020-05-11T12:47:11.669Z]   target, or an ALIAS target is missing?[2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] CMake Error at applets/systemmonitor/systemmonitor/CMakeLists.txt:5 (add_library):[2020-05-11T12:47:11.669Z]   Target "plasma_applet_systemmonitor" links to target "KF5::SysGuard" but[2020-05-11T12:47:11.669Z]   the target was not found.  Perhaps a find_package() call is missing for an[2020-05-11T12:47:11.669Z]   IMPORTED target, or an ALIAS target is missing?[2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] CMake Error at applets/systemmonitor/systemmonitor/CMakeLists.txt:5 (add_library):[2020-05-11T12:47:11.669Z]   Target "plasma_applet_systemmonitor" links to target "KF5::Sensors" but the[2020-05-11T12:47:11.669Z]   target was not found.  Perhaps a find_package() call is missing for an[2020-05-11T12:47:11.669Z]   IMPORTED target, or an ALIAS target is missing?[2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] [2020-05-11T12:47:11.669Z] CMake Error at 

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 90 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/90/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 11 May 2020 12:45:11 +
 Build duration:
2 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 539 lines...][2020-05-11T12:47:19.594Z]  * KF5KDELibs4Support (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5Crash (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5GlobalAccel (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5DBusAddons (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5Wayland (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5People (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5ActivitiesStats (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KDED[2020-05-11T12:47:19.594Z]  * KF5Plasma (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5PlasmaQuick[2020-05-11T12:47:19.594Z]  * ECM (required version >= 1.6.0)[2020-05-11T12:47:19.594Z]  * KF5Package[2020-05-11T12:47:19.594Z]  * KF5[2020-05-11T12:47:19.594Z]  * Qt5Network (required version >= 5.12.0)[2020-05-11T12:47:19.594Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-05-11T12:47:19.594Z]  * Gettext[2020-05-11T12:47:19.594Z]  * KF5I18n (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5TextWidgets (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KF5CoreAddons (required version >= 5.70.0)[2020-05-11T12:47:19.594Z]  * KWinDBusInterface[2020-05-11T12:47:19.594Z]  * KF5Screen[2020-05-11T12:47:19.594Z]  * KScreenLocker (required version >= 5.13.80)[2020-05-11T12:47:19.594Z]  * ScreenSaverDBusInterface[2020-05-11T12:47:19.594Z]  * ZLIB, Support for gzip compressed files and data streams, [2020-05-11T12:47:19.594Z]  * Qt5X11Extras[2020-05-11T12:47:19.594Z]  * Qt5Gui (required version >= 5.12.0)[2020-05-11T12:47:19.594Z]  * Qt5Sql[2020-05-11T12:47:19.594Z]  * Qt5[2020-05-11T12:47:19.594Z]  * Qt5Core[2020-05-11T12:47:19.594Z]  * Qt5Widgets[2020-05-11T12:47:19.594Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2020-05-11T12:47:19.594Z]  * XCB, X protocol C-language Binding, [2020-05-11T12:47:19.594Z]Required for enabling special X11 multihead mode[2020-05-11T12:47:19.594Z] [2020-05-11T12:47:19.594Z] -- The following RUNTIME packages have not been found:[2020-05-11T12:47:19.594Z] [2020-05-11T12:47:19.594Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2020-05-11T12:47:19.594Z]  * IsoCodes, ISO language, territory, currency, script codes and their translations, [2020-05-11T12:47:19.594Z]Translation of country names in digital clock applet[2020-05-11T12:47:19.594Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2020-05-11T12:47:19.594Z] [2020-05-11T12:47:19.594Z] -- The following OPTIONAL packages have not been found:[2020-05-11T12:47:19.594Z] [2020-05-11T12:47:19.594Z]  * Qalculate, Qalculate Library, [2020-05-11T12:47:19.594Z]Needed to enable advanced features of the calculator runner[2020-05-11T12:47:19.594Z]  * libgps, GPS support for geolocation, [2020-05-11T12:47:19.594Z] [2020-05-11T12:47:19.852Z] -- Configuring done[2020-05-11T12:47:20.109Z] CMake Error at systemmonitor/CMakeLists.txt:22 (add_executable):[2020-05-11T12:47:20.109Z]   Target "systemmonitor" links to target "KF5::ProcessUi" but the target was[2020-05-11T12:47:20.109Z]   not found.  Perhaps a find_package() call is missing for an IMPORTED[2020-05-11T12:47:20.109Z]   target, or an ALIAS target is missing?[2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] CMake Error at runners/kill/CMakeLists.txt:22 (add_library):[2020-05-11T12:47:20.109Z]   Target "krunner_kill" links to target "KF5::ProcessCore" but the target was[2020-05-11T12:47:20.109Z]   not found.  Perhaps a find_package() call is missing for an IMPORTED[2020-05-11T12:47:20.109Z]   target, or an ALIAS target is missing?[2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] CMake Error at applets/systemmonitor/systemmonitor/CMakeLists.txt:5 (add_library):[2020-05-11T12:47:20.109Z]   Target "plasma_applet_systemmonitor" links to target "KF5::SysGuard" but[2020-05-11T12:47:20.109Z]   the target was not found.  Perhaps a find_package() call is missing for an[2020-05-11T12:47:20.109Z]   IMPORTED target, or an ALIAS target is missing?[2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] CMake Error at applets/systemmonitor/systemmonitor/CMakeLists.txt:5 (add_library):[2020-05-11T12:47:20.109Z]   Target "plasma_applet_systemmonitor" links to target "KF5::Sensors" but the[2020-05-11T12:47:20.109Z]   target was not found.  Perhaps a find_package() call is missing for an[2020-05-11T12:47:20.109Z]   IMPORTED target, or an ALIAS target is missing?[2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] [2020-05-11T12:47:20.109Z] CMake Error at 

D29619: Improve StatusNotifierTest

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5459a533974e: Improve StatusNotifierTest (authored by 
davidre).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29619?vs=82491=82521

REVISION DETAIL
  https://phabricator.kde.org/D29619

AFFECTED FILES
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui

To: davidre, kmaterka, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 82519.
davidre added a comment.


  - fix

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=82492=82519

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Méven Car]

meven added a comment.


  Related fix in `plasma-desktop` https://phabricator.kde.org/D29626

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29628

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

[Méven Car]

meven updated this revision to Diff 82518.
meven added a comment.


  Update root CMakeLists.txt

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29626?vs=82509=82518

BRANCH
  arcpatch-D29626

REVISION DETAIL
  https://phabricator.kde.org/D29626

AFFECTED FILES
  CMakeLists.txt
  applets/taskmanager/CMakeLists.txt

To: meven, #plasma, ahiemstra
Cc: ahiemstra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29628: Use the right targets for KSysGuard

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29628

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82516.
ahiemstra added a comment.


  - Also change system monitor plasmoid

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29628?vs=82513=82516

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29628

AFFECTED FILES
  CMakeLists.txt
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/systemmonitor/CMakeLists.txt
  runners/kill/CMakeLists.txt
  systemmonitor/CMakeLists.txt

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Méven Car]

meven added a comment.


  ANd `KSysGuard::Sensors` `KSysGuard::SensorFaces` in 
`applets/systemmonitor/systemmonitor/CMakeLists.txt`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29628

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Méven Car]

meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  It miss a KSysGuard::ProcessCore in 
`applets/systemmonitor/systemmonitor/CMakeLists.txt`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29628

To: ahiemstra, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

[Arjen Hiemstra]

ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.


  You need to change `find_package(KF5 REQUIRED COMPONENTS SysGuard)` to 
`find_package(KSysGuard CONFIG REQUIRED)` in the root CMakeLists file.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29626

To: meven, #plasma, ahiemstra
Cc: ahiemstra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Cyril Rossi]

crossi added a comment.


  In D28662#664211 , @heikobecker 
wrote:
  
  > This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also 
fails on build.kde.org for a while, e.g.:
  >
  >   14:11:19  FAIL!  : KcmTest::testKCMSave() Compared values are not the same
  >   14:11:19 Actual   (cg.readEntry("widgetStyle", QString())): ""
  >   14:11:19 Expected (QString("testValue"))  : 
"testValue"
  >   14:11:19 Loc: 
[/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 
SUSEQt5.14/kcms/lookandfeel/autotests/kcmtest.cpp(185)]
  >  
  >
  >
  > 
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/23/console
  
  
  I will have a look at this test case. Thanks for reporting this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28662

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: heikobecker, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[Yunhe Guo]

guoyunhe updated this revision to Diff 82515.
guoyunhe added a comment.


  Use KGlobalAccel instead

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29625?vs=82508=82515

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.desktop

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

[Konrad Materka]

kmaterka added a comment.


  Can we have it reviewed before 5.19 release?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29544

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[David Redondo]

davidre added a comment.


  In D29625#668203 , @davidre wrote:
  
  > -1 for khotkeys.
  
  
  Add `X-KDE-Shortcuts`  to the desktop file instead and instal it to 
share/kglobalaccel

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[David Redondo]

davidre added a comment.


  -1 for khotkeys.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[Yunhe Guo]

guoyunhe added a comment.


  In D29625#668190 , @ognarb wrote:
  
  > I think khotkeys is deprecated: https://phabricator.kde.org/T2050
  
  
  Not yet, it is delayed to KF6.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29628: Use the right targets for KSysGuard

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Otherwise the build fails when things try to link to KF5::SysGuard etc.

TEST PLAN
  Builds again

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksysguard_targets

REVISION DETAIL
  https://phabricator.kde.org/D29628

AFFECTED FILES
  CMakeLists.txt
  dataengines/devicenotifications/CMakeLists.txt
  dataengines/systemmonitor/CMakeLists.txt
  runners/kill/CMakeLists.txt
  systemmonitor/CMakeLists.txt

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[Carl Schwan]

ognarb added a comment.


  I think khotkeys is deprecated: https://phabricator.kde.org/T2050

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

[Roman Gilg]

romangg added a comment.


  Since this has now the structure with exported headers as requested in 
D29028#653150  and D29028#654526 
 I'll push later today if there are 
no more specific issues pointed out in regards to the code.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

[Méven Car]

meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29626

AFFECTED FILES
  applets/taskmanager/CMakeLists.txt

To: meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The "Tools" key is function key in some laptops. In ThinkPad + Windows, when 
you press that key, it will open Control Panel or Windows 10 Settings. But in 
Linux, it does nothing. So I think it can be a good shortcut for System 
Settings because no other software use it.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.khotkeys

To: guoyunhe
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29623: Fix Warning about KF5::KSysGuard target being deprecated

[Arjen Hiemstra]

ahiemstra added a comment.


  Uh, I'm not sure how this fixes anything? It'll remove the warning but it 
means anything using the previous KF5:: namespaced targets is now broken. So 
this at least needs a follow up to change those usages.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29623

To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart closed this revision.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 89 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/89/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 11 May 2020 11:09:31 +
 Build duration:
2 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 539 lines...][2020-05-11T11:11:34.231Z]  * KF5KDELibs4Support (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5Crash (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5GlobalAccel (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5DBusAddons (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5Wayland (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5People (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5ActivitiesStats (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KDED[2020-05-11T11:11:34.231Z]  * KF5Plasma (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5PlasmaQuick[2020-05-11T11:11:34.231Z]  * ECM (required version >= 1.6.0)[2020-05-11T11:11:34.231Z]  * KF5Package[2020-05-11T11:11:34.231Z]  * KF5[2020-05-11T11:11:34.231Z]  * Qt5Network (required version >= 5.12.0)[2020-05-11T11:11:34.231Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-05-11T11:11:34.231Z]  * Gettext[2020-05-11T11:11:34.231Z]  * KF5I18n (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5TextWidgets (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KF5CoreAddons (required version >= 5.70.0)[2020-05-11T11:11:34.231Z]  * KWinDBusInterface[2020-05-11T11:11:34.231Z]  * KF5Screen[2020-05-11T11:11:34.231Z]  * KScreenLocker (required version >= 5.13.80)[2020-05-11T11:11:34.231Z]  * ScreenSaverDBusInterface[2020-05-11T11:11:34.231Z]  * ZLIB, Support for gzip compressed files and data streams, [2020-05-11T11:11:34.231Z]  * Qt5X11Extras[2020-05-11T11:11:34.231Z]  * Qt5Gui (required version >= 5.12.0)[2020-05-11T11:11:34.231Z]  * Qt5Sql[2020-05-11T11:11:34.231Z]  * Qt5[2020-05-11T11:11:34.231Z]  * Qt5Core[2020-05-11T11:11:34.231Z]  * Qt5Widgets[2020-05-11T11:11:34.231Z]  * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library[2020-05-11T11:11:34.231Z]  * XCB, X protocol C-language Binding, [2020-05-11T11:11:34.231Z]Required for enabling special X11 multihead mode[2020-05-11T11:11:34.231Z] [2020-05-11T11:11:34.231Z] -- The following RUNTIME packages have not been found:[2020-05-11T11:11:34.231Z] [2020-05-11T11:11:34.231Z]  * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.[2020-05-11T11:11:34.231Z]  * IsoCodes, ISO language, territory, currency, script codes and their translations, [2020-05-11T11:11:34.231Z]Translation of country names in digital clock applet[2020-05-11T11:11:34.231Z]  * AppMenuGtkModule, Application Menu GTK+ Module, [2020-05-11T11:11:34.231Z] [2020-05-11T11:11:34.231Z] -- The following OPTIONAL packages have not been found:[2020-05-11T11:11:34.231Z] [2020-05-11T11:11:34.231Z]  * Qalculate, Qalculate Library, [2020-05-11T11:11:34.231Z]Needed to enable advanced features of the calculator runner[2020-05-11T11:11:34.231Z]  * libgps, GPS support for geolocation, [2020-05-11T11:11:34.231Z] [2020-05-11T11:11:35.166Z] -- Configuring done[2020-05-11T11:11:35.730Z] CMake Error at systemmonitor/CMakeLists.txt:22 (add_executable):[2020-05-11T11:11:35.730Z]   Target "systemmonitor" links to target "KF5::ProcessUi" but the target was[2020-05-11T11:11:35.730Z]   not found.  Perhaps a find_package() call is missing for an IMPORTED[2020-05-11T11:11:35.730Z]   target, or an ALIAS target is missing?[2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] CMake Error at runners/kill/CMakeLists.txt:22 (add_library):[2020-05-11T11:11:35.730Z]   Target "krunner_kill" links to target "KF5::ProcessCore" but the target was[2020-05-11T11:11:35.730Z]   not found.  Perhaps a find_package() call is missing for an IMPORTED[2020-05-11T11:11:35.730Z]   target, or an ALIAS target is missing?[2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] CMake Error at applets/systemmonitor/systemmonitor/CMakeLists.txt:5 (add_library):[2020-05-11T11:11:35.730Z]   Target "plasma_applet_systemmonitor" links to target "KF5::SysGuard" but[2020-05-11T11:11:35.730Z]   the target was not found.  Perhaps a find_package() call is missing for an[2020-05-11T11:11:35.730Z]   IMPORTED target, or an ALIAS target is missing?[2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] CMake Error at applets/systemmonitor/systemmonitor/CMakeLists.txt:5 (add_library):[2020-05-11T11:11:35.730Z]   Target "plasma_applet_systemmonitor" links to target "KF5::Sensors" but the[2020-05-11T11:11:35.730Z]   target was not found.  Perhaps a find_package() call is missing for an[2020-05-11T11:11:35.730Z]   IMPORTED target, or an ALIAS target is missing?[2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] [2020-05-11T11:11:35.730Z] CMake Error at