D29807: WIP: Change Chrome API design

2020-05-17 Thread Alexander Lohnau 
alex updated this revision to Diff 83029.
alex marked an inline comment as done.
alex added a comment.


  Create test cases

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83028=83029

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/CMakeLists.txt
  runners/bookmarks/tests/chrome-config-home/.config/chromium/Local State
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json
  runners/bookmarks/tests/chromium/Default/Bookmarks
  runners/bookmarks/tests/chromium/Local State
  runners/bookmarks/tests/chromium/Profile 1/Bookmarks
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29781: Fix importing key-direction from *.ovpn files

2020-05-17 Thread Johan Ouwerkerk 
ouwerkerk abandoned this revision.
ouwerkerk added a comment.


  With the move to gitlab/invent.kde.org it seems better to abandon this in 
favour of a straightforward MR using the new shiny :) 
  See: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/1

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29781

To: ouwerkerk, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: WIP: Change Chrome API design

2020-05-17 Thread Alexander Lohnau 
alex updated this revision to Diff 83028.
alex added a comment.


  Make constructor private

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83019=83028

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still unstable!

2020-05-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 17 May 2020 17:05:57 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

2020-05-17 Thread David Korth 
dkorth created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dkorth requested review of this revision.

REVISION SUMMARY
  std::regex is slow, so use fixed-field parsing instead.
  
  This is an initial version that I've been using for a while with no major 
issues, though it might still need some improvements. CPU usage is 
significantly decreased compared to before when there is a lot of network 
activity.

TEST PLAN
  Run programs that generate a lot of network activity.
  Verify the network activity shows up correctly with this patch.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29808

AFFECTED FILES
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/ConnectionMapping.h

To: dkorth
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.14 - Build # 9 - Still unstable!

2020-05-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.14/9/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 17 May 2020 17:05:57 +
 Build duration:
7 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(492/2595)14%
(211/1511)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/165)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(284/1248)20%
(135/662)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/259)0%
(0/138)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/229)0%
(0/176)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D28154: Add users KCM

2020-05-17 Thread Nathaniel Graham 
ngraham added a comment.


  Now that D29394  has landed, you can add 
those images here!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29807: WIP: Change Chrome API design

2020-05-17 Thread Anthony Fieroni 
anthonyfieroni added reviewers: broulik, Plasma.
anthonyfieroni added a comment.


  Commented code should be removed.

INLINE COMMENTS

> chromeprofile.h:11
> +public:
> +ProfileBookmarks(const QString , const QString );
> +static QList findAllProfiles(const QString 
> );

You can move contructor to private section, that will make all things clear, 
`findAllProfiles` should be the only one allowed creator.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29807

To: alex, broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: WIP: Change Chrome API design

2020-05-17 Thread Alexander Lohnau 
alex created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  - The FindProfile class was only for Chrome implemented => removed
  - Having ProfileBookmarks and Profile class is unnecessary, especially 
because they are only needed for Chrome
  - Better error handling
  
  TODO: Adjust tests for chrome
  Have a second look at the changes ;-)

TEST PLAN
  Should work as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-17 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 83017.
ahmadsamir added a comment.


  Remove one include

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29687?vs=82943=83017

BRANCH
  l-krun-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29687

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: ahmadsamir, #plasma, broulik, dfaure
Cc: dfaure, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-17 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> iconapplet.cpp:52
>  #include 
> +#include 
>  #include 

You're not using that class, are you?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik, dfaure
Cc: dfaure, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

2020-05-17 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.


  KServiceFactory::findServiceByStorageId falls back to "new KService" if it 
can't find the storageId in ksycoca. So yes it worked, but it's kind of 
pointless (and confusing) to call it just to go to the new KService fallback, 
better do that directly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik, dfaure
Cc: dfaure, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

2020-05-17 Thread Alexander Lohnau 
alex added a comment.


  Friendly Ping @bruns or may I land this already ?
  And should this land on `Plasma/5.19`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29326

To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart