D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Carl Schwan]

ognarb added a comment.


  I rebased this merge request on top of master and moved it to gitlab. 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/37
  
  I see a major problem to move forward with this patch, not all the files have 
a license header and as such can't be merged. @gpark do you agree with me using 
your work under the GPL-2.0-or-later license?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: ognarb, davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham, apol, 
plasma-devel, hein, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D19444: Make long menus optionally scrollable instead of always expanding horizontally

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Doesn't seem like there's interest in this.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19444

To: ngraham, #breeze, broulik
Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28321: [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28321: [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  I'd like to land this early in the 5.20 cycle so we have lots of time for 
testing, if possible.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28321

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[David Redondo]

davidre added a comment.


  In my testing dragging a window to a screen with a different scalefactor has 
no issue and @apol said for him it's better than the status quo. So I  would 
like to land this

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Show POTD in lock screen

[Yunhe Guo]

guoyunhe added a comment.


  Also in KDE Invent. 
https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/3
  
  Can someone review it?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

sprint notes for 12/06/2020

[Marco Martin]

Convertible and Mobile: Topics

Touch gestures usage in shell

Implementation should mostly inside KWin ideally

Currently possibly we have gestures like edge gestures in wayland

Currently we use plasmashell side gestures

Action point: research into having kwin effects API for gestures

Are effects right place for this functionality?

https://bugs.kde.org/show_bug.cgi?id=402859

https://invent.kde.org/plasma/kwin/-/merge_requests/19

https://invent.kde.org/plasma/kwin/-/merge_requests/16

Action point: possibly VDG looks into interaction patterns? Some example:

Window switcher

Switching Virtual Desktops

Edge swipe is super broken, replace it?

TODO Marco will write what he needs for plasma mobile

not possible to do animations that "follow fingers" which is an
important usability problem
https://bugs.kde.org/show_bug.cgi?id=402859

sometimes we want actual kwin effects to be partly activated based
on fingers, kike the tabbox, present windows, switch desktops

effects should be controllable to say "trigger at 12%"the screen
edge effect would then control "how much" of that effect is triggered
to give the follow finger appearance

sometimes we want the shell to do things on edge swipe instead:
there could also be an api from kwin (either dbus or wayland protocol)
that tells the client the finger position

would maybe also be needed some protocol for when an app wants a
screen edge for itself (valid for an hypotetical all maximized windows
tablet mode)

TODO VDG should consider what's needed as well

Tablet mode is "broken" for lot of laptops due to lack of kernel support

We should talk to upstream about broken devices

Action point: figure out what to do when in tablet mode

TODO Niccolo might be interested in thinking what more tablety
things we could do for plasma upon tablet mode on

Can we make tablet mode available somehow in X11?

NO

Why not:

not worth the time, touch will always suck on X11

Virtual Keyboard - X11

TODO Somebody please investigate which virtual keyboards work.
Bhushan says maliit1 should work

Virtual Keyboard - Wayland

do we want to ditch the internal qtvirtualkeyboard in kwin process?

probably

make an app that uses QtVK and talks to KWin via Wayland

Implement wayland protocols. Which?

TODO Aleix kill qtvk from KWin

TODO Aleix fix his patch and merge it

TODO Aleix see that the right keyboard gets started, maybe with a kcm

Usage in tablets like e.g pinetab

Should we use the phone shell or desktop shell on tablet

How window management should look like on tablet device?

Should we get VDG feedback on this?

Convergence to larger form-factor

Pinephone

Librem 5

Action item: Working hardware which supports this.

Applications support (partially too wide topic, I think I am not
sure what specific issue I had in mind when I had aded it here -
bshah)

Call notification interface standard << shouldn't this be part of
notifications on sunday? << not really, you'll see when I explain

Nico wants a way for apps to know there's an ongoing call, like an
"mpris for calls"

talk to other projects

check out libresource-qt from sailfish

Rotation

Add rotation animation

Window maximize bug

Decide on interaction patterns for table devices

show toolbar on tablets?

Kirigami: standard, opt-in way of closing pages

Explore page sizing behaviour on tablets


Random bugs:

With Plasma style ScrollViewKCM looks weird https://i.imgur.com/4HaybQH.png



Wallpaper KCM: topics

people want to set all wallpapers at once

kcm has some ui and technical problems [marco] i want a design
that solves all cornercases of multiple screens and multiple
activities

we want an inline message that asks to apply same wallpaper to
lockscreen and login too

for discoverability adding "wallpaper" in the context menu entry


Panel defaults

Stay with horizontal panel and go with https://phabricator.kde.org/D27845

On the Global Themes side, add a sheet to the KCM for applying
only parts of the LNF packages

Then move forward with https://phabricator.kde.org/D24223

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added a comment.


  In D9875#675107 , @mkoller wrote:
  
  > They did not overwrite each other since the entry for the Username holds an 
URL _without_ user but the password entry did.
  
  
  That's pretty fragile, but would need to be kept for compatibility indeed.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: fvogt, pali, lbeltrame
Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D9875: Extend parsing ssh prompt

[Martin Koller]

mkoller added a comment.


  They did not overwrite each other since the entry for the Username holds an 
URL _without_ user but the password entry did.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: fvogt, pali, lbeltrame
Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added a comment.


  In D9875#675101 , @mkoller wrote:
  
  > This patch breaks usage for git (and probably others):
  >  git first asks for a "Username for 'https:" which leads to ksshaskpass 
open the input dialog but the typed-in user
  >  is no longer stored into the wallet!!
  >  (See case TypeClearText)
  >  This leads to git again and again ask for the Username on each invokation.
  >
  > Please ensure that even the Username is stored again _in the same folder_ 
in kwallet as before (e.g. below Passwords)
  >  otherwise it also breaks using existing passwords. E.g. reading
  >
  >   if (type != TypePassword) {
  >  QByteArray retrievedBytes;
  >  wallet->readEntry(identifier, retrievedBytes);
  >
  > is wrong (backwards incompatible).
  
  
  Can you make a patch?
  
  Having a quick look at the previous code, it seems like username and password 
shared the identifier, so they overwrote each other.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: fvogt, pali, lbeltrame
Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D9875: Extend parsing ssh prompt

[Martin Koller]

mkoller reopened this revision.
mkoller added a comment.
This revision is now accepted and ready to land.


  This patch breaks usage for git (and probably others):
  git first asks for a "Username for 'https:" which leads to ksshaskpass 
open the input dialog but the typed-in user
  is no longer stored into the wallet!!
  (See case TypeClearText)
  This leads to git again and again ask for the Username on each invokation.
  
  Please ensure that even the Username is stored again _in the same folder_ in 
kwallet as before (e.g. below Passwords)
  otherwise it also breaks using existing passwords. E.g. reading 
   if (type != TypePassword) {
  
QByteArray retrievedBytes;
wallet->readEntry(identifier, retrievedBytes);
  
  is wrong (backwards incompatible).

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: fvogt, pali, lbeltrame
Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart