D26675: [sddm-theme] Don't have a broken reveal password button

[Bharadwaj Raju]

bharadwaj-raju added a comment.


  I see. So the bug is seen only if Breeze icons aren't installed? Because I 
read that it happened only on some systems, but I didn't know which exactly.
  
  Doesn't/shouldn't PC3 fall back to other icon themes if Breeze isn't 
installed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26675: [sddm-theme] Don't have a broken reveal password button

[Ahmad Samir]

ahmadsamir added a comment.


  One was to fix this is if sddm have copies of the needed password buttons, 
then it should work regardless of the installed icon themes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26675: [sddm-theme] Don't have a broken reveal password button

[Ahmad Samir]

ahmadsamir added a comment.


  In D26675#678811 , @bharadwaj-raju 
wrote:
  
  > Is there an SDDM issue to track this? Because I edited the file to make 
`revealPasswordButtonShown` true, and the button shows up just fine. Which 
makes me think this might've been fixed in SDDM.
  
  
  I am not sure, but I think the issue is when the breeze icon theme isn't 
available, then the button would be shown without an icon, i.e. invisible, and 
we got bug reports of users hitting hit by mistake. Given the nature of the 
text box we're dealing with here, hitting that invisible button by mistake is 
problematic security-wise.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26032: feat: add Control API for auto rotation

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> control.cpp:266
> +const auto val = info[QStringLiteral("autorotate")];
> +return !val.canConvert() || val.toBool();
> +}

Why treat an inconvertible value as true and not false?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26032

To: romangg, #plasma
Cc: volkov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26675: [sddm-theme] Don't have a broken reveal password button

[Bharadwaj Raju]

bharadwaj-raju added a comment.


  Is there an SDDM issue to track this? Because I edited the file to make 
`revealPasswordButtonShown` true, and the button shows up just fine. Which 
makes me think this might've been fixed in SDDM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: bharadwaj-raju, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart