D24447: Fix compatibility of build_theme.sh with Dash

[Alexander Kernozhitsky]

gepardo added a comment.


  Thanks. Can you please merge it? I don't have a developer access to KDE repos.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24447: Fix compatibility of build_theme.sh with Dash

[Alexander Kernozhitsky]

gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  The script build_sh didn't work with Dash necause of "[[". When running it, I 
got the following:
  
  $ ./build_theme.sh 
  Installing into /home/gepardo/.local/share/themes/Breeze
  ./build_theme.sh: 111: [[: not found
  cp: cannot create directory '': No such file or directory

TEST PLAN
  After changing "[[" to "[", it worked fine and installed the theme

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

AFFECTED FILES
  src/build_theme.sh

To: gepardo
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  Thanks, now I got your point much clearer.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  ping @davidedmundson

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  Still waiting for the feedback.

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  Ping @davidedmundson

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  Here is how it looks on tall panels:
  F7114427: clock2.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 62751.
gepardo added a comment.


  Now the widget doesn't become too wide if the panel is tall. The size formula 
now looks similar to the size formula of the clock widget. Expanatory comment 
is updated.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17464?vs=62750=62751

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  > I don't follow how it makes them the same when the other number is 
different.
  
  Timer applet is rendered using SVGs, clock applet is rendered using text. So, 
as the SVGs and font glyphs have different sizes, we need different 
coefficients. The coefficient 0.86 itself is obtained by trying different other 
"magic" numbers and finding the nearest one visually.
  
  Here is how it looks:
  F7114370: clock.png 
  
  Or, I can just give up and remove 0.86 from the code :)
  F7114374: clock1.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 62750.
gepardo added a comment.


  Change magic value to 0.86, as it looks nearer to the clock font size

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17464?vs=62730=62750

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 62730.
gepardo added a comment.


  Minor change in the comment for the "magic" value 0.84

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17464?vs=62660=62730

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  The rationale is to make the clock font size and the timer font size 
identical. Setting 0.84 as timer height multiplier indeed reaches this goal. 
But two other problems remain:
  
  - the fonts are different itself, as clock uses the real font, and timer uses 
SVGs to render digits
  - if the panel is large enough, the vertical position of the text differs 
(timer's top and bottom margins are equal, but clock's top and bottom margins 
have different size)
  
  Should I fix some of these issues also?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo marked an inline comment as done.
gepardo added a comment.


  After some experiments, I finally set clock size to 0.84:
  
  F7107969: clock.png 
  
  The main problem is that the clock widget uses a real font, but the timer 
uses SVGs to render digits.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 62660.
gepardo added a comment.


  Updating D17464 : [Timer applet] Minor 
fixes for the applet
  
  Change clock size ratio to 0.84 for better compatibility with Clock's font 
size

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17464?vs=47224=62660

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Alexander Kernozhitsky]

gepardo added a comment.


  Nice :)
  
  I have some suggestions to prevent such errors in the future:
  
  - `sass` (but not `sassc`) has `-E` option to set the encoding for building
  - it may be a good idea to add such lines to all the SCSS files
  
  BTW, where does the build error happen?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18314: Cosmetic fixes for build_theme.sh

[Alexander Kernozhitsky]

gepardo added a comment.


  @davidedmundson, can you please merge it into master? I don't have a 
developer account, so I can't do this by myself.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  build-script-minor-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18314

To: gepardo, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18314: Cosmetic fixes for build_theme.sh

[Alexander Kernozhitsky]

gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  I saw the changes introduced by https://phabricator.kde.org/D18287. It's a 
really good idea :)
  
  The commit contains some minor fixes into the build script (like quoting "$4" 
parameter)

TEST PLAN
  Builds on my machine. The changes are minor and should not affect anything.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  build-script-minor-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18314

AFFECTED FILES
  src/build_theme.sh

To: gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  > I would also scrap all the stuff about ~/.local
  
  Are there any strong reasons?
  
  Reasons for not removing `~/.local` are the following. KDE still doesn't have 
custom color schemes support for Breeze-GTK. But `build-theme.sh` allows to 
rebuild the theme with custom color scheme and by default install it into 
`~/.local/share/themes`. As you can see, it can read the colors from kdeglobals 
and color schemes (local and system-wide). (BTW that's how I'm using the theme: 
I just run `build_theme.sh` when changing color scheme)
  
  I do agree that's a temporary hack there should be a user-friendly way to 
change the colors. But I think there no reason to remove this stuff now.
  
  Maybe this way to rebuild the theme can be mentioned in README also.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48474.
gepardo added a comment.


  Prevent the theme from rebuilding each time

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48462=48474

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-dark-gtk/assets/arrow-down-active.png
  Breeze-dark-gtk/assets/arrow-down-hover.png
  Breeze-dark-gtk/assets/arrow-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-down.png
  Breeze-dark-gtk/assets/arrow-left-active.png
  Breeze-dark-gtk/assets/arrow-left-hover.png
  Breeze-dark-gtk/assets/arrow-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-left.png
  Breeze-dark-gtk/assets/arrow-right-active.png
  Breeze-dark-gtk/assets/arrow-right-hover.png
  Breeze-dark-gtk/assets/arrow-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-right.png
  Breeze-dark-gtk/assets/arrow-small-down-active.png
  Breeze-dark-gtk/assets/arrow-small-down-hover.png
  Breeze-dark-gtk/assets/arrow-small-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-down.png
  Breeze-dark-gtk/assets/arrow-small-left-active.png
  Breeze-dark-gtk/assets/arrow-small-left-hover.png
  Breeze-dark-gtk/assets/arrow-small-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-left.png
  Breeze-dark-gtk/assets/arrow-small-right-active.png
  Breeze-dark-gtk/assets/arrow-small-right-hover.png
  Breeze-dark-gtk/assets/arrow-small-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-right.png
  Breeze-dark-gtk/assets/arrow-small-up-active.png
  Breeze-dark-gtk/assets/arrow-small-up-hover.png
  Breeze-dark-gtk/assets/arrow-small-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-up.png
  Breeze-dark-gtk/assets/arrow-up-active.png
  Breeze-dark-gtk/assets/arrow-up-hover.png
  Breeze-dark-gtk/assets/arrow-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-up.png
  Breeze-dark-gtk/assets/button-active.png
  Breeze-dark-gtk/assets/button-hover.png
  Breeze-dark-gtk/assets/button-insensitive.png
  Breeze-dark-gtk/assets/button.png
  Breeze-dark-gtk/assets/check-checked-active.png
  Breeze-dark-gtk/assets/check-checked-act...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop.png
  Breeze-dark-gtk/assets/check-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-checked-hover.png
  Breeze-dark-gtk/assets/check-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-checked-insensitive.png
  Breeze-dark-gtk/assets/check-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-active.png
  Breeze-dark-gtk/assets/check-mixed-act...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop.png
  Breeze-dark-gtk/assets/check-mixed-backd...@2.png
  Breeze-dark-gtk/assets/check-mixed-hover.png
  Breeze-dark-gtk/assets/check-mixed-ho...@2.png
  Breeze-dark-gtk/assets/check-mixed-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  
Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked.png
  Breeze-dark-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-dark-gtk/assets/check-unchecked-active.png
  Breeze-dark-gtk/assets/check-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  In D17154#384519 , @ngraham wrote:
  
  > The `install` target is installing to `./Breeze` and `./Breeze-Dark` in 
addition to the `CMAKE_INSTALL_PREFIX` location, which messes up the 
permissions in your source checkout if you do an in-source build and run `sudo 
make install`.
  
  
  Got it. The issue is more compilcated, though. `Breeze` and `Breeze-Dark` 
directories are created during the build. They are not real targets currently, 
so are build each time (even during the install). So, when installed as root, 
they are modified. I will think of how to fix this issue.
  
  Sorry for these issues with the building process, I'm not familar with it 
much. But at least I hope there're no such issues with the theme itself.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48462.
gepardo added a comment.


  CMake fixes:
  
  - Compatibility with older versions
  - Add docs and copyright into FindSass.cmake

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48224=48462

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-dark-gtk/assets/arrow-down-active.png
  Breeze-dark-gtk/assets/arrow-down-hover.png
  Breeze-dark-gtk/assets/arrow-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-down.png
  Breeze-dark-gtk/assets/arrow-left-active.png
  Breeze-dark-gtk/assets/arrow-left-hover.png
  Breeze-dark-gtk/assets/arrow-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-left.png
  Breeze-dark-gtk/assets/arrow-right-active.png
  Breeze-dark-gtk/assets/arrow-right-hover.png
  Breeze-dark-gtk/assets/arrow-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-right.png
  Breeze-dark-gtk/assets/arrow-small-down-active.png
  Breeze-dark-gtk/assets/arrow-small-down-hover.png
  Breeze-dark-gtk/assets/arrow-small-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-down.png
  Breeze-dark-gtk/assets/arrow-small-left-active.png
  Breeze-dark-gtk/assets/arrow-small-left-hover.png
  Breeze-dark-gtk/assets/arrow-small-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-left.png
  Breeze-dark-gtk/assets/arrow-small-right-active.png
  Breeze-dark-gtk/assets/arrow-small-right-hover.png
  Breeze-dark-gtk/assets/arrow-small-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-right.png
  Breeze-dark-gtk/assets/arrow-small-up-active.png
  Breeze-dark-gtk/assets/arrow-small-up-hover.png
  Breeze-dark-gtk/assets/arrow-small-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-up.png
  Breeze-dark-gtk/assets/arrow-up-active.png
  Breeze-dark-gtk/assets/arrow-up-hover.png
  Breeze-dark-gtk/assets/arrow-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-up.png
  Breeze-dark-gtk/assets/button-active.png
  Breeze-dark-gtk/assets/button-hover.png
  Breeze-dark-gtk/assets/button-insensitive.png
  Breeze-dark-gtk/assets/button.png
  Breeze-dark-gtk/assets/check-checked-active.png
  Breeze-dark-gtk/assets/check-checked-act...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop.png
  Breeze-dark-gtk/assets/check-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-checked-hover.png
  Breeze-dark-gtk/assets/check-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-checked-insensitive.png
  Breeze-dark-gtk/assets/check-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-active.png
  Breeze-dark-gtk/assets/check-mixed-act...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop.png
  Breeze-dark-gtk/assets/check-mixed-backd...@2.png
  Breeze-dark-gtk/assets/check-mixed-hover.png
  Breeze-dark-gtk/assets/check-mixed-ho...@2.png
  Breeze-dark-gtk/assets/check-mixed-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  
Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked.png
  Breeze-dark-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-dark-gtk/assets/check-unchecked-active.png
  Breeze-dark-gtk/assets/check-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensitive.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindSass.cmake:1
> Missing doc & license

Which one should I choose? Is BSD 3-clause, that is used by //Extra CMake 
modules//, OK?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  Hello, is there any progress on the review?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48224.
gepardo added a comment.


  Remove compiled themes from the sources; now the building process doesn't 
modify the sources at all

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48223=48224

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-dark-gtk/assets/arrow-down-active.png
  Breeze-dark-gtk/assets/arrow-down-hover.png
  Breeze-dark-gtk/assets/arrow-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-down.png
  Breeze-dark-gtk/assets/arrow-left-active.png
  Breeze-dark-gtk/assets/arrow-left-hover.png
  Breeze-dark-gtk/assets/arrow-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-left.png
  Breeze-dark-gtk/assets/arrow-right-active.png
  Breeze-dark-gtk/assets/arrow-right-hover.png
  Breeze-dark-gtk/assets/arrow-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-right.png
  Breeze-dark-gtk/assets/arrow-small-down-active.png
  Breeze-dark-gtk/assets/arrow-small-down-hover.png
  Breeze-dark-gtk/assets/arrow-small-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-down.png
  Breeze-dark-gtk/assets/arrow-small-left-active.png
  Breeze-dark-gtk/assets/arrow-small-left-hover.png
  Breeze-dark-gtk/assets/arrow-small-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-left.png
  Breeze-dark-gtk/assets/arrow-small-right-active.png
  Breeze-dark-gtk/assets/arrow-small-right-hover.png
  Breeze-dark-gtk/assets/arrow-small-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-right.png
  Breeze-dark-gtk/assets/arrow-small-up-active.png
  Breeze-dark-gtk/assets/arrow-small-up-hover.png
  Breeze-dark-gtk/assets/arrow-small-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-up.png
  Breeze-dark-gtk/assets/arrow-up-active.png
  Breeze-dark-gtk/assets/arrow-up-hover.png
  Breeze-dark-gtk/assets/arrow-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-up.png
  Breeze-dark-gtk/assets/button-active.png
  Breeze-dark-gtk/assets/button-hover.png
  Breeze-dark-gtk/assets/button-insensitive.png
  Breeze-dark-gtk/assets/button.png
  Breeze-dark-gtk/assets/check-checked-active.png
  Breeze-dark-gtk/assets/check-checked-act...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop.png
  Breeze-dark-gtk/assets/check-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-checked-hover.png
  Breeze-dark-gtk/assets/check-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-checked-insensitive.png
  Breeze-dark-gtk/assets/check-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-active.png
  Breeze-dark-gtk/assets/check-mixed-act...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop.png
  Breeze-dark-gtk/assets/check-mixed-backd...@2.png
  Breeze-dark-gtk/assets/check-mixed-hover.png
  Breeze-dark-gtk/assets/check-mixed-ho...@2.png
  Breeze-dark-gtk/assets/check-mixed-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  
Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked.png
  Breeze-dark-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-dark-gtk/assets/check-unchecked-active.png
  Breeze-dark-gtk/assets/check-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensitive.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  > But files in the source repo are still overwritten during the build process 
if you do an in-source build.
  
  `Breeze-gtk` and `Breeze-dark-gtk` are ovewritten regardless of whether an 
in-source build in used or not. I'm going to fix it now by removing compiled 
files from the repo (located in `Breeze-gtk` and `Breeze-dark-gtk`)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48223.
gepardo added a comment.


  Summary of changes done:
  
  - Fix race condition during the build
  - Prevent the build process from writing into the source directory
  - Style fixes in build_theme.sh
  - Improve parameter parsing in build_theme.sh
  - Remove gtkrc, at it is autogenerated anyway
  - Pycodestyle fixes

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48156=48223

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  In D17154#382450 , @ngraham wrote:
  
  > Also, overwriting sources is a no-no. :/
  >
  > If this is a pre-existing bug, perhaps we should fix it in another patch 
though.
  
  
  What does it mean? Should I create a new Phabricator revision or so?
  
  This bug did exist in the repo I took as a base 
(https://github.com/dirruk1/gnome-breeze). The scripts from there overwrote the 
sources.
  
  Now I am almost ready with fixing this issue. This involves changing Python 
script a liitle to make it write `gtk2rc` and `global.scss` into custom 
locations.
  
  > Also, overwriting sources is a no-no. :/
  
  So, I think, it's even better to remove `Breeze-gtk` and `Breeze-dark-gtk` 
directories from the sources (because they are regenerated each time). Is it OK?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  It seems to be the issue with parallel Make. The original scripts often 
overwrite sources, so they can't be built in parallel. I'll try to fix it to 
resolve the race conditions.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48156.
gepardo added a comment.


  Add gtk-dark.css support for Breeze

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48153=48156

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked.png
  Breeze-gtk/assets/radio-unchec...@2.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48153.
gepardo added a comment.


  Fix GTK+ 3.18 theme installation

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48148=48153

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked.png
  Breeze-gtk/assets/radio-unchec...@2.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  Oops, sorry, I forgot to check the installation.
  
  GTK+ 3.18 did built, but it was built into `gtk-3.0` directory (the build 
scripts in the old repo seem to do so). But `CMakeLists.txt` remained unchanged.
  
  I noticed that recent versions install `gtk-3.18` and `gtk-3.20` dirs, so 
I'll change the build scripts to have `gtk-3.18` as a target directory.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48148.
gepardo marked an inline comment as done.
gepardo added a comment.


  Fix finding Python package for CMake <3.12

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48145=48148

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo marked 2 inline comments as done.
gepardo added inline comments.

INLINE COMMENTS

> ngraham wrote in CMakeLists.txt:13
> This doesn't seem like the correct way to require Python 3:
> 
>   dev@dev-pc:~/repos/breeze-gtk$  (arcpatch-D17154) cmake 
> -DCMAKE_INSTALL_PREFIX=/usr
>   -- Could NOT find Sass (missing: Sass_EXECUTABLE) 
>   CMake Error at CMakeLists.txt:13 (find_package):
> By not providing "FindPython3.cmake" in CMAKE_MODULE_PATH this project has
> asked CMake to find a package configuration file provided by "Python3", 
> but
> CMake did not find one.
>   
> Could not find a package configuration file provided by "Python3" with any
> of the following names:
>   
>   Python3Config.cmake
>   python3-config.cmake
>   
> Add the installation prefix of "Python3" to CMAKE_PREFIX_PATH or set
> "Python3_DIR" to a directory containing one of the above files.  If
> "Python3" provides a separate development package or SDK, be sure it has
> been installed.
>   
>   
>   -- Configuring incomplete, errors occurred!
>   See also "/home/dev/repos/breeze-gtk/CMakeFiles/CMakeOutput.log".

Using find_package(Python3) worked for me. But I understood the reason why it 
may fail.

It seems that find_package(Python3) appeared only in CMake 3.12, while 
find_package(PythonInterp) was used earlier (now it's deprecated). So, I'll add 
a conditional for older and current CMake.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48145.
gepardo added a comment.


  Make Sass a required dependency

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48031=48145

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48031.
gepardo added a comment.


  More imrovements:
  
  - remove gtk-3.18 as it's not rebuilt. The theme is still usable under GTK+ 
3.18 (files are actually located in gtk-3.0)
  - add python as a dependency in CMakeLists.txt

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48030=48031

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 48030.
gepardo added a comment.


  Use CMake for building themes
  
  The following changes are made:
  
  - cmake/FindSass.cmake is now used to detect SASS compiler presence
  - build scripts are invoked from cmake, so everythings builds using simple 
cmake && make

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=46195=48030

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  In D17154#380574 , @ngraham wrote:
  
  > On that subject, rebuilding the theme should be done as a part of the 
default build target when running `make` rather than requiring the use of a 
script. It's a requirement that all the work gets done simply by running 
`make`. This will require a few CMake adjustment too.
  
  
  I had an even better idea: to run these lines directly from CMakeLists.txt, 
so it will be integrated with building process as good as possible.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo updated this revision to Diff 47224.
gepardo added a comment.


  Add a comment about value 0.77

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17464?vs=47219=47224

BRANCH
  timer-on-panel-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17464

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added inline comments.

INLINE COMMENTS

> davidedmundson wrote in TimerView.qml:53
> never set size hints from current size, you're asking for binding loops.
> 
> setting it based on the implicitWith is ok

Can't get it work with `implicitWidth` and `implicitHeight`.

By the way, when using `parent.width` and `parent.height` it works OK (but 
`parent.implicitWidth` and `parent.implicitHeight` don't work correctly). Is it 
OK or are there other ideas how to rewrite this part of code?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added inline comments.

INLINE COMMENTS

> davidedmundson wrote in TimerView.qml:65
> where has 0.77 come from

As I remember, I was trying to make the digits size of timer equal nearer to 
clock font size. Setting this to `1.0` won't break anything, but the digits 
will take the full height of the panel.

BTW, clock itself uses `height * 0.71`.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added inline comments.

INLINE COMMENTS

> davidedmundson wrote in TimerView.qml:46
> what if it's neither (i.e on the desktop) ?

Doesn't it use the default sizing settings (as used before this patch)?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  BUG: 395182
  BUG: 361025
  
  Here are the changes made:
  
  - Allow Timer widget to work well on panels, both vertical and horizontal.
  
  - Use root.digitHasChanged(); instead of main.digitChanged(); This line was 
changed before in https://phabricator.kde.org/D12534, but it seems that 
main.digitChanged(); doesn't exist also.
  
  - Use "expireTimeout" instead of "timeout", as explained in 
https://bugs.kde.org/show_bug.cgi?id=361025.
  
  - Increase notification time from 2s to 5s, so it's harder to miss it.

TEST PLAN
  Tried placing the timer on a panel, then tried to resize the panel. Tested on 
both vertical and horizontal panels.
  
  I regularly use this applet on a vertical panel without issues.

REPOSITORY
  R114 Plasma Addons

BRANCH
  timer-on-panel-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17464

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: gepardo
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  This patch is not reviewed for two weeks. How soon can I get some feedback on 
it?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze
Cc: ngraham, jackg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  As it was explained in https://phabricator.kde.org/D16365,
  
  > Further potential steps in the same direction of saving code would be going 
back to SASS
  
  This patch tries to go back to SCSS sources with backporting all the fixes 
made in Breeze-gtk recently. As a base, I used this repository: 
https://github.com/dirruk1/gnome-breeze. But it's outdated, so I walked through 
the commit history of breeze-gtk and ported all the changes here. The script 
for building the theme was ported to Python3, and shell scripts now use POSIX 
sh instead of bash. Also I fixed some inconsistences between Qt and GTK Breeze 
themes. For example, Breeze-Qt colorscheme was updated a little (in Plasma 
5.12, as far as I remember), but the GTK theme was updated only partially; now 
the colors are synchronized. Both GTK-3.18 and GTK-3.20 versions work fine for 
me; many things were also fixed for GTK 3.18.
  
  For building the theme, ruby-sass (or more lightweght sassc) is required. 
Also the theme can be patched to allow changing the colorscheme in System 
Settings (though, rebuilding the theme with sassc is required for this). The 
original repository (https://github.com/dirruk1/gnome-breeze) had also 
named-colors branch that allowed using named colors and changing the 
colorscheme without rebuilding; but I couldn't get this working.
  
  Because both Breeze-gtk and Breese-dark-gtk are now built from sources, there 
will be no more inconsistences between them. Rebuilding these themes can be 
done using rebuild-theme.sh.

TEST PLAN
  I do not know how to test this automatically. But I am using this version of 
Breeze-GTK for several months (I am not using many GTK+ applications, though). 
Also checked it on gtk3-widget-factory; it seems to work fine.
  
  GTK2 version was tested on Gimp, but it is mostly unchanged.
  
  For differences between https://github.com/dirruk1/gnome-breeze and this 
version, you can see my GitHub repo where I worked on this patch: 
https://github.com/alex65536/gnome-breeze/tree/breeze-gtk-merge.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  

D15110: Fix scrollbars in LibreOffice

[Alexander Kernozhitsky]

gepardo added a comment.


  @davidedmundson, can you please merge this revision? I don't have a developer 
account, so I can't do it.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D15110

To: gepardo, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15110: Fix scrollbars in LibreOffice

[Alexander Kernozhitsky]

gepardo added a comment.


  In D15110#316372 , @davidedmundson 
wrote:
  
  > Can you explain where this 14 is derived from?
  
  
  This value is used un Breeze-Dark-gtk and older revisions of Breeze-gtk.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D15110

To: gepardo, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15110: Fix scrollbars in LibreOffice

[Alexander Kernozhitsky]

gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  BUG: 389709

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D15110

AFFECTED FILES
  Breeze-gtk/gtk-3.20/gtk.css

To: gepardo
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

SCSS sources of Breeze-gtk

[Alexander Kernozhitsky]

Hello, I noticed that Breeze-gtk theme had SCSS sources in

https://github.com/dirruk1/gnome-breeze.

But now this repository is adandoned, and the KDE repos don't include SCSS 
sources. Does anyone knows why this happened?

Because of lack of sources, Breeze-gtk and Breeze-Dark-gtk are not syncronized 
in some places (see e. g. https://bugs.kde.org/show_bug.cgi?id=389709#c4).

There was also a good script to change the colors in SCSS to match the current 
color scheme. It was better than patching themes manually if the default 
colorscheme changes. Also, with the old approach, colorscheme support could be 
added (but recompliling must be done each time).

-- 
Alexander Kernozhitsky