Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/#review71165 --- Ship it! Looks good to me once the open issues have be solved. - Alexander Richardson On Nov. 14, 2014, 6:08 nachm., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/ --- (Updated Nov. 14, 2014, 6:08 nachm.) Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, and Marco Martin. Repository: kcoreaddons Description --- This set of patches moves the code to decode and json-serialize from desktoptojson into its own class, used by the KPluginMetaData(QString file) constructor. These functions are not exported, desktoptojson directly includes this class. I've done it this way to avoid littering the API, yet removing as much duplicated code from desktoptojson as possible. These functions have gone into their own class, and made static, since they don't carry state, anyway. The purpose of this patch is to allow the package indexer in kpackage (the split-out framework containing Plasma::Package) to create a correct, KPlugin-compatible cache file from package metadata. This patch allows us to just feed a .desktop file into KPluginMetaData and get back correct deserialized KPluginMetaData objects. It allows us to cut out the KService dependency in KPackage. In particular, this is split up into the following patches (you can find it in git kcoreaddons[sebas/kpluginmetadata] as well): Remove now-duplicated code in desktoptojson Use escapeValue, deserializeList and convertToJson from desktopfileparser. Move the bits to parse .desktop files into its own class This encapsulates the desktop file parseing logic into its own class. It's fairly self-contained, all static code. This also makes it easier to share this code with the desktoptojson binary. Allow to read KPluginMetaData from .desktop files Move the logic to create a KPluginMetaData object from desktoptojson into KPluginMetaData. This allows to load metadata from a .desktop file, making it possible to load desktop files without going through KPluginInfo (and thus KService). This is useful for conversion to json data, which will be used to index packages in the KPackage framework for faster lookups, similar to the index proof-of-concept for KPluginTrader. Add an autotest for loading KPluginMetaData from a .desktop file Diffs - autotests/data/fakeplugin.desktop PRE-CREATION autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e src/desktoptojson/desktoptojson.cpp 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a src/lib/plugin/desktopfileparser.h PRE-CREATION src/lib/plugin/desktopfileparser.cpp PRE-CREATION src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd Diff: https://git.reviewboard.kde.org/r/121122/diff/ Testing --- Added an autotest which compares a KPluginMetaData object created from a desktop file. Also used this code from kpackage. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/ --- (Updated Oct. 27, 2014, 5:31 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kio-extras Description --- This is what the core ioslaves such as file or http do. Also dropped the kio_ prefix to the library name since it isn't needed now that we install them into a kio directory Diffs - archive/CMakeLists.txt ec2cf7ad6c9c645e62a47c94ec617f8a37c5f708 archive/ar.protocol 7a848e505e5f00121e8ec5493564dfacdd405c31 archive/tar.protocol 19447a5e75b106e7a8c8e8396375bb1fc600a6da archive/zip.protocol ce7c54b4e92dfab29150246bf6588d1f8bb49057 bookmarks/CMakeLists.txt 703b109c2e049edecce1742482bd82e5c92caecd bookmarks/bookmarks.protocol 0642bd2f7277be8707351582f219281d45834fa6 desktop/CMakeLists.txt f7bd6709340a5f4e7e5f6fbd076400a76b526cd8 desktop/desktop.protocol 0e388386f1794dd90d445ec146ef54a04f595c8b filter/CMakeLists.txt 240cc7b57bd38e86fd50084e53c17f1672b2b946 filter/bzip.protocol 7d3cb570fbc534fbba22dd8e10472b47053c7195 filter/bzip2.protocol 1baaf7dd610f39325b2aa21bdee5bf1e63e5835f filter/gzip.protocol 8ed55ec16f49f42fe6d419327484b33d59ec537b filter/lzma.protocol 13bb28e3d870f8130d052efd97a5a688d9133c31 filter/xz.protocol f4fb7f01146cbf4d5afce528462e0c5dafa9591e fish/CMakeLists.txt 24136d4dac01a8a08db8d17380661a9051fa0b04 fish/fish.protocol ff5784eea877d0fd9a3c6ac4724056ddfd8fe5f2 info/CMakeLists.txt 0163e82c4f865e3fb3b09bf5ddd44e272ce9c609 info/info.protocol fa8cbb4f6eaaeeaf8bfdead0fad598df8fe588eb man/CMakeLists.txt 3343ed85978dbbfa72a5f2cc8530d0f0c043df48 man/man.protocol cc100ce5ec48b40c890abe5d7afdf02ef589810b network/ioslave/CMakeLists.txt 67fc482cd390f35fb2d5c1740994d2fe9db254f1 network/ioslave/network.protocol 1e10cc6c3a6aadf2ee6794ab36200ef6793e324e nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 nfs/nfs.protocol 85cf2035e44bf7bfe65d4e2b62d1f44fa05d6001 recentdocuments/CMakeLists.txt bc2b9dbf35428cf0dd1e6ad5c6e569806c92d47f recentdocuments/recentdocuments.protocol c0bf1ebd80a2c696cad3062ef047ac4847270fc5 settings/CMakeLists.txt 5a57a1840fb33b32701a6ecfff24c42739b05c45 settings/settings.protocol efb03e865594f30be5ed0d1013d31a0200eed816 sftp/CMakeLists.txt defb7dd041ebfd5af0ac19a252cc9f2f454f67f9 sftp/sftp.protocol ec15eeb26b3ce2efded173f4c7a4cd737e0a05f8 smb/CMakeLists.txt a3a772f3028995b811b01fcebe11d8715d3e1620 smb/smb.protocol e58597844ff8554e837f6ee8807d17820e377945 thumbnail/CMakeLists.txt f3733d452eb133d2b5a1445740db0312cd5d8251 thumbnail/thumbnail.protocol eef743ab5310007093e6a1c1ff6d8c258f1be5d9 trash/CMakeLists.txt 4ee03581f5d632282efb9b8902b3abb0e95d169c trash/trash.protocol 277698579c8a70bac5cadff5cc1f379053e4c61e Diff: https://git.reviewboard.kde.org/r/119081/diff/ Testing --- Archive protocol works fine in dolphin (KF5) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/#review67273 --- Ping? - Alexander Richardson On Sept. 23, 2014, 10:36 vorm., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/ --- (Updated Sept. 23, 2014, 10:36 vorm.) Review request for KDE Frameworks and Plasma. Repository: kio-extras Description --- This is what the core ioslaves such as file or http do. Also dropped the kio_ prefix to the library name since it isn't needed now that we install them into a kio directory Diffs - archive/CMakeLists.txt ec2cf7ad6c9c645e62a47c94ec617f8a37c5f708 archive/ar.protocol 7a848e505e5f00121e8ec5493564dfacdd405c31 archive/tar.protocol 19447a5e75b106e7a8c8e8396375bb1fc600a6da archive/zip.protocol ce7c54b4e92dfab29150246bf6588d1f8bb49057 bookmarks/CMakeLists.txt 703b109c2e049edecce1742482bd82e5c92caecd bookmarks/bookmarks.protocol 0642bd2f7277be8707351582f219281d45834fa6 desktop/CMakeLists.txt f7bd6709340a5f4e7e5f6fbd076400a76b526cd8 desktop/desktop.protocol 0e388386f1794dd90d445ec146ef54a04f595c8b filter/CMakeLists.txt 240cc7b57bd38e86fd50084e53c17f1672b2b946 filter/bzip.protocol 7d3cb570fbc534fbba22dd8e10472b47053c7195 filter/bzip2.protocol 1baaf7dd610f39325b2aa21bdee5bf1e63e5835f filter/gzip.protocol 8ed55ec16f49f42fe6d419327484b33d59ec537b filter/lzma.protocol 13bb28e3d870f8130d052efd97a5a688d9133c31 filter/xz.protocol f4fb7f01146cbf4d5afce528462e0c5dafa9591e fish/CMakeLists.txt 24136d4dac01a8a08db8d17380661a9051fa0b04 fish/fish.protocol ff5784eea877d0fd9a3c6ac4724056ddfd8fe5f2 info/CMakeLists.txt 0163e82c4f865e3fb3b09bf5ddd44e272ce9c609 info/info.protocol fa8cbb4f6eaaeeaf8bfdead0fad598df8fe588eb man/CMakeLists.txt 3343ed85978dbbfa72a5f2cc8530d0f0c043df48 man/man.protocol cc100ce5ec48b40c890abe5d7afdf02ef589810b network/ioslave/CMakeLists.txt 67fc482cd390f35fb2d5c1740994d2fe9db254f1 network/ioslave/network.protocol 1e10cc6c3a6aadf2ee6794ab36200ef6793e324e nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 nfs/nfs.protocol 85cf2035e44bf7bfe65d4e2b62d1f44fa05d6001 recentdocuments/CMakeLists.txt bc2b9dbf35428cf0dd1e6ad5c6e569806c92d47f recentdocuments/recentdocuments.protocol c0bf1ebd80a2c696cad3062ef047ac4847270fc5 settings/CMakeLists.txt 5a57a1840fb33b32701a6ecfff24c42739b05c45 settings/settings.protocol efb03e865594f30be5ed0d1013d31a0200eed816 sftp/CMakeLists.txt defb7dd041ebfd5af0ac19a252cc9f2f454f67f9 sftp/sftp.protocol ec15eeb26b3ce2efded173f4c7a4cd737e0a05f8 smb/CMakeLists.txt a3a772f3028995b811b01fcebe11d8715d3e1620 smb/smb.protocol e58597844ff8554e837f6ee8807d17820e377945 thumbnail/CMakeLists.txt f3733d452eb133d2b5a1445740db0312cd5d8251 thumbnail/thumbnail.protocol eef743ab5310007093e6a1c1ff6d8c258f1be5d9 trash/CMakeLists.txt 4ee03581f5d632282efb9b8902b3abb0e95d169c trash/trash.protocol 277698579c8a70bac5cadff5cc1f379053e4c61e Diff: https://git.reviewboard.kde.org/r/119081/diff/ Testing --- Archive protocol works fine in dolphin (KF5) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/ --- (Updated Sept. 23, 2014, 10:36 vorm.) Review request for KDE Frameworks and Plasma. Repository: kio-extras Description (updated) --- This is what the core ioslaves such as file or http do. Also dropped the kio_ prefix to the library name since it isn't needed now that we install them into a kio directory Diffs - archive/CMakeLists.txt ec2cf7ad6c9c645e62a47c94ec617f8a37c5f708 archive/ar.protocol 7a848e505e5f00121e8ec5493564dfacdd405c31 archive/tar.protocol 19447a5e75b106e7a8c8e8396375bb1fc600a6da archive/zip.protocol ce7c54b4e92dfab29150246bf6588d1f8bb49057 bookmarks/CMakeLists.txt 703b109c2e049edecce1742482bd82e5c92caecd bookmarks/bookmarks.protocol 0642bd2f7277be8707351582f219281d45834fa6 desktop/CMakeLists.txt f7bd6709340a5f4e7e5f6fbd076400a76b526cd8 desktop/desktop.protocol 0e388386f1794dd90d445ec146ef54a04f595c8b filter/CMakeLists.txt 240cc7b57bd38e86fd50084e53c17f1672b2b946 filter/bzip.protocol 7d3cb570fbc534fbba22dd8e10472b47053c7195 filter/bzip2.protocol 1baaf7dd610f39325b2aa21bdee5bf1e63e5835f filter/gzip.protocol 8ed55ec16f49f42fe6d419327484b33d59ec537b filter/lzma.protocol 13bb28e3d870f8130d052efd97a5a688d9133c31 filter/xz.protocol f4fb7f01146cbf4d5afce528462e0c5dafa9591e fish/CMakeLists.txt 24136d4dac01a8a08db8d17380661a9051fa0b04 fish/fish.protocol ff5784eea877d0fd9a3c6ac4724056ddfd8fe5f2 info/CMakeLists.txt 0163e82c4f865e3fb3b09bf5ddd44e272ce9c609 info/info.protocol fa8cbb4f6eaaeeaf8bfdead0fad598df8fe588eb man/CMakeLists.txt 3343ed85978dbbfa72a5f2cc8530d0f0c043df48 man/man.protocol cc100ce5ec48b40c890abe5d7afdf02ef589810b network/ioslave/CMakeLists.txt 67fc482cd390f35fb2d5c1740994d2fe9db254f1 network/ioslave/network.protocol 1e10cc6c3a6aadf2ee6794ab36200ef6793e324e nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 nfs/nfs.protocol 85cf2035e44bf7bfe65d4e2b62d1f44fa05d6001 recentdocuments/CMakeLists.txt bc2b9dbf35428cf0dd1e6ad5c6e569806c92d47f recentdocuments/recentdocuments.protocol c0bf1ebd80a2c696cad3062ef047ac4847270fc5 settings/CMakeLists.txt 5a57a1840fb33b32701a6ecfff24c42739b05c45 settings/settings.protocol efb03e865594f30be5ed0d1013d31a0200eed816 sftp/CMakeLists.txt defb7dd041ebfd5af0ac19a252cc9f2f454f67f9 sftp/sftp.protocol ec15eeb26b3ce2efded173f4c7a4cd737e0a05f8 smb/CMakeLists.txt a3a772f3028995b811b01fcebe11d8715d3e1620 smb/smb.protocol e58597844ff8554e837f6ee8807d17820e377945 thumbnail/CMakeLists.txt f3733d452eb133d2b5a1445740db0312cd5d8251 thumbnail/thumbnail.protocol eef743ab5310007093e6a1c1ff6d8c258f1be5d9 trash/CMakeLists.txt 4ee03581f5d632282efb9b8902b3abb0e95d169c trash/trash.protocol 277698579c8a70bac5cadff5cc1f379053e4c61e Diff: https://git.reviewboard.kde.org/r/119081/diff/ Testing (updated) --- Archive protocol works fine in dolphin (KF5) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118073: Use QHostInfo in kio_nfs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118073/ --- (Updated Sept. 23, 2014, 8:45 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kio-extras Description --- Use QHostInfo in kio_nfs Diffs - nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 nfs/kio_nfs.cpp 293df2529a2488b7970dbe81a5ec202bc6a22742 Diff: https://git.reviewboard.kde.org/r/118073/diff/ Testing --- Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119913: Force creation of a OpenGL core context
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119913/ --- (Updated Aug. 28, 2014, 5:35 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- This was suggested by Martin Gräßlin in review 119524 and also fixes the build with Qt 5.4, since QQuickWindow::setDefaultFormat no longer exists REVIEW: 119913 Diffs - krunner/main.cpp 4d8cc31ff4d78c2daa0f9a6af247b3bd1c317ffa Diff: https://git.reviewboard.kde.org/r/119913/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119913: Force creation of a OpenGL core context
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119913/ --- Review request for Plasma. Repository: plasma-workspace Description --- This was suggested by Martin Gräßlin in review 119524 and also fixes the build with Qt 5.4, since QQuickWindow::setDefaultFormat no longer exists REVIEW: 119913 Diffs - krunner/main.cpp 4d8cc31ff4d78c2daa0f9a6af247b3bd1c317ffa Diff: https://git.reviewboard.kde.org/r/119913/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119524: Force OpenGLES if on Qt 5.4
On Aug. 11, 2014, 8:35 vorm., Martin Gräßlin wrote: I highly suggest to revert this change. Enforcing GLES means limiting to GLES (it's a subset after all) and also not all drivers do support GLES - that's still the smaller part. We are calling for lots of trouble if we go this route. I suggest to enforce core profile instead. Aleix Pol Gonzalez wrote: We discussed it with Marco, apparently this breaks on nvidia. I'm fine with reverting it (both plasmashell and on krunner) or with if'ing the cases where it doesn't work. Martin Gräßlin wrote: Requesting GLES on a desktop system just feels very wrong and from KWin experience: don't even think about ifdefing. For desktop usage I would suggest to try using QSurfaceFormat::setProfile. By the way this causes the build to fail with Qt 5.4, QQuickWindow::setDefaultFormat was changed to QSurfaceFormat::setDefaultFormat() (see https://git.reviewboard.kde.org/r/119913/ ) - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review64219 --- On Juli 29, 2014, 6:15 nachm., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- (Updated Juli 29, 2014, 6:15 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in. This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd. I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet. [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 Diffs - shell/main.cpp e34578d Diff: https://git.reviewboard.kde.org/r/119524/diff/ Testing --- I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports. File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/ --- Review request for Plasma. Repository: kio-extras Description --- This is what the core ioslaves such as file or http do. Also dropped the kio_ prefix to the library name since it isn't needed now that we install them into a kio directory Diffs - archive/CMakeLists.txt ec2cf7ad6c9c645e62a47c94ec617f8a37c5f708 archive/ar.protocol 7a848e505e5f00121e8ec5493564dfacdd405c31 archive/tar.protocol 19447a5e75b106e7a8c8e8396375bb1fc600a6da archive/zip.protocol ce7c54b4e92dfab29150246bf6588d1f8bb49057 bookmarks/CMakeLists.txt 703b109c2e049edecce1742482bd82e5c92caecd bookmarks/bookmarks.protocol 0642bd2f7277be8707351582f219281d45834fa6 desktop/CMakeLists.txt f7bd6709340a5f4e7e5f6fbd076400a76b526cd8 desktop/desktop.protocol 0e388386f1794dd90d445ec146ef54a04f595c8b filter/CMakeLists.txt 240cc7b57bd38e86fd50084e53c17f1672b2b946 filter/bzip.protocol 7d3cb570fbc534fbba22dd8e10472b47053c7195 filter/bzip2.protocol 1baaf7dd610f39325b2aa21bdee5bf1e63e5835f filter/gzip.protocol 8ed55ec16f49f42fe6d419327484b33d59ec537b filter/lzma.protocol 13bb28e3d870f8130d052efd97a5a688d9133c31 filter/xz.protocol f4fb7f01146cbf4d5afce528462e0c5dafa9591e fish/CMakeLists.txt 24136d4dac01a8a08db8d17380661a9051fa0b04 fish/fish.protocol ff5784eea877d0fd9a3c6ac4724056ddfd8fe5f2 info/CMakeLists.txt 0163e82c4f865e3fb3b09bf5ddd44e272ce9c609 info/info.protocol fa8cbb4f6eaaeeaf8bfdead0fad598df8fe588eb man/CMakeLists.txt 3343ed85978dbbfa72a5f2cc8530d0f0c043df48 man/man.protocol cc100ce5ec48b40c890abe5d7afdf02ef589810b network/ioslave/CMakeLists.txt 67fc482cd390f35fb2d5c1740994d2fe9db254f1 network/ioslave/network.protocol 1e10cc6c3a6aadf2ee6794ab36200ef6793e324e nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 nfs/nfs.protocol 85cf2035e44bf7bfe65d4e2b62d1f44fa05d6001 recentdocuments/CMakeLists.txt bc2b9dbf35428cf0dd1e6ad5c6e569806c92d47f recentdocuments/recentdocuments.protocol c0bf1ebd80a2c696cad3062ef047ac4847270fc5 settings/CMakeLists.txt 5a57a1840fb33b32701a6ecfff24c42739b05c45 settings/settings.protocol efb03e865594f30be5ed0d1013d31a0200eed816 sftp/CMakeLists.txt defb7dd041ebfd5af0ac19a252cc9f2f454f67f9 sftp/sftp.protocol ec15eeb26b3ce2efded173f4c7a4cd737e0a05f8 smb/CMakeLists.txt a3a772f3028995b811b01fcebe11d8715d3e1620 smb/smb.protocol e58597844ff8554e837f6ee8807d17820e377945 thumbnail/CMakeLists.txt f3733d452eb133d2b5a1445740db0312cd5d8251 thumbnail/thumbnail.protocol eef743ab5310007093e6a1c1ff6d8c258f1be5d9 trash/CMakeLists.txt 4ee03581f5d632282efb9b8902b3abb0e95d169c trash/trash.protocol 277698579c8a70bac5cadff5cc1f379053e4c61e Diff: https://git.reviewboard.kde.org/r/119081/diff/ Testing --- Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118417: [klipper] Port from KDebug to QDebug
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/#review58827 --- Shouldn't this rather use qCDebug() so that the output can be disabled? - Alexander Richardson On May 30, 2014, 12:29 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- (Updated May 30, 2014, 12:29 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDebug to QDebug Diffs - klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b Diff: https://git.reviewboard.kde.org/r/118417/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118073: Use QHostInfo in kio_nfs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118073/ --- Review request for Plasma. Repository: kio-extras Description --- Use QHostInfo in kio_nfs Diffs - nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 nfs/kio_nfs.cpp 293df2529a2488b7970dbe81a5ec202bc6a22742 Diff: https://git.reviewboard.kde.org/r/118073/diff/ Testing --- Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118015: Dont convert URLs with protocol h**p: to http:
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118015/ --- (Updated May 9, 2014, 11:51 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kio-extras Description --- All URL protocols with four letters starting with h and ending with p where the middle two characters are the same are automatically converted to http. This was introduced in r312725 to support those strange h**p://www.kde.org style URLs that people tend to post to message boards This no longer seems to be very common - remove this functionality since it also prevents any kioslave that uses e.g. a haab:/ or hbbp:/ protocol from working in e.g. dolphin. Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118015/diff/ Testing --- entering haap://foo.bar in the dolphin address bar no longer attempts to open the browser Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118017: Fix expansion of ~
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 7, 2014, 4:06 p.m.) Status -- This change has been discarded. Review request for Plasma and David Faure. Repository: kio-extras Description --- With QUrl we have to set the scheme manually, seems like KUrl defaulted to file://. Also removed the !isMalformed in the codition, QUrl(~) is malformed, whereas KUrl(~) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118017: Fix expansion of ~
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- Review request for Plasma. Repository: kio-extras Description --- With QUrl we have to set the scheme manually, seems like KUrl defaulted to file://. Also removed the !isMalformed in the codition, QUrl(~) is malformed, whereas KUrl(~) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118017: Fix expansion of ~
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 6, 2014, 2:42 p.m.) Review request for Plasma and David Faure. Changes --- Added dfaure since he knows a lot about KUrl vs QUrl Repository: kio-extras Description --- With QUrl we have to set the scheme manually, seems like KUrl defaulted to file://. Also removed the !isMalformed in the codition, QUrl(~) is malformed, whereas KUrl(~) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118017: Fix expansion of ~
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Doesn't pass before - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57402 --- On May 6, 2014, 2:42 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 6, 2014, 2:42 p.m.) Review request for Plasma and David Faure. Repository: kio-extras Description --- With QUrl we have to set the scheme manually, seems like KUrl defaulted to file://. Also removed the !isMalformed in the codition, QUrl(~) is malformed, whereas KUrl(~) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118017: Fix expansion of ~
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't pass before isMalformed is found by calling !uri().isValid(), which is !QUrl::fromUserInput(~).isValid(). Without removing the isMalformed check, it will never attempt to determine whether the file exists and therefore exists will always be false and the result is an empty URL then. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57402 --- On May 6, 2014, 2:42 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 6, 2014, 2:42 p.m.) Review request for Plasma and David Faure. Repository: kio-extras Description --- With QUrl we have to set the scheme manually, seems like KUrl defaulted to file://. Also removed the !isMalformed in the codition, QUrl(~) is malformed, whereas KUrl(~) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118017: Fix expansion of ~
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't pass before Alexander Richardson wrote: isMalformed is found by calling !uri().isValid(), which is !QUrl::fromUserInput(~).isValid(). Without removing the isMalformed check, it will never attempt to determine whether the file exists and therefore exists will always be false and the result is an empty URL then. This is the test I am using in KIO: http://paste.kde.org/ptyzmefz6 - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57402 --- On May 6, 2014, 2:42 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 6, 2014, 2:42 p.m.) Review request for Plasma and David Faure. Repository: kio-extras Description --- With QUrl we have to set the scheme manually, seems like KUrl defaulted to file://. Also removed the !isMalformed in the codition, QUrl(~) is malformed, whereas KUrl(~) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118017: Fix expansion of ~
On May 7, 2014, 12:01 a.m., David Faure wrote: See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. Okay, I guess this review can be dropped then, right? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57458 --- On May 6, 2014, 2:42 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 6, 2014, 2:42 p.m.) Review request for Plasma and David Faure. Repository: kio-extras Description --- With QUrl we have to set the scheme manually, seems like KUrl defaulted to file://. Also removed the !isMalformed in the codition, QUrl(~) is malformed, whereas KUrl(~) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117779: fix crash when textureNode-texture() is null
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- (Updated April 30, 2014, 2:21 p.m.) Status -- This change has been discarded. Review request for kde-workspace and Plasma. Repository: plasma-framework Description --- fix crash when textureNode-texture() is null I get this crash very frequently on my system. This is probably only fixing the symptom and not the underlying issue, however at least plasma no longer crashes every few minutes Diffs - src/declarativeimports/core/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708 Diff: https://git.reviewboard.kde.org/r/117779/diff/ Testing --- No longer crashes Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117779: fix crash when textureNode-texture() is null
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- Review request for kde-workspace and Plasma. Repository: plasma-framework Description --- fix crash when textureNode-texture() is null I get this crash very frequently on my system. This is probably only fixing the symptom and not the underlying issue, however at least plasma no longer crashes every few minutes Diffs - src/declarativeimports/core/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708 Diff: https://git.reviewboard.kde.org/r/117779/diff/ Testing --- No longer crashes Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117779: fix crash when textureNode-texture() is null
On April 25, 2014, 11:44 p.m., Thomas Lübking wrote: src/declarativeimports/core/windowthumbnail.cpp, line 231 https://git.reviewboard.kde.org/r/117779/diff/1/?file=268344#file268344line231 try before this call. Okay, just thought I'd exit early in that case and not bother with the other stuff. However is this an appropriate fix, or should it be done somewhere else? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56577 --- On April 25, 2014, 11:41 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- (Updated April 25, 2014, 11:41 p.m.) Review request for kde-workspace and Plasma. Repository: plasma-framework Description --- fix crash when textureNode-texture() is null I get this crash very frequently on my system. This is probably only fixing the symptom and not the underlying issue, however at least plasma no longer crashes every few minutes Diffs - src/declarativeimports/core/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708 Diff: https://git.reviewboard.kde.org/r/117779/diff/ Testing --- No longer crashes Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117779: fix crash when textureNode-texture() is null
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- (Updated April 26, 2014, 12:51 a.m.) Review request for kde-workspace and Plasma. Repository: plasma-framework Description --- fix crash when textureNode-texture() is null I get this crash very frequently on my system. This is probably only fixing the symptom and not the underlying issue, however at least plasma no longer crashes every few minutes Diffs (updated) - src/declarativeimports/core/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708 Diff: https://git.reviewboard.kde.org/r/117779/diff/ Testing --- No longer crashes Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117058: plasma-nm CMake fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/ --- (Updated March 27, 2014, 4:02 p.m.) Review request for Plasma. Changes --- Wrong group, it's not for frameworks even though that's for the frameworks port of plasma-nm. Repository: plasma-nm Description --- Don't find frameworks that are not required for compilation -- Also search CMAKE_PREFIX_PATH for the pkgconfig files This will be the default behaviour when requiring CMake = 3.1 Diffs - CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 Diff: https://git.reviewboard.kde.org/r/117058/diff/ Testing --- Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117058: plasma-nm CMake fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/ --- (Updated March 27, 2014, 6:59 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-nm Description --- Don't find frameworks that are not required for compilation -- Also search CMAKE_PREFIX_PATH for the pkgconfig files This will be the default behaviour when requiring CMake = 3.1 Diffs - CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 Diff: https://git.reviewboard.kde.org/r/117058/diff/ Testing --- Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114932: Use QExplicitlySharedDataPointer as the replacement of KSharedPtr
On Jan. 13, 2014, 2:25 p.m., Aurélien Gâteau wrote: Looks sane, at least it is much closer to the original code. I didn't know about QSharedData::ref() (I blame the lack of doc). I am curious about the performance issue you mention, can you expand on it? I doubt it is really measurable, but a QSharedPointer/QWeakPointer needs to perform two heap allocations (one for the object, one for the refcount block), whereas using QSharedData needs only one. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114932/#review47315 --- On Jan. 9, 2014, 8:14 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114932/ --- (Updated Jan. 9, 2014, 8:14 p.m.) Review request for Plasma and Aurélien Gâteau. Repository: plasma-framework Description --- This should be slightly more efficient than the solution from e7e2eedd which uses QWeakPointer and QSharedPointer Diffs - src/plasma/private/svg_p.h 16ed29638b6b253d1fefc220341b91f20c2d76d5 src/plasma/svg.cpp ae97783308574c9478b6f194b8460a457a2a187e Diff: https://git.reviewboard.kde.org/r/114932/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 114932: Use QExplicitlySharedDataPointer as the replacement of KSharedPtr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114932/ --- Review request for Plasma and Aurélien Gâteau. Repository: plasma-framework Description --- This should be slightly more efficient than the solution from e7e2eedd which uses QWeakPointer and QSharedPointer Diffs - src/plasma/private/svg_p.h 16ed29638b6b253d1fefc220341b91f20c2d76d5 src/plasma/svg.cpp ae97783308574c9478b6f194b8460a457a2a187e Diff: https://git.reviewboard.kde.org/r/114932/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113193: fix some warnings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- (Updated Oct. 13, 2013, 1:44 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- fix some warnings Diffs - src/shell/desktopview.cpp 8eda4be9bed60498a603c67a4234a8c669b729c0 src/scriptengines/qml/plasmoid/containmentinterface.cpp d7438506c6d120429d24d6680821030398af6101 src/declarativeimports/core/dialog.cpp 4f1d9c8d901b6ce5b14963229bf6b28fc57c8463 src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a Diff: http://git.reviewboard.kde.org/r/113193/diff/ Testing --- warnings are gone Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113193: fix some warnings
On Oct. 12, 2013, 9:23 p.m., Sebastian Kügler wrote: src/declarativeimports/core/dialog.cpp, line 63 http://git.reviewboard.kde.org/r/113193/diff/2/?file=200504#file200504line63 We normally use just 0 for this. I will change that before committing. Otherwise good to go in? - Alexander --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/#review41614 --- On Oct. 10, 2013, 10:40 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- (Updated Oct. 10, 2013, 10:40 p.m.) Review request for Plasma. Repository: plasma-framework Description --- fix some warnings Diffs - src/shell/desktopview.cpp 8eda4be9bed60498a603c67a4234a8c669b729c0 src/scriptengines/qml/plasmoid/containmentinterface.cpp d7438506c6d120429d24d6680821030398af6101 src/declarativeimports/core/dialog.cpp 4f1d9c8d901b6ce5b14963229bf6b28fc57c8463 src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a Diff: http://git.reviewboard.kde.org/r/113193/diff/ Testing --- warnings are gone Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 113193: fix some warnings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- Review request for Plasma. Repository: plasma-framework Description --- fix some warnings Diffs - src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a src/declarativeimports/core/dialog.cpp 4f1d9c8d901b6ce5b14963229bf6b28fc57c8463 src/plasma/private/runnerjobs.cpp 3c24c698bd293af9ea785ae08dab9f9804cd6f04 src/scriptengines/qml/plasmoid/containmentinterface.cpp d7438506c6d120429d24d6680821030398af6101 src/shell/desktopview.cpp 8eda4be9bed60498a603c67a4234a8c669b729c0 Diff: http://git.reviewboard.kde.org/r/113193/diff/ Testing --- warnings are gone Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113193: fix some warnings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- (Updated Oct. 10, 2013, 10:40 p.m.) Review request for Plasma. Repository: plasma-framework Description --- fix some warnings Diffs (updated) - src/shell/desktopview.cpp 8eda4be9bed60498a603c67a4234a8c669b729c0 src/scriptengines/qml/plasmoid/containmentinterface.cpp d7438506c6d120429d24d6680821030398af6101 src/declarativeimports/core/dialog.cpp 4f1d9c8d901b6ce5b14963229bf6b28fc57c8463 src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a Diff: http://git.reviewboard.kde.org/r/113193/diff/ Testing --- warnings are gone Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
