Re: Battery Monitor revamp
Hi! as some have already seen on my G+ page, I'm currently doing a complete UX revamp of the battery monitor plasmoid. Great work, looks really stunning! :-) What's missing: - Remaining time. There is no global category anymore and since we discourage and removed the option for displaying remaining time, I didn't see the need to implement it in solod so we can show it in eg. the battery advanced properties Oh noes! Please restore this option since it is crucial (well, for me at last). IMHO it would be a much more beloved feature if it was not hidden and could be enabled not only by modifying the config file. Please test and give me feedback Just from looking at your screen: All information is shown by default, right? Would it be an improvement having the additional batteries (mouse etc.) collapsed by default? What’s broken: - Backlight controls detection Just for my curisosity: I have an HP Envy 14 Spectre with backlit keys that may have 4 steps of brightness: off, low, med, high. Would I be able to set the brightness via GUI if you sort out the existing issues? Wow.. Yours, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
StackFolder graphical glitches
Hi Ural, I tested the latest stackfolder code and ran into some graphical glitches: Text color is now taken from scheme but has no glow which makes it hard to read. Also a highlighting would make sense. I compared the stackfolder plasmoid to the folderview plasmoid in the following screenshot to show what i mean: http://wstaw.org/m/2012/11/02/text.png Also the control panel icon size is slightly off as this screenshot demonstrates: http://wstaw.org/m/2012/11/02/iconsize.png Nevertheless great work! It would be cool if the fixes could be made. Thx, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stackfolder inclusion to 4.10 [attempt#2]
Hi Ural! I've added shadows for items text using QGraphicsDropShadowEffect. Much more readable now, great. Still it should obey the theme text color which is black instead of while. See sebas suggestion: Doesn't look like it's using the correct color from the theme (Theme::textColor), or is it? Now on to animation: I meant we can add some option/parameter to switch behavior of popup window during folder changing. In our distro it will hide/show and resize window to fit contents, in KDE - keep size. Yeah, this would be great. Another feature suggestion: It would be utterly cool to start typing and filter the files like e.g. the Takeoff plasmoid does: http://kde-apps.org/content/show.php?content=144078 Maybe you can use some code from there? Thanks for your contribution, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15359 --- Ship it! Ship It! - Andreas Demmer On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use window role to detect the dashboard
On July 4, 2012, 7:57 a.m., Andreas Demmer wrote: Ship It! I missed that windowRole would be a much better distinction than windowClass is when I initially implemented this effect. Your patch definitely makes sense, so ship it! - Andreas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15359 --- On June 28, 2012, 7:42 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- (Updated June 28, 2012, 7:42 p.m.) Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Description --- see bug. i guess the window role is the natural and more distinct hint. This addresses bug 302523. http://bugs.kde.org/show_bug.cgi?id=302523 Diffs - kwin/effects/dashboard/dashboard.cpp bb803a9 plasma/desktop/shell/dashboardview.cpp d6762b6 Diff: http://git.reviewboard.kde.org/r/105382/diff/ Testing --- yes, dashboard still triggers the effect, renamed xterm no longer Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Contribution proposal: Easier way to move windows between activities
Aaron J. Seigo wrote: in Share Like Connect, you can select the Connect button, select Activity and the activity you want [...] i don't know if it's fast enough Sounds consitant for things that should be always connected with eath other but I could imagine that for quick corrections (like chat windows opening on the wrong activity), even this would get in the way. I recieved the following suggestion from Lukas The best idea so far was to employ corner actions. When you hit top left corner with your mouse, you get Now Open Windows grid (something like expose in mac). When you hit the same corner when dragging the window, why not to have same with activities? So you can simply drag window to any activity in the activity preview grid (something like zoom out in earlier KDE versions) in less than 2-3 seconds with a single click :) Also Activites plasmoid in panel can be removed - important for the tablets/notebooks I like the idea of a simple drag'n'drop from windows corner and could think of this really being an enjoyable workflow. Yet, I see some issues needs to be solved with this workflow: 1. How making it obvious to the user that the opening grid are now activities instead of virtual desktops? We need to avoid any confusion. 2. How to handle many activities? Should we really show an activity grid which would become rather small for each activity when having more than 4-9 activities. Still, I like the idea of this grid even if it means that this would be largely implemented as KWin effect. Oh yeah, I can imagine Martin smiling now and thinking hehe, I told him KWin would be his fate :D Greets, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Contribution proposal: Easier way to move windows between activities
Hi, I recently started to use activities efficiently at work: One activity per project which makes it easy to have the according project folders opened etc. One major pain I ran into was to move windows from one activity to another. E.g. when working on activity 1 and recieving an instant message via kopete, the chat window will open in the current activity when it was not open before. If I notice now, that the chat is related to activity 2, it would be nice to easily move the chat window to activity 2. Instead, I have to right-click the title bar, select activities, check activity 2. Afterwards I have to right- click the title bar again, select activities and uncheck activity 1. This is way to unconvenient! My idea: Drag drag and hold the window over the activity plasmoid in the controlbar which would open the activity switcher. Now I continue to drag the window over the activity to which I would like to move it and drop it. I want to contribute this but would like to ask a few prerequisites. First: Is this behaviour compliant with how the plasma-desktop should feel like or does someone have a better suggestion how the workflow should be like? Second: I see from the pastebin plasmoid, that plasmoids already seem to support dragging things on them. Is it already possible do react on window- drag or does this have implications to add this feature to KWin? Maybe Martin can shed some light on this. Greets, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: new KWin effect: Dashboard
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ --- (Updated 2010-07-21 13:52:16.384053) Review request for kwin and Plasma. Changes --- Changelog: - removed Plasma dependency from dashboard_config - renamed blur role - small coding style fixes The source should be fine now to commit it to trunk. After committing, I will start to enhance the effect with logout-like blur and send the changes to review board again. Summary --- This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin. I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs. The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check. This addresses bugs dashboard, detection and hackish. https://bugs.kde.org/show_bug.cgi?id=dashboard https://bugs.kde.org/show_bug.cgi?id=detection https://bugs.kde.org/show_bug.cgi?id=hackish Diffs (updated) - trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1152500 trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1152500 trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1152500 trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PRE-CREATION trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1152500 trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1152500 trunk/KDE/kdelibs/plasma/windoweffects.h 1152494 trunk/KDE/kdelibs/plasma/windoweffects.cpp 1152494 Diff: http://reviewboard.kde.org/r/4332/diff Testing --- Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under all effects. If the plugin is enabled, its settings apply to the dashboard. Screenshots --- configuration dialog http://reviewboard.kde.org/r/4332/s/434/ dashboard with modified background http://reviewboard.kde.org/r/4332/s/435/ Thanks, Andreas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: new KWin effect: Dashboard
On 2010-07-05 06:16:45, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp, lines 58-62 http://reviewboard.kde.org/r/4332/diff/2/?file=29941#file29941line58 I'm not really sure if it is a good idea to make the blur option only available if blur is loaded. I can imagine situation like setting up the effects without having compositing enabled. Maybe it's better to just have the textbox and add a comment that blur effect is required for this option to work. This would also remove the Plasma dependency in the KCMs. Ok, I'll remove the Plasma dependency: The checkbox label already sais depends on `Blur´ effect On 2010-07-05 06:16:45, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h, line 20 http://reviewboard.kde.org/r/4332/diff/2/?file=29943#file29943line20 You should also use the namespace in the define, so KWIN_DASHBOARD_CONFIG_H I will also add the namespace to DASHBOARD_H in dashboard.cpp: KWIN_DASHBOARD_H On 2010-07-05 06:16:45, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h, line 196 http://reviewboard.kde.org/r/4332/diff/2/?file=29945#file29945line196 I would not call it ForceBlur. Just Blur. The other role is called Force, because it really forces blur in a code path where blur would be disabled. Ok. - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/#review6365 --- On 2010-06-29 19:29:38, Andreas Demmer wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ --- (Updated 2010-06-29 19:29:38) Review request for kwin and Plasma. Summary --- This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin. I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs. The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check. This addresses bugs dashboard, detection and hackish. https://bugs.kde.org/show_bug.cgi?id=dashboard https://bugs.kde.org/show_bug.cgi?id=detection https://bugs.kde.org/show_bug.cgi?id=hackish Diffs - trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1144343 trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1144343 trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1144343 trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PRE-CREATION trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1144343 trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1144343 trunk/KDE/kdelibs/plasma/windoweffects.h 1144345 trunk/KDE/kdelibs/plasma/windoweffects.cpp 1144345 Diff: http://reviewboard.kde.org/r/4332/diff Testing --- Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under all effects. If the plugin is enabled, its settings apply to the dashboard. Screenshots --- configuration dialog http://reviewboard.kde.org/r/4332/s/434/ dashboard with modified background http://reviewboard.kde.org/r/4332/s/435/ Thanks, Andreas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: new KWin effect: Dashboard
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ --- (Updated 2010-06-29 19:29:38.209000) Review request for kwin and Plasma. Changes --- - Atom name updated - Plasma dashboard now sets own window class - KWin now detects dashboard by its window class (no more hacks) - removed magic number for blur effect, moved to kwineffects and changed in blur effect, too - call reconfigure() in effect CTOR instead of duplicating code - implemented DTOR - brightness/saturation values are now handled as percentage - fixed blur region - removed german translation in .desktop files Summary --- This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin. I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs. The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check. This addresses bugs dashboard, detection and hackish. https://bugs.kde.org/show_bug.cgi?id=dashboard https://bugs.kde.org/show_bug.cgi?id=detection https://bugs.kde.org/show_bug.cgi?id=hackish Diffs (updated) - trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1144343 trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1144343 trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1144343 trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PRE-CREATION trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1144343 trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1144343 trunk/KDE/kdelibs/plasma/windoweffects.h 1144345 trunk/KDE/kdelibs/plasma/windoweffects.cpp 1144345 Diff: http://reviewboard.kde.org/r/4332/diff Testing --- Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under all effects. If the plugin is enabled, its settings apply to the dashboard. Screenshots --- configuration dialog http://reviewboard.kde.org/r/4332/s/434/ dashboard with modified background http://reviewboard.kde.org/r/4332/s/435/ Thanks, Andreas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: new KWin effect: Dashboard
On 2010-06-16 18:12:50, Martin Gräßlin wrote: I must agree with Aaron: I'm really glad we finally get a Dashboard effect (I remember that I wrote one about 4.1, but at that time Dashboard was so broken that I stopped working on it :-P) I'm not sure about the config options. Having them in effect config makes it a poweruser feature nobody will find. It's fine for development but for the release it's kind of useless. Such option might make sense in the dashboard config, but in general it looks quite a bit KDE 3-ish to change the level of gray ;-) The dashboard effect has the potential to be astonishing and I think it needs some Nuno love. Something special like we did for the logout effect. A kind of decent blur, so that we could enable it without harming the users who want to read something in the window. I need to ask Nuno... And if Plasma devs split Plasmoids from the wallpaper (needs KWin help) we can even do more awesome stuff like fading the Plasmoids to the top through all windows for same widget sets and a nice animation for dashboard widget set. I agree that animations would really enhance the effect. I propose to polish the current version according to your comments below and to push this into trunk when it opens again for 4.6. Then I have plenty of time to implement animations etc. in the 4.6 development cycle. What do you think? On 2010-06-16 18:12:50, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp, line 27 http://reviewboard.kde.org/r/4332/diff/1/?file=28777#file28777line27 Where does this magic number come from? And why is it required? This is set in window data to let the blur effect handle the blurring of the background. On 2010-06-16 18:12:50, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp, line 44 http://reviewboard.kde.org/r/4332/diff/1/?file=28777#file28777line44 we have reconfigure for reading the configuration values :-) Ah, crap, you are right. I'll change this to a reconfigure call. On 2010-06-16 18:12:50, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp, line 52 http://reviewboard.kde.org/r/4332/diff/1/?file=28777#file28777line52 In the dtor it's required to remove the property again. Please have a look at other effects which use xatoms. Ok, I'll implement the DTOR. Otherwise, the effect is not unloaded during the desktop session when deactivating in effect settings. On 2010-06-16 18:12:50, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp, line 70 http://reviewboard.kde.org/r/4332/diff/1/?file=28777#file28777line70 I would use percentage as brightness/saturation is such a nice [0.0, 1.0] interval Agreed. On 2010-06-16 18:12:50, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp, line 77 http://reviewboard.kde.org/r/4332/diff/1/?file=28777#file28777line77 Don't set this in each painting step. Set it in window activated. And as region you should use w-geometry(). The region is the area which is painted in the current rendering step. If another effect increases the region only parts of the dashboard would be blurred. Ah, I see. BTW: You just explained an issue, I have while patching the plasmoid-smooth-tasks. :-) On 2010-06-16 18:12:50, Martin Gräßlin wrote: trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop, line 7 http://reviewboard.kde.org/r/4332/diff/1/?file=28778#file28778line7 No need to translate, scripty will automatically overwrite it. I was unsure how KDE handles translations. I will read some information about it and change the desktop files accordingly. - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/#review6145 --- On 2010-06-15 20:31:15, Andreas Demmer wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ --- (Updated 2010-06-15 20:31:15) Review request for kwin and Plasma. Summary --- This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin. I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs
