Re: Review Request 120563: Add support for installing .comic packages again to plasmapkg2.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120563/ --- (Updated Sept. 15, 2016, 10:50 a.m.) Status -- This change has been discarded. Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and Martin Klapetek. Repository: plasma-framework Description --- This adds support for installing .comic type packages with plasmapkg2. This comes to help the comic dataengine port to frameworks, and permits the user to install .comic packages. Diffs - src/plasmapkg/plasmapkg.cpp 7d55d0f Diff: https://git.reviewboard.kde.org/r/120563/diff/ Testing --- Apply patch, rebuild plasma-framework, compile ok. Then install a .comic package from kde-files.org Plasma/Comics with plasmapkg2 -t comic -i ~/Downloads/garfield.comic. Expected results: Install method: plasmapkg2 -t comic -i ~/Downloads/92037-garfield.comic pluginname: "garfield" -- Copying "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" Copying metadata went ok. Successfully installed /home/developer/Downloads/92037-garfield.comic Remove method: plasmapkg2 -t comic -r ~/Downloads/92037-garfield.comic Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5" Successfully uninstalled /home/developer/Downloads/92037-garfield.comic Upgrade method: plasmapkg2 -t comic -u ~/Downloads/92037-garfield.comic Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5" Upgrading package from file: /home/developer/Downloads/92037-garfield.comic pluginname: "garfield" -- Copying "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" Copying metadata went ok. Successfully upgraded /home/developer/Downloads/92037-garfield.comic Thanks, Andrei Amuraritei
Re: Review Request 120563: Add support for installing .comic packages again to plasmapkg2.
> On Aug. 31, 2015, 1:41 p.m., Marco Martin wrote: > > Ship It! Is this still needed ? Comic works in Plasma 5 now. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120563/#review84629 --- On Oct. 12, 2014, 7:05 p.m., Andrei Amuraritei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120563/ > --- > > (Updated Oct. 12, 2014, 7:05 p.m.) > > > Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and > Martin Klapetek. > > > Repository: plasma-framework > > > Description > --- > > This adds support for installing .comic type packages with plasmapkg2. This > comes to help the comic dataengine port to frameworks, and permits the user > to install .comic packages. > > > Diffs > - > > src/plasmapkg/plasmapkg.cpp 7d55d0f > > Diff: https://git.reviewboard.kde.org/r/120563/diff/ > > > Testing > --- > > Apply patch, rebuild plasma-framework, compile ok. Then install a .comic > package from kde-files.org Plasma/Comics with plasmapkg2 -t comic -i > ~/Downloads/garfield.comic. > > Expected results: > > Install method: > plasmapkg2 -t comic -i ~/Downloads/92037-garfield.comic > > pluginname: "garfield" > -- Copying > "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" > "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" > Copying metadata went ok. > Successfully installed /home/developer/Downloads/92037-garfield.comic > > Remove method: > plasmapkg2 -t comic -r ~/Downloads/92037-garfield.comic > > Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5" > Successfully uninstalled /home/developer/Downloads/92037-garfield.comic > > Upgrade method: > plasmapkg2 -t comic -u ~/Downloads/92037-garfield.comic > > Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5" > Upgrading package from file: /home/developer/Downloads/92037-garfield.comic > pluginname: "garfield" > -- Copying > "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" > "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" > Copying metadata went ok. > Successfully upgraded /home/developer/Downloads/92037-garfield.comic > > > Thanks, > > Andrei Amuraritei > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Jan. 2, 2015, 11:30 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: what's the status of this? Andrei Amuraritei wrote: Hi there, this compiles and works, as best I could test it. Still needs work to port away from kde4support libs. Sadly my time with it has been null, too busy with work and other stuff still. Marco Martin wrote: can you push your work so far in a git branch? so is easy for people to try, and eventually contribute ;) David Edmundson wrote: As there has been no reply, I'm going to push this into master but leave the dataengine commented out in the CMakeLists.txt. There's no point shipping it till the plasmoid is done. To me the diff looks OK. Clearly a bit of work left, but what is here seems good. Sorry for not replying sooner, but I guess David did the better thing here. The engine works and I guess if people do really want to work on it (I still do), now they'll do it easier. On my part, I still need to get hold of the whole devel phase, so I'm slower. Thanks David. And Happy New Year to you all. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- On Jan. 2, 2015, 1:30 p.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Jan. 2, 2015, 1:30 p.m.) Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: what's the status of this? Hi there, this compiles and works, as best I could test it. Still needs work to port away from kde4support libs. Sadly my time with it has been null, too busy with work and other stuff still. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- On Oct. 17, 2014, 3:08 a.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 3:08 a.m.) Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 2:59 a.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Changes --- Fix Martin Klapetek reported issues. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs (updated) - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Oct. 13, 2014, 3:02 p.m., Martin Klapetek wrote: dataengines/comic/CMakeLists.txt, line 12 https://git.reviewboard.kde.org/r/120276/diff/3/?file=317961#file317961line12 Is the KDELibs4Support needed only because of the KStandardDirs? If yes, then let's port away from that as well, it's easy enough KDELibs4Support still needed for some other stuff (Solid and KService), need to port away from those, still wrapping my head around them. On Oct. 13, 2014, 3:02 p.m., Martin Klapetek wrote: dataengines/comic/CMakeLists.txt, lines 51-61 https://git.reviewboard.kde.org/r/120276/diff/3/?file=317961#file317961line51 These two could be merged into one Don't know if LINK_INTERFACE_LIBRARIES is really needed here so for commented out. Need some input from someone more knowledgeable about cmake building. On Oct. 13, 2014, 3:02 p.m., Martin Klapetek wrote: dataengines/comic/comic_package_plugin.cpp, line 21 https://git.reviewboard.kde.org/r/120276/diff/3/?file=317968#file317968line21 I think this should just go into comic_package.cpp to follow all the other exports, then this file can be removed This is exported in comicproviderkross.cpp because otherwise the engine doesn't detect the .comic packages. I get a plugin garfield could be created message when testing the engine with plasmaengineexplorer. On Oct. 13, 2014, 3:02 p.m., Martin Klapetek wrote: dataengines/comic/comicproviderwrapper.cpp, lines 762-771 https://git.reviewboard.kde.org/r/120276/diff/3/?file=317974#file317974line762 The coding style is no spaces inside ()s (I know it's not your code, but since you're touching it already, let's fix it) Also, do we need all this kind of information actually printed in the log? For now I think it's better to keep it. I am working on porting the applet also and until we have a working version I'd like to keep it here. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review68304 --- On Oct. 17, 2014, 2:59 a.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 2:59 a.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 3:08 a.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing (updated) --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 3:08 a.m.) Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120563: Add support for installing .comic packages again to plasmapkg2.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120563/ --- Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and Martin Klapetek. Repository: plasma-framework Description --- This adds support for installing .comic type packages with plasmapkg2. This comes to help the comic dataengine port to frameworks, and permits the user to install .comic packages. Diffs - src/plasmapkg/plasmapkg.cpp 7d55d0f Diff: https://git.reviewboard.kde.org/r/120563/diff/ Testing --- Apply patch, rebuild plasma-framework, compile ok. Then install a .comic package from kde-files.org Plasma/Comics with plasmapkg2 -t comic -i ~/Downloads/garfield.comic. Expected results: Install method: plasmapkg2 -t comic -i ~/Downloads/92037-garfield.comic pluginname: garfield -- Copying /home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop /home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop Copying metadata went ok. Successfully installed /home/developer/Downloads/92037-garfield.comic Remove method: plasmapkg2 -t comic -r ~/Downloads/92037-garfield.comic Trying to open ksycoca from /home/developer/.kde5-cache/ksycoca5 Successfully uninstalled /home/developer/Downloads/92037-garfield.comic Upgrade method: plasmapkg2 -t comic -u ~/Downloads/92037-garfield.comic Trying to open ksycoca from /home/developer/.kde5-cache/ksycoca5 Upgrading package from file: /home/developer/Downloads/92037-garfield.comic pluginname: garfield -- Copying /home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop /home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop Copying metadata went ok. Successfully upgraded /home/developer/Downloads/92037-garfield.comic Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 12, 2014, 7:06 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:15 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Changes --- Fix issues specified. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. File Attachments (updated) Rev2 of port https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/7b2d617f-1348-4b5c-ac9c-a4340436a47d__0002-Review-port-of-comic-dataengine.patch Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 dataengines/comic/plasma-dataengine-comic.desktop f9e5433 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Changes --- Fixed issues specified. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs (updated) - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 dataengines/comic/plasma-dataengine-comic.desktop f9e5433 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. File Attachments Rev2 of port https://git.reviewboard.kde.org/media/uploaded/files/2014/09/19/7b2d617f-1348-4b5c-ac9c-a4340436a47d__0002-Review-port-of-comic-dataengine.patch Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Sept. 19, 2014, 10:17 p.m., Martin Klapetek wrote: You need to select the Update diff to update the diff, not Add file ;) Done :) - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66978 --- On Sept. 19, 2014, 10:17 p.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 dataengines/comic/plasma-dataengine-comic.desktop f9e5433 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote: dataengines/comic/comic_package.cpp, line 49 https://git.reviewboard.kde.org/r/120276/diff/2/?file=313492#file313492line49 You're building this class as MODULE (ie. a plugin) but you don't define any plugin macro (K_PLUGIN_FACTORY), this can't work as a plugin without it Looks like you should keep this line (but port to K_PLUGIN_FACTORY) Please detail this. I've added #include KPluginFactory K_PLUGIN_FACTORY(ComicProviderKrossFactory, registerPluginComicProviderKross();) to comicproviderkross.cpp Old code had the usage of the old macro COMICPROVIDER_EXPORT_PLUGIN there. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66979 --- On Sept. 19, 2014, 10:17 p.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 dataengines/comic/plasma-dataengine-comic.desktop f9e5433 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote: dataengines/comic/comic_package.cpp, line 49 https://git.reviewboard.kde.org/r/120276/diff/2/?file=313492#file313492line49 You're building this class as MODULE (ie. a plugin) but you don't define any plugin macro (K_PLUGIN_FACTORY), this can't work as a plugin without it Looks like you should keep this line (but port to K_PLUGIN_FACTORY) Andrei Amuraritei wrote: Please detail this. I've added #include KPluginFactory K_PLUGIN_FACTORY(ComicProviderKrossFactory, registerPluginComicProviderKross();) to comicproviderkross.cpp Old code had the usage of the old macro COMICPROVIDER_EXPORT_PLUGIN there. Also should there be a K_EXPORT_PLASMA_PACKAGE_WITH_JSON(ComicPackage, plasma-packagestructure-comic.json) line at the end of comic_package.cpp ? - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66979 --- On Sept. 19, 2014, 10:17 p.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 dataengines/comic/plasma-dataengine-comic.desktop f9e5433 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 7:53 a.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comic_package_plugin.cpp d997947 dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
