Re: Review Request 115192: Fix building 32bit target on 64bit machine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115192/ --- (Updated Sept. 15, 2016, 11:18 a.m.) Status -- This change has been discarded. Review request for kdewin and Plasma. Repository: kdeplasma-addons Description --- with_SSE2_explicitly_enabled_if_x86 namespace is only implemented with THIS_PATH_WITH_SSE2_EXPLICTLY_ENABLED defined, this symbol is defined in render_with_SSE2_explicitly_enabled.cpp, but this source is only built when using a 32bit processor. In my case HAVE_PATH_WITH_SSE2_EXPLICITLY_ENABLED is defined, though, in global.h, since this is not a 64bit target. Diffs - wallpapers/mandelbrot/renderthread.cpp c1b5c60 Diff: https://git.reviewboard.kde.org/r/115192/diff/ Testing --- Tested using MSVC 2010, 32bit target, with ${CMAKE_SYSTEM_PROCESSOR}=AMD64 (it's a x86_64 processor) Thanks, Andrius da Costa Ribas
Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- (Updated April 3, 2015, 7:30 p.m.) Status -- This change has been marked as submitted. Review request for kdewin and Plasma. Changes --- Submitted with commit 99d968e1905cfd06bcd358b76177dba6c80f8dcb by Andrius da Costa Ribas to branch master. Repository: plasma-framework Description --- MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as a compile-time const expression (error C2051: case expression not constant) Diffs - src/plasma/private/framesvg_helpers.h 5b96cd5 Diff: https://git.reviewboard.kde.org/r/120877/diff/ Testing --- Builds with MSVC 2013 64bit. framesvg related tests pass, other unrelated tests still fail. Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master Start 1: plasma-dialogqmltest 1/10 Test #1: plasma-dialogqmltest ...***Failed1.15 sec Start 2: plasma-fallbackpackagetest 2/10 Test #2: plasma-fallbackpackagetest . Passed0.16 sec Start 3: plasma-packagestructuretest 3/10 Test #3: plasma-packagestructuretest ***Failed0.19 sec Start 4: plasma-packageurlinterceptortest 4/10 Test #4: plasma-packageurlinterceptortest ... Passed0.12 sec Start 5: plasma-pluginloadertest 5/10 Test #5: plasma-pluginloadertest Passed1.44 sec Start 6: plasma-framesvgtest 6/10 Test #6: plasma-framesvgtest Passed0.64 sec Start 7: coronatest 7/10 Test #7: coronatest .***Failed0.16 sec Start 8: plasma-storagetest 8/10 Test #8: plasma-storagetest .***Failed0.12 sec Start 9: plasma-sortfiltermodeltest 9/10 Test #9: plasma-sortfiltermodeltest . Passed0.14 sec Start 10: i18ndcheck Could not find executable SH-NOTFOUND Looked in the following places: SH-NOTFOUND SH-NOTFOUND.exe Release/SH-NOTFOUND Release/SH-NOTFOUND.exe Debug/SH-NOTFOUND Debug/SH-NOTFOUND.exe MinSizeRel/SH-NOTFOUND MinSizeRel/SH-NOTFOUND.exe RelWithDebInfo/SH-NOTFOUND RelWithDebInfo/SH-NOTFOUND.exe Deployment/SH-NOTFOUND Deployment/SH-NOTFOUND.exe Development/SH-NOTFOUND Development/SH-NOTFOUND.exe Unable to find executable: SH-NOTFOUND 10/10 Test #10: i18ndcheck .***Not Run 0.00 sec 50% tests passed, 5 tests failed out of 10 Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Jan. 10, 2015, 4:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120878: Remove unused header
On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: I should have asked, do you have commit access or do you need someone to merge this? I do have commit access, but I am okay if anyone commits it too. I just had little time to do so. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- On Out. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Out. 29, 2014, 2:27 a.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- (Updated Out. 30, 2014, 1:35 a.m.) Review request for kdewin and Plasma. Changes --- Fix coding style. Repository: plasma-framework Description --- MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as a compile-time const expression (error C2051: case expression not constant) Diffs (updated) - src/plasma/private/framesvg_helpers.h 5b96cd5 Diff: https://git.reviewboard.kde.org/r/120877/diff/ Testing --- Builds with MSVC 2013 64bit. framesvg related tests pass, other unrelated tests still fail. Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master Start 1: plasma-dialogqmltest 1/10 Test #1: plasma-dialogqmltest ...***Failed1.15 sec Start 2: plasma-fallbackpackagetest 2/10 Test #2: plasma-fallbackpackagetest . Passed0.16 sec Start 3: plasma-packagestructuretest 3/10 Test #3: plasma-packagestructuretest ***Failed0.19 sec Start 4: plasma-packageurlinterceptortest 4/10 Test #4: plasma-packageurlinterceptortest ... Passed0.12 sec Start 5: plasma-pluginloadertest 5/10 Test #5: plasma-pluginloadertest Passed1.44 sec Start 6: plasma-framesvgtest 6/10 Test #6: plasma-framesvgtest Passed0.64 sec Start 7: coronatest 7/10 Test #7: coronatest .***Failed0.16 sec Start 8: plasma-storagetest 8/10 Test #8: plasma-storagetest .***Failed0.12 sec Start 9: plasma-sortfiltermodeltest 9/10 Test #9: plasma-sortfiltermodeltest . Passed0.14 sec Start 10: i18ndcheck Could not find executable SH-NOTFOUND Looked in the following places: SH-NOTFOUND SH-NOTFOUND.exe Release/SH-NOTFOUND Release/SH-NOTFOUND.exe Debug/SH-NOTFOUND Debug/SH-NOTFOUND.exe MinSizeRel/SH-NOTFOUND MinSizeRel/SH-NOTFOUND.exe RelWithDebInfo/SH-NOTFOUND RelWithDebInfo/SH-NOTFOUND.exe Deployment/SH-NOTFOUND Deployment/SH-NOTFOUND.exe Development/SH-NOTFOUND Development/SH-NOTFOUND.exe Unable to find executable: SH-NOTFOUND 10/10 Test #10: i18ndcheck .***Not Run 0.00 sec 50% tests passed, 5 tests failed out of 10 Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120877: Convert switch statements to if/else due to MSVC limitation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- Review request for kdewin and Plasma. Repository: plasma-framework Description --- MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as a compile-time const expression (error C2051: case expression not constant) Diffs - src/plasma/private/framesvg_helpers.h 5b96cd5 Diff: https://git.reviewboard.kde.org/r/120877/diff/ Testing --- Builds with MSVC 2013 64bit. framesvg related tests pass, other unrelated tests still fail. Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master Start 1: plasma-dialogqmltest 1/10 Test #1: plasma-dialogqmltest ...***Failed1.15 sec Start 2: plasma-fallbackpackagetest 2/10 Test #2: plasma-fallbackpackagetest . Passed0.16 sec Start 3: plasma-packagestructuretest 3/10 Test #3: plasma-packagestructuretest ***Failed0.19 sec Start 4: plasma-packageurlinterceptortest 4/10 Test #4: plasma-packageurlinterceptortest ... Passed0.12 sec Start 5: plasma-pluginloadertest 5/10 Test #5: plasma-pluginloadertest Passed1.44 sec Start 6: plasma-framesvgtest 6/10 Test #6: plasma-framesvgtest Passed0.64 sec Start 7: coronatest 7/10 Test #7: coronatest .***Failed0.16 sec Start 8: plasma-storagetest 8/10 Test #8: plasma-storagetest .***Failed0.12 sec Start 9: plasma-sortfiltermodeltest 9/10 Test #9: plasma-sortfiltermodeltest . Passed0.14 sec Start 10: i18ndcheck Could not find executable SH-NOTFOUND Looked in the following places: SH-NOTFOUND SH-NOTFOUND.exe Release/SH-NOTFOUND Release/SH-NOTFOUND.exe Debug/SH-NOTFOUND Debug/SH-NOTFOUND.exe MinSizeRel/SH-NOTFOUND MinSizeRel/SH-NOTFOUND.exe RelWithDebInfo/SH-NOTFOUND RelWithDebInfo/SH-NOTFOUND.exe Deployment/SH-NOTFOUND Deployment/SH-NOTFOUND.exe Development/SH-NOTFOUND Development/SH-NOTFOUND.exe Unable to find executable: SH-NOTFOUND 10/10 Test #10: i18ndcheck .***Not Run 0.00 sec 50% tests passed, 5 tests failed out of 10 Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 115192: Fix building 32bit target on 64bit machine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115192/ --- Review request for kdewin and Plasma. Repository: kdeplasma-addons Description --- with_SSE2_explicitly_enabled_if_x86 namespace is only implemented with THIS_PATH_WITH_SSE2_EXPLICTLY_ENABLED defined, this symbol is defined in render_with_SSE2_explicitly_enabled.cpp, but this source is only built when using a 32bit processor. In my case HAVE_PATH_WITH_SSE2_EXPLICITLY_ENABLED is defined, though, in global.h, since this is not a 64bit target. Diffs - wallpapers/mandelbrot/renderthread.cpp c1b5c60 Diff: https://git.reviewboard.kde.org/r/115192/diff/ Testing --- Tested using MSVC 2010, 32bit target, with ${CMAKE_SYSTEM_PROCESSOR}=AMD64 (it's a x86_64 processor) Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: W7 Tab thumbnails in dolphin.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102758/ --- (Updated Oct. 5, 2011, 12:52 a.m.) Review request for KDE Base Apps, KDE Accessibility, kdewin, Plasma, Patrick Spendrin, and Peter Penz. Description --- Add Windows 7 tab thumbnails feature to dolphin. Mostly based on the example from http://nicug.blogspot.com/2011/03/windows-7-taskbar-extensions-in-qt-tab.html. An icon representation is used instead of actual thumbnails ( please agree that those microscopic previews are not useful at all ;] ). Changing an icon when url changes is also easier than checking all the time whether something inside the window has been changed. Using icons is a lot more KDE-ish and therefore more beautiful and user-friendly than the default Windows behavior ;). win7utils.h and win7utils.cpp are from https://github.com/xfreebird/blogstuff/tree/master/qt/thumbnailtabs_example1 with few adaptations. Diffs - dolphin/src/CMakeLists.txt 93225c5 dolphin/src/dolphinapplication.h 69d07c3 dolphin/src/dolphinapplication.cpp 0dc9c96 dolphin/src/dolphinmainwindow.h 9fb83bf dolphin/src/dolphinmainwindow.cpp 6ca6e59 dolphin/src/platform/win7utils.h PRE-CREATION dolphin/src/platform/win7utils.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102758/diff/diff Testing --- Tested using MSVC 2010 32 bit, in a Windows 7 64 bit machine. May need testing: - Compiling under mingw-w32 and mingw-w64 - Using Windows Vista or below to ensure there are no side-efects on a box without this feature. - Using Windows 8 (I don't know much about its bugs^H^H^H^Hfeatures ;] ) Known problems: - There is no way to know if KTabBar got a tab reordered, so the thumbnails won't be reordered, but their reference is still correct - Undefined behavior when dolphin gets unresponsive [e.g.: because of a defective kioslave], most of the code assume dolphin is okay [e.g.: QPixmap::grabWidget won't work in a frozen window]. Screenshots --- Tabs! http://git.reviewboard.kde.org/r/102758/s/281/ More Tabs! http://git.reviewboard.kde.org/r/102758/s/282/ Too many tabs! http://git.reviewboard.kde.org/r/102758/s/283/ Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: W7 Tab thumbnails in dolphin.
On Oct. 3, 2011, 1:15 p.m., David Faure wrote: Couldn't this be done higher in the stack, e.g. in KTabWidget or in Qt? Kevin Kofler wrote: Indeed, I think there should be some interface for this stuff in kdelibs, so that 1. applications don't have to add such platform-specific code and 2. the feature can also be implemented for our own Plasma Desktop workspace, and applications will automatically benefit (whereas with the current solution, they'd need more platform-specific code doing the same thing). Seeing KDE applications doing more things in a foreign desktop workspace than in our own doesn't look right to me. :-( (Yet another kdelibs feature that would justify doing a 4.8 release…) Martin Gräßlin wrote: if anyone wants to do the bits for Plasma, please see http://community.kde.org/KWin/Browser_Integration It just needs someone to implement and at least Mozilla already showed interest in adding support if we add that. Andrius da Costa Ribas wrote: My thoughts: - I did an first experiment with dolphin only, but yes, we all agree this might be inside some sort of library. - I don't think KTabWidget is an appropriate place to place this either, since we may want to generate previews of non tabbed interfaces (Konversation and Kate don't necessarily use tabs). It would be better to bind such interface into a KApplication (but not necessarily making it inside KApplication) - (this one more kind of brainstorming) Reading Martin and Kevin's comments, I think it would be good to have a single interface to window managers, in the same way phonon address multimedia stuff so the app should not care about whether VLC, Xine or DirectSound is being used, in the same way solid address hardware stuff so the app should not care about whether WMI or HAL is being used, this interface should work in a way the app should not care whether KWin, Mutter or dwm.exe is being used. - Seeing KDE applications doing more things in a foreign desktop workspace than in our own doesn't look right to me. - To me this would not look right if we were talking about GnomeShell or other X11 desktop... in this case I see this more like an OS thing (given that explorer can be replaced, but dwm can't). Also, I think implementing something ready for a foreign desktop encourages making the native desktop ready for it too ;). @Martin: I know almost nothing about x11-specific stuff to help out with plasma/kwin, but according to that link, the required elements are almost the same ( icon + title + thumbnail ), so I think it may be not hard to have a common interface, not just for this feature but for other wm features too ( I'm thinking about thumbnail toolbars on amarok and kopete, just like the ones in wmp, wlm and skype ;] ) I'm closing this request as discarded. By now I think the patch can be used in emerge scripts to help out tracking issues with this on different compilers and different windows boxes. I would like to know from plasma/kwin people their thoughts about a common interface as mentioned in my previous comment. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102758/#review7032 --- On Oct. 5, 2011, 12:52 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102758/ --- (Updated Oct. 5, 2011, 12:52 a.m.) Review request for KDE Base Apps, KDE Accessibility, kdewin, Plasma, Patrick Spendrin, and Peter Penz. Description --- Add Windows 7 tab thumbnails feature to dolphin. Mostly based on the example from http://nicug.blogspot.com/2011/03/windows-7-taskbar-extensions-in-qt-tab.html. An icon representation is used instead of actual thumbnails ( please agree that those microscopic previews are not useful at all ;] ). Changing an icon when url changes is also easier than checking all the time whether something inside the window has been changed. Using icons is a lot more KDE-ish and therefore more beautiful and user-friendly than the default Windows behavior ;). win7utils.h and win7utils.cpp are from https://github.com/xfreebird/blogstuff/tree/master/qt/thumbnailtabs_example1 with few adaptations. Diffs - dolphin/src/CMakeLists.txt 93225c5 dolphin/src/dolphinapplication.h 69d07c3 dolphin/src/dolphinapplication.cpp 0dc9c96 dolphin/src/dolphinmainwindow.h 9fb83bf dolphin/src/dolphinmainwindow.cpp 6ca6e59 dolphin/src/platform/win7utils.h PRE-CREATION dolphin/src/platform/win7utils.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r