Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
On April 23, 2015, 7:42 p.m., Bhushan Shah wrote: Ship It! What about the .cache discussion? debate on some other day? :P - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79387 --- On April 23, 2015, 7:25 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 23, 2015, 7:25 p.m.) Review request for Plasma, Bhushan Shah, Sebastian Kügler, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Save Cover art to a temporary folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces. Diffs - libs/mediacenter/mpris2/mpris2.cpp f03d062 Diff: https://git.reviewboard.kde.org/r/123467/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 23, 2015, 2:20 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Bhushan Shah, Sebastian Kügler, Shantanu Tushar, and Sinny Kumari. Changes --- Submitted with commit 8c416587adc8780639d3bef02c16a198f58b16f7 by Ashish Madeti to branch master. Repository: plasma-mediacenter Description --- Save Cover art to a temporary folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces. Diffs - libs/mediacenter/mpris2/mpris2.cpp f03d062 Diff: https://git.reviewboard.kde.org/r/123467/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 23, 2015, 7:25 p.m.) Review request for Plasma, Bhushan Shah, Sebastian Kügler, Shantanu Tushar, and Sinny Kumari. Changes --- Reverting back. Repository: plasma-mediacenter Description --- Save Cover art to a temporary folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces. Diffs (updated) - libs/mediacenter/mpris2/mpris2.cpp f03d062 Diff: https://git.reviewboard.kde.org/r/123467/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 22, 2015, 9:47 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Changes --- Use toNativeSeparators() for portability Repository: plasma-mediacenter Description (updated) --- Save Cover art to a temporary folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces. Diffs (updated) - libs/mediacenter/mpris2/mpris2.cpp f03d062 Diff: https://git.reviewboard.kde.org/r/123467/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Save Cover art to a temperoray folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces. Diffs - libs/mediacenter/mpris2/mpris2.cpp f03d062 Diff: https://git.reviewboard.kde.org/r/123467/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 22, 2015, 7:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Changes --- Create a path plasma-mediacenter/covers/ inside the temporary directory to store the cover arts. Repository: plasma-mediacenter Description --- Save Cover art to a temperoray folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces. Diffs (updated) - libs/mediacenter/mpris2/mpris2.cpp f03d062 Diff: https://git.reviewboard.kde.org/r/123467/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
On April 23, 2015, 4:05 a.m., Sebastian Kügler wrote: libs/mediacenter/mpris2/mpris2.cpp, line 33 https://git.reviewboard.kde.org/r/123467/diff/3/?file=362527#file362527line33 Actually, this is wrong now. Using the native separator may produce \ (on Windows, for example), which is then concatenated with a /-separated path. The old version was correct, though, as it used a path returned from QDir, which is separated by / (always, Qt does that internally), and you concat it with a /-separated path. That's the correct way to do it. This is a bit confusing, but a general rule of thumb is to *not* use QDir::separator() or QDir::toNativeSeparator() when you're building paths without user input or anything that's coming from external parts. 1. I am first concatenating QDir::tempPath() with QLatin1String(/plasma-mediacenter/covers/) and then passing them to toNativeSeparators(). Is it still wrong? 2. If I build paths without separator() and toNativeSeparator() will they still work on Windows? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79364 --- On April 22, 2015, 9:47 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 22, 2015, 9:47 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Save Cover art to a temporary folder. Include the path of the cover art in the metadata currently exposed with MPRIS interfaces. Diffs - libs/mediacenter/mpris2/mpris2.cpp f03d062 Diff: https://git.reviewboard.kde.org/r/123467/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121476: Port showdesktop applet to Plasma Next
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/ --- (Updated Jan. 5, 2015, 8:14 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Bhushan Shah, Martin Gräßlin, and Vishesh Handa. Repository: kdeplasma-addons Description --- Ported the Show Desktop applet to Plasma Next. Most of the code is derived from the old showdesktop applet. Diffs - applets/showdesktop/package/contents/config/main.xml PRE-CREATION applets/showdesktop/package/contents/ui/main.qml PRE-CREATION applets/showdesktop/package/metadata.desktop PRE-CREATION applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da applets/showdesktop/plugin/qmldir PRE-CREATION applets/showdesktop/plugin/showdesktop.h PRE-CREATION applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 config-kdeplasma-addons.h.cmake PRE-CREATION CMakeLists.txt db03015 applets/CMakeLists.txt ccd1bf7 applets/showdesktop/CMakeLists.txt eb53207 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121476: Port showdesktop applet to Plasma Next
On Jan. 2, 2015, 2:55 p.m., Martin Gräßlin wrote: The adjustments look good to me. If we want it for the next plasma release I call it a ShipIt. If we want to delay by one release the code could be extremely simplified by making use of https://git.reviewboard.kde.org/r/121667/ So should I push it or wait for https://git.reviewboard.kde.org/r/121667/ and simplify the code accordingly ? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review72912 --- On Dec. 19, 2014, 10:53 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/ --- (Updated Dec. 19, 2014, 10:53 p.m.) Review request for Plasma, Bhushan Shah, Martin Gräßlin, and Vishesh Handa. Repository: kdeplasma-addons Description --- Ported the Show Desktop applet to Plasma Next. Most of the code is derived from the old showdesktop applet. Diffs - applets/showdesktop/package/contents/config/main.xml PRE-CREATION applets/showdesktop/package/contents/ui/main.qml PRE-CREATION applets/showdesktop/package/metadata.desktop PRE-CREATION applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da applets/showdesktop/plugin/qmldir PRE-CREATION applets/showdesktop/plugin/showdesktop.h PRE-CREATION applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 config-kdeplasma-addons.h.cmake PRE-CREATION CMakeLists.txt db03015 applets/CMakeLists.txt ccd1bf7 applets/showdesktop/CMakeLists.txt eb53207 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121476: Port showdesktop applet to Plasma Next
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/ --- (Updated Dec. 19, 2014, 10:53 p.m.) Review request for Plasma, Bhushan Shah, Martin Gräßlin, and Vishesh Handa. Changes --- Added appropriate checks for whether the platform is X11 or not. Repository: kdeplasma-addons Description --- Ported the Show Desktop applet to Plasma Next. Most of the code is derived from the old showdesktop applet. Diffs (updated) - applets/showdesktop/package/contents/config/main.xml PRE-CREATION applets/showdesktop/package/contents/ui/main.qml PRE-CREATION applets/showdesktop/package/metadata.desktop PRE-CREATION applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da applets/showdesktop/plugin/qmldir PRE-CREATION applets/showdesktop/plugin/showdesktop.h PRE-CREATION applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 config-kdeplasma-addons.h.cmake PRE-CREATION CMakeLists.txt db03015 applets/CMakeLists.txt ccd1bf7 applets/showdesktop/CMakeLists.txt eb53207 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121476: Port showdesktop applet to Plasma Next
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/ --- Review request for Plasma and Bhushan Shah. Repository: kdeplasma-addons Description --- Ported the Show Desktop applet to Plasma Next. Most of the code is derived from the old showdesktop applet. Diffs - CMakeLists.txt db03015 applets/CMakeLists.txt ccd1bf7 applets/showdesktop/CMakeLists.txt eb53207 applets/showdesktop/package/contents/config/main.xml PRE-CREATION applets/showdesktop/package/contents/ui/main.qml PRE-CREATION applets/showdesktop/package/metadata.desktop PRE-CREATION applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da applets/showdesktop/plugin/qmldir PRE-CREATION applets/showdesktop/plugin/showdesktop.h PRE-CREATION applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121476: Port showdesktop applet to Plasma Next
On Dec. 13, 2014, 8:01 p.m., Vishesh Handa wrote: applets/showdesktop/plugin/showdesktop.h, line 49 https://git.reviewboard.kde.org/r/121476/diff/1/?file=332919#file332919line49 This timer isn't actually doing anything. If the timer is of no use, then I guess no point of the delay() slot either? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review71923 --- On Dec. 13, 2014, 7:44 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/ --- (Updated Dec. 13, 2014, 7:44 p.m.) Review request for Plasma and Bhushan Shah. Repository: kdeplasma-addons Description --- Ported the Show Desktop applet to Plasma Next. Most of the code is derived from the old showdesktop applet. Diffs - CMakeLists.txt db03015 applets/CMakeLists.txt ccd1bf7 applets/showdesktop/CMakeLists.txt eb53207 applets/showdesktop/package/contents/config/main.xml PRE-CREATION applets/showdesktop/package/contents/ui/main.qml PRE-CREATION applets/showdesktop/package/metadata.desktop PRE-CREATION applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da applets/showdesktop/plugin/qmldir PRE-CREATION applets/showdesktop/plugin/showdesktop.h PRE-CREATION applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121476: Port showdesktop applet to Plasma Next
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/ --- (Updated Dec. 13, 2014, 9:25 p.m.) Review request for Plasma and Bhushan Shah. Changes --- Fixed the issues pointed by Vishesh and IMHO delay(), reset() slots are not needed anymore. Repository: kdeplasma-addons Description --- Ported the Show Desktop applet to Plasma Next. Most of the code is derived from the old showdesktop applet. Diffs (updated) - CMakeLists.txt db03015 applets/CMakeLists.txt ccd1bf7 applets/showdesktop/CMakeLists.txt eb53207 applets/showdesktop/package/contents/config/main.xml PRE-CREATION applets/showdesktop/package/contents/ui/main.qml PRE-CREATION applets/showdesktop/package/metadata.desktop PRE-CREATION applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da applets/showdesktop/plugin/qmldir PRE-CREATION applets/showdesktop/plugin/showdesktop.h PRE-CREATION applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.
On Aug. 1, 2014, 11:06 p.m., Sinny Kumari wrote: mediaelements/mediaplayer/MediaPlayer.qml, line 108 https://git.reviewboard.kde.org/r/118406/diff/3/?file=294832#file294832line108 Rather than saying Please make sure the location is accessible and try again , it should be please make sure media exists. Media inaccesible could be due to multiple reason like renaming of media, deleting media or unmounting partition/device which is kind of deletion of media for my computer. Is it guaranteed that the error in video can only arise due to location not accessible (or because the file does not exist)? I have seen the same screen (as mentioned in the bug, https://docs.google.com/file/d/0Bxf5QIFnNjVeRHFCdzFkTVRtRDA) when the necessary codecs are not present. In that case, I guess we need some generic error message. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/#review63648 --- On Aug. 1, 2014, 9:33 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/ --- (Updated Aug. 1, 2014, 9:33 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 333764 http://bugs.kde.org/show_bug.cgi?id=333764 Repository: plasma-mediacenter Description --- If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. Diffs - mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c mediaelements/playlist/Playlist.qml 5dde297 Diff: https://git.reviewboard.kde.org/r/118406/diff/ Testing --- 1. Load media to a playlist. 2. Unmount the device containing media. 3. Check if the user is notified of the location being inaccessible --yes, the user is notified 4. Mount the device containing media and play a media from playlist. -- The media plays properly. File Attachments wihtout_i18n.png https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118734: Added MPRIS specifications Tracklist Interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/ --- (Updated June 20, 2014, 7:10 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Emmanuel Pescosta, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Added a MPRIS specifications Tracklist Interface, which will expose and give control over the current playlist on dbus. http://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html Diffs - libs/mediacenter/CMakeLists.txt 8d95cfc libs/mediacenter/mpris2/mediaplayer2player.h 7a2f583 libs/mediacenter/mpris2/mediaplayer2player.cpp 2de56c2 libs/mediacenter/mpris2/mediaplayer2tracklist.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2tracklist.cpp PRE-CREATION libs/mediacenter/mpris2/mpris2.h 1dd78ca libs/mediacenter/mpris2/mpris2.cpp b64ba04 shells/newshell/mainwindow.cpp 3c888f8 Diff: https://git.reviewboard.kde.org/r/118734/diff/ Testing --- Tested the properties using qdbusviewer. I created a qt console application for testing whether the signals are being emitted correctly and the methods are working. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118824: Fix for Bug 336414 - Playlist switching doesnt move highlight
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 336414 http://bugs.kde.org/show_bug.cgi?id=336414 Repository: plasma-mediacenter Description --- Whenever we added / removed any playlist, the highlight was stuck at one point i.e changing the playlist after that was not changing the highlight. This was happening because we were directly assigning value to multiplePlaylistList.currentIndex in qml code, which removed its previous binding. Instead we should emit the currentIndexChanged() signal and let the ListView do the rest. Diffs - libs/mediacenter/multipleplaylistmodel.cpp 87601f5 mediaelements/playlist/MultiplePlaylists.qml 4b085fe Diff: https://git.reviewboard.kde.org/r/118824/diff/ Testing --- Changed playlist after adding / removing a playlist. Now highlight is working fine Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118767: Fix for Bug 328532 - Remember the playlist I was using when I closed PMC last time
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/ --- (Updated June 19, 2014, 10 p.m.) Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 328532 http://bugs.kde.org/show_bug.cgi?id=328532 Repository: plasma-mediacenter Description --- PMC didn't used to remember the playlist I was on the last time, when restarting it. Now it saves the lastPlaylist while closing in the settings, and when starting it loads the value of lastPlaylist in settings Diffs (updated) - libs/mediacenter/playlistmodel.cpp dccaf52 Diff: https://git.reviewboard.kde.org/r/118767/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118767: Fix for Bug 328532 - Remember the playlist I was using when I closed PMC last time
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/ --- (Updated June 19, 2014, 5:14 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 328532 http://bugs.kde.org/show_bug.cgi?id=328532 Repository: plasma-mediacenter Description --- PMC didn't used to remember the playlist I was on the last time, when restarting it. Now it saves the lastPlaylist while closing in the settings, and when starting it loads the value of lastPlaylist in settings Diffs - libs/mediacenter/playlistmodel.cpp dccaf52 Diff: https://git.reviewboard.kde.org/r/118767/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118759: Add a separator to the path where PMC stores playlist file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Due to a lack of separator, PMC was storing the file in a different directory and reading playlists from a different directory. Diffs - Diff: https://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118759: Add a separator to the path where PMC stores playlist file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- (Updated June 15, 2014, 3:44 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Due to a lack of separator, PMC was storing the file in a different directory and reading playlists from a different directory. Diffs (updated) - libs/mediacenter/playlistmodel.cpp 4c52f00 Diff: https://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118759: Add a separator to the path where PMC stores playlist file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- (Updated June 15, 2014, 6 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Due to a lack of separator, PMC was storing the file in a different directory and reading playlists from a different directory. Diffs (updated) - libs/mediacenter/playlistmodel.cpp 4c52f00 Diff: https://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118759: Add a separator to the path where PMC stores playlist file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- (Updated June 15, 2014, 4:21 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Due to a lack of separator, PMC was storing the file in a different directory and reading playlists from a different directory. Diffs - libs/mediacenter/playlistmodel.cpp 4c52f00 Diff: https://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118734: Added MPRIS specifications Tracklist Interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/ --- (Updated June 14, 2014, 1:45 p.m.) Review request for Plasma, Emmanuel Pescosta, Shantanu Tushar, and Sinny Kumari. Changes --- Fixed the issues Repository: plasma-mediacenter Description --- Added a MPRIS specifications Tracklist Interface, which will expose and give control over the current playlist on dbus. http://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html Diffs (updated) - libs/mediacenter/CMakeLists.txt 8d95cfc libs/mediacenter/mpris2/mediaplayer2player.h 7a2f583 libs/mediacenter/mpris2/mediaplayer2player.cpp 2de56c2 libs/mediacenter/mpris2/mediaplayer2tracklist.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2tracklist.cpp PRE-CREATION libs/mediacenter/mpris2/mpris2.h 1dd78ca libs/mediacenter/mpris2/mpris2.cpp b64ba04 shells/newshell/mainwindow.cpp 3c888f8 Diff: https://git.reviewboard.kde.org/r/118734/diff/ Testing --- Tested the properties using qdbusviewer. I created a qt console application for testing whether the signals are being emitted correctly and the methods are working. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118734: Added MPRIS specifications Tracklist Interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/ --- Review request for Plasma, Emmanuel Pescosta, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Added a MPRIS specifications Tracklist Interface, which will expose and give control over the current playlist on dbus. http://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html Diffs - libs/mediacenter/CMakeLists.txt 8d95cfc libs/mediacenter/mpris2/mediaplayer2player.h 7a2f583 libs/mediacenter/mpris2/mediaplayer2player.cpp 2de56c2 libs/mediacenter/mpris2/mediaplayer2tracklist.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2tracklist.cpp PRE-CREATION libs/mediacenter/mpris2/mpris2.h 1dd78ca libs/mediacenter/mpris2/mpris2.cpp b64ba04 shells/newshell/mainwindow.cpp 3c888f8 Diff: https://git.reviewboard.kde.org/r/118734/diff/ Testing --- Tested the properties using qdbusviewer. I created a qt console application for testing whether the signals are being emitted correctly and the methods are working. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Change the currentIndex of playlistModel to -1 when a media is played from somewhere other than playlist. Diffs - libs/mediacenter/playlistmodel.h 0de7c56 shells/newshell/package/contents/ui/mediacenter.qml a859225 Diff: https://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- (Updated June 12, 2014, 10:52 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Used a slot instead of directly writing from QML code Repository: plasma-mediacenter Description --- Change the currentIndex of playlistModel to -1 when a media is played from somewhere other than playlist. Diffs (updated) - libs/mediacenter/playlistmodel.h 0de7c56 libs/mediacenter/playlistmodel.cpp c5ab1ab shells/newshell/package/contents/ui/mediacenter.qml a859225 Diff: https://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- (Updated June 12, 2014, 5:51 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Change the currentIndex of playlistModel to -1 when a media is played from somewhere other than playlist. Diffs - libs/mediacenter/playlistmodel.h 0de7c56 libs/mediacenter/playlistmodel.cpp c5ab1ab shells/newshell/package/contents/ui/mediacenter.qml a859225 Diff: https://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist
On June 12, 2014, 11:24 p.m., Mark Gaiser wrote: Why would you do it this way? I mean, you should have a model in the C++ side and you should have a view (probably ListView). Then you can just ask the view the count: http://qt-project.org/doc/qt-5/qml-qtquick-listview.html#count-prop i kinda miss the point of doing this via C++. But then again, i don't know the code in this project. I don't understand how 'count' is relevant here (I didn't get your point). We want to set the currentIndex (which points to the item currently playing in playlist) to -1 whenever a user plays something from other than playlist. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review59895 --- On June 12, 2014, 11:21 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- (Updated June 12, 2014, 11:21 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Change the currentIndex of playlistModel to -1 when a media is played from somewhere other than playlist. Diffs - libs/mediacenter/playlistmodel.h 0de7c56 libs/mediacenter/playlistmodel.cpp c5ab1ab shells/newshell/package/contents/ui/mediacenter.qml a859225 Diff: https://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118657/ --- (Updated June 12, 2014, 10:42 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Use beginMoveRows() and endMoveRows() instead of dataChanged() while moving items in playlistModel Diffs - libs/mediacenter/playlistmodel.cpp 158ca65 Diff: https://git.reviewboard.kde.org/r/118657/diff/ Testing --- Moved media around in playlist, its working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118657/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Use beginMoveRows() and endMoveRows() instead of dataChanged() while moving items in playlistModel Diffs - libs/mediacenter/playlistmodel.cpp 158ca65 Diff: https://git.reviewboard.kde.org/r/118657/diff/ Testing --- Moved media around in playlist, its working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118092: Left and right movement in All music
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/#review58040 --- Now if you are on Songs tab, a single left/right key press will take you to Artists/Albums section but when you return to Songs section, the focus is still on tab bar. Due to this user has to first go to the list by pressing down key once (not intuitive) whereas imho user should be able to continue from where he left. - Ashish Madeti On May 16, 2014, 8:48 a.m., Sujith Haridasan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- (Updated May 16, 2014, 8:48 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 334148 http://bugs.kde.org/show_bug.cgi?id=334148 Repository: plasma-mediacenter Description --- Left and right movement in All Music - Songs section. Now user can navigate left and right when in the songs section. And this is applicable only to the songs section. Diffs - components/listbrowser/ListBrowser.qml 202d406 Diff: https://git.reviewboard.kde.org/r/118092/diff/ Testing --- 1) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117801: Make PMC MPRIS compatible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- (Updated May 1, 2014, 2:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Add Dbus adaptors through which any other application can programmatically control PMC using MPRIS specifications. http://specifications.freedesktop.org/mpris-spec/latest/index.html Diffs - libs/mediacenter/CMakeLists.txt 37769f6 libs/mediacenter/mpris2/mediaplayer2.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2.cpp PRE-CREATION libs/mediacenter/mpris2/mediaplayer2player.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2player.cpp PRE-CREATION libs/mediacenter/mpris2/mpris2.h PRE-CREATION libs/mediacenter/mpris2/mpris2.cpp PRE-CREATION mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.h 9cbf77c shells/newshell/mainwindow.cpp c1be61a shells/newshell/package/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117801: Make PMC MPRIS compatible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Add Dbus adaptors through which any other application can programmatically control PMC using MPRIS specifications. http://specifications.freedesktop.org/mpris-spec/latest/index.html Diffs - libs/mediacenter/CMakeLists.txt 51f657a libs/mpris2/mediaplayer2.h PRE-CREATION libs/mpris2/mediaplayer2.cpp PRE-CREATION libs/mpris2/mediaplayer2player.h PRE-CREATION libs/mpris2/mediaplayer2player.cpp PRE-CREATION libs/mpris2/mpris2.h PRE-CREATION libs/mpris2/mpris2.cpp PRE-CREATION mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp cfbe097 shells/newshell/package/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117801: Make PMC MPRIS compatible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- (Updated April 27, 2014, 8:03 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Some problems with the previous diff Repository: plasma-mediacenter Description --- Add Dbus adaptors through which any other application can programmatically control PMC using MPRIS specifications. http://specifications.freedesktop.org/mpris-spec/latest/index.html Diffs (updated) - libs/mediacenter/CMakeLists.txt 37769f6 libs/mpris2/mediaplayer2.h PRE-CREATION libs/mpris2/mediaplayer2.cpp PRE-CREATION libs/mpris2/mediaplayer2player.h PRE-CREATION libs/mpris2/mediaplayer2player.cpp PRE-CREATION libs/mpris2/mpris2.h PRE-CREATION libs/mpris2/mpris2.cpp PRE-CREATION mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp c1be61a shells/newshell/package/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117801: Make PMC MPRIS compatible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- (Updated April 28, 2014, 12:20 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- 1) Relay a signal from MediaPlayer2 to MainWindow to raise PMC rather than passing a reference of MainWindow to MediaPlayer2 2) Make the signalPropertiesChange() of MediaPlayer2Player more genric 3) Move libs/mpris2/ to libs/mediacenter/mpris2/ and some other minor issues. Repository: plasma-mediacenter Description --- Add Dbus adaptors through which any other application can programmatically control PMC using MPRIS specifications. http://specifications.freedesktop.org/mpris-spec/latest/index.html Diffs (updated) - libs/mediacenter/CMakeLists.txt 37769f6 libs/mediacenter/mpris2/mediaplayer2.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2.cpp PRE-CREATION libs/mediacenter/mpris2/mediaplayer2player.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2player.cpp PRE-CREATION libs/mediacenter/mpris2/mpris2.h PRE-CREATION libs/mediacenter/mpris2/mpris2.cpp PRE-CREATION mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.h 9cbf77c shells/newshell/mainwindow.cpp c1be61a shells/newshell/package/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117801: Make PMC MPRIS compatible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- (Updated April 28, 2014, 12:42 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Change the include lines to point to the new location of mpris2/ Repository: plasma-mediacenter Description --- Add Dbus adaptors through which any other application can programmatically control PMC using MPRIS specifications. http://specifications.freedesktop.org/mpris-spec/latest/index.html Diffs (updated) - libs/mediacenter/CMakeLists.txt 37769f6 libs/mediacenter/mpris2/mediaplayer2.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2.cpp PRE-CREATION libs/mediacenter/mpris2/mediaplayer2player.h PRE-CREATION libs/mediacenter/mpris2/mediaplayer2player.cpp PRE-CREATION libs/mediacenter/mpris2/mpris2.h PRE-CREATION libs/mediacenter/mpris2/mpris2.cpp PRE-CREATION mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.h 9cbf77c shells/newshell/mainwindow.cpp c1be61a shells/newshell/package/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117510/ --- (Updated April 13, 2014, 4:59 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Remove the function extractAndSaveDurationInfo() and add a case for MediaCenter::DurationRole in setValueForRole(). Diffs - libs/mediacenter/media.cpp 3ba5d9e libs/mediacenter/medialibrary.h 3ac18a6 libs/mediacenter/medialibrary.cpp 713827a Diff: https://git.reviewboard.kde.org/r/117510/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117510/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Remove the function extractAndSaveDurationInfo() and add a case for MediaCenter::DurationRole in setValueForRole(). Diffs - libs/mediacenter/media.cpp 3ba5d9e libs/mediacenter/medialibrary.h 3ac18a6 libs/mediacenter/medialibrary.cpp 713827a Diff: https://git.reviewboard.kde.org/r/117510/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs - libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/media.h 2bdef4d libs/mediacenter/medialibrary.cpp 713827a libs/mediacenter/medialibrary.h 3ac18a6 libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/mediacenter.h a2855dd Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 4:21 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Fixed some issues with the previous diff. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs (updated) - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/medialibrary.cpp 713827a libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 6:32 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Made changes suggested by Shantanu Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs (updated) - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117365: Add Genre to metadata PMC keeps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 5, 2014, 3:32 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Added genre to metadata pmc keeps so that it too can be retrieved from the media library when needed. Diffs - libs/mediacenter/media.h 2bdef4d libs/mediacenter/media.cpp 32b9f19 libs/mediacenter/mediacenter.h a2855dd libs/mediacenter/mediacenter.cpp 35240d3 libs/mediacenter/pmcmedia.h 68275f2 libs/mediacenter/pmcmedia.cpp a266a26 libs/mediacenter/pmcmetadatamodel.cpp 2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 27, 2014, 8:33 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 12:16 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Implemented Rate property and polished a bit. Tested with mpristester : https://github.com/randomguy3/mpristester Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 mediaelements/playlist/Playlist.qml 5dde297 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 10:53 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Made necessary changes. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 12:32 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Completely implemented the Player adaptor. Tested with qdbusviewer and Now Playing plasmoid. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/playlist/Playlist.qml 5dde297 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 20, 2014, 7:53 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Adopted a better way of ensuring volume remains in bounds, as suggested by Emmanuel Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 20, 2014, 8:04 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- A typo in the previous patch. Sorry Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs (updated) - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
On March 20, 2014, 11 a.m., Sujith Haridasan wrote: Ashish can you explain why do we need session bus for every single adaptor? Just wanted to know what advantage would that make? We need to register each adaptor on session bus separately (i.e in their respective constructors) because if we register all the adaptors at one go, say in the constructor of MPRIS class, we will not be able to handle the events in a particular adaptor from QML (as QML will create a separate instance which has not been registered on sessionBus). Therefore, we use MPRIS adaptor only to register PMC as a service on session bus. Each adaptor registers itself as an object from its own constructor. PS: If we find that some adaptor has no relation whatsoever with QML, then we can register it right from MPRIS class (as a future change). - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review53474 --- On March 19, 2014, 10:52 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 19, 2014, 10:52 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review53324 --- shells/newshell/package/contents/ui/mediacenter.qml https://git.reviewboard.kde.org/r/116874/#comment37513 What if a user has paused and then clicked the next button. runtimeData.playing will be false but the next song should play. - Ashish Madeti On March 18, 2014, 7:59 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated March 18, 2014, 7:59 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - shells/newshell/package/contents/ui/mediacenter.qml b6cb87c Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116802: Fix for Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'
On March 15, 2014, 8:08 p.m., Sinny Kumari wrote: shells/newshell/package/contents/ui/mediacenter.qml, line 366 https://git.reviewboard.kde.org/r/116802/diff/1/?file=254061#file254061line366 Instead of pushing playlist and popping it back, its better to not push it. Just create the playlist using getPlaylist() and don't show it. I already tried it. When I did it without pushing and popping i.e just calling getPlaylist(), I got some wierd object in left top corner of PMC when I return to the welcome screen (Just after the media player page shows up). It hangs there until I open Playlists page. I couldn't figure out what it was. Please check it. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/#review52976 --- On March 14, 2014, 11:31 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- (Updated March 14, 2014, 11:31 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331919 http://bugs.kde.org/show_bug.cgi?id=331919 Repository: plasma-mediacenter Description --- When a media was played from a folder using Open With or is passed as an argument to PMC, playlist was shown instead of the media. This behavior is fixed in this patch. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 714e561 Diff: https://git.reviewboard.kde.org/r/116802/diff/ Testing --- Tested with both open with and command line arguments. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116802: Fix for Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- (Updated March 15, 2014, 9:20 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- No pushing and popping of playlist. Instead just created a playlist instance. Bugs: 331919 http://bugs.kde.org/show_bug.cgi?id=331919 Repository: plasma-mediacenter Description --- When a media was played from a folder using Open With or is passed as an argument to PMC, playlist was shown instead of the media. This behavior is fixed in this patch. Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml 714e561 Diff: https://git.reviewboard.kde.org/r/116802/diff/ Testing --- Tested with both open with and command line arguments. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116802: Fix for Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- (Updated March 15, 2014, 8:22 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331919 http://bugs.kde.org/show_bug.cgi?id=331919 Repository: plasma-mediacenter Description --- When a media was played from a folder using Open With or is passed as an argument to PMC, playlist was shown instead of the media. This behavior is fixed in this patch. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 714e561 Diff: https://git.reviewboard.kde.org/r/116802/diff/ Testing --- Tested with both open with and command line arguments. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116802: Fix for Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331919 http://bugs.kde.org/show_bug.cgi?id=331919 Repository: plasma-mediacenter Description --- When a media was played from a folder using Open With or is passed as an argument to PMC, playlist was shown instead of the media. This behavior is fixed in this patch. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 714e561 Diff: https://git.reviewboard.kde.org/r/116802/diff/ Testing --- Tested with both open with and command line arguments. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm
You should probably revert the lines you changed in MusicStats.qml file, as it may not be related to this particular bug. On Wed, Mar 12, 2014 at 12:44 AM, Atul Dubey sinister.co...@gmail.comwrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116736/ Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. By Atul Dubey. *Bugs: * 330115 http://bugs.kde.org/show_bug.cgi?id=330115 *Repository: * plasma-mediacenter Description Fixed the bug. Applied a new condition. Tested on local system. Diffs - mediaelements/mediaplayer/MusicStats.qml (178a37d) - mediaelements/mediawelcome/HomeScreenFooter.qml (d2c0eb7) View Diff https://git.reviewboard.kde.org/r/116736/diff/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- *Ashish Madeti* ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- (Updated March 10, 2014, 9:21 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 331888 http://bugs.kde.org/show_bug.cgi?id=331888 Repository: plasma-mediacenter Description --- Playing media while searching, often plays the wrong media. Diffs (updated) - libs/mediacenter/filterplaylistmodel.h 19688af libs/mediacenter/filterplaylistmodel.cpp ff546f8 libs/mediacenter/playlistmodel.h 52050fb mediaelements/playlist/Playlist.qml 0e87471 Diff: https://git.reviewboard.kde.org/r/116674/diff/ Testing --- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- (Updated March 10, 2014, 10:20 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Used ListView.Contain rather than ListView.Center Bugs: 331888 http://bugs.kde.org/show_bug.cgi?id=331888 Repository: plasma-mediacenter Description --- Playing media while searching, often plays the wrong media. Diffs (updated) - libs/mediacenter/filterplaylistmodel.h 19688af libs/mediacenter/filterplaylistmodel.cpp ff546f8 libs/mediacenter/playlistmodel.h 52050fb mediaelements/playlist/Playlist.qml 0e87471 Diff: https://git.reviewboard.kde.org/r/116674/diff/ Testing --- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- (Updated March 10, 2014, 5:08 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 331888 http://bugs.kde.org/show_bug.cgi?id=331888 Repository: plasma-mediacenter Description --- Playing media while searching, often plays the wrong media. Diffs - libs/mediacenter/filterplaylistmodel.h 19688af libs/mediacenter/filterplaylistmodel.cpp ff546f8 libs/mediacenter/playlistmodel.h 52050fb mediaelements/playlist/Playlist.qml 0e87471 Diff: https://git.reviewboard.kde.org/r/116674/diff/ Testing --- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 9, 2014, 8:03 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Fixed indentation mistakes. Bugs: 331820 http://bugs.kde.org/show_bug.cgi?id=331820 Repository: plasma-mediacenter Description --- When you delete a media from playlist while searching, often some other media gets deleted. Diffs (updated) - mediaelements/playlist/PlaylistDelegate.qml 644bfd0 mediaelements/playlist/Playlist.qml dbca104 libs/mediacenter/filterplaylistmodel.cpp e6f7053 libs/mediacenter/filterplaylistmodel.h aa1284b Diff: https://git.reviewboard.kde.org/r/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 9, 2014, 3:50 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331820 http://bugs.kde.org/show_bug.cgi?id=331820 Repository: plasma-mediacenter Description --- When you delete a media from playlist while searching, often some other media gets deleted. Diffs - mediaelements/playlist/PlaylistDelegate.qml 644bfd0 mediaelements/playlist/Playlist.qml dbca104 libs/mediacenter/filterplaylistmodel.cpp e6f7053 libs/mediacenter/filterplaylistmodel.h aa1284b Diff: https://git.reviewboard.kde.org/r/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 331888 http://bugs.kde.org/show_bug.cgi?id=331888 Repository: plasma-mediacenter Description --- Playing media while searching, often plays the wrong media. Diffs - mediaelements/playlist/Playlist.qml 0e87471 libs/mediacenter/playlistmodel.h 52050fb libs/mediacenter/filterplaylistmodel.h 19688af libs/mediacenter/filterplaylistmodel.cpp ff546f8 Diff: https://git.reviewboard.kde.org/r/116674/diff/ Testing --- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116674: Fix for Bug 331888 - Playing media when searching, often plays the wrong media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116674/ --- (Updated March 9, 2014, 11:49 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Now the correct view is played and the view is also centered on the media played. Bugs: 331888 http://bugs.kde.org/show_bug.cgi?id=331888 Repository: plasma-mediacenter Description --- Playing media while searching, often plays the wrong media. Diffs (updated) - libs/mediacenter/filterplaylistmodel.h 19688af libs/mediacenter/filterplaylistmodel.cpp ff546f8 libs/mediacenter/playlistmodel.h 52050fb mediaelements/playlist/Playlist.qml 0e87471 Diff: https://git.reviewboard.kde.org/r/116674/diff/ Testing --- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331820 http://bugs.kde.org/show_bug.cgi?id=331820 Repository: plasma-mediacenter Description --- When you delete a media from playlist while searching, often some other media gets deleted. Diffs - mediaelements/playlist/PlaylistDelegate.qml 644bfd0 Diff: https://git.reviewboard.kde.org/r/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 8, 2014, 7:34 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Made changes to FilterPlaylistModel to fix the bug. Bugs: 331820 http://bugs.kde.org/show_bug.cgi?id=331820 Repository: plasma-mediacenter Description --- When you delete a media from playlist while searching, often some other media gets deleted. Diffs (updated) - mediaelements/playlist/PlaylistDelegate.qml 644bfd0 mediaelements/playlist/Playlist.qml dbca104 libs/mediacenter/filterplaylistmodel.cpp e6f7053 libs/mediacenter/filterplaylistmodel.h aa1284b Diff: https://git.reviewboard.kde.org/r/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116656: Fix for Bug 331820 - Deleting items when searching removes the wrong items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 9, 2014, 5:20 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Added a remove function to the FilterModel itself, which will delete from source model after mapping the index to source. Bugs: 331820 http://bugs.kde.org/show_bug.cgi?id=331820 Repository: plasma-mediacenter Description --- When you delete a media from playlist while searching, often some other media gets deleted. Diffs (updated) - mediaelements/playlist/PlaylistDelegate.qml 644bfd0 mediaelements/playlist/Playlist.qml dbca104 libs/mediacenter/filterplaylistmodel.cpp e6f7053 libs/mediacenter/filterplaylistmodel.h aa1284b Diff: https://git.reviewboard.kde.org/r/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 9:12 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- There were some issues with the previous diff file, hoping this works fine. Bugs: 331798 http://bugs.kde.org/show_bug.cgi?id=331798 Repository: plasma-mediacenter Description --- Patch for Bug 331798 : Playlist shows the wrong song as now playing (in red color) in some cases of reordering the playlist. Diffs (updated) - libs/mediacenter/playlistmodel.h cb88c6c mediaelements/playlist/Playlist.qml d578720 mediaelements/playlist/PlaylistDelegate.qml a5f6ebb mediaelements/playlist/PlaylistDelegateLogic.js e69de29 Diff: https://git.reviewboard.kde.org/r/116640/diff/ Testing --- 1.Moved a song with index less than the currently playing media to some place below the currently playing media. 2.Moved a song with index greater than the currently playing media to some place above the currently playing media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in red color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 1:50 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Made changes to model instead of the view. Bugs: 331798 http://bugs.kde.org/show_bug.cgi?id=331798 Repository: plasma-mediacenter Description --- Patch for Bug 331798 : Playlist shows the wrong song as now playing (in red color) in some cases of reordering the playlist. Diffs (updated) - libs/mediacenter/playlistmodel.cpp 6477047 mediaelements/playlist/Playlist.qml d578720 mediaelements/playlist/PlaylistDelegate.qml a5f6ebb mediaelements/playlist/PlaylistDelegateLogic.js e69de29 Diff: https://git.reviewboard.kde.org/r/116640/diff/ Testing --- 1.Moved a song with index less than the currently playing media to some place below the currently playing media. 2.Moved a song with index greater than the currently playing media to some place above the currently playing media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in red color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 3:44 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Made changes suggested by Shantan. Bugs: 331798 http://bugs.kde.org/show_bug.cgi?id=331798 Repository: plasma-mediacenter Description --- Patch for Bug 331798 : Playlist shows the wrong song as now playing (in red color) in some cases of reordering the playlist. Diffs (updated) - libs/mediacenter/playlistmodel.h cb88c6c libs/mediacenter/playlistmodel.cpp 6477047 mediaelements/playlist/Playlist.qml d578720 mediaelements/playlist/PlaylistDelegate.qml a5f6ebb mediaelements/playlist/PlaylistDelegateLogic.js e69de29 Diff: https://git.reviewboard.kde.org/r/116640/diff/ Testing --- 1.Moved a song with index less than the currently playing media to some place below the currently playing media. 2.Moved a song with index greater than the currently playing media to some place above the currently playing media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in red color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 4:27 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 331798 http://bugs.kde.org/show_bug.cgi?id=331798 Repository: plasma-mediacenter Description --- Patch for Bug 331798 : Playlist shows the wrong song as now playing (in red color) in some cases of reordering the playlist. Diffs - libs/mediacenter/playlistmodel.h cb88c6c libs/mediacenter/playlistmodel.cpp 6477047 mediaelements/playlist/Playlist.qml d578720 mediaelements/playlist/PlaylistDelegate.qml a5f6ebb mediaelements/playlist/PlaylistDelegateLogic.js e69de29 Diff: https://git.reviewboard.kde.org/r/116640/diff/ Testing --- 1.Moved a song with index less than the currently playing media to some place below the currently playing media. 2.Moved a song with index greater than the currently playing media to some place above the currently playing media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in red color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote: After going to playlist like this, if you press back you get a blank screen with Loading spinner. Expected is the homescreen to come back. 1.Start PMC 2.Click on empty area (playlist shows) 3.Click back. I am getting homescreen only after step 3. Am I missing something here ? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52229 --- On March 6, 2014, 5:20 a.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 6, 2014, 5:20 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/ --- (Updated March 6, 2014, 2:22 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168 Now not only can you delete the media without playing it, it is easier to navigate the playlist then before. Diffs - mediaelements/playlist/PlaylistDelegate.qml e1bd31d mediaelements/playlist/Playlist.qml fd83c21 Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first
On March 6, 2014, 2:23 p.m., Shantanu Tushar wrote: I have merged this to master. Please note, please fill the bug field in reviewboard from the next time when you're fixing a bug. I will definitely keep that in mind from next time. Thank you very much for helping me in fixing the bug. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/#review52261 --- On March 6, 2014, 2:22 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/ --- (Updated March 6, 2014, 2:22 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168 Now not only can you delete the media without playing it, it is easier to navigate the playlist then before. Diffs - mediaelements/playlist/PlaylistDelegate.qml e1bd31d mediaelements/playlist/Playlist.qml fd83c21 Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 6, 2014, 4:17 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Made the code compact (1 line) as Shantanu suggested. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 6, 2014, 5:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 331798 http://bugs.kde.org/show_bug.cgi?id=331798 Repository: plasma-mediacenter Description --- Patch for Bug 331798 : Playlist shows the wrong song as now playing (in red color) in some cases of reordering the playlist. Diffs - mediaelements/playlist/PlaylistDelegate.qml e1bd31d mediaelements/playlist/PlaylistDelegateLogic.js e69de29 Diff: https://git.reviewboard.kde.org/r/116640/diff/ Testing --- 1.Moved a song with index less than the currently playing media to some place below the currently playing media. 2.Moved a song with index greater than the currently playing media to some place above the currently playing media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in red color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Bug 322820 - Playlist is not reachable from home screen
Hi Shantanu, If you think the 1st solution bring unnecessary clutter to the home screen , we can make it auto-hide like on the now playing screen. Another way to implement Solution 1, like if we presently click the empty area in the top and there is a media player instance it goes to it, we can make it go to the playlist page if there is no media player instance. On 4 March 2014 22:36, Shantanu Tushar Jha shaan...@gmail.com wrote: Hi Ashish, Solution 1 isn't very good because it brings unnecessary clutter to the home screen. Solution 2 is what we should be going for, however to get a menu item you'll have to create a new backend and this backend will need to run some QML code to bring up the playlist. Right now backends cannot do this, so in order to do this you'll have to add this capability to the backend system. Cheers, On Mon, Mar 3, 2014 at 9:14 PM, Ashish Madeti sskash...@gmail.com wrote: In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820 I have two solutions to the problem. 1. We can show the mediaController even on home screen (welcome screen). It will have an added advantage (can be implemented in near future) of directly playing the last selected playlist by clicking the play button on welcome screen. 2. We can add a menu item for Browse Playlists on welcome screen for music and videos. I will try to implement whichever is better. -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- *Ashish Madeti* 2nd Year Computer Science Engineering The LNM Institute of Information Technology Jaipur, Rajasthan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 5, 2014, 7:38 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Changed the if-else code format as pointed out by Sinny. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116626: Fix for Bug 325012 - Playlist reordering works only in one direction
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116626/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Playlist reordering used to work only in one direction i.e you could only drag a media to somewhere below it's current index. After this patch it will work both ways. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 Diff: https://git.reviewboard.kde.org/r/116626/diff/ Testing --- Reordered a playlist both ways. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/ --- Review request for Plasma. Repository: plasma-mediacenter Description --- Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168 Now not only can you delete the media without playing it, it is easier to navigate the playlist then before. Diffs - mediaelements/playlist/PlaylistDelegate.qml e1bd31d Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/ --- (Updated March 4, 2014, 3:17 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168 Now not only can you delete the media without playing it, it is easier to navigate the playlist then before. Diffs - mediaelements/playlist/PlaylistDelegate.qml e1bd31d Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/ --- (Updated March 4, 2014, 7:28 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- The previous patch made the view to scroll like crazy (as pointed out by Shantanu) when mouse pointer reached somewhat near the end of the view. Fixed by making a little change to Playlist.qml Repository: plasma-mediacenter Description --- Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168 Now not only can you delete the media without playing it, it is easier to navigate the playlist then before. Diffs (updated) - mediaelements/playlist/Playlist.qml fd83c21 mediaelements/playlist/PlaylistDelegate.qml e1bd31d Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/ --- (Updated March 5, 2014, 6:15 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- The previous patch didn't show the complete highlighted item (when it is cut off by the screen at the end). Now it does. Repository: plasma-mediacenter Description --- Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168 Now not only can you delete the media without playing it, it is easier to navigate the playlist then before. Diffs (updated) - mediaelements/playlist/PlaylistDelegate.qml e1bd31d mediaelements/playlist/Playlist.qml fd83c21 Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Bug 322820 - Playlist is not reachable from home screen
In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820 I have two solutions to the problem. 1. We can show the mediaController even on home screen (welcome screen). It will have an added advantage (can be implemented in near future) of directly playing the last selected playlist by clicking the play button on welcome screen. 2. We can add a menu item for Browse Playlists on welcome screen for music and videos. I will try to implement whichever is better. -- *Ashish Madeti* 2nd Year Computer Science Engineering The LNM Institute of Information Technology Jaipur, Rajasthan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
