Reminder: Plasma Meeting

[David Redondo]

Hello everyone,

please remember the Plasma meeting on Monday at 16:00 CET
(Europe stopped daylight savings, convert to your timezone: 
https://zonestamp.toolforge.org/1730732400)


https://meet.kde.org/b/dav-gqe-zqc-ngr

Topics and notes are collected here:
https://invent.kde.org/plasma/plasma-meetings/-/issues/4

David

P.S. Don't forget your homework!

Re: Plasma 6.3 schedule

[David Redondo]

Am Freitag, 18. Oktober 2024, 18:08:34 MESZ schrieb Jonathan Riddell:
> We should schedule Plasma 6.3
> 
> I've made a proposal on my Google calendar here
> https://calendar.google.com/calendar/u/0?cid=MDMxZ2tncWcxaGpmOGxjbWowZW0xZDJzajhAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ
> 
> I can't find the notes from the scheduling bof we had at Akademy so this is
> just using the current setup.
> 
> Rather than doing the beta straight after the 6.2.5 release, which would
> put it during the new year holidays, this suggestio is to put the repo
> freeze (alpha?) Jan 2nd, Beta two weeks later allows it to get Frameworks
> 6.10 so that's on mid-January 16 and release February 6th.
> 
> How's that?
> 
> Jonathan
> 

I will put it on the Agenda for monday

David

Reminder: Plasma Meeting

[David Redondo]

Hello everyone,

please remember the Plasma meeting today at 16:00 CEST:
https://meet.kde.org/b/dav-gqe-zqc-ngr

Topics and notes are collected here:
https://invent.kde.org/plasma/plasma-meetings/-/issues/2

David

P.S. Sadly I will not be able to attend again as I am returning from 
vacation

Reminder: Plasma meeting

[David Redondo]

Hello everyone,

please remember the first of our regular Plasma meetings, on Monday 16:00 CEST:
https://meet.kde.org/b/dav-gqe-zqc-ngr

Topics and notes are collected here: 
https://invent.kde.org/plasma/plasma-meetings/-/issues/1

The Agenda looks a bit empty so far so go ahead and fill it in now!

Thank you,
David

P.S. I am most likely not able to make the meeting, but I've heard another 
David will run the meeting.

Biweekly Plasma meetings

[David Redondo]

Hi,

as discussed at the BoF,  there is now a repo (thanks to Ben) to organise and 
keep track of Plasma video meetings. It also shortly explains how the whole 
process works. You can find it at https://invent.kde.org/plasma/plasma-meetings

The first meeting will be on 2024-09-23 16:00 CEST

Set the agenda at https://invent.kde.org/plasma/plasma-meetings/-/issues/1

David

[kwrited] [Bug 491272] Write Daemon/Local System Message Service does not show notifications sent using wall(1) or write(1)

[David Redondo]

https://bugs.kde.org/show_bug.cgi?id=491272

--- Comment #2 from David Redondo  ---
No this was certainly brainstormed but it's still there and released with
plasma 6 
https://invent.kde.org/plasma/kwrited

It also still works for me on plasma 6

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: feature freeze exception

[David Redondo]

Am Donnerstag, 21. März 2024, 16:51:00 CET schrieb Mike Noe:
> Hello fellow developers!
> 
> I'd like to request a feature freeze exception for 
> https://invent.kde.org/plasma/print-manager/-/merge_requests/116. I feel 
> that this is important to get into the next release because we've had a 
> couple of reports of users getting stuck when their printer is not 
> auto-discovered and adding it manually is not available, creating 
> confusion with the current System Settings. There are, however, 2 
> work-arounds, one involving the CUPS web interface and the other using 
> the older version of the "add printer" wizard.
> 
> As I am not subscribed to this mailing list, please use "Reply All" 
> rather than "Reply List".
> Thanks!
> 
> Mike
> 
> 
We are right now not in a feature freeze period.
If your patch fixes a bug, it's a bug fix :)
However it introduces new strings which is problematic.

David

Re: Wayland Nvidia situation for initial Plasma 6 release

[David Redondo]

Am Mittwoch, 7. Februar 2024, 10:37:13 CET schrieb Kai Uwe Broulik:
> Hi,
> 
> plasma-integration already (which I am NOT happy about!) creates a GL 
> context to check whether to use software rendering, there we could also 
> check the GL_VENDOR and set basic render loop.
> 
Yes we did that in 5 as well.
https://invent.kde.org/plasma/plasma-integration/-/merge_requests/119 now 
contains such a
check. 

Let's hope it's fixed properly in Qt 6.7!

David

Wayland Nvidia situation for initial Plasma 6 release

[David Redondo]

Hi, 

when using Wayland on Nvidia there is a significant problem that QtQuick 
windows freeze when resized, this can also manifest in plasma popups sometimes
not showing up. 
ref. https://bugreports.qt.io/browse/QTBUG-95817
This can be worked around with using the basic render loop instead of the 
threaded one.
With https://codereview.qt-project.org/c/qt/qtwayland/+/536040 Qt will now
disable threaded rendering on NVidia. However this patch missed 6.6.2 and will
be released with 6.6.3. Given that 6.6.2 is the latest patch version released
for Plasma 6.0 and the Wayland session is the new default we need to do 
something. Options that I can think of are

- tell distros to include this patch in their QtWayland builds
- disable threaded rendering in plasma-integration on Nvidia and running 
anything less than Qt 6.6.3

Thoughts?

David

Re: QML: a packagers nightmare. Assistance please.

[David Redondo]

Am Mittwoch, 8. November 2023, 12:22:33 CET schrieb Scarlett Moore:
> Hi everyone,
> As we progress through the Qt6 transition I have been trying to keep
> up on our QML dependencies and I keep tripping over circular
> dependency nightmare. We switched to a mega package format which
> includes qml modules. So we have big issues when frameworks like kwin
> depends on plasma-workspace. Introduced here:
> 
> https://invent.kde.org/plasma/kwin/-/commit/028dd552cfb9d826b40b9620d869c98d
> 2aa3dca3?page=2
> 
> Is it intended that qml modules in plasma-workspace are allowed to be
> used by frameworks? Are we wrong to bundle QML inside a mega package
> or is the framework wrong for depending on QML further up the stack?
> Any help or insight would be much appreciated.


CC'ing plasma-devel and distributions so stakeholders can chime in.

>From what I am seeing this patch causes KWin to import a qml module that lives 
in plasma-workspace 

import org.kde.plasma.workspace.components 2.0 as WorkspaceComponents

At the same time plasma-workspace build depends on KWin due to the need of the 
DBus xml files.

So the situation right now is that plasma-workspace build depends on KWin and 
KWin has a runtime dependency on plasma-workspace. 
I think it's not a full cycle since installing plasma-workspace does not need 
anything from KWin but maybe it can cause problems for distributions?

David

Re: Plasma 6 alpha modules list

[David Redondo]

Am Freitag, 27. Oktober 2023, 17:39:22 CET schrieb Jonathan Riddell:

> kwayland-integration - drop

No, it is needed for Qt5 apps.

David

Re: Plasma-integration and branches

[David Redondo]

Am Freitag, 16. Juni 2023, 13:37:20 CEST schrieb David Edmundson:
> We've discussed a few times an issue with plasma-integration and
> supporting Qt5 and Qt6 clients.
> 
> When we release Plasma 6, we need to ensure that a Qt5 and Qt6 builds
> are released. We need users to have both as they are plugins where
> users might have Qt5 and Qt6 codebases.
> 
> Right now master branch supports both. The Qt branches are massively
> divergent for Qt 5 and 6 clients and we're filling it with a huge mess
> of if statements and it's a pain to work on. There's patches blocked
> on needing ifdefs.
> 
> The proposal is we make a Plasma/6.0-qt5 branch based off the current
> Plasma/5.27 branch but fixing the version numbers.
> 
> At release time we will release a tarball from Plasma/6.0 and
> Plasma/6.0-qt5 with different tarball names.
> Translations would have to be considered. Pragmatically translations
> will be identical to 5.27, though it's not guaranteed.
> 
> Before we go ahead, are there any objections and can release team
> people and i18n confirm they're ok with the above.

Harald and I prototyped another solution to build a Qt
 5 and Qt 6 version out of the same repo and employed it on
plasma-integration: https://invent.kde.org/plasma/plasma-integration/-/
merge_requests/91
This has the advantage of having the code for both versions in 
the same place and the Qt5 version being not stuck on some old
 version. Also the translations can be shared automatically since 
they use the same catalog.
There is one case  where Qt uses unversioned targets and one
unversioned ecm variable but cadavidn be easily worked around.


> David
David

Re: kio-extras and the KF5/KF6 period

[David Redondo]

Am Mittwoch, 7. Juni 2023, 13:00:13 CEST schrieb Luigi Toscano:
> I think this is a different case: plasma-integration is part of plasma, and
> afaik the maser branch of all repositories which are part of plasma are
> Qt6-only already.

Note that plasma-integration is our Qt Platform Theme and is in the same 
situation as Breeze - we need to have a qt5 version for integration of Qt5 
Apps running under Plasma 6.

David

Re: kio-extras and the KF5/KF6 period

[David Redondo]

Am Donnerstag, 25. Mai 2023, 12:51:32 CEST schrieb Nicolas Fella:
> Hi,
> 
> Am 17.05.23 um 00:02 schrieb Albert Astals Cid:
> > kio-extras provides plugins for kio.
> > 
> > So KF5 applications want a KF5 kio-extras and KF6 applications want a KF6
> > kio- extras.
> 
> This is also the case in more places, e.g. Breeze/Oxygen and
> plasma-integration, so having a unified approach would make sense.
> 
> > If we're going to support a period on which we ship both Kf5 and KF6 based
> > applications we need to:
> > 
> > Make sure kf5 and kf6 are coinstallable.
> > 
> > a) release two tarballs, one for each KF
> 
> In some cases, where there is a large enough divergence between the 5
> and 6 code we might want to have separate branches to maintain those
> (e.g. master is Qt6 and we have a qt5-compat branch).
> 

I think plasma-integration is already at that point where it's very hard to 
maintain and do something because it's becoming a soup of #ifdefs.
Checking 5 vs. 6 but also checking Qt6 Patch levels which is only going to 
become worse in the future. For exmaple if we want to use  QNativeInterface 
API which theoretically would  make the code easier to read or dbus menu 
support which might end up needing to do different thing depending on the Qt 6
version.

So for plasma-integration I would like to no longer have 5 and 6 support in 
master.

Re: Adjusting Kickoff favorites for Plasma 5.27 not working anymore

[David Redondo]

I think this issue has been reported as 
https://bugs.kde.org/show_bug.cgi?id=448660
Seems distros resort to patching files, as these are installed maybe you can do 
so as 
well. On my system that is 
/usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/config/main.xml

David

Am Freitag, 19. Mai 2023, 18:06:38 CEST schrieb Oliver Freyermuth:
> (in case I ask at the wrong place, please redirect me)
> 
> Dear Plasma devs,
> 
> I'm trying to set Kickoff favorites in Plasma 5.27. The following
> Plasmascript worked fine with Plasma 5.20 previously, and the used config
> group and parameters are still documented in the Plasma scripting
> documentation:
> 
> 
> for (var i in panels()) {
>  var panel = panels()[i];
> 
>  for (var j in panel.widgetIds) {
>  var widget = panel.widgetById(panel.widgetIds[j]);
> 
>  if (widget.type == "org.kde.plasma.kickoff") {
>  print (widget);
>  widget.currentConfigGroup = ["General"];
> 
>  widget.writeConfig("favorites", [
>  'applications:gimp.desktop',
>  ]);
>  // Dirty hack:
>  widget.writeConfig('favoritesPortedToKAstats', false);
> 
>  widget.reloadConfig();
>  }
>  }
> }
> 
> 
> However, it seems to be ineffective with Plasma 5.27.
> 
> To my knowledge, favorites are now stored in kactivitymanager's SQLite DB,
> and their order in ~/.config/kactivitymanagerd-statsrc .
> 
> Is there a way to pre-set favorites for new accounts via plasma scripting
> working with Plasma 5.27?
> 
> Thanks in advance (and please RTFM me in case I missed some documentation),
>   Oliver
> 
> PS: Please keep me in CC, I'm not subscribed to the list. Thanks!

Re: Splitting KGlobalAccel interface and runtime

[David Redondo]

Am Montag, 13. Februar 2023, 21:05:33 CET schrieb Nicolas Fella:
> It wouldn't automatically solve the coinstallability problem of KF5 and
> KF6, because a kglobalacceld provided by KF5-KGlobalAccel would still
> conflict with a Plasma-provided kglobalacceld, but it's at least
> conceptually less messy since it's clear that the Plasma-provided one
> would be the preferred one to use.

While running both may never work, I would suggest making the KF6 kglobacceld
register a versioned name (i.e. org.kde.kglobalaccel6) instead of 
org.kde.kglobalaccel and have the interface talk to that name to avoid 
autostarting a KF5 kglobalacceld. 

We can also go further and version the whole API http://0pointer.de/blog/
projects/versioning-dbus.html to make changes easier in the future.

> This also means that a KF6-based kglobalacceld must work with a KF5 
interface library

The KF6 one should also register the old name and support the current DBus API
so KF5 applications will not autostart a KF5 kglobalacceld.

David

Re: make IDEs aware of the headers

[David Redondo]

Am Samstag, 7. Januar 2023, 16:40:27 CET schrieb Andrey Butirsky:


> > Other IDEs should benefit too.

KDevelop (and I think Kate too) displays headers in "Project" view without 
this. I am not convinced of this amount of work (and cluttering of our CMake 
files) to workaround IDE/editor deficiencies. While I don't know how easy it 
is to get at CMake is likely to have include info.

David

Re: Latte Dock 0.10.9

[David Redondo]

Am Mittwoch, 16. November 2022, 17:38:12 CET schrieb Jonathan Riddell:
> Hi Michael, I've been asking to make a new latte-dock bugfix release to
> include this Wayland fix
> https://invent.kde.org/plasma/latte-dock/-/commit/1d468a94e931d684f1ec180584
> eaa1d25765f100
> 
> I've made a tar from that 0.10 branch, could you check and tell me it's
> good to release?
> 
> http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/latte-dock/0.10.9_
> to_0.10.8/changes_report.html#CPPPrograms
> 
> http://embra.edinburghlinux.co.uk/~jr/tmp/latte-dock-0.10.9.tar.xz
> 
> Jonathan

Given without the fix it breaks should we release anyways? 
Or can we make a tar with only the one commit on top (i.e. a 10.8.1 or smth)?

David

Re: Cherry-picking policy

[David Redondo]

Am Samstag, 19. November 2022, 05:06:11 CET schrieb Ben Cooksley:
> Not sure how much of this is on our radar at the moment, but I do know that
> we were playing with a bot to do tagging of MRs at one point in time.
> 
> In terms of how this bot operates, how are people thinking it should work?

I quite like the way Qt does it, in the commit message footer you add 
for example 
"Pick to: 6.4 6.2"
and after the your change is merged to dev the bot creates MR for
the relevant branches.

Nate brought up label + milestone. Please correct me but you can only have one 
milestone I think. I guess it would need to work something like,
- if has "Cherry-pick" label and milestone LTS -> pick to LTS and stable
- if has "Cherry-pick" label and milestone stabel -> pick to stable

Do we have situations where we pick to more than stable and latest LTS?
The only thing that would come to my mind are security fixes after the
normal support period.

David

Re: Using layershell-qt

[David Redondo]

Am Freitag, 23. September 2022, 13:19:05 CEST schrieb Ralf Van Bogaert:
> Hi,
> 
Cool project, that you are trying to use layershell-qt with Qt6! 

> *qt.qpa.wayland: No shell integration named "layer-shell"
> foundqt.qpa.wayland: Loading shell integration failed.qt.qpa.wayland:
> Attempted to load the following shells QList("layer-shell")*
Qt can't find the layer shell plugin. 
Did you install the project after compiling?
If yes, is the install location somewhere that your Qt6 expects it to be? 
Otherwise you can use QT_PLUGIN_PATH to point to the directory it ends up in.
In your build folder should be 'prefix.sh' file that sets some environment 
variables so things in the install directory work/can be found.
For example in my build it contains the following line

export QT_PLUGIN_PATH=/home/david/kde/build6/install/lib/x86_64-linux-gnu/
plugins:$QT_PLUGIN_PATH


> Thanks in advance!
Hope I could provide some pointers in the right direction.

David

Re: semicolons and the policy that was none

[David Redondo]

Am 2022-08-10 15:57, schrieb Harald Sitter:

Aloha,

Someone recently dug up this page from 2012

https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks

First I'd like to point out that this page isn't a policy page, if it
was meant to be then it needs to be linked on the policies page and
supposedly somehow agreed upon, which I don't recall this one being
(but then I wasn't really following plasma 10 years ago).

Secondly, can we clarify our stance on semicolons?

a) we don't care, do whatever you feel like but be consistent with
your surrounding
b) use semicolons never [*unless required]
c) use semicolons always
d) use semicolons sometimes [*define sometimes]

Please cast votes


I vote for b)
I think its what people have been using recently
(and  a not entirely good reason, I think it looks better and writes 
more easily)



I vote for a) or b) because the point of having a policy on this
eludes me entirely

HS

Re: [GSoC Draft proposal] Redesign system settings modules by porting them to QtQuick

[David Redondo]

Am Freitag, 1. April 2022, 19:09:07 CEST schrieb Nate Graham:
> I would be willing to co-mentor alongside someone else with more dev
> experience.
I am happy to be co-mentor. As I was never a mentor before you can also mentor 
my mentoring ;)

-


>I'm looking for potentials mentors for GSoC 2022 to review/comment my draft
>proposal
Smit: I didn't look at the kcms in question at all but imo 1 week per kcm can 
be very steep.

David 

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

[David Redondo]

davidre added a comment.


  This has been done elsewhere

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D27036

To: davidedmundson, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26675: [sddm-theme] Don't have a broken reveal password button

[David Redondo]

davidre added a comment.


  we could install an icon into hicolor as fallback

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26675

To: davidedmundson, #plasma
Cc: davidre, ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: [sysadmin/repo-metadata] projects-invent/plasma/ksysguard: There's no ksysguard 5.23

[David Redondo]

Am Dienstag, 21. September 2021, 10:23:57 CEST schrieb Ben Cooksley:
> [...]
> [2021-09-20T19:24:50.371Z]  * KSysGuard

Afaik that's libksysguard and not ksysguard as in the repo, that's fine

> Currently the CI Dependency Build jobs for Plasma on the stable side are a
> sea of red.
> Can someone please take a look into this?

Seems to fail because wanting to check out the non-existing Plasma/5.23 branch 
from the ksysguard repo

Re: [sysadmin/repo-metadata] projects-invent/plasma/ksysguard: There's no ksysguard 5.23

[David Redondo]

Am Sonntag, 19. September 2021, 23:09:04 CEST schrieb Albert Astals Cid:
> Plasma devs if there will be no new ksysguard 5.22.x release please tell
> us and we'll clean it up from stable i18n

Hi Albert,

yes that's correct. From Plasma side there will be no further ksysguard 
releases. Of course someone can come around and make independent releases
in the future (like 5.22 was).

David

Re: KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.15 - Build # 295 - Failure!

[David Redondo]

Am Mittwoch, 1. September 2021, 00:01:49 CEST schrieb David Edmundson:
> CC'ing BSD people as only BSD is affected.
> 
> https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.1
> 5/295/
> 
> I'm stumped on this, the code looks fine.
> The build started failing from an SVN_SILENT translation update, so it's
> probably come from an external situation.
> 
> David

Job 297 just succeeded, so fine?

Other David

Re: ECM 5.85: introducing KDE_COMPILERSETTINGS_LEVEL concept

[David Redondo]

This (being the thing described in Friedrich's email, that was sent to
kde-devel and that I've attached below) is going to affect us. We migrated
to KDECompilerSettings because we were using KDEFrameworksCompilerSettings
when we should not have been and the find version bump hit us. At the moment
we are not setting KDE_COMPILERSETTINGS_LEVEL, so the next version bump is
going to enable stricter settings which could lead to a similar fallout.
In plasma-workspace this could already be observed, see
54cf81e79c4d1f79848a18d28dd378f4cf0ed786 and 
606ed4edc9800bd5e73560908cb2e56d7175d11f.

I see multiple options here:
- Do nothing and have drama on beta day with people scrambling to fix builds
  (current state)
- Do nothing at cmake level and hope people will fix things until the version
  bump (previous option with more optimism, result will probably be the same)
- Fix KDE_COMPILERSETTINGS_LEVEL at known working version (5.84.0) and only
  increase it manually when working on a repo or someone has the motivation to
  do all the work some time
- Commit version bumps earlier, not on beta day and have failing builds earlier

What do you think is the way we should follow this up with? Or maybe there are 
other
options that I've missed.

Regards,
David



Am Samstag, 14. August 2021, 12:06:19 CEST schrieb Friedrich W. H. Kossebau:
> Hi,
> 
> ((kde-core-devel as CC:, please reply only to kde-devel)
> 
> TL;DR
> Starting with ECM 5.85 KDECompilerSettings will provide some stricter
> settings, which you can control on the toplevel by
> KDE_COMPILERSETTINGS_LEVEL and then again per settings category, for a
> stable set of settings matching your project requirements across ECM
> versions, not affected by the minimal required ECM version.
> Make sure to include KDECompilerSettings right after find_package(ECM),
> before any other find_package() calls (best done in any case due to a
> current flaw). While your minimum required ECM version is < 5.85, no other
> change is needed. Port any usage of KDEFrameworkCompilerSettings outside of
> KDE Frameworks modules to that once you can afford to require ECM >= 5.85.
> For more, see docs on
> https://api.kde.org/ecm/kde-module/KDECompilerSettings.html
> 
> 
> This is a heads-up for a new mechanism introduced with ECM 5.85 to control
> the set of compiler settings for your project when using ECM's
> KDECompilerSettings (and your way out of repurposing
> KDEFrameworkCompilerSettings to easily gain a more strict set of settings).
> 
> It enables KDECompilerSettings to offer new variants of settings (which
> usually mean more strictness and enforcing usage of more modern standards),
> while allowing consumers to pin-point a certain settings variant as well as
> overwriting individual settings, without being coupled to the minimum
> required ECM version.
> 
> 
> Basic usage:
> 
> Set KDE_COMPILERSETTINGS_LEVEL to the version whose set of settings you
> desire right before including KDECompilerSettings,
> 
> find_package(ECM 5.85.0 NO_MODULE)
> set(CMAKE_MODULE_PATH /* other paths as needed */ ${ECM_MODULE_PATH})
> set(KDE_COMPILERSETTINGS_LEVEL 5.85.0)  # <- new, to set before
> including include(KDECompilerSettings NO_POLICY_SCOPE)
> 
> WARNING:
> Also make sure to call include(KDECompilerSettings) right after
> find_package(ECM), before any other find_package() calls. There is currently
> a design flaw in ECM code which relies on the minimum required version as
> passed to the find_package(ECM) call, and any further calls of
> find_package(ECM) like e.g. can happen in the chain behind
> find_package(KF5) can overwrite this with the version used in those calls
> (someone needed to fix this, you, dear reader?).
> As work-around for now everyone has to include the ECM modules right before
> invoking anything else.
> 
> 
> KDE_COMPILERSETTINGS_LEVEL cannot be higher than min required ECM:
> 
> As at the time of writing older ECM versions it cannot be foreseen what
> future ECM versions might have as new settings for their respective
> KDE_COMPILERSETTINGS_LEVEL version, the max version that can be used for
> KDE_COMPILERSETTINGS_LEVEL is the one of the minimum required ECM version.
> That ensures that for a given KDE_COMPILERSETTINGS_LEVEL version it is a
> known set of settings you can expect to be set.
> 
> 
> Setting KDE_COMPILERSETTINGS_LEVEL to not get new settings right now:
> 
> KDE_COMPILERSETTINGS_LEVEL <= 5.84.0 will give you the settings as used to
> before so far.
> KDE_COMPILERSETTINGS_LEVEL == 5.85.0 will bring lots of new strict settings,
> matching those of previous KDEFrameworkCompilerSettings and then some.
> Future KDE_COMPILERSETTINGS_LEVEL can then contain any more settings which
> seem sensible as default, whatever ECM community decides here.
> 
> 
> KDE_COMPILERSETTINGS_LEVEL defaulting to minimum required ECM version:
> 
> For convenience for those who are fine to also update their code to match
> latest settings when bumping the minimum required 

Re: The unfortunate state of Plasma's stable branch CI coverage

[David Redondo]

I executed the steps that David described and the dependency builds did 
succeed and the build queue is still filled at this moment. But the stable
jobs should now be on 5.22 I hope.

Regards,
David

Microsoft taking inspiration from Plasma slogan

[David Redondo]

Hi,

after many people saying that Windows 11 looks a bit similar to Plasma (which 
is not the focus of this message, please don't start discussing it in detail).
They are now using a very familiar slogan to promote Windows 11. Go to 
https://insider.windows.com/en-us/insidewindows11 and scroll down a bit. You 
will be greeted by 

Simple by default.
Powerful by choice.​

I think that's really bad for us. I fear that they can appropriate our slogan 
through their bigger reach and publicity resulting in us looking like copy 
cats every time we want to use our "Simply by default. Powerful when needed". 
I don't even want to think about what would happen if they would trademark it.

Our goal here should be to stop Microsoft from using it altogether. Please 
don't yet post on social media or on your blog and make a huge stir. We want 
to get this resolved as quickly as possible and public trouble may not help if
we can do this silently.
For this I would like to ask the board if they could reach out to Microsoft to 
try to get them stop copying our slogan.

Regards,
David

Re: Monday meeting notes for 14/06/2021

[David Redondo]

Am Montag, 14. Juni 2021, 15:43:52 CEST schrieb Nate Graham:
> KGlobaAccel seems somewhat fragile; I feel like every time anyone
> touches anything about it, stuff breaks. Is it possible to improve unit
> test coverage for it?

I don't think more testing of KGlobalAccel would solve the problem.
The problem is that not all of the behavior is clear from the API,
and contains some gotchas, see the linked MRs. So KGlobalAccel itself as the 
shortcut daemon works, but the client side API has room for improvement.

David

Fwd: Krunner plugins - basic questions from the new plasma dev

[David Redondo]

Forwarding to plasma-devel

--  Weitergeleitete Nachricht  --

Betreff: Krunner plugins - basic questions from the new plasma dev
Datum: Sonntag, 18. April 2021, 21:07:37 CEST
Von: Slawek Kaplonski 
An: kde-de...@kde.org

Hi,

I'm user of the KDE since some time and now I want to get more familiar with 
its codebase and development process.
I wanted to write some simple Krunner plugin. I started doing that with the 
[1] guide but it seems like a bit old and outdated in some places. Is there 
anything newer and more up to date maybe?
And also second question is about building and running such new plugin. I 
started doing it in Kdevelop. I found that there is krunner plugin template 
already there so I started with it. But how I should run this plugin from the 
IDE? Is it possible on the running (production) system or should I run it 
somehow in some "sandbox"? Is there any guide for that maybe? Thx in advance 
for any help. 

[1] https://techbase.kde.org/Development/Tutorials/Plasma4/AbstractRunner

-- 
Best regards
Sławek Kapłoński
sla...@kaplonski.pl



-

Re: Plasma 5.22 Kickoff Notes

[David Redondo]

Thank you for your opinion Marco.

Am Mittwoch, 10. März 2021, 09:30:35 CET schrieb Marco Martin:
> wasn't present at the kickoff meeting so commenting just here, just now.
> I'm quite against qqc2-breeze-style and i think it was a mistake.
> It was that the style used in plasma-mobile had bugs, so let's just
> write a whole new style from scratch putting more maintainance burden
> on the time being.

I also was worried about the maintenance burden in the meeting being double 
and having to keep everything in sync.
Furthermore a controls style does not only change the visuals but can also 
influence the behavior of the controls. I feel that the goal of qqc2-breeze-
style to be as similar as possible in that regard to the styles shipped with 
Qt is not one we should aim for. It means that it will lead to a (more) split
desktop experience, missing fixes in qqc2-desktop-style where the default 
behavior is different to widgets or just bad.

As written in the notes many of were suprised of the inclusion, including me.
I thought it would maybe go to extragear, but the issue I think was that the 
review mail never specified the intended place for the project.

Regards,
David

qqc2-breeze-style should use bugs.kde.org for bug tracking

[David Redondo]

Hi, 

I think when the gitlab migration happened, it was agreed that bug tracking 
still happens on bugs.kde.org and gitlab issues will eventually replace 
phabricator tasks.

The readme of qqc2-breeze-style includes: 
> # Bug Reports/Feature Requests/Issues:
>
>File your reports/requests here: 
>https://invent.kde.org/plasma/qqc2-breeze-style/-/issues

I think at least all repos part of plasma should stay consistent on where bugs 
are reported and qqc2-breeze-style should use bugzilla, too.

Thoughts on this?

Regards,
David

D23257: Allow for easier syncing of Plasma font

[David Redondo]

davidre closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23257: Allow for easier syncing of Plasma font

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> filipf wrote in sddmkcm.cpp:243
> Unfortunately not yet because we still need the `kdeglobals` file for color 
> schemes. From my previous testing it's not enough to just copy some line 
> `colorScheme=Adwaita`, we actually need to copy all of the color scheme 
> values written in `kdeglobals`. IIRC that was also a bit tricky just like 
> recreating the `fonts.conf` XML file, but it may be possible to reuse 
> existing KDE color scheme functions instead of copy-pasting from config files.

Alright

BRANCH
  arcpatch-D23257

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23257: Allow for easier syncing of Plasma font

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> sddmkcm.cpp:243
>  
>  if (!kdeglobalsPath.isEmpty()) {
>  args[QStringLiteral("kdeglobals")] = kdeglobalsPath;

Should I remove this then?

BRANCH
  arcpatch-D23257

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23257: Allow for easier syncing of Plasma font

[David Redondo]

davidre added a comment.


  I rebased it because of the rewrite that happened, can you check if 
everything is still ok @filipf

BRANCH
  arcpatch-D23257

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23257: Allow for easier syncing of Plasma font

[David Redondo]

davidre updated this revision to Diff 83430.
davidre added a comment.


  Rebase

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23257?vs=64999&id=83430

BRANCH
  arcpatch-D23257

REVISION DETAIL
  https://phabricator.kde.org/D23257

AFFECTED FILES
  src/sddmkcm.cpp

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23257: Allow for easier syncing of Plasma font

[David Redondo]

davidre added a comment.


  Everybody ok if I push this, before it is forgotten again?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  easier-font-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

[David Redondo]

davidre added a comment.


  Ping?

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D27036

To: davidedmundson, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Monday meeting notes for 9/11/2020

[David Redondo]

Am Montag, 9. November 2020, 15:22:51 CET schrieb Nate Graham:
> On 11/9/20 5:18 AM, Marco Martin wrote:
> > Missing form David Redondo:
> > * I made a simple patch so QMenus are polished before creating the
> > platform window
> > * https://codereview.qt-project.org/c/qt/qtbase/+/320154
> > <https://codereview.qt-project.org/c/qt/qtbase/+/320154>
> > *  Which was the cause for ugly menus appearing in some places
> 
> Nice! Does this fix https://bugs.kde.org/show_bug.cgi?id=428095 or
> https://bugsfiles.kde.org/attachment.cgi?id=133043 or both or neither?
> 
> Nate

Would need some investigation,
the instance which led me to the above was right clicking on menu bars.
However I found one place where the application was the cause by explicitly
creating the window right after constructing the menu (submitted a MR for that 
too of course)

David

Re: Plasma and a bachelor thesis

[David Redondo]

Hi Ilya,

> That's fair. Even though the format would declare it an engineering thesis
> and shift the focus more to the code, I would still need to show research
> skills, explain the novelty of this work (maybe by using a more general
> topic name) and write plenty of text. Do you think the topic allows for
> that?

I think such a topic fits a thesis quite well. I do not know the requirements 
of your university for a Bachelor's thesis but I think it could also work as a 
Master's thesis depending on the scope with which you are approaching the 
topic. Ample opportunity to write about current/past approaches done by other
software, IPC mechanisms and what you end up doing for whatever reasons.
 
> 
> Best regards,
> 
> Ilya

Best Regards,
David

Plasma Beta Review Day

[David Redondo]

Hi, 

during the last kickoff meeting we decided to hold a public Plasma Beta Review 
day on BBB to get more feedback on the beta release.  The date in the wiki is 
Thursday next week (exactly one week after the beta). If we want to go through 
with this idea, we need to decide on a time frame and publicly announce it 
somewhere. 
I think the time frame should not be to small so that everybody can have a 
chance to join and report their experience. Maybe promo (CC'ed) can help with 
announcing the session on the main KDE channels?
I also CC'ed sysadmin for the needed scaling of the BBB instance.

Best Regards,
David

Relicensing a file in Dr. Konqi

[David Redondo]

Hello Hans,
 
we are currently converting copyright headers to SPDX expressions to be in 
line with the REUSE specification, see https://phabricator.kde.org/T12528
and https://invent.kde.org/teams/licensing
During this I found this file https://invent.kde.org/plasma/drkonqi/-/blob/
master/src/drkonqi.cpp which seems to be partly licensed as GPL-2+ and partly 
as MIT because it includes code that you originally contributed under this 
license.
Are you okay with relicensing your code from MIT to GPL-2+?

Best Regards,
David

Monday Meeting Notes for 10/08/2020

[David Redondo]

Nico:
- Update Flatpak runtime to KF5 5.73 
https://invent.kde.org/packaging/flatpak-kde-runtime/-/merge_requests/17
- Tweak some margins in the dialer: https://invent.kde.org/plasma-mobile/
plasma-dialer/-/merge_requests/20
- Some code cleanup in Kongress
- Fix passive notification padding when using Plasma style: https://
invent.kde.org/frameworks/kirigami/-/merge_requests/72
- Allow refreshing device list in kdeconnect-app: https://invent.kde.org/
network/kdeconnect-kde/-/merge_requests/306
- Cleanup kirigami app template: https://invent.kde.org/frameworks/kirigami/-/
merge_requests/71
- Fix PC3 toolbar https://invent.kde.org/frameworks/plasma-framework/-/
merge_requests/62 https://invent.kde.org/frameworks/plasma-framework/-/
merge_requests/63

Arjen:
- so the biggest thing is that I merged the actiontoolbar rewrite to Kirigami 
last week which had a bit of fallout (as I kinda expected) and a few more 
issues popped up
- the fallout was mostly windows build failing (which is fixed) and the unit 
test failing (which is ongoing)
- the main issue now remaining is that toolbuttons with menus don't display 
correctly when non-flat which turns out to be a problem with breeze since that 
lacks menu arrows for instant-popup toolbuttons
- the plan there is to add that functionality to breeze, then fixup qqc2-
desktop-style and kirigami to make use of it
- there's also a Qt bug I filed because the toolbutton change I did triggers a 
very unexpected binding loop
see https://bugreports.qt.io/browse/QTBUG-85941

David E:
- I merged the wayland klipper side
- It exposes a race at a protocol level - clipbord replacements in wayland 
aren't necessarily atomic
- I have a horribly bodgy workaround, but it seems to work - I have yet to 
fully merge the workaround
- Nvidia did a big update and it's caused a mess :/ 
   systemsettings randomly will stop showing the sidebar even after restarting 
systemsettings
   so there must be something about creating multiple contexts in one app? Not 
sure of the details, fortunately I can now reproduce that 
   But this potentially could end up quite a major problem if we don't 
diagnose what's wrong and get a fix soo

Kai Uwe:
plasma-browser-integration:
* Released version 1.7.6 \o/
* https://blog.broulik.de/2020/08/plasma-browser-integration-1-7-6/
* Patch to calculate transfer speed manually if download size isn't known, 
please review: https://invent.kde.org/plasma/plasma-browser-integration/-/
merge_requests/8
* Split "page" context menus from links
* There's a regression in the release on Firefox where right clicking on an 
empty are in the page doesn't offer KDE Connect sharing anymore, please 
review: https://invent.kde.org/plasma/plasma-browser-integration/-/
merge_requests/9
  * Might warrant doing a 1.7.6.1 for Firefox
* Also added the share entry to the tab bar, so you can right click a tab to 
send it
PowerDevil:
* Introduce dedicated "turn off keyboard backlight" action, please review: 
https://invent.kde.org/plasma/powerdevil/-/merge_requests/17
  * Especially some hints on how to make a proper kconf update script would be 
appreciated 
[hint were given by d_ed, see https://phabricator.kde.org/P628]
* Remove shortcut migration code, please review: https://invent.kde.org/
plasma/powerdevil/-/merge_requests/16
* Fixed keyboard backlight not turning back on when closing the lid to suspend 
and then waking back up
KWin:
* Apply maximize animation also to full screen changes: https://
invent.kde.org/plasma/kwin/-/merge_requests/171
* d_ed had the idea of installing the effect twice and then using plugin ID to 
distinguish the two, so we have a dedicated "full screen" effect
* Will need to look into that, might need to expose the plugin ID through 
KWin effects API first
Solid:
* Anything else left for imobile backend? https://invent.kde.org/frameworks/
solid/-/merge_requests/9

Aleix:
- I've been mostly working on the input method v1 support for wayland which is 
mostly ready right now, it has some annoyances with maliit that I'm looking to 
polish so not to break plasma mobile
- I think I've hit some kind of bug deep in Qt so there's that...
- but it only happens when explicitly closing the keyboard other than that it 
works well
- all screencasting stuff should be merged, I hope you all are testing it 
already :D
- [d_ed]: there's been some Qt upstream reviews for keyboard input stuff 
lately, I don't know if it's relevant
-my problem is related to issuing the set_input_mask call
- it's in wl_surface
- null requests are never issued for some reason; issued or received, one of 
those

Marco:
# Plasma
* made breeze decoration use global animation duration
* made a branch for the top headerbar area in breeze qstyle different approach 
to one by Jan, but that has problems as well... i guess hacky thing is hacky 
(giving up in trying to have fluid animations: i guess the only way to make it 
work is the (hacky) thing some style do of having all windows argb and have

Re: Plasma related BoFs at Akademy 2020

[David Redondo]

Hi Aleix,

Am Montag, 3. August 2020, 16:40:21 CEST schrieb Aleix Pol:
> We do have several Plasma BoF. I see at least Plasma Discover and
> Plasma Mobile. ;)
Seems like I should have used ctrl+f instead of scrolling over the page and 
looking manually. ;)
> Hardware collaborations should also be related to Plasma IMHO.
> 
> Maybe it would make sense to have one about "Getting started to
> collaborate with Plasma"?
I think that would be a great topic. Do you imagine it as a session that would 
be useful for people who want to start collaborating? 

Regards,
David

Plasma related BoFs at Akademy 2020

[David Redondo]

Hi,

currently I see no Plasma related BoFs at https://community.kde.org/Akademy/
2020/AllBoF . Do you think we should have some specific BoFs and/or a general 
Plasma one? Or maybe you already have a subject that you feel warrants a BoF? 
Then feel free to tell us and add it to the wiki.

Regards,
David

Re: Breakage in Breeze Icons

[David Redondo]

I fixed the build now. There was a symlink to a removed file which
cmake -E copy_directory didn't like.

Regards,
David

Re: dipping a toe in waywater? :)

[David Redondo]

Hello René,

maybe this blog post from Aleix can help you. It explains how to started a 
nested session or wayland session.
https://www.proli.net/2020/04/03/developing-kwin-wayland/ 

Regard, David

D29154: Use QWindow overload of QIcon::pixmap

[David Redondo]

davidre added a comment.


  In my testing dragging a window to a screen with a different scalefactor has 
no issue and @apol said for him it's better than the status quo. So I  would 
like to land this

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

[David Redondo]

davidre added a comment.


  Ping

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29462

To: Zren, #kirigami, mart
Cc: davidre, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29140: Show POTD in lock screen

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> kded_potd.cpp:25
> +delete engine;
> +delete watcher;
> +}

Don't need to delete watcher because you constructed it with `this` as parent. 
https://doc.qt.io/qt-5/objecttrees.html
For the engine don't delete it because you don't have the ownership pof the 
object. The function just returned a pointer to it.

> When the DataEngineConsumer class is deleted, all engines accessed using it 
> are de-referenced and possibly deleted (in the case that there are no other 
> users of the engine in question).

https://api.kde.org/frameworks/plasma-framework/html/classPlasma_1_1DataEngineConsumer.html

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Show POTD in lock screen

[David Redondo]

davidre added a comment.


  Flickr works here F8325269: Screenshot_20200516_095930.png 

  
  > For the leaks, I really have no idea. (also asked some friends but no help) 
C++ isn't my primary programming language. If you can share some 
document/tutorials/examples...
  
  In C++ there is automatic and dynamic storage duration (and some others but 
you don't need to care about them for now). Automatic is the normal when you 
write
  
 void f() {
int i = 0;
[complicated code]
}
  
  i is automatically allocated at the start of the function and deallocated at 
the end of the function. Objects with automatic storage duration are 
deallocated at the end of the scope they were declared in. You can't use a 
variable that you declare in a for loop or inside an if block outside of them 
because the scope they were declared in (the foor loop or the if block) has 
ended. You can also manually create a scope by wrapping code with braces.
  
  Dynamic storage duration happens when you manually allocate memory by writing 
`new Object` or more C-like by calling `malloc` or `calloc`. Here the memory is 
not automatically freed again. It's on the programmer to deallocate it when 
it's no longer needed. You need to call `delete` (or `free` if you used 
`malloc`) to free the memory again.
  
  Here it's not a huge problem because I guess the module will be only 
instantiated once but it's something one should always keep an eye on it. 
Imagine if the class was instantiated multilple times. After some (or longer) 
time your memory would be full because each object allocates a 
`Plasma::DataEngineConsumer` but never frees the corresponding memory even if 
the object itself is destroyed. That's what's called a leak.  You have to call 
`delete consumer` in the destructor of `PotdModule`.
  
  There are some tools that help with memory managment `std::unique_ptr` and 
`QScopePointer` wrap a pointer created with new and will delete it if they are 
destroyed themelves, so you don't forget the delete. `std::shared_ptr` and 
`QSharedPointer` count how many places hold a refrence to it, if noone holds a 
reference anymore the memory is freed. Finally in Qt there is the 
`QObject(QObject *parent)` pattern.  A QObject will delete it this children. So 
if you write `new QWidget(this)` you don't need to care about freeing the 
memory occupied of  the new widget.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Show POTD in lock screen

[David Redondo]

davidre added a comment.


  I don't get how saving as a png fails if we have the image as QImage.

INLINE COMMENTS

> kded_potd.cpp:9
> +{
> +consumer = new Plasma::DataEngineConsumer();
> +engine = consumer->dataEngine(QStringLiteral("potd"));

still leaks

> kded_potd.cpp:28
> + */
> +void PotdModule::dataUpdated(const QString& sourceName, const 
> Plasma::DataEngine::Data& data)
> +{

This method can be removed it's not referenced anywhere.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Show POTD in lock screen

[David Redondo]

davidre added a comment.


  I fail to see what the kded module actually does. Or is it the case that 
simply requesting the data from the engine causes it to cache the image on 
disk? Maybe that should be documented.

INLINE COMMENTS

> CMakeLists.txt:44
>  CoreAddons
> +DBusAddons
>  Declarative

Seems unused?

> CMakeLists.txt:68
>  )
> -
>  add_definitions(

unrelated

> PoTD-list.txt:8
>  where YY is the 2 digits year, MM is the 2 digits month and DD is the 2 
> digits day.
> +Note: sometimes, the webpage shows a YouTube video and picture cannot be 
> fetched.
>  

Unrelated

> cachedprovider.cpp:54
>  const QString path = CachedProvider::identifierToPath( m_identifier );
> -m_image.save(path, "PNG");
> +m_image.save(path, "JPEG");
>  emit done( m_identifier, path, m_image );

Can't we save the image in its original format?

> kded_potd.cpp:3
> +
> +#include 
> +

QDebug

> kded_potd.cpp:10
> +
> +#define COMPONENT_NAME "potd"
> +

unused

> kded_potd.cpp:12
> +
> +K_PLUGIN_FACTORY_WITH_JSON(PotdModuleFactory,
> +   "kded_potd.json",

You can use K_PLUGIN_CLASS_WITH_JSON

> kded_potd.cpp:18
> +{
> +Plasma::DataEngineConsumer *consumer = new Plasma::DataEngineConsumer();
> +engine = consumer->dataEngine(QStringLiteral("potd"));

this leaks

> kded_potd.cpp:34
> +
> +void PotdModule::dataUpdated(const QString& sourceName, const 
> Plasma::DataEngine::Data& data)
> +{

Why don't we care if the data was updated?

> kded_potd.cpp:46
> +engine->connectSource(previousSource, this);
> +watcher->addPath(configPath); // when recreated, it needs to be added to 
> watcher again
> +}

Why?

> kded_potd.cpp:49
> +
> +QString PotdModule::getSource()
> +{

Maybe getProvider or getProviderName no to confuse it with the dataSource?

> kded_potd.cpp:51
> +{
> +KConfig config(configPath);
> +KConfigGroup group = config.group(QStringLiteral("Greeter"))

Couldn't we get the config directly with "kscreenlockerrc" if we use cascading 
either way? No need to seach for the actual path

> kded_potd.h:21
> +
> +public Q_SLOTS:
> +

remove

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29703: Disable horizontal scrollbar in systemtray settings

[David Redondo]

davidre updated this revision to Diff 82728.
davidre added a comment.


  do it for all

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29703?vs=82721&id=82728

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29703

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configTimeZones.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29704: [kcms/baloo] Disable horizonal scrollbar

[David Redondo]

davidre updated this revision to Diff 82727.
davidre added a comment.


  Do it for every scrollview

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29704?vs=82722&id=82727

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29704

AFFECTED FILES
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/baloo/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29704: [kcms/baloo] Disable horizonal scrollbar

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  We need to hardcode it now because of QTBUG-83890.
  CCBUG: 419514

REPOSITORY
  R119 Plasma Desktop

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29704

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29703: Disable horizontal scrollbar in systemtray settings

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  We need to hardcode it now because of QTBUG-83890.
  
  CCBUG: 419514

REPOSITORY
  R120 Plasma Workspace

BRANCH
  scroll (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D29703

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29701: Disable horizontal scrollbar in kcm

[David Redondo]

davidre added a comment.


  Should this go to master, too? Or should we hope that we need the workaround 
only for 5.18 and 5.19 and the qtbug will be fixed eventually?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29701

To: davidre, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29701: Disable horizontal scrollbar in kcm

[David Redondo]

davidre updated this revision to Diff 82719.
davidre added a comment.


  .

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29701?vs=82718&id=82719

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29701

AFFECTED FILES
  kcm/qml/main.qml

To: davidre, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29701: Disable horizontal scrollbar in kcm

[David Redondo]

davidre created this revision.
davidre added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
davidre requested review of this revision.

REVISION SUMMARY
  We need to hardcode it now because of QTBUG-83890.
  CCBUG: 419514

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29701

AFFECTED FILES
  kcm/qml/main.qml

To: davidre, broulik, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:847d9216e0c1: [kcms/keys] Use better collator settings 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29632?vs=82625&id=82626

REVISION DETAIL
  https://phabricator.kde.org/D29632

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[David Redondo]

davidre updated this revision to Diff 82625.
davidre added a comment.


  numeric

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29632?vs=82529&id=82625

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29644: Select application after it is added

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bc5c1d882ed8: Select application after it is added 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29644?vs=82621&id=82624

REVISION DETAIL
  https://phabricator.kde.org/D29644

AFFECTED FILES
  kcms/keys/package/contents/ui/main.qml

To: davidre, broulik, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29579: [kcms/keys] Really ignore unknown action

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:12a14a789da4: [kcms/keys] Really ignore unknown action 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29579?vs=82407&id=82623

REVISION DETAIL
  https://phabricator.kde.org/D29579

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29635: [kcms/keys] Make saving sync

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fcb04768142f: [kcms/keys] Make saving sync (authored by 
davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29635?vs=82535&id=82622

REVISION DETAIL
  https://phabricator.kde.org/D29635

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29644: Select application after it is added

[David Redondo]

davidre updated this revision to Diff 82621.
davidre added a comment.


  Use PropertyAction

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29644?vs=82545&id=82621

BRANCH
  addIndex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29644

AFFECTED FILES
  kcms/keys/package/contents/ui/main.qml

To: davidre, broulik, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29644: Select application after it is added

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  After adding an application, an user will probably want to edit shortcuts for 
  the new application. Having to select it again is cumbersome.

TEST PLAN
  Add an application.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  addIndex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29644

AFFECTED FILES
  kcms/keys/package/contents/ui/main.qml

To: davidre, broulik, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> shortcutsmodel.cpp:89
>  QCollator collator;
> +collator.setCaseSensitivity(Qt::CaseInsensitive);
>  std::sort(m_components.begin(), m_components.end(), 
> [&](const Component &c1, const Component &c2){

We typically don't have apps with numbers but I can also add it?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29635: [kcms/keys] Make saving sync

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  If it's async it will not save when changing modules, or quitting kcmshell, 
see T13140 .
  BUG: 421333

TEST PLAN
  Make a change, change module in systemsettings. Changes are saved.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  syncSave (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29635

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: Use better collator settings

[David Redondo]

davidre created this revision.
davidre added reviewers: ognarb, broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ognarb, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29619: Improve StatusNotifierTest

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5459a533974e: Improve StatusNotifierTest (authored by 
davidre).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29619?vs=82491&id=82521

REVISION DETAIL
  https://phabricator.kde.org/D29619

AFFECTED FILES
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui

To: davidre, kmaterka, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 82519.
davidre added a comment.


  - fix

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=82492&id=82519

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[David Redondo]

davidre added a comment.


  In D29625#668203 , @davidre wrote:
  
  > -1 for khotkeys.
  
  
  Add `X-KDE-Shortcuts`  to the desktop file instead and instal it to 
share/kglobalaccel

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

[David Redondo]

davidre added a comment.


  -1 for khotkeys.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 82492.
davidre added a comment.


  - Rebase without test

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78982&id=82492

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29619: Improve StatusNotifierTest

[David Redondo]

davidre added a comment.


  F8308915: Screenshot_20200511_093148.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29619

To: davidre, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29619: Improve StatusNotifierTest

[David Redondo]

davidre created this revision.
davidre added a reviewer: kmaterka.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
  Makes it easier to test combinations of those.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  snitest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29619

AFFECTED FILES
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui

To: davidre, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29580: [kcms/keys] Also consider portable text when filtering

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Enables searching for "ctrl" or "shift" in non english locale

REPOSITORY
  R119 Plasma Desktop

BRANCH
  portabletext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29580

AFFECTED FILES
  kcms/keys/filteredmodel.cpp

To: davidre, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29579: [kcms/keys] Really ignore unknown action

[David Redondo]

davidre created this revision.
davidre added reviewers: ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise the end() iterator is dereferenced resulting in a crash
  BUG: 421016

TEST PLAN
  Import a predefined scheme

REPOSITORY
  R119 Plasma Desktop

BRANCH
  crash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29579

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1ee6660ceb62: Rewrite of the global shortcuts kcm 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81441&id=81607

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Applications and System Services

[David Redondo]

davidre abandoned this revision.
davidre added a comment.


  Superseeded by total rewrite of the kcm

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma, mlaurent, ngraham
Cc: mlaurent, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre added a comment.


  In D28744#659447 , @ngraham wrote:
  
  > I find that I'm not able to set shortcuts involving the space key. The key 
sequence get repeated twice in the button and the Apply button ever becomes 
enabled. Can you reproduce?
  
  
  That's the current behavior of KeySequenceItem and KKeySequenceWidget. You 
should be able to observe it everywhere such an item is used

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 81441.
davidre added a comment.


  - Reinstate the pointingHand mouseAreas
  - Make delegate automatically expand if it's the only one

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81435&id=81441

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 81435.
davidre added a comment.


  - Make the delegate use states

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81305&id=81435

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[David Redondo]

davidre added a comment.


  I did some digging and think that things should be repainted when they change 
screen
  
https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#_ZN13QWidgetWindow18handleScreenChangeEv

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 81305.
davidre added a comment.


  rebasae

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81304&id=81305

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 81304.
davidre added a comment.


  - Use model.* properties
  - Use placeholder message
  - Still don't know why model properties are undefined when switching 
components

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=81016&id=81304

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Fix POTD in lock screen (partly)

[David Redondo]

davidre added a comment.


  In D29140#656817 , @guoyunhe wrote:
  
  > To totally solve the issue, there are several solutions I can find:
  >
  > 1. POTD need to have a daemon process that can always access network. The 
lock screen send request to the daemon through DBus or other protocol.
  > 2. Create an invisible lock screen widget in the desktop, so it fetches and 
updates the POTD even before screen locks.
  >
  >   The second option is much easier to do. Both will cause some performance 
impact.
  
  
  
  
  2. doesn't sound something like we want do

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[David Redondo]

davidre added a comment.


  Actually everything in the sidebad is very blurry at 2x

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[David Redondo]

davidre added a comment.


  In D29154#656690 , @apol wrote:
  
  > This is what it looks like for me with the patch applied.
  >
  > scale 1x: F8258193: Screenshot_20200424_203628.png 

  >  scale 2x: F8258201: Screenshot_20200424_203729.png 

  >
  > master:
  >  scale 1x: F8258205: Screenshot_20200424_203923.png 

  >  scale 2x:F8258207: Screenshot_20200424_203959.png 

  >
  > I can see a noticeable wonky-ness on 1x master, so I'd say this patch helps.
  
  
  Is master scale 1x the correct image? Also  notice the network icon looks bad 
at 2x in both images

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29157: force systemsettings for kcms

[David Redondo]

davidre added a comment.


  Maybe todo remove?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29157

To: mart, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[David Redondo]

davidre added a comment.


  In D29154#656585 , @apol wrote:
  
  > +1
  >
  > I did the same thing for kirigami @ D29100 
 and plasma-framework @ D29102 
 yesterday after looking at Qt's code and 
assessing it was the right thing to do.
  >  I am not familiar with Breeze's code but the patch is sound.
  >
  > I do have all of the dpis so if you tell me how I'll test it.
  >
  > This should probably fix the BUG 418869.
  
  
  I guess how you tested your patches? Looking at icons on all the dpis?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of QIcon::pixmap

[David Redondo]

davidre updated this revision to Diff 81107.
davidre added a comment.


  Correct code style when I'm touching these lines either way

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29154?vs=81106&id=81107

BRANCH
  window

REVISION DETAIL
  https://phabricator.kde.org/D29154

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29154: Use QWindow overload of icon.pixmap

[David Redondo]

davidre created this revision.
davidre added reviewers: apol, broulik, ndavis, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Previously only the combobox used this overload but that dropped in
  0eaf762705d84fab5c70a8934ffa7cfeadeeebde 
 
because of the changes in
  582f5ebad1686d47168a3246e2aff5beefb59121 
. 
However we should prefer that
  overload because it takes the screen into account on which the icon is 
rendered.
  This reinstates the code removed in 0eaf762 
 as a 
helper function to retrieve the
  window from a window or styleObject.

TEST PLAN
  Icons look correct
  (I don't have a high dpi screen myself but this should be straightforward)

REPOSITORY
  R31 Breeze

BRANCH
  window

REVISION DETAIL
  https://phabricator.kde.org/D29154

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: davidre, apol, broulik, ndavis, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28908: Use the same icon mode calculation for comboboxes as for buttons

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:5a62232415bc: Use the same icon mode calculation for 
comboboxes as for buttons (authored by davidre).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28908?vs=80359&id=81105

REVISION DETAIL
  https://phabricator.kde.org/D28908

AFFECTED FILES
  kstyle/breezestyle.cpp

To: davidre, broulik, #breeze, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29012: Fix variable mixup

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:49cff2127371: Fix variable mixup (authored by davidre).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29012?vs=80657&id=81104

REVISION DETAIL
  https://phabricator.kde.org/D29012

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, #breeze, #plasma, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 81016.
davidre added a comment.


  - Don't drop installing scheme files

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80767&id=81016

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart