D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov added a comment.


  Ohhh, okay, thanks anyway😢

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov added a comment.


  Right, but they can be cherry-picked the the **Plasma 5.19**. In truth, I'm 
tired of editing these files after every Plasma update☹️

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov added a comment.


  In D29818#672942 , @ngraham wrote:
  
  > was landed on master, not 5.19
  
  
  Can it be moved to Plasma 5.19?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

To: epopov, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov created this revision.
epopov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  In D29652 , I made an annoying mistake: I 
removed the check if the clipboard is empty when initializing the 
**Plasmoid.status** of the Clipboard applet. If the user enables the option to 
save clipboard content, then after restarting the Plasma, even if the clipboard 
had content, the state of the applet will be **PlasmaCore.Types.PassiveStatus** 
and its icon will be hidden in the system tray. This patch fixes this issue. I 
hope it will get into Plasma 5.19.
  
  See: https://phabricator.kde.org/D29652

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29818

AFFECTED FILES
  applets/clipboard/contents/ui/clipboard.qml

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-14 Thread Eugene Popov
epopov updated this revision to Diff 82816.
epopov added a comment.


  You're right. Fixed.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29652?vs=82565&id=82816

REVISION DETAIL
  https://phabricator.kde.org/D29652

AFFECTED FILES
  applets/clipboard/contents/ui/clipboard.qml

To: epopov, ngraham, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-11 Thread Eugene Popov
epopov added a comment.


  Currently, the Notifications applet closes itself when the last element 
(notification) is removed (or all elements are removed by pressing "Clear 
History" button in the top-right corner). But also it closes itself, even if 
the applet is pinned, and I guess that this behaviour isn't correct. D29651 
 fixes this issue.
  
  Currently, the Clipboard applet remains visible when the last element 
(fragment) is removed (or all elements are removed by clicking "Clear History" 
button in the top-right corner), even if the applet isn't pinned. D29652 
 makes the Clipboard applet to close itself 
if there are no elements in the clipboard history and it's not pinned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29652

To: epopov, ngraham, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

2020-05-11 Thread Eugene Popov
epopov updated this revision to Diff 82594.
epopov added a comment.


  Fixed.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29651?vs=82563&id=82594

REVISION DETAIL
  https://phabricator.kde.org/D29651

AFFECTED FILES
  applets/notifications/package/contents/ui/main.qml

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-11 Thread Eugene Popov
epopov added a comment.


  I believe that there is a better solution, but I did not come up with it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29652

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D29652: Automatically close Clipboard applet after clearing history or deleting the last element

2020-05-11 Thread Eugene Popov
epopov created this revision.
epopov added reviewers: ngraham, plasma-devel.
Herald added a project: Plasma.
epopov requested review of this revision.

REVISION SUMMARY
  It would be correct to close the Clipboard applet after clearing the history 
or deleting the last element, since there is nothing more to do with the empty 
Clipboard applet (similar to how the Notification applet closes after the last 
notification is removed).
  
  BUG: 421345

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29652

AFFECTED FILES
  applets/clipboard/contents/ui/clipboard.qml

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

2020-05-11 Thread Eugene Popov
epopov created this revision.
epopov added reviewers: ngraham, plasma-devel.
Herald added a project: Plasma.
epopov requested review of this revision.

REVISION SUMMARY
  When I pin a Notifications applet and then remove all notifications, the 
Notifications applet closes itself.
  
  BUG: 421344

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

AFFECTED FILES
  applets/notifications/package/contents/ui/main.qml

To: epopov, ngraham, plasma-devel
Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

2020-04-01 Thread Eugene Popov
epopov added a comment.


  Is it normal that I can close pinned applet by pressing ESC?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28483

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

2020-04-01 Thread Eugene Popov
epopov added a comment.


  Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28483

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

2020-04-01 Thread Eugene Popov
epopov updated this revision to Diff 79046.
epopov added a comment.


  Rebase on **master**

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28483?vs=79045&id=79046

REVISION DETAIL
  https://phabricator.kde.org/D28483

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

2020-04-01 Thread Eugene Popov
epopov created this revision.
epopov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  The previous patch updates the pinned state only for the active applet. For 
instance, if you open the Networks applet and pin it, then switch to the 
Clipboard applet and click on the history item, then the Clipboard applet 
closes. This is because we need to use binding instead of assignment.
  
  See https://phabricator.kde.org/D28408.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28483

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

2020-04-01 Thread Eugene Popov
epopov added a comment.


  The previous patch updates the pinned state only for the active applet. For 
instance, if you open the Networks applet and pin it, then switch to the 
Clipboard applet and click on the history item, then the Clipboard applet 
closes. This is because we need to use binding instead of assignment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

2020-04-01 Thread Eugene Popov
epopov updated this revision to Diff 79034.
epopov added a comment.


  Unfortunately, the previous patch doesn't solve the problem completely, but 
this one should. Can you check it and if everything works well, then replace it 
with the previous one?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=79001&id=79034

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

2020-03-31 Thread Eugene Popov
epopov updated this revision to Diff 78992.
epopov added a comment.


  Rebase on **master**, second edition. Can you try this patch?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78926&id=78992

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

2020-03-31 Thread Eugene Popov
epopov added a comment.


  I have no idea how to test code from **master** branch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

2020-03-30 Thread Eugene Popov
epopov updated this revision to Diff 78926.
epopov added a comment.


  Rebase on **master**

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78827&id=78926

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

2020-03-30 Thread Eugene Popov
epopov added a comment.


  In **Plasma/5.18** branch there was a `Containment.onAppletAdded` handler 
that took the `applet` as a parameter, but can't find this handler in 
**master** branch. Unfortunately, I don’t have enough knowledge of Plasma API 
to know if I can add this handler manually.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

2020-03-30 Thread Eugene Popov
epopov added a comment.


  Can't be rebased on master

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28354: [applets/digital-clock] Fix calendar events not being shown at first

2020-03-30 Thread Eugene Popov
epopov added inline comments.

INLINE COMMENTS

> broulik wrote in CalendarView.qml:154
> Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs 
> since epoch)

How can I compare only the date using your expression?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28354

To: epopov, ngraham, #plasma, vkrause
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28354: [applets/digital-clock] Fix calendar events not being shown at first

2020-03-30 Thread Eugene Popov
epopov updated this revision to Diff 78853.
epopov added a comment.


  Rebase to `master`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28354?vs=78715&id=78853

REVISION DETAIL
  https://phabricator.kde.org/D28354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

2020-03-29 Thread Eugene Popov
epopov updated this revision to Diff 78827.
epopov added a comment.


  Use `hideOnWindowDeactivate` property instead of `configuration.pin`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78805&id=78827

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

2020-03-29 Thread Eugene Popov
epopov added a comment.


  In D28408#637476 , @davidedmundson 
wrote:
  
  > As a question, rather than a researched proposal, is it better to check for 
the pin in?
  >
  > systemtray / PlasmoidItem.qml
  >
  >   Connections {
  >   target: applet
  >   onExpandedChanged: {
  >   
  
  
  We should be able to hide the pinned applet by clicking in the system tray 
(at least this can be done now).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

2020-03-29 Thread Eugene Popov
epopov created this revision.
epopov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  When I pin a Klipper widget and then click on a history item, the Klipper 
widget closes.
  
  To fix this bug, we need to check if Klipped is pinned, but to be able to do 
this, we also need to "forward" the pinned state from the SystemTray applet to 
the Klipper applet.
  
  BUG 416510

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28354: [applets/digital-clock] Fix calendar events not being shown at first

2020-03-28 Thread Eugene Popov
epopov updated this revision to Diff 78715.
epopov added a comment.


  Put the `dateEquals` function outside the `onAgendaUpdated` handler, so it 
can be used elsewhere.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28354?vs=78694&id=78715

REVISION DETAIL
  https://phabricator.kde.org/D28354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28354: [applets/digital-clock] Fix calendar events not being shown at first

2020-03-27 Thread Eugene Popov
epopov updated this revision to Diff 78694.
epopov added a comment.


  Make a function that compares dates inline.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28354?vs=78670&id=78694

REVISION DETAIL
  https://phabricator.kde.org/D28354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28354: Bug 395956: calendar events are not shown at first

2020-03-27 Thread Eugene Popov
epopov created this revision.
epopov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  I noticed that on the first time I bring up the calendar by clicking the 
clock on my Plasma panel, it always shows "No event for today". If I click 
another day on the calendar and then click back on today, it shows today's 
events fine. It should display it correctly the first time.
  
  To fix this bug, we need to compare the date without time.
  
  BUG 395956

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/digital-clock/package/contents/ui/code/tools.js

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28306: [applets/taskmanager] Make the hover state clarifying, but not main

2020-03-27 Thread Eugene Popov
epopov added a comment.


  Thank you, guys!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28306: Make the hover state clarifying, but not main

2020-03-26 Thread Eugene Popov
epopov updated this revision to Diff 78599.
epopov added a comment.


  Fix hover state for pinned launchers

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28306?vs=78580&id=78599

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/code/tools.js

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28306: Make the hover state clarifying, but not main

2020-03-26 Thread Eugene Popov
epopov marked 2 inline comments as done.
epopov added inline comments.

INLINE COMMENTS

> broulik wrote in Task.qml:331
> We can use ECMAScript 6 now, use spread syntax:
> 
>   return [
>   ...TaskTools.taskPrefix(etc),
>   ...foo,
>   ...bar
>   ];
> 
> Note the `...`

TaskTools.taskPrefix(...) returns an array, so it will be an array-of-arrays

> broulik wrote in Task.qml:331
> We can use ECMAScript 6 now, use spread syntax:
> 
>   return [
>   ...TaskTools.taskPrefix(etc),
>   ...foo,
>   ...bar
>   ];
> 
> Note the `...`

Ah, now I understand. It looks amazing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28306: Make the hover state clarifying, but not main

2020-03-26 Thread Eugene Popov
epopov updated this revision to Diff 78580.
epopov added a comment.


  Use ES6 spread syntax 

 instead of Array.concat()

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28306?vs=78568&id=78580

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/code/tools.js

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28306: Make the hover state clarifying, but not main

2020-03-26 Thread Eugene Popov
epopov updated this revision to Diff 78568.
epopov added a comment.


  Create a new function in TasksTools to make the code more readable.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28306?vs=78540&id=78568

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/code/tools.js

To: epopov, davidedmundson, #vdg
Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28306: Make the hover state clarifying, but not main

2020-03-26 Thread Eugene Popov
epopov created this revision.
epopov added reviewers: davidedmundson, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  I'm trying to make a custom appearance of the Task Manager by creating a new 
theme, but I ran into some issue. I expected that there are three main states 
(minimized, normal and active) and one clarifying state (hover). But I was 
surprised to find that there are four main states (minimized, normal, active 
and hover), and the hover state is also main, but not clarifying. I believe 
that the hover state should be clarifying for the main states, i.e. there must 
be three main states (minimized, normal and active) and three additional 
(minimzed-hover, normal-hover, active-hover).
  
  BUG: 418318
  
  See https://phabricator.kde.org/P555

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28306

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: epopov, davidedmundson, #vdg
Cc: epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart