D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Fabian Riethmayer]

fabianr added a comment.


  I would
  
  In D25055#557216 , @hein wrote:
  
  > If we want to keep the handles-on-hover outside of Edit Mode, is there a 
reason it can't be always on and needs to be gated behind a checkbox?
  >
  > I have to admit though I have a hard time seeing users like/rely on this 
behavior. Hovering and just waiting, even once you've learned it's possible, is 
always going to be an unsatisfying user experience - you're literally waiting 
around until the system deigns to approve your intent (long-press, in contrast 
is still //active// to some extent). I'd be worried that some users might learn 
"long hover" as "this is how it's supposed to be done" and then be forever 
annoyed that widgets are so cumbersome to handle. I'd propose removing it and 
fully leading users towards Edit Mode instead?
  
  
  +1
  And long hover is not something that would work with touch devices or is 
common in plasma or other environments, so I don't see a point in introducing a 
new usage pattern, that looks to me quiet cumbersome and problematic.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: fabianr, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24223: [RFC] Add global themes that mimic other platforms' workflows

[Fabian Riethmayer]

fabianr added a comment.


  > It doesn't auto-hide by default in macOS. I decided to make it span the 
full width of the screen because not doing this is IMO one of the dumbest parts 
of that macOS dock, because it pointlessly  wastes the bottom-left-most and 
bottom-right-most pixels, which are two of the four easiest to click pixels in 
the whole screen.
  
  Even if you don't agree with the dock being limited in width, I think you 
still should make it limited. It is one of the most distinct visual aspects of 
the original desktop.
  
  Can Late be used in LnF?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24223: [RFC] Add global themes that mimic other platforms' workflows

[Fabian Riethmayer]

fabianr added a comment.


  > I'd also consider to make the global theme also change plasma theme, color 
scheme or even application style so that it switches to a even more similiar 
interface. If Cupertino global theme switched to a light version of 
https://store.kde.org/p/1252328/, that would be, well, //extraordinary//. In 
such case, I'd also consider the addition of a Fluent theme. Still, I can see 
why this would be much harder.
  
  Please, no other plasma themes, color themes, application styles, icons, ... 
then the default ones in any official LnF. If we ship them as part of a default 
LnF we would need to support them as well. Documenting and fixing all the 
inconsistencies with the default ones is more then enough :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: fabianr, Zren, mmustac, niccolove, rikmills, cblack, broulik, mvourlakos, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Fabian Riethmayer]

fabianr added a comment.


  In D17906#388294 , @filipf wrote:
  
  > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same 
problem.
  >
  > F6531867: image.png 
  >
  > F6531893: image.png 
  >
  > For me this represented a massive regression, and there's bound to be more 
people in a similar situation. We can't have this happening.
  
  
  You are not using the default font, are you?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Fabian Riethmayer]

fabianr added a comment.


  The HIG states: "When the visual design calls for an area of exceptional 
focus, a larger typeface size may be used. In this case use a Light typeface 
weight to keep the stroke width similar to other styles throughout the 
interface"
  
  I think, if you want to have something like F6531451: 
Screenshot_20190107_145258.png  you 
should use your own special sized label. And if you want to add so much focus 
on a text, it can be unique in its font size.
  
  To me it seams the predefined Header[1-4] are mainly to be used for regular 
content and chrome?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17556: Make Status and Notification popup consistent with others.

[Fabian Riethmayer]

fabianr added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:98
>  topMargin: hiddenItemsView.visible ? units.smallSpacing : 0
> -leftMargin: hiddenItemsView.iconColumnWidth + units.largeSpacing;
> +leftMargin: 5
>  }

Please don't use hard coded margins, use smallSpacing instead.

See https://hig.kde.org/layout/units.html

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14238: Polish Notifier Plasmoid's UI

[Fabian Riethmayer]

fabianr added a comment.


  In D14238#295426 , @apol wrote:
  
  > In D14238#295251 , @fabianr 
wrote:
  >
  > > Maybe add a second button "Update" that does update right away without 
viewing the available update list? Most users probably won't be interested in 
which packages are updated, but just want to stay up to date?
  >
  >
  > Then they should use a distribution that upgrades on the background, much 
like snap does.
  
  
  They still might want to choose when to update? Like I would not run updates 
right before some kind of deadline.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14238

To: ngraham, apol, #discover_software_store, #vdg
Cc: fabianr, esedgh, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14238: Polish Notifier Plasmoid's UI

[Fabian Riethmayer]

fabianr added a comment.


  Maybe add a second button "Update" that does update right away without 
viewing the available update list? Most users probably won't be interested in 
which packages are updated, but just want to stay up to date?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14238

To: ngraham, apol, #discover_software_store, #vdg
Cc: fabianr, esedgh, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr closed this revision.

REPOSITORY
  R985 KDE Human Interface Guidelines

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol, 
davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 34275.
fabianr added a comment.


  - removed border around dolphin example in ondemand pattern

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=34271&id=34275

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/desktop-listview.png
  source/img/mobile-listview.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol, 
davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 34271.
fabianr added a comment.


  - moved example image to the top in ondemand pattern

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=33745&id=34271

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/desktop-listview.png
  source/img/mobile-listview.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol, 
davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 33745.
fabianr added a comment.


  - Changed 'How to use' for on demand pattern to incorporate phab feedback

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=33631&id=33745

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/desktop-listview.png
  source/img/mobile-listview.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol, 
davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 33631.
fabianr added a comment.


  - Fixed typo

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=33609&id=33631

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/desktop-listview.png
  source/img/mobile-listview.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr marked an inline comment as done.
fabianr added inline comments.

INLINE COMMENTS

> colomar wrote in ondemand.rst:27
> Since this is a command pattern, shouldn't this link to command patterns 
> instead of navigation patterns?

My intention was to suggest switching to a navigation pattern  like 
"Master-Detail" or "Column-based navigation", so each item has its own content 
page where more actions could easily be displayed.

What kind of command pattern would you suggest could replace the 3+ actions?

REPOSITORY
  R985 KDE Human Interface Guidelines

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 33609.
fabianr added a comment.


  - Updated visuals for listview and folderview

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=32867&id=33609

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/desktop-listview.png
  source/img/mobile-listview.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr added inline comments.

INLINE COMMENTS

> mart wrote in ondemand.rst:11
> maybe add a dolphin screenshot as well with the + on hover? (or folderview)

There is a dolphin screenshot with the hover in the desktop section, (line 48+)

REPOSITORY
  R985 KDE Human Interface Guidelines

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

[Fabian Riethmayer]

fabianr added a comment.


  > to me pinning should mean:
  > 
  > - i say what are the most important tasks to me (regardless if it's for one 
activity or for all activities)
  > - i want them always there, no matter whether running or not
  > - they stay always exactly in the same place (muscle memory) therefore 
can't have text and never move when they are started
  > 
  >   to achieve that, i should do one action, not 2, it looks like bad UI for 
me otherwise.
  
  I would rather not have all the "icon only tasks" as starters ("always show 
entry"), if they are not running. To me a "icon only task" is something I would 
like to apply on tasks, that only have (normally) one instance running, so 
there is no problem with confusing them. They don't have to be the most 
important apps to me at all. Depending on your workflow these might include 
chat apps, ide's,  multimedia editors like krita, kdenlive, kontact ... .
  
  eg I only start Krita every couple of weeks, but I never start it twice so I 
would not need a task bar entry with text. But I don't need a starter for it 
either, since I don't start it very often. To me starters are something 
unrelated. (And they are pretty broken, in my option, when used with multiple 
workspaces and you only show entries from the current workspace in the taskbar, 
but that's probably besides point here)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12462

To: Fuchs, hein
Cc: mart, fabianr, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Fabian Riethmayer]

fabianr added a comment.


  +1
  As soon as there are enough tasks in the task bar, that you can not any 
longer read the title at a glimpse or the tasks start to group the task bar, it 
looses so much of its usefulness. 
  In groups you have to hover , wait, move the mouse and click to activate a 
task and if the labels are too small you either have to wait for the hover or 
guess.
  
  With this possibility to make applications with only one instance open like 
an IDE, a music player, chat, mail, ... to show as icon only in the task bar, 
the point where the tab bar looses it usefulness comes much later.
  
  To mee, this is very similar to pinning tabs in browsers. And in my opinion 
that is one of the best UI improvements in browsers in the recent years. It 
makes tab organization so much clearer, since one can have a lot more tabs open 
before you need to scroll to see all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: fabianr, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 32867.
fabianr added a comment.


  - Merge branch 'master' into swipe
  - added a screenshot for a desktop swipelistitem, small formating change
  - Added png file

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=31867&id=32867

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/swipe.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Fabian Riethmayer]

fabianr added a comment.


  What I don't like is that the menus in the different hierarchy levels can 
have a different size now. To have them in an uniform size gives them a more 
consistent look.
  
  Change all the menus, in all hierarchy levels, to the same dynamic size?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: fabianr, ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11876: Display star ratings

[Fabian Riethmayer]

fabianr added a comment.


  +1 for no line
  
  And if there must be a line, please choose a different color. Plasma blues is 
supposed to be used to indicate possible interaction .

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11876

To: ngraham, apol, #discover_software_store, #vdg
Cc: fabianr, ragreen, acrouthamel, plasma-devel, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Fabian Riethmayer]

fabianr added a comment.


  In D11069#221381 , @zzag wrote:
  
  > So, I'd spent last two hours trying to find good menu shadow params.. HIG 
guidelines don't say too much about shadows(also, navigating them is hard) so I 
don't know whether these shadows are good.
  
  
  As you noticed HIG has very few information on shadows, it would be great if 
the results of this review could also be added to the hig. 
  https://hig.kde.org/resources/contribute.html

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] replace old slide effect with a new one

[Fabian Riethmayer]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, iodelay, bwowk, hardening

D10438: reserve space for checkable widgets in menu items

[Fabian Riethmayer]

fabianr added a comment.


  @zzag It would be greate if you could add a screenshot of the new context 
menu to 
https://community.kde.org/KDE_Visual_Design_Group/HIG/ContextMenu#Examples . Of 
cause other improvements/corrections to the page are more then welcome, too. If 
you hagve question you can ping me on IRC/Telegram in the vdg channel.

REPOSITORY
  R31 Breeze

BRANCH
  menuitem-margins

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Fabian Riethmayer]

fabianr added a comment.


  According to the HIG  units.smallSpacing (4px) or units.largeSpacing (18px) 
or multiples of these should be used when ever possible, maybe it would make 
sense to uses these?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

[Fabian Riethmayer]

fabianr accepted this revision.
fabianr added a comment.
This revision is now accepted and ready to land.


  To keep the notification open when it is not visible is the suggested action 
in the notification draft too:
  https://community.kde.org/Plasma/Notifications#Behaviour_2

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9878

To: broulik, #plasma, hein, graesslin, #vdg, fabianr
Cc: fabianr, abetts, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D9431: [Login / Lock screen] Highlight button when focus or hover

[Fabian Riethmayer]

fabianr added a comment.


  Hover and focus should not have the same visual effect, otherwise a user can 
not distinguish them.
  
  Either
  
  - show only an effect for focus
  - use two different effects, eg underline and highlight
  - handle it like a list and use the same highlight for focus and hover.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9431

To: broulik, #plasma, #vdg, davidedmundson
Cc: fabianr, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D5262: Animate quick tiling outline

[Fabian Riethmayer]

fabianr added a comment.


  +1,  I like the new animation.
  It adds information without introducing any new "clutter" or slow down

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5262

To: broulik, #vdg, #plasma, #kwin
Cc: fabianr, graesslin, plasma-devel, kwin, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D5382: Improve password dialogs

[Fabian Riethmayer]

fabianr added a comment.


  +1, other then the spacing mentioned above, I like the change.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D5382

To: jgrulich, #vdg, #plasma
Cc: fabianr, mart, broulik, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5424: [Notifications] Introduce "settings" action

[Fabian Riethmayer]

fabianr added a comment.


  I like the change, the text button was too striking. the icon is much better

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5424

To: broulik, #vdg, #plasma, markg, mck182
Cc: fabianr, andreaska, mck182, markg, plasma-devel, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5382: Improve password dialogs

[Fabian Riethmayer]

fabianr added a comment.


  It looks like the spacing between the 4 content sections (title, description, 
passwords, buttons) is not always the same. To me it the spacing between title 
- description and password - buttons looks equal, but description - password 
seems to be smaller. I would suggest to increase the spacing between 
description - passwords, so that all 3 spacings are the same.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D5382

To: jgrulich, #plasma, #vdg
Cc: fabianr, mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4960: Pause media players on suspend

[Fabian Riethmayer]

fabianr added a comment.


  Looking good to me.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4960

To: broulik, #plasma, #vdg, graesslin
Cc: fabianr, andreaska, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

[Fabian Riethmayer]

fabianr added a comment.


  The layout looks good and is according to the HIG.
  You probably shouldn't display duplicate information, but if I understood the 
comments correct this is already addressed.
  
  A case could be made that this information is actually the most interesting 
one, and could have a more prominent place, then on the last tab. Would it be 
possible to display the information together with the information of the 
current first tab?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D4614

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #vdg, dfaure, aacid
Cc: fabianr, ltoscano, davidedmundson, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Review Request: Reusable qml components for mediabrowsing

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107861/
---

Review request for Plasma.


Description
---

First reusable qml components for mediabrowsing.
Description of the browsers 
http://community.kde.org/Plasma/Plasma_Media_Center/Media_Browser


Diffs
-

  CMakeLists.txt f7f2366 
  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
 a66123e 
  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/qmldir
 3f2f55d 
  components/CMakeLists.txt PRE-CREATION 
  components/MediaGridBrowser.qml PRE-CREATION 
  components/MediaGridItemDelegate.qml PRE-CREATION 
  components/MediaItemDelegateLogic.js PRE-CREATION 
  components/MediaLineItemDelegate.qml PRE-CREATION 
  components/MediaListBrowser.qml PRE-CREATION 
  components/TabBrowser.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107861/diff/


Testing
---


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

PMC feature free tonight at 23:59 hours UTC

[Fabian, Riethmayer]

Hi!

Just a reminder, PMC goes into a feature free tonight at 23:59 hours 
UTC[1]. If you have new features in a branch, or local clone, merge them 
with master already.


Don't hesitate to ask if someone has a question/concern.

[1] http://community.kde.org/Plasma/Plasma_Media_Center/DecemberMeeting


--

Thanks,
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

PMC tonight at 23:59 hours UTC

[Fabian Riethmayer]

Hi!

Just a reminder, PMC goes into a feature free tonight at 23:59 hours 
UTC[1]. If you have new features in a branch, or local clone, merge them 
with master already.


Don't hesitate to ask if someone has a question/concern.

[1] http://community.kde.org/Plasma/Plasma_Media_Center/DecemberMeeting
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107325/#review21986
---

Ship it!


Ship It!

- Fabian Riethmayer


On Nov. 14, 2012, 12:09 p.m., Fabian Riethmayer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107325/
> ---
> 
> (Updated Nov. 14, 2012, 12:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Show a album cover in the track view if a cover is available.
> At the moment only a placeholder is displayed.
> 
> If all tracks or all tracks of an artist are selected, no cover is displayed.
> 
> 
> Diffs
> -
> 
>   
> browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
>  08735a2 
> 
> Diff: http://git.reviewboard.kde.org/r/107325/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Trackview with cover
>   http://git.reviewboard.kde.org/r/107325/s/831/
> 
> 
> Thanks,
> 
> Fabian Riethmayer
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107325/
---

(Updated Nov. 14, 2012, 12:09 p.m.)


Review request for Plasma.


Changes
---

Fixed hardcoded values.


Description
---

Show a album cover in the track view if a cover is available.
At the moment only a placeholder is displayed.

If all tracks or all tracks of an artist are selected, no cover is displayed.


Diffs (updated)
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
 08735a2 

Diff: http://git.reviewboard.kde.org/r/107325/diff/


Testing
---


Screenshots
---

Trackview with cover
  http://git.reviewboard.kde.org/r/107325/s/831/


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107325/
---

Review request for Plasma.


Description
---

Show a album cover in the track view if a cover is available.
At the moment only a placeholder is displayed.

If all tracks or all tracks of an artist are selected, no cover is displayed.


Diffs
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
 08735a2 

Diff: http://git.reviewboard.kde.org/r/107325/diff/


Testing
---


Screenshots
---

Trackview with cover
  http://git.reviewboard.kde.org/r/107325/s/831/


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rework of metadatamusic qml components.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107299/
---

(Updated Nov. 13, 2012, 11:11 a.m.)


Review request for Plasma.


Changes
---

Screenshoots of artist view and track view.


Description
---

Rework of metadatamusic qml components.
Switched album and artist view to gridview.

Refactored MediaItemDelegate.qml and created new MediaItem.qml


Diffs
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
 5218866 

Diff: http://git.reviewboard.kde.org/r/107299/diff/


Testing
---


Screenshots (updated)
---

Artist view
  http://git.reviewboard.kde.org/r/107299/s/827/
Track view
  http://git.reviewboard.kde.org/r/107299/s/828/


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rework of metadatamusic qml components.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107299/
---

(Updated Nov. 12, 2012, 6:04 p.m.)


Review request for Plasma.


Description
---

Rework of metadatamusic qml components.
Switched album and artist view to gridview.

Refactored MediaItemDelegate.qml and created new MediaItem.qml


Diffs (updated)
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
 5218866 

Diff: http://git.reviewboard.kde.org/r/107299/diff/


Testing
---


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rework of metadatamusic qml components.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107299/
---

(Updated Nov. 12, 2012, 5:36 p.m.)


Review request for Plasma.


Changes
---

Selecting an artist switches to track view.


Description
---

Rework of metadatamusic qml components.
Switched album and artist view to gridview.

Refactored MediaItemDelegate.qml and created new MediaItem.qml


Diffs (updated)
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
 5218866 
  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/qmldir
 3f2f55d 
  components/mediabrowser/MediaItem.qml PRE-CREATION 
  components/mediabrowser/MediaItemDelegate.qml e3fe582 

Diff: http://git.reviewboard.kde.org/r/107299/diff/


Testing
---


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Rework of metadatamusic qml components.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107299/
---

Review request for Plasma.


Description
---

Rework of metadatamusic qml components.
Switched album and artist view to gridview.

Refactored MediaItemDelegate.qml and created new MediaItem.qml


Diffs
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
 5218866 
  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/qmldir
 3f2f55d 
  components/mediabrowser/MediaItem.qml PRE-CREATION 
  components/mediabrowser/MediaItemDelegate.qml e3fe582 

Diff: http://git.reviewboard.kde.org/r/107299/diff/


Testing
---


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105816/
---

(Updated Aug. 6, 2012, 9:17 a.m.)


Review request for Plasma.


Description
---

Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, 
more space between items, a frame for pictures, fixed keyboardinteraction.


Diffs (updated)
-

  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h 
1ba77e7 
  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp 
d4f7449 
  components/mediabrowser/MediaItemDelegate.qml bd181ab 

Diff: http://git.reviewboard.kde.org/r/105816/diff/


Testing
---


Screenshots
---

PMC Pictures
  http://git.reviewboard.kde.org/r/105816/s/660/


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105816/
---

(Updated Aug. 2, 2012, 8:29 a.m.)


Review request for Plasma.


Description
---

Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, 
more space between items, a frame for pictures, fixed keyboardinteraction.


Diffs (updated)
-

  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h 
1ba77e7 
  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp 
d4f7449 
  components/mediabrowser/MediaItemDelegate.qml bd181ab 

Diff: http://git.reviewboard.kde.org/r/105816/diff/


Testing
---


Screenshots
---

PMC Pictures
  http://git.reviewboard.kde.org/r/105816/s/660/


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105816/
---

(Updated Aug. 2, 2012, 8:24 a.m.)


Review request for Plasma.


Changes
---

Fixed indentation and switched fillMode


Description
---

Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, 
more space between items, a frame for pictures, fixed keyboardinteraction.


Diffs (updated)
-

  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h 
1ba77e7 
  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp 
d4f7449 
  components/mediabrowser/MediaItemDelegate.qml bd181ab 

Diff: http://git.reviewboard.kde.org/r/105816/diff/


Testing
---


Screenshots
---

PMC Pictures
  http://git.reviewboard.kde.org/r/105816/s/660/


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105816/
---

(Updated Aug. 1, 2012, 3:02 p.m.)


Review request for Plasma.


Description
---

Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, 
more space between items, a frame for pictures, fixed keyboardinteraction.


Diffs
-

  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h 
1ba77e7 
  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp 
d4f7449 
  components/mediabrowser/MediaItemDelegate.qml bd181ab 

Diff: http://git.reviewboard.kde.org/r/105816/diff/


Testing
---


Screenshots (updated)
---

PMC Pictures
  http://git.reviewboard.kde.org/r/105816/s/660/


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

[Fabian Riethmayer]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105816/
---

Review request for Plasma.


Description
---

Added slot error(QString) for nepomukmusicmodel. Changed MediaItemDelegate.qml, 
more space between items, a frame for pictures, fixed keyboardinteraction.


Diffs
-

  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.h 
1ba77e7 
  browsingbackends/metadatabackends/metadatamusicbackend/nepomukmusicmodel.cpp 
d4f7449 
  components/mediabrowser/MediaItemDelegate.qml bd181ab 

Diff: http://git.reviewboard.kde.org/r/105816/diff/


Testing
---


Thanks,

Fabian Riethmayer

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Switching activities and keeping applications

[Fabian Riethmayer]

Hello,
I was just talking to sebas on IRC about switching activities and "take" all 
my applications with me. He said, it was not (easily) possible at the moment 
to switch between activities and still have all my running applications "with 
me", but I might send my usecase to plasma mailing list.

My usecase:
I have a netbook, normally running with Plasma netbook. If I connect it to a 
big monitor, I switch to a different activity, Plasma Desktop.
At the moment, I have to either asign all applications to all activities one 
by one, or reopen all applications on the other activitiy.

kind regards
Fabian

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel